@fleetbase/fleetops-engine 0.6.58 → 0.6.60

package/server/tests/Feature/Http/Api/TrackingNumberControllerHelpersTest.php

@@ -0,0 +1,160 @@
+<?php
+
+use Fleetbase\FleetOps\Http\Controllers\Api\v1\TrackingNumberController;
+use Fleetbase\FleetOps\Models\TrackingNumber;
+use Illuminate\Database\ConnectionResolver;
+use Illuminate\Database\Eloquent\Model as EloquentModel;
+use Illuminate\Database\SQLiteConnection;
+
+/**
+ * Covers the TrackingNumberController protected helper bodies against
+ * SQLite: owner uuid lookups, tracking number creation and lookup,
+ * resource wrappers, qr-model resolution and the json response helper.
+ */
+if (!function_exists('Fleetbase\\Support\\session')) {
+    eval('namespace Fleetbase\\Support; function session($key = null, $default = null) { if ($key === null) { return new class { public function has($k) { return \\session($k) !== null; } public function get($k, $d = null) { return \\session($k, $d); } }; } return \\session($key, $default); }');
+}
+
+if (!function_exists('Fleetbase\\Support\\auth')) {
+    eval('namespace Fleetbase\\Support; function auth() { return new class { public function user() { return null; } public function id() { return null; } }; }');
+}
+
+if (!function_exists('Fleetbase\\Observers\\event')) {
+    eval('namespace Fleetbase\\Observers; function event($event = null, $payload = []) { return []; }');
+}
+
+function fleetopsTrackingNumberHelpersBoot(): SQLiteConnection
+{
+    if (!Illuminate\Support\Str::hasMacro('humanize')) {
+        Illuminate\Support\Str::macro('humanize', fn ($value, $uppercase = true) => str_replace('_', ' ', Illuminate\Support\Str::snake((string) $value)));
+    }
+    $connection = new SQLiteConnection(new PDO('sqlite::memory:'));
+    $resolver   = new ConnectionResolver(['default' => $connection, 'mysql' => $connection]);
+    $resolver->setDefaultConnection('mysql');
+    EloquentModel::setConnectionResolver($resolver);
+    if (!EloquentModel::getEventDispatcher()) {
+        EloquentModel::setEventDispatcher(new Illuminate\Events\Dispatcher());
+    }
+    app()->instance('db', new class($connection) {
+        public function __construct(public SQLiteConnection $c)
+        {
+        }
+
+        public function connection($name = null): SQLiteConnection
+        {
+            return $this->c;
+        }
+
+        public function __call($method, $arguments)
+        {
+            return $this->c->{$method}(...$arguments);
+        }
+    });
+    Illuminate\Support\Facades\DB::clearResolvedInstance('db');
+
+    $barcodeFake = new class {
+        public function __call($method, $arguments)
+        {
+            return 'barcode';
+        }
+    };
+    app()->instance('DNS2D', $barcodeFake);
+    app()->instance('DNS1D', $barcodeFake);
+    app()->instance('responsecache', new class {
+        public function __call($method, $arguments)
+        {
+            return null;
+        }
+    });
+    config()->set('activitylog.enabled', false);
+    config()->set('activitylog.default_auth_driver', 'web');
+    app()->bind(Illuminate\Contracts\Config\Repository::class, fn () => config());
+
+    $schema = $connection->getSchemaBuilder();
+    $tables = [
+        'tracking_numbers'  => ['uuid', 'public_id', 'company_uuid', 'tracking_number', 'owner_uuid', 'owner_type', 'region', 'barcode', 'qr_code', 'status_uuid', 'type', '_key'],
+        'entities'          => ['uuid', 'public_id', 'company_uuid', 'name', 'type', 'internal_id', 'tracking_number_uuid', 'payload_uuid', 'customer_uuid', 'customer_type', 'meta', '_key'],
+        'orders'            => ['uuid', 'public_id', 'company_uuid', 'internal_id', 'payload_uuid', 'status', 'type', 'meta', '_key'],
+        'tracking_statuses' => ['uuid', 'public_id', 'company_uuid', 'tracking_number_uuid', 'code', 'status', 'details', 'location', 'city', 'province', 'country', '_key'],
+    ];
+    foreach ($tables as $table => $columns) {
+        $schema->create($table, function ($blueprint) use ($columns) {
+            $blueprint->increments('id');
+            foreach ($columns as $column) {
+                $blueprint->string($column)->nullable();
+            }
+            $blueprint->timestamps();
+            $blueprint->timestamp('deleted_at')->nullable();
+        });
+    }
+
+    session(['company' => 'company-1']);
+
+    return $connection;
+}
+
+test('tracking number helpers look up owners create records and wrap resources', function () {
+    $connection = fleetopsTrackingNumberHelpersBoot();
+    $connection->table('orders')->insert(['uuid' => '44444444-4444-4444-8444-444444444401', 'public_id' => 'order_tnhelper1', 'company_uuid' => 'company-1', 'status' => 'created']);
+    $connection->table('entities')->insert(['uuid' => '44444444-4444-4444-8444-444444444402', 'public_id' => 'entity_tnhelper1', 'company_uuid' => 'company-1', 'name' => 'Tracked Entity']);
+
+    $controller = new TrackingNumberController();
+    $helper     = function (string $method, ...$arguments) use ($controller) {
+        $reflection = new ReflectionMethod(TrackingNumberController::class, $method);
+        $reflection->setAccessible(true);
+
+        return $reflection->invoke($controller, ...$arguments);
+    };
+
+    // Owner uuid resolution reads through Utils::getUuid
+    $ownerUuid = $helper('getOwnerUuid', ['orders'], ['public_id' => 'order_tnhelper1', 'company_uuid' => 'company-1'], []);
+    expect($ownerUuid)->toBe('44444444-4444-4444-8444-444444444401');
+
+    // Creation persists a tracking number row
+    $trackingNumber = $helper('createTrackingNumber', [
+        'company_uuid'    => 'company-1',
+        'tracking_number' => 'FLB-HELPER-1',
+        'owner_uuid'      => '44444444-4444-4444-8444-444444444401',
+        'owner_type'      => Fleetbase\FleetOps\Models\Order::class,
+        'region'          => 'SG',
+    ]);
+    expect($trackingNumber)->toBeInstanceOf(TrackingNumber::class)
+        ->and($connection->table('tracking_numbers')->count())->toBe(1);
+
+    // Lookup finds persisted tracking numbers by uuid
+    $uuid  = (string) $connection->table('tracking_numbers')->value('uuid');
+    $found = $helper('findTrackingNumber', $uuid);
+    expect($found)->toBeInstanceOf(TrackingNumber::class)
+        ->and($found->tracking_number)->toBe('FLB-HELPER-1');
+
+    // Resource wrappers and the json helper
+    expect($helper('trackingNumberResource', $found))->toBeInstanceOf(Fleetbase\FleetOps\Http\Resources\v1\TrackingNumber::class)
+        ->and($helper('trackingNumberResourceCollection', collect([$found])))->toBeInstanceOf(Illuminate\Http\Resources\Json\ResourceCollection::class)
+        ->and($helper('deletedTrackingNumberResource', $found))->toBeInstanceOf(Fleetbase\FleetOps\Http\Resources\v1\DeletedResource::class)
+        ->and($helper('jsonResponse', ['ok' => true], 200))->toBeInstanceOf(Illuminate\Http\JsonResponse::class);
+
+    // Qr model resolution finds models and wraps them in fleet-ops v1 resources
+    $qrModel = $helper('findQrModel', ['entities'], ['public_id' => 'entity_tnhelper1']);
+    expect($qrModel)->not->toBeNull()
+        ->and($helper('qrModelResource', $qrModel))->toBeInstanceOf(Fleetbase\FleetOps\Http\Resources\v1\Entity::class);
+
+    // A table with no eloquent mapping resolves to null rather than a raw row.
+    //
+    // The raw-row fallback was removed: it passed the ARRAY of table names to
+    // DB::table(), which stringified it to the literal table "Array" and threw
+    // SQLSTATE[42S02], so every unresolvable QR code answered 500 instead of the 400 the
+    // caller already handles. It could not have helped either way — qrModelResource()
+    // serializes through a typed resource keyed on the model class, and a raw stdClass
+    // row has none.
+    $connection->table('tracking_statuses')->insert([
+        'uuid'      => '44444444-4444-4444-8444-444444444403',
+        'public_id' => 'tracking_status_tnhelper1',
+        'code'      => 'DISPATCHED',
+        'status'    => 'Dispatched',
+    ]);
+
+    expect($helper('findQrModel', ['tracking_statuses'], ['public_id' => 'tracking_status_tnhelper1']))->toBeNull()
+        // And a mapped table that simply matches nothing is also null, which is the path
+        // an unknown or unresolved code takes.
+        ->and($helper('findQrModel', ['entities', 'orders'], ['uuid' => '{{qr_code}}']))->toBeNull();
+});

package/server/tests/Feature/Http/Api/TrackingStatusControllerHelpersTest.php

@@ -0,0 +1,165 @@
+<?php
+
+use Fleetbase\FleetOps\Http\Controllers\Api\v1\TrackingStatusController;
+use Fleetbase\FleetOps\Models\TrackingStatus;
+use Illuminate\Database\ConnectionResolver;
+use Illuminate\Database\Eloquent\Model as EloquentModel;
+use Illuminate\Database\SQLiteConnection;
+
+/**
+ * Covers the TrackingStatusController protected helper bodies against
+ * SQLite: status code preparation, tracking-number lookups by table and
+ * order, status creation and lookup, and the resource wrappers.
+ */
+if (!function_exists('Fleetbase\Support\session')) {
+    eval('namespace Fleetbase\Support; function session($key = null, $default = null) { if ($key === null) { return new class { public function has($k) { return \session($k) !== null; } public function get($k, $d = null) { return \session($k, $d); } }; } return \session($key, $default); }');
+}
+
+if (!function_exists('Fleetbase\Observers\event')) {
+    eval('namespace Fleetbase\Observers; function event($event = null, $payload = []) { return []; }');
+}
+
+function fleetopsTrackingStatusHelpersBoot(): SQLiteConnection
+{
+    if (!Illuminate\Support\Str::hasMacro('humanize')) {
+        Illuminate\Support\Str::macro('humanize', fn ($value, $uppercase = true) => str_replace('_', ' ', Illuminate\Support\Str::snake((string) $value)));
+    }
+    $pdo = new PDO('sqlite::memory:');
+    foreach (['ST_PointFromText', 'ST_GeomFromText'] as $fn) {
+        $pdo->sqliteCreateFunction($fn, fn ($wkt, $srid = 0, $axisOrder = null) => $wkt);
+    }
+    $connection = new SQLiteConnection($pdo);
+    $resolver   = new ConnectionResolver(['default' => $connection, 'mysql' => $connection]);
+    $resolver->setDefaultConnection('mysql');
+    EloquentModel::setConnectionResolver($resolver);
+    if (!EloquentModel::getEventDispatcher()) {
+        EloquentModel::setEventDispatcher(new Illuminate\Events\Dispatcher());
+    }
+    app()->instance('db', new class($connection) {
+        public function __construct(public SQLiteConnection $c)
+        {
+        }
+
+        public function connection($name = null): SQLiteConnection
+        {
+            return $this->c;
+        }
+
+        public function __call($method, $arguments)
+        {
+            return $this->c->{$method}(...$arguments);
+        }
+    });
+    app()->instance('db.schema', $connection->getSchemaBuilder());
+    Illuminate\Support\Facades\DB::clearResolvedInstance('db');
+    app()->instance('responsecache', new class {
+        public function __call($method, $arguments)
+        {
+            return null;
+        }
+    });
+    config()->set('activitylog.enabled', false);
+    config()->set('activitylog.default_auth_driver', 'web');
+    app()->bind(Illuminate\Contracts\Config\Repository::class, fn () => config());
+
+    $schema = $connection->getSchemaBuilder();
+    $tables = [
+        'tracking_statuses' => ['uuid', 'public_id', 'company_uuid', 'tracking_number_uuid', 'code', 'status', 'details', 'location', 'city', 'province', 'country', 'proof_uuid', '_key'],
+        'tracking_numbers'  => ['uuid', 'public_id', 'company_uuid', 'tracking_number', 'owner_uuid', 'owner_type', 'region', 'barcode', 'qr_code', 'status_uuid', 'type', '_key'],
+        'orders'            => ['uuid', 'public_id', 'company_uuid', 'internal_id', 'payload_uuid', 'tracking_number_uuid', 'status', 'type', 'meta', '_key'],
+    ];
+    foreach ($tables as $table => $columns) {
+        $schema->create($table, function ($blueprint) use ($columns) {
+            $blueprint->increments('id');
+            foreach ($columns as $column) {
+                $blueprint->string($column)->nullable();
+            }
+            $blueprint->timestamps();
+            $blueprint->timestamp('deleted_at')->nullable();
+        });
+    }
+
+    session(['company' => 'company-1']);
+
+    return $connection;
+}
+
+test('tracking status helpers prepare codes look up numbers and wrap resources', function () {
+    $connection = fleetopsTrackingStatusHelpersBoot();
+    $connection->table('tracking_numbers')->insert(['uuid' => '88888888-8888-4888-8888-888888888801', 'public_id' => 'tracking_number_tshelper', 'company_uuid' => 'company-1', 'tracking_number' => 'FLB-TS-1']);
+    $connection->table('orders')->insert(['uuid' => '88888888-8888-4888-8888-888888888802', 'public_id' => 'order_tshelper1', 'company_uuid' => 'company-1', 'tracking_number_uuid' => '88888888-8888-4888-8888-888888888801', 'status' => 'created']);
+
+    $controller = new TrackingStatusController();
+    $helper     = function (string $method, ...$arguments) use ($controller) {
+        $reflection = new ReflectionMethod(TrackingStatusController::class, $method);
+        $reflection->setAccessible(true);
+
+        return $reflection->invoke($controller, ...$arguments);
+    };
+
+    // Status codes normalize through the model helper
+    expect($helper('prepareTrackingStatusCode', 'In Transit'))->toBeString()->not->toBeEmpty();
+
+    // Tracking-number lookups by table and by order public id
+    expect($helper('getTrackingNumberUuid', 'tracking_numbers', ['public_id' => 'tracking_number_tshelper', 'company_uuid' => 'company-1']))->toBe('88888888-8888-4888-8888-888888888801')
+        ->and($helper('getOrderTrackingNumberUuid', 'order_tshelper1'))->toBe('88888888-8888-4888-8888-888888888801');
+
+    // Creation persists a status row and lookups rehydrate it
+    $status = $helper('createTrackingStatus', [
+        'company_uuid'         => 'company-1',
+        'tracking_number_uuid' => '88888888-8888-4888-8888-888888888801',
+        'status'               => 'In Transit',
+        'code'                 => 'IN_TRANSIT',
+        'details'              => 'Package moving',
+    ]);
+    expect($status)->toBeInstanceOf(TrackingStatus::class)
+        ->and($connection->table('tracking_statuses')->count())->toBe(1);
+
+    $publicId = (string) $connection->table('tracking_statuses')->value('public_id');
+    $found    = $helper('findTrackingStatus', $publicId);
+    expect($found)->toBeInstanceOf(TrackingStatus::class)
+        ->and($found->code)->toBe('IN_TRANSIT');
+
+    // Resource wrappers and the json helper
+    expect($helper('trackingStatusResource', $found))->toBeInstanceOf(Fleetbase\FleetOps\Http\Resources\v1\TrackingStatus::class)
+        ->and($helper('trackingStatusResourceCollection', collect([$found])))->toBeInstanceOf(Illuminate\Http\Resources\Json\ResourceCollection::class)
+        ->and($helper('jsonResponse', ['ok' => true], 200))->toBeInstanceOf(Illuminate\Http\JsonResponse::class);
+    $deleted = $helper('deletedTrackingStatusResource', $found);
+    expect($deleted)->not->toBeNull();
+});
+
+test('unique status rule detects statuses already applied through orders', function () {
+    $connection = fleetopsTrackingStatusHelpersBoot();
+    $connection->table('tracking_numbers')->insert(['uuid' => '88888888-8888-4888-8888-888888888811', 'public_id' => 'tracking_number_uniq1', 'company_uuid' => 'company-1', 'tracking_number' => 'FLB-UNIQ-1']);
+    $connection->table('orders')->insert(['uuid' => '88888888-8888-4888-8888-888888888812', 'public_id' => 'order_uniqone1', 'company_uuid' => 'company-1', 'tracking_number_uuid' => '88888888-8888-4888-8888-888888888811', 'status' => 'created']);
+    $connection->table('tracking_statuses')->insert(['uuid' => '88888888-8888-4888-8888-888888888813', 'company_uuid' => 'company-1', 'tracking_number_uuid' => '88888888-8888-4888-8888-888888888811', 'code' => 'IN_TRANSIT', 'status' => 'In Transit']);
+
+    $makeRule = function (array $input) {
+        $request    = Fleetbase\FleetOps\Http\Requests\CreateTrackingStatusRequest::create('/v1/tracking-statuses', 'POST', $input);
+        $reflection = new ReflectionMethod(Fleetbase\FleetOps\Http\Requests\CreateTrackingStatusRequest::class, 'uniqueStatus');
+        $reflection->setAccessible(true);
+
+        return $reflection->invoke(null, $request);
+    };
+
+    // Orders whose tracking number already carries the status fail the rule
+    $failures = [];
+    $rule     = $makeRule(['order' => 'order_uniqone1', 'status' => 'in transit']);
+    $rule('status', 'in transit', function ($message) use (&$failures) {
+        $failures[] = $message;
+    });
+    expect($failures)->toHaveCount(1)
+        ->and($failures[0])->toContain('already been applied');
+
+    // Fresh statuses pass, and duplicate mode bypasses the check entirely
+    $cleanFailures = [];
+    $cleanRule     = $makeRule(['order' => 'order_uniqone1', 'status' => 'delivered']);
+    $cleanRule('status', 'delivered', function ($message) use (&$cleanFailures) {
+        $cleanFailures[] = $message;
+    });
+    $duplicateRule = $makeRule(['order' => 'order_uniqone1', 'status' => 'in transit', 'duplicate' => '1']);
+    $duplicateRule('status', 'in transit', function ($message) use (&$cleanFailures) {
+        $cleanFailures[] = $message;
+    });
+    expect($cleanFailures)->toBe([]);
+});