@fleetbase/fleetops-engine 0.6.51 → 0.6.53

package/server/src/Http/Controllers/Internal/v1/TelematicController.php

@@ -6,6 +6,7 @@ use Fleetbase\FleetOps\Http\Controllers\FleetOpsController;
 use Fleetbase\FleetOps\Models\Telematic;
 use Fleetbase\FleetOps\Support\Telematics\TelematicProviderRegistry;
 use Fleetbase\FleetOps\Support\Telematics\TelematicService;
+use Fleetbase\Models\Activity;
 use Illuminate\Http\JsonResponse;
 use Illuminate\Http\Request;
 
@@ -54,9 +55,7 @@ class TelematicController extends FleetOpsController
      */
     public function testConnection(Request $request, string $id): JsonResponse
     {
-        $telematic = Telematic::where('uuid', $id)
-            ->where('company_uuid', session('company'))
-            ->firstOrFail();
+        $telematic = $this->findTelematic($id);
 
         $async = $request->input('async', false);
 
@@ -82,7 +81,16 @@ class TelematicController extends FleetOpsController
             if (!$provider) {
                 return response()->error('Unable to resolve telematic provider.');
             }
-            $result   = $provider->testConnection($credentials);
+            $result      = $provider->testConnection($credentials);
+            $telematicId = $request->input('telematic_id');
+
+            if ($telematicId) {
+                $telematic = $this->findTelematic($telematicId);
+
+                if ($telematic->provider === $key) {
+                    $this->telematicService->recordConnectionTest($telematic, $result);
+                }
+            }
         } catch (\Exception $e) {
             return response()->error($e->getMessage());
         }
@@ -99,12 +107,10 @@ class TelematicController extends FleetOpsController
      */
     public function discover(Request $request, string $id): JsonResponse
     {
-        $telematic = Telematic::where('uuid', $id)
-            ->where('company_uuid', session('company'))
-            ->firstOrFail();
+        $telematic = $this->findTelematic($id);
 
         $jobId = $this->telematicService->discoverDevices($telematic, [
-            'limit'   => $request->input('limit', 100),
+            'limit'   => $request->input('limit'),
             'filters' => $request->input('filters', []),
         ]);
 
@@ -119,9 +125,7 @@ class TelematicController extends FleetOpsController
      */
     public function devices(Request $request, string $id): JsonResponse
     {
-        $telematic = Telematic::where('uuid', $id)
-            ->where('company_uuid', session('company'))
-            ->firstOrFail();
+        $telematic = $this->findTelematic($id);
 
         $devices = $this->telematicService->getDevices($telematic, [
             'status' => $request->input('status'),
@@ -133,18 +137,44 @@ class TelematicController extends FleetOpsController
         ]);
     }
 
+    /**
+     * Get persisted logs and audit entries for a telematic.
+     */
+    public function logs(Request $request, string $id): JsonResponse
+    {
+        $telematic = $this->findTelematic($id);
+        $limit     = min((int) $request->input('limit', 50), 100);
+
+        $activityLogs = Activity::with(['causer'])
+            ->where('subject_type', Telematic::class)
+            ->where('subject_id', $telematic->uuid)
+            ->latest()
+            ->limit($limit)
+            ->get()
+            ->map(fn (Activity $activity) => $this->makeActivityLogEntry($activity));
+
+        $logs = $this->makeTelematicMetadataLogs($telematic)
+            ->merge($activityLogs)
+            ->sortByDesc(fn ($log) => $log['created_at'] ?? '')
+            ->values();
+
+        return response()->json([
+            'logs' => $logs,
+        ]);
+    }
+
     /**
      * Link a device to a telematic.
      */
     public function linkDevice(Request $request, string $id): JsonResponse
     {
-        $telematic = Telematic::where('uuid', $id)
-            ->where('company_uuid', session('company'))
-            ->firstOrFail();
+        $telematic = $this->findTelematic($id);
 
         $request->validate([
-            'external_id' => 'required|string',
-            'device_name' => 'required|string',
+            'external_id' => 'required_without:device_id|nullable|string',
+            'device_id'   => 'required_without:external_id|nullable|string',
+            'device_name' => 'nullable|string',
+            'name'        => 'nullable|string',
         ]);
 
         $device = $this->telematicService->linkDevice($telematic, $request->all());
@@ -153,4 +183,137 @@ class TelematicController extends FleetOpsController
             'device' => $device,
         ], 201);
     }
+
+    protected function findTelematic(string $id): Telematic
+    {
+        return Telematic::where(function ($query) use ($id) {
+            $query->where('uuid', $id)->orWhere('public_id', $id);
+        })
+            ->where('company_uuid', session('company'))
+            ->firstOrFail();
+    }
+
+    protected function makeTelematicMetadataLogs(Telematic $telematic)
+    {
+        $meta = $telematic->meta ?? [];
+        $logs = collect();
+
+        if (data_get($meta, 'last_sync_result')) {
+            $result = data_get($meta, 'last_sync_result');
+            $failed = $result === 'failed';
+
+            $logs->push([
+                'id'          => 'sync-' . (data_get($meta, 'last_sync_job_id') ?? data_get($meta, 'last_sync_completed_at') ?? data_get($meta, 'last_sync_failed_at') ?? $telematic->uuid),
+                'type'        => 'sync_' . $result,
+                'label'       => $failed ? 'Device sync failed' : ($result === 'queued' ? 'Device sync queued' : 'Device sync completed'),
+                'description' => $failed
+                    ? $this->userFacingIssueMessage(data_get($meta, 'last_sync_error'), 'Device sync failed. Review the provider connection and server logs, then try again.')
+                    : $this->syncSuccessDescription($meta),
+                'status'      => $failed ? 'warning' : ($result === 'queued' ? 'info' : 'success'),
+                'icon'        => $failed ? 'circle-exclamation' : 'satellite-dish',
+                'created_at'  => data_get($meta, 'last_sync_failed_at') ?? data_get($meta, 'last_sync_completed_at') ?? data_get($meta, 'last_sync_started_at'),
+                'actor_name'  => null,
+                'metadata'    => [
+                    'job_id'       => data_get($meta, 'last_sync_job_id'),
+                    'result'       => $result,
+                    'total'        => data_get($meta, 'last_sync_total'),
+                    'error_type'   => data_get($meta, 'last_sync_error_type'),
+                    'started_at'   => data_get($meta, 'last_sync_started_at'),
+                    'completed_at' => data_get($meta, 'last_sync_completed_at'),
+                    'failed_at'    => data_get($meta, 'last_sync_failed_at'),
+                ],
+            ]);
+        }
+
+        if (data_get($meta, 'last_test_result')) {
+            $result = data_get($meta, 'last_test_result');
+            $failed = $result === 'failed';
+
+            $logs->push([
+                'id'          => 'connection-test-' . (data_get($meta, 'last_connection_test') ?? $telematic->uuid),
+                'type'        => 'connection_test_' . $result,
+                'label'       => $failed ? 'Connection test failed' : 'Connection test verified',
+                'description' => $failed
+                    ? $this->userFacingIssueMessage(data_get($meta, 'last_error'), 'Connection test failed. Review the provider credentials and try again.')
+                    : 'Provider credentials were verified successfully.',
+                'status'      => $failed ? 'warning' : 'success',
+                'icon'        => 'plug',
+                'created_at'  => data_get($meta, 'last_connection_test'),
+                'actor_name'  => null,
+                'metadata'    => [
+                    'result' => $result,
+                ],
+            ]);
+        }
+
+        return $logs;
+    }
+
+    protected function makeActivityLogEntry(Activity $activity): array
+    {
+        return [
+            'id'          => $activity->uuid ?? $activity->id,
+            'type'        => 'activity_' . ($activity->event ?? 'updated'),
+            'label'       => $this->activityLogLabel($activity),
+            'description' => $this->activityLogDescription($activity),
+            'status'      => $activity->event === 'deleted' ? 'warning' : 'default',
+            'icon'        => $activity->event === 'created' ? 'plus' : 'history',
+            'created_at'  => $activity->created_at,
+            'actor_name'  => data_get($activity, 'causer.name'),
+            'metadata'    => [
+                'event' => $activity->event,
+            ],
+        ];
+    }
+
+    protected function activityLogLabel(Activity $activity): string
+    {
+        return match ($activity->event) {
+            'created' => 'Provider connection created',
+            'deleted' => 'Provider connection deleted',
+            default   => 'Provider connection updated',
+        };
+    }
+
+    protected function activityLogDescription(Activity $activity): string
+    {
+        return match ($activity->event) {
+            'created' => 'Provider connection details were created.',
+            'deleted' => 'Provider connection details were removed.',
+            default   => 'Provider connection details were updated.',
+        };
+    }
+
+    protected function syncSuccessDescription(array $meta): string
+    {
+        $total = data_get($meta, 'last_sync_total');
+
+        if (is_numeric($total)) {
+            return "{$total} provider devices were synced.";
+        }
+
+        return 'Provider device sync completed successfully.';
+    }
+
+    protected function userFacingIssueMessage($message, string $fallback): string
+    {
+        if (!$message || $this->isSensitiveIssueMessage($message)) {
+            return $fallback;
+        }
+
+        return (string) $message;
+    }
+
+    protected function isSensitiveIssueMessage($message): bool
+    {
+        $value = strtolower((string) $message);
+
+        foreach (['sqlstate', 'insert into', 'update `', 'select ', 'schema', 'stack trace', 'connection:', 'pdoexception'] as $fragment) {
+            if (str_contains($value, $fragment)) {
+                return true;
+            }
+        }
+
+        return false;
+    }
 }

package/server/src/Http/Controllers/Internal/v1/VehicleController.php

@@ -4,14 +4,19 @@ namespace Fleetbase\FleetOps\Http\Controllers\Internal\v1;
 
 use Fleetbase\FleetOps\Exports\VehicleExport;
 use Fleetbase\FleetOps\Http\Controllers\FleetOpsController;
+use Fleetbase\FleetOps\Http\Resources\v1\Index\Order as IndexOrderResource;
 use Fleetbase\FleetOps\Imports\VehicleImport;
+use Fleetbase\FleetOps\Models\Device;
 use Fleetbase\FleetOps\Models\Driver;
+use Fleetbase\FleetOps\Models\Order;
 use Fleetbase\FleetOps\Models\Vehicle;
 use Fleetbase\Http\Requests\ExportRequest;
 use Fleetbase\Http\Requests\ImportRequest;
+use Illuminate\Http\JsonResponse;
 use Illuminate\Http\Request;
 use Illuminate\Support\Arr;
 use Illuminate\Support\Facades\DB;
+use Illuminate\Support\Facades\Log;
 use Illuminate\Support\Str;
 use Maatwebsite\Excel\Facades\Excel;
 
@@ -86,6 +91,250 @@ class VehicleController extends FleetOpsController
         }
     }
 
+    public function assignDriver(Request $request, string $id): JsonResponse
+    {
+        $request->validate(['driver' => 'required|string']);
+
+        $vehicle = $this->findVehicle($id);
+        $driver  = $this->findDriver($request->input('driver'));
+
+        $vehicle->assignDriver($driver);
+        $vehicle->load(['driver', 'devices']);
+
+        return response()->json([
+            'status'  => 'ok',
+            'message' => 'Driver assigned to vehicle.',
+            'vehicle' => $vehicle,
+        ]);
+    }
+
+    public function unassignDriver(string $id): JsonResponse
+    {
+        $vehicle = $this->findVehicle($id);
+        $vehicle->unassignDriver();
+        $vehicle->load(['driver', 'devices']);
+
+        return response()->json([
+            'status'  => 'ok',
+            'message' => 'Driver unassigned from vehicle.',
+            'vehicle' => $vehicle,
+        ]);
+    }
+
+    public function assignedOrders(string $id): JsonResponse
+    {
+        $vehicle = $this->findVehicle($id);
+        $orders  = Order::where('vehicle_assigned_uuid', $vehicle->uuid)
+            ->where('company_uuid', session('company'))
+            ->with(['payload', 'trackingNumber', 'orderConfig', 'driverAssigned', 'vehicleAssigned'])
+            ->orderByRaw('uuid = ? desc', [$this->activeOrderUuid($vehicle)])
+            ->latest()
+            ->get();
+
+        return response()->json([
+            'status'  => 'ok',
+            'vehicle' => $vehicle->fresh(['driver', 'devices']),
+            'orders'  => IndexOrderResource::collection($orders)->resolve(),
+            'current' => $this->activeOrderUuid($vehicle),
+            'count'   => $orders->count(),
+        ]);
+    }
+
+    public function unassignOrders(Request $request, string $id): JsonResponse
+    {
+        $request->validate([
+            'orders'   => 'required|array|min:1',
+            'orders.*' => 'required|string',
+        ]);
+
+        $vehicle = $this->findVehicle($id);
+        $ids     = collect($request->input('orders'))->filter()->unique()->values();
+        $orders  = Order::where('vehicle_assigned_uuid', $vehicle->uuid)
+            ->where('company_uuid', session('company'))
+            ->where(function ($query) use ($ids) {
+                $query->whereIn('uuid', $ids)->orWhereIn('public_id', $ids);
+            })
+            ->get();
+
+        if ($orders->isEmpty()) {
+            return response()->error('No assigned orders were selected for this vehicle.');
+        }
+
+        DB::transaction(function () use ($orders): void {
+            Order::whereIn('uuid', $orders->pluck('uuid'))->update([
+                'vehicle_assigned_uuid' => null,
+                'updated_at'            => now(),
+            ]);
+        });
+
+        return response()->json([
+            'status'  => 'ok',
+            'message' => 'Vehicle unassigned from selected orders.',
+            'vehicle' => $vehicle->fresh(['driver', 'devices']),
+            'orders'  => IndexOrderResource::collection($orders->fresh(['driverAssigned', 'vehicleAssigned']))->resolve(),
+            'count'   => $orders->count(),
+        ]);
+    }
+
+    public function attachDevice(Request $request, string $id): JsonResponse
+    {
+        $request->validate(['device' => 'required|string']);
+
+        $deviceId = $request->input('device');
+        $vehicle  = $this->resolveVehicle($id);
+        $device   = $this->resolveDevice($deviceId);
+
+        if (!$vehicle) {
+            $this->logDeviceAttachmentLookupFailure('attach-device', 'vehicle', $id, $deviceId);
+
+            return response()->error('Vehicle not found or not available for this organization.', 404);
+        }
+
+        if (!$device) {
+            $this->logDeviceAttachmentLookupFailure('attach-device', 'device', $id, $deviceId);
+
+            return response()->error('Device not found or not available for this organization.', 404);
+        }
+
+        try {
+            $device->attachTo($vehicle);
+            $device->load(['telematic', 'warranty', 'attachable']);
+            $vehicle->load(['driver', 'devices']);
+        } catch (\Throwable $e) {
+            $this->logDeviceAttachmentFailure('attach-device', $vehicle, $device, $e);
+
+            return response()->error('Unable to attach device to vehicle. Please try again or contact support.', 500);
+        }
+
+        return response()->json([
+            'status'  => 'ok',
+            'message' => 'Device attached to vehicle.',
+            'device'  => $device,
+            'vehicle' => $vehicle,
+        ]);
+    }
+
+    public function detachDevice(Request $request, string $id): JsonResponse
+    {
+        $request->validate(['device' => 'required|string']);
+
+        $deviceId = $request->input('device');
+        $vehicle  = $this->resolveVehicle($id);
+        $device   = $this->resolveDevice($deviceId);
+
+        if (!$vehicle) {
+            $this->logDeviceAttachmentLookupFailure('detach-device', 'vehicle', $id, $deviceId);
+
+            return response()->error('Vehicle not found or not available for this organization.', 404);
+        }
+
+        if (!$device) {
+            $this->logDeviceAttachmentLookupFailure('detach-device', 'device', $id, $deviceId);
+
+            return response()->error('Device not found or not available for this organization.', 404);
+        }
+
+        if ($device->attachable_uuid !== $vehicle->uuid) {
+            return response()->error('This device is not attached to the selected vehicle.');
+        }
+
+        try {
+            $device->detach();
+            $device->load(['telematic', 'warranty', 'attachable']);
+            $vehicle->load(['driver', 'devices']);
+        } catch (\Throwable $e) {
+            $this->logDeviceAttachmentFailure('detach-device', $vehicle, $device, $e);
+
+            return response()->error('Unable to detach device from vehicle. Please try again or contact support.', 500);
+        }
+
+        return response()->json([
+            'status'  => 'ok',
+            'message' => 'Device detached from vehicle.',
+            'device'  => $device,
+            'vehicle' => $vehicle,
+        ]);
+    }
+
+    protected function findVehicle(string $id): Vehicle
+    {
+        return Vehicle::where(function ($query) use ($id) {
+            $query->where('uuid', $id)->orWhere('public_id', $id);
+        })
+            ->where('company_uuid', session('company'))
+            ->firstOrFail();
+    }
+
+    protected function resolveVehicle(string $id): ?Vehicle
+    {
+        return Vehicle::where(function ($query) use ($id) {
+            $query->where('uuid', $id)->orWhere('public_id', $id);
+        })
+            ->where('company_uuid', session('company'))
+            ->first();
+    }
+
+    protected function findDriver(string $id): Driver
+    {
+        return Driver::where(function ($query) use ($id) {
+            $query->where('uuid', $id)->orWhere('public_id', $id);
+        })
+            ->where('company_uuid', session('company'))
+            ->firstOrFail();
+    }
+
+    protected function resolveDevice(string $id): ?Device
+    {
+        return Device::where(function ($query) use ($id) {
+            $query->where('uuid', $id)->orWhere('public_id', $id);
+        })
+            ->where('company_uuid', session('company'))
+            ->first();
+    }
+
+    protected function logDeviceAttachmentLookupFailure(string $action, string $missingResource, string $vehicleId, ?string $deviceId): void
+    {
+        Log::warning('Vehicle device attachment lookup failed', [
+            'action'           => $action,
+            'missing_resource' => $missingResource,
+            'vehicle_id'       => $vehicleId,
+            'device_id'        => $deviceId,
+            'company_uuid'     => session('company'),
+            'request_id'       => request()->headers->get('X-Request-ID') ?? request()->headers->get('X-Correlation-ID'),
+        ]);
+    }
+
+    protected function logDeviceAttachmentFailure(string $action, Vehicle $vehicle, Device $device, \Throwable $exception): void
+    {
+        Log::error('Vehicle device attachment failed', [
+            'action'          => $action,
+            'vehicle_uuid'    => $vehicle->uuid,
+            'vehicle_id'      => $vehicle->public_id,
+            'device_uuid'     => $device->uuid,
+            'device_id'       => $device->public_id,
+            'company_uuid'    => session('company'),
+            'request_id'      => request()->headers->get('X-Request-ID') ?? request()->headers->get('X-Correlation-ID'),
+            'exception_class' => get_class($exception),
+            'exception'       => $exception->getMessage(),
+        ]);
+    }
+
+    protected function activeOrderUuid(Vehicle $vehicle): ?string
+    {
+        $vehicle->loadMissing('driver.currentOrder');
+
+        return data_get($vehicle, 'driver.currentOrder.uuid') ?? data_get($vehicle->lastKnownPosition(), 'order_uuid');
+    }
+
+    protected function findDevice(string $id): Device
+    {
+        return Device::where(function ($query) use ($id) {
+            $query->where('uuid', $id)->orWhere('public_id', $id);
+        })
+            ->where('company_uuid', session('company'))
+            ->firstOrFail();
+    }
+
     /**
      * Get all status options for an vehicle.
      *