@fleetbase/fleetops-engine 0.6.49 → 0.6.50

package/server/tests/LabelPdfRenderingTest.php

@@ -0,0 +1,23 @@
+<?php
+
+test('labels use the shared utf8 pdf renderer instead of arabic-only html rewriting', function () {
+    $labelPdf = file_get_contents(dirname(__DIR__) . '/src/Support/LabelPdf.php');
+    $order    = file_get_contents(dirname(__DIR__) . '/src/Models/Order.php');
+    $waypoint = file_get_contents(dirname(__DIR__) . '/src/Models/Waypoint.php');
+    $entity   = file_get_contents(dirname(__DIR__) . '/src/Models/Entity.php');
+    $default  = file_get_contents(dirname(__DIR__) . '/resources/views/labels/default.php');
+    $stop     = file_get_contents(dirname(__DIR__) . '/resources/views/labels/waypoint-label.php');
+    $utils    = file_get_contents(dirname(__DIR__) . '/src/Support/Utils.php');
+
+    expect($labelPdf)
+        ->toContain("Pdf::loadHTML(\$html, 'UTF-8')")
+        ->toContain("'defaultFont'             => 'DejaVu Sans'")
+        ->and($order)->toContain('LabelPdf::fromHtml($this->label())')
+        ->and($waypoint)->toContain('LabelPdf::fromHtml($this->label())')
+        ->and($entity)->toContain('LabelPdf::fromHtml($this->label())')
+        ->and($default)->toContain('Noto Sans Arabic')
+        ->not->toContain('strtoupper($company->name)')
+        ->and($stop)->toContain('Noto Sans CJK JP')
+        ->not->toContain('strtoupper($company->name)')
+        ->and($utils)->not->toContain('fixArabicInHTML');
+});

package/server/tests/LiveControllerViewportTest.php

@@ -0,0 +1,60 @@
+<?php
+
+use Fleetbase\FleetOps\Http\Controllers\Internal\v1\LiveController;
+use Fleetbase\FleetOps\Models\Driver;
+use Illuminate\Http\Request;
+
+function callLiveControllerMethod(string $method, array $arguments = [])
+{
+    $reflection = new ReflectionMethod(LiveController::class, $method);
+    $reflection->setAccessible(true);
+
+    return $reflection->invokeArgs(new LiveController(), $arguments);
+}
+
+test('live viewport bounds are normalized for stable cache keys', function () {
+    $request = new Request([
+        'bounds' => ['1.234567', '103.876543', '1.345678', '103.987654'],
+    ]);
+
+    expect(callLiveControllerMethod('normalizeLiveBounds', [$request]))
+        ->toBe([1.2346, 103.8765, 1.3457, 103.9877]);
+});
+
+test('invalid live viewport bounds fall back to unbounded queries', function ($bounds) {
+    $request = new Request(['bounds' => $bounds]);
+
+    expect(callLiveControllerMethod('normalizeLiveBounds', [$request]))->toBeNull();
+})->with([
+    'missing coordinate' => [[1, 2, 3]],
+    'non numeric'        => [[1, 'west', 3, 4]],
+    'invalid latitude'   => [[-91, 103, 1, 104]],
+    'invalid longitude'  => [[1, -181, 2, 104]],
+    'inverted latitude'  => [[2, 103, 1, 104]],
+    'inverted longitude' => [[1, 104, 2, 103]],
+]);
+
+test('live viewport limit defaults and clamps', function () {
+    expect(callLiveControllerMethod('normalizeLiveLimit', [new Request()]))->toBe(500)
+        ->and(callLiveControllerMethod('normalizeLiveLimit', [new Request(['limit' => 25])]))->toBe(25)
+        ->and(callLiveControllerMethod('normalizeLiveLimit', [new Request(['limit' => 0])]))->toBe(500)
+        ->and(callLiveControllerMethod('normalizeLiveLimit', [new Request(['limit' => 5000])]))->toBe(1000);
+});
+
+test('live viewport query avoids spatial constructors with fixed srids', function () {
+    $query = Driver::query();
+
+    callLiveControllerMethod('applyLiveLocationGuards', [$query]);
+    callLiveControllerMethod('applyLiveViewportBounds', [$query, [1.2, 103.8, 1.4, 104.0]]);
+    $query->orderByDesc('updated_at')->orderByDesc('id')->limit(25);
+
+    $sql = $query->toSql();
+
+    expect($sql)->toContain('ST_Y(location) BETWEEN ? AND ?')
+        ->and($sql)->toContain('ST_X(location) BETWEEN ? AND ?')
+        ->and($sql)->toContain('limit 25')
+        ->and($sql)->not->toContain('ST_MakeEnvelope')
+        ->and($sql)->not->toContain('ST_GeomFromText');
+
+    expect($query->getBindings())->toContain(1.2, 1.4, 103.8, 104.0);
+});

package/server/tests/MetricsRegistryTest.php

@@ -1,12 +1,8 @@
 <?php
 
 use Fleetbase\FleetOps\Support\Metrics\AbstractMetric;
-use Fleetbase\FleetOps\Support\Metrics\AvgOrderValueMetric;
-use Fleetbase\FleetOps\Support\Metrics\EarningsMetric;
-use Fleetbase\FleetOps\Support\Metrics\OpenIssuesMetric;
 use Fleetbase\FleetOps\Support\Metrics\OrdersInProgressMetric;
 use Fleetbase\FleetOps\Support\Metrics\Registry;
-use Fleetbase\FleetOps\Support\Metrics\ResolvedIssuesMetric;
 use Fleetbase\FleetOps\Support\Metrics\TotalTimeTraveledMetric;
 
 test('registry exposes every known metric slug', function () {
@@ -42,7 +38,7 @@ test('every registered metric extends the abstract base', function () {
 });
 
 test('open and resolved issue metrics scope to the constructor company (not session)', function () {
-    $sourceOpen = file_get_contents(dirname(__DIR__) . '/src/Support/Metrics/OpenIssuesMetric.php');
+    $sourceOpen     = file_get_contents(dirname(__DIR__) . '/src/Support/Metrics/OpenIssuesMetric.php');
     $sourceResolved = file_get_contents(dirname(__DIR__) . '/src/Support/Metrics/ResolvedIssuesMetric.php');
 
     expect($sourceOpen)->not->toContain("session('company')");
@@ -60,7 +56,7 @@ test('total_time_traveled metric sums the time column, not distance', function (
 });
 
 test('money metrics return float values to preserve cents', function () {
-    $earnings = file_get_contents(dirname(__DIR__) . '/src/Support/Metrics/EarningsMetric.php');
+    $earnings  = file_get_contents(dirname(__DIR__) . '/src/Support/Metrics/EarningsMetric.php');
     $fuelCosts = file_get_contents(dirname(__DIR__) . '/src/Support/Metrics/FuelCostsMetric.php');
 
     expect($earnings)->toContain('(float) $query->sum');
@@ -70,9 +66,9 @@ test('money metrics return float values to preserve cents', function () {
 });
 
 test('money metrics filter by currency to avoid mixed-currency sums', function () {
-    $earnings = file_get_contents(dirname(__DIR__) . '/src/Support/Metrics/EarningsMetric.php');
+    $earnings  = file_get_contents(dirname(__DIR__) . '/src/Support/Metrics/EarningsMetric.php');
     $fuelCosts = file_get_contents(dirname(__DIR__) . '/src/Support/Metrics/FuelCostsMetric.php');
-    $aov = file_get_contents(dirname(__DIR__) . '/src/Support/Metrics/AvgOrderValueMetric.php');
+    $aov       = file_get_contents(dirname(__DIR__) . '/src/Support/Metrics/AvgOrderValueMetric.php');
 
     expect($earnings)->toContain("->where('currency'");
     expect($fuelCosts)->toContain("->where('currency'");

package/server/tests/OrchestrationPayloadBuilderTest.php

@@ -39,7 +39,7 @@ function orchestrationTestOrder($pickup = null, $dropoff = null, array $waypoint
         public function __construct(public $pickup, public $dropoff, array $waypoints)
         {
             $this->entities         = collect();
-            $this->waypointMarkers = collect($waypoints)->map(function ($place, $index) {
+            $this->waypointMarkers  = collect($waypoints)->map(function ($place, $index) {
                 return new class($place, $index) {
                     public string $public_id;
                     public string $uuid;
@@ -61,7 +61,7 @@ function orchestrationTestOrder($pickup = null, $dropoff = null, array $waypoint
         }
     };
 
-    $order = new Order();
+    $order            = new Order();
     $order->public_id = 'order_test';
     $order->setRelation('payload', $payload);
 

package/server/tests/OrderConfigEndpointTest.php

@@ -0,0 +1,86 @@
+<?php
+
+use Fleetbase\FleetOps\Http\Controllers\Api\v1\OrderConfigController;
+use Fleetbase\FleetOps\Http\Resources\Internal\v1\OrderConfig as InternalOrderConfigResource;
+use Fleetbase\FleetOps\Http\Resources\v1\OrderConfig as OrderConfigResource;
+
+/*
+|--------------------------------------------------------------------------
+| OrderConfig API surface — static shape checks.
+|
+| The OrderConfig public API surface gives consumers (customer portals,
+| third-party integrations) a read-only projection of the OrderConfig
+| `flow` JSON so they can drive status filters, activity labels, and
+| similar UI from the canonical config rather than hardcoding their own.
+|
+| These mirror the lightweight static checks used elsewhere in this
+| package and verify the routes, controller methods, and resource shape
+| exist without booting Laravel.
+|--------------------------------------------------------------------------
+*/
+
+test('order-configs route group is registered in the consumable v1 namespace', function () {
+    $routes = file_get_contents(dirname(__DIR__) . '/src/routes.php');
+
+    expect($routes)
+        ->toContain("\$router->group(['prefix' => 'order-configs']")
+        ->and($routes)->toContain('OrderConfigController@query')
+        ->and($routes)->toContain('OrderConfigController@find');
+});
+
+test('OrderConfigController exposes only read-only methods', function () {
+    foreach (['query', 'find'] as $method) {
+        expect(method_exists(OrderConfigController::class, $method))->toBeTrue(
+            "OrderConfigController::{$method} missing",
+        );
+    }
+
+    // No write methods are exposed — OrderConfigs are owned by operator UIs.
+    foreach (['create', 'update', 'delete', 'store', 'destroy'] as $method) {
+        expect(method_exists(OrderConfigController::class, $method))->toBeFalse(
+            "OrderConfigController::{$method} should NOT exist on the public surface",
+        );
+    }
+});
+
+test('find() resolves by uuid, public_id, namespace, or key', function () {
+    $source = file_get_contents(dirname(__DIR__) . '/src/Http/Controllers/Api/v1/OrderConfigController.php');
+
+    // The controller defers to the canonical resolver so /transport,
+    // /system:order-config:transport, the public_id, and the uuid all work.
+    expect($source)
+        ->toContain('OrderConfig::resolveFromIdentifier')
+        ->toContain('findRecordOrFail');
+});
+
+test('OrderConfig resource projects only public-safe fields', function () {
+    expect(class_exists(OrderConfigResource::class))->toBeTrue();
+
+    $source = file_get_contents(dirname(__DIR__) . '/src/Http/Resources/v1/OrderConfig.php');
+
+    expect($source)
+        // Public contract: id/key/name/namespace + the flow projection.
+        ->toContain("'key'")
+        ->toContain("'name'")
+        ->toContain("'namespace'")
+        ->toContain("'flow'")
+        ->toContain('projectFlow')
+        // Each flow row keeps the canonical activity keys.
+        ->toContain("'code'")
+        ->toContain("'status'")
+        ->toContain("'complete'")
+        // Internal config payload must not be exposed on the public surface.
+        ->not->toContain("'entities'");
+});
+
+test('internal OrderConfig resource preserves editable flow graph fields', function () {
+    expect(class_exists(InternalOrderConfigResource::class))->toBeTrue();
+
+    $source = file_get_contents(dirname(__DIR__) . '/src/Http/Resources/Internal/v1/OrderConfig.php');
+
+    expect($source)
+        ->toContain("'flow'")
+        ->toContain('$this->flow')
+        ->toContain("'entities'")
+        ->toContain("'core_service'");
+});

package/server/tests/OrderFileAttachmentTest.php

@@ -0,0 +1,20 @@
+<?php
+
+test('order file updates attach files to the order like creation does', function () {
+    $controller = file_get_contents(dirname(__DIR__) . '/src/Http/Controllers/Internal/v1/OrderController.php');
+    $orderModel = file_get_contents(dirname(__DIR__) . '/src/Models/Order.php');
+    $detailsJs  = file_get_contents(dirname(dirname(__DIR__)) . '/addon/components/order/details/documents.js');
+    $formJs     = file_get_contents(dirname(dirname(__DIR__)) . '/addon/components/order/form/documents.js');
+
+    expect($controller)
+        ->toContain("\$uploads = \$request->array('order.files')")
+        ->toContain('$order->attachFiles($uploads)')
+        ->and($orderModel)
+        ->toContain('public function attachFiles($uploads): self')
+        ->toContain('$file->setKey($this)')
+        ->and($detailsJs)
+        ->toContain("subject_type: 'fleet-ops:order'")
+        ->and($formJs)
+        ->toContain('if (!this.args.resource.isNew)')
+        ->toContain('subject_uuid = this.args.resource.id');
+});

package/server/tests/ServiceAreaZoneApiShapeTest.php

@@ -0,0 +1,34 @@
+<?php
+
+test('service area create and update accept persisted map geometry and style fields', function () {
+    $controller = file_get_contents(__DIR__ . '/../src/Http/Controllers/Api/v1/ServiceAreaController.php');
+
+    expect($controller)
+        ->toContain("'border'")
+        ->toContain("'color'")
+        ->toContain("'stroke_color'");
+});
+
+test('service area resource returns map geometry and style fields', function () {
+    $resource = file_get_contents(__DIR__ . '/../src/Http/Resources/v1/ServiceArea.php');
+
+    expect($resource)
+        ->toContain("'border'")
+        ->toContain("'color'")
+        ->toContain("'stroke_color'")
+        ->toContain("'trigger_on_entry'")
+        ->toContain("'trigger_on_exit'");
+});
+
+test('zone create accepts only service area public ids on the consumable api', function () {
+    $request    = file_get_contents(__DIR__ . '/../src/Http/Requests/CreateZoneRequest.php');
+    $controller = file_get_contents(__DIR__ . '/../src/Http/Controllers/Api/v1/ZoneController.php');
+
+    expect($request)
+        ->toContain("'service_area'")
+        ->not->toContain("'service_area_uuid'");
+
+    expect($controller)
+        ->toContain("'public_id'    => \$request->input('service_area')")
+        ->not->toContain("->orWhere('uuid'");
+});

package/server/tests/VehicleDriverAssignmentTest.php

@@ -0,0 +1,18 @@
+<?php
+
+test('vehicle updates preserve driver assignment unless driver input is explicit', function () {
+    $internalController = file_get_contents(dirname(__DIR__) . '/src/Http/Controllers/Internal/v1/VehicleController.php');
+    $publicController   = file_get_contents(dirname(__DIR__) . '/src/Http/Controllers/Api/v1/VehicleController.php');
+    $vehicleModel       = file_get_contents(dirname(__DIR__) . '/src/Models/Vehicle.php');
+
+    expect($internalController)
+        ->toContain('hasDriverInput($request)')
+        ->toContain('syncDriverAssignment($vehicle, $this->driverIdentifierFromRequest($request))')
+        ->toContain("Arr::has(\$payload, 'vehicle.driver_uuid')")
+        ->and($publicController)
+        ->toContain("\$request->exists('driver')")
+        ->toContain('$vehicle->unassignDriver()')
+        ->and($vehicleModel)
+        ->toContain('public function unassignDriver(): self')
+        ->toContain("Driver::where('vehicle_uuid', \$this->uuid)->update(['vehicle_uuid' => null])");
+});

package/translations/en-us.yaml

@@ -8,6 +8,7 @@ common:
     dispatch-orders: Dispatch Orders
     dispatch-order: Dispatch Order
     assign-driver: Assign Driver
+    unassign-driver: Unassign Driver
     assign-drivers: Assign Drivers
     no-driver-assigned: No driver assigned
     details: Details

package/server/migrations/2026_05_13_000001_repair_customer_contact_user_types.php

@@ -1,86 +0,0 @@
-<?php
-
-use Fleetbase\FleetOps\Models\Contact;
-use Fleetbase\Models\CompanyUser;
-use Illuminate\Database\Migrations\Migration;
-use Illuminate\Support\Facades\DB;
-use Illuminate\Support\Facades\Schema;
-
-return new class extends Migration {
-    /**
-     * Run the migrations.
-     *
-     * @return void
-     */
-    public function up()
-    {
-        Contact::withoutGlobalScopes()
-            ->where('type', 'customer')
-            ->whereNull('deleted_at')
-            ->chunkById(100, function ($contacts) {
-                foreach ($contacts as $contact) {
-                    try {
-                        $contact->repairCustomerTypeInvariant(true);
-                    } catch (Throwable $e) {
-                        // Skip ambiguous or unrecoverable records; runtime invariants handle new writes.
-                    }
-                }
-            });
-
-        if (!$this->canUseCustomerRoleHint()) {
-            return;
-        }
-
-        DB::table('contacts')
-            ->select('contacts.id')
-            ->join('company_users', function ($join) {
-                $join->on('company_users.user_uuid', '=', 'contacts.user_uuid');
-                $join->on('company_users.company_uuid', '=', 'contacts.company_uuid');
-            })
-            ->join('model_has_roles', function ($join) {
-                $join->on('model_has_roles.model_uuid', '=', 'company_users.uuid');
-                $join->where('model_has_roles.model_type', CompanyUser::class);
-            })
-            ->join('roles', 'roles.id', '=', 'model_has_roles.role_id')
-            ->where('roles.name', 'Fleet-Ops Customer')
-            ->whereNull('contacts.deleted_at')
-            ->where(function ($query) {
-                $query->whereNull('contacts.type');
-                $query->orWhere('contacts.type', '!=', 'customer');
-            })
-            ->distinct()
-            ->orderBy('contacts.id')
-            ->chunk(100, function ($rows) {
-                foreach ($rows as $row) {
-                    $contact = Contact::withoutGlobalScopes()->find($row->id);
-                    if (!$contact) {
-                        continue;
-                    }
-
-                    try {
-                        $contact->repairCustomerTypeInvariant(true);
-                    } catch (Throwable $e) {
-                        // Skip ambiguous or unrecoverable records; role is only a recovery hint.
-                    }
-                }
-            });
-    }
-
-    /**
-     * Reverse the migrations.
-     *
-     * @return void
-     */
-    public function down()
-    {
-        // Data repair is intentionally not reversible.
-    }
-
-    private function canUseCustomerRoleHint(): bool
-    {
-        return Schema::hasTable('contacts')
-            && Schema::hasTable('company_users')
-            && Schema::hasTable('model_has_roles')
-            && Schema::hasTable('roles');
-    }
-};