@flashphoner/websdk 2.0.261 → 2.0.263

package/flashphoner-room-api-webrtc-only.js

@@ -11619,6 +11619,7 @@ var StreamStatsCollector = function StreamStatsCollector(description, id, mediaC
     metricsBatch: null,
     timer: null,
     batchCount: 0,
+    timerBusy: false,
     start: function () {
       var _start = _asyncToGenerator(/*#__PURE__*/_regenerator().m(function _callee() {
         var error;
@@ -11701,7 +11702,7 @@ var StreamStatsCollector = function StreamStatsCollector(description, id, mediaC
                 _context2.n = 1;
                 break;
               }
-              statCollector.logger.error(LOG_PREFIX, "Can't update WebRTC metrics sending: no parameters passed");
+              statCollector.logger.error(LOG_PREFIX + "-" + statCollector.id, "Can't update WebRTC metrics sending: no parameters passed");
               return _context2.a(2);
             case 1:
               if (!(description.types || description.compression)) {
@@ -11761,14 +11762,26 @@ var StreamStatsCollector = function StreamStatsCollector(description, id, mediaC
     }(),
     updateHeaders: function () {
       var _updateHeaders = _asyncToGenerator(/*#__PURE__*/_regenerator().m(function _callee3() {
-        var stats;
+        var stats,
+          currentHeaders,
+          headersChanged,
+          newMetrics,
+          _args3 = arguments;
         return _regenerator().w(function (_context3) {
           while (1) switch (_context3.n) {
             case 0:
+              stats = _args3.length > 0 && _args3[0] !== undefined ? _args3[0] : null;
+              currentHeaders = "";
+              headersChanged = false;
+              if (stats) {
+                _context3.n = 2;
+                break;
+              }
               _context3.n = 1;
               return statCollector.mediaConnection.getWebRTCStats();
             case 1:
               stats = _context3.v;
+            case 2:
               Object.keys(statCollector.description.types).forEach(function (type) {
                 var typeDescriptor = statCollector.description.types[type];
                 var metricsString = "";
@@ -11781,11 +11794,11 @@ var StreamStatsCollector = function StreamStatsCollector(description, id, mediaC
                 }
                 if (stats[type]) {
                   stats[type].forEach(function (report) {
-                    statCollector.logger.debug(LOG_PREFIX, type + " report: " + JSON.stringify(report));
+                    statCollector.logger.debug(LOG_PREFIX + "-" + statCollector.id, type + " report: " + JSON.stringify(report));
                     if (contentFilters) {
                       var filtersMatched = true;
                       for (var filter in contentFilters) {
-                        statCollector.logger.debug(LOG_PREFIX, type + " filter by " + filter + ": " + JSON.stringify(contentFilters[filter]));
+                        statCollector.logger.debug(LOG_PREFIX + "-" + statCollector.id, type + " filter by " + filter + ": " + JSON.stringify(contentFilters[filter]));
                         var filterMatched = false;
                         if (report[filter]) {
                           var _iterator = _createForOfIteratorHelper(contentFilters[filter]),
@@ -11793,7 +11806,7 @@ var StreamStatsCollector = function StreamStatsCollector(description, id, mediaC
                           try {
                             for (_iterator.s(); !(_step = _iterator.n()).done;) {
                               var value = _step.value;
-                              statCollector.logger.debug(LOG_PREFIX, filter + ": " + value + " <>  " + report[filter]);
+                              statCollector.logger.debug(LOG_PREFIX + "-" + statCollector.id, filter + ": " + value + " <>  " + report[filter]);
                               if (report[filter] === value) {
                                 filterMatched = true;
                                 break;
@@ -11811,18 +11824,30 @@ var StreamStatsCollector = function StreamStatsCollector(description, id, mediaC
                         }
                       }
                       if (filtersMatched) {
-                        statCollector.addHeaders(report, metricsString);
+                        currentHeaders = statCollector.addHeaders(currentHeaders, report, metricsString);
                       }
                     } else {
-                      statCollector.addHeaders(report, metricsString);
+                      currentHeaders = statCollector.addHeaders(currentHeaders, report, metricsString);
                     }
                   });
                 } else {
-                  statCollector.logger.warn(LOG_PREFIX, "No report type found in RTC stats: '" + type + "'");
+                  statCollector.logger.debug(LOG_PREFIX + "-" + statCollector.id, "No report type found in RTC stats: '" + type + "'");
                 }
               });
-            case 2:
-              return _context3.a(2);
+              if (currentHeaders !== statCollector.headers) {
+                headersChanged = true;
+                newMetrics = [];
+                currentHeaders.split(",").forEach(function (header) {
+                  if (statCollector.headers.indexOf(header) === -1) {
+                    newMetrics.push(header);
+                  }
+                });
+                if (newMetrics.length) {
+                  statCollector.logger.info(LOG_PREFIX + "-" + statCollector.id, "RTC metrics to be collected: " + newMetrics.toString());
+                }
+                statCollector.headers = currentHeaders;
+              }
+              return _context3.a(2, headersChanged);
           }
         }, _callee3);
       }));
@@ -11831,24 +11856,20 @@ var StreamStatsCollector = function StreamStatsCollector(description, id, mediaC
       }
       return updateHeaders;
     }(),
-    addHeaders: function addHeaders(report, metricsString) {
+    addHeaders: function addHeaders(currentHeaders, report, metricsString) {
       if (metricsString) {
         var metrics = metricsString.split(",");
         metrics.forEach(function (metric) {
-          var metricFound = false;
           for (var _i = 0, _Object$keys = Object.keys(report); _i < _Object$keys.length; _i++) {
             var key = _Object$keys[_i];
             if (metric === key) {
-              statCollector.headers = util.addFieldToCsvString(statCollector.headers, report.type + "." + report.id + "." + metric, ",");
-              metricFound = true;
+              currentHeaders = util.addFieldToCsvString(currentHeaders, report.type + "." + report.id + "." + metric, ",");
               break;
             }
           }
-          if (!metricFound) {
-            statCollector.logger.warn(LOG_PREFIX, "No metric found in RTC stats report '" + report.type + "': '" + metric + "'");
-          }
         });
       }
+      return currentHeaders;
     },
     updateCompression: function () {
       var _updateCompression = _asyncToGenerator(/*#__PURE__*/_regenerator().m(function _callee4() {
@@ -11901,7 +11922,7 @@ var StreamStatsCollector = function StreamStatsCollector(description, id, mediaC
             case 2:
               _context5.p = 2;
               _t2 = _context5.v;
-              statCollector.logger.warn(LOG_PREFIX, "Can't compress metrics data using " + compression + ": " + _t2);
+              statCollector.logger.warn(LOG_PREFIX + "-" + statCollector.id, "Can't compress metrics data using " + compression + ": " + _t2);
               statCollector.compression = "none";
             case 3:
               return _context5.a(2);
@@ -11922,7 +11943,7 @@ var StreamStatsCollector = function StreamStatsCollector(description, id, mediaC
       statCollector.send("webRTCMetricsClientDescription", data);
     },
     send: function send(message, data) {
-      statCollector.logger.debug(LOG_PREFIX, data);
+      statCollector.logger.debug(LOG_PREFIX + "-" + statCollector.id, data);
       if (statCollector.wsConnection.readyState === WebSocket.OPEN) {
         statCollector.wsConnection.send(JSON.stringify({
           message: message,
@@ -11945,14 +11966,17 @@ var StreamStatsCollector = function StreamStatsCollector(description, id, mediaC
     },
     collectMetrics: function () {
       var _collectMetrics = _asyncToGenerator(/*#__PURE__*/_regenerator().m(function _callee6() {
-        var stats, metrics;
+        var stats, metrics, lostMetrics;
         return _regenerator().w(function (_context6) {
           while (1) switch (_context6.n) {
             case 0:
-              if (!statCollector.timer) {
-                _context6.n = 2;
+              if (!(statCollector.timer && !statCollector.timerBusy)) {
+                _context6.n = 6;
                 break;
               }
+              // Unfortunately there are no real atomics in JS unless SharedArrayBuffer is used
+              // So we guard the timer callback with a dumb boolean
+              statCollector.timerBusy = true;
               _context6.n = 1;
               return statCollector.mediaConnection.getWebRTCStats();
             case 1:
@@ -11961,6 +11985,7 @@ var StreamStatsCollector = function StreamStatsCollector(description, id, mediaC
                 statCollector.metricsBatch = [];
               }
               metrics = [];
+              lostMetrics = [];
               statCollector.headers.split(",").forEach(function (header) {
                 var components = header.split(".");
                 var descriptor = {
@@ -11968,7 +11993,7 @@ var StreamStatsCollector = function StreamStatsCollector(description, id, mediaC
                   id: components[1],
                   name: components[2]
                 };
-                var value = "undefined";
+                var value = "NO";
                 if (stats[descriptor.type]) {
                   var _iterator2 = _createForOfIteratorHelper(stats[descriptor.type]),
                     _step2;
@@ -11987,7 +12012,13 @@ var StreamStatsCollector = function StreamStatsCollector(description, id, mediaC
                   }
                 }
                 metrics.push(value);
+                if (value == "NO") {
+                  lostMetrics.push(descriptor);
+                }
               });
+              if (lostMetrics.length) {
+                statCollector.logger.info(LOG_PREFIX + "-" + statCollector.id, "Missing metrics: " + JSON.stringify(lostMetrics));
+              }
               statCollector.metricsBatch.push(metrics);
               statCollector.batchCount--;
               if (!(statCollector.batchCount === 0)) {
@@ -11997,6 +12028,21 @@ var StreamStatsCollector = function StreamStatsCollector(description, id, mediaC
               _context6.n = 2;
               return statCollector.sendMetrics();
             case 2:
+              _context6.n = 3;
+              return statCollector.updateHeaders(stats);
+            case 3:
+              if (!_context6.v) {
+                _context6.n = 5;
+                break;
+              }
+              statCollector.logger.info(LOG_PREFIX + "-" + statCollector.id, "RTC metrics list has changed, sending a new metrics description");
+              _context6.n = 4;
+              return statCollector.sendMetrics();
+            case 4:
+              statCollector.sendHeaders();
+            case 5:
+              statCollector.timerBusy = false;
+            case 6:
               return _context6.a(2);
           }
         }, _callee6);
@@ -12008,7 +12054,7 @@ var StreamStatsCollector = function StreamStatsCollector(description, id, mediaC
     }(),
     sendMetrics: function () {
       var _sendMetrics = _asyncToGenerator(/*#__PURE__*/_regenerator().m(function _callee7() {
-        var previous, metricsToSend, metricsData, i, metricsString, j, valueString, previousString, separator, data, _t3;
+        var previous, metricsToSend, metricsData, i, metricsString, j, valueString, previousString, delimiter, data, _t3;
         return _regenerator().w(function (_context7) {
           while (1) switch (_context7.p = _context7.n) {
             case 0:
@@ -12018,14 +12064,17 @@ var StreamStatsCollector = function StreamStatsCollector(description, id, mediaC
                 for (j = 0; j < statCollector.metricsBatch[i].length; j++) {
                   valueString = valueToString(statCollector.metricsBatch[i][j]);
                   previousString = "";
-                  separator = ";";
+                  delimiter = ";";
                   if (previous) {
                     previousString = valueToString(previous[j]);
                   }
                   if (valueString === previousString) {
                     valueString = "";
                   }
-                  metricsString = util.addFieldToCsvString(metricsString, valueString, separator);
+                  metricsString = util.addFieldToCsvString(metricsString, valueString, delimiter);
+                  if (j > 0 && metricsString === "") {
+                    metricsString = delimiter;
+                  }
                 }
                 previous = statCollector.metricsBatch[i];
                 metricsToSend.push(metricsString);
@@ -12044,7 +12093,7 @@ var StreamStatsCollector = function StreamStatsCollector(description, id, mediaC
             case 3:
               _context7.p = 3;
               _t3 = _context7.v;
-              statCollector.logger.warn(LOG_PREFIX, "Can't send metrics data using" + statCollector.compression + ": " + _t3);
+              statCollector.logger.warn(LOG_PREFIX + "-" + statCollector.id, "Can't send metrics data using" + statCollector.compression + ": " + _t3);
               metricsData = null;
             case 4:
               _context7.n = 6;
@@ -12596,14 +12645,14 @@ var setPublishingBitrate = function setPublishingBitrate(sdp, mediaConnection, m
   }
   return sdp;
 };
-var addFieldToCsvString = function addFieldToCsvString(csvString, field, separator) {
-  if (field !== "" && field.indexOf(separator) >= 0) {
+var addFieldToCsvString = function addFieldToCsvString(csvString, field, delimiter) {
+  if (field !== "" && field.indexOf(delimiter) >= 0) {
     field = '"' + field + '"';
   }
-  if (csvString === "" && field !== "") {
+  if (csvString === "") {
     csvString = field;
   } else {
-    csvString = csvString + separator + field;
+    csvString = csvString + delimiter + field;
   }
   return csvString;
 };