@flashnet/sdk 0.4.2 → 0.4.4

package/dist/esm/src/client/FlashnetClient.js

@@ -1,3 +1,4 @@
+import sha256 from 'fast-sha256';
 import { ApiClient } from '../api/client.js';
 import { TypedAmmApi } from '../api/typed-endpoints.js';
 import { getClientEnvironmentName, resolveClientNetworkConfig, getClientNetworkConfig, BTC_ASSET_PUBKEY } from '../config/index.js';
@@ -213,8 +214,7 @@ class FlashnetClient {
     }
     /**
      * Convert a token identifier into the raw hex string form expected by the Flashnet backend.
-     * If the identifier is the BTC constant or already a hex string, it is returned unchanged.
-     * If it is in Bech32m human-readable form, it is decoded to hex.
+     * Handles BTC constant, hex strings, and Bech32m human-readable format.
      */
     toHexTokenIdentifier(tokenIdentifier) {
         if (tokenIdentifier === BTC_ASSET_PUBKEY) {
@@ -364,7 +364,7 @@ class FlashnetClient {
             nonce,
         });
         // Sign intent
-        const messageHash = new Uint8Array(await crypto.subtle.digest("SHA-256", intentMessage));
+        const messageHash = sha256(intentMessage);
         const signature = await this._wallet.config.signer.signMessageWithIdentityKey(messageHash, true);
         // Create pool
         const request = {
@@ -495,7 +495,7 @@ class FlashnetClient {
             totalHostFeeRateBps: params.totalHostFeeRateBps.toString(),
             nonce,
         });
-        const messageHash = new Uint8Array(await crypto.subtle.digest("SHA-256", intentMessage));
+        const messageHash = sha256(intentMessage);
         const signature = await this._wallet.config.signer.signMessageWithIdentityKey(messageHash, true);
         // Create pool
         const request = {
@@ -551,7 +551,7 @@ class FlashnetClient {
             assetASparkTransferId,
             nonce,
         });
-        const messageHash = new Uint8Array(await crypto.subtle.digest("SHA-256", intentMessage));
+        const messageHash = sha256(intentMessage);
         const signature = await this._wallet.config.signer.signMessageWithIdentityKey(messageHash, true);
         const request = {
             poolId,
@@ -635,7 +635,7 @@ class FlashnetClient {
             nonce,
         });
         // Sign intent
-        const messageHash = new Uint8Array(await crypto.subtle.digest("SHA-256", intentMessage));
+        const messageHash = sha256(intentMessage);
         const signature = await this._wallet.config.signer.signMessageWithIdentityKey(messageHash, true);
         const request = {
             userPublicKey: this.publicKey,
@@ -771,7 +771,7 @@ class FlashnetClient {
                 defaultIntegratorFeeRateBps: params.integratorFeeRateBps?.toString(),
             });
             // Sign intent
-            const messageHash = new Uint8Array(await crypto.subtle.digest("SHA-256", intentMessage));
+            const messageHash = sha256(intentMessage);
             const signature = await this._wallet.config.signer.signMessageWithIdentityKey(messageHash, true);
             const request = {
                 userPublicKey: this.publicKey,
@@ -870,7 +870,7 @@ class FlashnetClient {
                 nonce,
             });
             // Sign intent
-            const messageHash = new Uint8Array(await crypto.subtle.digest("SHA-256", intentMessage));
+            const messageHash = sha256(intentMessage);
             const signature = await this._wallet.config.signer.signMessageWithIdentityKey(messageHash, true);
             const request = {
                 userPublicKey: this.publicKey,
@@ -945,7 +945,7 @@ class FlashnetClient {
             nonce,
         });
         // Sign intent
-        const messageHash = new Uint8Array(await crypto.subtle.digest("SHA-256", intentMessage));
+        const messageHash = sha256(intentMessage);
         const signature = await this._wallet.config.signer.signMessageWithIdentityKey(messageHash, true);
         const request = {
             userPublicKey: this.publicKey,
@@ -979,7 +979,7 @@ class FlashnetClient {
             nonce,
         });
         // Sign intent
-        const messageHash = new Uint8Array(await crypto.subtle.digest("SHA-256", intentMessage));
+        const messageHash = sha256(intentMessage);
         const signature = await this._wallet.config.signer.signMessageWithIdentityKey(messageHash, true);
         const request = {
             namespace: params.namespace,
@@ -1027,7 +1027,7 @@ class FlashnetClient {
             nonce,
         });
         // Sign intent
-        const messageHash = new Uint8Array(await crypto.subtle.digest("SHA-256", intentMessage));
+        const messageHash = sha256(intentMessage);
         const signature = await this._wallet.config.signer.signMessageWithIdentityKey(messageHash, true);
         const request = {
             lpIdentityPublicKey: params.lpIdentityPublicKey,
@@ -1084,7 +1084,7 @@ class FlashnetClient {
             nonce,
         });
         // Sign intent
-        const messageHash = new Uint8Array(await crypto.subtle.digest("SHA-256", intentMessage));
+        const messageHash = sha256(intentMessage);
         const signature = await this._wallet.config.signer.signMessageWithIdentityKey(messageHash, true);
         const request = {
             integratorPublicKey: this.publicKey,
@@ -1135,7 +1135,7 @@ class FlashnetClient {
             abandonConditions: params.abandonConditions || undefined,
             nonce,
         });
-        const messageHash = new Uint8Array(await crypto.subtle.digest("SHA-256", intentMessage));
+        const messageHash = sha256(intentMessage);
         const signature = await this._wallet.config.signer.signMessageWithIdentityKey(messageHash, true);
         const request = {
             creatorPublicKey: this.publicKey,
@@ -1203,7 +1203,7 @@ class FlashnetClient {
             nonce,
         });
         // Sign
-        const messageHash = new Uint8Array(await crypto.subtle.digest("SHA-256", intentMessage));
+        const messageHash = sha256(intentMessage);
         const signature = await this._wallet.config.signer.signMessageWithIdentityKey(messageHash, true);
         // Call API
         const request = {
@@ -1228,7 +1228,7 @@ class FlashnetClient {
             recipientPublicKey: this.publicKey,
             nonce,
         });
-        const messageHash = new Uint8Array(await crypto.subtle.digest("SHA-256", intentMessage));
+        const messageHash = sha256(intentMessage);
         const signature = await this._wallet.config.signer.signMessageWithIdentityKey(messageHash, true);
         const request = {
             escrowId: params.escrowId,
@@ -1284,7 +1284,7 @@ class FlashnetClient {
             lpIdentityPublicKey: params.lpIdentityPublicKey,
             nonce,
         });
-        const messageHash = new Uint8Array(await crypto.subtle.digest("SHA-256", intentMessage));
+        const messageHash = sha256(intentMessage);
         const signature = await this._wallet.config.signer.signMessageWithIdentityKey(messageHash, true);
         const request = {
             senderPublicKey: this.publicKey,
@@ -1765,7 +1765,7 @@ class FlashnetClient {
             assetBMinAmountIn: assetBMinAmountIn.toString(),
             nonce,
         });
-        const messageHash = new Uint8Array(await crypto.subtle.digest("SHA-256", intentMessage));
+        const messageHash = sha256(intentMessage);
         const signature = await this._wallet.config.signer.signMessageWithIdentityKey(messageHash, true);
         const request = {
             userPublicKey: this.publicKey,
@@ -1802,7 +1802,18 @@ class FlashnetClient {
         // Decode the invoice to get the amount
         const invoiceAmountSats = await this.decodeInvoiceAmount(invoice);
         if (!invoiceAmountSats || invoiceAmountSats <= 0) {
-            throw new Error("Unable to decode invoice amount. Zero-amount invoices are not supported for token payments.");
+            throw new FlashnetError("Unable to decode invoice amount. Zero-amount invoices are not supported for token payments.", {
+                response: {
+                    errorCode: "FSAG-1002",
+                    errorCategory: "Validation",
+                    message: "Unable to decode invoice amount. Zero-amount invoices are not supported for token payments.",
+                    requestId: "",
+                    timestamp: new Date().toISOString(),
+                    service: "sdk",
+                    severity: "Error",
+                    remediation: "Provide a valid BOLT11 invoice with a non-zero amount.",
+                },
+            });
         }
         // Get Lightning fee estimate
         const lightningFeeEstimate = await this.getLightningFeeEstimate(invoice);
@@ -1821,9 +1832,19 @@ class FlashnetClient {
         // Check BTC minimum (output from swap)
         const btcMinAmount = minAmounts.get(BTC_ASSET_PUBKEY.toLowerCase());
         if (btcMinAmount && totalBtcNeeded < btcMinAmount) {
-            throw new Error(`Invoice amount too small. Flashnet minimum BTC output is ${btcMinAmount} sats, ` +
-                `but invoice + lightning fee totals only ${totalBtcNeeded} sats. ` +
-                `Please use an invoice of at least ${btcMinAmount} sats.`);
+            const msg = `Invoice amount too small. Minimum BTC output is ${btcMinAmount} sats, but invoice + lightning fee totals only ${totalBtcNeeded} sats.`;
+            throw new FlashnetError(msg, {
+                response: {
+                    errorCode: "FSAG-1003",
+                    errorCategory: "Validation",
+                    message: msg,
+                    requestId: "",
+                    timestamp: new Date().toISOString(),
+                    service: "sdk",
+                    severity: "Error",
+                    remediation: `Use an invoice of at least ${btcMinAmount} sats.`,
+                },
+            });
         }
         // Find the best pool to swap token -> BTC
         const poolQuote = await this.findBestPoolForTokenToBtc(tokenAddress, totalBtcNeeded.toString(), options?.integratorFeeRateBps);
@@ -1832,9 +1853,19 @@ class FlashnetClient {
         const tokenMinAmount = minAmounts.get(tokenHex);
         if (tokenMinAmount &&
             BigInt(poolQuote.tokenAmountRequired) < tokenMinAmount) {
-            throw new Error(`Token amount too small. Flashnet minimum input is ${tokenMinAmount} units, ` +
-                `but calculated amount is only ${poolQuote.tokenAmountRequired} units. ` +
-                `Please use a larger invoice amount.`);
+            const msg = `Token amount too small. Minimum input is ${tokenMinAmount} units, but calculated amount is only ${poolQuote.tokenAmountRequired} units.`;
+            throw new FlashnetError(msg, {
+                response: {
+                    errorCode: "FSAG-1003",
+                    errorCategory: "Validation",
+                    message: msg,
+                    requestId: "",
+                    timestamp: new Date().toISOString(),
+                    service: "sdk",
+                    severity: "Error",
+                    remediation: "Use a larger invoice amount.",
+                },
+            });
         }
         // Calculate the BTC variable fee adjustment (how much extra we're requesting)
         const btcVariableFeeAdjustment = Number(totalBtcNeeded - baseBtcNeeded);
@@ -2068,6 +2099,8 @@ class FlashnetClient {
         const tokenHex = this.toHexTokenIdentifier(tokenAddress);
         const btcHex = BTC_ASSET_PUBKEY;
         // Find all pools that have this token paired with BTC
+        // Note: The API may return the same pool for both filter combinations,
+        // so we need to deduplicate and determine tokenIsAssetA from actual pool data
         const poolsWithTokenAsA = await this.listPools({
             assetAAddress: tokenHex,
             assetBAddress: btcHex,
@@ -2076,17 +2109,57 @@ class FlashnetClient {
             assetAAddress: btcHex,
             assetBAddress: tokenHex,
         });
-        const allPools = [
-            ...poolsWithTokenAsA.pools.map((p) => ({ ...p, tokenIsAssetA: true })),
-            ...poolsWithTokenAsB.pools.map((p) => ({ ...p, tokenIsAssetA: false })),
-        ];
+        // Deduplicate pools by poolId and determine tokenIsAssetA from actual pool addresses
+        const poolMap = new Map();
+        for (const p of [...poolsWithTokenAsA.pools, ...poolsWithTokenAsB.pools]) {
+            if (!poolMap.has(p.lpPublicKey)) {
+                // Determine tokenIsAssetA from actual pool asset addresses, not from which query returned it
+                const tokenIsAssetA = p.assetAAddress?.toLowerCase() === tokenHex.toLowerCase();
+                poolMap.set(p.lpPublicKey, { pool: p, tokenIsAssetA });
+            }
+        }
+        const allPools = Array.from(poolMap.values()).map(({ pool, tokenIsAssetA }) => ({
+            ...pool,
+            tokenIsAssetA,
+        }));
         if (allPools.length === 0) {
-            throw new Error(`No liquidity pool found for token ${tokenAddress} paired with BTC`);
+            throw new FlashnetError(`No liquidity pool found for token ${tokenAddress} paired with BTC`, {
+                response: {
+                    errorCode: "FSAG-4001",
+                    errorCategory: "Business",
+                    message: `No liquidity pool found for token ${tokenAddress} paired with BTC`,
+                    requestId: "",
+                    timestamp: new Date().toISOString(),
+                    service: "sdk",
+                    severity: "Error",
+                },
+            });
+        }
+        // Pre-check: Get minimum amounts to provide clear error if invoice is too small
+        const minAmounts = await this.getMinAmountsMap();
+        const btcMinAmount = minAmounts.get(BTC_ASSET_PUBKEY.toLowerCase());
+        // Check if the BTC amount needed is below the minimum
+        if (btcMinAmount && BigInt(btcAmountNeeded) < btcMinAmount) {
+            const msg = `Invoice amount too small. Minimum ${btcMinAmount} sats required, but invoice only requires ${btcAmountNeeded} sats.`;
+            throw new FlashnetError(msg, {
+                response: {
+                    errorCode: "FSAG-1003",
+                    errorCategory: "Validation",
+                    message: msg,
+                    requestId: "",
+                    timestamp: new Date().toISOString(),
+                    service: "sdk",
+                    severity: "Error",
+                    remediation: `Use an invoice with at least ${btcMinAmount} sats.`,
+                },
+            });
         }
         // Find the best pool (lowest token cost for the required BTC)
         let bestPool = null;
         let bestTokenAmount = BigInt(Number.MAX_SAFE_INTEGER);
         let bestSimulation = null;
+        // Track errors for each pool to provide better diagnostics
+        const poolErrors = [];
         for (const pool of allPools) {
             try {
                 // Get pool details for reserves
@@ -2120,12 +2193,53 @@ class FlashnetClient {
                             warningMessage: simulation.warningMessage,
                         };
                     }
+                    else {
+                        // Simulation output was insufficient
+                        const btcReserve = pool.tokenIsAssetA
+                            ? poolDetails.assetBReserve
+                            : poolDetails.assetAReserve;
+                        poolErrors.push({
+                            poolId: pool.lpPublicKey,
+                            error: `Simulation output (${simulation.amountOut} sats) < required (${btcAmountNeeded} sats)`,
+                            btcReserve,
+                        });
+                    }
                 }
             }
-            catch { }
+            catch (e) {
+                // Capture pool errors for diagnostics
+                const errorMessage = e instanceof Error ? e.message : String(e);
+                poolErrors.push({
+                    poolId: pool.lpPublicKey,
+                    error: errorMessage,
+                });
+            }
         }
         if (!bestPool || !bestSimulation) {
-            throw new Error(`No pool has sufficient liquidity for ${btcAmountNeeded} sats`);
+            let errorMessage = `No pool has sufficient liquidity for ${btcAmountNeeded} sats`;
+            if (poolErrors.length > 0) {
+                const details = poolErrors
+                    .map((pe) => {
+                    const reserveInfo = pe.btcReserve
+                        ? ` (BTC reserve: ${pe.btcReserve})`
+                        : "";
+                    return `  - Pool ${pe.poolId.slice(0, 12)}...${reserveInfo}: ${pe.error}`;
+                })
+                    .join("\n");
+                errorMessage += `\n\nPool evaluation details:\n${details}`;
+            }
+            throw new FlashnetError(errorMessage, {
+                response: {
+                    errorCode: "FSAG-4201",
+                    errorCategory: "Business",
+                    message: errorMessage,
+                    requestId: "",
+                    timestamp: new Date().toISOString(),
+                    service: "sdk",
+                    severity: "Error",
+                    remediation: "Try a smaller amount or wait for more liquidity.",
+                },
+            });
         }
         const poolDetails = await this.getPool(bestPool.lpPublicKey);
         return {