@flarum/cli 3.0.11 → 3.0.13

package/lib/steps/upgrade/twopointoh/base.js

@@ -12,10 +12,24 @@ const chalk_1 = tslib_1.__importDefault(require("chalk"));
 const string_1 = tslib_1.__importDefault(require("string"));
 const simple_git_1 = tslib_1.__importDefault(require("simple-git"));
 const types_1 = require("@babel/types");
+const step_failures_1 = require("./step-failures");
+const todos_1 = require("./todos");
+const terminal_1 = require("../../../utils/terminal");
+/**
+ * The indentation a JSON file's first indented line uses, or the given
+ * fallback when it has none (an empty object, say, or everything on one line).
+ */
+function jsonIndentation(code, fallback) {
+    var _a, _b;
+    return (_b = (_a = code.match(/^[\t ]+(?=\S)/m)) === null || _a === void 0 ? void 0 : _a[0]) !== null && _b !== void 0 ? _b : fallback;
+}
 class BaseUpgradeStep {
     getExposed(_paths, _paramProvider) {
         return (0, pick_deep_1.default)(this.params, this.exposes);
     }
+    get number() {
+        return this.step;
+    }
     constructor(command, root, step, totalSteps, forceStep) {
         this.composable = true;
         this.exposes = [];
@@ -24,7 +38,15 @@ class BaseUpgradeStep {
         this.totalSteps = 0;
         this.forceStep = false;
         this.beforeHook = false;
+        /** Whether the step runs for a check, in a worktree that is thrown away. */
+        this.checking = false;
+        /** Work this step leaves that no @TODO comment in a file shows. */
+        this.followUps = [];
         this.fsEditor = null;
+        /**
+         * Unset until the step runs.
+         */
+        this.outcome = null;
         this.command = command;
         this.step = step;
         this.totalSteps = totalSteps;
@@ -34,14 +56,29 @@ class BaseUpgradeStep {
     before(_file, _code, _advanced) {
         // ...
     }
+    /**
+     * Leave work for the author that the step can't mark with a @TODO comment,
+     * such as a file that is missing, or a change it can only point out.
+     */
+    leaveTodo(file, text) {
+        if (!this.followUps.some((todo) => todo.file === file && todo.text === text)) {
+            this.followUps.push({ file, line: null, text });
+        }
+    }
+    /** The follow-ups, as lines to print under the step's notes. */
+    followUpLines() {
+        return this.followUps.map((todo) => `${chalk_1.default.bgYellow.black(' TO DO ')} ${todo.file}: ${todo.text}`);
+    }
     async run(fs, paths, io, providers) {
-        var _a, _b, _c, _d, _e;
+        var _a, _b, _c, _d;
         if (this.root !== paths.cwd()) {
             process.chdir(this.root);
         }
         const fsEditor = (0, mem_fs_editor_1.create)(fs);
         this.fsEditor = fsEditor;
         this.php = providers.php;
+        // Until the step gets further: whatever stops it from here on is a failure.
+        this.outcome = { status: 'failed', failures: [] };
         // Stop if there are uncommited changes
         const status = await (0, simple_git_1.default)((_a = paths.requestedDir()) !== null && _a !== void 0 ? _a : paths.cwd()).status();
         if (status === null || status === void 0 ? void 0 : status.files.length) {
@@ -56,20 +93,24 @@ class BaseUpgradeStep {
         if (!this.forceStep && (await this.alreadyCommited((_b = paths.requestedDir()) !== null && _b !== void 0 ? _b : paths.cwd(), this.gitCommit().message))) {
             this.command.log('     => ' + chalk_1.default.bgGreen.bold('    SKIP    '));
             this.command.log('');
+            this.outcome = { status: 'skipped' };
             return fs;
         }
         // Show loading indicator
         let dots = 1;
         let nl = false;
         const progress = () => {
+            if (!(0, terminal_1.isTerminal)())
+                return;
             if (!nl) {
                 this.command.log('');
                 nl = true;
             }
             const filledDots = '.'.repeat(dots) + ' '.repeat(3 - dots);
-            this.command.log('\u001B[A     => ' + chalk_1.default.bold('  WORKING' + filledDots));
+            this.command.log((0, terminal_1.overwrite)() + '     => ' + chalk_1.default.bold('  WORKING' + filledDots));
             dots = (dots + 1) % 4;
         };
+        const failures = new step_failures_1.StepFailures();
         const targets = this.targets();
         for (const target of targets) {
             progress();
@@ -84,8 +125,15 @@ class BaseUpgradeStep {
                         continue;
                     }
                     const code = fsEditor.read(file);
-                    const advanced = this.advancedContent(file, code);
-                    this.before(file, code, advanced);
+                    // Same as the transform pass below: a file this step can't read
+                    // shouldn't stop it from reporting on the others.
+                    try {
+                        const advanced = this.advancedContent(file, code);
+                        this.before(file, code, advanced);
+                    }
+                    catch (error) {
+                        failures.record((0, string_1.default)(file.replace(paths.package(), '')).stripLeft('/').stripLeft('\\').toString(), error);
+                    }
                     progress();
                 }
             }
@@ -97,10 +145,20 @@ class BaseUpgradeStep {
                         continue;
                     }
                     const code = fsEditor.read(file);
-                    const advanced = this.advancedContent(file, code);
                     const relativeTarget = (0, string_1.default)(file.replace(paths.package(), '')).stripLeft('/').stripLeft('\\').toString();
-                    // eslint-disable-next-line no-await-in-loop
-                    const result = await this.applyReplacements(relativeTarget, code, advanced);
+                    let result;
+                    // One file the step can't handle shouldn't decide the fate of the
+                    // rest: note it and carry on, so the author is told about every
+                    // problem this step found rather than the first one.
+                    try {
+                        const advanced = this.advancedContent(file, code);
+                        // eslint-disable-next-line no-await-in-loop
+                        result = await this.applyReplacements(relativeTarget, code, advanced);
+                    }
+                    catch (error) {
+                        failures.record(relativeTarget, error);
+                        continue;
+                    }
                     if (result.newPath && result.newPath !== file) {
                         fsEditor.move(file, result.newPath);
                         newFiles.push(result.newPath);
@@ -137,20 +195,49 @@ class BaseUpgradeStep {
             //   await applyOn(newFiles);
             // }
         }
-        const changesMade = await (0, simple_git_1.default)((_c = paths.requestedDir()) !== null && _c !== void 0 ? _c : paths.cwd())
+        const dir = (_c = paths.requestedDir()) !== null && _c !== void 0 ? _c : paths.cwd();
+        if (failures.any()) {
+            // Leave the step all-or-nothing. Its partial writes are already on disk,
+            // and the run refuses to start with a dirty tree, so keeping them would
+            // block the re-run this step is asking the author to do.
+            await (0, simple_git_1.default)(dir).checkout(['--', '.']);
+            this.outcome = { status: 'failed', failures: failures.list() };
+            this.command.log((0, terminal_1.overwrite)() + '     => ' + chalk_1.default.bgRed.bold('   FAILED   '));
+            this.command.log('');
+            this.command.log(failures.report());
+            this.command.log('');
+            const files = failures.count() === 1 ? 'file' : 'files';
+            this.command.error(`${failures.count()} ${files} could not be upgraded by this step, so it made no changes.\n` +
+                '     Fix the problems above and run the command again — steps that already\n' +
+                '     completed are skipped, so it will resume from here.', { code: 'FL_ERR' });
+        }
+        const changesMade = await (0, simple_git_1.default)(dir)
             .diffSummary()
             .then((summary) => summary.files.length > 0);
         if (changesMade) {
             await (0, simple_git_1.default)((_d = paths.requestedDir()) !== null && _d !== void 0 ? _d : paths.cwd()).add('.');
-            await this.pauseAndConfirm(this.pauseMessage(), io);
+            const notes = this.pauseMessage();
+            await this.pauseAndConfirm([notes, ...this.followUpLines()].join('\n                     '), io);
             const commit = this.gitCommit();
             const message = commit.message + '\n\n' + commit.description;
-            await (0, create_1.commitAll)((_e = paths.requestedDir()) !== null && _e !== void 0 ? _e : paths.cwd(), message);
-            this.command.log('\u001B[A     => ' + chalk_1.default.bgCyan.bold('   COMMIT   ') + ' ' + chalk_1.default.dim(commit.message));
+            await (0, create_1.commitAll)(dir, message);
+            const sha = (await (0, simple_git_1.default)(dir).revparse(['HEAD'])).trim();
+            this.outcome = {
+                status: 'committed',
+                commit: { sha, message: commit.message },
+                notes: (0, terminal_1.stripAnsi)(notes).trim(),
+                todos: [...(await (0, todos_1.todosAddedBy)(dir, sha)), ...this.followUps],
+            };
+            const label = this.checking ? chalk_1.default.bgYellow.black.bold(' WOULD CHANGE ') : chalk_1.default.bgCyan.bold('   COMMIT   ');
+            this.command.log((0, terminal_1.overwrite)() + '     => ' + label + ' ' + chalk_1.default.dim(commit.message));
             this.command.log('');
         }
         else {
-            this.command.log('\u001B[A     => ' + chalk_1.default.bgGreen.bold(' NO CHANGES '));
+            this.outcome = this.followUps.length > 0 ? { status: 'no-changes', todos: this.followUps } : { status: 'no-changes' };
+            this.command.log((0, terminal_1.overwrite)() + '     => ' + chalk_1.default.bgGreen.bold(' NO CHANGES '));
+            for (const line of this.followUpLines()) {
+                this.command.log('                     ' + line);
+            }
             this.command.log('');
         }
         return fs;
@@ -176,13 +263,17 @@ class BaseUpgradeStep {
                 continue;
             // eslint-disable-next-line no-await-in-loop
             code = await this.updateCode(file, code, result.updated);
+            // Later replacements read the parsed code: parse it again after a text
+            // change, or one that returns a syntax tree would undo this change.
+            if (typeof result.updated === 'string') {
+                advanced = this.advancedContent(file, code);
+            }
             if (((_a = result.imports) === null || _a === void 0 ? void 0 : _a.length) || (result.updated && typeof result.updated !== 'string' && 'program' in result.updated)) {
                 try {
                     advanced = (0, ast_1.parseCode)(code);
                 }
                 catch (error) {
-                    this.command.warn(`Failed to parse code for ${file}, code: \n${code}`);
-                    throw error;
+                    throw new Error(`The transformed code could not be parsed back: ${error.message}`);
                 }
                 (_b = result.imports) === null || _b === void 0 ? void 0 : _b.forEach((imp) => {
                     this.ensureImport(file, advanced, imp);
@@ -230,17 +321,22 @@ class BaseUpgradeStep {
         if (lang === 'json') {
             // remove comments
             code = code.replace(/^\s*\/\/.*$/gm, '');
-            // remove loose ,
-            code = code.replace(/,\s*}/g, '}');
+            // remove loose , before the end of an object or an array, as tsconfig.json allows
+            code = code.replace(/,(\s*[\]}])/g, '$1');
             try {
                 return JSON.parse(code);
             }
-            catch (_a) {
-                this.command.error(`Failed to parse JSON file ${file}`);
+            catch (error) {
+                throw new Error(`Not valid JSON: ${error.message}`);
             }
         }
         if (['js', 'ts', 'jsx', 'tsx'].includes(lang || '')) {
-            return (0, ast_1.parseCode)(code);
+            try {
+                return (0, ast_1.parseCode)(code);
+            }
+            catch (error) {
+                throw new Error(`Could not parse: ${error.message}`);
+            }
         }
         return null;
     }
@@ -253,23 +349,25 @@ class BaseUpgradeStep {
             return updated;
         }
         if (lang === 'json') {
-            const space = file === 'composer.json' ? 4 : 2;
-            return JSON.stringify(updated, null, space);
+            // Write the file back the way it was laid out, so the diff only shows
+            // what the step changed.
+            const space = jsonIndentation(code, file === 'composer.json' ? 4 : 2);
+            const json = JSON.stringify(updated, null, space);
+            return code.includes('\r\n') ? json.replace(/\n/g, '\r\n') + (code.endsWith('\r\n') ? '\r\n' : '') : json + (code.endsWith('\n') ? '\n' : '');
         }
         if (updated && 'program' in updated) {
             try {
                 return (0, ast_1.generateCode)(updated, false);
             }
             catch (error) {
-                this.command.warn(`Failed to generate code for ${file}, code: \n${code}`);
-                throw error;
+                throw new Error(`Could not generate code from the transformed syntax tree: ${error.message}`);
             }
         }
         return code;
     }
     async pauseAndConfirm(message, io) {
         const stepMarker = chalk_1.default.bgWhite.black.bold('    DONE    ');
-        this.command.log('\u001B[A     => ' + stepMarker + ' ' + message);
+        this.command.log((0, terminal_1.overwrite)() + '     => ' + stepMarker + ' ' + message);
         this.command.log('');
         await this.command.continueWhenReady(io);
     }

package/lib/steps/upgrade/twopointoh/dependencies.d.ts

@@ -1,10 +1,67 @@
-import { BaseUpgradeStep, GitCommit, Replacement } from './base';
+import { AdvancedContent, BaseUpgradeStep, GitCommit, Replacement } from './base';
 export default class Dependencies extends BaseUpgradeStep {
     type: string;
+    /** The TypeScript the extension asked for, when it was not a 4.x. */
+    protected typeScriptWas: string | null;
+    /** What was removed from tsconfig.json, as TypeScript 4.9 doesn't have it. */
+    protected removedCompilerOptions: string[];
+    protected newerSyntax: boolean;
+    /** Constraints left as they were, as they already ask for newer versions. */
+    protected keptNewer: string[];
+    /** Tooling moved from dependencies to devDependencies. */
+    protected movedToDev: string[];
+    /** The typings scripts, and the tooling they run, added to package.json. */
+    protected addedTypings: string[];
     replacements(file: string): Replacement[];
     targets(): string[];
+    advancedContent(file: string, code: string): AdvancedContent;
+    updateCode(file: string, code: string, updated: string | AdvancedContent): Promise<string>;
     gitCommit(): GitCommit;
     pauseMessage(): string;
+    /**
+     * Require at least the given version, leaving a constraint that already
+     * asks for a newer one as it is.
+     */
+    protected raise(dependencies: Record<string, string>, name: string, version: string): void;
     updateComposerJson(): Replacement;
     updatePackageJson(): Replacement;
+    /**
+     * Add the scripts that build and check typings, which a new extension is
+     * scaffolded with and the reusable frontend workflow runs, along with the
+     * tooling they need. Scripts the extension already has are left alone.
+     */
+    protected addTypingsScripts(pkg: Record<string, any>): void;
+    protected hasTsConfig(): boolean;
+    /** The package manager the extension's frontend uses, by its lockfile. */
+    protected packageManager(): 'yarn' | 'npm';
+    /**
+     * Flarum 2.0 extensions only build with their tooling: none of it ends up
+     * in the bundle, so it belongs in devDependencies. Where the extension lists
+     * a tool under both keys, the newer constraint is kept. Other dependencies
+     * may be libraries the bundle includes, so they stay where they are.
+     */
+    protected moveToolingToDevDependencies(pkg: Record<string, any>): void;
+    /**
+     * Drop the compiler options, and option values, TypeScript 4.9 doesn't have:
+     * it refuses a tsconfig.json with any. A tsconfig.json it can read is left
+     * exactly as it was.
+     */
+    updateTsConfig(): Replacement;
+    /**
+     * TypeScript loads every type package in node_modules unless told which,
+     * and 4.9 can't read the @types/node that webpack's minimizer brings along.
+     * Load only the ones the code imports. The file is edited as text so its
+     * comments stay.
+     */
+    limitTypes(): Replacement;
+    /**
+     * A test config extending tsconfig.json would no longer load Jest's globals.
+     */
+    testTypes(): Replacement;
+    /** The extension's js/package.json, or nothing when it has none. */
+    protected packageJson(): Record<string, any>;
+    /**
+     * Put a @TODO above each line using syntax TypeScript 4.9 can't compile.
+     */
+    flagNewerSyntax(): Replacement;
 }