@flamingo-stack/openframe-frontend-core 0.0.725 → 0.0.727

package/src/components/faq/faq-ask-card.tsx

@@ -1,21 +1,10 @@
 'use client';
 
-import { useMemo, useState } from 'react';
-import {
-  AssistantRuntimeContext,
-  useAssistantRuntime,
-  type AssistantOpenRequest,
-  type AssistantRuntime,
-} from '../../contexts/assistant-runtime-context';
+import { useState } from 'react';
+import type { AssistantOpenRequest, AssistantRuntime } from '../../contexts/assistant-runtime-context';
 import { useInView } from '../../hooks/ui/use-in-view';
-import { AskCard } from '../chat/ask-prompts';
-import {
-  assistantAvailable,
-  ASK_PROMPTS_DEFAULT_COUNT,
-  useAskPrompts,
-  useAssistantOpen,
-  useShownAskPromptIds,
-} from '../chat/hooks/use-ask-prompts';
+import { AssistantAskPrompts } from '../chat/assistant-ask-prompts';
+import { assistantAvailable } from '../chat/hooks/use-ask-prompts';
 
 /** The card beside a FAQ, as a host may shape it. Every field is optional. */
 export interface FaqAskOptions {
@@ -29,8 +18,7 @@ export interface FaqAskOptions {
   topic?: string;
   /**
    * Ids of questions never to offer. Absent: the ones the page's other "ask"
-   * surfaces show (`AssistantAskPrompts` rows say so themselves), which the
-   * card waits for. `null`: wait.
+   * surfaces show, which the card waits for. `null`: wait.
    */
   exclude?: readonly string[] | null;
   /** How many questions the card offers. Absent: the runtime's, else three. */
@@ -46,70 +34,37 @@ export interface FaqAskOptions {
   onOpen?: (request: AssistantOpenRequest) => void;
 }
 
-/** The lib's own wording, when neither the host nor the runtime states it. */
-const DEFAULT_ASK_CARD = {
-  title: 'Still deciding?',
-  description: '{assistant} answers from our docs and customer stories.',
-} as const;
-
 /** How far below the viewport the card is when it picks its questions. */
 const PICK_ROOT_MARGIN = '600px';
 
-const fillAssistant = (text: string, name: string) => text.split('{assistant}').join(name);
-
 /** True when a FAQ under this runtime shows the card: a chat to open, and a name for the card's words. */
 export function faqAskCardShown(assistant: AssistantRuntime | null): assistant is AssistantRuntime {
   return assistantAvailable(assistant) && !!assistant.name;
 }
 
 /**
- * The "ask the assistant" card of a FAQ: the assistant's identity and the
- * chat's opener from the nearest assistant runtime, its questions from the
- * host's endpoint. It picks ONCE, when the card first comes near the viewport:
- * by then the page above has said which questions it shows itself, and a
- * visitor who never reaches the FAQ costs no request. The card is the same
- * height before and after the questions arrive. A host with no questions
- * endpoint gets the launcher with no questions.
+ * The "ask the assistant" card of a FAQ: THE ask surface (`AssistantAskPrompts`)
+ * as a card, told when to pick. It picks ONCE, when the card first comes near
+ * the viewport: a visitor who never reaches the FAQ costs no request, and the
+ * card then leaves out every question the page above already shows. The card
+ * is the same height before and after the questions arrive.
  */
 export function FaqAskCard({ topic, exclude, count, title, description, onOpen }: FaqAskOptions & { topic: string }) {
-  const assistant = useAssistantRuntime();
   const { ref, inView } = useInView<HTMLDivElement>({ rootMargin: PICK_ROOT_MARGIN });
   const [reached, setReached] = useState(false);
   if (inView && !reached) setReached(true);
-
-  const shownElsewhere = useShownAskPromptIds();
-  const excluded = exclude === undefined ? shownElsewhere : exclude;
-  const slots = count ?? assistant?.askCard?.count ?? ASK_PROMPTS_DEFAULT_COUNT;
-  const { prompts, isLoading, supported } = useAskPrompts({
-    topic,
-    count: slots,
-    exclude: excluded ?? undefined,
-    enabled: reached && excluded !== null,
-  });
-  const open = useAssistantOpen(topic, onOpen);
-  // The card's launcher opens the same chat as its questions, with the card's topic: it reads the runtime.
-  const scoped = useMemo(() => (assistant ? { ...assistant, open } : null), [assistant, open]);
-
-  if (!faqAskCardShown(assistant) || !assistant.name) return null;
-  const name = assistant.name;
-  const cardDescription = description ?? assistant.askCard?.description ?? DEFAULT_ASK_CARD.description;
   return (
-    <AssistantRuntimeContext.Provider value={scoped}>
-      <div ref={ref}>
-        <AskCard
-          title={fillAssistant(title ?? assistant.askCard?.title ?? DEFAULT_ASK_CARD.title, name)}
-          description={cardDescription ? fillAssistant(cardDescription, name) : undefined}
-          prompts={prompts}
-          // Fixed slots, one question per row: chip skeletons until the pick lands, the same box after.
-          count={supported ? slots : 0}
-          loading={isLoading}
-          source={assistant.source}
-          label={name}
-          icon={assistant.icon}
-          onOpen={open}
-          onAsk={prompt => assistant.onAsk?.({ promptId: prompt.id, topic })}
-        />
-      </div>
-    </AssistantRuntimeContext.Provider>
+    <div ref={ref}>
+      <AssistantAskPrompts
+        variant="card"
+        topic={topic}
+        count={count}
+        exclude={exclude}
+        enabled={reached}
+        title={title}
+        description={description}
+        onOpen={onOpen}
+      />
+    </div>
   );
 }

package/src/utils/source-grouping.ts

@@ -28,14 +28,23 @@ import { defaultDocumentTypeForTableId, getSourceLabel } from './source-icons';
 /**
  * Doc-table documentTypes: whole documents with their own viewer (markdown =
  * product docs, data_room_doc = data room). They carry an in-app `path`, an
- * embedder keys `docPlatformTargets` by them, and they NEVER group: one chip
- * per document. The hub's per-source contract test pins this list to its
+ * embedder keys `docPlatformTargets` by them, and a server never folds them
+ * into one citation (`groupsByTable`); the strip still draws them as one chip
+ * per table. The hub's per-source contract test pins this list to its
  * doc-table configs.
  */
 export const DOC_TABLE_TYPES = ['markdown', 'data_room_doc'] as const;
 
-/** THE rule: rows of a knowledge table share one chip unless they are whole
- *  documents. Decided by `documentType`, the one fact every producer has. */
+/**
+ * Which tables a SERVER folds into one citation: rows of a knowledge table
+ * share one number (and reach the model as one table) unless they are whole
+ * documents, which each keep their own number and are read in full. Decided by
+ * `documentType`, the one fact every producer has.
+ *
+ * This is not the strip's rule. The strip (`groupSourcesByTable`) draws ONE chip
+ * per table for every source, documents included: a document keeps its own
+ * citation number inside its table's chip.
+ */
 export function groupsByTable(documentType: string | null | undefined): boolean {
   return !(DOC_TABLE_TYPES as readonly string[]).includes(documentType ?? '');
 }
@@ -98,16 +107,16 @@ function typeOf(source: TableSource): string {
   return source.documentType || defaultDocumentTypeForTableId(source.sourceRepo) || '';
 }
 
-/** A source that belongs to its table's chip: it names its table and is not a
- *  whole document. Both shapes qualify, a flat row AND a chip the server
- *  already grouped, so one table is never drawn twice. Naming the table is the
- *  ONLY requirement: a row with no `id`, or no `documentType`, still joins (as
- *  the hub's server-side chips do). Leaving it out would split one table
- *  across a group AND a stray chip. What it lacks only limits its dropdown
- *  row: no `id` or no type means Open-only, no Ask. */
+/** A source that belongs to its table's chip: it names its table. Whole
+ *  documents join their table's chip like every other record (each keeps its
+ *  own citation number as a dropdown row). Both shapes qualify, a flat row AND
+ *  a chip the server already grouped, so one table is never drawn twice.
+ *  Naming the table is the ONLY requirement: a row with no `id`, or no
+ *  `documentType`, still joins (as the hub's server-side chips do). Leaving it
+ *  out would split one table across a group AND a stray chip. What it lacks
+ *  only limits its dropdown row: no `id` or no type means Open-only, no Ask. */
 function joinsTableChip(source: ChatSource): source is TableSource {
-  if (!source.sourceRepo) return false;
-  return groupsByTable(typeOf({ ...source, sourceRepo: source.sourceRepo }));
+  return !!source.sourceRepo;
 }
 
 /** A source's dropdown rows: a grouped chip's own items, or the flat row itself. */
@@ -154,7 +163,8 @@ function uniqueRows(rows: GroupedSourceRow[]): GroupedSourceRow[] {
  * table's only source. When flat rows of the same table arrive beside it (a
  * hub-injected chip plus MCP-cited rows in one answer), they merge into it:
  * its rows first, its chip-level link kept, the count restated. Whole
- * documents and rows naming no table pass through as their own chips.
+ * documents group under their table too, each row keeping its own citation
+ * number; only a row naming no table passes through as its own chip.
  */
 export function groupSourcesByTable(sources: ChatSource[]): ChatSource[] {
   const membersByTable = new Map<string, TableSource[]>();

package/src/utils/source-icons.ts

@@ -64,11 +64,11 @@ export const SOURCE_ICON_NAMES: Record<string, string> = {
 
   // Financials
   'investor-updates': 'mail',
-  'financial-kpis': 'activity',
-  'financial-cap-table': 'table',
-  'financial-pnl': 'trending-up',
-  'financial-balance-sheet': 'dollar-sign',
-  'financial-cash-flow': 'banknote',
+  'financial-kpis': 'chart-bar-01-ver',
+  'financial-cap-table': 'chart-pie',
+  'financial-pnl': 'money-bill-dollar',
+  'financial-balance-sheet': 'bank',
+  'financial-cash-flow': 'coins-exchange-currency',
 
   // ClickUp
   'clickup-roadmap': 'clickup',
@@ -92,24 +92,24 @@ export const SOURCE_ICON_NAMES: Record<string, string> = {
   'slack-messages': 'slack',
 
   // People-hub employee content
-  'what-i-shipped': 'package',
-  'how-i-work': 'book-open',
-  'ai-prompts': 'message-square',
+  'what-i-shipped': 'rocket-02',
+  'how-i-work': 'clipboard-list',
+  'ai-prompts': 'chat-quote',
 
   // Product-hub internal
   'design-docs': 'file-text',
   'openframe-tenants': 'openframe',
-  'prospect-calls': 'phone',
+  'prospect-calls': 'call',
 
   // Code intelligence
-  'code-rules': 'check-square',
-  'code-graph-repos': 'github',
+  'code-rules': 'bracket-curly-check',
+  'code-graph-repos': 'coding-branch',
   'code-graph-deployments': 'package',
-  'code-graph-files': 'file-text',
-  'code-symbols': 'box',
-  'code-duplicates': 'search',
-  'code-impact': 'activity',
-  'change-sets': 'coding-branch',
+  'code-graph-files': 'file-code',
+  'code-symbols': 'code-square',
+  'code-duplicates': 'copy-01',
+  'code-impact': 'coding-pull-request',
+  'change-sets': 'coding-merge',
 };
 
 /** Lookup an icon name by RagTableConfig.id. Returns undefined when