@flamingo-stack/openframe-frontend-core 0.0.670 → 0.0.671

package/src/__tests__/search-input-submit-on-clear.test.tsx

@@ -0,0 +1,32 @@
+import { fireEvent, render, screen } from '@testing-library/react';
+import { useState } from 'react';
+import { describe, expect, it, vi } from 'vitest';
+import { SearchInput } from '../components/ui/search-input';
+
+// An enter-to-search host: a submitted search must not stay applied once its text is gone.
+function Host({ onSubmit }: { onSubmit: (v: string) => void }) {
+  const [value, setValue] = useState('sso');
+  return (
+    <SearchInput value={value} onChange={setValue} onSubmit={onSubmit} showDropdown={false} placeholder="Search" />
+  );
+}
+
+describe('SearchInput submits the empty search when the box is emptied', () => {
+  it('by the clear button', () => {
+    const onSubmit = vi.fn();
+    render(<Host onSubmit={onSubmit} />);
+    fireEvent.click(screen.getByLabelText('Clear search'));
+    expect(onSubmit).toHaveBeenCalledWith('');
+  });
+
+  it('by deleting the text, once (not on every keystroke, and not when it was already empty)', () => {
+    const onSubmit = vi.fn();
+    render(<Host onSubmit={onSubmit} />);
+    const input = screen.getByPlaceholderText('Search');
+    fireEvent.change(input, { target: { value: 'ss' } });
+    expect(onSubmit).not.toHaveBeenCalled();
+    fireEvent.change(input, { target: { value: '' } });
+    expect(onSubmit).toHaveBeenCalledTimes(1);
+    expect(onSubmit).toHaveBeenCalledWith('');
+  });
+});

package/src/components/ui/search-input.tsx

@@ -51,7 +51,11 @@ export interface SearchInputProps {
   defaultValue?: string;
   /** Called when input value changes (raw, not debounced) */
   onChange?: (value: string) => void;
-  /** Called when user presses Enter */
+  /**
+   * Called when the user presses Enter, AND with `''` when the box is emptied (the clear button, or deleting the
+   * text): a search that was submitted must not stay applied after its text is gone. Read the argument, never the
+   * host's own state, which has not re-rendered yet when this fires.
+   */
   onSubmit?: (value: string) => void;
   /** Search results to display in the dropdown */
   results?: SearchResult[];
@@ -292,6 +296,7 @@ export function SearchInput({
     } else {
       setInternalValue(newVal);
     }
+    if (newVal === '' && currentValue !== '') onSubmit?.('');
     if (!isOpen) setIsOpen(true);
     setHighlightedIndex(-1);
   };
@@ -304,6 +309,7 @@ export function SearchInput({
     } else {
       setInternalValue('');
     }
+    if (currentValue !== '') onSubmit?.('');
     inputRef.current?.focus();
   };
 

package/src/types/design-doc.ts

@@ -376,7 +376,11 @@ export interface DesignDocListResponse {
   count: number;
   /** Server-computed spec-mode counts over the scope, MINUS the spec-mode
    *  filter itself — so a filtered row still shows what the other value holds. */
-  facets: { spec_mode: Record<string, number> };
+  facets: {
+    spec_mode: Record<string, number>;
+    /** The same over readiness (`ready` / `not_ready`), MINUS the ready filter itself: the filter row's options. */
+    ready: Record<'ready' | 'not_ready', number>;
+  };
 }
 
 export interface DesignDocStats {