@flamingo-stack/openframe-frontend-core 0.0.508 → 0.0.509

package/src/components/chat/utils/__tests__/__snapshots__/segment-accumulator-golden.test.ts.snap

@@ -0,0 +1,605 @@
+// Vitest Snapshot v1, https://vitest.dev/guide/snapshot.html
+
+exports[`MessageSegmentAccumulator — golden sequences > CHARACTERIZATION: a LATE standalone EXECUTING after its EXECUTED pushes a NEW executing segment (no in-place downgrade, but a duplicate card appears) 1`] = `
+[
+  {
+    "data": {
+      "integratedToolType": "TACTICAL_RMM",
+      "parameters": {
+        "script": "cleanup.sh",
+      },
+      "result": "Freed 2.3 GB",
+      "success": true,
+      "toolExecutionRequestId": "exec-1",
+      "toolExplanation": undefined,
+      "toolFunction": "run_script",
+      "toolTitle": "Run cleanup script",
+      "type": "EXECUTED_TOOL",
+    },
+    "type": "tool_execution",
+  },
+  {
+    "data": {
+      "integratedToolType": "TACTICAL_RMM",
+      "parameters": {
+        "script": "cleanup.sh",
+      },
+      "toolExecutionRequestId": "exec-1",
+      "toolFunction": "run_script",
+      "toolTitle": "Run cleanup script",
+      "type": "EXECUTING_TOOL",
+    },
+    "type": "tool_execution",
+  },
+]
+`;
+
+exports[`MessageSegmentAccumulator — golden sequences > EXECUTED with no prior EXECUTING lands as a standalone completed segment 1`] = `
+[
+  {
+    "data": {
+      "integratedToolType": "TACTICAL_RMM",
+      "parameters": undefined,
+      "result": "Freed 2.3 GB",
+      "success": true,
+      "toolExecutionRequestId": "exec-orphan",
+      "toolExplanation": undefined,
+      "toolFunction": "run_script",
+      "toolTitle": undefined,
+      "type": "EXECUTED_TOOL",
+    },
+    "type": "tool_execution",
+  },
+]
+`;
+
+exports[`MessageSegmentAccumulator — golden sequences > addApprovalBatch upserts by approvalRequestId (replay path produces ONE batch segment) 1`] = `
+[
+  {
+    "data": {
+      "approvalRequestId": "batch-1",
+      "approvalType": "CLIENT",
+      "executions": {
+        "exec-a": {
+          "result": "ok",
+          "status": "done",
+          "success": true,
+        },
+      },
+      "toolCalls": [
+        {
+          "approvalType": "CLIENT",
+          "requiresApproval": true,
+          "toolCallArguments": {
+            "subject": "Printer down",
+          },
+          "toolExecutionRequestId": "exec-a",
+          "toolExplanation": "Opens a support ticket",
+          "toolName": "create_ticket",
+          "toolTitle": "Create ticket",
+        },
+        {
+          "approvalType": null,
+          "requiresApproval": false,
+          "toolCallArguments": null,
+          "toolExecutionRequestId": "exec-b",
+          "toolName": "read_kb",
+        },
+      ],
+    },
+    "onApprove": undefined,
+    "onReject": undefined,
+    "resolvedByName": "Jane Admin",
+    "status": "approved",
+    "type": "approval_batch",
+  },
+]
+`;
+
+exports[`MessageSegmentAccumulator — golden sequences > batch approval with per-tool executions merged into the batch (no standalone segments) 1`] = `
+[
+  {
+    "data": {
+      "approvalRequestId": "batch-1",
+      "approvalType": "CLIENT",
+      "executions": {
+        "exec-a": {
+          "result": "Ticket #77 created",
+          "status": "done",
+          "success": true,
+        },
+        "exec-b": {
+          "result": undefined,
+          "status": "executing",
+          "success": undefined,
+        },
+      },
+      "toolCalls": [
+        {
+          "approvalType": "CLIENT",
+          "requiresApproval": true,
+          "toolCallArguments": {
+            "subject": "Printer down",
+          },
+          "toolExecutionRequestId": "exec-a",
+          "toolExplanation": "Opens a support ticket",
+          "toolName": "create_ticket",
+          "toolTitle": "Create ticket",
+        },
+        {
+          "approvalType": null,
+          "requiresApproval": false,
+          "toolCallArguments": null,
+          "toolExecutionRequestId": "exec-b",
+          "toolName": "read_kb",
+        },
+      ],
+    },
+    "onApprove": undefined,
+    "onReject": undefined,
+    "resolvedByName": "Jane Admin",
+    "status": "approved",
+    "type": "approval_batch",
+  },
+]
+`;
+
+exports[`MessageSegmentAccumulator — golden sequences > batch no-downgrade rule: a redelivered EXECUTING after EXECUTED keeps the done slot 1`] = `
+[
+  {
+    "data": {
+      "approvalRequestId": "batch-1",
+      "approvalType": "CLIENT",
+      "executions": {
+        "exec-a": {
+          "result": "done!",
+          "status": "done",
+          "success": true,
+        },
+      },
+      "toolCalls": [
+        {
+          "approvalType": "CLIENT",
+          "requiresApproval": true,
+          "toolCallArguments": {
+            "subject": "Printer down",
+          },
+          "toolExecutionRequestId": "exec-a",
+          "toolExplanation": "Opens a support ticket",
+          "toolName": "create_ticket",
+          "toolTitle": "Create ticket",
+        },
+        {
+          "approvalType": null,
+          "requiresApproval": false,
+          "toolCallArguments": null,
+          "toolExecutionRequestId": "exec-b",
+          "toolName": "read_kb",
+        },
+      ],
+    },
+    "onApprove": undefined,
+    "onReject": undefined,
+    "resolvedByName": undefined,
+    "status": "approved",
+    "type": "approval_batch",
+  },
+]
+`;
+
+exports[`MessageSegmentAccumulator — golden sequences > coalesces consecutive text deltas into one text segment 1`] = `
+[
+  {
+    "text": "Hello, world",
+    "type": "text",
+  },
+]
+`;
+
+exports[`MessageSegmentAccumulator — golden sequences > coalesces thinking deltas, and text after thinking starts a NEW segment 1`] = `
+[
+  {
+    "text": "Let me think… ok.",
+    "type": "thinking",
+  },
+  {
+    "text": "Answer: 42",
+    "type": "text",
+  },
+  {
+    "text": "post-answer thought",
+    "type": "thinking",
+  },
+]
+`;
+
+exports[`MessageSegmentAccumulator — golden sequences > completeContextCompaction with no started segment pushes a completed one 1`] = `
+[
+  {
+    "status": "completed",
+    "summary": undefined,
+    "type": "context_compaction",
+  },
+]
+`;
+
+exports[`MessageSegmentAccumulator — golden sequences > context compaction start → complete replaces the started segment in place 1`] = `
+[
+  {
+    "text": "Before compaction",
+    "type": "text",
+  },
+  {
+    "status": "completed",
+    "summary": "Summarized 34 messages",
+    "type": "context_compaction",
+  },
+  {
+    "text": "After compaction",
+    "type": "text",
+  },
+]
+`;
+
+exports[`MessageSegmentAccumulator — golden sequences > error segments append verbatim 1`] = `
+[
+  {
+    "text": "partial answer",
+    "type": "text",
+  },
+  {
+    "details": "boom",
+    "title": "Agent crashed",
+    "type": "error",
+  },
+]
+`;
+
+exports[`MessageSegmentAccumulator — golden sequences > flushPendingApprovals emits pending cards for every tracked-but-unresolved approval 1`] = `
+[
+  {
+    "data": {
+      "approvalType": "CLIENT",
+      "command": "cmd-1",
+      "explanation": undefined,
+      "requestId": "req-1",
+    },
+    "onApprove": undefined,
+    "onReject": undefined,
+    "status": "pending",
+    "type": "approval_request",
+  },
+  {
+    "data": {
+      "approvalType": "ADMIN",
+      "command": "cmd-2",
+      "explanation": "why",
+      "requestId": "req-2",
+    },
+    "onApprove": undefined,
+    "onReject": undefined,
+    "status": "pending",
+    "type": "approval_request",
+  },
+]
+`;
+
+exports[`MessageSegmentAccumulator — golden sequences > implicit approval does NOT touch approval_batch segments (handled by applyExecutionToBatch only) 1`] = `
+[
+  {
+    "data": {
+      "approvalRequestId": "batch-1",
+      "approvalType": "CLIENT",
+      "toolCalls": [
+        {
+          "approvalType": "CLIENT",
+          "requiresApproval": true,
+          "toolCallArguments": {
+            "subject": "Printer down",
+          },
+          "toolExecutionRequestId": "exec-a",
+          "toolExplanation": "Opens a support ticket",
+          "toolName": "create_ticket",
+          "toolTitle": "Create ticket",
+        },
+        {
+          "approvalType": null,
+          "requiresApproval": false,
+          "toolCallArguments": null,
+          "toolExecutionRequestId": "exec-b",
+          "toolName": "read_kb",
+        },
+      ],
+    },
+    "onApprove": undefined,
+    "onReject": undefined,
+    "resolvedByName": undefined,
+    "status": "pending",
+    "type": "approval_batch",
+  },
+  {
+    "data": {
+      "integratedToolType": "TACTICAL_RMM",
+      "parameters": {
+        "script": "cleanup.sh",
+      },
+      "toolExecutionRequestId": "exec-unrelated",
+      "toolFunction": "run_script",
+      "toolTitle": "Run cleanup script",
+      "type": "EXECUTING_TOOL",
+    },
+    "type": "tool_execution",
+  },
+]
+`;
+
+exports[`MessageSegmentAccumulator — golden sequences > implicit approval flips ONLY the latest pending gate, earlier pending gates stay pending 1`] = `
+[
+  {
+    "data": {
+      "approvalType": "CLIENT",
+      "command": "first",
+      "explanation": undefined,
+      "requestId": "req-1",
+    },
+    "onApprove": undefined,
+    "onReject": undefined,
+    "status": "pending",
+    "type": "approval_request",
+  },
+  {
+    "data": {
+      "approvalType": "CLIENT",
+      "command": "second",
+      "explanation": undefined,
+      "requestId": "req-2",
+    },
+    "onApprove": undefined,
+    "onReject": undefined,
+    "status": "approved",
+    "type": "approval_request",
+  },
+  {
+    "data": {
+      "integratedToolType": "TACTICAL_RMM",
+      "parameters": {
+        "script": "cleanup.sh",
+      },
+      "toolExecutionRequestId": "exec-1",
+      "toolFunction": "run_script",
+      "toolTitle": "Run cleanup script",
+      "type": "EXECUTING_TOOL",
+    },
+    "type": "tool_execution",
+  },
+]
+`;
+
+exports[`MessageSegmentAccumulator — golden sequences > implicit resolvePendingApprovalForExecution: a tool execution flips the LATEST pending single approval (NATS-observer behavior) 1`] = `
+[
+  {
+    "data": {
+      "approvalType": "CLIENT",
+      "command": "echo old",
+      "explanation": undefined,
+      "requestId": "req-old",
+    },
+    "onApprove": undefined,
+    "onReject": undefined,
+    "status": "rejected",
+    "type": "approval_request",
+  },
+  {
+    "data": {
+      "approvalType": "CLIENT",
+      "command": "systemctl restart nats",
+      "explanation": undefined,
+      "requestId": "req-1",
+    },
+    "onApprove": undefined,
+    "onReject": undefined,
+    "status": "approved",
+    "type": "approval_request",
+  },
+  {
+    "data": {
+      "integratedToolType": "TACTICAL_RMM",
+      "parameters": {
+        "script": "cleanup.sh",
+      },
+      "toolExecutionRequestId": "exec-9",
+      "toolFunction": "run_script",
+      "toolTitle": "Run cleanup script",
+      "type": "EXECUTING_TOOL",
+    },
+    "type": "tool_execution",
+  },
+]
+`;
+
+exports[`MessageSegmentAccumulator — golden sequences > initializeWithState continues an incomplete message across reconnect 1`] = `
+[
+  {
+    "text": "partial ",
+    "type": "text",
+  },
+  {
+    "data": {
+      "integratedToolType": "TACTICAL_RMM",
+      "parameters": {
+        "script": "cleanup.sh",
+      },
+      "result": "Freed 2.3 GB",
+      "success": true,
+      "toolExecutionRequestId": "exec-1",
+      "toolExplanation": undefined,
+      "toolFunction": "run_script",
+      "toolTitle": "Run cleanup script",
+      "type": "EXECUTED_TOOL",
+    },
+    "type": "tool_execution",
+  },
+  {
+    "text": "and the rest.",
+    "type": "text",
+  },
+]
+`;
+
+exports[`MessageSegmentAccumulator — golden sequences > merges EXECUTING_TOOL → EXECUTED_TOOL in place by toolExecutionRequestId (title restored) 1`] = `
+[
+  {
+    "text": "Running a cleanup now.",
+    "type": "text",
+  },
+  {
+    "data": {
+      "integratedToolType": "TACTICAL_RMM",
+      "parameters": {
+        "script": "cleanup.sh",
+      },
+      "result": "Freed 2.3 GB",
+      "success": true,
+      "toolExecutionRequestId": "exec-1",
+      "toolExplanation": undefined,
+      "toolFunction": "run_script",
+      "toolTitle": "Run cleanup script",
+      "type": "EXECUTED_TOOL",
+    },
+    "type": "tool_execution",
+  },
+]
+`;
+
+exports[`MessageSegmentAccumulator — golden sequences > pairs by (integratedToolType, toolFunction) when no exec id is present (older backends) 1`] = `
+[
+  {
+    "data": {
+      "integratedToolType": "TACTICAL_RMM",
+      "parameters": {
+        "script": "cleanup.sh",
+      },
+      "result": "Freed 2.3 GB",
+      "success": true,
+      "toolExplanation": undefined,
+      "toolFunction": "run_script",
+      "toolTitle": "Run cleanup script",
+      "type": "EXECUTED_TOOL",
+    },
+    "type": "tool_execution",
+  },
+]
+`;
+
+exports[`MessageSegmentAccumulator — golden sequences > replaySegments reproduces a mixed recorded segment array (idempotent replay) 1`] = `
+[
+  {
+    "text": "hmm",
+    "type": "thinking",
+  },
+  {
+    "text": "Sure — ",
+    "type": "text",
+  },
+  {
+    "data": {
+      "integratedToolType": "TACTICAL_RMM",
+      "parameters": {
+        "script": "cleanup.sh",
+      },
+      "result": "Freed 2.3 GB",
+      "success": true,
+      "toolExecutionRequestId": "exec-1",
+      "toolExplanation": undefined,
+      "toolFunction": "run_script",
+      "toolTitle": "Run cleanup script",
+      "type": "EXECUTED_TOOL",
+    },
+    "type": "tool_execution",
+  },
+  {
+    "data": {
+      "approvalRequestId": "batch-1",
+      "approvalType": "CLIENT",
+      "executions": {
+        "exec-a": {
+          "result": "ok",
+          "status": "done",
+          "success": true,
+        },
+      },
+      "toolCalls": [
+        {
+          "approvalType": "CLIENT",
+          "requiresApproval": true,
+          "toolCallArguments": {
+            "subject": "Printer down",
+          },
+          "toolExecutionRequestId": "exec-a",
+          "toolExplanation": "Opens a support ticket",
+          "toolName": "create_ticket",
+          "toolTitle": "Create ticket",
+        },
+        {
+          "approvalType": null,
+          "requiresApproval": false,
+          "toolCallArguments": null,
+          "toolExecutionRequestId": "exec-b",
+          "toolName": "read_kb",
+        },
+      ],
+    },
+    "onApprove": undefined,
+    "onReject": undefined,
+    "resolvedByName": undefined,
+    "status": "approved",
+    "type": "approval_batch",
+  },
+  {
+    "text": "done.",
+    "type": "text",
+  },
+]
+`;
+
+exports[`MessageSegmentAccumulator — golden sequences > single approval request → updateApprovalStatus flips status and stamps resolvedByName only on batches 1`] = `
+[
+  {
+    "data": {
+      "approvalType": "CLIENT",
+      "command": "systemctl restart nats",
+      "explanation": "Restart broker",
+      "requestId": "req-1",
+    },
+    "onApprove": [Function],
+    "onReject": [Function],
+    "status": "approved",
+    "type": "approval_request",
+  },
+]
+`;
+
+exports[`MessageSegmentAccumulator — golden sequences > tracked (pending) approval + processApprovalResult appends a resolved segment 1`] = `
+{
+  "hasPendingAfter": false,
+  "pendingData": {
+    "approvalType": "CLIENT",
+    "command": "rm -rf /tmp/cache",
+    "explanation": "Clear caches",
+  },
+  "segments": [
+    {
+      "data": {
+        "approvalType": "CLIENT",
+        "command": "rm -rf /tmp/cache",
+        "explanation": "Clear caches",
+        "requestId": "req-2",
+      },
+      "onApprove": undefined,
+      "onReject": undefined,
+      "status": "rejected",
+      "type": "approval_request",
+    },
+  ],
+}
+`;

package/src/components/chat/utils/__tests__/extract-incomplete-message-state.test.ts

@@ -0,0 +1,106 @@
+import { describe, expect, it } from 'vitest'
+import type { MessageSegment, ProcessedMessage } from '../../types'
+import { extractIncompleteTailState } from '../extract-incomplete-message-state'
+
+/**
+ * `agentBusy` is the restore-time counterpart of a live `onAgentBusy`: after a
+ * reload nothing on the wire re-establishes the activity indicator, so it has
+ * to be derived from the persisted tail. The distinction it draws is the whole
+ * point — an unfinished turn can be unfinished because the AGENT is working, or
+ * because it is BLOCKED ON THE USER, and only the first should spin.
+ */
+
+const assistant = (content: MessageSegment[]): ProcessedMessage =>
+  ({ id: 'a1', role: 'assistant', content }) as unknown as ProcessedMessage
+
+const user = (): ProcessedMessage => ({ id: 'u1', role: 'user', content: 'go' }) as unknown as ProcessedMessage
+
+const batch = (
+  status: string | undefined,
+  executions?: Record<string, { status: string }>,
+): MessageSegment =>
+  ({
+    type: 'approval_batch',
+    status,
+    data: {
+      approvalRequestId: 'req-1',
+      toolCalls: [{ toolExecutionRequestId: 'exec-1' }, { toolExecutionRequestId: 'exec-2' }],
+      executions,
+    },
+  }) as unknown as MessageSegment
+
+const request = (status: string | undefined): MessageSegment =>
+  ({
+    type: 'approval_request',
+    status,
+    data: { requestId: 'req-2', command: 'rm -rf /tmp/cache', approvalType: 'CLIENT' },
+  }) as unknown as MessageSegment
+
+const executing = (): MessageSegment =>
+  ({
+    type: 'tool_execution',
+    data: {
+      type: 'EXECUTING_TOOL',
+      integratedToolType: 'openframe',
+      toolFunction: 'search_machines',
+      toolExecutionRequestId: 'exec-9',
+    },
+  }) as unknown as MessageSegment
+
+describe('extractIncompleteTailState → agentBusy', () => {
+  it('is set for an APPROVED batch whose tool calls are still running', () => {
+    // The reported case: the operator approves a batch, reloads, and the thread
+    // renders as if nothing were happening. A batch records its runs INSIDE the
+    // segment, so `executingTools` is empty here — gating the indicator on that
+    // map missed the entire approval path.
+    const extras = extractIncompleteTailState([user(), assistant([batch('approved')])])
+    expect(extras?.agentBusy).toBe(true)
+  })
+
+  it('is NOT set while the batch is still awaiting the user', () => {
+    const extras = extractIncompleteTailState([user(), assistant([batch('pending')])])
+    expect(extras).toBeDefined()
+    expect(extras?.agentBusy).toBeUndefined()
+  })
+
+  it('is NOT set once every call in the batch is done', () => {
+    const extras = extractIncompleteTailState([
+      user(),
+      assistant([batch('approved', { 'exec-1': { status: 'done' }, 'exec-2': { status: 'done' } })]),
+    ])
+    expect(extras?.agentBusy).toBeUndefined()
+  })
+
+  it('is set for a trailing APPROVED single request (nothing produced since)', () => {
+    const extras = extractIncompleteTailState([user(), assistant([request('approved')])])
+    expect(extras?.agentBusy).toBe(true)
+  })
+
+  it('is NOT set when work already followed the approved request', () => {
+    // Position is the only signal for a single request: work after it means the
+    // agent came back. Here that work is itself finished.
+    const extras = extractIncompleteTailState([
+      user(),
+      assistant([request('approved'), { type: 'text', text: 'done, 2 endpoints online' }]),
+    ])
+    expect(extras).toBeUndefined()
+  })
+
+  it('is set for a tool left mid-flight', () => {
+    const extras = extractIncompleteTailState([user(), assistant([executing()])])
+    expect(extras?.agentBusy).toBe(true)
+  })
+
+  it('is set for an open compaction (the agent’s own work)', () => {
+    const extras = extractIncompleteTailState([
+      user(),
+      assistant([{ type: 'context_compaction', status: 'started' } as unknown as MessageSegment]),
+    ])
+    expect(extras?.agentBusy).toBe(true)
+  })
+
+  it('reports nothing for a finished tail', () => {
+    const extras = extractIncompleteTailState([user(), assistant([{ type: 'text', text: 'all good' }])])
+    expect(extras).toBeUndefined()
+  })
+})