@flamingo-stack/openframe-frontend-core 0.0.498-1506.4000.1 → 0.0.498

package/src/components/chat/__tests__/chat-pending-turn.test.tsx

@@ -1,250 +0,0 @@
-/**
- * Pending-turn + hidden-row contracts.
- *
- * Two reader-visible defects this pins against:
- *
- *  1. Approving a tool call minted an author-label row with NO body
- *     ("Michael Assraf:" then nothing). The approval decision is
- *     out-of-band metadata, so the reducer must not materialize a user
- *     row for it at all — fixing it at render would leave dead state.
- *  2. While the model was thinking, the transcript showed a second,
- *     empty "Mingo:" row ABOVE the footer progress indicator — two
- *     owners for one pending turn, and an `aria-live` log announcing a
- *     bare "Mingo". Exactly one affordance must be present.
- *
- * Plus the two idioms that must SURVIVE both fixes: a hidden row that
- * carries real text (auto-continuation directive) stays in state while
- * never rendering, and the SYSTEM name-only row still renders.
- */
-
-import { render } from '@testing-library/react'
-import { describe, expect, it, vi } from 'vitest'
-import { createChatStreamReducer } from '../stream/chat-stream-reducer'
-import {
-  AUTO_CONTINUATION_DIRECTIVE_PREFIX,
-  buildAutoContinuationDirective,
-} from '../utils/auto-continuation-directive'
-import type { Message } from '../types/message.types'
-
-// ─── Render harness (mirrors chat-message-list.test.tsx) ────────────────────
-
-const scrollToBottom = vi.fn()
-const stopScroll = vi.fn()
-
-function makeRef() {
-  const fn = ((el: HTMLElement | null) => {
-    ;(fn as { current: HTMLElement | null }).current = el
-  }) as ((el: HTMLElement | null) => void) & { current: HTMLElement | null }
-  fn.current = null
-  return fn
-}
-
-vi.mock('use-stick-to-bottom', () => ({
-  useStickToBottom: () => ({
-    scrollRef: makeRef(),
-    contentRef: makeRef(),
-    scrollToBottom,
-    stopScroll,
-  }),
-}))
-
-// Row stub that renders the author label the way the real component does
-// (`Name:`), so "labeled row with no body" is directly assertable.
-vi.mock('../chat-message-enhanced', () => ({
-  ChatMessageEnhanced: ({ name, content }: { name?: string; content: unknown }) => (
-    <div data-testid="row">
-      <span data-testid="row-name">{name ?? ''}</span>
-      <span data-testid="row-body">
-        {typeof content === 'string'
-          ? content
-          : Array.isArray(content)
-            ? content
-                .map((s) => (s && (s as { type?: string }).type === 'text' ? (s as { text: string }).text : '[seg]'))
-                .join('')
-            : ''}
-      </span>
-    </div>
-  ),
-}))
-
-import { ChatMessageList } from '../chat-message-list'
-
-class ObserverStub {
-  observe() {}
-  unobserve() {}
-  disconnect() {}
-}
-vi.stubGlobal('IntersectionObserver', ObserverStub)
-vi.stubGlobal('ResizeObserver', ObserverStub)
-
-const names = (c: HTMLElement) =>
-  Array.from(c.querySelectorAll('[data-testid="row-name"]')).map((n) => n.textContent)
-const bodies = (c: HTMLElement) =>
-  Array.from(c.querySelectorAll('[data-testid="row-body"]')).map((n) => n.textContent)
-
-// ─── State-level contracts ─────────────────────────────────────────────────
-
-describe('approval sends mint no visible user row', () => {
-  it('beginSseSend with empty text pushes only the assistant placeholder', () => {
-    const r = createChatStreamReducer({ transport: 'sse' })
-    // What `cardApprove` triggers: ('', { hidden: true, approvalAction }).
-    r.beginSseSend({ text: '', hidden: true, assistantName: 'Mingo AI' })
-
-    expect(r.state.messages).toHaveLength(1)
-    expect(r.state.messages[0].role).toBe('assistant')
-    expect(r.state.messages.some((m) => m.role === 'user')).toBe(false)
-    expect(r.state.streamingPhase).toBe('thinking')
-  })
-
-  it('pushOptimisticSend with empty text likewise mints no user row', () => {
-    const r = createChatStreamReducer({ transport: 'nats' })
-    r.pushOptimisticSend('', true)
-
-    expect(r.state.messages).toHaveLength(1)
-    expect(r.state.messages[0].role).toBe('assistant')
-  })
-
-  it('a normal send still mints the user row', () => {
-    const r = createChatStreamReducer({ transport: 'sse' })
-    r.beginSseSend({ text: 'hello', assistantName: 'Mingo AI' })
-
-    expect(r.state.messages).toHaveLength(2)
-    expect(r.state.messages[0]).toMatchObject({ role: 'user', content: 'hello' })
-    expect(r.state.messages[0].hidden).toBeUndefined()
-  })
-})
-
-describe('hidden rows that carry text', () => {
-  it('an auto-continuation directive IS state (the model sees it) but is flagged hidden', () => {
-    const directive = buildAutoContinuationDirective('create_ticket', { ticketId: '42' })
-    expect(directive.startsWith(AUTO_CONTINUATION_DIRECTIVE_PREFIX)).toBe(true)
-
-    const r = createChatStreamReducer({ transport: 'sse' })
-    r.beginSseSend({ text: directive, hidden: true, assistantName: 'Mingo AI' })
-
-    const userRow = r.state.messages.find((m) => m.role === 'user')
-    expect(userRow?.content).toBe(directive)
-    expect(userRow?.hidden).toBe(true)
-  })
-
-  it('never renders — the raw directive text must not reach the transcript', () => {
-    const directive = buildAutoContinuationDirective('create_ticket', { ticketId: '42' })
-    const messages: Message[] = [
-      { id: 'u1', role: 'user', name: 'Michael Assraf', content: 'my laptop is dead' },
-      { id: 'h1', role: 'user', name: 'Michael Assraf', content: directive, hidden: true },
-      { id: 'a1', role: 'assistant', name: 'Mingo', content: 'Opened a ticket.' },
-    ]
-    const { container } = render(<ChatMessageList dialogId="d" messages={messages} />)
-
-    expect(container.textContent).not.toContain(AUTO_CONTINUATION_DIRECTIVE_PREFIX)
-    expect(bodies(container)).toEqual(['my laptop is dead', 'Opened a ticket.'])
-  })
-})
-
-// ─── Render-level contracts ────────────────────────────────────────────────
-
-describe('a thinking turn has exactly ONE pending affordance', () => {
-  const pending: Message[] = [
-    { id: 'u1', role: 'user', name: 'Michael Assraf', content: 'what is broken?' },
-    // `Message` carries its body in `content` — there is no `segments` field on
-    // it (that is `UnifiedChatMessage`), and the render path never reads one.
-    // An empty `content` IS the empty pending turn.
-    { id: 'a1', role: 'assistant', name: 'Mingo', content: '' },
-  ]
-
-  it('does not render the empty labeled assistant row while typing', () => {
-    const { container } = render(
-      <ChatMessageList dialogId="d" messages={pending} isTyping />,
-    )
-    // The bare "Mingo" label must be gone from the transcript entirely —
-    // removed from the DOM, not visually hidden (the list is an aria-live
-    // log; a zero-height node would still be announced).
-    expect(names(container)).toEqual(['Michael Assraf'])
-    expect(bodies(container)).toEqual(['what is broken?'])
-    // …and the single remaining owner is the polite status indicator.
-    expect(container.querySelectorAll('[role="status"]')).toHaveLength(1)
-  })
-
-  it('renders the assistant row as soon as it carries text', () => {
-    const withText: Message[] = [
-      pending[0],
-      { id: 'a1', role: 'assistant', name: 'Mingo', content: [{ type: 'text', text: 'Chec' }] },
-    ]
-    const { container } = render(
-      <ChatMessageList dialogId="d" messages={withText} isTyping />,
-    )
-    expect(names(container)).toEqual(['Michael Assraf', 'Mingo'])
-  })
-
-  it('renders the assistant row when it carries a NON-text segment (tool call)', () => {
-    const withTool: Message[] = [
-      pending[0],
-      {
-        id: 'a1',
-        role: 'assistant',
-        name: 'Mingo',
-        // The REAL `ToolExecutionSegment` shape — `{ type, data }`, not flat
-        // fields. The previous fixture put `toolExecutionRequestId` / `status`
-        // at the top level and needed an `as` cast to compile at all (the cast
-        // was the tell: the two types did not overlap). It passed only because
-        // the empty-pending-turn predicate looks at segment TYPE; the moment it
-        // inspected `data`, this test would have kept passing while the real
-        // path broke.
-        content: [
-          {
-            type: 'tool_execution',
-            data: {
-              type: 'EXECUTING_TOOL',
-              integratedToolType: 'SHELL',
-              toolFunction: 'run_command',
-              toolTitle: 'Run command',
-              parameters: { cmd: 'ls' },
-              toolExecutionRequestId: 'e1',
-            },
-          },
-        ],
-      },
-    ]
-    const { container } = render(
-      <ChatMessageList dialogId="d" messages={withTool} isTyping />,
-    )
-    expect(names(container)).toEqual(['Michael Assraf', 'Mingo'])
-  })
-
-  it('renders the assistant row when it carries ONLY a guide segment', () => {
-    // A `guide` body is the whole visible answer for a how-to question. If
-    // the empty-pending-turn predicate ever counted it as "nothing visible"
-    // (e.g. by widening its text-only clause), a guide-only turn would render
-    // NOTHING until the turn ended — the footer loader would be the sole
-    // affordance while a fully-formed guide card sat in state.
-    const withGuide: Message[] = [
-      pending[0],
-      {
-        id: 'a1',
-        role: 'assistant',
-        name: 'Mingo',
-        content: [{ type: 'guide', text: '## Enroll a device' }],
-      },
-    ]
-    const { container } = render(
-      <ChatMessageList dialogId="d" messages={withGuide} isTyping />,
-    )
-    expect(names(container)).toEqual(['Michael Assraf', 'Mingo'])
-  })
-
-  it('renders a completed empty-ish assistant row when NOT typing', () => {
-    const { container } = render(<ChatMessageList dialogId="d" messages={pending} />)
-    expect(names(container)).toEqual(['Michael Assraf', 'Mingo'])
-  })
-})
-
-describe('the SYSTEM name-only row is a legitimate label-without-body', () => {
-  it('still renders', () => {
-    const messages: Message[] = [
-      { id: 'u1', role: 'user', name: 'Michael Assraf', content: 'hi' },
-      { id: 's1', role: 'user', name: 'Technician joined', content: '', authorType: 'system' },
-    ]
-    const { container } = render(<ChatMessageList dialogId="d" messages={messages} isTyping />)
-    expect(names(container)).toContain('Technician joined')
-  })
-})

package/src/components/chat/hooks/__tests__/__snapshots__/conversation-id-persistence-golden.test.ts.snap

@@ -1,37 +0,0 @@
-// Vitest Snapshot v1, https://vitest.dev/guide/snapshot.html
-
-exports[`server-history hydration (materializes through the reducer) > rebuilds messages + sendIdx-keyed refs + send counter from the transcript 1`] = `
-[
-  {
-    "content": "open a ticket for the broken printer",
-    "id": "hydrated-1",
-    "role": "user",
-  },
-  {
-    "chatRefs": {
-      "ticket:77": {
-        "id": "77",
-        "metadata": {
-          "status": "OPEN",
-        },
-        "title": "Broken printer",
-        "type": "ticket",
-        "url": null,
-      },
-    },
-    "content": "✅ Approved — ticket created: [card://ticket:77]",
-    "id": "hydrated-2",
-    "role": "assistant",
-  },
-  {
-    "content": "what is the pricing?",
-    "id": "hydrated-3",
-    "role": "user",
-  },
-  {
-    "content": "Pricing starts at $99/month per site.",
-    "id": "hydrated-4",
-    "role": "assistant",
-  },
-]
-`;

package/src/components/chat/hooks/__tests__/chunk-catchup-dialog-staleness.test.ts

@@ -1,92 +0,0 @@
-/**
- * A catch-up fetch is async and the active dialog can change while it is in
- * flight — switching dialogs is the ordinary interaction, not an edge case.
- *
- * `useChunkCatchup` already knows about staleness, but only in its `finally`:
- * the processing loop ran FIRST and unconditionally. Everything downstream of
- * it is bound to the CURRENT dialog — `onChunkReceived` is read through a ref
- * the adapter reassigns every render, and the seq bookkeeping refs were just
- * re-armed by `resetChunkTracking` for the newly-entered dialog — so a fetch
- * that resolved late wrote dialog A's transcript into dialog B, and pushed B's
- * seq cursor to A's JetStream sequence. Since the reducer drops anything at or
- * below `lastAppliedSeq`, and A's stream position is unrelated to B's, that can
- * silently discard B's own live chunks for the rest of the session.
- *
- * The same applies to the flags: finalizing `hasCompletedInitialCatchup` /
- * `bufferUntilInitialCatchupComplete` on a stale fetch ends the NEW dialog's
- * buffering window early, and draining `chunkBuffer` hands B's buffered live
- * deliveries to A's stale batch.
- */
-import { describe, it, expect, vi } from 'vitest'
-import { renderHook, act } from '@testing-library/react'
-import { useChunkCatchup } from '../use-chunk-catchup'
-import type { ChunkData } from '../../types'
-
-type Deferred = {
-  promise: Promise<ChunkData[]>
-  resolve: (chunks: ChunkData[]) => void
-}
-
-function deferred(): Deferred {
-  let resolve!: (chunks: ChunkData[]) => void
-  const promise = new Promise<ChunkData[]>((r) => {
-    resolve = r
-  })
-  return { promise, resolve }
-}
-
-const textChunk = (text: string, streamSeq: number, sequenceId: number): ChunkData =>
-  ({ type: 'TEXT', text, streamSeq, sequenceId }) as unknown as ChunkData
-
-describe('useChunkCatchup — dialog staleness', () => {
-  it('does not deliver a catchup that resolved after the dialog changed', async () => {
-    const onChunkReceived = vi.fn()
-    const pending = deferred()
-    const fetchChunks = vi.fn((dialogId: string) =>
-      dialogId === 'A' ? pending.promise : Promise.resolve([]),
-    )
-
-    const { result, rerender } = renderHook(
-      ({ dialogId }: { dialogId: string }) =>
-        useChunkCatchup({ dialogId, onChunkReceived, fetchChunks }),
-      { initialProps: { dialogId: 'A' } },
-    )
-
-    // Dialog A starts its catch-up…
-    let catchup!: Promise<unknown>
-    await act(async () => {
-      catchup = result.current.catchUpChunks()
-    })
-    expect(fetchChunks).toHaveBeenCalledWith('A', expect.anything(), undefined)
-
-    // …the user switches to B while A's fetch is still open…
-    rerender({ dialogId: 'B' })
-
-    // …and only then does A's fetch land, carrying A's own transcript.
-    await act(async () => {
-      pending.resolve([textChunk('SECRET FROM DIALOG A', 100001, 100001)])
-      await catchup
-    })
-
-    expect(onChunkReceived).not.toHaveBeenCalled()
-  })
-
-  it('still delivers a catchup for the dialog that is current when it lands', () => {
-    const onChunkReceived = vi.fn()
-    const fetchChunks = vi.fn(() =>
-      Promise.resolve([textChunk('B REAL CONTENT', 50001, 50001)]),
-    )
-
-    const { result } = renderHook(() =>
-      useChunkCatchup({ dialogId: 'B', onChunkReceived, fetchChunks }),
-    )
-
-    return act(async () => {
-      await result.current.catchUpChunks()
-    }).then(() => {
-      // Positive control: the guard must not swallow the normal path.
-      expect(onChunkReceived).toHaveBeenCalledTimes(1)
-      expect(onChunkReceived.mock.calls[0][0]).toMatchObject({ text: 'B REAL CONTENT' })
-    })
-  })
-})