@flamingo-stack/openframe-frontend-core 0.0.496 → 0.0.498-1506.3998.1

package/src/components/features/floating-walkthrough-video.tsx

@@ -2,7 +2,8 @@
 
 /**
  * <FloatingWalkthroughVideo> — THE generic, embeddable per-platform demo-video
- * widget. A collapsed card pinned bottom-left (bite-identical hover grammar via
+ * widget. A collapsed card pinned to a bottom corner — left unless the video
+ * data says `position: 'right'` — (bite-identical hover grammar via
  * <VideoHoverPreviewSurface>) that opens a large in-page theater (Radix Dialog
  * primitives, NOT native fullscreen) showing ONLY the video: a bare 16:9 stage
  * with the player's own controls + captions. No card chrome, no summary.
@@ -71,6 +72,9 @@ export interface WalkthroughVideoData {
   captionsUrl?: string | null;
   title?: string | null;
   presenterAvatarUrl?: string | null;
+  /** Which bottom corner the collapsed card pins to. Admin-controlled per
+   *  video; anything other than 'right' (including absent) means left. */
+  position?: 'left' | 'right' | null;
 }
 
 export interface FloatingWalkthroughVideoProps {
@@ -816,7 +820,14 @@ export function FloatingWalkthroughVideo({
   return (
     <>
       {showCard && (
-        <div className={cn('pointer-events-none fixed bottom-0 left-0 p-[var(--spacing-system-mf)]', WALKTHROUGH_Z)} style={{ paddingBottom: 'max(var(--spacing-system-mf), env(safe-area-inset-bottom))' }}>
+        <div
+          className={cn(
+            'pointer-events-none fixed bottom-0 p-[var(--spacing-system-mf)]',
+            video.position === 'right' ? 'right-0' : 'left-0',
+            WALKTHROUGH_Z,
+          )}
+          style={{ paddingBottom: 'max(var(--spacing-system-mf), env(safe-area-inset-bottom))' }}
+        >
           {collapsed}
         </div>
       )}

package/src/components/onboarding-guides/onboarding-guide-detail-view.tsx

@@ -15,7 +15,7 @@
  * renderer with extra plugins.
  */
 
-import { type ComponentType, type ReactNode } from 'react'
+import { Fragment, type ComponentType, type ReactNode } from 'react'
 import { PageLayout } from '../layout/page-layout'
 
 import { useRouter } from '../../embed-shims'
@@ -30,7 +30,7 @@ import { VideoBitesStrip } from '../features/video-bites-strip'
 import { toStripProfile } from '../features/video-bites-shared'
 import { useVideoWarmup } from '../features/use-video-warmup'
 import { getCaptionsUrl } from '../features/captions-url'
-import { RichMarkdownRenderer } from '../ui/rich-markdown-renderer'
+import { RichMarkdownRenderer } from '../ui/markdown'
 import { EntityTagBadges } from '../features/entity-tag-badges'
 import { LoadError } from '../ui/error-state'
 import { ArticleAuthorByline } from '../shared/article-author-byline'
@@ -244,8 +244,26 @@ export function OnboardingGuideDetailView({
           </div>
         )}
 
-        {/* Host slot — cross-type related-content / FAQ rail. */}
-        {relatedContent}
+        {/*
+         * Host slot — cross-type related-content / FAQ rail.
+         *
+         * KEYED DELIBERATELY. This is one member of PageLayout's static children
+         * array, and the only member whose element may be created in a SERVER
+         * component and crossed over the RSC boundary. Static JSX children are
+         * normally exempt from the key warning because `jsxs` runs
+         * `validateChildKeys` and stamps `_store.validated = 1` on each element —
+         * but a slot arriving over the wire is referenced as a lazy chunk wrapper,
+         * so validation marks the WRAPPER and the fulfilled path never copies the
+         * flag onto the revived element. It reaches the reconciler with
+         * `validated: 0, key: null` and warns, blaming PageLayout (the owner of the
+         * enclosing element) rather than anything actually at fault.
+         *
+         * A keyed Fragment emits no DOM, so rendered output is byte-identical.
+         * Do NOT "fix" this in PageLayout via `React.Children.toArray` — that would
+         * auto-key every consumer's children and change reconciliation identity for
+         * all of them, and that file carries an explicit FROZEN contract.
+         */}
+        <Fragment key="related-content">{relatedContent}</Fragment>
       </PageLayout>
   )
 }

package/src/components/shared/legal-document/legal-document-page.tsx

@@ -19,7 +19,7 @@
 
 import type { ComponentType } from 'react';
 import { PageShell, PageLayout } from '../../ui';
-import { RichMarkdownRenderer } from '../../ui/rich-markdown-renderer';
+import { RichMarkdownRenderer } from '../../ui/markdown';
 import { useRouter } from '../../../embed-shims/next-navigation';
 import { useLegalDocs, type LegalDocument } from './use-legal-docs';
 import { formatLegalDate } from '../../../utils/format';

package/src/components/shared/product-release/release-detail-page.tsx

@@ -1,6 +1,6 @@
 "use client";
 
-import { useState, useEffect, ComponentType, type ReactNode } from 'react';
+import { useState, useEffect, Fragment, ComponentType, type ReactNode } from 'react';
 import Link from '../../../embed-shims/next-link';
 import { useRouter } from '../../../embed-shims/next-navigation';
 import { Card, CardContent } from '../../ui/card';
@@ -11,7 +11,7 @@ import { PageShell } from '../../layout/article-detail-layout';
 import { PageLayout } from '../../layout/page-layout';
 import { FadePreview } from '../../ui/fade-preview';
 import { ReleaseChangelogSection } from '../../ui/release-changelog-section';
-import { RichMarkdownRenderer } from '../../ui/rich-markdown-renderer';
+import { RichMarkdownRenderer } from '../../ui/markdown';
 import { EntityTagBadges } from '../../features/entity-tag-badges';
 import { EntityMetadataAuthorCell } from '../../chat/entity-cards/entity-author-card';
 import type { EntityAuthor } from '../../../types/entity-author';
@@ -582,8 +582,23 @@ export function ReleaseDetailPage({
         )}
       </div>
 
-      {/* Host slot — end-of-article byline + related-content / FAQ rail. */}
-      {relatedContent}
+      {/*
+       * Host slot — end-of-article byline + related-content / FAQ rail.
+       *
+       * KEYED for the same reason as `onboarding-guide-detail-view.tsx`: this is a
+       * member of PageLayout's static children array, and a slot element built in a
+       * SERVER component crosses the RSC boundary as a lazy chunk wrapper, so
+       * `validateChildKeys` marks the wrapper and the fulfilled path never copies
+       * `_store.validated` onto the revived element — it reaches the reconciler
+       * unvalidated and warns.
+       *
+       * Today the hub's only consumer of this view is a `'use client'` wrapper that
+       * builds the slot locally, so no element actually crosses the boundary and
+       * this is pre-emptive. It is kept because the trap is invisible from here: a
+       * future server-built slot would warn with no clue pointing at this line.
+       * A keyed Fragment emits no DOM, so output is byte-identical either way.
+       */}
+      <Fragment key="related-content">{relatedContent}</Fragment>
       </PageLayout>
   );
 }