@flamingo-stack/openframe-frontend-core 0.0.490 → 0.0.491-snapshot.20260729083908

package/src/components/ui/tab-navigation.tsx

@@ -1,6 +1,6 @@
 'use client'
 
-import React, { useState, useEffect, useMemo, useRef, useCallback } from 'react'
+import React, { useState, useEffect, useLayoutEffect, useDeferredValue, useMemo, useRef, useCallback, memo, startTransition } from 'react'
 import { useSearchParams, useRouter, usePathname } from '../../embed-shims/next-navigation'
 import { cn } from '../../utils/cn'
 
@@ -38,93 +38,91 @@ interface TabNavigationProps {
   urlSync?: boolean | TabNavigationUrlSyncOptions
   defaultTab?: string  // Fallback when no valid tab in URL or initial value
 
-  // Render prop to provide active tab to children
-  children?: (activeTab: string) => React.ReactNode
+  /**
+   * Render prop for the tab BODY. Receives the tab to render and, additively,
+   * a `isStale` flag — true while the bar has already moved to a newly clicked
+   * tab but the body is still showing the PREVIOUS one (see `deferredActiveTab`
+   * below). Use it to dim the body or show a pending hint; without it a slow
+   * tab looks like a tab that simply did nothing.
+   */
+  children?: (activeTab: string, state: { isStale: boolean }) => React.ReactNode
 }
 
-export function TabNavigation({
-  activeTab: controlledActiveTab,
-  onTabChange: controlledOnTabChange,
-  tabs,
-  className,
-  shadowClassName,
-  showRightGradient = false,
-  showLeftGradient = false,
-  stretchTabs = false,
-  urlSync = false,
-  defaultTab,
-  children
-}: TabNavigationProps) {
-  const router = useRouter()
-  const pathname = usePathname()
-  const searchParams = useSearchParams()
-
-  // Determine URL sync settings
-  const isUrlSyncEnabled = !!urlSync
-  const paramName = typeof urlSync === 'object' ? (urlSync.paramName || 'tab') : 'tab'
-  const replaceState = typeof urlSync === 'object' ? (urlSync.replaceState !== false) : true
-
-  // Valid tab IDs set
-  const validTabIds = useMemo(() => new Set(tabs.map(t => t.id)), [tabs])
-
-  // Get initial tab value
-  const getInitialTab = () => {
-    if (isUrlSyncEnabled) {
-      // Try to read from URL
-      const fromUrl = searchParams?.get(paramName) || ''
-      if (validTabIds.has(fromUrl)) {
-        return fromUrl
-      }
-    }
-
-    // Fall back to defaultTab or first tab
-    return defaultTab || tabs[0]?.id || ''
-  }
-
-  // Internal state for URL sync mode
-  const [internalActiveTab, setInternalActiveTab] = useState(getInitialTab)
-
-  // Use internal state if URL sync is enabled, otherwise use controlled prop
-  const activeTab = isUrlSyncEnabled ? internalActiveTab : (controlledActiveTab || '')
+/** Where the underline sits, in the strip's own coordinates. */
+interface IndicatorRect {
+  left: number
+  width: number
+}
 
-  // Sync with URL changes (back/forward navigation)
-  useEffect(() => {
-    if (!isUrlSyncEnabled) return
+const HIDDEN_INDICATOR: IndicatorRect = { left: 0, width: 0 }
 
-    const fromUrl = searchParams?.get(paramName) || ''
-    const nextTab = validTabIds.has(fromUrl) ? fromUrl : (defaultTab || tabs[0]?.id || '')
+const StatusDot = ({ indicator, className }: { indicator: NonNullable<TabItem['indicator']>; className?: string }) => (
+  <div className={cn(
+    "w-3 h-3 rounded-full border-2 border-ods-bg",
+    indicator === 'error' && 'bg-ods-error',
+    indicator === 'warning' && 'bg-ods-accent',
+    indicator === 'success' && 'bg-ods-success',
+    className
+  )} />
+)
 
-    if (nextTab !== internalActiveTab) {
-      setInternalActiveTab(nextTab)
-    }
-  }, [isUrlSyncEnabled, searchParams, paramName, validTabIds, defaultTab, tabs, internalActiveTab])
-
-  // Handle tab change
-  const handleTabChange = (tabId: string) => {
-    if (isUrlSyncEnabled) {
-      // Update internal state
-      setInternalActiveTab(tabId)
-
-      // Update URL
-      const params = new URLSearchParams(searchParams?.toString())
-      params.set(paramName, tabId)
-      const method = replaceState ? 'replace' : 'push'
-      router[method](`${pathname}?${params.toString()}`)
-
-      // Call optional callback
-      controlledOnTabChange?.(tabId)
-    } else {
-      // Legacy controlled mode
-      controlledOnTabChange?.(tabId)
-    }
-  }
+interface TabBarProps {
+  tabs: TabItem[]
+  activeTab: string
+  onTabChange: (tabId: string) => void
+  className?: string
+  shadowClassName?: string
+  showLeftGradient: boolean
+  showRightGradient: boolean
+  stretchTabs: boolean
+}
 
+/**
+ * The strip itself — buttons, overflow scrolling, edge fades, underline.
+ *
+ * Split out of `TabNavigation` for one reason, and it is a performance one: the
+ * strip keeps state that changes for reasons having nothing to do with which tab
+ * is open (scroll position → edge fades, ResizeObserver → re-measure). While
+ * that state lived on `TabNavigation`, every one of those updates re-rendered
+ * the component that CALLS the body render prop, so merely scrolling the tab
+ * strip on a narrow screen re-rendered whatever heavy table was open underneath.
+ * Down here it re-renders only the bar; `TabNavigation` — and the body — never
+ * hear about it.
+ */
+const TabBar = memo(function TabBar({
+  tabs,
+  activeTab,
+  onTabChange,
+  className,
+  shadowClassName,
+  showLeftGradient,
+  showRightGradient,
+  stretchTabs,
+}: TabBarProps) {
   const scrollRef = useRef<HTMLDivElement>(null)
   const activeTabRef = useRef<HTMLButtonElement>(null)
   const isFirstActiveScrollRef = useRef(true)
   const [canScrollLeft, setCanScrollLeft] = useState(false)
   const [canScrollRight, setCanScrollRight] = useState(false)
 
+  // The underline is ONE element that slides, not a div mounted under whichever
+  // tab is active — that version could only ever pop from tab to tab. Position
+  // is measured rather than derived from CSS because the tabs are natural-width
+  // (label-dependent) and live in a scroll container, so nothing but layout
+  // knows where the active one actually is.
+  const [indicator, setIndicator] = useState<IndicatorRect>(HIDDEN_INDICATOR)
+  // Suppresses the slide for the FIRST placement: a deep link landing on the
+  // third tab should not open with the underline gliding in from the left edge.
+  const hasPlacedIndicatorRef = useRef(false)
+
+  const measureIndicator = useCallback(() => {
+    const active = activeTabRef.current
+    // No active tab (unknown id, or an empty tabs array) → collapse it away
+    // rather than leaving it under whichever tab it last sat on.
+    const next = active ? { left: active.offsetLeft, width: active.offsetWidth } : HIDDEN_INDICATOR
+    setIndicator(prev => (prev.left === next.left && prev.width === next.width ? prev : next))
+  }, [])
+
   const updateScrollShadows = useCallback(() => {
     const el = scrollRef.current
     if (!el) return
@@ -132,6 +130,18 @@ export function TabNavigation({
     setCanScrollRight(el.scrollLeft + el.clientWidth < el.scrollWidth - 1)
   }, [])
 
+  // Layout effect: the underline's first frame must already be under the right
+  // tab. In a passive effect it would paint at the previous position first.
+  useLayoutEffect(() => {
+    measureIndicator()
+  }, [measureIndicator, activeTab, tabs])
+
+  // Flipped only AFTER a real position has been committed, so the transition
+  // class is absent for that first paint and present from the next change on.
+  useLayoutEffect(() => {
+    if (indicator.width > 0) hasPlacedIndicatorRef.current = true
+  }, [indicator])
+
   useEffect(() => {
     const el = scrollRef.current
     if (!el) return
@@ -159,17 +169,27 @@ export function TabNavigation({
       e.preventDefault()
     }
 
+    // Scrolling moves the viewport, not the content — `offsetLeft` is unchanged,
+    // so only the fades need recomputing. A resize moves both.
     el.addEventListener('scroll', updateScrollShadows, { passive: true })
     el.addEventListener('wheel', onWheel, { passive: false })
-    const ro = new ResizeObserver(updateScrollShadows)
+    const ro = new ResizeObserver(() => {
+      updateScrollShadows()
+      measureIndicator()
+    })
     ro.observe(el)
+    // Web fonts land after first paint and change every label's width, which
+    // moves every tab but fires no resize on the strip itself.
+    let cancelled = false
+    document.fonts?.ready.then(() => { if (!cancelled) measureIndicator() }).catch(() => {})
 
     return () => {
+      cancelled = true
       el.removeEventListener('scroll', updateScrollShadows)
       el.removeEventListener('wheel', onWheel)
       ro.disconnect()
     }
-  }, [updateScrollShadows])
+  }, [updateScrollShadows, measureIndicator])
 
   // Bring the active tab into view when it changes (e.g. clicking a partly
   // off-screen tab, or a URL-driven change). Uses the browser's own smooth
@@ -197,7 +217,7 @@ export function TabNavigation({
   const leftFade = canScrollLeft || showLeftGradient
   const rightFade = canScrollRight || showRightGradient
 
-  const borderStyle: React.CSSProperties = (() => {
+  const borderStyle = useMemo<React.CSSProperties>(() => {
     const c = 'var(--color-border-default)'
     if (leftFade && rightFade) {
       return { background: `linear-gradient(to right, transparent 0, ${c} 40px, ${c} calc(100% - 40px), transparent 100%)` }
@@ -209,89 +229,290 @@ export function TabNavigation({
       return { background: `linear-gradient(to right, ${c} 0, ${c} calc(100% - 40px), transparent 100%)` }
     }
     return { background: c }
-  })()
+  }, [leftFade, rightFade])
+
+  // A 1px bar scaled to width, rather than an animated `left`/`width` pair:
+  // transform and opacity are the only two properties the compositor can
+  // animate without laying the strip out again on every frame.
+  const isPlaced = indicator.width > 0
+  const indicatorStyle: React.CSSProperties = {
+    transform: `translateX(${indicator.left}px) scaleX(${indicator.width})`,
+    opacity: isPlaced ? 1 : 0,
+  }
+  const shouldAnimateIndicator = hasPlacedIndicatorRef.current
 
   return (
-    <>
-      <div className={cn("relative w-full", className)}>
-        {/* scrollbar-hide: tabs stay swipe/wheel-scrollable, bar never shows */}
-        <div ref={scrollRef} className="flex gap-[var(--spacing-system-xxs)] items-center justify-start h-full overflow-x-auto overflow-y-hidden scrollbar-hide">
-          {tabs.map((tab) => {
-            const isActive = activeTab === tab.id
-
-            return (
-              <button
-                key={tab.id}
-                ref={isActive ? activeTabRef : undefined}
-                type="button"
-                onClick={() => handleTabChange(tab.id)}
-                className={cn(
-                  "flex gap-[var(--spacing-system-xxs)] items-center justify-center p-[var(--spacing-system-m)] relative shrink-0 cursor-pointer",
-                  "transition-all duration-200 bg-transparent border-none outline-none",
-                  stretchTabs && 'flex-1',
-                  // Known limitation: ODS color vars hold hex values, so Tailwind
-                  // alpha modifiers (to-ods-accent/10) silently produce no CSS.
-                  // color-mix() accepts hex, so we derive the 10%-alpha stop from the token.
-                  isActive
-                    ? 'bg-gradient-to-b from-transparent to-[color-mix(in_srgb,var(--color-accent-primary)_10%,transparent)]'
-                    : 'hover:bg-gradient-to-b hover:from-transparent hover:to-[color-mix(in_srgb,var(--color-accent-primary)_10%,transparent)]'
-                )}
-              >
-                {tab.icon ? (
-                  <div className="relative flex items-center justify-center">
-                    <tab.icon
-                      className={cn("h-4 w-4 md:h-6 md:w-6 transition-colors", isActive ? 'text-ods-accent' : 'text-ods-text-secondary')}
-                    />
-                    {tab.indicator && (
-                      <div className={cn(
-                        "absolute right-0 top-[-3px] w-3 h-3 rounded-full border-2 border-ods-bg",
-                        tab.indicator === 'error' && 'bg-ods-error',
-                        tab.indicator === 'warning' && 'bg-ods-accent',
-                        tab.indicator === 'success' && 'bg-ods-success'
-                      )} />
-                    )}
-                  </div>
-                ) : tab.indicator ? (
-                  // Text-only tabs keep their status badge — inline dot before
-                  // the label (there's no icon corner to anchor to).
-                  <div className={cn(
-                    "w-3 h-3 shrink-0 rounded-full border-2 border-ods-bg",
-                    tab.indicator === 'error' && 'bg-ods-error',
-                    tab.indicator === 'warning' && 'bg-ods-accent',
-                    tab.indicator === 'success' && 'bg-ods-success'
-                  )} />
-                ) : null}
-
-                <span className={cn(
-                  "text-h4 whitespace-nowrap transition-colors",
-                  isActive ? 'text-ods-text-primary' : 'text-ods-text-secondary'
-                )}>
-                  {tab.label}
-                </span>
-
-                {isActive && (
-                  <div className="absolute bottom-0 left-0 right-0 h-1 bg-ods-accent" />
-                )}
-              </button>
-            )
-          })}
-
-        </div>
-
-        {/* Fade shadows — visible when content overflows or when forced via props */}
-        {leftFade && (
-          <div className={cn("absolute left-0 top-0 bottom-0 w-10 pointer-events-none bg-gradient-to-r to-transparent", shadowClassName || "from-ods-bg")} />
-        )}
-        {rightFade && (
-          <div className={cn("absolute right-0 top-0 bottom-0 w-10 pointer-events-none bg-gradient-to-l to-transparent", shadowClassName || "from-ods-bg")} />
-        )}
-
-        {/* Bottom border — a gradient-capable 1px line that fades to transparent on any edge that has an active fade shadow. */}
-        <div className="absolute bottom-0 left-0 right-0 h-px pointer-events-none" style={borderStyle} />
+    <div className={cn("relative w-full", className)}>
+      {/* scrollbar-hide: tabs stay swipe/wheel-scrollable, bar never shows.
+          `relative` makes this the offsetParent the underline is measured against. */}
+      <div ref={scrollRef} className="relative flex gap-[var(--spacing-system-xxs)] items-center justify-start h-full overflow-x-auto overflow-y-hidden scrollbar-hide">
+        {tabs.map((tab) => {
+          const isActive = activeTab === tab.id
+
+          return (
+            <button
+              key={tab.id}
+              ref={isActive ? activeTabRef : undefined}
+              type="button"
+              onClick={() => onTabChange(tab.id)}
+              className={cn(
+                "flex gap-[var(--spacing-system-xxs)] items-center justify-center p-[var(--spacing-system-m)] relative shrink-0 cursor-pointer",
+                // Named rather than `transition-all`: the only thing that moves
+                // here is colour. `all` also made the browser re-check every
+                // property each frame, including the background GRADIENT — which
+                // never animated anyway, since the inactive state has no
+                // background-image to interpolate from.
+                "transition-colors duration-200 bg-transparent border-none outline-none",
+                // `outline-none` above drops the browser's own focus ring, so
+                // put one back or the strip is un-navigable by keyboard — you
+                // can tab through it with nothing to show where you are. Inset,
+                // so it stays within the button instead of overlapping the tab
+                // sitting 4px away.
+                "focus-visible:ring-2 focus-visible:ring-inset focus-visible:ring-ods-focus",
+                stretchTabs && 'flex-1',
+                // Known limitation: ODS color vars hold hex values, so Tailwind
+                // alpha modifiers (to-ods-accent/10) silently produce no CSS.
+                // color-mix() accepts hex, so we derive the 10%-alpha stop from the token.
+                isActive
+                  ? 'bg-gradient-to-b from-transparent to-[color-mix(in_srgb,var(--color-accent-primary)_10%,transparent)]'
+                  : 'hover:bg-gradient-to-b hover:from-transparent hover:to-[color-mix(in_srgb,var(--color-accent-primary)_10%,transparent)]'
+              )}
+            >
+              {tab.icon ? (
+                <div className="relative flex items-center justify-center">
+                  <tab.icon
+                    className={cn("h-4 w-4 md:h-6 md:w-6 transition-colors", isActive ? 'text-ods-accent' : 'text-ods-text-secondary')}
+                  />
+                  {tab.indicator && <StatusDot indicator={tab.indicator} className="absolute right-0 top-[-3px]" />}
+                </div>
+              ) : tab.indicator ? (
+                // Text-only tabs keep their status badge — inline dot before
+                // the label (there's no icon corner to anchor to).
+                <StatusDot indicator={tab.indicator} className="shrink-0" />
+              ) : null}
+
+              <span className={cn(
+                "text-h4 whitespace-nowrap transition-colors",
+                isActive ? 'text-ods-text-primary' : 'text-ods-text-secondary'
+              )}>
+                {tab.label}
+              </span>
+            </button>
+          )
+        })}
+
+        {/* One underline for the whole strip, sliding between tabs. Inside the
+            scroll container so it travels with the content; `origin-left` +
+            `w-px` make scaleX(n) read as "n pixels wide". */}
+        <div
+          aria-hidden
+          className={cn(
+            "pointer-events-none absolute bottom-0 left-0 h-1 w-px origin-left bg-ods-accent",
+            shouldAnimateIndicator && "transition-[transform,opacity] duration-200 ease-out motion-reduce:transition-none"
+          )}
+          style={indicatorStyle}
+        />
       </div>
 
+      {/* Fade shadows — visible when content overflows or when forced via props */}
+      {leftFade && (
+        <div className={cn("absolute left-0 top-0 bottom-0 w-10 pointer-events-none bg-gradient-to-r to-transparent", shadowClassName || "from-ods-bg")} />
+      )}
+      {rightFade && (
+        <div className={cn("absolute right-0 top-0 bottom-0 w-10 pointer-events-none bg-gradient-to-l to-transparent", shadowClassName || "from-ods-bg")} />
+      )}
+
+      {/* Bottom border — a gradient-capable 1px line that fades to transparent on any edge that has an active fade shadow. */}
+      <div className="absolute bottom-0 left-0 right-0 h-px pointer-events-none" style={borderStyle} />
+    </div>
+  )
+})
+
+export function TabNavigation({
+  activeTab: controlledActiveTab,
+  onTabChange: controlledOnTabChange,
+  tabs,
+  className,
+  shadowClassName,
+  showRightGradient = false,
+  showLeftGradient = false,
+  stretchTabs = false,
+  urlSync = false,
+  defaultTab,
+  children
+}: TabNavigationProps) {
+  const router = useRouter()
+  const pathname = usePathname()
+  const searchParams = useSearchParams()
+
+  // Determine URL sync settings
+  const isUrlSyncEnabled = !!urlSync
+  const paramName = typeof urlSync === 'object' ? (urlSync.paramName || 'tab') : 'tab'
+  const replaceState = typeof urlSync === 'object' ? (urlSync.replaceState !== false) : true
+
+  // Valid tab IDs set
+  const validTabIds = useMemo(() => new Set(tabs.map(t => t.id)), [tabs])
+  // A string, so the sync effect below depends on a VALUE rather than on the
+  // `tabs` array identity — a consumer passing an inline array literal would
+  // otherwise re-run that effect on every one of its renders.
+  const fallbackTab = defaultTab || tabs[0]?.id || ''
+
+  // What the URL currently says. Read during render (not in the effect) so the
+  // effect can compare it against the last value it ACTED on.
+  const urlTab = isUrlSyncEnabled ? (searchParams?.get(paramName) || '') : ''
+
+  // Get initial tab value
+  const getInitialTab = () => {
+    if (isUrlSyncEnabled && validTabIds.has(urlTab)) return urlTab
+    return fallbackTab
+  }
+
+  // Internal state for URL sync mode
+  const [internalActiveTab, setInternalActiveTab] = useState(getInitialTab)
+
+  // Use internal state if URL sync is enabled, otherwise use controlled prop
+  const activeTab = isUrlSyncEnabled ? internalActiveTab : (controlledActiveTab || '')
+
+  // The last URL value this component reconciled against.
+  const lastSyncedUrlTabRef = useRef(urlTab)
+  // Tabs written to the URL whose navigation has not landed yet, oldest first.
+  // Until a write lands, `searchParams` still reports the PREVIOUS tab — and
+  // reading that as somebody else editing the URL is exactly what used to push
+  // the tab back to where the click started.
+  const inFlightUrlTabsRef = useRef<string[]>([])
+
+  // Sync with URL changes (back/forward navigation, a link into a tab).
+  //
+  // Not guarded on `nextTab !== internalActiveTab`, which is what this used to
+  // compare. That re-ran whenever our own click moved the state, and at that
+  // moment `router.replace` has not landed — so it read the tab we just left,
+  // decided the state was wrong, and pushed the tab BACK, only for the arriving
+  // URL to move it forward again. Whether the flicker was visible came down to
+  // whether the navigation beat the passive-effect flush.
+  //
+  // The three cases below are the three things that can actually have happened.
+  useEffect(() => {
+    if (!isUrlSyncEnabled) return
+
+    // 1. One of our own writes arriving. The state moved on the click, so there
+    //    is nothing to set — just drop it, along with anything written before it
+    //    that a faster second click has already superseded.
+    const landed = inFlightUrlTabsRef.current.indexOf(urlTab)
+    if (landed !== -1) {
+      inFlightUrlTabsRef.current.splice(0, landed + 1)
+      lastSyncedUrlTabRef.current = urlTab
+      return
+    }
+
+    // 2. The URL has not moved. Either a write is still in flight and this run
+    //    is an unrelated re-render landing in the gap (a `tabs` array with a
+    //    fresh identity, say — which a guard on the URL alone would misread as
+    //    an external change and use to undo the click), or the TAB LIST itself
+    //    changed. The latter is why a URL guard is not enough on its own: a
+    //    consumer whose tabs load asynchronously mounts with an empty list,
+    //    resolves to no tab, and would then wait for a URL change that never
+    //    comes — deep link dropped, nothing ever active. So re-resolve, but only
+    //    when what we are showing is no longer in the list.
+    if (urlTab === lastSyncedUrlTabRef.current) {
+      setInternalActiveTab(prev =>
+        validTabIds.has(prev) ? prev : validTabIds.has(urlTab) ? urlTab : fallbackTab,
+      )
+      return
+    }
+
+    // 3. The URL moved somewhere we did not write it: back/forward, a redirect,
+    //    a link elsewhere on the page. That wins, and anything still in flight
+    //    is stale by definition.
+    inFlightUrlTabsRef.current.length = 0
+    lastSyncedUrlTabRef.current = urlTab
+    setInternalActiveTab(validTabIds.has(urlTab) ? urlTab : fallbackTab)
+  }, [isUrlSyncEnabled, urlTab, validTabIds, fallbackTab])
+
+  // Everything the click handler reads but must not be re-created for. Held in
+  // a ref so `handleTabChange` is reference-stable: it is the one prop that
+  // would otherwise break `TabBar`'s memo on every navigation, since
+  // `searchParams` gets a new identity each time ANY query param moves.
+  const navRef = useRef({ isUrlSyncEnabled, controlledOnTabChange, searchParams, pathname, paramName, replaceState })
+  // Filled in an effect rather than in the render body. With `useDeferredValue`
+  // this component renders more than once per commit, and React is free to
+  // discard a render outright — a ref written during one of those would hand the
+  // click handler a `pathname`/`searchParams` pair that never committed, and the
+  // click would write its query string against the wrong URL. A click can only
+  // arrive after a commit, so the handler still reads current values.
+  useEffect(() => {
+    navRef.current = { isUrlSyncEnabled, controlledOnTabChange, searchParams, pathname, paramName, replaceState }
+  })
+
+  const handleTabChange = useCallback((tabId: string) => {
+    const nav = navRef.current
+
+    if (!nav.isUrlSyncEnabled) {
+      // Legacy controlled mode
+      nav.controlledOnTabChange?.(tabId)
+      return
+    }
+
+    // The bar follows the click immediately — this update stays urgent.
+    setInternalActiveTab(tabId)
+    // ...and is what the URL is about to say. Recorded so the sync effect knows
+    // the param arriving later is ours, and knows that until it does arrive the
+    // URL is merely stale rather than disagreeing with us. Skipped when it is
+    // already the newest thing in flight, so a double-click on one tab does not
+    // queue the same id twice.
+    const inFlight = inFlightUrlTabsRef.current
+    if (inFlight[inFlight.length - 1] !== tabId) inFlight.push(tabId)
+
+    const params = new URLSearchParams(nav.searchParams?.toString())
+    params.set(nav.paramName, tabId)
+    const method = nav.replaceState ? 'replace' : 'push'
+    // Non-urgent: the navigation re-renders every `useSearchParams()` subscriber
+    // on the page, which is a lot of work for a query param nobody is waiting
+    // on. In a transition it yields to the click feedback instead of competing
+    // with it.
+    startTransition(() => {
+      // `scroll: false` because only a query param moves here. The App Router
+      // otherwise scrolls to the top on every navigation, which throws away the
+      // reading position of anyone using a tab strip partway down a page.
+      router[method](`${nav.pathname}?${params.toString()}`, { scroll: false })
+    })
+
+    nav.controlledOnTabChange?.(tabId)
+  }, [router])
+
+  // The tab BAR follows the click immediately; the tab BODY is deferred, which
+  // makes React treat swapping it as a transition. That is the whole fix for the
+  // flash: a tab whose data is not in the client cache yet SUSPENDS the moment it
+  // mounts, and outside a transition React has to show that Suspense fallback —
+  // so the skeleton appears for a frame before the real content lands. Inside a
+  // transition React keeps the previous tab on screen and swaps only once the new
+  // one is ready. Deferring the body rather than the whole state keeps the
+  // underline responsive, so the click still feels instant.
+  //
+  // Two things this asks of the consumer, both worth knowing:
+  //  - The render prop runs on BOTH passes (once with the old id, once with the
+  //    new). Put anything expensive behind `memo` so the first pass is free.
+  //  - A SLOW tab leaves the previous tab's content under the new tab's
+  //    underline with nothing saying so — worse than a skeleton, because stale
+  //    data reads as fresh data. `isStale` is handed to the render prop so the
+  //    body can mark itself while it waits.
+  const deferredActiveTab = useDeferredValue(activeTab)
+  const isStale = activeTab !== deferredActiveTab
+
+  return (
+    <>
+      <TabBar
+        tabs={tabs}
+        activeTab={activeTab}
+        onTabChange={handleTabChange}
+        className={className}
+        shadowClassName={shadowClassName}
+        showLeftGradient={showLeftGradient}
+        showRightGradient={showRightGradient}
+        stretchTabs={stretchTabs}
+      />
+
       {/* Render children with active tab if provided */}
-      {children && children(activeTab)}
+      {children && children(deferredActiveTab, { isStale })}
     </>
   )
 }
@@ -304,4 +525,4 @@ export const getTabById = (tabs: TabItem[], tabId: string): TabItem | undefined
 export const getTabComponent = (tabs: TabItem[], tabId: string): React.ComponentType<any> | null => {
   const tab = getTabById(tabs, tabId)
   return tab?.component || null
-}
+}

package/src/components/ui/tag-search-input.tsx

@@ -140,7 +140,13 @@ export function TagSearchInput<T = string>({
           "has-[:focus]:border-ods-accent",
           !disabled && "hover:bg-ods-bg-hover hover:border-ods-border-hover",
           disabled && "bg-ods-bg",
-          disabled && "cursor-not-allowed opacity-50",
+          disabled && "cursor-not-allowed",
+          // Match Input: grey the text and the icons, don't fade the whole
+          // control (a blanket opacity also washes out the border). Icons only —
+          // this container has no adornment spans of its own, so a `[&_span]`
+          // rule would ONLY have reached the selected `Tag` chips, whose label is
+          // a span, and greyed them into their own fill in the light theme.
+          "has-[:disabled]:[&_svg]:text-ods-text-disabled",
           className,
         )}
         onClick={() => {
@@ -199,7 +205,8 @@ export function TagSearchInput<T = string>({
               "flex-1 min-w-[60px] bg-transparent border-none outline-none",
               "text-h4",
               "text-ods-text-primary placeholder:text-ods-text-secondary",
-              "disabled:cursor-not-allowed",
+              // Disabled - match Input exactly (value greys out, placeholder dims further)
+              "disabled:cursor-not-allowed disabled:text-ods-text-disabled disabled:placeholder:text-ods-border",
             )}
           />
         </div>

package/src/components/ui/textarea.tsx

@@ -119,6 +119,12 @@ const Textarea = React.forwardRef<HTMLTextAreaElement, TextareaProps>(
           !hideBorder && cn("rounded-[6px] border bg-ods-card border-ods-border", accentBorder),
           !hideBorder && !props.disabled && "hover:bg-ods-bg-hover hover:border-ods-border-hover active:bg-ods-bg-active active:border-ods-border-active",
           !hideBorder && props.disabled && "!cursor-not-allowed bg-ods-bg",
+          // Start / end icons carry their own colour — grey them with the value
+          // so a disabled field reads as one flat colour. Scoped to the DIRECT
+          // span children (the two icon wrappers): the nodes inside them are
+          // rendered verbatim so callers can pass an interactive trigger and own
+          // its styling, and a descendant rule would overwrite exactly that.
+          "has-[:disabled]:[&>span]:text-ods-text-disabled has-[:disabled]:[&_svg]:text-ods-text-disabled",
           !hideBorder && isInvalid && cn("border-ods-error hover:border-ods-error", accentBorderError),
           hideBorder && "bg-transparent",
         )}
@@ -150,7 +156,8 @@ const Textarea = React.forwardRef<HTMLTextAreaElement, TextareaProps>(
             // internally instead of pushing the icon out of frame.
             "max-h-[160px] overflow-y-auto",
             "scrollbar-thin scrollbar-track-transparent scrollbar-thumb-ods-border/30 hover:scrollbar-thumb-ods-text-secondary/30",
-            "disabled:cursor-not-allowed disabled:placeholder:text-ods-border",
+            // Disabled - match Input exactly (value greys out, placeholder dims further)
+            "disabled:cursor-not-allowed disabled:text-ods-text-disabled disabled:placeholder:text-ods-border",
             className,
           )}
           {...props}