@flamingo-stack/openframe-frontend-core 0.0.490-1506.3944.1 → 0.0.490

package/src/components/chat/stream/__tests__/chat-stream-reducer-golden.test.ts

@@ -1,460 +0,0 @@
-/**
- * GOLDEN CHARACTERIZATION TESTS — the NATS kernel of
- * `createChatStreamReducer`, driven through `decodeNatsChunk`.
- *
- * Originally written against the `useRealtimeChunkProcessor` compat hook
- * (Phase 0 of the chat unification). That wrapper was deleted once every
- * consumer moved to the reducer; the behavioral spec it pinned is far too
- * valuable to lose, so the suite was RETARGETED at the reducer itself. The
- * recorded snapshots are byte-identical to the wrapper-era ones — the only
- * thing that changed is who dispatches the effects.
- *
- * `dispatch()` below replicates the deleted wrapper's effect→callback
- * forwarding verbatim (including the `segments-after-approval-result`
- * conditional), so the logs remain a 1:1 record of the legacy
- * `RealtimeChunkCallbacks` contract. Do NOT "fix" behaviors captured here.
- */
-
-import { describe, it, expect } from 'vitest'
-import { decodeNatsChunk } from '../../../../chat-protocol/nats-decoder'
-import {
-  createChatStreamReducer,
-  type ChatStreamReducer,
-  type InitializeExtras,
-} from '../chat-stream-reducer'
-import type { ChatApprovalStatus, RealtimeChunkCallbacks } from '../../types'
-
-type EventLog = Array<Record<string, unknown>>
-
-/** Build a full callback set that records every invocation into `log`. */
-function makeRecordingCallbacks(log: EventLog): RealtimeChunkCallbacks {
-  return {
-    onStreamStart: () => log.push({ event: 'onStreamStart' }),
-    onStreamEnd: () => log.push({ event: 'onStreamEnd' }),
-    onMetadata: (metadata) => log.push({ event: 'onMetadata', metadata }),
-    onSegmentsUpdate: (segments, metadata) =>
-      log.push({ event: 'onSegmentsUpdate', segments, metadata }),
-    onError: (error, details) => log.push({ event: 'onError', error, details }),
-    onUserMessage: (text, metadata) => log.push({ event: 'onUserMessage', text, metadata }),
-    onTokenUsage: (data) => log.push({ event: 'onTokenUsage', data }),
-    onDirectMessage: (text, metadata) => log.push({ event: 'onDirectMessage', text, metadata }),
-    onSystemMessage: (text, metadata) => log.push({ event: 'onSystemMessage', text, metadata }),
-    onApprove: async () => log.push({ event: 'onApprove' }),
-    onReject: async () => log.push({ event: 'onReject' }),
-    onEscalatedApproval: (requestId, data) =>
-      log.push({ event: 'onEscalatedApproval', requestId, data }),
-    onEscalatedApprovalResult: (requestId, approved, data) =>
-      log.push({ event: 'onEscalatedApprovalResult', requestId, approved, data }),
-    onApprovalResolved: (requestId, status, approvalType, resolvedByName) =>
-      log.push({ event: 'onApprovalResolved', requestId, status, approvalType, resolvedByName }),
-    onToolExecuted: (segment) => log.push({ event: 'onToolExecuted', segment }),
-    onAgentBusy: () => log.push({ event: 'onAgentBusy' }),
-    onDialogClosed: () => log.push({ event: 'onDialogClosed' }),
-  }
-}
-
-interface SetupOptions {
-  callbacks?: RealtimeChunkCallbacks
-  batchApprovalsEnabled?: boolean
-  displayApprovalTypes?: string[]
-  approvalStatuses?: Record<string, ChatApprovalStatus>
-  isDirectMode?: boolean
-  initialState?: InitializeExtras
-}
-
-function setup(options: SetupOptions = {}) {
-  const log: EventLog = []
-  const callbacks = options.callbacks ?? makeRecordingCallbacks(log)
-
-  const reducer: ChatStreamReducer = createChatStreamReducer({
-    transport: 'nats',
-    batchApprovalsEnabled: options.batchApprovalsEnabled,
-    displayApprovalTypes: options.displayApprovalTypes,
-    approvalStatuses: options.approvalStatuses,
-    isDirectMode: options.isDirectMode,
-    crossMessageToolRouting: !!callbacks.onToolExecuted,
-    callbacks: {
-      onApprove: (id) => callbacks.onApprove?.(id),
-      onReject: (id) => callbacks.onReject?.(id),
-    },
-    onEffect: ({ name, args }) => {
-      const cbs = callbacks as Record<string, ((...a: unknown[]) => void) | undefined>
-      // Legacy conditional: the cumulative post-APPROVAL_RESULT emit fires
-      // only when the consumer did NOT wire onApprovalResolved.
-      if (name === 'segments-after-approval-result') {
-        if (!cbs.onApprovalResolved) cbs.onSegmentsUpdate?.(...args)
-        return
-      }
-      cbs[name]?.(...args)
-    },
-  })
-
-  // The wrapper initialized from `initialState` in a mount effect.
-  if (options.initialState) reducer.initializeWithState(null, options.initialState)
-
-  const feed = (chunks: unknown[]) => {
-    for (const chunk of chunks) {
-      const event = decodeNatsChunk(chunk)
-      if (event) reducer.apply(event)
-    }
-  }
-  return { log, reducer, feed }
-}
-
-const EXECUTING = {
-  type: 'EXECUTING_TOOL',
-  integratedToolType: 'TACTICAL_RMM',
-  toolFunction: 'run_script',
-  title: 'Run cleanup script',
-  parameters: { script: 'cleanup.sh' },
-  toolExecutionRequestId: 'exec-1',
-}
-const EXECUTED = {
-  type: 'EXECUTED_TOOL',
-  integratedToolType: 'TACTICAL_RMM',
-  toolFunction: 'run_script',
-  result: 'Freed 2.3 GB',
-  success: true,
-  toolExecutionRequestId: 'exec-1',
-}
-
-describe('chat stream reducer — legacy chunk-processor golden event logs', () => {
-  it('normal turn: start → metadata → text ×3 → token usage → end', () => {
-    const { log, feed } = setup()
-    feed([
-      { type: 'MESSAGE_START' },
-      {
-        type: 'AI_METADATA',
-        modelDisplayName: 'Claude Sonnet',
-        modelName: 'claude-sonnet-x',
-        providerName: 'anthropic',
-        contextWindow: 200000,
-      },
-      { type: 'TEXT', text: 'Hello' },
-      { type: 'TEXT', text: ', ' },
-      { type: 'TEXT', text: 'world' },
-      {
-        type: 'TOKEN_USAGE',
-        inputTokensSize: 100,
-        outputTokensSize: 20,
-        totalTokensSize: 120,
-        contextSize: 180000,
-      },
-      { type: 'MESSAGE_END' },
-    ])
-    expect(log).toMatchSnapshot()
-  })
-
-  it('streamSeq on content chunks is threaded into onSegmentsUpdate metadata', () => {
-    const { log, feed } = setup()
-    feed([
-      { type: 'MESSAGE_START' },
-      { type: 'TEXT', text: 'seq-stamped', streamSeq: 7 },
-      { type: 'MESSAGE_END' },
-    ])
-    expect(log).toMatchSnapshot()
-  })
-
-  it('cold start (no MESSAGE_START ever): text emits CUMULATIVE segments (no append flag)', () => {
-    const { log, feed } = setup()
-    feed([
-      { type: 'TEXT', text: 'cold ' },
-      { type: 'TEXT', text: 'start' },
-    ])
-    expect(log).toMatchSnapshot()
-  })
-
-  it('post-MESSAGE_END continuation: text/thinking emit DELTA segments with append:true', () => {
-    const { log, feed } = setup()
-    feed([
-      { type: 'MESSAGE_START' },
-      { type: 'TEXT', text: 'in-stream' },
-      { type: 'MESSAGE_END' },
-      { type: 'TEXT', text: 'post-end text' },
-      { type: 'THINKING', text: 'post-end thinking' },
-    ])
-    expect(log).toMatchSnapshot()
-  })
-
-  it('tool execution OUTSIDE a message window: onAgentBusy + cross-message onToolExecuted (accumulator skipped)', () => {
-    const { log, feed } = setup()
-    // No MESSAGE_START — approved commands execute between the approval
-    // bubble's MESSAGE_END and the continuation stream.
-    feed([EXECUTING, EXECUTED])
-    expect(log).toMatchSnapshot()
-  })
-
-  it('tool execution IN-stream: accumulator-driven segment updates, onToolExecuted NOT fired', () => {
-    const { log, feed } = setup()
-    feed([
-      { type: 'MESSAGE_START' },
-      { type: 'TEXT', text: 'Running now. ' },
-      EXECUTING,
-      EXECUTED,
-      { type: 'MESSAGE_END' },
-    ])
-    expect(log).toMatchSnapshot()
-  })
-
-  it('approval request (displayed) → approval result: in-message flip + onApprovalResolved', () => {
-    const { log, feed } = setup()
-    feed([
-      { type: 'MESSAGE_START' },
-      {
-        type: 'APPROVAL_REQUEST',
-        approvalRequestId: 'req-1',
-        approvalType: 'CLIENT',
-        command: 'systemctl restart nats',
-        explanation: 'Restart the broker',
-      },
-      { type: 'MESSAGE_END' },
-      {
-        type: 'APPROVAL_RESULT',
-        approvalRequestId: 'req-1',
-        approved: true,
-        approvalType: 'CLIENT',
-        displayName: 'Jane Admin',
-      },
-    ])
-    // CHARACTERIZATION: because onApprovalResolved IS wired, the result
-    // does NOT emit onSegmentsUpdate — only the cross-message callback.
-    expect(log).toMatchSnapshot()
-  })
-
-  it('approval result WITHOUT onApprovalResolved wired: emits cumulative onSegmentsUpdate instead', () => {
-    const log: EventLog = []
-    const callbacks = makeRecordingCallbacks(log)
-    delete callbacks.onApprovalResolved
-    const { feed } = setup({ callbacks })
-    feed([
-      { type: 'MESSAGE_START' },
-      {
-        type: 'APPROVAL_REQUEST',
-        approvalRequestId: 'req-1',
-        approvalType: 'CLIENT',
-        command: 'reboot',
-      },
-      {
-        type: 'APPROVAL_RESULT',
-        approvalRequestId: 'req-1',
-        approved: false,
-        approvalType: 'CLIENT',
-      },
-    ])
-    expect(log).toMatchSnapshot()
-  })
-
-  it('escalated approval (type not displayed) → onEscalatedApproval, then result appends resolved card', () => {
-    const { log, feed, reducer } = setup() // displayApprovalTypes defaults to ['CLIENT']
-    feed([
-      { type: 'MESSAGE_START' },
-      {
-        type: 'APPROVAL_REQUEST',
-        approvalRequestId: 'req-adm',
-        approvalType: 'ADMIN',
-        command: 'drop database prod',
-      },
-      { type: 'MESSAGE_END' },
-      {
-        type: 'APPROVAL_RESULT',
-        approvalRequestId: 'req-adm',
-        approved: true,
-        approvalType: 'ADMIN',
-      },
-    ])
-    expect({
-      log,
-      pendingAfter: Array.from(reducer.getPendingEscalated().entries()),
-    }).toMatchSnapshot()
-  })
-
-  it('batch approval (batchApprovalsEnabled default ON): one batch segment, executions merge into it', () => {
-    const { log, feed } = setup()
-    feed([
-      { type: 'MESSAGE_START' },
-      {
-        type: 'APPROVAL_REQUEST',
-        approvalRequestId: 'batch-1',
-        approvalType: 'CLIENT',
-        toolCalls: [
-          {
-            toolExecutionRequestId: 'exec-a',
-            toolName: 'create_ticket',
-            toolTitle: 'Create ticket',
-            requiresApproval: true,
-            approvalType: 'CLIENT',
-            toolCallArguments: { subject: 'Printer down' },
-          },
-          {
-            toolExecutionRequestId: 'exec-b',
-            toolName: 'read_kb',
-            requiresApproval: false,
-          },
-        ],
-      },
-      {
-        type: 'APPROVAL_RESULT',
-        approvalRequestId: 'batch-1',
-        approved: true,
-        displayName: 'Alice Client',
-      },
-      {
-        type: 'EXECUTING_TOOL',
-        integratedToolType: 'PSA',
-        toolFunction: 'create_ticket',
-        toolExecutionRequestId: 'exec-a',
-      },
-      {
-        type: 'EXECUTED_TOOL',
-        integratedToolType: 'PSA',
-        toolFunction: 'create_ticket',
-        result: 'Ticket #77 created',
-        success: true,
-        toolExecutionRequestId: 'exec-a',
-      },
-      { type: 'MESSAGE_END' },
-    ])
-    expect(log).toMatchSnapshot()
-  })
-
-  it('batch approval with batchApprovalsEnabled:false unfolds into legacy cards (requiresApproval only)', () => {
-    const { log, feed } = setup({ batchApprovalsEnabled: false })
-    feed([
-      { type: 'MESSAGE_START' },
-      {
-        type: 'APPROVAL_REQUEST',
-        approvalRequestId: 'batch-1',
-        approvalType: 'CLIENT',
-        toolCalls: [
-          {
-            toolExecutionRequestId: 'exec-a',
-            toolName: 'create_ticket',
-            toolTitle: 'Create ticket',
-            requiresApproval: true,
-            toolCallArguments: { subject: 'Printer down' },
-          },
-          {
-            toolExecutionRequestId: 'exec-b',
-            toolName: 'read_kb',
-            requiresApproval: false,
-          },
-        ],
-      },
-      { type: 'MESSAGE_END' },
-    ])
-    expect(log).toMatchSnapshot()
-  })
-
-  it('CHARACTERIZATION duplicate/out-of-order: redelivered EXECUTING after EXECUTED in-stream appends a NEW executing segment (no dedup)', () => {
-    // The reducer does no duplicate suppression for standalone tool
-    // segments — dedup only exists inside approval batches (no-downgrade
-    // rule). Recording actual behavior, see unification plan.
-    const { log, feed } = setup()
-    feed([
-      { type: 'MESSAGE_START' },
-      EXECUTING,
-      EXECUTED,
-      EXECUTING, // redelivered
-      { type: 'MESSAGE_END' },
-    ])
-    expect(log).toMatchSnapshot()
-  })
-
-  it('error chunk: segment append + onError with JSON-extracted message', () => {
-    const { log, feed } = setup()
-    feed([
-      { type: 'MESSAGE_START' },
-      { type: 'TEXT', text: 'partial' },
-      { type: 'ERROR', error: 'Agent crashed', details: '{"error":{"message":"boom"}}' },
-      { type: 'ERROR', error: 'Plain details', details: 'not-json' },
-    ])
-    expect(log).toMatchSnapshot()
-  })
-
-  it('user echo / system / direct-message / dialog-closed routing', () => {
-    const { log, feed } = setup()
-    feed([
-      {
-        type: 'MESSAGE_REQUEST',
-        text: 'open a ticket',
-        ownerType: 'CLIENT',
-        displayName: 'Alice',
-        userId: 'user-42',
-        streamSeq: 3,
-        contextItems: [{ type: 'device', id: 'dev-1' }],
-      },
-      { type: 'SYSTEM', text: 'User joined the chat', streamSeq: 4 },
-      {
-        type: 'DIRECT_MESSAGE',
-        text: 'Human here now',
-        ownerType: 'ADMIN',
-        displayName: 'Jane Admin',
-        userId: 'admin-7',
-        streamSeq: 5,
-      },
-      { type: 'DIALOG_CLOSED' },
-    ])
-    expect(log).toMatchSnapshot()
-  })
-
-  it('direct-mode barrier: after a DIRECT_MESSAGE, AI chunks are dropped with a one-shot teardown', () => {
-    const { log, feed } = setup()
-    feed([
-      { type: 'MESSAGE_START' },
-      { type: 'TEXT', text: 'ai text before takeover' },
-      { type: 'DIRECT_MESSAGE', text: 'Human takeover', ownerType: 'ADMIN' },
-      // AI chunks now dropped; first one triggers the teardown (onStreamEnd).
-      { type: 'TEXT', text: 'dropped ai text' },
-      { type: 'TEXT', text: 'also dropped' },
-      // Allowlisted chunks still flow.
-      { type: 'SYSTEM', text: 'still visible' },
-      { type: 'DIRECT_MESSAGE', text: 'second human message' },
-    ])
-    expect(log).toMatchSnapshot()
-  })
-
-  it('context compaction outside a stream emits append+isCompacting metadata; inside a stream it is cumulative', () => {
-    const { log, feed } = setup()
-    feed([
-      // standalone (no open stream)
-      { type: 'CONTEXT_COMPACTION_START' },
-      { type: 'CONTEXT_COMPACTION_END', text: 'Summarized 12 messages' },
-    ])
-    const standaloneLog = [...log]
-    log.length = 0
-    feed([
-      { type: 'MESSAGE_START' },
-      { type: 'CONTEXT_COMPACTION_START' },
-      { type: 'CONTEXT_COMPACTION_END', text: 'Mid-stream summary' },
-      { type: 'MESSAGE_END' },
-    ])
-    expect({ standalone: standaloneLog, inStream: log }).toMatchSnapshot()
-  })
-
-  it('reset() clears accumulator + stream flags so the next dialog cold-starts cumulative', () => {
-    const { log, feed, reducer } = setup()
-    feed([
-      { type: 'MESSAGE_START' },
-      { type: 'TEXT', text: 'dialog one' },
-      { type: 'MESSAGE_END' },
-    ])
-    reducer.reset()
-    log.length = 0
-    feed([{ type: 'TEXT', text: 'dialog two cold start' }])
-    expect(log).toMatchSnapshot()
-  })
-
-  it('initialState resume: continuation chunks after resume take the post-stream append path', () => {
-    const { log } = setup({
-      initialState: {
-        existingSegments: [{ type: 'text', text: 'restored partial ' }],
-        escalatedApprovals: new Map([
-          ['req-esc', { command: 'escalated cmd', approvalType: 'ADMIN' }],
-        ]),
-      },
-    })
-    // initializeWithState replays escalated approvals via onEscalatedApproval
-    // and marks hasEverStreamed=true.
-    expect(log).toMatchSnapshot()
-  })
-})