@flamingo-stack/openframe-frontend-core 0.0.468-snapshot.20260723140929 → 0.0.468

package/src/components/chat/stream/__tests__/delta-batcher.test.ts

@@ -1,255 +0,0 @@
-/**
- * `createDeltaBatcher` — the SHARED (framework-free) delta batching policy.
- *
- * These tests exist because the batcher was previously inlined in the React
- * hook and re-implemented, near-verbatim but WITHOUT coalescing, by a product
- * app's non-React mirror. Coalescing is the difference between one `apply`
- * per frame and sixty.
- */
-
-import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest'
-import { createDeltaBatcher, type DeltaEvent } from '../delta-batcher'
-import type { ChatStreamEvent } from '../../../../chat-protocol/events'
-
-const text = (t: string, extra: Partial<ChatStreamEvent> = {}): ChatStreamEvent =>
-  ({ type: 'text-delta', text: t, ...extra }) as ChatStreamEvent
-const thinking = (t: string): ChatStreamEvent => ({ type: 'thinking-delta', text: t }) as ChatStreamEvent
-
-beforeEach(() => {
-  vi.useFakeTimers()
-  // No rAF in this environment → the always-armed timer fallback drives flushes.
-  vi.stubGlobal('requestAnimationFrame', undefined)
-  vi.stubGlobal('cancelAnimationFrame', undefined)
-})
-afterEach(() => {
-  vi.useRealTimers()
-  vi.unstubAllGlobals()
-})
-
-describe('createDeltaBatcher', () => {
-  it('coalesces a burst of consecutive text-deltas into ONE apply', () => {
-    const applied: DeltaEvent[] = []
-    const b = createDeltaBatcher({ applyOne: (e) => applied.push(e) })
-
-    for (let i = 0; i < 60; i += 1) b.push(text(`${i} `))
-    expect(applied).toHaveLength(0)
-    expect(b.pendingCount).toBe(1)
-
-    b.flush()
-    expect(applied).toHaveLength(1)
-    expect(applied[0].text).toBe(
-      Array.from({ length: 60 }, (_, i) => `${i} `).join(''),
-    )
-  })
-
-  it('does NOT coalesce across delta types, or across a differing `leading` flag', () => {
-    const applied: DeltaEvent[] = []
-    const b = createDeltaBatcher({ applyOne: (e) => applied.push(e) })
-
-    b.push(text('a'))
-    b.push(thinking('t1'))
-    b.push(thinking('t2'))
-    b.push(text('b', { leading: true } as Partial<ChatStreamEvent>))
-    b.push(text('c', { leading: true } as Partial<ChatStreamEvent>))
-    b.push(text('d'))
-    b.flush()
-
-    expect(applied.map((e) => [e.type, e.text])).toEqual([
-      ['text-delta', 'a'],
-      ['thinking-delta', 't1t2'],
-      ['text-delta', 'bc'],
-      ['text-delta', 'd'],
-    ])
-  })
-
-  it('carries the LATEST seq onto the coalesced event', () => {
-    const applied: DeltaEvent[] = []
-    const b = createDeltaBatcher({ applyOne: (e) => applied.push(e) })
-    b.push(text('a', { seq: 1 } as Partial<ChatStreamEvent>))
-    b.push(text('b', { seq: 2 } as Partial<ChatStreamEvent>))
-    b.push(text('c', { seq: 3 } as Partial<ChatStreamEvent>))
-    b.flush()
-    expect(applied).toHaveLength(1)
-    expect(applied[0].seq).toBe(3)
-  })
-
-  /**
-   * REGRESSION (round 3): coalescing must not swallow a redelivered /
-   * out-of-order delta. Merging it would concatenate its text (the reducer
-   * never sees a duplicate to drop) AND rewind the batch's seq below an
-   * already-applied one, defeating the reducer's `seq <= lastAppliedSeq`
-   * gate. It is pushed as its OWN entry so the gate can do its job.
-   */
-  it('does NOT coalesce a delta whose seq does not advance past the tail', () => {
-    const applied: DeltaEvent[] = []
-    const b = createDeltaBatcher({ applyOne: (e) => applied.push(e) })
-    b.push(text('a', { seq: 1 } as Partial<ChatStreamEvent>))
-    b.push(text('b', { seq: 2 } as Partial<ChatStreamEvent>))
-    // Redelivery of seq 2, then an out-of-order seq 1.
-    b.push(text('b', { seq: 2 } as Partial<ChatStreamEvent>))
-    b.push(text('a', { seq: 1 } as Partial<ChatStreamEvent>))
-    expect(b.pendingCount).toBe(3)
-    b.flush()
-    expect(applied.map((e) => [e.seq, e.text])).toEqual([
-      [2, 'ab'],
-      [2, 'b'],
-      [1, 'a'],
-    ])
-  })
-
-  /**
-   * REGRESSION (round 4): a seq-LESS tail is not "always advancing". Merging a
-   * seq-BEARING delta onto it stamps the merged entry with that seq, so on a
-   * stream mixing both shapes a redelivered delta could still rewind the
-   * batch's position past the reducer's gate.
-   */
-  it('does NOT coalesce a seq-bearing delta onto a seq-LESS tail', () => {
-    const applied: DeltaEvent[] = []
-    const b = createDeltaBatcher({ applyOne: (e) => applied.push(e) })
-    b.push(text('a'))
-    b.push(text('b', { seq: 2 } as Partial<ChatStreamEvent>))
-    expect(b.pendingCount).toBe(2)
-    b.flush()
-    expect(applied.map((e) => [e.seq, e.text])).toEqual([
-      [undefined, 'a'],
-      [2, 'b'],
-    ])
-  })
-
-  it('does NOT coalesce a seq-less delta onto a seq-BEARING tail', () => {
-    const applied: DeltaEvent[] = []
-    const b = createDeltaBatcher({ applyOne: (e) => applied.push(e) })
-    b.push(text('a', { seq: 1 } as Partial<ChatStreamEvent>))
-    b.push(text('b'))
-    expect(b.pendingCount).toBe(2)
-    b.flush()
-    expect(applied.map((e) => [e.seq, e.text])).toEqual([
-      [1, 'a'],
-      [undefined, 'b'],
-    ])
-  })
-
-  it('never mutates the caller-supplied event objects', () => {
-    const b = createDeltaBatcher({ applyOne: () => {} })
-    const first = text('a')
-    b.push(first)
-    b.push(text('b'))
-    b.flush()
-    expect((first as DeltaEvent).text).toBe('a')
-  })
-
-  it('returns false for non-delta events and leaves them unqueued', () => {
-    const applied: DeltaEvent[] = []
-    const b = createDeltaBatcher({ applyOne: (e) => applied.push(e) })
-    expect(b.push(text('a'))).toBe(true)
-    expect(b.push({ type: 'turn-end' } as ChatStreamEvent)).toBe(false)
-    expect(b.pendingCount).toBe(1)
-    expect(applied).toHaveLength(0)
-  })
-
-  it('flushes on the timer fallback when rAF is unavailable', () => {
-    const applied: DeltaEvent[] = []
-    const flushes: number[] = []
-    const b = createDeltaBatcher({
-      applyOne: (e) => applied.push(e),
-      onFlushed: (n) => flushes.push(n),
-    })
-
-    b.push(text('a'))
-    b.push(text('b'))
-    expect(applied).toHaveLength(0)
-
-    vi.advanceTimersByTime(50)
-    expect(applied.map((e) => e.text)).toEqual(['ab'])
-    expect(flushes).toEqual([1])
-
-    // Timer is one-shot per batch: a later delta arms a fresh one.
-    b.push(text('c'))
-    vi.advanceTimersByTime(50)
-    expect(applied.map((e) => e.text)).toEqual(['ab', 'c'])
-  })
-
-  it('honours a custom fallbackMs', () => {
-    const applied: DeltaEvent[] = []
-    const b = createDeltaBatcher({ applyOne: (e) => applied.push(e), fallbackMs: 200 })
-    b.push(text('a'))
-    vi.advanceTimersByTime(199)
-    expect(applied).toHaveLength(0)
-    vi.advanceTimersByTime(1)
-    expect(applied).toHaveLength(1)
-  })
-
-  it('flushes the pending batch against the PREVIOUS key when the key changes', () => {
-    const applied: Array<[string, string]> = []
-    const b = createDeltaBatcher<string>({
-      applyOne: (e, key) => applied.push([key ?? '<none>', e.text]),
-    })
-
-    b.push(text('for-a1'), 'A')
-    b.push(text('|for-a2'), 'A')
-    // Switching keys must land the A batch on A BEFORE queueing for B.
-    b.push(text('for-b'), 'B')
-    expect(applied).toEqual([['A', 'for-a1|for-a2']])
-
-    b.flush()
-    expect(applied).toEqual([
-      ['A', 'for-a1|for-a2'],
-      ['B', 'for-b'],
-    ])
-  })
-
-  it('flushes on key change even for a NON-delta event', () => {
-    const applied: Array<[string, string]> = []
-    const b = createDeltaBatcher<string>({
-      applyOne: (e, key) => applied.push([key ?? '<none>', e.text]),
-    })
-    b.push(text('a'), 'A')
-    expect(b.push({ type: 'turn-end' } as ChatStreamEvent, 'B')).toBe(false)
-    expect(applied).toEqual([['A', 'a']])
-  })
-
-  it('dispose() flushes the tail and cancels the pending timer', () => {
-    const applied: DeltaEvent[] = []
-    const b = createDeltaBatcher({ applyOne: (e) => applied.push(e) })
-    b.push(text('tail'))
-    b.dispose()
-    expect(applied.map((e) => e.text)).toEqual(['tail'])
-    vi.advanceTimersByTime(1000)
-    expect(applied).toHaveLength(1)
-  })
-
-  it('flush() on an empty batch is a no-op (no applyOne, no onFlushed)', () => {
-    const applyOne = vi.fn()
-    const onFlushed = vi.fn()
-    const b = createDeltaBatcher({ applyOne, onFlushed })
-    b.flush()
-    b.flush()
-    expect(applyOne).not.toHaveBeenCalled()
-    expect(onFlushed).not.toHaveBeenCalled()
-  })
-})
-
-describe('createDeltaBatcher — rAF path', () => {
-  it('prefers requestAnimationFrame and cancels it on an explicit flush', () => {
-    let rafCb: (() => void) | null = null
-    const cancel = vi.fn()
-    vi.stubGlobal('requestAnimationFrame', (cb: () => void) => {
-      rafCb = cb
-      return 7
-    })
-    vi.stubGlobal('cancelAnimationFrame', cancel)
-
-    const applied: DeltaEvent[] = []
-    const b = createDeltaBatcher({ applyOne: (e) => applied.push(e) })
-    b.push(text('a'))
-    expect(rafCb).toBeTypeOf('function')
-
-    b.flush()
-    expect(cancel).toHaveBeenCalledWith(7)
-    expect(applied.map((e) => e.text)).toEqual(['a'])
-
-    // A late rAF callback for the already-flushed batch is harmless.
-    rafCb!()
-    expect(applied).toHaveLength(1)
-  })
-})

package/src/components/chat/stream/__tests__/use-chat-stream-reducer.test.ts

@@ -1,98 +0,0 @@
-/**
- * Phase-3 tests — `useChatStreamReducer` delta batching.
- *
- * Text/thinking deltas coalesce to ~one animation frame (≤50ms timer
- * fallback); any non-delta event force-flushes the batch first so ordering
- * holds and completion always lands on fully-applied delta state.
- */
-
-import { describe, it, expect, beforeEach, afterEach, vi } from 'vitest'
-import { renderHook, act } from '@testing-library/react'
-import { createChatDialogStore } from '../chat-dialog-store'
-import { useChatStreamReducer } from '../use-chat-stream-reducer'
-
-beforeEach(() => {
-  vi.useFakeTimers()
-  // Force the timer fallback path (deterministic under fake timers).
-  vi.stubGlobal('requestAnimationFrame', undefined)
-  vi.stubGlobal('cancelAnimationFrame', undefined)
-})
-
-afterEach(() => {
-  vi.unstubAllGlobals()
-  vi.useRealTimers()
-})
-
-function setup() {
-  const store = createChatDialogStore()
-  const hook = renderHook(() =>
-    useChatStreamReducer({
-      store,
-      dialogId: 'dlg-1',
-      createReducerOptions: () => ({ transport: 'nats' }),
-    }),
-  )
-  return { store, hook }
-}
-
-describe('useChatStreamReducer — delta batching', () => {
-  it('coalesces text deltas and applies them on the ≤50ms fallback timer', () => {
-    const { store, hook } = setup()
-    act(() => {
-      hook.result.current.applyEvent({ type: 'turn-start' })
-      hook.result.current.applyEvent({ type: 'text-delta', text: 'a' })
-      hook.result.current.applyEvent({ type: 'text-delta', text: 'b' })
-    })
-    // Not yet applied — pending in the batch.
-    let trailing = store.getSnapshot('dlg-1').messages.at(-1)
-    expect(trailing?.segments ?? []).toEqual([])
-
-    act(() => {
-      vi.advanceTimersByTime(50)
-    })
-    trailing = store.getSnapshot('dlg-1').messages.at(-1)
-    expect(trailing?.segments).toEqual([{ type: 'text', text: 'ab' }])
-  })
-
-  it('a non-delta event force-flushes the pending batch synchronously first', () => {
-    const { store, hook } = setup()
-    act(() => {
-      hook.result.current.applyEvent({ type: 'turn-start' })
-      hook.result.current.applyEvent({ type: 'text-delta', text: 'partial ' })
-      hook.result.current.applyEvent({ type: 'text-delta', text: 'answer' })
-      // Completion — must land on fully-applied delta state.
-      hook.result.current.applyEvent({ type: 'turn-end' })
-    })
-    const state = store.getSnapshot('dlg-1')
-    const trailing = state.messages.at(-1)
-    expect(trailing?.segments).toEqual([{ type: 'text', text: 'partial answer' }])
-    expect(state.streamingPhase).toBe('idle')
-  })
-
-  it('flushDeltas applies the batch on demand (SSE end-of-stream path)', () => {
-    const { store, hook } = setup()
-    act(() => {
-      hook.result.current.applyEvent({ type: 'turn-start' })
-      hook.result.current.applyEvent({ type: 'thinking-delta', text: 'hmm ' })
-      hook.result.current.applyEvent({ type: 'thinking-delta', text: 'ok' })
-      hook.result.current.flushDeltas()
-    })
-    const trailing = store.getSnapshot('dlg-1').messages.at(-1)
-    expect(trailing?.segments).toEqual([{ type: 'thinking', text: 'hmm ok' }])
-  })
-
-  it('interleaved text/thinking preserve order across the batch', () => {
-    const { store, hook } = setup()
-    act(() => {
-      hook.result.current.applyEvent({ type: 'turn-start' })
-      hook.result.current.applyEvent({ type: 'thinking-delta', text: 'think' })
-      hook.result.current.applyEvent({ type: 'text-delta', text: 'answer' })
-      hook.result.current.flushDeltas()
-    })
-    const trailing = store.getSnapshot('dlg-1').messages.at(-1)
-    expect(trailing?.segments).toEqual([
-      { type: 'thinking', text: 'think' },
-      { type: 'text', text: 'answer' },
-    ])
-  })
-})