@flamingo-stack/openframe-frontend-core 0.0.404 → 0.0.405-snapshot.20260711081601

package/src/utils/announcement-storage.ts

@@ -1,36 +1,82 @@
-// Stub for announcement storage
-export interface AnnouncementStorageOptions {
-  key: string;
-  defaultValue?: any;
+/**
+ * Announcement dismissal store.
+ *
+ * The dismissal COOKIE is the single source of truth: the hub's root layout
+ * reads it server-side to decide whether to SSR-seed the bar (no flash for
+ * dismissed users), and the client reads it via `isAnnouncementDismissed`.
+ * One cookie per platform holding the LAST dismissed announcement id —
+ * dismissal is an id-match, never mere cookie presence, so a new announcement
+ * always shows after an old one was dismissed, and re-activating an old
+ * announcement intentionally re-shows it.
+ *
+ * The legacy per-id localStorage key (`<platform>-announcement-<id>-dismissed`)
+ * is READ-ONLY legacy: consulted only when no cookie exists for the platform,
+ * purely as the migration trigger (the bar's mount effect backfills the
+ * cookie). New dismissals write the cookie only, so the second store dies out.
+ *
+ * No `"use client"` directive on purpose — `announcementDismissCookieName` and
+ * `isDismissedCookieValue` are pure/isomorphic and imported by the hub's
+ * server layout; the DOM-touching helpers guard on `typeof document`.
+ */
+
+/** Cookie name for a platform's dismissed-announcement id — the ONE home for
+ *  the encoding, shared by the client writer and the hub's SSR reader. */
+export function announcementDismissCookieName(platform: string): string {
+  return `${platform}-announcement-dismissed`
 }
 
-export function getStoredAnnouncement(key: string): any {
-  if (typeof window !== 'undefined') {
-    try {
-      return JSON.parse(localStorage.getItem(key) || 'null');
-    } catch {
-      return null;
-    }
-  }
-  return null;
+/** THE dismissal match rule (id-match, not presence), shared across the
+ *  server/client boundary. `undefined` id (no active announcement) → false. */
+export function isDismissedCookieValue(
+  cookieValue: string | undefined,
+  id: string | undefined,
+): boolean {
+  return !!id && cookieValue === id
+}
+
+function readCookie(name: string): string | undefined {
+  if (typeof document === 'undefined') return undefined
+  const match = document.cookie
+    .split('; ')
+    .find((row) => row.startsWith(`${name}=`))
+  return match ? decodeURIComponent(match.slice(name.length + 1)) : undefined
 }
 
-export function setStoredAnnouncement(key: string, value: any): void {
-  if (typeof window !== 'undefined') {
-    try {
-      localStorage.setItem(key, JSON.stringify(value));
-    } catch {
-      // Ignore storage errors
-    }
+const legacyDismissKey = (platform: string, id: string) =>
+  `${platform}-announcement-${id}-dismissed`
+
+/** Persist a dismissal: cookie only (1 year). The SSR layout sees it on the
+ *  next request; localStorage is intentionally NOT written (read-only legacy). */
+export function dismissAnnouncement(platform: string, id: string): void {
+  if (typeof document === 'undefined') return
+  const name = announcementDismissCookieName(platform)
+  document.cookie = `${name}=${encodeURIComponent(id)}; path=/; max-age=31536000; SameSite=Lax`
+}
+
+/**
+ * Client-side dismissal check — cookie-first: the legacy localStorage key is
+ * consulted ONLY when no cookie exists for the platform. Reads browser
+ * storage, so callers must invoke it from effects, never during render
+ * (a render-time read would desync hydration from the SSR HTML).
+ */
+export function isAnnouncementDismissed(platform: string, id: string): boolean {
+  if (typeof document === 'undefined') return false
+  const cookieValue = readCookie(announcementDismissCookieName(platform))
+  if (cookieValue !== undefined) return isDismissedCookieValue(cookieValue, id)
+  try {
+    return localStorage.getItem(legacyDismissKey(platform, id)) !== null
+  } catch {
+    return false
   }
 }
 
-export function clearStoredAnnouncement(key: string = 'announcement'): void {
-  if (typeof window !== 'undefined') {
-    try {
-      localStorage.removeItem(key);
-    } catch {
-      // Ignore storage errors
-    }
+/** One-time cleanup of pre-refactor storage: the orphaned announcement cache
+ *  (the old "instant paint" blob) — called from the bar's mount effect. */
+export function clearLegacyAnnouncementCache(platform: string): void {
+  if (typeof window === 'undefined') return
+  try {
+    localStorage.removeItem(`${platform}-announcement-cache`)
+  } catch {
+    // ignore storage errors
   }
-}
+}

package/src/utils/app-config.ts

@@ -16,5 +16,14 @@ export function getAppConfig() {
 }
 
 export function getAppType() {
-  return process.env.NEXT_PUBLIC_APP_TYPE || 'openmsp';
+  // The exact `process.env.NEXT_PUBLIC_APP_TYPE` member expression is kept so
+  // Next/webpack can statically inline it. The try/catch makes the call safe
+  // in non-Next React hosts (Vite/CRA embeds) where `process` does not exist
+  // at runtime — those hosts fall back to 'openmsp' or pass an explicit
+  // platform where it matters (e.g. AnnouncementBar's `platform` prop).
+  try {
+    return process.env.NEXT_PUBLIC_APP_TYPE || 'openmsp';
+  } catch {
+    return 'openmsp';
+  }
 }

package/src/utils/color-analysis.ts

@@ -26,7 +26,7 @@ export function hexToRgb(hex: string): [number, number, number] {
 /**
  * Calculate relative luminance for contrast calculations
  */
-function getLuminance(rgb: [number, number, number]): number {
+export function getLuminance(rgb: [number, number, number]): number {
   const [r, g, b] = rgb.map(c => {
     c = c / 255;
     return c <= 0.03928 ? c / 12.92 : Math.pow((c + 0.055) / 1.055, 2.4);
@@ -45,6 +45,21 @@ export function getContrastRatio(color1: [number, number, number], color2: [numb
   return (brightest + 0.05) / (darkest + 0.05);
 }
 
+/**
+ * Pick the readable foreground shade for an arbitrary background hex — 'dark'
+ * when dark text has the better WCAG contrast on it, 'light' otherwise.
+ * Callers map the result to an ODS THEME, not to color literals (e.g. the
+ * announcement bar scopes its content with .theme-light when the background
+ * needs dark-on-light, .theme-dark otherwise — every color then resolves
+ * from the active theme's own tokens).
+ */
+export function pickReadableTextColor(bgHex: string): 'dark' | 'light' {
+  const bg = hexToRgb(bgHex);
+  const darkContrast = getContrastRatio(bg, [26, 26, 26]);
+  const lightContrast = getContrastRatio(bg, [250, 250, 250]);
+  return darkContrast >= lightContrast ? 'dark' : 'light';
+}
+
 /**
  * Extract dominant color from image canvas
  */

package/src/utils/index.ts

@@ -85,6 +85,9 @@ export * from './generic-domain-utils'
 // Color analysis (canvas-based image color extraction)
 export * from './color-analysis'
 
+// Announcement dismissal store (cookie SSOT; server-safe name/match helpers)
+export * from './announcement-storage'
+
 // Image-proxy URL builder (pure, runtime-configurable)
 export {
   type GetProxiedImageUrlOptions,