@flamework-experimental/transformer 2.0.0-alpha.0 → 2.0.0-alpha.1

package/out/transformations/macros/updateComponentConfig.js

@@ -308,15 +308,17 @@ function updateLinks(state, node, properties) {
             for (var _e = __values(getDeclaredChildren(state, node, instanceType)), _f = _e.next(); !_f.done; _f = _e.next()) {
                 var _g = __read(_f.value, 2), property = _g[0], declaredType = _g[1];
                 var targetType = state.typeChecker.getNonNullableType(declaredType);
-                var optional = isOptionalMember(state, property, declaredType);
+                // Whether it names a component or a plain instance: a child that may be missing is a
+                // child `this.instance` cannot be indexed for, so the tree does not describe one.
+                if (isOptionalMember(state, property, declaredType)) {
+                    assertChildIsRequired(node, property, property.name);
+                }
                 if (getComponentInstanceType(state, targetType, node)) {
                     // A child's own guard is part of the component's instance guard, so the link only
                     // has to name the component that must exist on it.
-                    links.push(createLink(state, node, "child", property.name, optional, targetType));
+                    links.push(createLink(state, node, "child", property.name, false, targetType));
                 }
                 else if ((0, buildGuardFromType_1.isInstanceType)(targetType)) {
-                    if (optional)
-                        assertChildIsRequired(node, property, property.name);
                     assertInstanceTree(state, node, targetType, property.name);
                 }
             }
@@ -346,22 +348,15 @@ function getPropertyNode(node, property) {
     return factory_1.f.is.namedDeclaration(declaration) ? declaration.name : declaration;
 }
 /**
- * A child of the instance tree cannot be optional. `this.instance.Head` is an index into the
- * instance itself, and Roblox raises on a child that is not there rather than handing back nothing,
- * so the optional type would promise a read that is not safe to make.
- *
- * A child typed as a *component* is the exception, and is let through above: it is a link, so its
- * presence is watched and `childComponents.Head` -- an ordinary table read -- is what says whether
- * the child is there.
+ * A child of the instance tree cannot be optional, whether it names a component or a plain
+ * instance. `this.instance.Head` is an index into the instance itself, and Roblox raises on a
+ * child that is not there rather than handing back nothing, so the optional type would promise a
+ * read that is not safe to make. A component that may or may not be there is reached through an
+ * optional link attribute, or looked up with `getComponent`.
  */
 function assertChildIsRequired(node, property, path) {
     var component = node.name ? " of '".concat(node.name.text, "'") : "";
-    // Naming a component is only an option for a direct child; one deeper in the tree cannot be
-    // linked at all, so it is not offered as a way out there.
-    var link = path.includes(".")
-        ? ""
-        : " type it as a component so that Flamework watches it and 'childComponents' says whether it is there, or";
-    diagnostics_1.Diagnostics.error(getPropertyNode(node, property), "Child '".concat(path, "' of the instance tree").concat(component, " is optional, which Flamework does not allow: Roblox raises when a child that does not exist is indexed, so 'this.instance.").concat(path, "' would error rather than be undefined."), "Require the child,".concat(link, " leave it out of the tree and reach for it with FindFirstChild."));
+    diagnostics_1.Diagnostics.error(getPropertyNode(node, property), "Child '".concat(path, "' of the instance tree").concat(component, " is optional, which Flamework does not allow: Roblox raises when a child that does not exist is indexed, so 'this.instance.").concat(path, "' would error rather than be undefined."), "Require the child, or leave it out of the tree and reach for it with FindFirstChild; a component that may be missing can be named by an optional link attribute, or looked up with getComponent.");
 }
 /**
  * Checks the children declared below a direct child of the instance tree.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@flamework-experimental/transformer",
-  "version": "2.0.0-alpha.0",
+  "version": "2.0.0-alpha.1",
   "description": "An opinionated game framework for Roblox.",
   "main": "out/index.js",
   "scripts": {