@fjall/eslint-plugin 3.11.0 → 4.1.0

package/index.js

@@ -26,6 +26,7 @@ import requireAbortPrecheckInSdkLoop from "./require-abort-precheck-in-sdk-loop.
 import requireAbortCompositionOnSdkSend from "./require-abort-composition-on-sdk-send.js";
 import noClassicConnectedAccountAssume from "./no-classic-connected-account-assume.js";
 import noRawDbTransaction from "./no-raw-db-transaction.js";
+import noRawExitCode from "./no-raw-exit-code.js";
 
 export default {
   rules: {
@@ -58,6 +59,7 @@ export default {
     "require-abort-precheck-in-sdk-loop": requireAbortPrecheckInSdkLoop,
     "require-abort-composition-on-sdk-send": requireAbortCompositionOnSdkSend,
     "no-classic-connected-account-assume": noClassicConnectedAccountAssume,
-    "no-raw-db-transaction": noRawDbTransaction
+    "no-raw-db-transaction": noRawDbTransaction,
+    "no-raw-exit-code": noRawExitCode
   }
 };

package/no-raw-exit-code.js

@@ -0,0 +1,82 @@
+/**
+ * ESLint Rule: no-raw-exit-code
+ *
+ * Exit codes live in the registry (cli/src/util/exitCodes.ts) - one owner
+ * per number, per-family tables, documented cross-family reuse. A raw
+ * numeric literal in `process.exit(N)` or `process.exitCode = N` bypasses
+ * that contract and reintroduces the collision class the registry closed
+ * (codemod IO_ERROR 4 vs deploy destruction-withheld 4).
+ *
+ * Flags:
+ * - process.exit(<numeric literal>)
+ * - process.exitCode = <numeric literal>  (including negated literals)
+ *
+ * Allowed:
+ * - process.exit(SOME_CONSTANT) / process.exitCode = someVariable
+ * - the registry module itself (it defines the numbers)
+ */
+
+const REGISTRY_PATH_FRAGMENT = "util/exitCodes.ts";
+
+function isNumericLiteral(node) {
+  if (node === undefined || node === null) return false;
+  if (node.type === "Literal" && typeof node.value === "number") return true;
+  // -1 parses as UnaryExpression("-", Literal(1))
+  return (
+    node.type === "UnaryExpression" &&
+    node.operator === "-" &&
+    isNumericLiteral(node.argument)
+  );
+}
+
+function isProcessMember(node, propertyName) {
+  return (
+    node.type === "MemberExpression" &&
+    node.object.type === "Identifier" &&
+    node.object.name === "process" &&
+    node.property.type === "Identifier" &&
+    node.property.name === propertyName
+  );
+}
+
+/** @type {import('eslint').Rule.RuleModule} */
+export default {
+  meta: {
+    type: "problem",
+    docs: {
+      description:
+        "Exit codes must come from the registry (cli/src/util/exitCodes.ts), never raw numeric literals",
+      category: "Best Practices",
+      recommended: false
+    },
+    messages: {
+      rawExit:
+        "Raw numeric exit code. Import a named constant from util/exitCodes.ts (the exit-code registry) so the number keeps exactly one meaning per family."
+    },
+    schema: []
+  },
+
+  create(context) {
+    const filename = context.filename ?? context.getFilename();
+    if (filename.replaceAll("\\", "/").endsWith(REGISTRY_PATH_FRAGMENT)) {
+      return {};
+    }
+
+    return {
+      CallExpression(node) {
+        if (!isProcessMember(node.callee, "exit")) return;
+        if (node.arguments.length === 0) return;
+        if (isNumericLiteral(node.arguments[0])) {
+          context.report({ node, messageId: "rawExit" });
+        }
+      },
+      AssignmentExpression(node) {
+        if (node.operator !== "=") return;
+        if (!isProcessMember(node.left, "exitCode")) return;
+        if (isNumericLiteral(node.right)) {
+          context.report({ node, messageId: "rawExit" });
+        }
+      }
+    };
+  }
+};

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@fjall/eslint-plugin",
-  "version": "3.11.0",
+  "version": "4.1.0",
   "description": "ESLint plugin with Fjall-specific coding standard rules",
   "type": "module",
   "main": "index.js",
@@ -32,5 +32,5 @@
     "vitest": "^4.1.5"
   },
   "license": "SEE LICENSE IN LICENSE",
-  "gitHead": "a15125ea026d52428ff5433d098699899695ca3f"
+  "gitHead": "09dee795753839b82aedbb7d0cef1c5ef283df55"
 }