@fitzzero/quickdraw-core 3.6.0 → 3.8.0

package/eslint-plugin-quickdraw/rules/no-cross-service-mutations.mjs

@@ -1,4 +1,4 @@
-const MUTATION_METHODS = new Set(["create", "update", "delete"])
+const MUTATION_METHODS = new Set(["create", "update", "delete"]);
 
 /**
  * Extract the service directory name from a file path.
@@ -6,8 +6,8 @@ const MUTATION_METHODS = new Set(["create", "update", "delete"])
  *      "/app/services/task/helpers.ts" → "task"
  */
 function getServiceDirName(filename) {
-  const match = filename.match(/services\/([^/]+)\//)
-  return match ? match[1] : null
+  const match = filename.match(/services\/([^/]+)\//);
+  return match ? match[1] : null;
 }
 
 /**
@@ -16,7 +16,7 @@ function getServiceDirName(filename) {
  * e.g. "cloud-build" → "cloudBuild", "task" → "task"
  */
 function dirNameToModelName(dirName) {
-  return dirName.replace(/[-_](\w)/g, (_, c) => c.toUpperCase())
+  return dirName.replace(/[-_](\w)/g, (_, c) => c.toUpperCase());
 }
 
 /** @type {import('eslint').Rule.RuleModule} */
@@ -56,38 +56,37 @@ export default {
     ],
   },
   create(context) {
-    const filename = context.filename || context.getFilename()
-    const serviceDirName = getServiceDirName(filename)
+    const filename = context.filename || context.getFilename();
+    const serviceDirName = getServiceDirName(filename);
 
-    if (!serviceDirName) return {}
+    if (!serviceDirName) return {};
 
-    const ownedModel = dirNameToModelName(serviceDirName)
-    const isIndexFile = filename.endsWith("/index.ts") || filename.endsWith("/index.js")
-    const options = context.options[0] || {}
-    const allowedModels = options.allowedModels || {}
-    const allowedForThisService = new Set(allowedModels[serviceDirName] || [])
+    const ownedModel = dirNameToModelName(serviceDirName);
+    const isIndexFile = filename.endsWith("/index.ts") || filename.endsWith("/index.js");
+    const options = context.options[0] || {};
+    const allowedModels = options.allowedModels || {};
+    const allowedForThisService = new Set(allowedModels[serviceDirName] || []);
 
     return {
       CallExpression(node) {
-        const callee = node.callee
-        if (callee.type !== "MemberExpression") return
-        if (callee.property.type !== "Identifier") return
+        const callee = node.callee;
+        if (callee.type !== "MemberExpression") return;
+        if (callee.property.type !== "Identifier") return;
 
-        const methodName = callee.property.name
-        if (!MUTATION_METHODS.has(methodName)) return
+        const methodName = callee.property.name;
+        if (!MUTATION_METHODS.has(methodName)) return;
 
-        const obj = callee.object
-        if (obj.type !== "MemberExpression") return
+        const obj = callee.object;
+        if (obj.type !== "MemberExpression") return;
 
-        const parentObj = obj.object
-        if (parentObj.type !== "MemberExpression") return
-        if (parentObj.property.type !== "Identifier") return
-        if (parentObj.property.name !== "prisma") return
+        const parentObj = obj.object;
+        if (parentObj.type !== "MemberExpression") return;
+        if (parentObj.property.type !== "Identifier") return;
+        if (parentObj.property.name !== "prisma") return;
 
-        if (parentObj.object.type !== "ThisExpression") return
+        if (parentObj.object.type !== "ThisExpression") return;
 
-        const modelName =
-          obj.property.type === "Identifier" ? obj.property.name : "model"
+        const modelName = obj.property.type === "Identifier" ? obj.property.name : "model";
 
         if (modelName === ownedModel) {
           if (!isIndexFile) {
@@ -95,19 +94,19 @@ export default {
               node,
               messageId: "useBaseService",
               data: { method: methodName, model: modelName },
-            })
+            });
           }
-          return
+          return;
         }
 
-        if (allowedForThisService.has(modelName)) return
+        if (allowedForThisService.has(modelName)) return;
 
         context.report({
           node,
           messageId: "crossServiceMutation",
           data: { method: methodName, model: modelName },
-        })
+        });
       },
-    }
+    };
   },
-}
+};

package/eslint-plugin-quickdraw/rules/no-direct-prisma-mutations.mjs

@@ -14,36 +14,35 @@ export default {
     schema: [],
   },
   create(context) {
-    const MUTATION_METHODS = new Set(["create", "update", "delete"])
+    const MUTATION_METHODS = new Set(["create", "update", "delete"]);
 
     return {
       CallExpression(node) {
-        const callee = node.callee
-        if (callee.type !== "MemberExpression") return
-        if (callee.property.type !== "Identifier") return
+        const callee = node.callee;
+        if (callee.type !== "MemberExpression") return;
+        if (callee.property.type !== "Identifier") return;
 
-        const methodName = callee.property.name
-        if (!MUTATION_METHODS.has(methodName)) return
+        const methodName = callee.property.name;
+        if (!MUTATION_METHODS.has(methodName)) return;
 
-        const obj = callee.object
-        if (obj.type !== "MemberExpression") return
+        const obj = callee.object;
+        if (obj.type !== "MemberExpression") return;
 
-        const parentObj = obj.object
-        if (parentObj.type !== "MemberExpression") return
-        if (parentObj.property.type !== "Identifier") return
-        if (parentObj.property.name !== "prisma") return
+        const parentObj = obj.object;
+        if (parentObj.type !== "MemberExpression") return;
+        if (parentObj.property.type !== "Identifier") return;
+        if (parentObj.property.name !== "prisma") return;
 
-        if (parentObj.object.type !== "ThisExpression") return
+        if (parentObj.object.type !== "ThisExpression") return;
 
-        const modelName =
-          obj.property.type === "Identifier" ? obj.property.name : "model"
+        const modelName = obj.property.type === "Identifier" ? obj.property.name : "model";
 
         context.report({
           node,
           messageId: "noDirectMutation",
           data: { method: methodName, model: modelName },
-        })
+        });
       },
-    }
+    };
   },
-}
+};

package/eslint-plugin-quickdraw/rules/no-raw-button-strings.mjs

@@ -0,0 +1,52 @@
+/** @type {import('eslint').Rule.RuleModule} */
+export default {
+  meta: {
+    type: "problem",
+    docs: {
+      description:
+        "Disallow raw string literals in Button components. Use useTranslations() or the <T> component for localization.",
+    },
+    messages: {
+      noRawButtonStrings:
+        "Raw string '{{content}}' in Button component should be localized. Use t('key') or <T>key</T> instead.",
+    },
+    schema: [],
+  },
+  create(context) {
+    return {
+      JSXElement(node) {
+        // Check if this is a Button element
+        if (
+          node.openingElement.name.type !== "JSXIdentifier" ||
+          node.openingElement.name.name !== "Button"
+        ) {
+          return;
+        }
+
+        // Check all children for raw strings
+        for (const child of node.children) {
+          if (child.type === "JSXText") {
+            // Flag JSXText that contains non-whitespace characters
+            const trimmedText = child.value.trim();
+            if (trimmedText.length > 0) {
+              context.report({
+                node: child,
+                messageId: "noRawButtonStrings",
+                data: { content: trimmedText },
+              });
+            }
+          } else if (child.type === "JSXExpressionContainer") {
+            // Flag JSXExpressionContainer where the expression is a string literal
+            if (child.expression.type === "Literal" && typeof child.expression.value === "string") {
+              context.report({
+                node: child,
+                messageId: "noRawButtonStrings",
+                data: { content: child.expression.value },
+              });
+            }
+          }
+        }
+      },
+    };
+  },
+};

package/eslint-plugin-quickdraw/rules/no-raw-service-room-string.mjs

@@ -0,0 +1,140 @@
+/**
+ * Bans raw template literals used as room name strings in emit/to/join calls.
+ * Use serviceRoom(), userRoom(), etc. helpers from your shared package instead.
+ *
+ * Options: { additionalPatterns: string[] } — app-specific room patterns
+ * (regex sources) checked in addition to the defaults.
+ */
+
+const DEFAULT_ROOM_PATTERNS = [/Service:\$\{/, /^user:\$\{/];
+
+/**
+ * Check if a template literal node looks like a room string.
+ */
+function isRoomTemplateLiteral(node, patterns) {
+  if (node.type !== "TemplateLiteral" || node.expressions.length === 0) {
+    return false;
+  }
+
+  // Reconstruct the raw template pattern by replacing expressions with ${...}
+  let raw = "";
+  for (let i = 0; i < node.quasis.length; i++) {
+    raw += node.quasis[i].value.raw;
+    if (i < node.expressions.length) {
+      raw += "${...}";
+    }
+  }
+
+  return patterns.some((pattern) => pattern.test(raw));
+}
+
+/**
+ * Check if a node is a call to emitToRoom, .to(), .join(), or
+ * emitConnectedUsers and return the argument index that represents the room name.
+ */
+function getRoomArgIndex(node) {
+  if (node.type !== "CallExpression") return -1;
+
+  const callee = node.callee;
+
+  // this.emitToRoom(ROOM, ...) or service.emitToRoom(ROOM, ...)
+  if (
+    callee.type === "MemberExpression" &&
+    callee.property.type === "Identifier" &&
+    callee.property.name === "emitToRoom"
+  ) {
+    return 0;
+  }
+
+  // .to(ROOM) — Socket.IO chaining
+  if (
+    callee.type === "MemberExpression" &&
+    callee.property.type === "Identifier" &&
+    callee.property.name === "to"
+  ) {
+    return 0;
+  }
+
+  // .join(ROOM) — Socket.IO room joining
+  if (
+    callee.type === "MemberExpression" &&
+    callee.property.type === "Identifier" &&
+    callee.property.name === "join"
+  ) {
+    return 0;
+  }
+
+  // this.emitConnectedUsers(entityId, ROOM)
+  if (
+    callee.type === "MemberExpression" &&
+    callee.property.type === "Identifier" &&
+    callee.property.name === "emitConnectedUsers"
+  ) {
+    return 1;
+  }
+
+  return -1;
+}
+
+/** @type {import('eslint').Rule.RuleModule} */
+export default {
+  meta: {
+    type: "problem",
+    docs: {
+      description:
+        "Disallow raw template literal room strings in emit/to/join calls. Use serviceRoom() or other room helpers from your shared package.",
+    },
+    messages: {
+      noRawRoomString:
+        "Use serviceRoom() or other room helpers from your shared package instead of raw template literals for room names.",
+    },
+    schema: [
+      {
+        type: "object",
+        properties: {
+          additionalPatterns: {
+            type: "array",
+            items: { type: "string" },
+          },
+        },
+        additionalProperties: false,
+      },
+    ],
+  },
+  create(context) {
+    const options = context.options[0] ?? {};
+    const patterns = [
+      ...DEFAULT_ROOM_PATTERNS,
+      ...(options.additionalPatterns ?? []).map((source) => new RegExp(source)),
+    ];
+
+    return {
+      CallExpression(node) {
+        const argIndex = getRoomArgIndex(node);
+        if (argIndex < 0 || !node.arguments[argIndex]) return;
+
+        const arg = node.arguments[argIndex];
+        if (isRoomTemplateLiteral(arg, patterns)) {
+          context.report({
+            node: arg,
+            messageId: "noRawRoomString",
+          });
+        }
+      },
+      // Also catch: const room = `chatService:${id}`;
+      VariableDeclarator(node) {
+        if (
+          node.id.type === "Identifier" &&
+          /room/i.test(node.id.name) &&
+          node.init &&
+          isRoomTemplateLiteral(node.init, patterns)
+        ) {
+          context.report({
+            node: node.init,
+            messageId: "noRawRoomString",
+          });
+        }
+      },
+    };
+  },
+};

package/eslint-plugin-quickdraw/rules/no-raw-socket-emit.mjs

@@ -2,12 +2,12 @@
  * Allowed event name prefixes that are exempt from this rule.
  * These are documented exceptions for protocols that don't map to BaseService.
  */
-const DEFAULT_ALLOWED_PREFIXES = ["agentRunner:", "projectRunner:"]
+const DEFAULT_ALLOWED_PREFIXES = ["agentRunner:", "projectRunner:"];
 
 /**
  * Allowed exact event names that are exempt from this rule.
  */
-const DEFAULT_ALLOWED_EVENTS = new Set(["subscribe", "unsubscribe"])
+const DEFAULT_ALLOWED_EVENTS = new Set(["subscribe", "unsubscribe"]);
 
 /** @type {import('eslint').Rule.RuleModule} */
 export default {
@@ -51,45 +51,43 @@ export default {
     ],
   },
   create(context) {
-    const options = context.options[0] || {}
-    const allowedPrefixes = options.allowedPrefixes || DEFAULT_ALLOWED_PREFIXES
-    const allowedEvents = new Set(
-      options.allowedEvents || DEFAULT_ALLOWED_EVENTS
-    )
+    const options = context.options[0] || {};
+    const allowedPrefixes = options.allowedPrefixes || DEFAULT_ALLOWED_PREFIXES;
+    const allowedEvents = new Set(options.allowedEvents || DEFAULT_ALLOWED_EVENTS);
 
     return {
       CallExpression(node) {
-        const callee = node.callee
-        if (callee.type !== "MemberExpression") return
-        if (callee.property.type !== "Identifier") return
-        if (callee.property.name !== "emit") return
+        const callee = node.callee;
+        if (callee.type !== "MemberExpression") return;
+        if (callee.property.type !== "Identifier") return;
+        if (callee.property.name !== "emit") return;
 
-        const obj = callee.object
-        if (obj.type !== "Identifier" || obj.name !== "socket") return
+        const obj = callee.object;
+        if (obj.type !== "Identifier" || obj.name !== "socket") return;
 
-        const eventArg = node.arguments[0]
-        if (!eventArg) return
+        const eventArg = node.arguments[0];
+        if (!eventArg) return;
 
         if (eventArg.type === "Literal" && typeof eventArg.value === "string") {
-          const eventName = eventArg.value
+          const eventName = eventArg.value;
 
-          if (allowedEvents.has(eventName)) return
+          if (allowedEvents.has(eventName)) return;
           if (allowedPrefixes.some((prefix) => eventName.startsWith(prefix))) {
-            return
+            return;
           }
 
           context.report({
             node,
             messageId: "noRawSocketEmit",
             data: { eventName },
-          })
+          });
         } else {
           context.report({
             node,
             messageId: "noRawSocketEmitDynamic",
-          })
+          });
         }
       },
-    }
+    };
   },
-}
+};

package/eslint-plugin-quickdraw/rules/no-raw-socket-on.mjs

@@ -2,7 +2,7 @@
  * Allowed event name prefixes that are exempt from this rule.
  * These are documented exceptions for protocols that don't map to BaseService.
  */
-const DEFAULT_ALLOWED_PREFIXES = ["agentRunner:", "projectRunner:"]
+const DEFAULT_ALLOWED_PREFIXES = ["agentRunner:", "projectRunner:"];
 
 /** @type {import('eslint').Rule.RuleModule} */
 export default {
@@ -39,41 +39,41 @@ export default {
     ],
   },
   create(context) {
-    const options = context.options[0] || {}
-    const allowedPrefixes = options.allowedPrefixes || DEFAULT_ALLOWED_PREFIXES
+    const options = context.options[0] || {};
+    const allowedPrefixes = options.allowedPrefixes || DEFAULT_ALLOWED_PREFIXES;
 
     return {
       CallExpression(node) {
-        const callee = node.callee
-        if (callee.type !== "MemberExpression") return
-        if (callee.property.type !== "Identifier") return
-        if (callee.property.name !== "on") return
+        const callee = node.callee;
+        if (callee.type !== "MemberExpression") return;
+        if (callee.property.type !== "Identifier") return;
+        if (callee.property.name !== "on") return;
 
-        const obj = callee.object
-        if (obj.type !== "Identifier" || obj.name !== "socket") return
+        const obj = callee.object;
+        if (obj.type !== "Identifier" || obj.name !== "socket") return;
 
-        const eventArg = node.arguments[0]
-        if (!eventArg) return
+        const eventArg = node.arguments[0];
+        if (!eventArg) return;
 
         if (eventArg.type === "Literal" && typeof eventArg.value === "string") {
-          const eventName = eventArg.value
+          const eventName = eventArg.value;
 
           if (allowedPrefixes.some((prefix) => eventName.startsWith(prefix))) {
-            return
+            return;
           }
 
           context.report({
             node,
             messageId: "noRawSocketOn",
             data: { eventName },
-          })
+          });
         } else {
           context.report({
             node,
             messageId: "noRawSocketOnDynamic",
-          })
+          });
         }
       },
-    }
+    };
   },
-}
+};

package/eslint-plugin-quickdraw/rules/no-raw-tooltip-strings.mjs

@@ -0,0 +1,59 @@
+/** @type {import('eslint').Rule.RuleModule} */
+export default {
+  meta: {
+    type: "problem",
+    docs: {
+      description:
+        "Disallow raw string literals in Tooltip title props. Use useTranslations() for localization.",
+    },
+    messages: {
+      noRawTooltipStrings:
+        "Raw string '{{content}}' in Tooltip title should be localized. Use t('key') instead.",
+    },
+    schema: [],
+  },
+  create(context) {
+    return {
+      JSXOpeningElement(node) {
+        if (node.name.type !== "JSXIdentifier" || node.name.name !== "Tooltip") {
+          return;
+        }
+
+        const titleAttr = node.attributes.find(
+          (a) => a.type === "JSXAttribute" && a.name.name === "title",
+        );
+        if (!titleAttr) return;
+
+        // Check for title="raw string"
+        if (
+          titleAttr.value &&
+          (titleAttr.value.type === "StringLiteral" || titleAttr.value.type === "Literal") &&
+          typeof titleAttr.value.value === "string" &&
+          titleAttr.value.value.trim().length > 0
+        ) {
+          context.report({
+            node: titleAttr,
+            messageId: "noRawTooltipStrings",
+            data: { content: titleAttr.value.value },
+          });
+        }
+
+        // Check for title={"raw string"}
+        if (
+          titleAttr.value &&
+          titleAttr.value.type === "JSXExpressionContainer" &&
+          titleAttr.value.expression &&
+          titleAttr.value.expression.type === "Literal" &&
+          typeof titleAttr.value.expression.value === "string" &&
+          titleAttr.value.expression.value.trim().length > 0
+        ) {
+          context.report({
+            node: titleAttr,
+            messageId: "noRawTooltipStrings",
+            data: { content: titleAttr.value.expression.value },
+          });
+        }
+      },
+    };
+  },
+};

package/eslint-plugin-quickdraw/rules/no-raw-typography-strings.mjs

@@ -0,0 +1,52 @@
+/** @type {import('eslint').Rule.RuleModule} */
+export default {
+  meta: {
+    type: "problem",
+    docs: {
+      description:
+        "Disallow raw string literals in Typography components. Use useTranslations() or the <T> component for localization.",
+    },
+    messages: {
+      noRawTypographyStrings:
+        "Raw string '{{content}}' in Typography component should be localized. Use t('key') or <T>key</T> instead.",
+    },
+    schema: [],
+  },
+  create(context) {
+    return {
+      JSXElement(node) {
+        // Check if this is a Typography element
+        if (
+          node.openingElement.name.type !== "JSXIdentifier" ||
+          node.openingElement.name.name !== "Typography"
+        ) {
+          return;
+        }
+
+        // Check all children for raw strings
+        for (const child of node.children) {
+          if (child.type === "JSXText") {
+            // Flag JSXText that contains non-whitespace characters
+            const trimmedText = child.value.trim();
+            if (trimmedText.length > 0) {
+              context.report({
+                node: child,
+                messageId: "noRawTypographyStrings",
+                data: { content: trimmedText },
+              });
+            }
+          } else if (child.type === "JSXExpressionContainer") {
+            // Flag JSXExpressionContainer where the expression is a string literal
+            if (child.expression.type === "Literal" && typeof child.expression.value === "string") {
+              context.report({
+                node: child,
+                messageId: "noRawTypographyStrings",
+                data: { content: child.expression.value },
+              });
+            }
+          }
+        }
+      },
+    };
+  },
+};

package/eslint-plugin-quickdraw/rules/no-service-method-record.mjs

@@ -26,10 +26,10 @@ export default {
             context.report({
               node: member,
               messageId: "noServiceMethodRecord",
-            })
+            });
           }
         }
       },
-    }
+    };
   },
-}
+};

package/eslint-plugin-quickdraw/rules/no-unsafe-payload-cast.mjs

@@ -17,12 +17,12 @@ export default {
   create(context) {
     return {
       TSAsExpression(node) {
-        const typeAnnotation = node.typeAnnotation
-        if (typeAnnotation.type !== "TSTypeReference") return
-        if (typeAnnotation.typeName?.type !== "TSQualifiedName") return
+        const typeAnnotation = node.typeAnnotation;
+        if (typeAnnotation.type !== "TSTypeReference") return;
+        if (typeAnnotation.typeName?.type !== "TSQualifiedName") return;
 
-        const left = typeAnnotation.typeName.left
-        const right = typeAnnotation.typeName.right
+        const left = typeAnnotation.typeName.left;
+        const right = typeAnnotation.typeName.right;
 
         if (
           left.type === "Identifier" &&
@@ -33,9 +33,9 @@ export default {
           context.report({
             node,
             messageId: "noUnsafePayloadCast",
-          })
+          });
         }
       },
-    }
+    };
   },
-}
+};