@fitzzero/quickdraw-core 2.3.0 → 3.1.0

package/eslint-config/index.mjs

@@ -101,7 +101,7 @@ export const server = [
     },
     plugins: { quickdraw: quickdrawPlugin },
     rules: {
-      "quickdraw/no-direct-prisma-mutations": "warn",
+      "quickdraw/no-cross-service-mutations": "warn",
       "quickdraw/require-zod-schema": "warn",
       "quickdraw/no-service-method-record": "error",
       "quickdraw/no-unsafe-payload-cast": "warn",
@@ -121,12 +121,6 @@ export const server = [
       "@typescript-eslint/no-unnecessary-type-assertion": "off",
     },
   },
-  {
-    files: ["**/services/**/index.ts"],
-    rules: {
-      "quickdraw/no-direct-prisma-mutations": "off",
-    },
-  },
 ];
 
 export const client = [

package/eslint-plugin-quickdraw/index.mjs

@@ -1,4 +1,4 @@
-import noDirectPrismaMutations from "./rules/no-direct-prisma-mutations.mjs"
+import noCrossServiceMutations from "./rules/no-cross-service-mutations.mjs"
 import requireZodSchema from "./rules/require-zod-schema.mjs"
 import noServiceMethodRecord from "./rules/no-service-method-record.mjs"
 import noUnsafePayloadCast from "./rules/no-unsafe-payload-cast.mjs"
@@ -6,7 +6,7 @@ import noUnsafePayloadCast from "./rules/no-unsafe-payload-cast.mjs"
 /** @type {import('eslint').ESLint.Plugin} */
 export default {
   rules: {
-    "no-direct-prisma-mutations": noDirectPrismaMutations,
+    "no-cross-service-mutations": noCrossServiceMutations,
     "require-zod-schema": requireZodSchema,
     "no-service-method-record": noServiceMethodRecord,
     "no-unsafe-payload-cast": noUnsafePayloadCast,

package/eslint-plugin-quickdraw/rules/no-cross-service-mutations.mjs

@@ -0,0 +1,113 @@
+const MUTATION_METHODS = new Set(["create", "update", "delete"])
+
+/**
+ * Extract the service directory name from a file path.
+ * e.g. "/app/services/cloud-build/index.ts" → "cloud-build"
+ *      "/app/services/task/helpers.ts" → "task"
+ */
+function getServiceDirName(filename) {
+  const match = filename.match(/services\/([^/]+)\//)
+  return match ? match[1] : null
+}
+
+/**
+ * Convert a kebab-case or snake_case directory name to camelCase
+ * to match Prisma model names.
+ * e.g. "cloud-build" → "cloudBuild", "task" → "task"
+ */
+function dirNameToModelName(dirName) {
+  return dirName.replace(/[-_](\w)/g, (_, c) => c.toUpperCase())
+}
+
+/** @type {import('eslint').Rule.RuleModule} */
+export default {
+  meta: {
+    type: "problem",
+    docs: {
+      description:
+        "Disallow Prisma mutations on models not owned by the current service. " +
+        "Services should route mutations through the owning service, not bypass it with direct Prisma calls.",
+    },
+    messages: {
+      useBaseService:
+        "Use this.{{ method }}() from BaseService instead of this.prisma.{{ model }}.{{ method }}(). " +
+        "BaseService methods auto-emit updates to subscribers.",
+      crossServiceMutation:
+        "Direct mutation on '{{ model }}' is not owned by this service. " +
+        "Route through the owning service instead of this.prisma.{{ model }}.{{ method }}().",
+    },
+    schema: [
+      {
+        type: "object",
+        properties: {
+          allowedModels: {
+            type: "object",
+            description:
+              "Map of service directory name → array of foreign model names that are allowed. " +
+              'e.g. { "task": ["chat"], "project": ["agent", "projectAgent"] }',
+            additionalProperties: {
+              type: "array",
+              items: { type: "string" },
+            },
+          },
+        },
+        additionalProperties: false,
+      },
+    ],
+  },
+  create(context) {
+    const filename = context.filename || context.getFilename()
+    const serviceDirName = getServiceDirName(filename)
+
+    if (!serviceDirName) return {}
+
+    const ownedModel = dirNameToModelName(serviceDirName)
+    const isIndexFile = filename.endsWith("/index.ts") || filename.endsWith("/index.js")
+    const options = context.options[0] || {}
+    const allowedModels = options.allowedModels || {}
+    const allowedForThisService = new Set(allowedModels[serviceDirName] || [])
+
+    return {
+      CallExpression(node) {
+        const callee = node.callee
+        if (callee.type !== "MemberExpression") return
+        if (callee.property.type !== "Identifier") return
+
+        const methodName = callee.property.name
+        if (!MUTATION_METHODS.has(methodName)) return
+
+        const obj = callee.object
+        if (obj.type !== "MemberExpression") return
+
+        const parentObj = obj.object
+        if (parentObj.type !== "MemberExpression") return
+        if (parentObj.property.type !== "Identifier") return
+        if (parentObj.property.name !== "prisma") return
+
+        if (parentObj.object.type !== "ThisExpression") return
+
+        const modelName =
+          obj.property.type === "Identifier" ? obj.property.name : "model"
+
+        if (modelName === ownedModel) {
+          if (!isIndexFile) {
+            context.report({
+              node,
+              messageId: "useBaseService",
+              data: { method: methodName, model: modelName },
+            })
+          }
+          return
+        }
+
+        if (allowedForThisService.has(modelName)) return
+
+        context.report({
+          node,
+          messageId: "crossServiceMutation",
+          data: { method: methodName, model: modelName },
+        })
+      },
+    }
+  },
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@fitzzero/quickdraw-core",
-  "version": "2.3.0",
+  "version": "3.1.0",
   "description": "Fast fullstack patterns for real-time applications with Socket.io and TanStack Query",
   "type": "module",
   "main": "./dist/shared/index.js",
@@ -42,13 +42,15 @@
   "scripts": {
     "build": "tsup",
     "dev": "tsup --watch",
-    "typecheck": "tsc --noEmit",
-    "lint": "eslint src --ext .ts,.tsx",
-    "lint:fix": "eslint src --ext .ts,.tsx --fix",
+    "typecheck": "tsgo --noEmit",
+    "lint": "oxlint src",
+    "lint:fix": "oxlint --fix src",
+    "format": "oxfmt --write .",
+    "format:check": "oxfmt --check .",
     "test": "vitest run",
     "test:watch": "vitest",
     "test:coverage": "vitest run --coverage",
-    "prepublishOnly": "pnpm build"
+    "prepublishOnly": "bun run build"
   },
   "keywords": [
     "socket.io",
@@ -115,12 +117,12 @@
     "@types/express": "^4.17.21",
     "@types/node": "^20.11.0",
     "@types/react": "^18.2.0",
-    "@typescript-eslint/eslint-plugin": "^7.0.0",
-    "@typescript-eslint/parser": "^7.0.0",
+    "@typescript/native-preview": "^7.0.0-dev",
     "@vitest/coverage-v8": "^1.3.0",
-    "eslint": "^8.56.0",
     "express": "^4.18.2",
     "jsdom": "^24.0.0",
+    "oxfmt": "^0.37.0",
+    "oxlint": "^1.52.0",
     "react": "^18.2.0",
     "react-dom": "^18.2.0",
     "socket.io": "^4.7.4",