@fitlab-ai/agent-infra 0.9.15 → 0.10.0

package/dist/lib/task/human-override.js

@@ -407,10 +407,7 @@ function resourceForSnapshot(policy, options, frontmatter) {
     if (policy.producerId === 'platform.issue') {
         const identity = options.probeIssueNumber !== undefined
             ? resourceIdentity(options.probeIssueNumber)
-            : taskIssueIdentity((frontmatter || {})) || (() => {
-                const number = toPositiveInteger(frontmatter?.issue_number);
-                return number === null ? null : resourceIdentity(number);
-            })();
+            : taskIssueIdentity((frontmatter || {}));
         return identity ? { kind: 'issue', identity, number: resourceIdentityNumber(identity) } : null;
     }
     if (policy.producerId === 'platform.pull-request') {
@@ -481,11 +478,11 @@ async function probePlatformFailure(taskRef, policy, resolved, options) {
     }
     const issueIdentity = options.probeIssueNumber !== undefined
         ? resourceIdentity(options.probeIssueNumber)
-        : taskIssueIdentity(frontmatter) || (() => {
-            const number = toPositiveInteger(frontmatter.issue_number);
-            return number === null ? null : resourceIdentity(number);
-        })();
+        : taskIssueIdentity(frontmatter);
     const fact = readPrDeliveryFact(frontmatter);
+    if (fact.status === 'invalid') {
+        return error(fact.error.code, fact.error.message);
+    }
     const pullRequestIdentity = options.probePullRequestNumber !== undefined
         ? resourceIdentity(options.probePullRequestNumber)
         : fact.status === 'valid' && fact.fact.state === 'bound' ? fact.fact.identity.resource : null;

package/dist/lib/task/intermediate-cleanup.js

@@ -7,11 +7,12 @@ import { checkpointCommitMatches } from './commit-identity.js';
 import { readCheckpointIntent } from './commit-intent.js';
 import { parseTaskFrontmatter } from './frontmatter.js';
 import { readTaskFinalizationReceipt } from './finalization.js';
-import { readLocalArtifactFinalizationIntent, semanticDigest, sha256Content } from './local-artifact-finalization.js';
+import { semanticDigest, sha256Content } from './local-artifact-finalization.js';
+import { artifactRecoveryRoot, readArtifactRecoveryIntent } from './artifact-repair-intent.js';
 import { parseArtifactName } from './artifact-name.js';
 import { enumerateAllTaskDirs } from './resolve-ref.js';
 const TASK_ID_RE = /^TASK-\d{8}-\d{6}$/;
-const LOCAL_INTENT_RE = /^(TASK-\d{8}-\d{6})-(analysis|plan|code)-(.+\.md)\.json$/;
+const LOCAL_INTENT_RE = /^(TASK-\d{8}-\d{6})-(analysis|review-analysis|plan|review-plan|code|review-code)-(.+\.md)\.json$/;
 const COMMIT_INTENT_RE = /^(TASK-\d{8}-\d{6})\.json$/;
 const AUXILIARY_ROOTS = [
     '.local-artifact-finalization-intents',
@@ -110,7 +111,7 @@ function localIntentCandidate(repoRoot, task, filePath, taskId, family, artifact
     }
     let intent;
     try {
-        intent = readLocalArtifactFinalizationIntent(repoRoot, taskId, family, artifact);
+        intent = readArtifactRecoveryIntent(repoRoot, taskId, family, artifact);
     }
     catch {
         return item('LFAI-CONSUMED', taskId, filePath, 'protected', 'LFAI_SCHEMA_INVALID', identity);
@@ -129,7 +130,7 @@ function localIntentCandidate(repoRoot, task, filePath, taskId, family, artifact
     catch {
         return item('LFAI-CONSUMED', taskId, filePath, 'protected', 'ARTIFACT_UNREADABLE', identity);
     }
-    if (intent.artifactSha256 !== sha256Content(content) || intent.semanticDigest !== semanticDigest(content)) {
+    if (intent.finalArtifactSha256 !== sha256Content(content) || intent.finalSemanticDigest !== semanticDigest(content)) {
         return item('LFAI-CONSUMED', taskId, filePath, 'protected', 'ARTIFACT_DIGEST_MISMATCH', identity);
     }
     const receiptReason = receiptGate(repoRoot, task, options);
@@ -254,7 +255,60 @@ function scanIntermediateCleanup(repoRoot, options = {}) {
     const candidates = scanInternal(repoRoot, options);
     return buildIntermediateCleanupReport(candidates, true);
 }
-function removeCandidate(candidate) {
+function cleanupConsumedRecoveryFiles(repoRoot, task, candidate) {
+    if (candidate.kind !== 'LFAI-CONSUMED' || !candidate.taskId)
+        return true;
+    if (!task)
+        return false;
+    const match = LOCAL_INTENT_RE.exec(path.basename(candidate.path));
+    if (!match)
+        return false;
+    let intent;
+    try {
+        intent = readArtifactRecoveryIntent(repoRoot, candidate.taskId, match[2], match[3]);
+    }
+    catch {
+        return false;
+    }
+    if (!intent || intent.state !== 'consumed')
+        return false;
+    const recovery = artifactRecoveryRoot(task.taskDir, intent.recoveryOperationId);
+    let stat = null;
+    try {
+        stat = fs.lstatSync(recovery);
+    }
+    catch (error) {
+        if (errorCode(error) === 'ENOENT')
+            return true;
+        return false;
+    }
+    if (!stat.isDirectory() || stat.isSymbolicLink())
+        return false;
+    let entries;
+    try {
+        entries = fs.readdirSync(recovery, { withFileTypes: true });
+    }
+    catch {
+        return false;
+    }
+    for (const entry of entries) {
+        if (entry.isSymbolicLink() || !entry.isFile() || !['baseline.md', 'candidate.md', 'final.md', 'publish.md'].includes(entry.name))
+            return false;
+    }
+    try {
+        for (const entry of entries)
+            fs.unlinkSync(path.join(recovery, entry.name));
+        fs.rmdirSync(recovery);
+        const recoveryRoot = path.dirname(recovery);
+        if (fs.readdirSync(recoveryRoot).length === 0)
+            fs.rmdirSync(recoveryRoot);
+        return true;
+    }
+    catch (error) {
+        return errorCode(error) === 'ENOENT';
+    }
+}
+function removeCandidate(repoRoot, candidate, task) {
     if (candidate.disposition !== 'planned')
         return candidate;
     const root = candidate.kind === 'EMPTY-AUX-PARENT'
@@ -279,6 +333,9 @@ function removeCandidate(candidate) {
         return { ...candidate, disposition: 'protected', reason: 'PATH_IDENTITY_CHANGED' };
     if (!sameFileIdentity(expected, actual))
         return { ...candidate, disposition: 'protected', reason: 'PATH_IDENTITY_CHANGED' };
+    if (!cleanupConsumedRecoveryFiles(repoRoot, task, candidate)) {
+        return { ...candidate, disposition: 'protected', reason: 'RECOVERY_STAGING_NOT_SAFE_TO_REMOVE' };
+    }
     try {
         if (candidate.kind === 'EMPTY-AUX-PARENT') {
             if (fs.readdirSync(candidate.path).length !== 0)
@@ -317,6 +374,7 @@ function cleanupIntermediateUnderRemovalCoordinator(repoRoot, options = {}) {
         indexes.push(index);
         byTask.set(candidate.taskId, indexes);
     }
+    const tasks = inspectTaskRecords(repoRoot, new Set(byTask.keys()));
     for (const taskId of [...byTask.keys()].sort()) {
         const execute = () => {
             const refreshed = scanIntermediateCleanup(repoRoot, {
@@ -330,7 +388,7 @@ function cleanupIntermediateUnderRemovalCoordinator(repoRoot, options = {}) {
                     continue;
                 const current = refreshedByKey.get(intermediateCleanupKey(initialCandidate));
                 items[index] = current
-                    ? removeCandidate(current)
+                    ? removeCandidate(repoRoot, current, tasks.get(taskId))
                     : { ...initialCandidate, disposition: 'protected', reason: 'CANDIDATE_NO_LONGER_ELIGIBLE' };
             }
         };
@@ -351,14 +409,14 @@ function cleanupIntermediateUnderRemovalCoordinator(repoRoot, options = {}) {
     for (const [index, candidate] of items.entries()) {
         if (candidate.taskId || candidate.disposition !== 'planned')
             continue;
-        items[index] = removeCandidate(candidate);
+        items[index] = removeCandidate(repoRoot, candidate);
     }
     const knownPaths = new Set(items.map((candidate) => intermediateCleanupKey(candidate)));
     for (const candidate of scanIntermediateCleanup(repoRoot, scanOptions).items) {
         if (candidate.kind !== 'EMPTY-AUX-PARENT' || candidate.disposition !== 'planned'
             || knownPaths.has(intermediateCleanupKey(candidate)))
             continue;
-        items.push(removeCandidate(candidate));
+        items.push(removeCandidate(repoRoot, candidate));
     }
     return buildIntermediateCleanupReport(items);
 }