@fitlab-ai/agent-infra 0.9.14 → 0.10.0

package/dist/lib/task/verification-engine.js

@@ -12,12 +12,16 @@ import { resolveMaterializedReviewedHeadRelation } from "../platform/change-requ
 import { resolveReviewedHeadRelation } from "../platform/merged-pr-equivalence.js";
 import { resolveLocalReviewedCommitRelation } from "../git/reviewed-commit-equivalence.js";
 import { parseTypedTaskFrontmatter } from "./frontmatter.js";
-import { LEDGER_SECTION_MISSING_CODE, LEDGER_SECTION_MISSING_MESSAGE, parseLedgerDocument, summarizeLedgerStage, validateLedgerRows } from "./ledger.js";
+import { LEDGER_TERMINAL, LEDGER_SECTION_MISSING_CODE, LEDGER_SECTION_MISSING_MESSAGE, parseLedgerDocument, summarizeLedgerStage, validateLedgerRows } from "./ledger.js";
 import { isValidAgentInfraVersion } from "../version.js";
 import { equalCounts, parseReviewSummary } from "./review-artifacts.js";
 import { inspectDecisionDetailDuplicates } from "./decision-details.js";
+import { parseImplementationInputs } from "./implementation-inputs.js";
+import { scanVisibleMarkdown } from "./markdown.js";
 import { loadVerificationConfig } from "./verification-config.js";
 import { snapshotReview } from "../git/review-snapshot.js";
+import { inspectActivityLog } from "./activity-log.js";
+import { parseWorkflowWarnings } from "./workflow-warnings.js";
 import { OrchestrationStateError, readRun } from "./orchestration.js";
 import { resolveDeliveryTarget } from "./delivery-target.js";
 import { readPrDeliveryFact } from "./pr-delivery-fact.js";
@@ -25,6 +29,11 @@ import { validateLocalArtifact } from "./local-artifact-finalization.js";
 import { validateQualificationAudit } from "./qualification-audit.js";
 import { getArtifactSchema } from "./artifact-schema.js";
 import { inspectArtifactContract } from "./artifact-operations.js";
+import { manualValidationFinalSummaryProjectionMatches } from "./manual-validation-receipt.js";
+import { readManualValidationCompletion } from "./manual-validation-completion.js";
+import { sha256File } from "./artifact-receipts.js";
+import { summaryCommentState } from "../platform/pr-summary.js";
+import { taskIssueIdentity } from "../platform/task-identities.js";
 const TASK_ENUMS = {
     type: ["feature", "bugfix", "refactor", "docs", "chore"],
     workflow: ["feature-development", "bug-fix", "refactoring"],
@@ -42,7 +51,6 @@ const DEFAULT_REQUIRED_FIELDS = [
     "assigned_to"
 ];
 const DATE_TIME_PATTERN = /^\d{4}-\d{2}-\d{2}[T ]\d{2}:\d{2}:\d{2}(?:[+-]\d{2}:\d{2})?$/;
-const ACTIVITY_LOG_PATTERN = /^- (\d{4}-\d{2}-\d{2}[T ]\d{2}:\d{2}:\d{2}(?:[+-]\d{2}:\d{2})?) — \*\*(.+?)\*\* by (.+?) — (.+)$/;
 // Start markers (action suffixed with ` [started]`) are excluded from the
 // "latest action" / freshness computation so a step's in-flight marker never
 // satisfies a skill's expected_action_pattern; the matching done entry does.
@@ -50,27 +58,11 @@ const ACTIVITY_LOG_STARTED_RE = /\s*\[started\]\s*$/;
 const BRANCH_SLUG_PATTERN = /^[a-z0-9]+(?:-[a-z0-9]+)*$/;
 // Review disagreement ledger (see .agents/rules/review-handshake.md).
 const LEDGER_SECTION_NAMES = ["审查分歧账本", "Review Disagreement Ledger"];
-const LEDGER_STATUSES = new Set([
-    "open",
-    "accepted",
-    "adjusted",
-    "refuted",
-    "cannot-judge",
-    "confirmed",
-    "needs-human-decision",
-    "closed",
-    "human-decided"
-]);
-const LEDGER_TERMINAL_OK = new Set(["confirmed", "closed", "human-decided"]);
 const DEFAULT_MAX_HANDSHAKE_ROUNDS = 3;
 const POST_REVIEW_COMMIT_STAGE = "post-review-commit";
 const SHA_PATTERN = /^[0-9a-f]{7,40}$/i;
-const WORKFLOW_WARNING_SECTION_NAMES = ["工作流告警", "Workflow Warnings"];
-const WORKFLOW_WARNING_STATUSES = new Set(["open", "resolved", "ignored"]);
-const WORKFLOW_WARNING_SEVERITIES = new Set(["IMPORTANT", "ACTION_REQUIRED"]);
-const WORKFLOW_WARNING_ID_PATTERN = /^WW-\d+$/;
 const scriptPath = fileURLToPath(import.meta.url);
-let repoRoot = path.resolve(path.dirname(scriptPath), "..", "..");
+const defaultRepoRoot = path.resolve(path.dirname(scriptPath), "..", "..");
 const PLATFORM_ADAPTERS = {
     "platform-sync": checkPlatformSync,
     "platform-sync-preflight": async (context, shared) => ({ ...await checkPlatformSync(context, shared), type: "platform-sync-preflight" }),
@@ -87,8 +79,6 @@ const sharedUtils = {
     failResult,
     blockedResult,
     safeStat,
-    parseIssueNumber,
-    parsePrNumber
 };
 async function runCheck(type, context, shared) {
     switch (type) {
@@ -175,14 +165,12 @@ function exactText(value) {
 function validateCleanCompletionEvidence(run) {
     const evidence = run.completionEvidence;
     const shaPattern = /^[0-9a-f]{40}$/i;
-    if (evidence?.kind !== 'reviewed-head-clean'
-        || !exactText(evidence.observedAt)
+    if (!evidence
         || Number.isNaN(Date.parse(evidence.observedAt))
         || !shaPattern.test(evidence.head)
         || !shaPattern.test(evidence.headTree)
         || !shaPattern.test(evidence.worktreeTree)
         || !shaPattern.test(evidence.lastReviewedCommit)
-        || !(evidence.prNumber === null || (Number.isInteger(evidence.prNumber) && evidence.prNumber > 0))
         || !(evidence.prHead === null || shaPattern.test(evidence.prHead))) {
         return 'Clean completion evidence has an invalid structure';
     }
@@ -195,7 +183,6 @@ function validateCleanCompletionEvidence(run) {
         || run.pendingDelegation !== null
         || run.commitAuthorization?.issuedAt !== null
         || run.commitAuthorization?.consumedAt !== null
-        || !Array.isArray(run.receipts)
         || run.receipts.some((receipt) => receipt.stage === 'commit')) {
         return 'Clean completion evidence conflicts with commit delegation state';
     }
@@ -214,43 +201,10 @@ function checkOrchestrationEvidence({ taskDir }) {
         const message = error instanceof OrchestrationStateError ? error.message : String(error);
         return failResult('orchestration-evidence', `Invalid orchestration.json: ${message}`);
     }
+    if (!run)
+        return failResult('orchestration-evidence', 'orchestration.json is missing');
+    // readRun validates the persisted schema, receipt identities and client provenance.
     const policy = run.modelPolicy;
-    if (!policy
-        || !exactText(policy.executor?.model)
-        || !exactText(policy.executor?.reasoningEffort)
-        || !exactText(policy.reviewer?.model)
-        || !exactText(policy.reviewer?.reasoningEffort)) {
-        return failResult('orchestration-evidence', 'Run model policy requires exact executor and reviewer model and effort');
-    }
-    if (!run.modelPolicySource
-        || !['explicit', 'project-config'].includes(run.modelPolicySource.kind)
-        || !exactText(run.modelPolicySource.client)
-        || !exactText(run.modelPolicySource.resolvedAt)
-        || !Array.isArray(run.recoveryHistory)) {
-        return failResult('orchestration-evidence', 'Run model policy source or recovery history is invalid');
-    }
-    for (const recovery of run.recoveryHistory) {
-        const guards = recovery.guards;
-        const validClaudeCodeRecovery = recovery.code === 'CLIENT_CAPABILITY_ENABLED'
-            && recovery.previousStatus === 'paused'
-            && recovery.previousPause?.code === 'ORCHESTRATION_CLIENT_UNSUPPORTED'
-            && recovery.client === 'claude-code'
-            && recovery.resultingStatus === 'running'
-            && exactText(recovery.recoveredAt)
-            && guards?.stepCount === 0
-            && guards?.nextStage === null
-            && guards?.baselineEmpty === true
-            && guards?.receiptCount === 0
-            && guards?.pendingDelegation === false
-            && guards?.commitAuthorizationUnused === true
-            && guards?.completionEvidenceAbsent === true;
-        if (!validClaudeCodeRecovery) {
-            return failResult('orchestration-evidence', 'Run recovery history contains invalid provenance');
-        }
-    }
-    if (!Array.isArray(run.receipts)) {
-        return failResult('orchestration-evidence', 'Run receipts must be an array');
-    }
     if (run.completionEvidence != null) {
         const evidenceError = validateCleanCompletionEvidence(run);
         if (evidenceError)
@@ -282,10 +236,6 @@ function checkOrchestrationEvidence({ taskDir }) {
                     return failResult('orchestration-evidence', `Receipt '${receipt.id ?? '(unknown)'}' has no host-observed actual reasoning effort`);
                 }
             }
-            // parentId/childId 校验对所有 client 保持统一（不新增分支）；spawnMode 检查按 client 判断
-            if (!exactText(receipt.parentId) || !exactText(receipt.childId) || receipt.parentId === receipt.childId) {
-                return failResult('orchestration-evidence', `Receipt '${receipt.id ?? '(unknown)'}' has invalid delegation identity`);
-            }
             if (!isClaudeCode && receipt.spawnMode !== 'fresh') {
                 return failResult('orchestration-evidence', `Receipt '${receipt.id ?? '(unknown)'}' has invalid fresh delegation identity`);
             }
@@ -307,41 +257,6 @@ function checkOrchestrationEvidence({ taskDir }) {
                 && receipt.reasoningEffortFallbackReason !== null) {
                 return failResult('orchestration-evidence', `Receipt '${receipt.id ?? '(unknown)'}' has an unrelated reasoning-effort fallback reason`);
             }
-            if (receipt.client === 'codex') {
-                const activatedCodex = ['activated', 'stage-completed', 'sealed', 'consumed'].includes(receipt.status);
-                const host = receipt.hostEvidence;
-                const provenance = receipt.lifecycleProvenance;
-                if (!provenance
-                    || (activatedCodex && (host?.kind !== 'codex-lifecycle-v2'
-                        || host.protocolVersion !== provenance.protocolVersion
-                        || host.hookDefinitionHash !== provenance.hookDefinitionHash
-                        || host.hookSource !== provenance.hookSource
-                        || host.hookSourcePathDigest !== provenance.hookSourcePathDigest
-                        || host.hookSourceHash !== provenance.hookSourceHash
-                        || host.capabilitySessionId !== provenance.capabilitySessionId
-                        || receipt.parentId !== provenance.capabilitySessionId
-                        || host.capabilityTurnId !== provenance.capabilityTurnId
-                        || host.controllerInstanceDigest !== provenance.controllerInstanceDigest
-                        || host.controlGeneration !== provenance.controlGeneration
-                        || host.spawnToolUseId === provenance.capabilityToolUseId
-                        || !exactText(host.spawnToolUseId)
-                        || !Number.isFinite(Date.parse(host.spawnObservedAt ?? ''))
-                        || !Number.isFinite(Date.parse(receipt.spawnDispatchedAt ?? ''))
-                        || !Number.isFinite(Date.parse(receipt.activationDeadlineAt ?? ''))
-                        || Date.parse(host.spawnObservedAt ?? '') < Date.parse(receipt.spawnDispatchedAt ?? '')
-                        || Date.parse(host.spawnObservedAt ?? '') > Date.parse(receipt.activationDeadlineAt ?? '')
-                        || !exactText(host.hookDefinitionHash)
-                        || !Number.isSafeInteger(host.startRevision)
-                        || host.startRevision < 1))) {
-                    return failResult('orchestration-evidence', `Receipt '${receipt.id ?? '(unknown)'}' has invalid Codex start evidence`);
-                }
-                if (['sealed', 'consumed'].includes(receipt.status) && (!Number.isSafeInteger(host.stopRevision)
-                    || host.stopRevision <= host.startRevision
-                    || host.consumer !== receipt.id
-                    || !exactText(host.consumedAt))) {
-                    return failResult('orchestration-evidence', `Receipt '${receipt.id ?? '(unknown)'}' has invalid Codex consumed stop evidence`);
-                }
-            }
         }
     }
     if (run.receipts.some((receipt) => receipt.status !== 'consumed')) {
@@ -350,7 +265,7 @@ function checkOrchestrationEvidence({ taskDir }) {
     return passResult('orchestration-evidence', 'Persisted orchestration model and delegation evidence is internally consistent');
 }
 // === Check Functions ===
-function checkTaskMeta({ taskDir, config }) {
+function checkTaskMeta({ taskDir, config, repositoryRoot }) {
     const task = loadTask(taskDir);
     if (!task.ok) {
         return failResult("task-meta", task.message);
@@ -380,13 +295,15 @@ function checkTaskMeta({ taskDir, config }) {
             return failResult("task-meta", `Invalid ${field}: ${metadata[field]}`);
         }
     }
-    const branchValidationError = validateTaskBranch(metadata);
+    const branchValidationError = validateTaskBranch(metadata, repositoryRoot);
     if (branchValidationError) {
         return failResult("task-meta", branchValidationError);
     }
-    const warningValidationErrors = validateWorkflowWarnings(task.content);
-    if (warningValidationErrors.length > 0) {
-        return failResult("task-meta", `Invalid Workflow Warnings: ${warningValidationErrors.join("; ")}`);
+    try {
+        parseWorkflowWarnings(task.content);
+    }
+    catch (error) {
+        return failResult("task-meta", `Invalid Workflow Warnings: ${error instanceof Error ? error.message : String(error)}`);
     }
     const expectedStep = config.expected_step;
     if (expectedStep && metadata.current_step !== expectedStep) {
@@ -396,8 +313,8 @@ function checkTaskMeta({ taskDir, config }) {
     if (expectedStatus && metadata.status !== expectedStatus) {
         return failResult("task-meta", `Expected status '${expectedStatus}', got '${metadata.status || "(empty)"}'`);
     }
-    if (config.require_issue_number && !parseIssueNumber(metadata.issue_number)) {
-        return failResult("task-meta", "Expected a valid issue_number in task metadata");
+    if (config.require_platform_issue_identity && !taskIssueIdentity(metadata)) {
+        return failResult("task-meta", "Expected a valid platform_issue_identity in task metadata");
     }
     if (config.require_completed_at && isBlank(metadata.completed_at)) {
         return failResult("task-meta", "Expected completed_at to be present");
@@ -481,11 +398,11 @@ async function checkRequiredPrDelivery({ taskDir, repositoryRoot, mode }) {
     }
     return passResult('required-pr-delivery', `Pull request delivery policy satisfied (${status})`);
 }
-function validateTaskBranch(metadata) {
+function validateTaskBranch(metadata, repoRoot) {
     if (isBlank(metadata.branch)) {
         return null;
     }
-    const projectName = loadProjectName();
+    const projectName = loadProjectName(repoRoot);
     const expectedPrefix = projectName ? `${projectName}-${metadata.type}-` : "";
     if (expectedPrefix && !String(metadata.branch).startsWith(expectedPrefix)) {
         return `Invalid branch: expected prefix '${expectedPrefix}', got '${metadata.branch}'`;
@@ -496,7 +413,7 @@ function validateTaskBranch(metadata) {
     }
     return null;
 }
-function loadProjectName() {
+function loadProjectName(repoRoot) {
     const configPath = path.join(repoRoot, ".agents", ".airc.json");
     if (!fs.existsSync(configPath)) {
         return "";
@@ -647,30 +564,17 @@ function checkImplementationInput({ taskDir, artifactFile }) {
     const artifactPath = path.join(taskDir, artifactFile);
     if (!safeStat(artifactPath)?.isFile())
         return failResult("implementation-input", `Artifact not found: ${artifactFile}`);
-    const inputSection = getSectionContent(task.content, ["实现输入", "Implementation Inputs"]);
-    const rows = [];
-    if (inputSection) {
-        const table = inputSection.split(/\r?\n/).filter((line) => line.trim().startsWith("|"));
-        const cells = (line) => line.split("|").slice(1, -1).map((cell) => cell.trim());
-        const expected = ["id", "ledger_id", "decision_evidence", "stage", "needs_implementation", "decided_at", "status", "consumed_by"];
-        if (table.length < 2 || JSON.stringify(cells(table[0])) !== JSON.stringify(expected)) {
-            return failResult("implementation-input", "Implementation Inputs table schema is invalid");
-        }
-        const seen = new Set();
-        for (const line of table.slice(2)) {
-            const row = cells(line);
-            if (row.length !== 8 || !/^II-[1-9]\d*$/.test(row[0]) || seen.has(row[0])) {
-                return failResult("implementation-input", "Implementation Inputs table contains an invalid or duplicate id");
-            }
-            seen.add(row[0]);
-            rows.push({ id: row[0], ledgerId: row[1], evidence: row[2], stage: row[3], needs: row[4], status: row[6], consumedBy: row[7] });
-        }
+    let rows;
+    try {
+        rows = parseImplementationInputs(task.content).rows;
     }
-    const logSection = getSectionContent(task.content, ["活动日志", "Activity Log"]);
-    const doneActions = logSection.split(/\r?\n/).flatMap((line) => {
-        const match = line.trim().match(ACTIVITY_LOG_PATTERN);
-        return match && !ACTIVITY_LOG_STARTED_RE.test(match[2]) ? [match[2]] : [];
-    });
+    catch (error) {
+        return failResult("implementation-input", `Invalid Implementation Inputs: ${error instanceof Error ? error.message : String(error)}`);
+    }
+    const doneActions = (inspectActivityLog(task.content).section?.entries ?? [])
+        .filter((entry) => !ACTIVITY_LOG_STARTED_RE.test(entry.step))
+        .map((entry) => entry.step)
+        .filter((step) => /^(?:Code Task|Code) \(Round \d+/.test(step));
     const latestAction = doneActions.at(-1) || "";
     const actionDecision = /(?:Code Task|Code) \(Round \d+, decision (II-[1-9]\d*)\)/.exec(latestAction)?.[1] || null;
     const report = fs.readFileSync(artifactPath, "utf8");
@@ -698,10 +602,10 @@ function checkImplementationInput({ taskDir, artifactFile }) {
     if (matches.length !== 1)
         return failResult("implementation-input", `${actionDecision} is missing or duplicated in task table`);
     const row = matches[0];
-    if (row.stage !== "code" || row.needs !== "true" || row.status !== "consumed" || row.consumedBy !== artifactFile || !row.evidence) {
+    if (row.stage !== "code" || !row.needsImplementation || row.status !== "consumed" || row.consumedBy !== artifactFile || !row.decisionEvidence) {
         return failResult("implementation-input", `${actionDecision} is not a consumed input for ${artifactFile}`);
     }
-    if (reportLedger !== row.ledgerId || reportEvidence !== row.evidence) {
+    if (reportLedger !== row.ledgerId || reportEvidence !== row.decisionEvidence) {
         return failResult("implementation-input", `${actionDecision} report identity does not match task table evidence`);
     }
     return passResult("implementation-input", `${actionDecision} matches Activity Log, report, and task table`);
@@ -711,27 +615,22 @@ function checkActivityLog({ taskDir, config }) {
     if (!task.ok) {
         return failResult("activity-log", task.message);
     }
-    const logSection = getSectionContent(task.content, ["活动日志", "Activity Log"]);
-    if (!logSection) {
-        return failResult("activity-log", "Activity Log section not found");
-    }
-    const entries = logSection
-        .split(/\r?\n/)
-        .map((line) => line.trim())
-        .filter((line) => line.startsWith("- "));
-    if (entries.length === 0) {
+    const { section, invalidEntries } = inspectActivityLog(task.content);
+    if (!section)
+        return failResult("activity-log", "Activity Log section not found or ambiguous");
+    if (invalidEntries.length)
+        return failResult("activity-log", `Invalid Activity Log entry format: ${invalidEntries[0]}`);
+    const entries = section.entries;
+    if (entries.length === 0)
         return failResult("activity-log", "Activity Log has no entries");
-    }
     let previousTimestamp = "";
     let latestAction = "";
     let latestTimestamp = "";
     const doneActions = [];
     for (const entry of entries) {
-        const match = entry.match(ACTIVITY_LOG_PATTERN);
-        if (!match) {
-            return failResult("activity-log", `Invalid Activity Log entry format: ${entry}`);
-        }
-        const [, timestamp, action] = match;
+        if (!entry.note.trim())
+            return failResult("activity-log", "Activity Log entry note is required");
+        const { time: timestamp, step: action } = entry;
         if (previousTimestamp && timestamp < previousTimestamp) {
             return failResult("activity-log", "Activity Log timestamps are not in ascending order");
         }
@@ -786,111 +685,7 @@ function checkCompletionChecklist({ taskDir, config }) {
     }
     return passResult("completion-checklist", `Completion Checklist valid (${items.length} items checked)`);
 }
-function splitMarkdownTableRow(line) {
-    let value = String(line || "").trim();
-    if (!value.startsWith("|")) {
-        return [];
-    }
-    value = value.replace(/^\|/, "").replace(/\|$/, "");
-    const cells = [];
-    let cell = "";
-    for (let index = 0; index < value.length; index += 1) {
-        const char = value[index];
-        if (char === "|" && !isEscapedAt(value, index)) {
-            cells.push(unescapeMarkdownTableCell(cell.trim()));
-            cell = "";
-            continue;
-        }
-        cell += char;
-    }
-    cells.push(unescapeMarkdownTableCell(cell.trim()));
-    return cells;
-}
-function unescapeMarkdownTableCell(value) {
-    let output = "";
-    for (let index = 0; index < value.length; index += 1) {
-        const char = value[index];
-        const next = value[index + 1];
-        if (char === "\\" && (next === "\\" || next === "|")) {
-            output += next;
-            index += 1;
-            continue;
-        }
-        output += char;
-    }
-    return output;
-}
-function isEscapedAt(value, index) {
-    let backslashes = 0;
-    for (let cursor = index - 1; cursor >= 0 && value[cursor] === "\\"; cursor -= 1) {
-        backslashes += 1;
-    }
-    return backslashes % 2 === 1;
-}
-function parseWorkflowWarningRows(section) {
-    const rows = [];
-    for (const rawLine of String(section || "").split(/\r?\n/)) {
-        const cells = splitMarkdownTableRow(rawLine);
-        if (cells.length === 0) {
-            continue;
-        }
-        if ((cells[0] || "").toLowerCase() === "id") {
-            continue;
-        }
-        if (cells.every((cell) => /^:?-{3,}:?$/.test(cell))) {
-            continue;
-        }
-        rows.push(cells);
-    }
-    return rows;
-}
-function validateWorkflowWarnings(content) {
-    const section = getSectionContent(content, WORKFLOW_WARNING_SECTION_NAMES);
-    if (!section.trim()) {
-        return [];
-    }
-    const rows = parseWorkflowWarningRows(section);
-    const errors = [];
-    for (const cells of rows) {
-        if (cells.length < 11) {
-            errors.push(`malformed row (expected 11 columns): ${cells.join(" | ")}`);
-            continue;
-        }
-        const [id, time, step, severity, code, status, target, message, action, resolvedAt, resolution] = cells;
-        if (!WORKFLOW_WARNING_ID_PATTERN.test(id)) {
-            errors.push(`${id || "(empty id)"}: invalid id`);
-        }
-        if (!DATE_TIME_PATTERN.test(time)) {
-            errors.push(`${id}: invalid time '${time}'`);
-        }
-        if (isBlank(step)) {
-            errors.push(`${id}: step is required`);
-        }
-        if (!WORKFLOW_WARNING_SEVERITIES.has(severity)) {
-            errors.push(`${id}: illegal severity '${severity}'`);
-        }
-        if (isBlank(code)) {
-            errors.push(`${id}: code is required`);
-        }
-        if (!WORKFLOW_WARNING_STATUSES.has(status)) {
-            errors.push(`${id}: illegal status '${status}'`);
-        }
-        if (isBlank(target)) {
-            errors.push(`${id}: target is required`);
-        }
-        if (isBlank(message)) {
-            errors.push(`${id}: message is required`);
-        }
-        if (status === "open" && isBlank(action)) {
-            errors.push(`${id}: open warning requires action`);
-        }
-        if ((status === "resolved" || status === "ignored") && (isBlank(resolvedAt) || isBlank(resolution))) {
-            errors.push(`${id}: ${status} warning requires resolved_at and resolution`);
-        }
-    }
-    return errors;
-}
-function resolveReviewSetting(config, key, fallback) {
+function resolveReviewSetting(config, key, fallback, repoRoot) {
     if (config && config[key] !== undefined && config[key] !== null) {
         return config[key];
     }
@@ -900,7 +695,7 @@ function resolveReviewSetting(config, key, fallback) {
     }
     return fallback;
 }
-function checkReviewLedger({ taskDir, config }) {
+function checkReviewLedger({ taskDir, config, repositoryRoot }) {
     const task = loadTask(taskDir);
     if (!task.ok) {
         return failResult("review-ledger", task.message);
@@ -910,9 +705,7 @@ function checkReviewLedger({ taskDir, config }) {
         const ledger = parseLedgerDocument(task.content);
         if (!ledger.present)
             return failResult("review-ledger", `${LEDGER_SECTION_MISSING_CODE}: ${LEDGER_SECTION_MISSING_MESSAGE}`);
-        rows = ledger.rows.map((row) => [
-            row.id, row.stage, row.round, row.severity, row.status, row.evidence
-        ]);
+        rows = ledger.rows;
     }
     catch (error) {
         return failResult("review-ledger", `Invalid disagreement ledger: ${error instanceof Error ? error.message : String(error)}`);
@@ -921,15 +714,11 @@ function checkReviewLedger({ taskDir, config }) {
         return passResult("review-ledger", "Disagreement ledger has no entries");
     }
     const stageScope = Array.isArray(config.stage_scope) ? config.stage_scope : null;
-    const maxRounds = Number(resolveReviewSetting(config, "maxHandshakeRounds", DEFAULT_MAX_HANDSHAKE_ROUNDS));
+    const maxRounds = Number(resolveReviewSetting(config, "maxHandshakeRounds", DEFAULT_MAX_HANDSHAKE_ROUNDS, repositoryRoot));
     const problems = [];
     let inScopeCount = 0;
-    for (const cells of rows) {
-        if (cells.length < 6) {
-            problems.push(`malformed row (expected 6 columns): ${cells.join(" | ")}`);
-            continue;
-        }
-        const [id, stage, roundRaw, , status, evidence] = cells;
+    for (const row of rows) {
+        const { id, stage, round: roundRaw, status, evidence } = row;
         const stageScoped = stageScope ? stageScope.includes(stage) : true;
         // post-review-commit exemption rows are consumed by the post-review-commit
         // check, not enforced here.
@@ -940,8 +729,9 @@ function checkReviewLedger({ taskDir, config }) {
             continue;
         }
         inScopeCount += 1;
-        if (!LEDGER_STATUSES.has(status)) {
-            problems.push(`${id}: illegal status '${status}'`);
+        const invalid = validateLedgerRows([row]);
+        if (invalid) {
+            problems.push(`${invalid.code}: ${invalid.message}`);
             continue;
         }
         if (status !== "open" && evidence === "") {
@@ -950,11 +740,11 @@ function checkReviewLedger({ taskDir, config }) {
         const round = Number.parseInt(roundRaw, 10);
         if (Number.isFinite(round) &&
             round >= maxRounds &&
-            !LEDGER_TERMINAL_OK.has(status) &&
+            !LEDGER_TERMINAL.has(status) &&
             status !== "needs-human-decision") {
             problems.push(`${id}: round ${round} reached limit ${maxRounds} without convergence; escalate to needs-human-decision`);
         }
-        if (!LEDGER_TERMINAL_OK.has(status)) {
+        if (!LEDGER_TERMINAL.has(status)) {
             problems.push(`${id}: unresolved (status '${status}')`);
         }
     }
@@ -964,7 +754,7 @@ function checkReviewLedger({ taskDir, config }) {
     const scopeLabel = stageScope ? ` for stages [${stageScope.join(", ")}]` : "";
     return passResult("review-ledger", `Disagreement ledger clean (${inScopeCount} in-scope entries terminal${scopeLabel})`);
 }
-function checkManualValidation({ taskDir }) {
+async function checkManualValidation({ taskDir, repositoryRoot }) {
     // 1. Latest review-code artifact; none -> pass (no review, check not applicable).
     const review = findAuthoritativeReviewCodeArtifact(taskDir);
     if (!review.ok) {
@@ -995,10 +785,23 @@ function checkManualValidation({ taskDir }) {
     const task = loadTask(taskDir);
     if (!task.ok)
         return failResult("manual-validation", task.message);
-    const log = getSectionContent(task.content, ["活动日志", "Activity Log"]);
-    const completed = new RegExp(`\\*\\*Complete Manual Validation\\*\\*[\\s\\S]*?Manual validation passed → ${escapeRegExp(artifactName)};`);
-    if (!completed.test(log)) {
-        return failResult("manual-validation", `Manual validation artifact exists but completion is not recorded for ${artifactName}: re-run /complete-manual-validation`);
+    const completion = readManualValidationCompletion(taskDir, {
+        taskId: task.metadata.id,
+        artifact: artifactName
+    });
+    if (!completion.ok) {
+        const source = completion.error.code.startsWith('MANUAL_VALIDATION_RECEIPT_') ? 'receipt' : 'transaction';
+        return failResult("manual-validation", `Manual validation ${source} is unavailable: ${completion.error.message}`);
+    }
+    const { receipt, transaction } = completion.value;
+    if (transaction.phase !== "committed" || !transaction.eventAppended || !transaction.postWriteVerified) {
+        return failResult("manual-validation", "Manual validation transaction has not reached the committed post-write-verified state");
+    }
+    if (transaction.pendingSummaryDigest !== receipt.pendingSummaryDigest || transaction.finalSummaryDigest !== receipt.finalSummaryDigest) {
+        return failResult("manual-validation", "Manual validation summary digests do not match the committed receipt");
+    }
+    if (sha256File(resolved.path) !== receipt.artifactSha256) {
+        return failResult("manual-validation", `Manual validation artifact digest does not match the receipt for ${artifactName}`);
     }
     // 6. Timing correlation (PL-3 fix, PL-4 corrected): the completion entry must
     //    sit AFTER the latest review-code round's completion entry in the
@@ -1007,21 +810,39 @@ function checkManualValidation({ taskDir }) {
     //    which indexOf never matches). Not reusing completed.exec().index: exec
     //    anchors to the first '**Complete Manual Validation**' heading, which can
     //    belong to an earlier round's entry and misorder the standard path.
-    const reviewDoneIndex = log.indexOf(`**Review Code (Round ${review.round})** by `);
-    const completedIndex = log.indexOf(`Manual validation passed → ${artifactName};`);
-    if (reviewDoneIndex === -1) {
-        // The latest review-code round's completion entry is missing entirely (abnormal
-        // state, e.g. a restored/historical task without a review-code.completed record).
-        // Re-running complete-manual-validation cannot restore it, so the remediation
-        // targets the review record itself. Fail closed either way.
-        return failResult("manual-validation", `Latest review-code (round ${review.round}) completion entry is missing from the Activity Log (abnormal state): re-run review-code or restore the completion record`);
-    }
-    if (completedIndex < reviewDoneIndex) {
-        return failResult("manual-validation", `Latest review-code (round ${review.round}) came after the manual validation completion recorded for ${artifactName}: re-run /complete-manual-validation to cover new pending items`);
-    }
-    return passResult("manual-validation", `Manual validation completed → ${artifactName}`);
+    const inspectedLog = inspectActivityLog(task.content);
+    if (!inspectedLog.section)
+        return failResult("manual-validation", "Activity Log is missing or invalid");
+    const reviewDoneIndex = inspectedLog.section.entries.findIndex((entry) => entry.step === `Review Code (Round ${review.round})`);
+    const completedIndex = inspectedLog.section.entries.findIndex((entry) => entry.step === "Complete Manual Validation"
+        && entry.note.includes(`Manual validation passed → ${artifactName};`)
+        && entry.note.includes(`transaction=${receipt.transactionId};`)
+        && entry.note.includes(`receipt=${receipt.receiptDigest};`)
+        && entry.note.includes(`head=${receipt.prHeadSha}`));
+    if (reviewDoneIndex === -1)
+        return failResult("manual-validation", `Latest review-code (round ${review.round}) completion entry is missing from the Activity Log`);
+    if (completedIndex === -1)
+        return failResult("manual-validation", `Committed manual validation completion is not recorded for ${artifactName}`);
+    if (completedIndex < reviewDoneIndex)
+        return failResult("manual-validation", `Latest review-code (round ${review.round}) came after the manual validation completion recorded for ${artifactName}`);
+    const fact = readPrDeliveryFact(task.metadata);
+    if (fact.status === "invalid")
+        return failResult("manual-validation", fact.error.message);
+    if (fact.status === "valid" && fact.fact.state === "bound") {
+        const inspected = await inspectPlatformPullRequest(task.metadata.id, { cwd: repositoryRoot });
+        if (!inspected.pullRequest)
+            return failResult("manual-validation", inspected.error?.message ?? "canonical pull-request head is unavailable");
+        if (inspected.pullRequest.head.sha !== receipt.prHeadSha)
+            return failResult("manual-validation", "manual validation receipt is stale for the current pull-request head");
+        const summary = await summaryCommentState(task.metadata.id, { cwd: repositoryRoot });
+        if (!summary.comment)
+            return failResult("manual-validation", "canonical pull-request summary comment is unavailable");
+        if (!manualValidationFinalSummaryProjectionMatches(summary.comment.body, receipt))
+            return failResult("manual-validation", "canonical pull-request summary does not match the committed manual validation projection");
+    }
+    return passResult("manual-validation", `Manual validation completed → ${artifactName} (committed receipt and post-write verification)`);
 }
-async function checkPostReviewCommit({ taskDir, config }) {
+async function checkPostReviewCommit({ taskDir, config, repositoryRoot }) {
     const reviewArtifact = findAuthoritativeReviewCodeArtifact(taskDir);
     if (!reviewArtifact.ok) {
         if (reviewArtifact.error)
@@ -1043,7 +864,7 @@ async function checkPostReviewCommit({ taskDir, config }) {
         return failResult("post-review-commit", factRead.error.message);
     const fact = factRead.status === 'valid' ? factRead.fact : null;
     const lastReviewedCommit = task.ok ? (task.metadata.last_reviewed_commit || "").trim() : "";
-    const globs = resolvePostReviewGlobs(config, loadPostReviewConfig(repoRoot));
+    const globs = resolvePostReviewGlobs(config, loadPostReviewConfig(repositoryRoot));
     const hasPullRequest = fact?.state === 'bound';
     let inspected = null;
     if (hasPullRequest) {
@@ -1189,7 +1010,7 @@ function resolvePostReviewExemption(content) {
         };
     }
 }
-function checkReviewFact({ taskDir, artifactFile }) {
+function checkReviewFact({ taskDir, artifactFile, repositoryRoot }) {
     const resolvedArtifact = resolveArtifactPath(taskDir, "review-code.md|review-code-r{N}.md", artifactFile);
     if (!resolvedArtifact.ok) {
         return failResult("review-fact", resolvedArtifact.message);
@@ -1255,7 +1076,7 @@ function checkReviewFact({ taskDir, artifactFile }) {
             mode: "worktree",
             baseline,
             diffBase,
-            globs: resolvePostReviewGlobs({}, loadPostReviewConfig(repoRoot))
+            globs: resolvePostReviewGlobs({}, loadPostReviewConfig(repositoryRoot))
         });
     }
     catch {
@@ -1342,40 +1163,12 @@ function resolveArtifactPath(taskDir, filePattern, artifactFile) {
     return { ok: true, path: path.join(taskDir, matches[0].fileName) };
 }
 function getSectionContent(content, names) {
-    const lines = content.split(/\r?\n/);
-    function visibleHeadings() {
-        const headings = [];
-        let fence = null;
-        for (let index = 0; index < lines.length; index += 1) {
-            const line = lines[index];
-            if (fence) {
-                const closer = line.match(/^ {0,3}(`+|~+)\s*$/);
-                if (closer && closer[1][0] === fence.character && closer[1].length >= fence.length) {
-                    fence = null;
-                }
-                continue;
-            }
-            const opener = line.match(/^ {0,3}(`{3,}|~{3,})(?:[^`~].*)?$/);
-            if (opener) {
-                fence = { character: opener[1][0], length: opener[1].length };
-                continue;
-            }
-            if (line.startsWith("## ")) {
-                headings.push({ index, text: line.trim() });
-            }
-        }
-        return headings;
-    }
-    const headings = visibleHeadings();
+    const headings = scanVisibleMarkdown(content).headings.filter((heading) => heading.level === 2);
     for (const name of names) {
-        const heading = `## ${name}`;
-        const position = headings.findIndex((item) => item.text === heading);
-        if (position === -1) {
+        const position = headings.findIndex((heading) => heading.text === name);
+        if (position === -1)
             continue;
-        }
-        const startIndex = headings[position].index;
-        const endIndex = headings[position + 1]?.index ?? lines.length;
-        return lines.slice(startIndex + 1, endIndex).join("\n").trim();
+        return content.slice(headings[position].end + 1, headings[position + 1]?.start ?? content.length).replace(/\r\n/g, "\n").trim();
     }
     return "";
 }
@@ -1391,16 +1184,6 @@ function getCheckedRequirements(content) {
         .filter(Boolean)
         .map((match) => match[1].trim());
 }
-function parseIssueNumber(value) {
-    if (isBlank(value) || value === "N/A") {
-        return null;
-    }
-    const match = String(value).match(/\d+/);
-    return match ? Number(match[0]) : null;
-}
-function parsePrNumber(value) {
-    return parseIssueNumber(value);
-}
 // === Utilities ===
 function normalizeContent(text) {
     return String(text || "")
@@ -1479,9 +1262,8 @@ function isBlank(value) {
     return value === undefined || value === null || String(value).trim() === "";
 }
 async function verifyInProcess({ mode, skillName, taskDir, artifactFile, checks: requestedChecks, repositoryRoot }) {
-    if (repositoryRoot)
-        repoRoot = path.resolve(repositoryRoot);
-    else {
+    let repoRoot = repositoryRoot ? path.resolve(repositoryRoot) : defaultRepoRoot;
+    if (!repositoryRoot) {
         let cursor = path.resolve(taskDir);
         while (path.dirname(cursor) !== cursor && !fs.existsSync(path.join(cursor, ".agents")))
             cursor = path.dirname(cursor);