@fitlab-ai/agent-infra 0.9.0 → 0.9.2

package/lib/task/verification-engine.ts

@@ -7,16 +7,23 @@ import { fileURLToPath } from "node:url";
 
 import {
   extractReviewBaseline,
+  extractReviewDiffBase,
   extractReviewDiffFingerprint,
   extractReviewedSnapshotTree,
   findAuthoritativeReviewCodeArtifact,
+  loadPostReviewConfig,
   parseReviewVerdict,
   resolvePostReviewGlobs
 } from "./verification-review.ts";
 import { check as checkPlatformSync } from "../platform/verification-sync.ts";
 import { check as checkRequiredChecks } from "../platform/verification-required.ts";
+import { inspectPlatformPullRequest } from "../platform/pull-requests.ts";
+import { resolveMaterializedReviewedHeadRelation } from "../platform/change-request-git-evidence.ts";
+import { resolveReviewedHeadRelation } from "../platform/merged-pr-equivalence.ts";
+import { resolveLocalReviewedCommitRelation } from "../git/reviewed-commit-equivalence.ts";
 import { parseTypedTaskFrontmatter } from "./frontmatter.ts";
-import { parseLedger } from "./ledger.ts";
+import { parseLedger, summarizeLedgerStage, validateLedgerRows } from "./ledger.ts";
+import { equalCounts, parseReviewSummary } from "./review-artifacts.ts";
 import { loadVerificationConfig } from "./verification-config.ts";
 import { snapshotReview } from "../git/review-snapshot.ts";
 
@@ -107,10 +114,14 @@ function runCheck(type: any, context: any, shared: any): any {
       return checkCompletionChecklist(context);
     case "review-ledger":
       return checkReviewLedger(context);
+    case "review-summary":
+      return checkReviewSummary(context);
     case "review-fact":
       return checkReviewFact(context);
     case "post-review-commit":
       return checkPostReviewCommit(context);
+    case "orchestration-state":
+      return checkOrchestrationState(context);
     default: {
       const adapter = PLATFORM_ADAPTERS[type];
       if (!adapter) {
@@ -126,6 +137,32 @@ function runCheck(type: any, context: any, shared: any): any {
   }
 }
 
+function checkOrchestrationState({ taskDir }: any): any {
+  const file = path.join(taskDir, 'orchestration.json');
+  const stat = safeStat(file);
+  if (!stat?.isFile()) return failResult('orchestration-state', 'orchestration.json is missing');
+  let run: any;
+  try {
+    run = JSON.parse(fs.readFileSync(file, 'utf8'));
+  } catch (error) {
+    return failResult('orchestration-state', `Invalid orchestration.json: ${String(error)}`);
+  }
+  if (run.schemaVersion !== 1 || !['paused', 'completed'].includes(run.status)) {
+    return failResult('orchestration-state', `Expected paused or completed run, received '${run.status}'`);
+  }
+  if (run.status === 'paused' && (!run.pause?.code || !run.pause?.message)) {
+    return failResult('orchestration-state', 'Paused run requires a stable pause code and message');
+  }
+  if (run.status === 'completed') {
+    if (run.pendingDelegation !== null || !run.commitAuthorization?.consumedAt) {
+      return failResult('orchestration-state', 'Completed run must consume commit authorization and clear pending delegation');
+    }
+  } else if (run.pendingDelegation?.status === 'sealed') {
+    return failResult('orchestration-state', 'Paused run has a sealed delegation that could still advance');
+  }
+  return passResult('orchestration-state', `Orchestration run is safely ${run.status}`);
+}
+
 // === Check Functions ===
 
 function checkTaskMeta({ taskDir, config }: any): any {
@@ -268,20 +305,6 @@ function loadProjectName(): any {
   }
 }
 
-function loadReviewConfig(): any {
-  const configPath = path.join(repoRoot, ".agents", ".airc.json");
-  if (!fs.existsSync(configPath)) {
-    return {};
-  }
-
-  try {
-    const config = JSON.parse(fs.readFileSync(configPath, "utf8"));
-    return config.review && typeof config.review === "object" ? config.review : {};
-  } catch {
-    return {};
-  }
-}
-
 function checkArtifact({ taskDir, config, artifactFile }: any): any {
   const resolvedArtifact = resolveArtifactPath(taskDir, config.file_pattern, artifactFile);
   if (!resolvedArtifact.ok) {
@@ -324,6 +347,43 @@ function checkArtifact({ taskDir, config, artifactFile }: any): any {
   );
 }
 
+function checkReviewSummary({ taskDir, config, artifactFile }: any): any {
+  const stage = String(config.stage || "");
+  if (!["analysis", "plan", "code"].includes(stage)) {
+    return failResult("review-summary", `Invalid review stage '${stage}'`);
+  }
+  const resolvedArtifact = resolveArtifactPath(taskDir, "", artifactFile);
+  if (!resolvedArtifact.ok || !safeStat(resolvedArtifact.path)?.isFile()) {
+    return failResult("review-summary", resolvedArtifact.message || "Review artifact is missing");
+  }
+  const parsed = parseReviewSummary(fs.readFileSync(resolvedArtifact.path, "utf8"));
+  if (!parsed.ok) return failResult("review-summary", `${parsed.code}: ${parsed.message}`);
+  if (!parsed.summary.counts) {
+    return failResult("review-summary", "Review summary finding counts are not finalized");
+  }
+  const task = loadTask(taskDir);
+  if (!task.ok) return failResult("review-summary", task.message);
+  let rows;
+  try {
+    rows = parseLedger(task.content);
+  } catch (error) {
+    return failResult("review-summary", `Invalid disagreement ledger: ${String(error)}`);
+  }
+  const invalid = validateLedgerRows(rows);
+  if (invalid) return failResult("review-summary", `${invalid.code}: ${invalid.message}`);
+  const expected = summarizeLedgerStage(rows, stage as "analysis" | "plan" | "code").unresolvedFindingCounts;
+  if (!equalCounts(parsed.summary.counts, expected)) {
+    return failResult(
+      "review-summary",
+      `Review summary counts ${JSON.stringify(parsed.summary.counts)} do not match ledger ${JSON.stringify(expected)}`
+    );
+  }
+  return passResult(
+    "review-summary",
+    `${path.basename(resolvedArtifact.path)} finding counts match the ${stage} ledger`
+  );
+}
+
 function checkImplementationInput({ taskDir, artifactFile }: any): any {
   const task = loadTask(taskDir);
   if (!task.ok) return failResult("implementation-input", task.message);
@@ -598,7 +658,7 @@ function resolveReviewSetting(config: any, key: any, fallback: any): any {
   if (config && config[key] !== undefined && config[key] !== null) {
     return config[key];
   }
-  const reviewConfig = loadReviewConfig();
+  const reviewConfig = loadPostReviewConfig(repoRoot);
   if (reviewConfig[key] !== undefined && reviewConfig[key] !== null) {
     return reviewConfig[key];
   }
@@ -694,8 +754,51 @@ function checkPostReviewCommit({ taskDir, config }: any): any {
   }
 
   const task = loadTask(taskDir);
-  const content = fs.readFileSync(reviewArtifact.path!, "utf8");
+  if (!task.ok) return failResult("post-review-commit", task.message);
   const lastReviewedCommit = task.ok ? (task.metadata.last_reviewed_commit || "").trim() : "";
+  const globs = resolvePostReviewGlobs(config, loadPostReviewConfig(repoRoot));
+  const hasPullRequest = Number(task.metadata.pr_number) > 0;
+  let inspected: ReturnType<typeof inspectPlatformPullRequest> | null = null;
+  if (hasPullRequest) {
+    inspected = inspectPlatformPullRequest(task.metadata.id, { cwd: gitRoot });
+    if (!inspected.pullRequest) {
+      const message = inspected.error?.message || "PR merge snapshot is unavailable";
+      const code = inspected.error?.code || "PR_INSPECTION_INVALID";
+      return inspected.status === "blocked"
+        ? blockedResult("post-review-commit", message, code)
+        : failResult("post-review-commit", message, code);
+    }
+    if (
+      inspected.pullRequest.state === "closed" &&
+      inspected.pullRequest.mergedAt &&
+      inspected.pullRequest.mergeCommitSha
+    ) {
+      const relation = resolveMaterializedReviewedHeadRelation({
+        cwd: gitRoot,
+        platformType: inspected.platform.type,
+        lastReviewedCommit,
+        pullRequest: inspected.pullRequest
+      });
+      if (relation.status === "merged-equivalent") {
+        return passResult(
+          "post-review-commit",
+          `Reviewed PR head is content-equivalent to squash merge ${relation.mergeCommit.slice(0, 8)} on target ${relation.comparisonHead.slice(0, 8)}`
+        );
+      }
+      if (relation.status === "blocked") {
+        return blockedResult("post-review-commit", relation.message, relation.code);
+      }
+      if (relation.status === "strict") {
+        return failResult(
+          "post-review-commit",
+          "Merged PR evidence did not establish squash merge equivalence",
+          "PR_MERGE_IDENTITY_INVALID"
+        );
+      }
+      return failResult("post-review-commit", relation.message, relation.code);
+    }
+  }
+
   const baselineSource = resolvePostReviewBaseline({
     gitRoot,
     lastReviewedCommit,
@@ -706,7 +809,6 @@ function checkPostReviewCommit({ taskDir, config }: any): any {
   }
 
   const sha = baselineSource.sha;
-  const globs = resolvePostReviewGlobs(config, loadReviewConfig());
   let commits;
   try {
     const out = execFileSync("git", ["-C", gitRoot, "rev-list", `${sha}..HEAD`, "--", ...globs], { encoding: "utf8" });
@@ -719,15 +821,50 @@ function checkPostReviewCommit({ taskDir, config }: any): any {
     return passResult("post-review-commit", `No post-review commits to code/rule paths since ${sha.slice(0, 8)}`);
   }
 
-  let exempt = false;
+  let localHead = "";
   try {
-    exempt = task.ok && parseLedger(task.content).some(
-      (row) => row.stage === POST_REVIEW_COMMIT_STAGE && row.status === "human-decided"
-    );
+    localHead = execFileSync("git", ["-C", gitRoot, "rev-parse", "HEAD"], { encoding: "utf8" }).trim();
   } catch {
-    return failResult("post-review-commit", "Invalid disagreement ledger");
+    return blockedResult("post-review-commit", "Unable to resolve the local HEAD");
   }
-  if (exempt) {
+
+  if (hasPullRequest) {
+    if (inspected?.pullRequest) {
+      const relation = resolveReviewedHeadRelation({
+        gitRoot,
+        comparisonHead: localHead,
+        lastReviewedCommit: sha,
+        pullRequest: inspected.pullRequest
+      });
+      if (relation.status === "merged-equivalent") {
+        return passResult("post-review-commit", `Reviewed PR head is content-equivalent to squash merge ${relation.mergeCommit.slice(0, 8)}`);
+      }
+      if (relation.status === "blocked") {
+        return blockedResult("post-review-commit", relation.message, relation.code);
+      }
+    }
+  } else if (commits.length === 1) {
+    const relation = resolveLocalReviewedCommitRelation({
+      gitRoot,
+      localHead,
+      lastReviewedCommit: sha,
+      rewrittenCommit: commits[0]!,
+      pathspecs: globs
+    });
+    if (relation.status === "local-equivalent") {
+      return passResult(
+        "post-review-commit",
+        `Reviewed commit is content-equivalent to local rewrite ${relation.rewrittenCommit.slice(0, 8)}`
+      );
+    }
+    if (relation.status === "blocked") {
+      return blockedResult("post-review-commit", relation.message);
+    }
+  }
+
+  const exemption = resolvePostReviewExemption(task.content);
+  if (!exemption.ok) return failResult("post-review-commit", exemption.message);
+  if (exemption.exempt) {
     return passResult(
       "post-review-commit",
       `${commits.length} post-review commit(s) covered by a human-decided exemption`
@@ -740,6 +877,21 @@ function checkPostReviewCommit({ taskDir, config }: any): any {
   );
 }
 
+function resolvePostReviewExemption(content: string):
+  | { ok: true; exempt: boolean }
+  | { ok: false; message: string } {
+  try {
+    return {
+      ok: true,
+      exempt: parseLedger(content).some(
+        (row) => row.stage === POST_REVIEW_COMMIT_STAGE && row.status === "human-decided"
+      )
+    };
+  } catch {
+    return { ok: false, message: "Invalid disagreement ledger" };
+  }
+}
+
 function checkReviewFact({ taskDir, artifactFile }: any): any {
   const resolvedArtifact = resolveArtifactPath(
     taskDir,
@@ -758,6 +910,7 @@ function checkReviewFact({ taskDir, artifactFile }: any): any {
   const content = fs.readFileSync(resolvedArtifact.path, "utf8");
   const verdict = parseReviewVerdict(content);
   const reviewBaseline = extractReviewBaseline(content);
+  const reviewDiffBase = extractReviewDiffBase(content);
   const reviewedFingerprint = extractReviewDiffFingerprint(content);
   const reviewedTree = extractReviewedSnapshotTree(content);
 
@@ -768,10 +921,16 @@ function checkReviewFact({ taskDir, artifactFile }: any): any {
   let gitRoot;
   let head;
   let baseline;
+  let diffBase;
   try {
     gitRoot = execFileSync("git", ["-C", taskDir, "rev-parse", "--show-toplevel"], { encoding: "utf8" }).trim();
     head = execFileSync("git", ["-C", gitRoot, "rev-parse", "HEAD"], { encoding: "utf8" }).trim();
     baseline = execFileSync("git", ["-C", gitRoot, "rev-parse", `${reviewBaseline}^{commit}`], { encoding: "utf8" }).trim();
+    diffBase = execFileSync(
+      "git",
+      ["-C", gitRoot, "rev-parse", `${reviewDiffBase || reviewBaseline}^{commit}`],
+      { encoding: "utf8" }
+    ).trim();
   } catch {
     return blockedResult(
       "review-fact",
@@ -788,7 +947,13 @@ function checkReviewFact({ taskDir, artifactFile }: any): any {
 
   let actualSnapshot;
   try {
-    actualSnapshot = snapshotReview({ cwd: gitRoot, mode: "worktree", baseline, globs: resolvePostReviewGlobs({}, loadReviewConfig()) });
+    actualSnapshot = snapshotReview({
+      cwd: gitRoot,
+      mode: "worktree",
+      baseline,
+      diffBase,
+      globs: resolvePostReviewGlobs({}, loadPostReviewConfig(repoRoot))
+    });
   } catch {
     return blockedResult(
       "review-fact",

package/lib/task/verification-review.ts

@@ -1,8 +1,10 @@
 export {
   extractReviewBaseline,
+  extractReviewDiffBase,
   extractReviewDiffFingerprint,
   extractReviewedSnapshotTree,
   findAuthoritativeReviewCodeArtifact,
+  loadPostReviewConfig,
   parseReviewVerdict,
   resolvePostReviewGlobs
 } from './review-fingerprint.ts';

package/lib/task/verification.ts

@@ -16,7 +16,8 @@ type VerificationEvent =
   | 'complete-task.preflight' | 'complete-task.completed'
   | 'create-pr.completed' | 'create-task.completed'
   | 'import-codescan.completed' | 'import-dependabot.completed'
-  | 'import-issue.completed' | 'watch-pr.completed';
+  | 'import-issue.completed' | 'watch-pr.completed'
+  | 'run-task.paused' | 'run-task.completed';
 type VerificationSpec = {
   skill: string;
   expectedState: 'active' | 'blocked' | 'completed';
@@ -63,14 +64,16 @@ const VERIFICATION_CATALOG: Readonly<Record<VerificationEvent, VerificationSpec>
   'block-task.completed': gate('block-task', 'blocked'),
   'cancel-task.completed': gate('cancel-task', 'completed'),
   'commit.completed': gate('commit', 'active'),
-  'complete-task.preflight': { skill: 'complete-task', expectedState: 'active', mode: 'checks', checks: ['review-ledger', 'post-review-commit', 'required-checks', 'platform-sync-preflight'] },
+  'complete-task.preflight': { skill: 'complete-task', expectedState: 'active', mode: 'checks', checks: ['review-ledger', 'post-review-commit', 'platform-sync-preflight'] },
   'complete-task.completed': gate('complete-task', 'completed'),
   'create-pr.completed': gate('create-pr', 'active'),
   'create-task.completed': gate('create-task', 'active'),
   'import-codescan.completed': gate('import-codescan', 'active'),
   'import-dependabot.completed': gate('import-dependabot', 'active'),
   'import-issue.completed': gate('import-issue', 'active'),
-  'watch-pr.completed': gate('watch-pr', 'active')
+  'watch-pr.completed': gate('watch-pr', 'active'),
+  'run-task.paused': { skill: 'run-task', expectedState: 'active', mode: 'checks', checks: ['orchestration-state'] },
+  'run-task.completed': { skill: 'run-task', expectedState: 'active', mode: 'checks', checks: ['orchestration-state'] }
 };
 
 function failure(request: { taskRef: string; event: string; artifact?: string }, code: string, message: string, extra: Partial<TaskVerificationResult> = {}): TaskVerificationResult {

package/lib/task/workspace-snapshot.ts

@@ -0,0 +1,36 @@
+import fs from 'node:fs';
+import os from 'node:os';
+import path from 'node:path';
+import { spawnSync } from 'node:child_process';
+
+function git(repoRoot: string, indexFile: string | null, args: string[]): string {
+  const env = indexFile ? { ...process.env, GIT_INDEX_FILE: indexFile } : process.env;
+  const result = spawnSync('git', args, { cwd: repoRoot, env, encoding: 'utf8' });
+  if (result.status !== 0) {
+    throw new Error(String(result.stderr || result.stdout || `git ${args[0]} failed`).trim());
+  }
+  return result.stdout;
+}
+
+function captureWorkspaceSnapshot(repoRoot: string): string {
+  const tempDir = fs.mkdtempSync(path.join(os.tmpdir(), 'agent-infra-orchestration-index-'));
+  const indexFile = path.join(tempDir, 'index');
+  try {
+    git(repoRoot, indexFile, ['read-tree', 'HEAD']);
+    git(repoRoot, indexFile, ['add', '-A', '--', ':/']);
+    const workspace = path.join(repoRoot, '.agents', 'workspace', 'active');
+    if (fs.existsSync(workspace)) {
+      git(repoRoot, indexFile, ['add', '-f', '--', '.agents/workspace/active']);
+    }
+    return git(repoRoot, indexFile, ['write-tree']).trim();
+  } finally {
+    fs.rmSync(tempDir, { recursive: true, force: true });
+  }
+}
+
+function diffWorkspaceSnapshots(repoRoot: string, before: string, after: string): string[] {
+  const output = git(repoRoot, null, ['diff', '--name-only', '-z', before, after]);
+  return output.split('\0').filter(Boolean);
+}
+
+export { captureWorkspaceSnapshot, diffWorkspaceSnapshots };