@fitlab-ai/agent-infra 0.4.0 → 0.4.1

package/templates/.agents/skills/review-task/reference/output-templates.md

@@ -0,0 +1,72 @@
+# Review Output Templates
+
+Read this file before presenting the final review result to the user.
+
+## Choose Exactly One Output Branch
+
+Apply these rules in order:
+1. if `Blocker = 0` and `Major = 0` and `Minor = 0`, use Branch A
+2. if `Blocker = 0` and (`Major > 0` or `Minor > 0`), use Branch B
+3. if `Blocker > 0` and the work can be repaired in a focused refinement pass, use Branch C
+4. if the task requires major redesign, broad reimplementation, or a restart, use Branch D
+
+Prohibitions:
+- never skip the branch-selection step
+- never mix text from different branches
+- if `Blocker > 0`, never output an approval template
+- always include every TUI command format in the selected branch
+
+### Branch A: Approved with No Findings
+
+```text
+Task {task-id} review completed. Verdict: approved.
+- Blockers: 0 | Major: 0 | Minor: 0
+
+Next step - commit the code:
+  - Claude Code / OpenCode: /commit
+  - Gemini CLI: /agent-infra:commit
+  - Codex CLI: $commit
+```
+
+### Branch B: Approved with Findings
+
+```text
+Task {task-id} review completed. Verdict: approved.
+- Blockers: 0 | Major: {n} | Minor: {n}
+- Review report: .agents/workspace/active/{task-id}/{review-artifact}
+
+Next step - refine before commit (recommended):
+  - Claude Code / OpenCode: /refine-task {task-id}
+  - Gemini CLI: /agent-infra:refine-task {task-id}
+  - Codex CLI: $refine-task {task-id}
+
+Or commit directly (skip refinement):
+  - Claude Code / OpenCode: /commit
+  - Gemini CLI: /agent-infra:commit
+  - Codex CLI: $commit
+```
+
+### Branch C: Changes Requested
+
+```text
+Task {task-id} review completed. Verdict: changes requested.
+- Blockers: {n} | Major: {n} | Minor: {n}
+- Review report: .agents/workspace/active/{task-id}/{review-artifact}
+
+Next step - fix the findings:
+  - Claude Code / OpenCode: /refine-task {task-id}
+  - Gemini CLI: /agent-infra:refine-task {task-id}
+  - Codex CLI: $refine-task {task-id}
+```
+
+### Branch D: Rejected
+
+```text
+Task {task-id} review completed. Verdict: rejected, major rework required.
+- Review report: .agents/workspace/active/{task-id}/{review-artifact}
+
+Next step - re-implement:
+  - Claude Code / OpenCode: /implement-task {task-id}
+  - Gemini CLI: /agent-infra:implement-task {task-id}
+  - Codex CLI: $implement-task {task-id}
+```

package/templates/.agents/skills/review-task/reference/output-templates.zh-CN.md

@@ -0,0 +1,72 @@
+# 审查输出模板
+
+在向用户汇报最终审查结论之前先读取本文件。
+
+## 选择唯一输出场景
+
+按以下顺序判断：
+1. 如果 `Blocker = 0` 且 `Major = 0` 且 `Minor = 0`，使用场景 A
+2. 如果 `Blocker = 0` 且（`Major > 0` 或 `Minor > 0`），使用场景 B
+3. 如果 `Blocker > 0`，且问题可以通过一次聚焦修复解决，使用场景 C
+4. 如果任务需要重大重构、大范围重写或整体重来，使用场景 D
+
+禁止规则：
+- 不要跳过场景判断步骤
+- 不要混用不同场景的文案
+- 只要 `Blocker > 0`，就绝对不能输出通过模板
+- 所选场景中必须包含所有 TUI 命令格式
+
+### 场景 A：通过且无问题
+
+```text
+任务 {task-id} 代码审查完成。结论：通过。
+- 阻塞项：0 | 主要问题：0 | 次要问题：0
+
+下一步 - 提交代码：
+  - Claude Code / OpenCode：/commit
+  - Gemini CLI：/agent-infra:commit
+  - Codex CLI：$commit
+```
+
+### 场景 B：通过但有问题
+
+```text
+任务 {task-id} 代码审查完成。结论：通过。
+- 阻塞项：0 | 主要问题：{n} | 次要问题：{n}
+- 审查报告：.agents/workspace/active/{task-id}/{review-artifact}
+
+下一步 - 修复问题后提交（推荐）：
+  - Claude Code / OpenCode：/refine-task {task-id}
+  - Gemini CLI：/agent-infra:refine-task {task-id}
+  - Codex CLI：$refine-task {task-id}
+
+或直接提交（跳过修复）：
+  - Claude Code / OpenCode：/commit
+  - Gemini CLI：/agent-infra:commit
+  - Codex CLI：$commit
+```
+
+### 场景 C：需要修改
+
+```text
+任务 {task-id} 代码审查完成。结论：需要修改。
+- 阻塞项：{n} | 主要问题：{n} | 次要问题：{n}
+- 审查报告：.agents/workspace/active/{task-id}/{review-artifact}
+
+下一步 - 修复问题：
+  - Claude Code / OpenCode：/refine-task {task-id}
+  - Gemini CLI：/agent-infra:refine-task {task-id}
+  - Codex CLI：$refine-task {task-id}
+```
+
+### 场景 D：拒绝
+
+```text
+任务 {task-id} 代码审查完成。结论：拒绝，需要重大返工。
+- 审查报告：.agents/workspace/active/{task-id}/{review-artifact}
+
+下一步 - 重新实现：
+  - Claude Code / OpenCode：/implement-task {task-id}
+  - Gemini CLI：/agent-infra:implement-task {task-id}
+  - Codex CLI：$implement-task {task-id}
+```

package/templates/.agents/skills/review-task/reference/report-template.md

@@ -0,0 +1,63 @@
+# Review Report Template
+
+Use this template when writing `review.md` or `review-r{N}.md`.
+
+## Output Template
+
+```markdown
+# Code Review Report
+
+- **Review Round**: Round {review-round}
+- **Artifact File**: `{review-artifact}`
+- **Implementation Input**:
+  - `{implementation-artifact}`
+  - `{refinement-artifact}` (if present)
+
+## Review Summary
+
+- **Reviewer**: {reviewer-name}
+- **Review Time**: {timestamp}
+- **Scope**: {file-count and major modules}
+- **Overall Verdict**: {Approved / Changes Requested / Rejected}
+
+## Findings
+
+### Blockers (must fix)
+
+#### 1. {Issue title}
+**File**: `{file-path}:{line-number}`
+**Description**: {details}
+**Suggested Fix**: {fix suggestion}
+
+### Major Issues (should fix)
+
+#### 1. {Issue title}
+**File**: `{file-path}:{line-number}`
+**Description**: {details}
+**Suggested Fix**: {fix suggestion}
+
+### Minor Issues (optional improvements)
+
+#### 1. {Improvement point}
+**File**: `{file-path}:{line-number}`
+**Suggestion**: {improvement suggestion}
+
+## Highlights
+
+- {what went well}
+
+## Alignment with Plan
+
+- [ ] Implementation matches the technical plan
+- [ ] No unintended scope expansion
+
+## Conclusion and Recommendation
+
+### Approval Decision
+- [ ] Approved
+- [ ] Changes Requested
+- [ ] Rejected
+
+### Next Steps
+{recommended next step}
+```

package/templates/.agents/skills/review-task/reference/report-template.zh-CN.md

@@ -0,0 +1,63 @@
+# 审查报告模板
+
+编写 `review.md` 或 `review-r{N}.md` 时使用本模板。
+
+## 输出模板
+
+```markdown
+# 代码审查报告
+
+- **审查轮次**：第 {review-round} 轮
+- **产物文件**：`{review-artifact}`
+- **审查输入**：
+  - `{implementation-artifact}`
+  - `{refinement-artifact}`（如存在）
+
+## 审查摘要
+
+- **审查者**：{reviewer-name}
+- **审查时间**：{timestamp}
+- **审查范围**：{file-count and major modules}
+- **总体结论**：{通过 / 需要修改 / 拒绝}
+
+## 问题清单
+
+### 阻塞项（必须修复）
+
+#### 1. {问题标题}
+**文件**：`{file-path}:{line-number}`
+**说明**：{details}
+**修复建议**：{fix suggestion}
+
+### 主要问题（建议修复）
+
+#### 1. {问题标题}
+**文件**：`{file-path}:{line-number}`
+**说明**：{details}
+**修复建议**：{fix suggestion}
+
+### 次要问题（可选改进）
+
+#### 1. {改进点}
+**文件**：`{file-path}:{line-number}`
+**建议**：{improvement suggestion}
+
+## 亮点
+
+- {what went well}
+
+## 与方案一致性
+
+- [ ] 实现与技术方案一致
+- [ ] 没有意外的范围扩张
+
+## 结论与建议
+
+### 审查决定
+- [ ] 通过
+- [ ] 需要修改
+- [ ] 拒绝
+
+### 下一步
+{recommended next step}
+```

package/templates/.agents/skills/review-task/reference/review-criteria.md

@@ -0,0 +1,24 @@
+# Review Criteria
+
+Read this file before reviewing code or classifying findings.
+
+## Perform Code Review
+
+Follow the `code-review` step in `.agents/workflows/feature-development.yaml`.
+
+**Required review areas**:
+- [ ] code quality and coding standards
+- [ ] bug and risk detection
+- [ ] test coverage and test quality
+- [ ] error handling and edge cases
+- [ ] performance and security concerns
+- [ ] code comments and documentation
+- [ ] alignment with the technical plan
+
+**Review principles**:
+1. **Strict but fair**: point out problems and also acknowledge good work
+2. **Specific**: cite exact file paths and line numbers
+3. **Actionable**: suggest a concrete fix
+4. **Severity-based**: distinguish blockers, major issues, and minor improvements
+
+Also inspect `git diff` so the report reflects the full change context.

package/templates/.agents/skills/review-task/reference/review-criteria.zh-CN.md

@@ -0,0 +1,24 @@
+# 审查标准
+
+在审查代码或划分问题严重程度之前先读取本文件。
+
+## 执行代码审查
+
+遵循 `.agents/workflows/feature-development.yaml` 中的 `code-review` 步骤。
+
+**必查范围**：
+- [ ] 代码质量和编码规范
+- [ ] bug 与风险识别
+- [ ] 测试覆盖率和测试质量
+- [ ] 错误处理和边界情况
+- [ ] 性能与安全风险
+- [ ] 代码注释和文档
+- [ ] 与技术方案的一致性
+
+**审查原则**：
+1. **严格但公正**：既要指出问题，也要承认做得好的部分
+2. **具体**：引用准确的文件路径和行号
+3. **可执行**：给出明确可落地的修复建议
+4. **按严重程度分类**：明确区分 blocker、major 和 minor
+
+同时检查 `git diff`，确保报告反映完整的变更上下文。