@fitlab-ai/agent-infra 0.3.2 → 0.4.1

package/templates/.agents/skills/release/SKILL.zh-CN.md

@@ -1,7 +1,6 @@
 ---
 name: release
-description: >
-  执行版本发布流程。当用户要求发布版本时触发。参数：版本号（X.Y.Z）。
+description: "执行版本发布流程"
 ---
 
 # 版本发布
@@ -12,7 +11,7 @@ description: >
 
 ## 执行流程
 
-### 步骤 1：解析并验证版本号
+### 1. 解析并验证版本号
 
 从参数中提取版本。必须匹配 `X.Y.Z` 格式。
 
@@ -22,7 +21,7 @@ description: >
 
 如果格式无效，报错："Version format incorrect, expected X.Y.Z (e.g. 1.2.3)"
 
-### 步骤 2：验证工作区干净
+### 2. 验证工作区干净
 
 ```bash
 git status --short
@@ -30,7 +29,26 @@ git status --short
 
 如果有未提交的变更，报错："Workspace has uncommitted changes. Please commit or stash first."
 
-### 步骤 3：更新版本引用
+### 3. 发布前验证
+
+<!-- TODO: 替换为你的项目发布前验证步骤 -->
+
+运行所有在准备发布前必须通过的检查：
+
+```bash
+git branch --show-current
+# TODO: 替换为你的项目测试/构建验证命令
+```
+
+验证要求：
+- 确认发布使用的是项目规定的分支
+- 运行你的发布流程要求的完整校验命令
+
+处理规则：
+- 如果当前分支不符合预期，按项目策略输出警告或直接退出
+- 如果任何验证命令失败，停止发布流程并先修复问题
+
+### 4. 更新版本引用
 
 <!-- TODO: 替换为你的项目版本更新步骤 -->
 
@@ -44,6 +62,7 @@ git status --short
 
 **常见需要更新的文件**：
 - `package.json`（Node.js）
+- `package-lock.json`（Node.js；更新 `package.json` 后运行 `npm install --package-lock-only` 同步锁文件）
 - `pom.xml`（Maven）
 - `setup.py` / `pyproject.toml`（Python）
 - `version.go`（Go）
@@ -51,22 +70,39 @@ git status --short
 - `SECURITY.md` / `SECURITY.zh-CN.md`（支持版本表格）
 
 **排除以下目录的版本替换**：
-- `.agents/`、`.agent-workspace/`、`.claude/`、`.codex/`、`.gemini/`、`.opencode/`（AI 工具配置）
+- `.agents/`、`.agents/workspace/`、`.claude/`、`.codex/`、`.gemini/`、`.opencode/`（AI 工具配置）
+
+如果项目使用 `package-lock.json`，在更新 `package.json` 后运行 `npm install --package-lock-only`，确保锁文件中的版本号保持同步。
+
+### 5. 重新生成构建产物
 
-### 步骤 4：创建发布提交
+<!-- TODO: 替换为你的项目产物重建步骤 -->
+
+如果版本更新会影响生成文件、内嵌元数据或打包产物，现在重新生成它们：
+
+```bash
+# TODO: 替换为你的项目构建/重建命令
+```
+
+执行要求：
+- 在更新版本引用后运行，确保生成产物使用最新版本号
+- 如果项目没有生成产物，请在项目特化版本中明确说明
+- 如果重建失败，停止发布流程并先修复构建问题
+
+### 6. 创建发布提交
 
 ```bash
 git add -A
 git commit -m "chore: release v{version}"
 ```
 
-### 步骤 5：创建 Git 标签
+### 7. 创建 Git 标签
 
 ```bash
 git tag v{version}
 ```
 
-### 步骤 6：管理里程碑
+### 8. 管理里程碑
 
 为已发布版本关闭对应版本里程碑，并为下一轮创建缺失的规划里程碑。
 
@@ -83,7 +119,7 @@ bash .agents/skills/release/scripts/manage-milestones.sh "$MAJOR" "$MINOR" "$PAT
 - 当 `PATCH=0` 时，同时确保 `{MAJOR}.{MINOR+1}.0` 与 `{MAJOR}.{MINOR+1}.x`
 - 输出包含已发布里程碑动作和新建数量的汇总
 
-### 步骤 7：输出摘要
+### 9. 输出摘要
 
 > **重要**：以下「下一步」中列出的所有 TUI 命令格式必须完整输出，不要只展示当前 AI 代理对应的格式。
 
@@ -99,12 +135,12 @@ bash .agents/skills/release/scripts/manage-milestones.sh "$MAJOR" "$MINOR" "$PAT
 
 下一步（手动执行）：
 
-1. 推送标签：
-   git push origin v{version}
-
-2. 推送分支：
+1. 推送分支：
    git push origin {current-branch}
 
+2. 推送标签：
+   git push origin v{version}
+
 3.（可选）生成发布说明：
    - Claude Code / OpenCode：/create-release-note {version}
    - Gemini CLI：/{{project}}:create-release-note {version}
@@ -129,13 +165,17 @@ git checkout -- .
 
 1. **需要干净的工作区**：必须没有未提交的变更
 2. **不自动推送**：所有操作仅在本地执行；用户手动推送
-3. **不验证构建**：发布前执行 test 技能进行验证
-4. **版本替换范围**：通过搜索确定需要更新哪些文件；排除 AI 工具目录
-5. **适配你的项目**：以上版本更新步骤是通用的；请根据你的项目版本方案进行定制
-6. **里程碑联动**：发布时自动创建下一轮里程碑；如果里程碑体系未初始化，建议先运行 `init-milestones`
+3. **发布前验证**：将步骤 3 的 TODO 替换为你的项目所需的分支、测试和验证命令
+4. **生成产物**：如果版本变化会影响生成文件、打包产物或内嵌元数据，需要将步骤 5 的 TODO 替换为实际命令
+5. **发布自动化**：如果推送标签会触发 CI/CD 或包发布，请先确认所需凭据和流水线配置
+6. **版本替换范围**：通过搜索确定需要更新哪些文件；排除 AI 工具目录
+7. **适配你的项目**：以上版本更新和产物重建步骤是通用的；请根据你的项目版本方案进行定制
+8. **里程碑联动**：发布时自动创建下一轮里程碑；如果里程碑体系未初始化，建议先运行 `init-milestones`
 
 ## 错误处理
 
 - 版本格式无效：提示正确格式并退出
 - 工作区不干净：提示提交或暂存
+- 验证失败：显示失败的检查并停止发布流程
+- 产物重建失败：显示构建错误并停止发布流程
 - Git 操作失败：显示错误并提供回滚说明

package/templates/.agents/skills/review-task/SKILL.md

@@ -1,78 +1,46 @@
 ---
 name: review-task
-description: >
-  Review implemented task changes and output a code review report, categorized by
-  severity (Blocker / Major / Minor). Triggered when the user requests code
-  review after implementation is complete. Argument: task-id.
+description: "Review a task implementation and output a code review report"
 ---
 
 # Code Review
 
+Review the latest implementation round and produce `review.md` or `review-r{N}.md`.
+
 ## Boundary / Critical Rules
 
-- This skill only reads code and produces a review report (`review.md` or `review-r{N}.md`) -- it does not modify business code
-- After executing this skill, you **must** immediately update task status in task.md
+- This skill reviews code and writes a report; it does not modify product code
+- After executing this skill, you **must** immediately update task.md
 
 ## Steps
 
 ### 1. Verify Prerequisites
 
-Check required files:
-- `.agent-workspace/active/{task-id}/task.md` - Task file
-- At least one implementation report: `implementation.md` or `implementation-r{N}.md`
-
-Note: `{task-id}` format is `TASK-{yyyyMMdd-HHmmss}`, for example `TASK-20260306-143022`
-
-If either file is missing, prompt the user to complete the prerequisite step first.
+Require:
+- `.agents/workspace/active/{task-id}/task.md`
+- at least one implementation artifact: `implementation.md` or `implementation-r{N}.md`
 
 ### 2. Determine Review Round
 
-Scan review artifacts in `.agent-workspace/active/{task-id}/`:
-- If neither `review.md` nor `review-r*.md` exists -> this is Round 1 and must create `review.md`
-- If `review.md` exists and no `review-r*.md` exists -> this is Round 2 and must create `review-r2.md`
-- If `review-r{N}.md` exists -> this is Round N+1 and must create `review-r{N+1}.md`
-
-Record:
-- `{review-round}`: the current review round
-- `{review-artifact}`: the review report filename for this round
+Scan the task directory and record:
+- `{review-round}`
+- `{review-artifact}` as `review.md` or `review-r{N}.md`
 
-### 3. Read Implementation and Refinement Reports
+### 3. Read Implementation and Refinement Context
 
-Scan implementation reports in the task directory (`implementation.md`, `implementation-r{N}.md`) and read the highest-round file to understand:
-- The list of modified files
-- The key functionality that was implemented
-- Test results
-- Any items the implementer marked for reviewer attention
+Read the highest-round implementation artifact and, if present, the highest-round refinement artifact.
 
-If refinement artifacts exist (`refinement.md`, `refinement-r{N}.md`), read the highest-round file to understand:
-- Which review findings were already fixed
-- The effect of those fixes on code and tests
-- How the current code state changed relative to the previous review
+### 4. Perform the Review
 
-### 4. Perform Code Review
+Follow `.agents/workflows/feature-development.yaml` and inspect `git diff` for the full change context.
 
-Follow the `code-review` step in `.agents/workflows/feature-development.yaml`:
+> Detailed review criteria, severity rules, and reviewer expectations live in `reference/review-criteria.md`. Read `reference/review-criteria.md` before reviewing.
 
-**Required review areas**:
-- [ ] Code quality and coding standards (per project instructions)
-- [ ] Bug and risk detection
-- [ ] Test coverage and test quality
-- [ ] Error handling and edge cases
-- [ ] Performance and security concerns
-- [ ] Code comments and documentation
-- [ ] Alignment with the technical plan
+### 5. Write the Review Report
 
-**Review principles**:
-1. **Strict but fair**: Point out issues while also calling out what was done well
-2. **Specific**: Provide exact file paths and line numbers
-3. **Actionable**: Do not only point out problems; give fix suggestions
-4. **Severity-based**: Distinguish must-fix issues from optional improvements
+Create `.agents/workspace/active/{task-id}/{review-artifact}`.
 
-Also review `git diff` to inspect the full context of all changes.
-
-### 5. Output Review Report
-
-Create `.agent-workspace/active/{task-id}/{review-artifact}`.
+> The report format and severity layout live in `reference/report-template.md`. Read `reference/report-template.md` before writing the review.
 
 ### 6. Update Task Status
 
@@ -82,205 +50,35 @@ Get the current time:
 date "+%Y-%m-%d %H:%M:%S"
 ```
 
-Update `.agent-workspace/active/{task-id}/task.md`:
-- `current_step`: code-review
-- `assigned_to`: {reviewer}
-- `updated_at`: {current time}
-- Record the review artifact for this round: `{review-artifact}` (Round `{review-round}`)
-- Mark code-review as complete in workflow progress and include the actual round when the task template supports it
-- **Append** to `## Activity Log` (do NOT overwrite previous entries):
-  ```
-  - {yyyy-MM-dd HH:mm:ss} — **Code Review (Round {N})** by {agent} — Verdict: {Approved/Changes Requested/Rejected}, blockers: {n}, major: {n}, minor: {n} → {artifact-filename}
-  ```
+Update task.md and append:
+`- {yyyy-MM-dd HH:mm:ss} — **Code Review (Round {N})** by {agent} — Verdict: {Approved/Changes Requested/Rejected}, blockers: {n}, major: {n}, minor: {n} → {artifact-filename}`
 
 ### 7. Inform User
 
-> **IMPORTANT**: All TUI command formats listed below must be output in full. Do not show only the format for the current AI agent.
-
-Output based on the review result:
-
-> **⚠️ CONDITION CHECK — you must determine the conditions below first, then choose exactly one matching output branch:**
->
-> 1. If `Blocker = 0` and `Major = 0` and `Minor = 0` -> use "Output Branch A - Passed with No Issues"
-> 2. If `Blocker = 0` and (`Major > 0` or `Minor > 0`) -> use "Output Branch B - Passed with Issues"
-> 3. If `Blocker > 0` and the issues can be resolved in a focused follow-up fix, **without requiring broad rework** -> use "Output Branch C - Changes Requested"
-> 4. If the issues require major rework, redesign, or re-implementation -> use "Output Branch D - Rejected"
->
-> **Do not skip the decision. Do not mix templates from different branches. You must output exactly one branch. As soon as `Blocker > 0`, you must not output any "Approved" template.**
-
-**📋 Output Branch A - Passed with No Issues** (Condition: Blocker = 0 and Major = 0 and Minor = 0):
-```
-Code review complete for task {task-id}. Verdict: Approved.
-- Blockers: 0 | Major issues: 0 | Minor issues: 0
-
-Next step - commit changes:
-  - Claude Code / OpenCode: /commit
-  - Gemini CLI: /{{project}}:commit
-  - Codex CLI: $commit
-```
-
-**📋 Output Branch B - Passed with Issues** (Condition: Blocker = 0 and (`Major > 0` or `Minor > 0`)):
-```
-Code review complete for task {task-id}. Verdict: Approved.
-- Blockers: 0 | Major issues: {n} | Minor issues: {n}
-- Review report: .agent-workspace/active/{task-id}/{review-artifact}
-
-Next step - fix issues before commit (recommended):
-  - Claude Code / OpenCode: /refine-task {task-id}
-  - Gemini CLI: /{{project}}:refine-task {task-id}
-  - Codex CLI: $refine-task {task-id}
-
-Or commit directly (skip fixes):
-  - Claude Code / OpenCode: /commit
-  - Gemini CLI: /{{project}}:commit
-  - Codex CLI: $commit
-```
-
-**📋 Output Branch C - Changes Requested** (Condition: Blocker > 0, and the issues are fixable without major rework):
-```
-Code review complete for task {task-id}. Verdict: Changes Requested.
-- Blockers: {n} | Major issues: {n} | Minor issues: {n}
-- Review report: .agent-workspace/active/{task-id}/{review-artifact}
-
-Next step - refine the issues:
-  - Claude Code / OpenCode: /refine-task {task-id}
-  - Gemini CLI: /{{project}}:refine-task {task-id}
-  - Codex CLI: $refine-task {task-id}
-```
-
-**📋 Output Branch D - Rejected** (Condition: major rework, redesign, or re-implementation is required):
-```
-Code review complete for task {task-id}. Verdict: Rejected, major rework required.
-- Review report: .agent-workspace/active/{task-id}/{review-artifact}
-
-Next step - re-implement:
-  - Claude Code / OpenCode: /implement-task {task-id}
-  - Gemini CLI: /{{project}}:implement-task {task-id}
-  - Codex CLI: $implement-task {task-id}
-```
-
-## Output Template
-
-```markdown
-# Code Review Report
+Choose exactly one branch based on the findings:
+- no blockers, no major, no minor -> approved with no issues
+- no blockers, but major or minor findings -> approved with issues
+- blockers that can be fixed in a focused pass -> changes requested
+- major redesign or re-implementation needed -> rejected
 
-- **Review round**: Round {review-round}
-- **Artifact file**: `{review-artifact}`
-- **Implementation input**:
-  - `{implementation-artifact}`
-  - `{refinement-artifact}` (if present)
+> The full four-branch output templates, selection rules, and prohibition clauses live in `reference/output-templates.md`. Read `reference/output-templates.md` before reporting the review result.
 
-## Review Summary
-
-- **Reviewer**: {reviewer name}
-- **Review time**: {timestamp}
-- **Review scope**: {file count and major modules}
-- **Overall verdict**: {Approved / Changes Requested / Rejected}
-
-## Findings
-
-### Blockers (must fix)
-
-#### 1. {Issue title}
-**File**: `{file-path}:{line-number}`
-**Description**: {Detailed description}
-**Suggested fix**: {Concrete suggestion}
-**Severity**: High
-
-### Major Issues (should fix)
-
-#### 1. {Issue title}
-**File**: `{file-path}:{line-number}`
-**Description**: {Detailed description}
-**Suggested fix**: {Concrete suggestion}
-**Severity**: Medium
-
-### Minor Issues (optional improvements)
-
-#### 1. {Improvement point}
-**File**: `{file-path}:{line-number}`
-**Suggestion**: {Improvement suggestion}
-
-## Highlights
-
-- {Positive aspect 1}
-- {Positive aspect 2}
-
-## Standards Compliance
-
-### Coding Standards
-- [ ] Naming conventions
-- [ ] Code style
-- [ ] Comment standards
-- [ ] Testing standards
-
-### Code Quality Metrics
-- Cyclomatic complexity: {Assessment}
-- Code duplication: {Assessment}
-- Test coverage: {Percentage or assessment}
-
-## Test Review
-
-### Test Coverage
-- Unit tests: {Assessment}
-- Edge cases: {Covered?}
-- Error scenarios: {Covered?}
-
-### Test Quality
-- Test naming: {Assessment}
-- Assertion sufficiency: {Assessment}
-- Test independence: {Assessment}
-
-## Security Review
-
-- SQL injection risk: {Check result}
-- XSS risk: {Check result}
-- Access control: {Check result}
-- Sensitive data exposure: {Check result}
-
-## Performance Review
-
-- Algorithmic complexity: {Assessment}
-- Resource management: {Check result}
-- Potential bottlenecks: {Assessment}
-
-## Alignment with Plan
-
-- [ ] Implementation matches the technical plan
-- [ ] No deviation from design intent
-- [ ] No out-of-scope functionality was added
-
-## Conclusion and Recommendation
-
-### Approval Decision
-- [ ] Approved - no blocking issues
-- [ ] Changes Requested - issues need to be resolved
-- [ ] Rejected - major rework required
-
-### Next Steps
-{Recommendation based on the review result}
-```
+Include all TUI command formats in the next-step output.
 
 ## Completion Checklist
 
-- [ ] Completed code review for all modified files
-- [ ] Created review report `.agent-workspace/active/{task-id}/{review-artifact}`
-- [ ] Updated `current_step` to code-review in task.md
-- [ ] Updated `updated_at` to the current time in task.md
-- [ ] Updated `assigned_to` to the reviewer name in task.md
-- [ ] Appended an Activity Log entry to task.md
-- [ ] Marked code-review as complete in workflow progress
-- [ ] Informed the user of the next step based on the review result (must include all TUI command formats without filtering)
+- [ ] Reviewed the latest implementation context
+- [ ] Created `{review-artifact}`
+- [ ] Updated task.md and appended the Activity Log entry
+- [ ] Chose exactly one verdict branch in the user output
 
 ## Notes
 
-1. **Prerequisite**: At least one implementation round must already exist (`implementation.md` or `implementation-r{N}.md`)
-2. **Objectivity**: Be strict but fair; acknowledge strong work while pointing out issues
-3. **Specificity**: Always cite exact file paths and line numbers
-4. **Severity categories**: Blockers must be fixed; major issues should be fixed; minor issues are optional
-5. **Versioning rule**: First review uses `review.md`; later rounds use `review-r{N}.md`
+- Round 1 uses `review.md`; later rounds use `review-r{N}.md`
+- Always cite concrete file paths and line numbers in findings
+- Review severity must distinguish blockers, major issues, and minor issues
 
 ## Error Handling
 
-- Task not found: Prompt "Task {task-id} not found"
-- Missing implementation report: Prompt "Implementation report not found, please run the implement-task skill first"
+- Task not found: `Task {task-id} not found`
+- Missing implementation report: `Implementation report not found, please run the implement-task skill first`