@fitlab-ai/agent-infra 0.12.1 → 0.12.2

package/lib/task/verification-engine.ts

@@ -1,7 +1,6 @@
 // frontmatter, ledger, Git snapshot and platform domains are imported below.
 import fs from "node:fs";
 import path from "node:path";
-import process from "node:process";
 import { execFileSync } from "node:child_process";
 import { fileURLToPath } from "node:url";
 
@@ -29,10 +28,8 @@ import { inspectDecisionDetailDuplicates } from "./decision-details.ts";
 import { parseImplementationInputs, type ImplementationInput } from "./implementation-inputs.ts";
 import { scanVisibleMarkdown } from "./markdown.ts";
 import { loadVerificationConfig } from "./verification-config.ts";
-import { inspectActivityLog, pairEntries } from "./activity-log.ts";
+import { inspectActivityLog } from "./activity-log.ts";
 import { parseWorkflowWarnings } from "./workflow-warnings.ts";
-import { OrchestrationStateError, readRun } from "./orchestration.ts";
-import type { OrchestrationRun } from "./orchestration.ts";
 import { readPrDeliveryFact } from "./pr-delivery-fact.ts";
 import { validateLocalArtifact } from "./local-artifact-finalization.ts";
 import { getArtifactSchema } from "./artifact-schema.ts";
@@ -41,13 +38,12 @@ import type { VerificationShared } from "./verification-types.ts";
 import { normalizeVerificationRecord } from './gate-policy.ts';
 import { manualValidationFinalSummaryProjectionMatches } from "./manual-validation-receipt.ts";
 import { readManualValidationCompletion } from "./manual-validation-completion.ts";
-import { sha256File } from "./artifact-receipts.ts";
+import { parseArtifactReceipts, receiptForOutput, sha256File } from "./artifact-receipts.ts";
 import { inspectArtifactDirectory } from "./artifact-lifecycle.ts";
-import { getAgentClientAdapter } from "../agent-clients/registry.ts";
 import { parseArtifactName } from "./artifact-name.ts";
 import { summaryCommentState } from "../platform/pr-summary.ts";
 import { taskIssueIdentity } from "../platform/task-identities.ts";
-import { hasArtifactCompletionFact, hasArtifactCompletionLog, parseCompletionFacts } from './completion-facts.ts';
+import { hasValidArtifactCompletion } from './completion-facts.ts';
 import { inspectReviewIdentity } from './review-identity.ts';
 
 const TASK_ENUMS = {
@@ -70,11 +66,9 @@ const DEFAULT_REQUIRED_FIELDS = [
 
 const DATE_TIME_PATTERN = /^\d{4}-\d{2}-\d{2}[T ]\d{2}:\d{2}:\d{2}(?:[+-]\d{2}:\d{2})?$/;
 // Started rows do not represent completed lifecycle actions.
-const ACTIVITY_LOG_STARTED_RE = /\s*\[started\]\s*$/;
 const BRANCH_SLUG_PATTERN = /^[a-z0-9]+(?:-[a-z0-9]+)*$/;
 
 // Review disagreement ledger (see .agents/rules/review-handshake.md).
-const LEDGER_SECTION_NAMES = ["审查分歧账本", "Review Disagreement Ledger"];
 const POST_REVIEW_COMMIT_STAGE = "post-review-commit";
 const SHA_PATTERN = /^[0-9a-f]{7,40}$/i;
 
@@ -126,10 +120,6 @@ async function runCheck(type: any, context: any, shared: any): Promise<any> {
       return checkPostReviewCommit(context);
     case "required-pr-delivery":
       return checkRequiredPrDelivery(context);
-    case "orchestration-state":
-      return checkOrchestrationState(context);
-    case "orchestration-evidence":
-      return checkOrchestrationEvidence(context);
     default: {
       const adapter = PLATFORM_ADAPTERS[type];
       if (!adapter) {
@@ -145,162 +135,6 @@ async function runCheck(type: any, context: any, shared: any): Promise<any> {
   }
 }
 
-function checkOrchestrationState({ taskDir }: any): any {
-  const file = path.join(taskDir, '.runtime', 'orchestration.json');
-  const stat = safeStat(file);
-  if (!stat?.isFile()) return failResult('orchestration-state', 'orchestration.json is missing');
-  let run: OrchestrationRun | null;
-  try {
-    run = readRun(taskDir);
-  } catch (error) {
-    const message = error instanceof OrchestrationStateError ? error.message : String(error);
-    return failResult('orchestration-state', `Invalid orchestration.json: ${message}`);
-  }
-  if (!run || !['paused', 'completed'].includes(run.status)) {
-    return failResult('orchestration-state', `Expected paused or completed run, received '${run?.status ?? 'missing'}'`);
-  }
-  const adapterEvidenceError = validateAdapterReceiptEvidence(run);
-  if (adapterEvidenceError) return failResult('orchestration-state', adapterEvidenceError);
-  if (run.status === 'paused' && (!run.pause?.code || !run.pause?.message)) {
-    return failResult('orchestration-state', 'Paused run requires a stable pause code and message');
-  }
-  if (run.status === 'completed') {
-    const evidenceError = validateCleanCompletionEvidence(run);
-    if (evidenceError) return failResult('orchestration-state', evidenceError);
-  } else if (run.completionEvidence != null) {
-    return failResult('orchestration-state', 'Clean completion evidence requires a completed run');
-  } else if (run.pendingDelegation?.status === 'sealed') {
-    return failResult('orchestration-state', 'Paused run has a sealed delegation that could still advance');
-  }
-  return passResult('orchestration-state', `Orchestration run is safely ${run.status}`);
-}
-
-function exactText(value: unknown): value is string {
-  return typeof value === 'string' && value.length > 0 && value.trim() === value;
-}
-
-function validateCleanCompletionEvidence(run: OrchestrationRun): string | null {
-  const evidence = run.completionEvidence;
-  const shaPattern = /^[0-9a-f]{40}$/i;
-  if (
-    !evidence
-    || Number.isNaN(Date.parse(evidence.observedAt))
-    || !shaPattern.test(evidence.head)
-    || !shaPattern.test(evidence.headTree)
-    || !shaPattern.test(evidence.worktreeTree)
-    || !shaPattern.test(evidence.lastReviewedCommit)
-    || !(evidence.prHead === null || shaPattern.test(evidence.prHead))
-  ) {
-    return 'Clean completion evidence has an invalid structure';
-  }
-  if (
-    evidence.head !== evidence.lastReviewedCommit
-    || (evidence.prHead !== null && evidence.head !== evidence.prHead)
-    || evidence.headTree !== evidence.worktreeTree
-  ) {
-    return 'Clean completion evidence does not bind matching commit and tree identities';
-  }
-  if (
-    run.status !== 'completed'
-    || run.pendingDelegation !== null
-    || run.receipts.some((receipt) => receipt.stage === 'commit')
-  ) {
-    return 'Clean completion evidence conflicts with pending delegation or commit receipt state';
-  }
-  return null;
-}
-
-function validateAdapterReceiptEvidence(run: OrchestrationRun): string | null {
-  const receipts = [...run.receipts, ...(run.pendingDelegation ? [run.pendingDelegation] : [])];
-  for (const receipt of receipts) {
-    const validate = getAgentClientAdapter(receipt.client).orchestrationAdapter?.validateReceiptEvidence;
-    if (validate && !validate(receipt)) {
-      return `Receipt '${receipt.id}' has invalid evidence from its agent adapter`;
-    }
-  }
-  return null;
-}
-
-function checkOrchestrationEvidence({ taskDir }: any): any {
-  const file = path.join(taskDir, '.runtime', 'orchestration.json');
-  const stat = safeStat(file);
-  if (!stat?.isFile()) return failResult('orchestration-evidence', 'orchestration.json is missing');
-  let run: OrchestrationRun | null;
-  try {
-    run = readRun(taskDir);
-  } catch (error) {
-    const message = error instanceof OrchestrationStateError ? error.message : String(error);
-    return failResult('orchestration-evidence', `Invalid orchestration.json: ${message}`);
-  }
-  if (!run) return failResult('orchestration-evidence', 'orchestration.json is missing');
-  const adapterEvidenceError = validateAdapterReceiptEvidence(run);
-  if (adapterEvidenceError) return failResult('orchestration-evidence', adapterEvidenceError);
-  // readRun validates the persisted schema, receipt identities and client provenance.
-  const policy = run.modelPolicy;
-  if (run.completionEvidence != null) {
-    const evidenceError = validateCleanCompletionEvidence(run);
-    if (evidenceError) return failResult('orchestration-evidence', evidenceError);
-  } else if (run.status === 'completed') {
-    return failResult('orchestration-evidence', 'Completed run requires reviewed-head-clean completion evidence');
-  }
-  if (run.pendingDelegation && !['prepared', 'activated', 'stage-completed'].includes(run.pendingDelegation.status)) {
-    return failResult('orchestration-evidence', `Pending receipt has unsafe status '${run.pendingDelegation.status}'`);
-  }
-  const receipts = [...run.receipts, ...(run.pendingDelegation ? [run.pendingDelegation] : [])];
-  for (const receipt of receipts) {
-    const expectedPolicy = policy[receipt.role];
-    if (!expectedPolicy || receipt.requestedModel !== expectedPolicy.model) {
-      return failResult('orchestration-evidence', `Receipt '${receipt.id ?? '(unknown)'}' requested model does not match its role policy`);
-    }
-    if (receipt.requestedReasoningEffort !== expectedPolicy.reasoningEffort) {
-      return failResult('orchestration-evidence', `Receipt '${receipt.id ?? '(unknown)'}' requested reasoning effort does not match its role policy`);
-    }
-    const activated = ['activated', 'stage-completed', 'sealed', 'consumed'].includes(receipt.status);
-    if (activated) {
-      const evidencePolicy = getAgentClientAdapter(receipt.client).delegationEvidence;
-      if (evidencePolicy.actualModelRequired !== false) {
-        if (!exactText(receipt.actualModel)) {
-          return failResult('orchestration-evidence', `Receipt '${receipt.id ?? '(unknown)'}' has no host-observed actual model`);
-        }
-      }
-      if (evidencePolicy.actualReasoningEffortRequired !== false) {
-        if (!exactText(receipt.actualReasoningEffort)) {
-          return failResult('orchestration-evidence', `Receipt '${receipt.id ?? '(unknown)'}' has no host-observed actual reasoning effort`);
-        }
-      }
-      if (evidencePolicy.spawnModeRequired !== false && receipt.spawnMode !== 'fresh') {
-        return failResult('orchestration-evidence', `Receipt '${receipt.id ?? '(unknown)'}' has invalid fresh delegation identity`);
-      }
-      if (receipt.actualModel != null && receipt.actualModel !== receipt.requestedModel) {
-        if (evidencePolicy.fallbackReasonRequired !== false && !exactText(receipt.modelFallbackReason)) {
-          return failResult('orchestration-evidence', `Receipt '${receipt.id ?? '(unknown)'}' model fallback is not justified`);
-        }
-      }
-      if (
-        (receipt.actualModel == null || receipt.actualModel === receipt.requestedModel)
-        && receipt.modelFallbackReason !== null
-      ) {
-        return failResult('orchestration-evidence', `Receipt '${receipt.id ?? '(unknown)'}' has an unrelated model fallback reason`);
-      }
-      if (receipt.actualReasoningEffort != null && receipt.actualReasoningEffort !== receipt.requestedReasoningEffort) {
-        if (evidencePolicy.fallbackReasonRequired !== false && !exactText(receipt.reasoningEffortFallbackReason)) {
-          return failResult('orchestration-evidence', `Receipt '${receipt.id ?? '(unknown)'}' reasoning-effort fallback is not justified`);
-        }
-      }
-      if (
-        (receipt.actualReasoningEffort == null || receipt.actualReasoningEffort === receipt.requestedReasoningEffort)
-        && receipt.reasoningEffortFallbackReason !== null
-      ) {
-        return failResult('orchestration-evidence', `Receipt '${receipt.id ?? '(unknown)'}' has an unrelated reasoning-effort fallback reason`);
-      }
-    }
-  }
-  if (run.receipts.some((receipt) => receipt.status !== 'consumed')) {
-    return failResult('orchestration-evidence', 'Historical receipts must be consumed');
-  }
-  return passResult('orchestration-evidence', 'Persisted orchestration model and delegation evidence is internally consistent');
-}
-
 // === Check Functions ===
 
 function checkTaskMeta({ taskDir, config, repositoryRoot, skillName, artifactFile }: any): any {
@@ -356,12 +190,9 @@ function checkTaskMeta({ taskDir, config, repositoryRoot, skillName, artifactFil
   if (expectedStep && metadata.current_step !== expectedStep) {
     let validLifecycleArtifact = false;
     if (currentTask) {
-      const { section, invalidEntries } = inspectActivityLog(task.content);
-      if (section && invalidEntries.length === 0) {
-        validLifecycleArtifact = checkArtifactLifecycleActivityLog(
-          taskDir, artifactFile, skillName, task, section.entries
-        )?.status === "pass";
-      }
+      validLifecycleArtifact = checkArtifactLifecycleActivityLog(
+        taskDir, artifactFile, skillName, task
+      )?.status === "pass";
     }
     if (!validLifecycleArtifact) {
       return failResult(
@@ -678,12 +509,6 @@ function checkImplementationInput({ taskDir, artifactFile }: any): any {
     return failResult("implementation-input", `Invalid Implementation Inputs: ${error instanceof Error ? error.message : String(error)}`);
   }
 
-  const doneActions = (inspectActivityLog(task.content).section?.entries ?? [])
-    .filter((entry) => !ACTIVITY_LOG_STARTED_RE.test(entry.step))
-    .map((entry) => entry.step)
-    .filter((step) => /^(?:Code Task|Code) \(Round \d+/.test(step));
-  const latestAction = doneActions.at(-1) || "";
-  const actionDecision = /(?:Code Task|Code) \(Round \d+, decision (II-[1-9]\d*)\)/.exec(latestAction)?.[1] || null;
   const report = fs.readFileSync(artifactPath, "utf8");
   const reportSection = getSectionContent(report, ["实现输入", "Implementation Input"]);
   if (!reportSection) return failResult("implementation-input", "Implementation Input report section not found");
@@ -696,37 +521,31 @@ function checkImplementationInput({ taskDir, artifactFile }: any): any {
   const reportLedger = field("账本 ID", "Ledger ID");
   const reportEvidence = field("裁决证据", "Decision Evidence");
 
-  if (!actionDecision) {
-    if (reportInput && reportInput !== "N/A") {
-      return failResult("implementation-input", "Non-decision code action must report Decision Input as N/A");
-    }
+  if (!reportInput || reportInput === "N/A") {
     return passResult("implementation-input", "Non-decision implementation input identity is consistent");
   }
-  if (reportInput !== actionDecision) {
-    return failResult("implementation-input", `Report decision input '${reportInput}' does not match Activity Log ${actionDecision}`);
-  }
-  const matches = rows.filter((row) => row.id === actionDecision);
-  if (matches.length !== 1) return failResult("implementation-input", `${actionDecision} is missing or duplicated in task table`);
+  const matches = rows.filter((row) => row.id === reportInput);
+  if (matches.length !== 1) return failResult("implementation-input", `${reportInput} is missing or duplicated in task table`);
   const row = matches[0]!;
   if (row.stage !== "code" || !row.needsImplementation || row.status !== "consumed" || row.consumedBy !== artifactFile || !row.decisionEvidence) {
-    return failResult("implementation-input", `${actionDecision} is not a consumed input for ${artifactFile}`);
+    return failResult("implementation-input", `${reportInput} is not a consumed input for ${artifactFile}`);
   }
   if (reportLedger !== row.ledgerId || reportEvidence !== row.decisionEvidence) {
-    return failResult("implementation-input", `${actionDecision} report identity does not match task table evidence`);
+    return failResult("implementation-input", `${reportInput} report identity does not match task table evidence`);
   }
-  return passResult("implementation-input", `${actionDecision} matches Activity Log, report, and task table`);
+  return passResult("implementation-input", `${reportInput} matches report and task table`);
 }
 
-const ARTIFACT_ACTIVITY_STAGES: Readonly<Record<string, { family: string; event: string; action: string }>> = {
-  "analyze-task": { family: "analysis", event: "analyze.completed", action: "Analyze Task" },
-  "plan-task": { family: "plan", event: "plan.completed", action: "Plan Task" },
-  "review-analysis": { family: "review-analysis", event: "review-analysis.completed", action: "Review Analysis" },
-  "review-plan": { family: "review-plan", event: "review-plan.completed", action: "Review Plan" },
-  "code-task": { family: "code", event: "code.completed", action: "Code Task" },
-  "review-code": { family: "review-code", event: "review-code.completed", action: "Review Code" }
+const ARTIFACT_ACTIVITY_STAGES: Readonly<Record<string, { family: string; event: string }>> = {
+  "analyze-task": { family: "analysis", event: "analyze.completed" },
+  "plan-task": { family: "plan", event: "plan.completed" },
+  "review-analysis": { family: "review-analysis", event: "review-analysis.completed" },
+  "review-plan": { family: "review-plan", event: "review-plan.completed" },
+  "code-task": { family: "code", event: "code.completed" },
+  "review-code": { family: "review-code", event: "review-code.completed" }
 };
 
-function checkArtifactLifecycleActivityLog(taskDir: string, artifactFile: string | undefined, skillName: string, task: any, entries: any[]): any {
+function checkArtifactLifecycleActivityLog(taskDir: string, artifactFile: string | undefined, skillName: string, task: any): any {
   const stage = ARTIFACT_ACTIVITY_STAGES[skillName];
   if (!stage) return null;
   const inventory = inspectArtifactDirectory(taskDir, stage.family as any);
@@ -741,38 +560,21 @@ function checkArtifactLifecycleActivityLog(taskDir: string, artifactFile: string
   if (!identity || identity.family !== stage.family) {
     return failResult("activity-log", `Artifact '${output}' does not belong to ${stage.family}`);
   }
-  if (!hasArtifactCompletionFact(task.content, path.join(taskDir, output), stage.event)) {
+  if (!hasValidArtifactCompletion(task.content, taskDir, output, stage.event)) {
     return failResult("activity-log", `Completion fact for '${output}' is missing or stale; rerun ${skillName} to record a current completion`);
   }
 
-  const frontmatter = parseTypedTaskFrontmatter(task.content);
-  const fact = parseCompletionFacts(frontmatter.completion_facts).find((item) => item.event === stage.event && item.output === output);
-  if (!fact) return failResult("activity-log", `Completion fact for '${output}' is missing; rerun ${skillName}`);
-  if (!Array.isArray(fact.lifecycleInputs)) {
-    return failResult("activity-log", `Completion fact for '${output}' has no input snapshot; rerun ${skillName}`);
-  }
-  for (const input of fact.lifecycleInputs) {
-    if (!input || typeof input.name !== "string" || !/^[a-f0-9]{64}$/u.test(input.sha256)) {
-      return failResult("activity-log", `Completion fact for '${output}' has an invalid input snapshot; rerun ${skillName}`);
-    }
-    const inputIdentity = parseArtifactName(input.name);
-    if (!inputIdentity) return failResult("activity-log", `Completion fact for '${output}' has invalid input '${input.name}'; rerun ${skillName}`);
+  const receipts = parseArtifactReceipts(task.content).rows.filter((receipt) => receipt.output === output);
+  for (const receipt of receipts) {
+    const inputIdentity = parseArtifactName(receipt.input);
+    if (!inputIdentity) return failResult("activity-log", `Completion receipt for '${output}' has invalid input '${receipt.input}'; rerun ${skillName}`);
     const inputInventory = inspectArtifactDirectory(taskDir, inputIdentity.family as any);
-    if (inputInventory.status !== "ready" || inputInventory.latest?.name !== input.name
-      || sha256File(path.join(taskDir, input.name)) !== input.sha256) {
-      return failResult("activity-log", `Input '${input.name}' changed or is no longer current; rerun ${skillName} to refresh '${output}'`);
+    if (inputInventory.status !== "ready" || inputInventory.latest?.name !== receipt.input
+      || sha256File(path.join(taskDir, receipt.input)) !== receipt.inputSha256) {
+      return failResult("activity-log", `Input '${receipt.input}' changed or is no longer current; rerun ${skillName} to refresh '${output}'`);
     }
   }
 
-  const roundActionPattern = new RegExp(`^${stage.action} \\(Round ${identity.round}(?:, [^)]+)?\\)$`);
-  const roundAction = entries.find((entry) => {
-    return !ACTIVITY_LOG_STARTED_RE.test(entry.step)
-      && roundActionPattern.test(entry.step)
-      && entry.note.includes(`→ ${output}`);
-  });
-  if (!roundAction) {
-    return failResult("activity-log", `No completed Activity Log row records '${output}' for ${skillName} Round ${identity.round}`);
-  }
   return passResult("activity-log", `Current ${stage.family} completion '${output}' is valid for Round ${identity.round}`);
 }
 
@@ -782,22 +584,19 @@ function checkActivityLog({ taskDir, skillName, artifactFile }: any): any {
     return failResult("activity-log", task.message);
   }
 
-  const { section, invalidEntries } = inspectActivityLog(task.content);
-  if (!section) return failResult("activity-log", "Activity Log section not found or ambiguous");
-  if (invalidEntries.length) return failResult("activity-log", `Invalid Activity Log entry format: ${invalidEntries[0]}`);
-  const entries = section.entries;
-  if (entries.length === 0) return failResult("activity-log", "Activity Log has no entries");
+  const artifactLifecycleResult = checkArtifactLifecycleActivityLog(taskDir, artifactFile, skillName, task);
+  if (artifactLifecycleResult && artifactLifecycleResult.status !== "pass") return artifactLifecycleResult;
 
-  for (const entry of entries) {
-    if (!entry.note.trim()) return failResult("activity-log", "Activity Log entry note is required");
+  const { section, invalidEntries } = inspectActivityLog(task.content);
+  const warnings: string[] = [];
+  if (!section) warnings.push('Activity Log section is missing or ambiguous');
+  else {
+    if (invalidEntries.length) warnings.push('Activity Log contains malformed entries');
+    if (!section.entries.length) warnings.push('Activity Log has no entries');
+    if (section.entries.some((entry) => !entry.note.trim())) warnings.push('Activity Log entry note is empty');
   }
+  return passResult("activity-log", artifactLifecycleResult?.message ?? "Business checks are valid", warnings);
 
-  const artifactLifecycleResult = checkArtifactLifecycleActivityLog(
-    taskDir, artifactFile, skillName, task, entries
-  );
-  if (artifactLifecycleResult) return artifactLifecycleResult;
-
-  return passResult("activity-log", "Activity Log is valid");
 }
 
 function checkCompletionChecklist({ taskDir, config }: any): any {
@@ -837,18 +636,7 @@ function checkCompletionChecklist({ taskDir, config }: any): any {
   return passResult("completion-checklist", `Completion Checklist valid (${items.length} items checked)`);
 }
 
-function resolveReviewSetting(config: any, key: any, fallback: any, repoRoot: string): any {
-  if (config && config[key] !== undefined && config[key] !== null) {
-    return config[key];
-  }
-  const reviewConfig = loadPostReviewConfig(repoRoot);
-  if (reviewConfig[key] !== undefined && reviewConfig[key] !== null) {
-    return reviewConfig[key];
-  }
-  return fallback;
-}
-
-function checkReviewLedger({ taskDir, config, repositoryRoot }: any): any {
+function checkReviewLedger({ taskDir, config }: any): any {
   const task = loadTask(taskDir);
   if (!task.ok) {
     return failResult("review-ledger", task.message);
@@ -931,8 +719,7 @@ async function checkManualValidation({ taskDir, repositoryRoot }: any): Promise<
       `${parsed.summary.manualValidation} manual validation item(s) pending: run /complete-manual-validation`
     );
   }
-  // 5. The Activity Log must record the matching completion entry; the file name
-  //    is derived with path.basename (resolveArtifactPath does not return fileName).
+  // 5. Validate the committed receipt, transaction, and artifact.
   const artifactName = path.basename(resolved.path);
   const task = loadTask(taskDir);
   if (!task.ok) return failResult("manual-validation", task.message);
@@ -954,29 +741,21 @@ async function checkManualValidation({ taskDir, repositoryRoot }: any): Promise<
   if (sha256File(resolved.path) !== receipt.artifactSha256) {
     return failResult("manual-validation", `Manual validation artifact digest does not match the receipt for ${artifactName}`);
   }
-  // 6. Timing correlation (PL-3 fix, PL-4 corrected): the completion entry must
-  //    sit AFTER the latest review-code round's completion entry in the
-  //    append-only Activity Log. indexOf is a literal search, so the artifactName
-  //    must NOT be passed through escapeRegExp here (that escapes '.' to '\.',
-  //    which indexOf never matches). Not reusing completed.exec().index: exec
-  //    anchors to the first '**Complete Manual Validation**' heading, which can
-  //    belong to an earlier round's entry and misorder the standard path.
-  const inspectedLog = inspectActivityLog(task.content);
-  if (!inspectedLog.section) return failResult("manual-validation", "Activity Log is missing or invalid");
-  const reviewRow = pairEntries(inspectedLog.section.entries).find((row) =>
-    row.step === `Review Code (Round ${review.round})` && row.started !== '' && row.done !== ''
-  );
-  const reviewDoneIndex = reviewRow
-    ? inspectedLog.section.entries.findIndex((entry) => entry.step === reviewRow.step && entry.time === reviewRow.done)
-    : -1;
-  const completedIndex = inspectedLog.section.entries.findIndex((entry) => entry.step === "Complete Manual Validation"
-    && entry.note.includes(`Manual validation passed → ${artifactName};`)
-        && entry.note.includes(`transaction=${receipt.transactionId};`)
-        && entry.note.includes(`receipt=${receipt.receiptDigest};`)
-        && entry.note.includes(`head=${receipt.prHeadSha}`));
-  if (reviewDoneIndex === -1) return failResult("manual-validation", `Latest review-code (round ${review.round}) completion entry is missing from the Activity Log`);
-  if (completedIndex === -1) return failResult("manual-validation", `Committed manual validation completion is not recorded for ${artifactName}`);
-  if (completedIndex < reviewDoneIndex) return failResult("manual-validation", `Latest review-code (round ${review.round}) came after the manual validation completion recorded for ${artifactName}`);
+  // 6. Compare the review completion and committed manual-validation times.
+  let reviewReceipt;
+  try {
+    reviewReceipt = receiptForOutput(task.content, review.fileName!);
+  } catch (error) {
+    return failResult("manual-validation", `Review-code receipt is invalid: ${error instanceof Error ? error.message : String(error)}`);
+  }
+  if (!reviewReceipt || reviewReceipt.event !== "review-code.completed") {
+    return failResult("manual-validation", `Review-code completion time is unavailable for ${review.fileName}`);
+  }
+  const reviewTime = Date.parse(reviewReceipt.completedAt.replace(' ', 'T'));
+  const validationTime = Date.parse(receipt.committedAt);
+  if (!Number.isFinite(reviewTime) || !Number.isFinite(validationTime) || validationTime <= reviewTime) {
+    return failResult("manual-validation", `Manual validation must be completed after review-code ${review.fileName}`);
+  }
 
   const fact = readPrDeliveryFact(task.metadata);
   if (fact.status === "invalid") return failResult("manual-validation", fact.error.message);
@@ -1212,12 +991,9 @@ function checkReviewFact({ taskDir, artifactFile, repositoryRoot }: any): any {
   }
 
   const content = fs.readFileSync(resolvedArtifact.path, "utf8");
-  if (!hasArtifactCompletionFact(task.content, resolvedArtifact.path, 'review-code.completed')) {
+  if (!hasValidArtifactCompletion(task.content, taskDir, path.basename(resolvedArtifact.path), 'review-code.completed')) {
     return failResult("review-fact", `Review Code completion fact does not match ${path.basename(resolvedArtifact.path)}`);
   }
-  if (!hasArtifactCompletionLog(task.content, path.basename(resolvedArtifact.path), 'review-code.completed')) {
-    return failResult("review-fact", `Review Code completion entry does not reference ${path.basename(resolvedArtifact.path)}`);
-  }
   const verdict = parseReviewVerdict(content);
   const reviewTargetHead = extractReviewTargetHead(content);
   const reviewReviewedHead = extractReviewedHead(content);
@@ -1368,13 +1144,6 @@ function normalizeContent(text: any): any {
     .trim();
 }
 
-function interpolate(template: any, taskDir: any, artifactFile: any): any {
-  const artifactStem = artifactFile ? path.basename(artifactFile, path.extname(artifactFile)) : "";
-  return template
-    .replace(/\{task-id\}/g, path.basename(taskDir))
-    .replace(/\{artifact-stem\}/g, artifactStem);
-}
-
 function summarizeGate(checks: any): any {
   if (checks.some((check: any) => check.effectiveStatus === "blocked")) {
     return "blocked";

package/lib/task/verification.ts

@@ -17,8 +17,7 @@ type VerificationEvent =
   | 'create-pr.completed' | 'create-task.completed'
   | 'import-codescan.completed' | 'import-dependabot.completed'
   | 'import-issue.completed' | 'watch-pr.completed'
-  | 'review-pr.completed'
-  | 'run-task.paused' | 'run-task.completed';
+  | 'review-pr.completed';
 type VerificationSpec = {
   skill: string;
   expectedState: 'active' | 'blocked' | 'completed';
@@ -75,9 +74,7 @@ const VERIFICATION_CATALOG: Readonly<Record<VerificationEvent, VerificationSpec>
   'import-dependabot.completed': gate('import-dependabot', 'active'),
   'import-issue.completed': gate('import-issue', 'active'),
   'watch-pr.completed': gate('watch-pr', 'active'),
-  'review-pr.completed': gate('review-pr', 'active', 'pr-review'),
-  'run-task.paused': { skill: 'run-task', expectedState: 'active', mode: 'checks', checks: ['orchestration-state', 'orchestration-evidence'] },
-  'run-task.completed': { skill: 'run-task', expectedState: 'active', mode: 'checks', checks: ['orchestration-state', 'orchestration-evidence'] }
+  'review-pr.completed': gate('review-pr', 'active', 'pr-review')
 };
 
 function failure(request: { taskRef: string; event: string; artifact?: string }, code: string, message: string, extra: Partial<TaskVerificationResult> = {}): TaskVerificationResult {
@@ -161,6 +158,9 @@ function renderTaskVerification(result: TaskVerificationResult): string {
       && typeof message === 'string'
       && /\bhuman-decided (?:post-review )?exemption\b/i.test(message)
       && /\bPRC-\d+\s*:/.test(message);
+    if (Array.isArray(check.warnings)) {
+      for (const warning of check.warnings) if (typeof warning === 'string') lines.push(`Warning: ${id} - ${warning}`);
+    }
     if (effectiveStatus === 'pass' && !isSoftWarning && !isHumanExemptionNotice) continue;
     lines.push(isSoftWarning
       ? `Warning: ${id} (${rawStatus === 'blocked' ? `raw BLOCKED; ` : ''}${reason}) - ${message}; ${action}`

package/lib/task/write.ts

@@ -14,6 +14,7 @@ import type {
   TaskWorkspaceState
 } from './resolve-ref.ts';
 import { mutateTableRow, upsertSection } from './sections.ts';
+import { lifecycleExecutions, prReviewExecution, serializeLifecycleExecution } from './lifecycle-execution.ts';
 import { validateCurrentTaskContract } from './current-contract.ts';
 import type {
   TableRowDeleteMutation,
@@ -24,6 +25,7 @@ type FrontmatterMutation = {
   kind: 'frontmatter';
   set: Readonly<Record<string, FrontmatterScalar>>;
   remove?: readonly string[];
+  lifecycleExecutionDomain?: 'ordinary' | 'pr-review';
 };
 
 type SectionMutation = {
@@ -288,7 +290,16 @@ function writeTaskCore(request: TaskWriteRequest, options: TaskWriteOptions = {}
       }
       const before = candidate;
       if (mutation.kind === 'frontmatter') {
-        candidate = updateTaskFrontmatter(candidate, mutation.set, mutation.remove);
+        let set = mutation.set;
+        if (mutation.lifecycleExecutionDomain) {
+          const proposed = updateTaskFrontmatter(candidate, mutation.set);
+          const open = mutation.lifecycleExecutionDomain === 'ordinary'
+            ? lifecycleExecutions(proposed)
+            : lifecycleExecutions(candidate);
+          const pr = prReviewExecution(mutation.lifecycleExecutionDomain === 'pr-review' ? proposed : candidate);
+          set = { ...mutation.set, lifecycle_execution: serializeLifecycleExecution(open, undefined, pr) };
+        }
+        candidate = updateTaskFrontmatter(candidate, set, mutation.remove);
         operations.push({
           index,
           kind: 'frontmatter',

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@fitlab-ai/agent-infra",
-  "version": "0.12.1",
+  "version": "0.12.2",
   "description": "Bootstrap tool for AI multi-tool collaboration infrastructure — works with Claude Code, Codex, Antigravity CLI, and OpenCode",
   "license": "MIT",
   "type": "module",
@@ -55,7 +55,7 @@
     "@clack/prompts": "1.8.1",
     "@larksuiteoapi/node-sdk": "^1.68.0",
     "cross-spawn": "^7.0.6",
-    "fs-native-extensions": "1.5.1",
+    "fs-native-extensions": "1.5.2",
     "picocolors": "1.1.1",
     "semver": "^7.8.1",
     "smol-toml": "^1.6.1",

package/templates/.agents/README.en.md

@@ -222,16 +222,14 @@ Ordinary `managed` files keep their overwrite semantics. A small set of platform
 
 ## Agent Client Configuration
 
-Use the top-level `.agents/.airc.json` `agentClients` array to configure all five built-in clients (`claude-code`, `codex`, `antigravity-cli`, `opencode`, `traecli`). Each canonical entry has three required fields and one optional orchestration policy:
+Use the top-level `.agents/.airc.json` `agentClients` array to configure all five built-in clients (`claude-code`, `codex`, `antigravity-cli`, `opencode`, `traecli`). Each canonical entry has three required fields:
 
 | Field | Meaning |
 |-------|---------|
 | `id` | Built-in Agent Client id. The canonical array contains exactly one entry for each built-in client. |
 | `enabled` | Whether agent-infra writes and maintains that client's project integration and seed command. |
 | `installInSandbox` | Whether the sandbox image installs that client's CLI. This is independent from `enabled`. |
-| `orchestration` | Optional `run-task` default. It must include executor/reviewer `model` and host-native `reasoningEffort`; both roles may use the same model. |
 
-Explicit `run-task` model/effort flags are atomic: any one requires all four role fields and configuration never fills omissions. With no explicit policy, only the current client's `orchestration` is used. Query model-selection context with `agent-infra-internal agent-client model-selection --client <id>`; it labels results complete, partial, or interactive-only and never presents a local override list as a complete catalog.
 
 Manage these settings without hand-editing JSON:
 

package/templates/.agents/README.zh-CN.md

@@ -228,9 +228,7 @@ disable-model-invocation: true   # 可选；由支持该能力的 TUI 适配器
 | `id` | 内建 Agent Client id。规范数组为每个内建客户端保留且仅保留一个条目。 |
 | `enabled` | agent-infra 是否写入并维护该客户端的项目集成与种子命令。 |
 | `installInSandbox` | 沙箱镜像是否安装该客户端 CLI；此字段与 `enabled` 相互独立。 |
-| `orchestration` | `run-task` 可选默认策略；必须同时提供 executor/reviewer 的 `model` 与宿主原生 `reasoningEffort`，两个角色可以使用同一模型。 |
 
-`run-task` 的显式 model/effort 参数是原子输入：只要提供其中任一字段，就必须完整提供四个 role 字段，不能从配置补齐。完全没有显式策略时，只读取当前客户端的 `orchestration`。模型目录通过 `agent-infra-internal agent-client model-selection --client <id>` 查询，并明确标记 complete、partial 或 interactive-only；局部 override 列表不能当作完整目录。
 
 无需手工编辑 JSON，可使用：
 

package/templates/.agents/rules/README.en.md

@@ -31,7 +31,6 @@ so you can quickly find "which ones to read" without opening each file.
 ## Task Workflow
 
 - [`task-management.md`](task-management.md) — Task intent detection, workflow-command mapping, and skill blocking boundaries.
-- [`lifecycle-orchestration.md`](lifecycle-orchestration.md) — Fresh executor/reviewer, one-use receipt, pause/recovery, and safe endpoint rules for `run-task`.
 - [`review-handshake.md`](review-handshake.md) — Three-stage bidirectional review handshake: four-state disposition, symmetric evidence, disagreement ledger, convergence and post-review commit gate.
 - [`review-method.md`](review-method.md) — Shared three-stage review method: multi-pass review, risk lenses, traceability, and finding evidence.
 - [`local-artifact-repair.md`](local-artifact-repair.md) — Pre-completion local artifact validation for analysis/plan/code and model-per-case repair, safety gates, and convergence for failed review artifacts.

package/templates/.agents/rules/README.zh-CN.md

@@ -30,7 +30,6 @@
 ## 任务工作流
 
 - [`task-management.md`](task-management.md) — 任务语义识别、工作流命令映射与技能阻塞边界。
-- [`lifecycle-orchestration.md`](lifecycle-orchestration.md) — `run-task` 的 fresh executor/reviewer、一次性 receipt、暂停恢复与安全终点规则。
 - [`review-handshake.md`](review-handshake.md) — 三阶段双向审查握手协议：四态处置、对称证据、分歧账本、收敛与 post-review commit 门禁。
 - [`review-method.md`](review-method.md) — 三阶段共享检视方法：多遍检视、风险镜头、追踪与 finding 证据契约。
 - [`local-artifact-repair.md`](local-artifact-repair.md) — analysis/plan/code completed 前的本地产物校验、review artifact 失败后的模型逐例修复、机械安全门与收敛契约。

package/templates/.agents/rules/commit-and-pr.en.md

@@ -10,7 +10,7 @@
 ## Commit Execution Boundary
 
 - Do not run `git add` or `git commit` directly. All automatic commits must use the shared `agent-infra-internal git-workflow commit` core and follow the paths, HEAD/tree, and delivery-mode constraints of the applicable skill.
-- The active workflow defines whether a commit is required. Completing `code-task` requires a local checkpoint through the shared core after tests and report preflight pass. This applies to direct calls and `run-task` orchestration; no extra commit authorization or user confirmation is required.
+- The active workflow defines whether a commit is required. Completing `code-task` requires a local checkpoint through the shared core after tests and report preflight pass. The current code-task invocation calls the shared core.
 - A `code-task` checkpoint never pushes to a remote. Other skills may call the shared core only when their workflow explicitly requires it. The standalone `commit` skill still requires an explicit user invocation and follows its push-delivery flow.
 - Do not create a commit when the workflow does not require one. When a separate user commit is needed, remind the user to use the appropriate TUI command.