@fitchmultz/pi-subagents 0.52.7 → 0.52.8

package/src/pi-intercom/session-targets.ts

@@ -4,12 +4,12 @@ import path from "node:path";
 
 export interface TargetIdentity {
   readonly id: string;
-  readonly name?: string;
+  readonly name?: string | undefined;
 }
 
 export interface ProjectSessionIdentity extends TargetIdentity {
   readonly cwd: string;
-  readonly projectId?: string;
+  readonly projectId?: string | undefined;
 }
 
 export const MIN_SESSION_TARGET_PREFIX_LENGTH = 8;
@@ -170,8 +170,9 @@ export function formatPeerAwarenessHint(
 }
 
 function matchedTargets<T extends TargetIdentity>(matches: readonly T[]): TargetResolution<T> {
-  if (matches.length === 1) {
-    return { status: "found", target: matches[0], matches };
+  const [target] = matches;
+  if (matches.length === 1 && target !== undefined) {
+    return { status: "found", target, matches };
   }
   return matches.length > 1 ? { status: "ambiguous", matches } : { status: "none", matches: [] };
 }

package/src/pi-intercom/tool-registration.ts

@@ -16,6 +16,7 @@ export function registerIntercomTools(
       "Message connected Pi sessions in your group; mains also reach other mains across projects. List shows target IDs. Ask waits for a correlated reply; reply answers the active or sole pending ask. Pending lists asks; status shows connection and inbound queue. Last pages a peer's last completed response without waking it. Broker acceptance is not recipient persistence, consumption or completion.",
     parameters: intercomSchema,
     renderResult: renderCompactResult,
+    // oxlint-disable-next-line max-params
     async execute(_id, params, signal, _update, ctx) {
       const result = throwIfToolError(await tools.execute(params, signal, ctx));
       return { content: [...result.content], details: result.details };

package/src/pi-intercom/tool-results.ts

@@ -33,7 +33,7 @@ export function firstTextContent(result: {
   );
 }
 export class ToolExecutionFailure extends Error {
-  readonly details?: Readonly<Record<string, unknown>>;
+  readonly details?: Readonly<Record<string, unknown>> | undefined;
   constructor(message: string, details?: Readonly<Record<string, unknown>>) {
     super(message);
     this.details = details;

package/src/pi-intercom/types.ts

@@ -16,23 +16,23 @@ export type WakeResult =
 
 export interface SessionInfo {
   readonly id: string;
-  readonly name?: string;
+  readonly name?: string | undefined;
   readonly cwd: string;
   readonly model: string;
   /** Opaque same-repository/worktree identity used for ambient peer awareness. */
-  readonly projectId?: string;
-  readonly rootSessionId?: string;
-  readonly parentSessionId?: string;
-  readonly incarnation?: string;
-  readonly guardedDelivery?: 1;
-  readonly applicationGuard?: string;
-  readonly status?: string;
-  readonly lastSeen?: number;
-  readonly lastIntercomActivity?: number;
-  readonly pendingAsks?: number;
-  readonly acceptsAsks?: boolean;
-  readonly subscriptions?: readonly TopicSubscription[];
-  readonly topics?: readonly TopicUpdate[];
+  readonly projectId?: string | undefined;
+  readonly rootSessionId?: string | undefined;
+  readonly parentSessionId?: string | undefined;
+  readonly incarnation?: string | undefined;
+  readonly guardedDelivery?: 1 | undefined;
+  readonly applicationGuard?: string | undefined;
+  readonly status?: string | undefined;
+  readonly lastSeen?: number | undefined;
+  readonly lastIntercomActivity?: number | undefined;
+  readonly pendingAsks?: number | undefined;
+  readonly acceptsAsks?: boolean | undefined;
+  readonly subscriptions?: readonly TopicSubscription[] | undefined;
+  readonly topics?: readonly TopicUpdate[] | undefined;
 }
 
 export interface TopicSubscription {
@@ -102,10 +102,10 @@ export interface DeliveryGuard extends ContextTarget {
 export interface PublicationReplyHint {
   readonly tool: string;
   readonly commandId: string;
-  readonly commandFingerprint?: string;
+  readonly commandFingerprint?: string | undefined;
 }
 export type SendOptions = Omit<Message, "id" | "timestamp" | "content"> &
-  Message["content"] & { readonly messageId?: string };
+  Message["content"] & { readonly messageId?: string | undefined };
 export function isContextTarget(value: unknown): value is ContextTarget {
   return (
     isRecord(value) &&
@@ -150,20 +150,20 @@ export function isHumanMessageOrigin(value: unknown): value is HumanMessageOrigi
 export interface Message {
   readonly id: string;
   readonly timestamp: number;
-  readonly replyTo?: string;
-  readonly expectsReply?: boolean;
+  readonly replyTo?: string | undefined;
+  readonly expectsReply?: boolean | undefined;
   /** Recipients verify parent ownership before elevating human origin. */
-  readonly human?: HumanMessageOrigin;
-  readonly topic?: TopicUpdate;
-  readonly delivery?: MessageDelivery;
-  readonly queueMode?: QueueMode;
-  readonly threadId?: string;
-  readonly passive?: boolean;
-  readonly guard?: DeliveryGuard;
-  readonly replyHint?: PublicationReplyHint;
+  readonly human?: HumanMessageOrigin | undefined;
+  readonly topic?: TopicUpdate | undefined;
+  readonly delivery?: MessageDelivery | undefined;
+  readonly queueMode?: QueueMode | undefined;
+  readonly threadId?: string | undefined;
+  readonly passive?: boolean | undefined;
+  readonly guard?: DeliveryGuard | undefined;
+  readonly replyHint?: PublicationReplyHint | undefined;
   readonly content: {
     readonly text: string;
-    readonly attachments?: readonly Attachment[];
+    readonly attachments?: readonly Attachment[] | undefined;
   };
 }
 export interface Attachment {
@@ -378,26 +378,31 @@ export interface SessionSnapshot {
 }
 
 type CompactTopicMessage = Omit<Message, "topic"> & {
-  readonly topic?: Omit<TopicUpdate, "text"> & { readonly text?: string };
+  readonly topic?: (Omit<TopicUpdate, "text"> & { readonly text?: string | undefined }) | undefined;
 };
 /** Topic text and the standard coalescing key need only one copy on the wire. */
 export function compactTopicMessage(message: Message): CompactTopicMessage {
   if (!message.topic) {
     return message;
   }
+  const { threadId, ...rest } = message;
+  const dropThreadId =
+    message.queueMode === "replace" && threadId === `topic:${message.topic.topic}`;
   return {
-    ...message,
+    ...rest,
     topic:
-      message.topic.text === message.content.text
-        ? { ...message.topic, text: undefined }
-        : message.topic,
-    threadId:
-      message.queueMode === "replace" && message.threadId === `topic:${message.topic.topic}`
-        ? undefined
-        : message.threadId,
+      message.topic.text === message.content.text ? withoutTopicText(message.topic) : message.topic,
+    ...(dropThreadId || threadId === undefined ? {} : { threadId }),
   };
 }
 
+function withoutTopicText(
+  topic: TopicUpdate,
+): Omit<TopicUpdate, "text"> & { readonly text?: string | undefined } {
+  const { text: _duplicate, ...rest } = topic;
+  return rest;
+}
+
 export function normalizeMessage(value: unknown): Message | null {
   if (isMessage(value)) {
     return value;
@@ -424,9 +429,9 @@ export function normalizeMessage(value: unknown): Message | null {
 }
 
 export interface LastMessageQuery {
-  readonly entryId?: string;
-  readonly offset?: number;
-  readonly limit?: number;
+  readonly entryId?: string | undefined;
+  readonly offset?: number | undefined;
+  readonly limit?: number | undefined;
 }
 
 export const LAST_MESSAGE_PAGE_LIMIT = 16384;
@@ -468,13 +473,13 @@ export interface NativeReceipt extends ReceiptQuery {
   readonly version: 1;
   readonly sender: {
     readonly peerId: string;
-    readonly rootSessionId?: string;
-    readonly incarnation?: string;
+    readonly rootSessionId?: string | undefined;
+    readonly incarnation?: string | undefined;
   };
   readonly textSha256: string;
   readonly delivery: MessageDelivery;
-  readonly guard?: DeliveryGuard;
-  readonly replyHint?: PublicationReplyHint;
+  readonly guard?: DeliveryGuard | undefined;
+  readonly replyHint?: PublicationReplyHint | undefined;
   readonly checkpointEntryId: string;
   readonly receivedAt: number;
   /** Historical observations, not a promise that an input is still queued. */

package/src/shared/journal-frames.ts

@@ -13,7 +13,7 @@ export interface JournalOptions {
   readonly requireNewline?: boolean;
   readonly start?: number;
   readonly end?: number;
-  readonly stringChunk?: StringChunk;
+  readonly stringChunk?: StringChunk | undefined;
 }
 
 /** Byte-framed JSONL. Publication framing is independent of malformed-record tolerance. */

package/src/shared/json-projection.ts

@@ -12,7 +12,7 @@ export type StringChunk = (
 ) => void;
 interface Container {
   readonly path: readonly (string | number)[];
-  readonly value?: Record<string, unknown> | unknown[];
+  readonly value?: Record<string, unknown> | unknown[] | undefined;
   readonly array: boolean;
   key: string;
   index: number;
@@ -95,7 +95,7 @@ export class JsonProjection {
   private text = "";
   private numberState = 0;
   private readonly select: Projection;
-  private readonly stringChunk?: StringChunk;
+  private readonly stringChunk?: StringChunk | undefined;
   private readonly keys: KeyLimit;
   value: unknown;
   constructor(select: Projection, stringChunk?: StringChunk, keys: KeyLimit = () => 4096) {

package/src/shared/native-journal.ts

@@ -8,8 +8,8 @@ import { isRecord, type UnknownRecord } from "./unknown.ts";
 export interface NativePreview extends UnknownRecord {
   readonly id: string;
   readonly type: string;
-  readonly parentId?: string | null;
-  readonly timestamp?: string;
+  readonly parentId?: string | null | undefined;
+  readonly timestamp?: string | undefined;
 }
 export interface NativeRecord extends JournalRecord {
   readonly value: NativePreview;

package/src/shared/output-page.ts

@@ -1,7 +1,7 @@
 import * as fs from "node:fs";
 interface OutputPageOptions {
-  readonly offset?: number;
-  readonly length?: number;
+  readonly offset?: number | undefined;
+  readonly length?: number | undefined;
 }
 function pageLength(options: OutputPageOptions): number {
   const length = options.length ?? 64 * 1024;
@@ -40,7 +40,7 @@ function utf8Bounds(bytes: Buffer, count: number, more: boolean): { start: numbe
       last--;
     }
     const lead = bytes[last];
-    if (last + width(lead) > end) {
+    if (lead === undefined || last + width(lead) > end) {
       end = last;
     }
   }

package/src/shared/post-exit-stdio-guard.ts

@@ -9,7 +9,7 @@ const BIRTH_FIELDS = ["lstart=", "pgid="];
 export const PS_COMMAND = process.platform === "darwin" ? "/bin/ps" : "ps";
 
 interface AgentProcessExit {
-  readonly pid?: number;
+  readonly pid?: number | undefined;
   readonly code: number | null;
   readonly signal: NodeJS.Signals | null;
   readonly at: number;
@@ -22,7 +22,7 @@ interface ChildWithPipedStdio {
 }
 
 interface ChildWithKill {
-  readonly pid?: number;
+  readonly pid?: number | undefined;
   readonly kill: (signal?: NodeJS.Signals | number) => boolean;
 }
 
@@ -265,8 +265,8 @@ class OwnedChildLifecycle implements ChildProcessLifecycle {
   private isStopping = false;
   private isSettledCleanup = false;
   private exit?: AgentProcessExit;
-  private drainTimer?: NodeJS.Timeout;
-  private escalationTimer?: NodeJS.Timeout;
+  private drainTimer?: NodeJS.Timeout | undefined;
+  private escalationTimer?: NodeJS.Timeout | undefined;
   private readonly child: ChildWithPipedStdio & ChildWithKill;
   private readonly clearStdioGuard: () => void;
   constructor(child: ChildWithPipedStdio & ChildWithKill) {

package/tsconfig.json

@@ -16,7 +16,14 @@
     "allowJs": true,
     "checkJs": false,
     "types": ["node"],
-    "noUnusedLocals": true
+    "noUnusedLocals": true,
+    "noFallthroughCasesInSwitch": true,
+    "noImplicitOverride": true,
+    "noUncheckedIndexedAccess": true,
+    "exactOptionalPropertyTypes": true,
+    "noUncheckedSideEffectImports": true,
+    "forceConsistentCasingInFileNames": true,
+    "noCheck": false
   },
   "include": [
     "**/*.ts",