@fitchmultz/pi-subagents 0.52.2 → 0.52.3

package/src/pi-intercom/bridge-mailbox.ts

@@ -196,14 +196,24 @@ export class Mailbox {
   }
   ack(ids: readonly string[]): UnknownRecord {
     const acked: string[] = [];
-    for (const id of ids) {
-      const entry = this.get(id);
-      if (entry) {
-        this.notificationAccepted(id);
-        this.remove(id);
-        acked.push(id);
+    this.stored(() => {
+      // One FULL commit per ACK group; a rollback leaves every listed payload and intent pending.
+      this.db?.exec("BEGIN IMMEDIATE");
+      try {
+        for (const id of ids) {
+          const entry = this.get(id);
+          if (entry) {
+            this.notificationAccepted(id);
+            this.remove(id);
+            acked.push(id);
+          }
+        }
+        this.db?.exec("COMMIT");
+      } catch (error) {
+        this.db?.exec("ROLLBACK");
+        throw error;
       }
-    }
+    });
     return { acked };
   }
   page(after: number, limit: number): InboxPage {

package/src/pi-intercom/bridge-wake.ts

@@ -138,21 +138,20 @@ export class WakeDeliveries {
 
   private pending(delivery: Delivery): PendingNotification | undefined {
     let after = 0;
-    let next: PendingNotification | undefined;
     let page;
     do {
-      page = delivery.mailbox.pendingNotifications(after);
+      // Decode only the retired prefix and the oldest actionable entry, not the whole backlog.
+      page = delivery.mailbox.pendingNotifications(after, 1);
       for (const entry of page.messages) {
-        if (!actionable(entry)) {
-          // Retire only notification intent. Payload/reply obligations require actual ACK/reply.
-          delivery.mailbox.notificationAccepted(entry.message.id);
-        } else if (!next) {
-          next = entry;
+        if (actionable(entry)) {
+          return entry;
         }
+        // Retire only notification intent. Payload/reply obligations require actual ACK/reply.
+        delivery.mailbox.notificationAccepted(entry.message.id);
       }
       after = Number(page.nextCursor);
     } while (page.hasMore);
-    return next;
+    return undefined;
   }
 
   private groups(): Map<string, Candidate | undefined> {

package/src/pi-intercom/inbound-journal.ts

@@ -8,7 +8,12 @@ import {
   type InboundMessageEntry,
   type PendingInboundMessage,
 } from "./runtime-types.ts";
-import { isInboundCheckpoint, publicationMetadata, requestedDelivery } from "./inbound-record.ts";
+import {
+  checkpointMessageId,
+  isInboundCheckpoint,
+  publicationMetadata,
+  requestedDelivery,
+} from "./inbound-record.ts";
 import {
   isReceiptQuery,
   type NativeReceipt,
@@ -66,6 +71,7 @@ export class InboundJournal {
     if (
       item.type === "custom" &&
       item.customType === INBOUND_CHECKPOINT_TYPE &&
+      checkpointMessageId(item.data) === query.messageId &&
       isInboundCheckpoint(item.data) &&
       item.data.sessionId === query.rootSessionId
     ) {
@@ -82,7 +88,7 @@ export class InboundJournal {
     data: InboundCheckpoint,
   ): NativeReceipt | undefined {
     if ("entry" in data) {
-      if (receipt || data.entry.message.id !== query.messageId) {
+      if (receipt) {
         return receipt;
       }
       const { from, message, stage, receivedAt } = data.entry;
@@ -106,7 +112,7 @@ export class InboundJournal {
         discarded: false,
       };
     }
-    if (!receipt || data.messageId !== query.messageId) {
+    if (!receipt) {
       return receipt;
     }
     return {

package/src/pi-intercom/inbound-record.ts

@@ -97,3 +97,15 @@ export function isInboundCheckpoint(
       value.stage === "reply-retired")
   );
 }
+/** Unvalidated: lets a receipt skip checkpoints for other messages before full validation. */
+export function checkpointMessageId(value: unknown): unknown {
+  if (!isRecord(value)) {
+    return;
+  }
+  if ("entry" in value) {
+    return isRecord(value.entry) && isRecord(value.entry.message)
+      ? value.entry.message.id
+      : undefined;
+  }
+  return value.messageId;
+}

package/src/pi-intercom/ui/session-format.ts

@@ -11,10 +11,19 @@ function localForkStartCommand(): string {
   return `pi --name worker --extension ${shellQuote(path.join(PACKAGE_ROOT, "src", "index.ts"))}`;
 }
 function duplicateNames(sessions: readonly SessionInfo[]): ReadonlySet<string> {
-  const names = sessions
-    .map((session) => session.name?.toLowerCase())
-    .filter((name): name is string => name !== undefined && name !== "");
-  return new Set(names.filter((name, index) => names.indexOf(name) !== index));
+  const seen = new Set<string>();
+  const duplicates = new Set<string>();
+  for (const session of sessions) {
+    const name = session.name?.toLowerCase();
+    if (name === undefined || name === "") {
+      continue;
+    }
+    if (seen.has(name)) {
+      duplicates.add(name);
+    }
+    seen.add(name);
+  }
+  return duplicates;
 }
 export function formatDuration(seconds: number): string {
   if (seconds < 60) {
@@ -79,7 +88,7 @@ function healthTags(session: SessionInfo, now: number): readonly string[] {
 interface RowOptions {
   readonly currentCwd: string;
   readonly self: boolean;
-  readonly duplicates: (name: string) => boolean;
+  readonly duplicates: ReadonlySet<string>;
   readonly allSessions: readonly SessionInfo[];
   readonly now: number;
 }
@@ -88,7 +97,7 @@ function row(session: SessionInfo, options: RowOptions): string {
   const duplicate =
     session.name !== undefined &&
     session.name !== "" &&
-    options.duplicates(session.name.toLowerCase());
+    options.duplicates.has(session.name.toLowerCase());
   let location: string | undefined;
   if (options.self) {
     location = "self";
@@ -132,7 +141,7 @@ export function formatSessionListSections(
   const others = scoped.filter((session) => session.id !== id);
   const options = {
     currentCwd: current.cwd,
-    duplicates: (name: string) => duplicateNames(allSessions).has(name),
+    duplicates: duplicateNames(allSessions),
     allSessions,
     now: Date.now(),
   };