@fitchmultz/pi-subagents 0.52.16 → 0.52.17

package/CHANGELOG.md

@@ -2,6 +2,19 @@
 
 ## [Unreleased]
 
+## 0.52.17 - 2026-11-05
+
+<!-- npm-release:unreleased:start -->
+<!-- npm-release:unreleased:end -->
+
+- Adopt strict Oxlint/Oxfmt v5.2 without finding baselines (#339) ([8de822c](https://github.com/fitchmultz/pi-subagents/commit/8de822c14a56fdad3e13961abb02a106dac71a4f))
+
+### What's Changed
+
+- Adopt strict Oxlint/Oxfmt v5.2 without finding baselines by @fitchmultz in https://github.com/fitchmultz/pi-subagents/pull/339
+
+**Full Changelog**: https://github.com/fitchmultz/pi-subagents/compare/v0.52.16...v0.52.17
+
 ## 0.52.16 - 2026-11-03
 
 <!-- npm-release:unreleased:start -->

package/dist/agent/host.js

@@ -75,7 +75,7 @@ export async function loadSDK(root) {
         return resolvedSDK;
     }
     // Selected host SDK, not a second package-local runtime hidden behind Jiti aliases.
-    // oxlint-disable-next-line typescript/no-unsafe-assignment
+    // oxlint-disable-next-line typescript/no-unsafe-assignment -- QX-004: selected host module must retain its runtime identity.
     const sdk = await import(__rewriteRelativeImportExtension(pathToFileURL(path.join(root, "dist/index.js")).href));
     return sdk;
 }

package/dist/agent/notifications.js

@@ -5,17 +5,19 @@ import { readOutputPage } from "../shared/output-page.js";
 import { journalStamp } from "../shared/native-journal.js";
 import { launchAt, list, runDirectory } from "./storage.js";
 import { readCanonicalResult, readResult } from "./usage.js";
+function isStringSet(value) {
+    if (!(value instanceof Set)) {
+        return false;
+    }
+    const entries = value;
+    return [...entries].every((entry) => typeof entry === "string");
+}
 function queuedAdmissions() {
     const store = globalThis;
     const existing = store.__pi_single_agent_admissions__;
-    if (existing instanceof Set) {
-        const values = existing;
-        const strings = [...values].filter((value) => typeof value === "string");
-        if (strings.length === values.size) {
-            // Keep one live queue identity across native extension reloads.
-            // oxlint-disable-next-line typescript/no-unsafe-return
-            return existing;
-        }
+    if (isStringSet(existing)) {
+        // Keep one live queue identity across native extension reloads.
+        return existing;
     }
     const queued = new Set();
     store.__pi_single_agent_admissions__ = queued;

package/dist/agent/observe-layout.js

@@ -19,11 +19,11 @@ if (manifest === undefined) {
     throw new Error("Cannot locate the native Pi TUI package.");
 }
 const root = pathToFileURL(path.join(path.dirname(manifest), "dist/index.js"));
-// oxlint-disable-next-line typescript/no-unsafe-assignment
+// oxlint-disable-next-line typescript/no-unsafe-assignment -- QX-004: resolve the selected host TUI, not a second package instance.
 const tuiPromise = import(__rewriteRelativeImportExtension(root.href));
-// oxlint-disable-next-line typescript/no-unsafe-assignment
+// oxlint-disable-next-line typescript/no-unsafe-assignment -- QX-004: layout must share the selected host TUI instance.
 const layoutPromise = import(__rewriteRelativeImportExtension(new URL("./layout.js", root).href));
-// oxlint-disable-next-line typescript/no-unsafe-assignment
+// oxlint-disable-next-line typescript/no-unsafe-assignment -- QX-004: dispatch must share the selected host TUI instance.
 const dispatchPromise = import(__rewriteRelativeImportExtension(new URL("./tui.js", root).href));
 const [tui, layout, dispatch, sdk] = await Promise.all([
     tuiPromise,

package/dist/agent/parking.js

@@ -297,7 +297,6 @@ async function awaitWake(base, launch, signal, legacy) {
                 throw new Error(failure);
             }
             // DirectoryWatch reconciles dropped hints without imposing a deadline on native startup.
-            // oxlint-disable-next-line no-await-in-loop
             await wake.sleep(200);
         }
     }

package/dist/agent/process.js

@@ -38,9 +38,7 @@ export async function observeAlive(identities) {
     for (const claim of identities) {
         // One `ps` at a time: each spawn briefly holds the event loop, so concurrent spawns add up.
         const { pid, identity, clock } = claim;
-        verdicts.push(probe(claim) ??
-            // oxlint-disable-next-line no-await-in-loop
-            !(await observeChildProcessReplaced(pid, identity, claim.published, clock)));
+        verdicts.push(probe(claim) ?? !(await observeChildProcessReplaced(pid, identity, claim.published, clock)));
     }
     return verdicts;
 }
@@ -198,7 +196,6 @@ async function awaitStopping(dir, existing, signal) {
                 throw new Error("Previous actor is still stopping; no replacement was launched.");
             }
             // The old actor must actually exit before replacing its generation.
-            // oxlint-disable-next-line no-await-in-loop
             await delay(25);
         }
     }

package/dist/agent/runner.js

@@ -310,13 +310,11 @@ class Actor {
                     this.retry = false;
                     this.pending().forEach((command) => this.accept(command));
                 }
-                // oxlint-disable-next-line no-await-in-loop
                 if (await this.park(runtime, parked)) {
                     return;
                 }
                 const polling = this.retry || this.stopping || watch === "unwatched";
                 const tick = Math.max(1, this.nextParentCheck - performance.now());
-                // oxlint-disable-next-line no-await-in-loop
                 await this.wake.sleep(polling ? 100 : tick);
             }
         }

package/dist/agent/shutdown.js

@@ -37,7 +37,6 @@ async function waitForExit(targets, timeout) {
     const deadline = Date.now() + timeout;
     while (Date.now() < deadline && targets.some(alive)) {
         // Join actual process exit while native abort persists the interrupted turn.
-        // oxlint-disable-next-line no-await-in-loop
         await delay(25);
     }
 }

package/dist/agent/typebox.js

@@ -13,11 +13,11 @@ import { isChild, packageRoot } from "./host.js";
 // Pi aliases these imports to its own instance (including bundled virtual modules).
 // Only the detached runner needs absolute imports from the selected host package.
 const require = isChild() ? createRequire(path.join(packageRoot(), "dist/index.js")) : undefined;
-// oxlint-disable-next-line typescript/no-unsafe-assignment
+// oxlint-disable-next-line typescript/no-unsafe-assignment -- QX-004: detached runners resolve the selected host schema instance.
 const typeboxPromise = require === undefined
     ? import("typebox")
     : import(__rewriteRelativeImportExtension(pathToFileURL(require.resolve("typebox")).href));
-// oxlint-disable-next-line typescript/no-unsafe-assignment
+// oxlint-disable-next-line typescript/no-unsafe-assignment -- QX-004: validation must use the selected host schema instance.
 const valuePromise = require === undefined
     ? import("typebox/value")
     : import(__rewriteRelativeImportExtension(pathToFileURL(require.resolve("typebox/value")).href));

package/dist/build-info.js

@@ -1 +1 @@
-export const EXTENSION_BUILD = Object.freeze({"version":"0.52.16","sha256":"ec0886af93d91687cfae1ed692e1e2e31127d3fbf98abadf192034a044e44d51"});
+export const EXTENSION_BUILD = Object.freeze({"version":"0.52.17","sha256":"b18d11c5a8e05e11577a3347c2d40808b644af0b5bd5248f4a3314d68c97a640"});

package/dist/pi-intercom/bridge-presence.js

@@ -88,7 +88,6 @@ export class PersistentPresence {
             }
             try {
                 // Each identity has one connection attempt; preserve the native broker's spawn safeguards.
-                // oxlint-disable-next-line no-await-in-loop
                 await this.owner.connect(identity, registration.expires);
             }
             catch {

package/dist/pi-intercom/bridge-protocol.js

@@ -25,7 +25,6 @@ export function object(value, fields) {
 }
 export function label(value, field, max = 512) {
     // Labels are single-line identifiers and paths; reject C0/C1 controls and DEL.
-    // oxlint-disable-next-line no-control-regex
     const controls = /[\u0000-\u001f\u007f-\u009f]/;
     if (typeof value !== "string" ||
         value.trim() === "" ||
@@ -37,7 +36,6 @@ export function label(value, field, max = 512) {
 }
 export function text(value) {
     // Message text permits tab/newline/CR, but rejects other C0/C1 controls and DEL.
-    // oxlint-disable-next-line no-control-regex
     const controls = /[\u0000-\u0008\u000b\u000c\u000e-\u001f\u007f-\u009f]/;
     if (typeof value !== "string" || value.trim() === "" || controls.test(value)) {
         throw new Fault(400, "invalid_input", "Invalid message.");

package/dist/pi-intercom/bridge-session.js

@@ -303,7 +303,6 @@ export class Session {
             log("inbox_wait", { ...this.fields(), requestId: context.requestId, after: operation.after });
             try {
                 // A nonmatching commit must rearm the same cursor, not start parallel readers.
-                // oxlint-disable-next-line no-await-in-loop
                 await delay(remaining, undefined, { signal });
             }
             catch (error) {

package/dist/pi-intercom/bridge-wake.js

@@ -167,7 +167,6 @@ export class WakeDeliveries {
             // ponytail: two cold Macs can each admit one wake. Literal cross-Mac single admission
             // requires a neutral quota authority governing every writer, not a URL hash or HTTP 2xx.
             try {
-                // oxlint-disable-next-line no-await-in-loop
                 await this.post(candidate);
             }
             finally {

package/dist/pi-intercom/broker/client.js

@@ -148,12 +148,10 @@ export class IntercomClient extends EventEmitter {
     async restoreTopics(topics, subscriptions) {
         for (const topic of topics ?? []) {
             // Restore frames are individually acknowledged to preserve order and bound socket payloads.
-            // oxlint-disable-next-line no-await-in-loop
             await this.updateTopics({ action: "restore", topic });
         }
         for (const subscription of subscriptions ?? []) {
             // Subscriptions are committed before connect resolves and subsequent messages can arrive.
-            // oxlint-disable-next-line no-await-in-loop
             await this.updateTopics({ action: "restore", subscription });
         }
     }

package/dist/pi-intercom/broker/spawn.js

@@ -138,7 +138,6 @@ async function previousBrokerWarning() {
     const previousSockets = getPreviousBrokerSocketPaths();
     for (const socketPath of previousSockets) {
         // Migration probes are sequential and never register or send to old peers.
-        // oxlint-disable-next-line no-await-in-loop
         if (isOwnedBrokerSocket(socketPath) && (await checkOneSocket(socketPath))) {
             return "An older agent-directory Intercom broker is still running. Its peers are not part of shared same-user discovery until they reload with the updated extension. Existing sessions and accepted work are untouched; no legacy fallback is used.";
         }
@@ -240,12 +239,10 @@ async function waitForBroker(timeoutMs = 5000) {
     const start = Date.now();
     while (Date.now() - start < timeoutMs) {
         // Each probe must finish before the next to avoid parallel socket attempts.
-        // oxlint-disable-next-line no-await-in-loop
         if (await checkSocketConnectable()) {
             return;
         }
         // Polling waits between probes rather than starting an unbounded batch.
-        // oxlint-disable-next-line no-await-in-loop
         await sleep(100);
     }
     throw new Error("Broker failed to start within timeout");

package/dist/pi-intercom/tool-registration.js

@@ -9,8 +9,7 @@ export function registerIntercomTools(pi, tools) {
         description: "Message connected Pi sessions in your group; mains also reach other mains across projects. List shows target IDs. Ask waits for a correlated reply; reply answers the active or sole pending ask. Pending lists asks; status shows connection and inbound queue. Last pages a peer's last completed response without waking it. Broker acceptance is not recipient persistence, consumption or completion.",
         parameters: intercomSchema,
         renderResult: renderCompactResult,
-        // oxlint-disable-next-line max-params
-        async execute(_id, params, signal, _update, ctx) {
+        async execute(...[, params, signal, , ctx]) {
             const result = throwIfToolError(await tools.execute(params, signal, ctx));
             return { content: [...result.content], details: result.details };
         },

package/dist/pi-intercom/validation.js

@@ -34,10 +34,8 @@ export function asError(error) {
     return error instanceof Error ? error : new Error(errorMessage(error));
 }
 // Protocol text permits line feeds and tabs, but rejects other C0/C1 controls.
-// oxlint-disable-next-line no-control-regex
 const UNSAFE_TEXT_CONTROLS = /[\u0000-\u0008\u000b\u000c\u000e-\u001f\u007f-\u009f]/;
 // Protocol labels are single-line fields and reject every C0/C1 control.
-// oxlint-disable-next-line no-control-regex
 const UNSAFE_LABEL_CONTROLS = /[\u0000-\u001f\u007f-\u009f]/;
 export function safeText(value) {
     return typeof value === "string" && !UNSAFE_TEXT_CONTROLS.test(value);

package/dist/shared/cooperative.js

@@ -14,7 +14,6 @@ export async function runCooperatively(steps) {
         // single-record stall off-thread rather than increasing this batch size.
         if (++count === 32) {
             // Yield between ordered atomic recovery records; concurrency would reorder delivery.
-            // oxlint-disable-next-line no-await-in-loop
             await yieldToInput();
             count = 0;
         }

package/docs/code-quality.md

@@ -1,85 +1,113 @@
 # Code quality
 
-Oxlint checks maintained TypeScript and JavaScript. Oxfmt owns formatting.
-Both tools use the committed npm versions and repository configuration.
+The [Strict Oxlint/Oxfmt Engineering Standard v5.2](strict-oxlint-oxfmt-standard.md)
+owns the policy. [Quality exceptions](quality-exceptions.md) records the few
+operations that require different treatment. No finding budget or suppression
+baseline is accepted.
+
+## Commands
+
+Use the committed npm lockfile. Local checks are:
 
 ```sh
 npm ci --ignore-scripts
 npm run lint
-npm run lint:fix
-npm run format
 npm run format:check
 npm run typecheck
-npm run ci
+npm run typecheck:declarations
+npm run check:quality
+npm run build
 ```
 
-Lint rejects unsafe types, unchecked assertions, floating promises, accidental
-mutation, import cycles and ambiguous control flow. Application readonly types
-remain checked by TypeScript. `typescript/prefer-readonly-parameter-types` is
-disabled: the published backend cannot express the existing native SDK aliases
-with package-scoped allowances. The project does not patch the checker or add
-production wrappers to satisfy that rule.
+`npm run lint:fix` and `npm run format` are writing conveniences.
+`npm run lint:agent` is another output format for the same lint gate.
 
-Production limits are complexity 10, depth 3, parameters 4, statements 40,
-function lines 80 and file lines 500, excluding blank lines and comments.
-Tests retain complexity 15, depth 4 and parameters 6. Cohesive test suites have
-no size or statement limits.
+Full `npm run ci` remains hosted-only. It runs each independent gate even when
+another fails: native lint, format, implementation types, handwritten declaration
+types, policy and coverage, package size, package/install smokes, unit tests, and
+integration tests. Package smokes build the actual artifacts before testing them.
+The aggregate fails if any gate fails.
+
+CI qualifies official Pi on Linux and the maintained fork on Linux and macOS.
+Those are distinct runtime graphs, not interchangeable version labels. Android
+has no published oxlint-tsgolint backend; native semantic qualification runs on
+a supported host. A skipped local native probe is not hosted acceptance.
+
+## Coverage and enforcement
+
+`quality/check.ts` compares the effective policy with the normative JSON in the
+standard and the explicit repository mappings. It checks native lint membership,
+resolved compiler membership, formatter ownership, and required command scope.
+The inventory includes ignored files outside generated, dependency, and private
+runtime trees, so hiding maintained code with a Git ignore does not exempt it.
+
+The compiler's own resolution checks production dependencies on test support,
+including aliases, re-exports, and literal dynamic imports. Oxc's parser identifies
+actual comments and operation-bound directives. Strings containing example
+directives are data. Copied, moved, duplicate, stale, and wrong-operation
+directives fail; unused directives also fail native lint.
+
+The source profiles are:
 
-Formatting uses width 100, two spaces, LF and double quotes. npm owns lockfile
-formatting. Build outputs keep their own bytes.
-The VS Code Oxc extension uses these same lint and formatting configurations.
+- `src/**`, `scripts/**`, `quality/**`, and `.github/scripts/**` are production
+  implementation. Mixed-use helpers retain that profile.
+- `test/**` contains tests, fixtures, and exclusively test-used support.
+- `*.test-d.{ts,mts,cts}` are compiler-checked negative consumer contracts with
+  explained expected failures and passing counterparts.
+- Handwritten `*.d.{ts,mts,cts}` files receive the declaration profile and an
+  actual `skipLibCheck:false` check through `quality/declarations.ts`.
 
-`npm run ci` runs lint, formatting, TypeScript, package/install smokes and all
-tests. CI separately qualifies the latest official Pi on GitHub-hosted Linux and
-the maintained fork on Linux and macOS. There is no custom checker build, probe
-suite or self-hosted runner requirement.
+The root `tsconfig.json` checks all maintained TS and JS with the full required
+strict options. The application retains `skipLibCheck:true` because the installed
+SDK dependency closure includes incompatible third-party declaration imports.
+The declaration gate checks any handwritten declarations and their real dependency
+closure without that option or permissive stubs. There are currently no handwritten
+declaration files.
 
-CI's lint job also enforces the production byte ceiling before qualification
-substitutes the selected host graph. The retired workflow schema generator and
-its patching dependency are not part of the new runtime. `npm run check:size`
-still reports source and production line counts for visibility; no line count
-is mandated. The 1 MiB byte ceiling and all lint limits stay unchanged.
+`tsconfig.build.json` and `tsconfig.client.json` are emission configurations, not
+substitutes for the checked root project. Build-swap tests, packed-consumer type
+tests, and actual package/native-install smokes verify their outputs.
+
+Production limits are complexity 10, depth 3, parameters 4, statements 40,
+function lines 80, and file lines 500. Tests retain complexity 15, depth 4, and
+parameters 6 without statement or line limits. These are the standard's profiles,
+not local exceptions. There is no React, DOM JSX, Jest, or Vitest implementation;
+Node's test runner owns execution. A real failing assertion is qualified through
+the repository test command.
+
+Oxfmt owns supported maintained files, with width 100, two spaces, LF, double
+quotes, and no import/package/Tailwind/JSDoc transformations. npm owns
+`package-lock.json`; the build owns `dist/**` and temporary publication trees.
+Captured `docs/evidence/*.log` files retain original command bytes. Git, Pi state,
+dependency trees, npm cache, and OS metadata are not maintained source.
+No committed generated output requires a separate freshness generator.
+
+The existing viewer import restriction remains: lazy viewer values must come
+from the selected host through `observe-layout.ts`. It strengthens the base
+policy and protects runtime identity. The existing 1 MiB production-byte ceiling
+also remains. Neither is a new requirement of this standard.
 
 ## Adoption record
 
-Repository: `fitchmultz/pi-subagents`. Adopted standard: strict Oxlint/Oxfmt
-engineering standard v5.1.2, kept as the repository copy at
-`docs/strict-oxlint-oxfmt-standard.md`. Exception records live in
-[Quality exceptions](quality-exceptions.md) and follow the standard's Appendix B.
-
-Supported runtime and package manager: Node `>=24.21.0` with npm and the
-committed lockfile. Installed tool versions (devDependencies): oxlint 1.90.0,
-oxlint-tsgolint 7.0.2005, oxfmt 0.75.0, `@types/node` 24.19.2, typebox 1.4.3.
-
-Configuration and acceptance paths: lint `.oxlintrc.json`, formatting
-`.oxfmtrc.json`, compiler `tsconfig.json`. Local acceptance commands are
-`npm run lint`, `npm run format:check` and `npm run typecheck`; the aggregate
-acceptance command is hosted `npm run ci` (lint, formatting, TypeScript, byte
-ceiling, package/install smokes and the complete test suites, plus separate
-official-Pi and fork qualification jobs).
-
-Compiler projects and source profiles: one `tsc --noEmit` project covers all
-maintained TypeScript and checked-JavaScript (`src`, `scripts`, `test`,
-`.github`) with `strict`, `checkJs`, `noUncheckedIndexedAccess`,
-`exactOptionalPropertyTypes` and the full strict flag set. Lint profiles:
-production limits (complexity 10, depth 3, parameters 4, statements 40,
-function lines 80, file lines 500), test/fixture limits (complexity 15, depth
-4, parameters 6, no size limits) and declaration files with size limits off.
-
-Formatter and generator ownership: oxfmt formats all maintained source at
-width 100; npm owns lockfile formatting; build outputs keep their own bytes.
-
-Migration status: complete. The toolchain, baseline configuration, strict
-TypeScript compiler options, checked-JavaScript coverage and this records
-policy landed as PRs #319, #320, #321, #325 and the records PR; the policy
-integrity keeper `test/unit/strict-oxlint-policy.test.ts` pins the effective
-configuration, the four-entry overrides inventory and the directive rule-name
-inventory against drift.
-
-Integrated verification: hosted `npm run ci` on the merge of each part, with
-the single-agent-runtime, agent-receipts, pi-intercom-native-replay and
-retired-history-archive keepers exercising the native contracts. Locally
-verified state for the checked-JavaScript part is recorded in PR #325; the
-retired-history-archive suite requires passwordless `sudo` and
-`scripts/package-smoke.mjs` requires a short Unix socket directory, so hosted
-CI is the authoritative gate for both.
+Repository: `fitchmultz/pi-subagents`. Standard: v5.2, 3 November 2026.
+Runtime: Node `>=24.21.0`, npm, committed lockfile.
+Qualified tools: Oxlint 1.91.0, oxlint-tsgolint 7.0.2006, Oxfmt 0.76.0,
+TypeScript 7.0.2, oxc-parser 0.157.0, and `@types/node` 24.19.2.
+
+The adoption starts at `7f449e2dcc8e7e82432bea79a2709f0b49256239`.
+The adoption PR records the exact integrated head and hosted results; CI verifies
+the source SHA before qualification. Local M1 evidence uses Node 24.22.1 and
+official Pi 1.5.0; separate native fork coverage runs against its selected graph.
+
+Qualification lives in `strict-oxlint-qualification.test.ts`,
+`lint-node-test-allowance.test.ts`, `quality-coverage.test.ts`,
+`strict-oxlint-policy.test.ts`, and `quality-acceptance.test.ts`.
+These cover semantic and category rules, all six structural boundaries, Node
+registration origins, operation attachment, strict JS/TS/declaration checking,
+formatting idempotence, coverage omissions, and acceptance exit propagation.
+The adoption also exercised each aggregate gate's failure independently; ordinary
+regression coverage retains one representative failure plus the all-green case.
+
+The policy and source repairs are integrated. Completion requires the adoption
+PR's exact-head hosted checks and release verification; local passes alone do not
+establish complete adoption.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@fitchmultz/pi-subagents",
-  "version": "0.52.16",
+  "version": "0.52.17",
   "description": "Pi extension for subagent orchestration and local session coordination",
   "license": "MIT",
   "type": "module",
@@ -68,8 +68,10 @@
     "lint:agent": "oxlint --type-aware --deny-warnings --format=agent .",
     "format": "oxfmt --write .",
     "format:check": "oxfmt --check .",
-    "ci": "npm run lint && npm run format:check && npm run typecheck && npm run check:size && npm run smoke:package && npm run smoke:install && npm run test:all",
-    "smoke:real-pi": "node scripts/real-pi-smoke.mjs"
+    "ci": "node quality/acceptance.ts",
+    "smoke:real-pi": "node scripts/real-pi-smoke.mjs",
+    "check:quality": "node quality/check.ts",
+    "typecheck:declarations": "node quality/declarations.ts"
   },
   "pi": {
     "extensions": [
@@ -110,9 +112,10 @@
     "@earendil-works/pi-tui": "1.5.0",
     "@types/node": "24.19.2",
     "@types/sinon": "22.0.2",
-    "oxfmt": "0.75.0",
-    "oxlint": "1.90.0",
-    "oxlint-tsgolint": "7.0.2005",
+    "oxc-parser": "0.157.0",
+    "oxfmt": "0.76.0",
+    "oxlint": "1.91.0",
+    "oxlint-tsgolint": "7.0.2006",
     "sinon": "22.1.0",
     "type-fest": "5.10.0",
     "typebox": "1.4.3",

package/scripts/build.mjs

@@ -11,6 +11,7 @@
  */
 
 import { execFile as execFileCallback } from "node:child_process";
+import assert from "node:assert/strict";
 import { createHash } from "node:crypto";
 import { existsSync } from "node:fs";
 import { readFile, readdir, rename, rm, writeFile } from "node:fs/promises";
@@ -21,7 +22,6 @@ import { promisify } from "node:util";
 import { compilerInvocation } from "./typescript.mjs";
 
 /** @type {(file: string, args: readonly string[], options: import("node:child_process").ExecFileOptions) => Promise<{ stdout: string, stderr: string }>} */
-// oxlint-disable-next-line typescript/strict-void-return
 const execFile = promisify(execFileCallback);
 const RM_OPTIONS = { force: true, maxRetries: 5, recursive: true, retryDelay: 100 };
 
@@ -80,7 +80,6 @@ async function reapStrandedStaging(/** @type {string} */ cwd) {
       continue;
     }
     // Reap abandoned trees sequentially to bound filesystem removal pressure.
-    // oxlint-disable-next-line no-await-in-loop
     await discardStaging(join(cwd, entry.name));
   }
 }
@@ -114,13 +113,13 @@ async function compileToStaging(
     await compileProject(cwd, stagingDir, compiler, "tsconfig.client.json");
     await stampBuild(cwd, stagingDir);
   } catch (error) {
-    // oxlint-disable-next-line typescript/no-unsafe-type-assertion -- exec rejections carry partial output
-    const output = /** @type {{ stdout?: string, stderr?: string }} */ (error);
-    if (output.stdout !== undefined && output.stdout !== "") {
-      process.stdout.write(output.stdout);
-    }
-    if (output.stderr !== undefined && output.stderr !== "") {
-      process.stderr.write(output.stderr);
+    if (typeof error === "object" && error !== null) {
+      if ("stdout" in error && typeof error.stdout === "string") {
+        process.stdout.write(error.stdout);
+      }
+      if ("stderr" in error && typeof error.stderr === "string") {
+        process.stderr.write(error.stderr);
+      }
     }
     await discardStaging(stagingDir);
     throw error;
@@ -135,13 +134,13 @@ async function stampBuild(/** @type {string} */ cwd, /** @type {string} */ stagi
     .sort();
   for (const file of files) {
     // Hash sorted path/content pairs in order without buffering the whole emitted tree.
-    // oxlint-disable-next-line no-await-in-loop
     const content = await readFile(join(stagingDir, file));
     hash.update(file).update("\0").update(content).update("\0");
   }
-  /** @type {{ version: string }} */
-  // oxlint-disable-next-line typescript/no-unsafe-assignment
+  /** @type {unknown} */
   const pkg = JSON.parse(await readFile(join(cwd, "package.json"), "utf8"));
+  assert.ok(typeof pkg === "object" && pkg !== null && "version" in pkg);
+  assert.ok(typeof pkg.version === "string");
   const { version } = pkg;
   await writeFile(
     join(stagingDir, stamp),
@@ -184,7 +183,6 @@ async function publishStaging(/** @type {string} */ stagingDir, /** @type {strin
     });
     for (let retry = 0; ; retry++) {
       // Each retry must observe publication before another rename can race it.
-      // oxlint-disable-next-line no-await-in-loop
       if (await tryPublish(stagingDir, distDir, retry)) {
         break;
       }

package/scripts/check-compat.mjs

@@ -19,6 +19,8 @@ const run = (
   /** @type {import("node:child_process").SpawnSyncOptions} */ options = {},
 ) => {
   // Outlasts the 1_200_000 ms integration watchdog in scripts/run-tests.mjs.
+  // Inherited stdio produces null at runtime despite SpawnSyncReturns<T>'s declaration.
+  /** @type {import("node:child_process").SpawnSyncReturns<string | Buffer | null>} */
   const result = spawnSync(command, args, { stdio: "inherit", timeout: 1_500_000, ...options });
   if (result.error) {
     throw result.error;
@@ -28,8 +30,7 @@ const run = (
     0,
     `${command} ${args.join(" ")} failed (${result.status ?? result.signal ?? "unknown"})`,
   );
-  // oxlint-disable-next-line typescript/no-unsafe-type-assertion -- spawnSync stdout shape depends on caller options
-  return /** @type {string | undefined} */ (/** @type {unknown} */ (result.stdout))?.trim();
+  return result.stdout === null ? undefined : result.stdout.toString().trim();
 };
 const git = (/** @type {string} */ cwd, /** @type {string[]} */ args) =>
   run("git", args, { cwd, stdio: ["ignore", "pipe", "inherit"], encoding: "utf8" });

package/scripts/compat-host.mjs

@@ -12,9 +12,12 @@ if (hostPackageJson === undefined) {
 }
 export const hostRoot = realpathSync(dirname(hostPackageJson));
 export const hostIndex = join(hostRoot, "dist/index.js");
-/** @type {{ version: string, bin: { pi: string } }} */
-// oxlint-disable-next-line typescript/no-unsafe-assignment
+/** @type {unknown} */
 const manifest = JSON.parse(readFileSync(join(hostRoot, "package.json"), "utf8"));
+assert.ok(typeof manifest === "object" && manifest !== null);
+assert.ok("version" in manifest && typeof manifest.version === "string");
+assert.ok("bin" in manifest && typeof manifest.bin === "object" && manifest.bin !== null);
+assert.ok("pi" in manifest.bin && typeof manifest.bin.pi === "string");
 export const hostCli = realpathSync(join(hostRoot, manifest.bin.pi));
 /** @type {[string, string][]} */
 const expectedHostPaths = [
@@ -26,7 +29,6 @@ for (const [name, actual] of expectedHostPaths) {
   const expected = process.env[name];
   if (expected !== undefined) {
     assert.equal(
-      // oxlint-disable-next-line typescript/no-unnecessary-condition -- assert generic inference already matches
       realpathSync(expected),
       realpathSync(actual),
       `${name} must select the installed graph`,
@@ -35,11 +37,9 @@ for (const [name, actual] of expectedHostPaths) {
 }
 const expectedVersion = process.env.PI_COMPAT_EXPECTED_VERSION;
 if (expectedVersion !== undefined) {
-  // oxlint-disable-next-line typescript/no-unnecessary-condition -- assert generic inference already matches
   assert.equal(manifest.version, expectedVersion);
 }
 assert.equal(
-  // oxlint-disable-next-line typescript/no-unnecessary-condition -- assert generic inference already matches
   realpathSync(fileURLToPath(import.meta.resolve("@earendil-works/pi-coding-agent"))),
   realpathSync(hostIndex),
 );