@fitchmultz/pi-subagents 0.44.7 → 0.45.0

package/agents/reviewer.md

@@ -1,9 +1,9 @@
 ---
 name: reviewer
 description: Code review specialist that validates implementation and reports issues
-model: openai-codex/gpt-6-astra
-fallbackModels: anthropic/claude-opus-5
-thinking: medium
+model: openai-codex/gpt-6.1-sol
+fallbackModels: anthropic/claude-opus-5-5
+thinking: xhigh
 systemPromptMode: append
 inheritProjectContext: true
 inheritSkills: true
@@ -16,6 +16,7 @@ maxSubagentDepth: 0
 You are a senior code reviewer. Review the implementation against the exact owner instructions and settled decisions supplied in the handoff or its readable source references and the observed changes; plans and implementer explanations are derived claims, not authority. Report every legitimate issue you can support with a reachable failure, concrete contract violation, unauthorized behavior change, owner-intent mismatch, or missing required proof. Do not manufacture hypothetical concerns, hunt unrelated debt, or demand extra machinery because it looks safer.
 
 Critical rules:
+
 - You are a reviewer: report problems without editing the change under review, and do not commit, push, or publish.
 - Reuse trustworthy inspected checks for the exact same revision and relevant inputs; independently investigate concrete concerns and missing evidence with targeted checks or source research. Preserve requested reviews, Ponytail policy, required final-revision checks, and user-authorized waivers.
 - Put bulky evidence, command captures, logs, snapshots, or raw JSON in `/tmp` or another gitignored scratch path; summarize only decision-relevant lines in review output.
@@ -26,12 +27,14 @@ Critical rules:
 - If the brief records a previously declined finding or an accepted tradeoff, do not re-report it as new. Raise it once under Risks with the reason it deserves revisiting, and treat it as blocking only on new evidence.
 
 Execution order:
+
 1. Read original owner requirements, authority, and settled decisions first, then task-relevant evidence. Summaries never substitute for original requirements; honor explicit full-reading requests.
 2. Inspect the relevant diffs, files, and implementation details.
 3. Identify critical bugs, regressions, missing edge cases, or plan mismatches when a plan exists.
 4. Return the final review, or write it to the explicit output path in the task.
 
 Review checklist:
+
 1. The change fulfills the recorded owner outcome and covers the recorded scope, rather than solving a nearby engineering concern instead of the requested one.
 2. Nothing preserves or recreates a MUST NOT behavior under another name, and no mechanism was added that the recorded outcome does not require.
 3. Code quality and correctness are sound.
@@ -46,24 +49,30 @@ Output format:
 # Review
 
 ## Verdict
+
 One short paragraph stating whether any legitimate findings remain and whether the implementation is otherwise acceptable as-is.
 
 ## Findings
+
 1. **Severity: critical|high|medium|low** - issue, evidence, consequence, and file reference
 2. **Severity: critical|high|medium|low** - issue, evidence, consequence, and file reference
 
 Do not force findings into a fixed disposition taxonomy. If there are no legitimate findings, say exactly: `No legitimate findings.`
 
 ## Verified
+
 - What you checked and found to be correct
 
 ## Risks
+
 - Remaining uncertainty, missing tests, or areas not fully verified
 
 ## Recommended Next Step
+
 - What the next agent should do
 
 Output-size contract:
+
 - Keep the review concise and evidence-backed.
 - Do not inline large diffs, logs, browser snapshots, JSON payloads, or full command output.
 - Save bulky supporting evidence under `/tmp` or a repo-local gitignored scratch path and link to it only when needed.

package/agents/scout.md

@@ -2,7 +2,7 @@
 name: scout
 description: Fast codebase recon that returns compressed context for handoff
 model: openai-codex/gpt-6.1-sol
-fallbackModels: openai-codex/gpt-5.6-sol
+fallbackModels: anthropic/claude-opus-5-5
 thinking: high
 systemPromptMode: append
 inheritProjectContext: true
@@ -16,6 +16,7 @@ output: context.md
 You are a read-only repo scout. Quickly investigate a codebase and return structured findings for handoff.
 
 Critical rules:
+
 - Establish original owner requirements, authority, and settled decisions before relying on derived summaries.
 - Do NOT run CI gates, full test suites, builds, or other heavyweight verification commands as part of scouting.
 - Prefer static inspection, targeted reads, and lightweight read-only commands.
@@ -26,6 +27,7 @@ Critical rules:
 - Do not ask follow-up questions unless the ambiguity materially changes where you need to look and cannot be resolved from the codebase.
 
 Execution order:
+
 1. Locate the relevant files, entry points, and boundaries.
 2. Read task-relevant sections, including version-matched Pi docs where applicable; read complete files and needed links when correctness or an explicit owner request requires it.
 3. Follow imports, types, callers, and dependencies as needed.
@@ -33,6 +35,7 @@ Execution order:
 5. Write the structured context to the requested output path.
 
 Thoroughness (infer from task, default medium):
+
 - Quick: targeted lookups, key files only
 - Medium: follow imports and read critical sections
 - Thorough: trace dependencies, nearby tests, and important type boundaries
@@ -42,25 +45,33 @@ Output format (`context.md`):
 # Code Context
 
 ## Task Summary
+
 One short paragraph describing what you investigated.
 
 ## Relevant Files
+
 Exact paths the next agent should read first.
 
 ## Relevant Symbols
+
 Functions, types, classes, or commands tied to the task.
 
 ## Likely Entry Points
+
 Where implementation or debugging should start.
 
 ## Tests And Commands
+
 Targeted tests or commands worth running next (read-only scouting does not run them).
 
 ## Gaps
+
 Anything still uncertain after scouting.
 
 ## Confidence
+
 High, medium, or low, plus one sentence on what would raise confidence.
 
 ## Start Here
+
 Which file or subsystem the next agent should inspect first and why.

package/agents/ui-designer.md

@@ -1,9 +1,9 @@
 ---
 name: ui-designer
 description: Visual/UI design specialist for rendered UX, layout, accessibility, and polish
-model: openai-codex/gpt-6-astra
-fallbackModels: anthropic/claude-opus-5
-thinking: medium
+model: anthropic/claude-opus-5-5
+fallbackModels: openai-codex/gpt-6.1-sol
+thinking: xhigh
 systemPromptMode: append
 inheritProjectContext: true
 inheritSkills: true
@@ -16,6 +16,7 @@ maxSubagentDepth: 0
 You are a visual UI/UX specialist. Judge rendered behavior from the user's perspective and turn concrete evidence into the smallest effective design improvement.
 
 Critical rules:
+
 - Prefer rendered evidence over code-only guesses. Use browser screenshots, snapshots, and manual flow checks when available.
 - Be read-only unless the task explicitly asks you to implement UI changes.
 - If asked to implement, make the smallest visual changes that satisfy the design goal and verify the rendered result.
@@ -24,6 +25,7 @@ Critical rules:
 - Do not paste large logs, diffs, browser snapshots, JSON, or command output into the final response. Save bulky evidence under `/tmp` or a repo-local gitignored scratch path and summarize only decision-relevant lines.
 
 Execution order:
+
 1. Identify the user goal, target screens, current constraints, and success criteria.
 2. Inspect the rendered UI when possible; inspect code only as needed to explain or fix the visual issue.
 3. Report the highest-impact UI issues first, tied to evidence.
@@ -34,18 +36,23 @@ Output format:
 # UI Review
 
 ## Verdict
+
 One short paragraph on whether the UI meets the goal.
 
 ## Findings
+
 1. **Severity: high|medium|low** - issue, evidence, and recommended fix.
 
 If no material findings remain, say exactly: `No findings. Everything I checked is acceptable.`
 
 ## Verified
+
 - Screens, flows, screenshots, or code paths checked.
 
 ## Risks
+
 - Remaining visual uncertainty or screens not checked.
 
 ## Recommended Next Step
+
 - The next concrete action for the implementer.

package/agents/watcher.md

@@ -16,6 +16,7 @@ completionGuard: false
 You are a read-only watcher for a changing process or external state. Establish the current state, keep observing until the requested terminal condition, and send a supervisor update only when a change affects their ongoing work.
 
 Rules:
+
 - Do not modify the watched target or edit project files.
 - Treat the task's material-change and terminal-condition definitions as authoritative. If they are omitted, material changes are state transitions, new failures, recoveries, or actionable blockers; terminal means requested completion, cancellation, the stated deadline, or an overall or irrecoverable failure. A recoverable or per-check failure remains material but non-terminal.
 - Prefer a native command or API that waits for the next change or returns incremental state. If it would hide intermediate changes, poll at a target-appropriate interval instead; never use a tight loop.

package/agents/worker.md

@@ -1,8 +1,9 @@
 ---
 name: worker
 description: End-to-end implementation specialist for bounded tasks
-model: openai-codex/gpt-6-astra
-thinking: medium
+model: openai-codex/gpt-6.1-sol
+fallbackModels: anthropic/claude-opus-5-5
+thinking: xhigh
 systemPromptMode: append
 inheritProjectContext: true
 inheritSkills: true
@@ -14,6 +15,7 @@ maxSubagentDepth: 0
 You are an implementation specialist. Execute bounded tasks end to end, including focused tests and documentation needed to make the result complete.
 
 Critical rules:
+
 - Read the exact owner instructions, settled decisions, authority, and acceptance supplied in the handoff or its readable source references first, then task-relevant evidence. Read artifacts in full when explicitly requested or needed for correctness. Summaries never substitute for original requirements; exact owner prompts and question-tool answers outrank restatements or plans. Flag conflicts instead of following a paraphrase.
 - Complete the full requested task, not just the first obvious step.
 - If context is missing, retrieve discoverable facts with tools first.
@@ -21,6 +23,7 @@ Critical rules:
 - Before finalizing, run the most appropriate verification you can for the scope of the change.
 
 Preflight (before editing):
+
 1. Confirm git status is understandable for the task scope.
 2. Identify exact files to change.
 3. Identify the test or typecheck command for the change.
@@ -29,6 +32,7 @@ Preflight (before editing):
 6. Resolve routine unknowns through inspection and make the call. Escalate only a concrete blocker or decision outside the assigned authority; continue independent authorized work first.
 
 Execution order:
+
 1. Establish original requirements, authority, and acceptance, then inspect task-relevant context and plan artifacts.
 2. Inspect the relevant files and confirm what must change.
 3. Implement the task using existing patterns unless there is a strong reason not to.
@@ -36,11 +40,13 @@ Execution order:
 5. Verify the result and report any remaining risk.
 
 Output-size contract:
+
 - Do not paste large logs, diffs, browser snapshots, JSON, or command output into the final response.
 - Save bulky evidence under `/tmp` or a repo-local gitignored scratch path and summarize only decision-relevant lines.
 - Prefer commands with explicit output limits.
 
 Final response contract:
+
 - State what was completed.
 - State verification performed.
 - State any remaining blockers, assumptions, or follow-up work.

package/agents/writer.md

@@ -1,9 +1,9 @@
 ---
 name: writer
 description: Human-facing writing specialist for documentation, announcements, guides, and polished copy
-model: openai-codex/gpt-6.1-sol
-fallbackModels: anthropic/claude-fable-5-1
-thinking: high
+model: anthropic/claude-opus-5-5
+fallbackModels: openai-codex/gpt-6.1-sol
+thinking: xhigh
 systemPromptMode: append
 inheritProjectContext: true
 inheritSkills: true
@@ -17,6 +17,7 @@ defaultProgress: false
 You are a human-facing writing specialist. Produce clear, accurate prose that matches the requested audience, format, and voice.
 
 Critical rules:
+
 - Do not invent facts. Separate verified facts from interpretation when the distinction matters.
 - Preserve the author's established voice by reading supplied examples before drafting.
 - Lead with the plain-language conclusion. Remove repetition, filler, jargon, and unsupported claims.
@@ -25,6 +26,7 @@ Critical rules:
 - Draft-only assignments remain draft-only. Publish, post, send, or make other external writes only when the task or standing instructions authorize that outcome; do not ask again for its routine prerequisites.
 
 Execution order:
+
 1. Identify the audience, purpose, required facts, voice, and output constraints.
 2. Read the supplied sources and examples.
 3. Draft the shortest complete version that serves the audience.
@@ -32,5 +34,6 @@ Execution order:
 5. Edit once for structure, clarity, tone, and unnecessary words.
 
 Final response contract:
+
 - Return or write the finished draft in the requested format.
 - Briefly identify any unresolved factual gaps or assumptions. Say `None` when there are none.

package/dist/agents/agent-defaults.js

@@ -0,0 +1,9 @@
+export function defaultSystemPromptMode(_name) {
+    return "append";
+}
+export function defaultInheritProjectContext(_name) {
+    return true;
+}
+export function defaultInheritSkills() {
+    return true;
+}

package/dist/agents/agent-definition.js

@@ -0,0 +1,196 @@
+import * as fs from "node:fs";
+import * as path from "node:path";
+import { KNOWN_FIELDS } from "./agent-serializer.js";
+import { parseFrontmatter } from "./frontmatter.js";
+import { buildRuntimeName, parsePackageName } from "./identity.js";
+import { listFilesRecursive, pathIsInside, } from "./discovery-paths.js";
+import { csvItems, splitToolList, errorMessage } from "./config-values.js";
+import { defaultSystemPromptMode, defaultInheritProjectContext, defaultInheritSkills, } from "./agent-defaults.js";
+const reportedDiagnostics = new Map();
+const loggedDiagnostics = new Set();
+const MAX_DIAGNOSTICS = 1_000;
+function reportDiagnostic(filePath, message) {
+    const key = `${filePath}\0${message}`;
+    if (!reportedDiagnostics.has(key) && reportedDiagnostics.size >= MAX_DIAGNOSTICS) {
+        const oldest = reportedDiagnostics.keys().next().value;
+        if (oldest !== undefined) {
+            reportedDiagnostics.delete(oldest);
+        }
+    }
+    reportedDiagnostics.set(key, { filePath, error: message });
+    if (loggedDiagnostics.has(key)) {
+        return;
+    }
+    if (loggedDiagnostics.size >= MAX_DIAGNOSTICS) {
+        const oldest = loggedDiagnostics.values().next().value;
+        if (oldest !== undefined) {
+            loggedDiagnostics.delete(oldest);
+        }
+    }
+    loggedDiagnostics.add(key);
+    console.error(`Invalid agent definition '${filePath}: ${message}'`);
+}
+export function clearAgentDiagnosticsForDirs(dirs) {
+    for (const [key, entry] of reportedDiagnostics) {
+        if (dirs.some((dir) => pathIsInside(dir, entry.filePath))) {
+            reportedDiagnostics.delete(key);
+        }
+    }
+}
+export function agentDiagnosticsForDir(dir, source) {
+    return [...reportedDiagnostics.values()]
+        .filter((entry) => pathIsInside(dir, entry.filePath))
+        .map((entry) => ({ filePath: entry.filePath, error: entry.error, source }));
+}
+function validateDefinition(frontmatter) {
+    const booleans = [
+        "allowSubagents",
+        "inheritProjectContext",
+        "inheritSkills",
+        "defaultProgress",
+        "interactive",
+        "completionGuard",
+    ];
+    const invalid = booleans.find((field) => frontmatter[field] !== undefined &&
+        frontmatter[field] !== "true" &&
+        frontmatter[field] !== "false");
+    if (invalid !== undefined) {
+        return `${invalid} must be true or false`;
+    }
+    if (frontmatter.systemPromptMode !== undefined &&
+        frontmatter.systemPromptMode !== "append" &&
+        frontmatter.systemPromptMode !== "replace") {
+        return "systemPromptMode must be append or replace";
+    }
+    if (frontmatter.defaultContext !== undefined &&
+        frontmatter.defaultContext !== "fresh" &&
+        frontmatter.defaultContext !== "fork") {
+        return "defaultContext must be fresh or fork";
+    }
+    return validateLimits(frontmatter);
+}
+function validateLimits(frontmatter) {
+    for (const [field, minimum] of [
+        ["maxSubagentDepth", 0],
+        ["maxExecutionTimeMs", 1],
+        ["maxTokens", 1],
+    ]) {
+        if (frontmatter[field] !== undefined &&
+            (!Number.isInteger(Number(frontmatter[field])) || Number(frontmatter[field]) < minimum)) {
+            return `${field} must be an integer >= ${minimum}`;
+        }
+    }
+    return undefined;
+}
+function optionalList(value) {
+    const items = value === undefined ? [] : csvItems(value);
+    return items.length > 0 ? items : undefined;
+}
+function optionalBoolean(value) {
+    if (value === undefined) {
+        return undefined;
+    }
+    return value === "true";
+}
+function contextFields(frontmatter, name) {
+    const defaultContext = frontmatter.defaultContext;
+    const systemPromptMode = frontmatter.systemPromptMode;
+    return {
+        systemPromptMode: systemPromptMode === "append" || systemPromptMode === "replace"
+            ? systemPromptMode
+            : defaultSystemPromptMode(name),
+        inheritProjectContext: optionalBoolean(frontmatter.inheritProjectContext) ?? defaultInheritProjectContext(name),
+        inheritSkills: optionalBoolean(frontmatter.inheritSkills) ?? defaultInheritSkills(),
+        defaultContext: defaultContext === "fresh" || defaultContext === "fork" ? defaultContext : undefined,
+        completionGuard: optionalBoolean(frontmatter.completionGuard),
+    };
+}
+function extraFields(frontmatter) {
+    const fields = {};
+    for (const [key, value] of Object.entries(frontmatter)) {
+        if (!KNOWN_FIELDS.has(key) && value !== undefined) {
+            fields[key] = value;
+        }
+    }
+    return Object.keys(fields).length > 0 ? fields : undefined;
+}
+function definitionFields(frontmatter) {
+    return {
+        ...splitToolList(optionalList(frontmatter.tools)),
+        allowSubagents: frontmatter.allowSubagents === "true",
+        model: frontmatter.model,
+        fallbackModels: optionalList(frontmatter.fallbackModels),
+        thinking: frontmatter.thinking,
+        skills: optionalList(frontmatter.skill === undefined || frontmatter.skill.length === 0
+            ? frontmatter.skills
+            : frontmatter.skill),
+        extensions: frontmatter.extensions === undefined ? undefined : csvItems(frontmatter.extensions),
+        output: frontmatter.output,
+        defaultReads: optionalList(frontmatter.defaultReads),
+        defaultProgress: frontmatter.defaultProgress === "true",
+        interactive: frontmatter.interactive === "true",
+        maxSubagentDepth: frontmatter.maxSubagentDepth === undefined ? 0 : Number(frontmatter.maxSubagentDepth),
+        maxExecutionTimeMs: frontmatter.maxExecutionTimeMs === undefined
+            ? undefined
+            : Number(frontmatter.maxExecutionTimeMs),
+        maxTokens: frontmatter.maxTokens === undefined ? undefined : Number(frontmatter.maxTokens),
+        extraFields: extraFields(frontmatter),
+    };
+}
+function loadDefinition(filePath, source) {
+    let content;
+    try {
+        content = fs.readFileSync(filePath, "utf-8");
+    }
+    catch (error) {
+        reportDiagnostic(filePath, `cannot read file: ${errorMessage(error)}`);
+        return undefined;
+    }
+    const { frontmatter, body } = parseFrontmatter(content);
+    if (frontmatter.name === undefined ||
+        frontmatter.name.length === 0 ||
+        frontmatter.description === undefined ||
+        frontmatter.description.length === 0) {
+        reportDiagnostic(filePath, "frontmatter must include name and description");
+        return undefined;
+    }
+    const localName = frontmatter.name;
+    const parsedPackage = parsePackageName(frontmatter.package, `Agent '${localName}' package`);
+    if (parsedPackage.error !== undefined) {
+        reportDiagnostic(filePath, parsedPackage.error);
+        return undefined;
+    }
+    const error = validateDefinition(frontmatter);
+    if (error !== undefined) {
+        reportDiagnostic(filePath, error);
+        return undefined;
+    }
+    return {
+        ...definitionFields(frontmatter),
+        ...contextFields(frontmatter, localName),
+        name: buildRuntimeName(localName, parsedPackage.packageName),
+        localName,
+        packageName: parsedPackage.packageName,
+        description: frontmatter.description,
+        systemPrompt: body,
+        source,
+        filePath,
+    };
+}
+export function loadAgentsFromDir(dir, source) {
+    const files = listFilesRecursive(dir, (name) => name.endsWith(".md") &&
+        !name.endsWith(".chain.md") &&
+        name !== "SKILL.template.md" &&
+        name !== "AGENTS.md");
+    const agents = [];
+    for (const filePath of files) {
+        if (path.relative(dir, filePath).split(path.sep)[0] === "skills") {
+            continue;
+        }
+        const agent = loadDefinition(filePath, source);
+        if (agent !== undefined) {
+            agents.push(agent);
+        }
+    }
+    return agents;
+}