@fitchmultz/pi-subagents 0.44.6 → 0.45.0

package/dist/shared/temp-root.js

@@ -2,36 +2,42 @@ import * as fs from "node:fs";
 import * as path from "node:path";
 import { isSafeNestedPathId } from "../runs/shared/nested-path.js";
 import { ASYNC_DIR, RESULTS_DIR, TEMP_ROOT_DIR } from "./types.js";
-import { listRunQuestions, LEGACY_QUESTIONS_DIR, QUESTIONS_DIR } from "../runs/shared/supervisor-questions.js";
+import { hasErrorCode, isRecord } from "./unknown.js";
+import { listRunQuestions, LEGACY_QUESTIONS_DIR, QUESTIONS_DIR, } from "../runs/shared/supervisor-questions.js";
 const MAX_RUN_AGE_MS = 7 * 24 * 60 * 60 * 1000;
 export function ensureTempRoot() {
     fs.mkdirSync(TEMP_ROOT_DIR, { recursive: true, mode: 0o700 });
     const stat = fs.lstatSync(TEMP_ROOT_DIR);
-    if (!stat.isDirectory() || stat.isSymbolicLink())
+    if (!stat.isDirectory() || stat.isSymbolicLink()) {
         throw new Error(`Unsafe pi-subagents temp root: ${TEMP_ROOT_DIR}`);
+    }
     const uid = process.getuid?.();
-    if (uid !== undefined && stat.uid !== uid)
+    if (uid !== undefined && stat.uid !== uid) {
         throw new Error(`pi-subagents temp root is owned by another user: ${TEMP_ROOT_DIR}`);
+    }
     fs.chmodSync(TEMP_ROOT_DIR, 0o700);
 }
 export function ensureSafeTempPath(candidate) {
     const root = path.resolve(TEMP_ROOT_DIR);
     const resolved = path.resolve(candidate);
     const relative = path.relative(root, resolved);
-    if (relative === ".." || relative.startsWith(`..${path.sep}`) || path.isAbsolute(relative))
+    if (relative === ".." || relative.startsWith(`..${path.sep}`) || path.isAbsolute(relative)) {
         return;
+    }
     ensureTempRoot();
     let current = root;
     for (const segment of relative.split(path.sep).filter(Boolean)) {
         current = path.join(current, segment);
         try {
             const stat = fs.lstatSync(current);
-            if (stat.isSymbolicLink())
+            if (stat.isSymbolicLink()) {
                 throw new Error(`Unsafe symlink in pi-subagents temp path: ${current}`);
+            }
         }
         catch (error) {
-            if (error.code === "ENOENT")
+            if (hasErrorCode(error, "ENOENT")) {
                 return;
+            }
             throw error;
         }
     }
@@ -41,11 +47,12 @@ export function ensureSafeTempPath(candidate) {
 async function readJsonObject(file) {
     try {
         const parsed = JSON.parse(await fs.promises.readFile(file, "utf-8"));
-        return parsed !== null && typeof parsed === "object" ? parsed : undefined;
+        return isRecord(parsed) ? parsed : undefined;
     }
     catch (error) {
-        if (error.code === "ENOENT" || error instanceof SyntaxError)
+        if (hasErrorCode(error, "ENOENT") || error instanceof SyntaxError) {
             return undefined;
+        }
         throw error;
     }
 }
@@ -64,11 +71,19 @@ async function removeOldEntries(root, now, keepActive) {
     for (const entry of entries) {
         const entryPath = path.join(root, entry.name);
         try {
+            // Sequential retention bounds filesystem work and observes each entry before deletion.
+            // oxlint-disable-next-line no-await-in-loop
             const stat = await fs.promises.lstat(entryPath);
-            if (now - stat.mtimeMs <= MAX_RUN_AGE_MS)
+            if (now - stat.mtimeMs <= MAX_RUN_AGE_MS) {
                 continue;
-            if (keepActive && entry.isDirectory() && await keepActive(entryPath))
+            }
+            // Finish the entry's activity decision before deleting it or considering another entry.
+            // oxlint-disable-next-line no-await-in-loop
+            if (keepActive && entry.isDirectory() && (await keepActive(entryPath))) {
                 continue;
+            }
+            // Only remove entries whose preceding activity check completed; keep I/O bounded.
+            // oxlint-disable-next-line no-await-in-loop
             await fs.promises.rm(entryPath, { recursive: entry.isDirectory(), force: true });
         }
         catch {
@@ -84,17 +99,22 @@ async function removeOldEntries(root, now, keepActive) {
 async function nestedRouteActive(routeRoot, now) {
     for (const name of ["events", "controls"]) {
         try {
-            if (now - (await fs.promises.stat(path.join(routeRoot, name))).mtimeMs <= MAX_RUN_AGE_MS)
+            // Inspect the two writer directories in order, short-circuiting on live activity.
+            // oxlint-disable-next-line no-await-in-loop
+            if (now - (await fs.promises.stat(path.join(routeRoot, name))).mtimeMs <= MAX_RUN_AGE_MS) {
                 return true;
+            }
         }
         catch (error) {
-            if (error.code !== "ENOENT")
+            if (!hasErrorCode(error, "ENOENT")) {
                 throw error;
+            }
         }
     }
     const metadata = await readJsonObject(path.join(routeRoot, "route.json"));
-    if (!metadata || !isSafeNestedPathId(metadata.rootRunId))
+    if (!metadata || !isSafeNestedPathId(metadata.rootRunId)) {
         return false;
+    }
     return activeStatus(path.join(ASYNC_DIR, metadata.rootRunId, "status.json"));
 }
 function pendingQuestion(runDir) {
@@ -102,13 +122,22 @@ function pendingQuestion(runDir) {
 }
 export async function cleanupOldRunStorage(now = Date.now()) {
     for (const [dir, keepActive] of [
-        [ASYNC_DIR, async (entryPath) => await activeStatus(path.join(entryPath, "status.json")) || pendingQuestion(path.join(QUESTIONS_DIR, path.basename(entryPath)))],
+        [
+            ASYNC_DIR,
+            async (entryPath) => (await activeStatus(path.join(entryPath, "status.json"))) ||
+                pendingQuestion(path.join(QUESTIONS_DIR, path.basename(entryPath))),
+        ],
         [LEGACY_QUESTIONS_DIR, pendingQuestion],
         [RESULTS_DIR, undefined],
         [path.join(TEMP_ROOT_DIR, "nested-subagent-runs"), undefined],
-        [path.join(TEMP_ROOT_DIR, "nested-subagent-events"), (entryPath) => nestedRouteActive(entryPath, now)],
+        [
+            path.join(TEMP_ROOT_DIR, "nested-subagent-events"),
+            (entryPath) => nestedRouteActive(entryPath, now),
+        ],
     ]) {
         ensureSafeTempPath(dir);
+        // Finish one storage root's retention scan before opening another.
+        // oxlint-disable-next-line no-await-in-loop
         await removeOldEntries(dir, now, keepActive);
     }
 }

package/dist/shared/types/acceptance.js

@@ -0,0 +1 @@
+export {};

package/dist/shared/types/async.js

@@ -0,0 +1 @@
+export {};

package/dist/shared/types/config.js

@@ -0,0 +1 @@
+export {};

package/dist/shared/types/details.js

@@ -0,0 +1 @@
+export {};

package/dist/shared/types/history.js

@@ -0,0 +1 @@
+export {};

package/dist/shared/types/inputs.js

@@ -0,0 +1 @@
+export {};

package/dist/shared/types/intercom.js

@@ -0,0 +1 @@
+export {};

package/dist/shared/types/launch.js

@@ -0,0 +1 @@
+export {};

package/dist/shared/types/messages.js

@@ -0,0 +1 @@
+export {};

package/dist/shared/types/nested.js

@@ -0,0 +1 @@
+export {};

package/dist/shared/types/owned-runs.js

@@ -0,0 +1 @@
+export {};

package/dist/shared/types/progress.js

@@ -0,0 +1 @@
+export {};

package/dist/shared/types/questions.js

@@ -0,0 +1 @@
+export {};

package/dist/shared/types/results.js

@@ -0,0 +1 @@
+export {};

package/dist/shared/types/state.js

@@ -0,0 +1 @@
+export {};

package/dist/shared/types/usage.js

@@ -0,0 +1 @@
+export {};

package/dist/shared/types/workflow.js

@@ -0,0 +1 @@
+export {};

package/dist/shared/types.js

@@ -1,6 +1,4 @@
-/**
- * Type definitions for the subagent extension
- */
+/** Public compatibility barrel. Domain contracts depend on each other, never on implementation modules. */
 import * as os from "node:os";
 import * as path from "node:path";
 export const INTERCOM_DETACH_REQUEST_EVENT = "pi-intercom:detach-request";
@@ -17,7 +15,6 @@ export const SUBAGENT_INTERCOM_HEALTH_REQUEST_EVENT = "subagent:intercom-health-
 export const SUBAGENT_INTERCOM_HEALTH_RESPONSE_EVENT = "subagent:intercom-health-response";
 export const SUBAGENT_INTERCOM_IDENTITY_REQUEST_EVENT = "subagent:intercom-identity-request";
 export const SUBAGENT_INTERCOM_IDENTITY_RESPONSE_EVENT = "subagent:intercom-identity-response";
-// ============================================================================
 // Constants
 // ============================================================================
 export const DEFAULT_MAX_OUTPUT = {
@@ -29,31 +26,39 @@ function sanitizeTempScopeSegment(value) {
         .trim()
         .replace(/[^A-Za-z0-9._-]+/g, "-")
         .replace(/^-+|-+$/g, "");
-    return sanitized || "unknown";
+    return sanitized.length > 0 ? sanitized : "unknown";
 }
 export function resolveTempScopeId() {
-    if (typeof process.getuid === "function")
+    if (typeof process.getuid === "function") {
         return `uid-${process.getuid()}`;
+    }
     for (const key of ["USERNAME", "USER", "LOGNAME"]) {
         const value = process.env[key];
-        if (value)
+        if (value !== undefined && value.length > 0) {
             return `user-${sanitizeTempScopeSegment(value)}`;
+        }
     }
     try {
         const username = os.userInfo().username;
-        if (username)
+        if (username.length > 0) {
             return `user-${sanitizeTempScopeSegment(username)}`;
+        }
     }
     catch {
         // Fall through to home-directory-based scoping.
     }
+    return resolveHomeTempScopeId();
+}
+function resolveHomeTempScopeId() {
     const homedir = process.env.HOME;
-    if (homedir)
+    if (homedir !== undefined && homedir.length > 0) {
         return `home-${sanitizeTempScopeSegment(homedir)}`;
+    }
     try {
         const fallbackHomedir = os.homedir();
-        if (fallbackHomedir)
+        if (fallbackHomedir.length > 0) {
             return `home-${sanitizeTempScopeSegment(fallbackHomedir)}`;
+        }
     }
     catch {
         // Fall through to the last-resort shared scope.
@@ -64,8 +69,9 @@ const MAX_PARALLEL = 8;
 export const MAX_CONCURRENCY = 4;
 export function resolveTempRootDir(configured = process.env.PI_SUBAGENT_TEMP_ROOT) {
     const fallback = path.join(os.tmpdir(), `pi-subagents-${resolveTempScopeId()}`);
-    if (!configured?.trim())
+    if (configured === undefined || configured.trim().length === 0) {
         return fallback;
+    }
     const resolved = path.resolve(configured);
     if (!path.basename(resolved).startsWith("pi-subagents-")) {
         throw new Error("PI_SUBAGENT_TEMP_ROOT must name a dedicated 'pi-subagents-*' directory.");
@@ -88,67 +94,104 @@ export const SLASH_SUBAGENT_CANCEL_EVENT = "subagent:slash:cancel";
 export const POLL_INTERVAL_MS = 1000;
 export const MAX_WIDGET_JOBS = 4;
 export const DEFAULT_SUBAGENT_MAX_DEPTH = 1;
-export const SUBAGENT_ACTIONS = ["list", "get", "create", "update", "delete", "status", "history", "search", "interrupt", "extend", "resume", "nudge", "questions", "answer", "review", "doctor"];
+export const SUBAGENT_ACTIONS = [
+    "list",
+    "get",
+    "create",
+    "update",
+    "delete",
+    "status",
+    "history",
+    "search",
+    "interrupt",
+    "extend",
+    "resume",
+    "nudge",
+    "questions",
+    "answer",
+    "review",
+    "doctor",
+];
 export const DEFAULT_FORK_PREAMBLE = "You are a delegated subagent running from a fork of the parent session. " +
     "Treat the inherited conversation as reference-only context, not a live thread to continue. " +
     "Do not continue or answer prior messages as if they are waiting for a reply. " +
     "Your sole job is to execute the task below and return a focused result for that task using your tools.";
 function normalizeTopLevelParallelValue(value) {
-    const parsed = typeof value === "number" ? value : typeof value === "string" ? Number(value) : NaN;
-    if (!Number.isInteger(parsed) || parsed < 1)
+    let parsed = NaN;
+    if (typeof value === "number") {
+        parsed = value;
+    }
+    else if (typeof value === "string") {
+        parsed = Number(value);
+    }
+    if (!Number.isInteger(parsed) || parsed < 1) {
         return undefined;
+    }
     return parsed;
 }
 export function resolveTopLevelParallelMaxTasks(value) {
     return normalizeTopLevelParallelValue(value) ?? MAX_PARALLEL;
 }
 export function resolveTopLevelParallelConcurrency(override, configValue) {
-    return normalizeTopLevelParallelValue(override)
-        ?? normalizeTopLevelParallelValue(configValue)
-        ?? MAX_CONCURRENCY;
+    return (normalizeTopLevelParallelValue(override) ??
+        normalizeTopLevelParallelValue(configValue) ??
+        MAX_CONCURRENCY);
 }
 export function getAsyncConfigPath(suffix) {
     return path.join(TEMP_ROOT_DIR, `async-cfg-${suffix}.json`);
 }
 export function wrapForkTask(task, preamble) {
-    if (preamble === false)
+    if (preamble === false) {
         return task;
+    }
     const effectivePreamble = preamble ?? DEFAULT_FORK_PREAMBLE;
     const wrappedPrefix = `${effectivePreamble}\n\nTask:\n`;
-    if (task.startsWith(wrappedPrefix))
+    if (task.startsWith(wrappedPrefix)) {
         return task;
+    }
     return `${wrappedPrefix}${task}`;
 }
 // ============================================================================
 // Recursion Depth Guard
 // ============================================================================
 export function normalizeMaxSubagentDepth(value) {
-    const parsed = typeof value === "number" ? value : typeof value === "string" ? Number(value) : NaN;
-    if (!Number.isInteger(parsed) || parsed < 0)
+    let parsed = NaN;
+    if (typeof value === "number") {
+        parsed = value;
+    }
+    else if (typeof value === "string") {
+        parsed = Number(value);
+    }
+    if (!Number.isInteger(parsed) || parsed < 0) {
         return undefined;
+    }
     return parsed;
 }
 export function resolveCurrentMaxSubagentDepth(configMaxDepth) {
-    return normalizeMaxSubagentDepth(process.env.PI_SUBAGENT_MAX_DEPTH)
-        ?? normalizeMaxSubagentDepth(configMaxDepth)
-        ?? DEFAULT_SUBAGENT_MAX_DEPTH;
+    return (normalizeMaxSubagentDepth(process.env.PI_SUBAGENT_MAX_DEPTH) ??
+        normalizeMaxSubagentDepth(configMaxDepth) ??
+        DEFAULT_SUBAGENT_MAX_DEPTH);
 }
 export function resolveChildMaxSubagentDepth(parentMaxDepth, agentMaxDepth) {
     const normalizedParent = normalizeMaxSubagentDepth(parentMaxDepth) ?? DEFAULT_SUBAGENT_MAX_DEPTH;
     const normalizedAgent = normalizeMaxSubagentDepth(agentMaxDepth);
-    return normalizedAgent === undefined ? normalizedParent : Math.min(normalizedParent, normalizedAgent);
+    return normalizedAgent === undefined
+        ? normalizedParent
+        : Math.min(normalizedParent, normalizedAgent);
 }
 function parseSubagentDepth(value) {
-    if (value === undefined || value === null || value === "")
+    if (value === undefined || value === null || value === "") {
         return 0;
+    }
     const depth = Number(value);
     return Number.isInteger(depth) && depth >= 0 ? depth : undefined;
 }
 export function checkSubagentDepth(configMaxDepth) {
     const maxDepth = resolveCurrentMaxSubagentDepth(configMaxDepth);
     const depth = parseSubagentDepth(process.env.PI_SUBAGENT_DEPTH);
-    if (depth === undefined)
+    if (depth === undefined) {
         return { blocked: true, depth: maxDepth, maxDepth };
+    }
     return { blocked: depth >= maxDepth, depth, maxDepth };
 }
 export function getSubagentDepthEnv(maxDepth) {
@@ -164,10 +207,12 @@ export function getSubagentDepthEnv(maxDepth) {
 // Utility Functions
 // ============================================================================
 function formatBytes(bytes) {
-    if (bytes < 1024)
+    if (bytes < 1024) {
         return `${bytes}B`;
-    if (bytes < 1024 * 1024)
+    }
+    if (bytes < 1024 * 1024) {
         return `${(bytes / 1024).toFixed(1)}KB`;
+    }
     return `${(bytes / (1024 * 1024)).toFixed(1)}MB`;
 }
 export function truncateOutput(output, config, artifactPath) {
@@ -196,7 +241,7 @@ export function truncateOutput(output, config, artifactPath) {
         result = result.slice(0, low);
     }
     const keptLines = result.split("\n").length;
-    const marker = `[TRUNCATED: showing first ${keptLines} of ${lines.length} lines, ${formatBytes(Buffer.byteLength(result))} of ${formatBytes(bytes)}${artifactPath ? ` - full output at ${artifactPath}` : ""}]\n`;
+    const marker = `[TRUNCATED: showing first ${keptLines} of ${lines.length} lines, ${formatBytes(Buffer.byteLength(result))} of ${formatBytes(bytes)}${artifactPath !== undefined && artifactPath.length > 0 ? ` - full output at ${artifactPath}` : ""}]\n`;
     return {
         text: marker + result,
         truncated: true,

package/dist/shared/unknown.js

@@ -0,0 +1,52 @@
+export function isRecord(value) {
+    return typeof value === "object" && value !== null && !Array.isArray(value);
+}
+export function isUnknownArray(value) {
+    return Array.isArray(value);
+}
+export function recordAt(value, key) {
+    let child;
+    if (isRecord(value)) {
+        child = value[key];
+    }
+    else if (isUnknownArray(value) && typeof key === "number") {
+        child = value[key];
+    }
+    return isRecord(child) ? child : undefined;
+}
+export function errorMessage(error) {
+    try {
+        if (error instanceof Error) {
+            return error.message;
+        }
+        if (typeof error === "string") {
+            return error;
+        }
+        if (error === undefined) {
+            return "undefined";
+        }
+        if (typeof error === "number" ||
+            typeof error === "boolean" ||
+            typeof error === "bigint" ||
+            typeof error === "symbol") {
+            return String(error);
+        }
+        const serialized = JSON.stringify(error);
+        return typeof serialized === "string" ? serialized : "Unserializable failure";
+    }
+    catch {
+        return "Unserializable failure";
+    }
+}
+export function hasErrorCode(error, code) {
+    return isRecord(error) && error.code === code;
+}
+/** Retain native error names without letting a broken stringifier replace the caught failure. */
+export function errorDescription(error) {
+    try {
+        return error instanceof Error ? error.toString() : errorMessage(error);
+    }
+    catch {
+        return errorMessage(error);
+    }
+}