@fitchmultz/pi-mcp-adapter 8.0.11 → 8.0.13

package/CHANGELOG.md

@@ -7,6 +7,33 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## 8.0.13 - 2026-11-03
+
+<!-- npm-release:unreleased:start -->
+<!-- npm-release:unreleased:end -->
+
+- Enforce strict lint on MCP sampling bridge (#166) ([bb87eb1](https://github.com/fitchmultz/pi-mcp-adapter/commit/bb87eb14405d9231fb404dc8c50743b3c3757620))
+- Enforce strict lint on native manager configuration tests (#168) ([998be45](https://github.com/fitchmultz/pi-mcp-adapter/commit/998be4523d16239614f4c0f0ca55006660488c23))
+
+### What's Changed
+
+- Enforce strict lint on MCP sampling bridge by @fitchmultz in https://github.com/fitchmultz/pi-mcp-adapter/pull/166
+- Enforce strict lint on native manager configuration tests by @fitchmultz in https://github.com/fitchmultz/pi-mcp-adapter/pull/168
+
+**Full Changelog**: https://github.com/fitchmultz/pi-mcp-adapter/compare/v8.0.12...v8.0.13
+
+## 8.0.12 - 2026-11-03
+
+<!-- npm-release:unreleased:start -->
+<!-- npm-release:unreleased:end -->
+
+### What's Changed
+
+- Enforce strict lint on HTTP callback lifetimes by @fitchmultz in https://github.com/fitchmultz/pi-mcp-adapter/pull/163
+- Enforce strict lint on native command panels by @fitchmultz in https://github.com/fitchmultz/pi-mcp-adapter/pull/165
+
+**Full Changelog**: https://github.com/fitchmultz/pi-mcp-adapter/compare/v8.0.11...v8.0.12
+
 ## 8.0.11 - 2026-11-03
 
 <!-- npm-release:unreleased:start -->

package/dist/sampling-handler.d.ts

@@ -1,6 +1,6 @@
 import type { Api, Model } from "@earendil-works/pi-ai";
 import type { ExtensionUIContext, ModelRegistry } from "@earendil-works/pi-coding-agent";
-import { type Client, type CreateMessageRequest, type CreateMessageResult } from "@modelcontextprotocol/client";
+import type { Client, CreateMessageRequest, CreateMessageResult } from "@modelcontextprotocol/client";
 export interface SamplingHandlerOptions {
     serverName: string;
     autoApprove: boolean;

package/dist/sampling-handler.js

@@ -1,6 +1,5 @@
 import { truncateAtWord } from "./utils.js";
 import { throwIfAborted } from "./abort.js";
-import {} from "@modelcontextprotocol/client";
 export function registerSamplingHandler(client, options, own = (run) => run()) {
     // Own the handler's real promise, not the SDK caller's cancellable response facade.
     client.setRequestHandler("sampling/createMessage", (request) => own(() => handleSamplingRequest(options, request)));
@@ -9,51 +8,57 @@ export async function handleSamplingRequest(options, request) {
     const params = request.params;
     const signal = options.getSignal();
     throwIfAborted(signal);
+    validateSamplingFeatures(params);
+    const messages = params.messages.map(convertSamplingMessage);
+    const model = await resolveSamplingModel(options, params.modelPreferences);
+    throwIfAborted(signal);
+    await confirmSampling(options, "Approve MCP sampling request", formatRequestApproval(options.serverName, `${model.provider}/${model.id}`, params.systemPrompt, messages));
+    throwIfAborted(signal);
+    const result = await options.modelRegistry.complete(model, {
+        ...(params.systemPrompt !== undefined ? { systemPrompt: params.systemPrompt } : {}),
+        messages,
+    }, samplingCompletionOptions(model, params, signal));
+    const converted = convertAssistantResult(result);
+    throwIfAborted(signal);
+    await confirmSampling(options, "Return MCP sampling response", formatResponseApproval(options.serverName, converted));
+    return converted;
+}
+function validateSamplingFeatures(params) {
     if ("task" in params && params.task) {
         throw new Error("MCP sampling tasks are not supported");
     }
-    if (params.includeContext && params.includeContext !== "none") {
+    if (params.includeContext !== undefined && params.includeContext !== "none") {
         throw new Error("MCP sampling context inclusion is not supported");
     }
-    if (params.tools?.length) {
+    if (params.tools && params.tools.length > 0) {
         throw new Error("MCP sampling tool use is not supported");
     }
     if (params.toolChoice) {
         throw new Error("MCP sampling tool choice is not supported");
     }
-    if (params.stopSequences?.length) {
+    if (params.stopSequences && params.stopSequences.length > 0) {
         throw new Error("MCP sampling stop sequences are not supported");
     }
-    const messages = params.messages.map(convertSamplingMessage);
-    const model = await resolveSamplingModel(options, params.modelPreferences);
-    throwIfAborted(signal);
-    await confirmSampling(options, "Approve MCP sampling request", formatRequestApproval(options.serverName, `${model.provider}/${model.id}`, params.systemPrompt, messages));
-    throwIfAborted(signal);
+}
+function samplingCompletionOptions(model, params, signal) {
     const supportsTemperature = model.compat && "supportsTemperature" in model.compat
         ? model.compat.supportsTemperature !== false
         : !(model.id === "gpt-6-astra" &&
             (model.api === "openai-responses" || model.api === "openai-codex-responses"));
-    const result = await options.modelRegistry.complete(model, {
-        ...(params.systemPrompt !== undefined ? { systemPrompt: params.systemPrompt } : {}),
-        messages,
-    }, {
+    return {
         maxTokens: params.maxTokens,
         ...(supportsTemperature && params.temperature !== undefined
             ? { temperature: params.temperature }
             : {}),
         ...(params.metadata !== undefined ? { metadata: params.metadata } : {}),
         ...(signal ? { signal } : {}),
-    });
-    const converted = convertAssistantResult(result);
-    throwIfAborted(signal);
-    await confirmSampling(options, "Return MCP sampling response", formatResponseApproval(options.serverName, converted));
-    return converted;
+    };
 }
 function formatRequestApproval(serverName, modelName, systemPrompt, messages) {
     const lines = [
         `${serverName} wants to sample ${messages.length} message${messages.length === 1 ? "" : "s"} with ${modelName}.`,
     ];
-    if (systemPrompt) {
+    if (systemPrompt !== undefined && systemPrompt !== "") {
         lines.push(`System: ${truncateAtWord(systemPrompt, 400)}`);
     }
     for (const [index, message] of messages.entries()) {
@@ -80,19 +85,16 @@ function messageText(message) {
         if (block.type === "thinking") {
             return "[thinking]";
         }
-        if (block.type === "toolCall") {
-            return `[tool call: ${block.name}]`;
-        }
-        return "[content]";
+        return `[tool call: ${block.name}]`;
     })
         .join("\n");
 }
-async function resolveSamplingModel(options, modelPreferences) {
+function samplingCandidates(options, modelPreferences) {
     const candidates = [];
     const availableModels = options.modelRegistry.getAvailable();
     for (const hint of modelPreferences?.hints ?? []) {
-        const normalizedHint = hint.name?.trim().toLowerCase();
-        if (!normalizedHint) {
+        const normalizedHint = (hint.name ?? "").trim().toLowerCase();
+        if (normalizedHint === "") {
             continue;
         }
         for (const model of availableModels) {
@@ -109,6 +111,10 @@ async function resolveSamplingModel(options, modelPreferences) {
     for (const model of availableModels) {
         addSamplingCandidate(candidates, model);
     }
+    return candidates;
+}
+async function resolveSamplingModel(options, modelPreferences) {
+    const candidates = samplingCandidates(options, modelPreferences);
     const errors = [];
     const signal = options.getSignal();
     for (const model of candidates) {
@@ -188,14 +194,14 @@ function convertAssistantResult(message) {
             return block.text;
         }
         if (block.type === "thinking") {
-            return undefined;
+            return;
         }
         throw new Error(`MCP sampling result ${block.type} content is not supported`);
     })
         .filter((value) => value !== undefined)
         .join("\n\n")
         .trim();
-    if (!text) {
+    if (text === "") {
         throw new Error("MCP sampling result did not contain text content");
     }
     return {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@fitchmultz/pi-mcp-adapter",
-  "version": "8.0.11",
+  "version": "8.0.13",
   "description": "Token-efficient MCP adapter for the Pi coding agent",
   "type": "module",
   "types": "./dist/index.d.ts",
@@ -45,6 +45,7 @@
     "lint:prompts": "oxlint --deny-warnings __tests__/prompts.test.ts __tests__/prompts-sdk-integration.test.ts __tests__/test-state.ts __tests__/test-extension-context.ts",
     "lint:runtime-tests": "oxlint --deny-warnings __tests__/runtime",
     "lint:tracing": "oxlint --deny-warnings mcp-trace.ts",
+    "lint:sampling": "oxlint --deny-warnings sampling-handler.ts",
     "lint:sdk-http": "oxlint --deny-warnings __tests__/sdk-v2-http.test.ts __tests__/fixtures/native-capture-extension.ts",
     "lint:lifecycle-tests": "oxlint --deny-warnings __tests__/index-lifecycle.test.ts __tests__/fixtures/extension-lifecycle.ts __tests__/test-extension-context.ts",
     "lint:oauth-recovery": "oxlint --deny-warnings __tests__/oauth-recovery-integration.test.ts __tests__/fixtures/oauth-recovery-http.ts __tests__/fixtures/oauth-recovery.ts __tests__/fixtures/panel-host.ts",