@fitchmultz/pi-ask-question 0.6.3 → 0.6.5

package/extensions/lib/question-observer.ts

@@ -17,7 +17,7 @@ type Waiting = Target & {
 };
 
 function record(data: unknown): Record<string, unknown> | undefined {
-  return data !== null && typeof data === "object" ? data as Record<string, unknown> : undefined;
+  return data !== null && typeof data === "object" ? (data as Record<string, unknown>) : undefined;
 }
 
 function validId(value: unknown): value is string {
@@ -41,25 +41,46 @@ export function createQuestionObserver(pi: ExtensionAPI) {
   const unsubscribeQuery = pi.events.on("pi-ask-question:query", (data) => {
     const query = record(data);
     if (!query || !validId(query.queryId)) return;
-    const waiting = query.protocolVersion === protocolVersion && mode === "tui" ? current?.() : undefined;
+    const waiting =
+      query.protocolVersion === protocolVersion && mode === "tui" ? current?.() : undefined;
     pi.events.emit("pi-ask-question:snapshot", {
-      queryId: query.queryId, ...identity(), mode,
+      queryId: query.queryId,
+      ...identity(),
+      mode,
       status: query.protocolVersion !== protocolVersion || mode !== "tui" ? "unsupported" : "idle",
       ...waiting,
     });
   });
   const unsubscribeLookup = pi.events.on("pi-ask-question:lookup", (data) => {
     const query = record(data);
-    if (!query || !validId(query.queryId) || !validId(query.requestId) || typeof query.promptId !== "string") return;
-    const status = query.protocolVersion !== protocolVersion || mode !== "tui" ? "unsupported"
-      : query.ownerGeneration !== ownerGeneration || query.nativeRoot !== nativeRoot ? "stale" : undefined;
-    const receipt = status ? undefined : accepted.get(JSON.stringify([query.promptId, query.requestId]));
+    if (
+      !query ||
+      !validId(query.queryId) ||
+      !validId(query.requestId) ||
+      typeof query.promptId !== "string"
+    )
+      return;
+    const status =
+      query.protocolVersion !== protocolVersion || mode !== "tui"
+        ? "unsupported"
+        : query.ownerGeneration !== ownerGeneration || query.nativeRoot !== nativeRoot
+          ? "stale"
+          : undefined;
+    const receipt = status
+      ? undefined
+      : accepted.get(JSON.stringify([query.promptId, query.requestId]));
     pi.events.emit("pi-ask-question:lookup-result", {
-      queryId: query.queryId, ...identity(), promptId: query.promptId, requestId: query.requestId,
-      status: status ?? (receipt ? "answered" : "unknown"), ...receipt,
+      queryId: query.queryId,
+      ...identity(),
+      promptId: query.promptId,
+      requestId: query.requestId,
+      status: status ?? (receipt ? "answered" : "unknown"),
+      ...receipt,
     });
   });
-  pi.on("session_start", (_event, ctx) => { identify(ctx); });
+  pi.on("session_start", (_event, ctx) => {
+    identify(ctx);
+  });
   pi.on("session_shutdown", () => {
     current = undefined;
     accepted.clear();
@@ -72,20 +93,40 @@ export function createQuestionObserver(pi: ExtensionAPI) {
     identity,
     watch(getState: () => Waiting | undefined) {
       current = getState;
-      return () => { if (current === getState) current = undefined; };
+      return () => {
+        if (current === getState) current = undefined;
+      };
     },
     matches(request: Record<string, unknown>, deadline: number) {
       // Existing unversioned clients keep their original prompt/revision contract.
-      return request.protocolVersion === undefined ||
-        (request.protocolVersion === protocolVersion && request.ownerGeneration === ownerGeneration &&
-          request.nativeRoot === nativeRoot && request.deadline === deadline);
+      return (
+        request.protocolVersion === undefined ||
+        (request.protocolVersion === protocolVersion &&
+          request.ownerGeneration === ownerGeneration &&
+          request.nativeRoot === nativeRoot &&
+          request.deadline === deadline)
+      );
     },
     accept(target: Target, requestId: string, answer: string | string[]) {
       const answerFingerprint = createHash("sha256")
-        .update(JSON.stringify([protocolVersion, ownerGeneration, nativeRoot, target.promptId,
-          target.questionId, target.revision, target.deadline, answer]))
+        .update(
+          JSON.stringify([
+            protocolVersion,
+            ownerGeneration,
+            nativeRoot,
+            target.promptId,
+            target.questionId,
+            target.revision,
+            target.deadline,
+            answer,
+          ]),
+        )
         .digest("hex");
-      accepted.set(JSON.stringify([target.promptId, requestId]), { ...target, requestId, answerFingerprint });
+      accepted.set(JSON.stringify([target.promptId, requestId]), {
+        ...target,
+        requestId,
+        answerFingerprint,
+      });
       if (accepted.size > 1024) accepted.delete(accepted.keys().next().value!);
     },
   };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@fitchmultz/pi-ask-question",
-  "version": "0.6.3",
+  "version": "0.6.5",
   "description": "Pi extension that adds an interactive ask_question tool and /grill-me pressure-test mode",
   "author": "Mitch Fultz (https://github.com/fitchmultz)",
   "license": "MIT",
@@ -31,8 +31,13 @@
   "scripts": {
     "test": "node --test tests/*.test.ts",
     "typecheck": "tsc --noEmit",
+    "lint": "oxlint --deny-warnings .",
+    "lint:agent": "oxlint --deny-warnings --format=agent .",
+    "lint:fix": "oxlint --fix .",
+    "format": "oxfmt --write .",
+    "format:check": "oxfmt --check .",
     "check:compat": "npm run check",
-    "check": "npm test && npm run typecheck && npm pack --dry-run",
+    "check": "npm test && npm run typecheck && npm run format:check && npm pack --dry-run",
     "prepublishOnly": "npm run check"
   },
   "files": [
@@ -66,6 +71,9 @@
     "@earendil-works/pi-coding-agent": "1.4.0",
     "@earendil-works/pi-tui": "1.4.0",
     "@types/node": "24.19.1",
+    "oxfmt": "0.75.0",
+    "oxlint": "1.90.0",
+    "oxlint-tsgolint": "7.0.2005",
     "typebox": "1.3.34",
     "typescript": "7.0.2"
   },