@firstpick/pi-package-webui 0.9.1 → 0.9.3
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/README.md +31 -9
- package/bin/pi-webui-launcher.mjs +23 -12
- package/bin/pi-webui.mjs +729 -93
- package/index.ts +266 -1
- package/lib/agent-run-adapters.mjs +500 -0
- package/lib/agent-run-protocol.mjs +262 -0
- package/lib/agent-run-registry.mjs +339 -0
- package/lib/git-workflow-preferences.mjs +18 -28
- package/lib/intercom-conversations.mjs +491 -0
- package/lib/intercom-transcript-filter.mjs +99 -0
- package/lib/resource-selection.mjs +140 -0
- package/lib/trust-boundaries.mjs +2 -0
- package/lib/ui-layout-settings.mjs +172 -28
- package/lib/update/package-layout.mjs +50 -0
- package/lib/update/plan.mjs +11 -0
- package/package.json +2 -2
- package/public/app.js +2276 -419
- package/public/index.html +142 -72
- package/public/service-worker.js +2 -1
- package/public/stream-output-controller.mjs +15 -0
- package/public/styles.css +764 -92
- package/public/syntax-highlight.mjs +622 -0
- package/tests/agent-run-adapters.test.mjs +217 -0
- package/tests/agent-run-launcher.test.mjs +41 -0
- package/tests/agent-run-protocol.test.mjs +82 -0
- package/tests/agent-run-registry.test.mjs +102 -0
- package/tests/boot-failure-diagnostics.test.mjs +3 -3
- package/tests/browser/control-deck-side-panels.spec.mjs +354 -0
- package/tests/browser/controls-layout.spec.mjs +122 -0
- package/tests/browser/file-tree-git-ignored.spec.mjs +113 -0
- package/tests/browser/interaction-continuity.spec.mjs +161 -0
- package/tests/browser/intercom-conversation-viewer.spec.mjs +355 -0
- package/tests/browser/mobile-foundation.spec.mjs +26 -0
- package/tests/browser/model-search-focus.spec.mjs +96 -0
- package/tests/browser/optimistic-prompt.spec.mjs +22 -0
- package/tests/browser/persistent-ui-layout.spec.mjs +285 -66
- package/tests/browser/resource-profiles.spec.mjs +200 -0
- package/tests/browser/subagent-observability.spec.mjs +116 -0
- package/tests/codex-fast-mode-static.test.mjs +7 -6
- package/tests/common-options-submenus-interaction-static.test.mjs +2 -0
- package/tests/common-options-submenus-markup-static.test.mjs +1 -0
- package/tests/component-update-api-static.test.mjs +2 -1
- package/tests/composer-action-grid-reorder-static.test.mjs +3 -3
- package/tests/composer-skill-tag-layout.test.mjs +32 -2
- package/tests/control-deck-component-updates-static.test.mjs +6 -0
- package/tests/control-deck-side-panels-static.test.mjs +68 -0
- package/tests/controls-layout-static.test.mjs +22 -0
- package/tests/fast-mode-client-static.test.mjs +2 -2
- package/tests/feature-decision-output-popup-static.test.mjs +2 -2
- package/tests/feature-system-prompt-optional-feature-static.test.mjs +5 -5
- package/tests/file-tree-git-ignored-static.test.mjs +152 -0
- package/tests/file-tree-search-layout-static.test.mjs +2 -1
- package/tests/file-viewer-image-static.test.mjs +69 -0
- package/tests/fixtures/fake-pi.mjs +147 -12
- package/tests/foreground-transcript-catch-up-static.test.mjs +1 -1
- package/tests/git-panel-file-preview-static.test.mjs +5 -5
- package/tests/git-panel-live-updates-static.test.mjs +3 -3
- package/tests/git-workflow-preferences.test.mjs +55 -6
- package/tests/http-endpoints-harness.test.mjs +295 -14
- package/tests/intercom-conversation-viewer-static.test.mjs +105 -0
- package/tests/intercom-conversations-http.test.mjs +252 -0
- package/tests/intercom-conversations.test.mjs +374 -0
- package/tests/intercom-main-transcript-suppression-static.test.mjs +52 -0
- package/tests/intercom-tag-layout-static.test.mjs +46 -0
- package/tests/intercom-transcript-filter.test.mjs +98 -0
- package/tests/main-output-loading-static.test.mjs +59 -0
- package/tests/middle-button-drag-scroll-static.test.mjs +3 -3
- package/tests/mobile-compact-layout.test.mjs +2 -3
- package/tests/mobile-continuity-tablet-static.test.mjs +6 -6
- package/tests/mobile-foundation-static.test.mjs +3 -3
- package/tests/mobile-phone-experience-static.test.mjs +1 -1
- package/tests/mobile-static.test.mjs +76 -42
- package/tests/native-parity.test.mjs +8 -7
- package/tests/open-issue-wizard-static.test.mjs +2 -2
- package/tests/optional-feature-migration-frontend.test.mjs +5 -5
- package/tests/optional-feature-resource-setup-static.test.mjs +29 -0
- package/tests/persistent-ui-layout-static.test.mjs +13 -13
- package/tests/questionnaire-dialog.test.mjs +3 -3
- package/tests/remote-auth-settings-harness.test.mjs +1 -1
- package/tests/resource-defaults-helper.test.mjs +60 -6
- package/tests/resource-selection.test.mjs +114 -0
- package/tests/resource-tui-extension.test.mjs +23 -0
- package/tests/session-sampling-ui-static.test.mjs +3 -3
- package/tests/side-panel-context-menu-static.test.mjs +1 -1
- package/tests/side-panel-resize-static.test.mjs +26 -16
- package/tests/side-panel-section-height-removal-static.test.mjs +4 -4
- package/tests/side-panel-section-reorder-static.test.mjs +16 -70
- package/tests/stream-output-controller.test.mjs +8 -0
- package/tests/stream-output-isolation-static.test.mjs +2 -2
- package/tests/streaming-ui-coupling.test.mjs +5 -0
- package/tests/subagent-gate-visibility.test.mjs +2 -1
- package/tests/subagent-launch-slots.test.mjs +1 -1
- package/tests/subagent-observability-static.test.mjs +32 -0
- package/tests/subagent-reliability-integration.test.mjs +183 -0
- package/tests/subagent-workflow-section-static.test.mjs +67 -0
- package/tests/subagents-helper.test.mjs +548 -5
- package/tests/syntax-highlight.test.mjs +235 -0
- package/tests/syntax-highlighting-static.test.mjs +84 -0
- package/tests/terminal-tabs-resize-static.test.mjs +35 -0
- package/tests/theme-customizer-static.test.mjs +5 -5
- package/tests/thinking-format-parser.test.mjs +64 -0
- package/tests/ui-layout-settings.test.mjs +104 -32
- package/tests/update-api-harness.test.mjs +24 -10
- package/tests/update-package-layout.test.mjs +38 -0
- package/tests/update-plan.test.mjs +11 -1
- package/tests/webui-settings-locking.test.mjs +33 -3
- package/webui-rpc-helper.mjs +700 -89
|
@@ -120,6 +120,28 @@ test("run indicator remains visible and stable on mobile until delayed agent sta
|
|
|
120
120
|
await expect(page.locator("#chat .message.assistant").last()).toContainText("continuity stream complete");
|
|
121
121
|
});
|
|
122
122
|
|
|
123
|
+
test("run indicator keeps one-line geometry across changing activity text", async ({ page }) => {
|
|
124
|
+
await page.setViewportSize({ width: 760, height: 844 });
|
|
125
|
+
await page.goto(baseURL);
|
|
126
|
+
await page.locator("#promptInput").fill("fixture continuity delayed start");
|
|
127
|
+
await page.locator("#sendButton").click();
|
|
128
|
+
|
|
129
|
+
const runIndicator = page.locator("#runIndicatorHost .runIndicator");
|
|
130
|
+
await expect(runIndicator).toBeVisible();
|
|
131
|
+
const geometry = await runIndicator.evaluate((node) => {
|
|
132
|
+
const meta = node.querySelector(".run-indicator-meta");
|
|
133
|
+
const before = node.getBoundingClientRect();
|
|
134
|
+
meta.textContent = "Running tool: subagent_wait with a deliberately long activity description that must not wrap or resize the running status card · run time 1m 00s";
|
|
135
|
+
const after = node.getBoundingClientRect();
|
|
136
|
+
return {
|
|
137
|
+
heightDrift: Math.abs(after.height - before.height),
|
|
138
|
+
topDrift: Math.abs(after.top - before.top),
|
|
139
|
+
};
|
|
140
|
+
});
|
|
141
|
+
expect(geometry.heightDrift).toBeLessThanOrEqual(1.5);
|
|
142
|
+
expect(geometry.topDrift).toBeLessThanOrEqual(1.5);
|
|
143
|
+
});
|
|
144
|
+
|
|
123
145
|
test("confirmed streaming replaces routing status before delayed activity events", async ({ page }) => {
|
|
124
146
|
await page.goto(baseURL);
|
|
125
147
|
await page.locator("#promptInput").fill("fixture continuity confirmed before tool");
|
|
@@ -19,6 +19,7 @@ const layoutKeys = {
|
|
|
19
19
|
footerOrder: "pi-webui-footer-scoped-model-order-v1",
|
|
20
20
|
terminalLayout: "pi-webui-terminal-tabs-layout",
|
|
21
21
|
terminalGroups: "pi-webui-terminal-custom-groups-v1",
|
|
22
|
+
terminalSidebarWidth: "pi-webui-terminal-tabs-sidebar-width",
|
|
22
23
|
fileViewerWidth: "pi-webui-file-viewer-width",
|
|
23
24
|
sidePanelWidth: "pi-webui-side-panel-width",
|
|
24
25
|
};
|
|
@@ -113,12 +114,14 @@ async function seedStaleServerLayout() {
|
|
|
113
114
|
sidePanelWidth: 352,
|
|
114
115
|
expectedLayoutRevision: current.data.layoutRevision,
|
|
115
116
|
layout: {
|
|
116
|
-
version:
|
|
117
|
+
version: 2,
|
|
117
118
|
sidePanel: {
|
|
118
|
-
|
|
119
|
+
placement: "right",
|
|
120
|
+
sectionLayout: { order: ["git", "files", "controls"], leftSectionIds: [] },
|
|
119
121
|
collapsedSectionIds: [],
|
|
120
122
|
hiddenSectionIds: [],
|
|
121
|
-
|
|
123
|
+
collapsedPanels: { left: false, right: false },
|
|
124
|
+
panelWidths: { left: 384, right: 352 },
|
|
122
125
|
},
|
|
123
126
|
composerActions: { order: ["send", "new"], grid: null },
|
|
124
127
|
footerScopedModelOrder: ["fake/fake-gamma", "fake/fake-beta", "fake/fake-model"],
|
|
@@ -130,9 +133,7 @@ async function seedStaleServerLayout() {
|
|
|
130
133
|
}
|
|
131
134
|
|
|
132
135
|
async function sectionOrder(page) {
|
|
133
|
-
return page.locator("
|
|
134
|
-
sections.map((section) => section.dataset.sidePanelSection)
|
|
135
|
-
));
|
|
136
|
+
return page.locator("[data-control-deck-body]:not([hidden]) > [data-side-panel-section]").evaluateAll((sections) => sections.map((section) => section.dataset.sidePanelSection));
|
|
136
137
|
}
|
|
137
138
|
|
|
138
139
|
async function localLayout(page) {
|
|
@@ -145,6 +146,7 @@ async function localLayout(page) {
|
|
|
145
146
|
footerOrder: json(keys.footerOrder),
|
|
146
147
|
terminalLayout: localStorage.getItem(keys.terminalLayout),
|
|
147
148
|
terminalGroups: json(keys.terminalGroups),
|
|
149
|
+
terminalSidebarWidth: Number(localStorage.getItem(keys.terminalSidebarWidth)),
|
|
148
150
|
fileViewerWidth: Number(localStorage.getItem(keys.fileViewerWidth)),
|
|
149
151
|
sidePanelWidth: Number(localStorage.getItem(keys.sidePanelWidth)),
|
|
150
152
|
};
|
|
@@ -161,6 +163,15 @@ async function installScopedModelFixture(page) {
|
|
|
161
163
|
});
|
|
162
164
|
}
|
|
163
165
|
|
|
166
|
+
async function setTerminalLayout(page, layout) {
|
|
167
|
+
const controls = page.locator('[data-side-panel-section-toggle="controls"]');
|
|
168
|
+
if (await controls.getAttribute("aria-expanded") !== "true") await controls.click();
|
|
169
|
+
const select = page.locator("#terminalTabsLayoutSelect");
|
|
170
|
+
await expect(select).toBeVisible();
|
|
171
|
+
await select.selectOption(layout);
|
|
172
|
+
await expect(select).toHaveValue(layout);
|
|
173
|
+
}
|
|
174
|
+
|
|
164
175
|
async function openFooterModelPicker(page) {
|
|
165
176
|
const trigger = page.locator(".footer-tui-model, .footer-model.footer-meta-action").first();
|
|
166
177
|
await expect(trigger).toBeVisible();
|
|
@@ -193,18 +204,13 @@ async function composerColumnCount(page) {
|
|
|
193
204
|
});
|
|
194
205
|
}
|
|
195
206
|
|
|
196
|
-
|
|
197
|
-
|
|
198
|
-
|
|
199
|
-
for (const width of [...new Set(candidates)]) {
|
|
200
|
-
await page.setViewportSize({ width, height: current.height });
|
|
201
|
-
await page.evaluate(() => new Promise((resolve) => requestAnimationFrame(() => requestAnimationFrame(resolve))));
|
|
202
|
-
if (await composerColumnCount(page) === columns) return width;
|
|
203
|
-
}
|
|
204
|
-
throw new Error(`Could not reproduce the stored ${columns}-column composer geometry`);
|
|
207
|
+
|
|
208
|
+
async function suppressUnrelatedUpdateNotification(page) {
|
|
209
|
+
await page.addStyleTag({ content: "#updateNotification { display: none !important; }" });
|
|
205
210
|
}
|
|
206
211
|
|
|
207
212
|
async function assertRestoredLayout(page, expected, { expectCustomGroup = null } = {}) {
|
|
213
|
+
await suppressUnrelatedUpdateNotification(page);
|
|
208
214
|
await expect.poll(() => sectionOrder(page)).toEqual(expected.sideOrder);
|
|
209
215
|
await expect.poll(() => localLayout(page)).toMatchObject({
|
|
210
216
|
sideOrder: expected.sideOrder,
|
|
@@ -212,16 +218,28 @@ async function assertRestoredLayout(page, expected, { expectCustomGroup = null }
|
|
|
212
218
|
composerGrid: expected.composerGrid,
|
|
213
219
|
footerOrder: expected.footerOrder,
|
|
214
220
|
terminalLayout: "left",
|
|
221
|
+
terminalSidebarWidth: expected.terminalSidebarWidth,
|
|
215
222
|
fileViewerWidth: expected.fileViewerWidth,
|
|
216
223
|
sidePanelWidth: expected.sidePanelWidth,
|
|
217
224
|
});
|
|
218
225
|
await expect(page.locator("body")).toHaveClass(/terminal-tabs-left/);
|
|
219
226
|
await expect(page.locator("#terminalTabsLayoutSelect")).toHaveValue("left");
|
|
227
|
+
await expect.poll(async () => Number(await page.locator("#terminalTabsResizeHandle").getAttribute("aria-valuenow"))).toBe(expected.terminalSidebarWidth);
|
|
220
228
|
await expect.poll(async () => Number(await page.locator("#sidePanelResizeHandle").getAttribute("aria-valuenow"))).toBeGreaterThanOrEqual(320);
|
|
221
229
|
await expect.poll(async () => Number(await page.locator("#sidePanelResizeHandle").getAttribute("aria-valuenow"))).toBeLessThanOrEqual(expected.sidePanelWidth);
|
|
222
230
|
await expect(page.locator("[data-side-panel-section-resize]")).toHaveCount(0);
|
|
223
|
-
const
|
|
224
|
-
await
|
|
231
|
+
const deterministicComposerWidth = 2200;
|
|
232
|
+
await page.setViewportSize({ width: deterministicComposerWidth, height: 1000 });
|
|
233
|
+
await setTerminalLayout(page, "top");
|
|
234
|
+
const options = page.locator('[data-composer-action-id="options"]');
|
|
235
|
+
await expect.poll(async () => {
|
|
236
|
+
const columns = await composerColumnCount(page);
|
|
237
|
+
const column = Number(await options.evaluate((node) => node.style.getPropertyValue("--composer-action-grid-column")));
|
|
238
|
+
return column >= 1 && column <= columns;
|
|
239
|
+
}).toBe(true);
|
|
240
|
+
const projectedOptionsColumn = Number(await options.evaluate((node) => node.style.getPropertyValue("--composer-action-grid-column")));
|
|
241
|
+
await setTerminalLayout(page, "left");
|
|
242
|
+
await expect(page.locator("body")).toHaveClass(/terminal-tabs-left/);
|
|
225
243
|
if (expectCustomGroup === true) await expect(page.locator(".terminal-tab-custom-group")).toHaveCount(1);
|
|
226
244
|
if (expectCustomGroup === false) await expect(page.locator(".terminal-tab-custom-group")).toHaveCount(0);
|
|
227
245
|
|
|
@@ -234,7 +252,7 @@ async function assertRestoredLayout(page, expected, { expectCustomGroup = null }
|
|
|
234
252
|
await expect(page.locator("#fileViewerPane")).toBeVisible();
|
|
235
253
|
await expect.poll(() => page.locator("#fileViewerResizeHandle").getAttribute("aria-valuenow")).toBe(String(expected.fileViewerWidth));
|
|
236
254
|
await page.locator("#fileViewerCloseButton").click();
|
|
237
|
-
return
|
|
255
|
+
return { width: deterministicComposerWidth, projectedOptionsColumn };
|
|
238
256
|
}
|
|
239
257
|
|
|
240
258
|
test.beforeAll(async () => {
|
|
@@ -256,6 +274,67 @@ test.afterAll(async () => {
|
|
|
256
274
|
await rm(tempRoot, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
257
275
|
});
|
|
258
276
|
|
|
277
|
+
test("collapsed tracked skill tags expand upward and keep hidden tags selectable", async ({ browser }) => {
|
|
278
|
+
const tabs = await serverApi("/api/tabs");
|
|
279
|
+
const tabId = tabs.data.tabs[0].id;
|
|
280
|
+
const names = [
|
|
281
|
+
"subagent-governance",
|
|
282
|
+
"feature-development-workflow",
|
|
283
|
+
"repository-explorer",
|
|
284
|
+
"accessibility-review",
|
|
285
|
+
"release-verification",
|
|
286
|
+
"browser-regression-testing",
|
|
287
|
+
"documentation-maintenance",
|
|
288
|
+
"interface-consistency-check",
|
|
289
|
+
];
|
|
290
|
+
const entries = names.map((name, index) => ({
|
|
291
|
+
name,
|
|
292
|
+
firstSeenAt: 1_000 + index,
|
|
293
|
+
lastSeenAt: 2_000 + index,
|
|
294
|
+
kinds: ["read"],
|
|
295
|
+
sources: ["browser-test"],
|
|
296
|
+
path: `/skills/${name}/SKILL.md`,
|
|
297
|
+
paths: [`/skills/${name}/SKILL.md`],
|
|
298
|
+
}));
|
|
299
|
+
const context = await browser.newContext({ viewport: { width: 820, height: 720 } });
|
|
300
|
+
await context.addInitScript(({ activeTabId, storedEntries }) => {
|
|
301
|
+
localStorage.setItem("pi-webui-skill-usage-v1", JSON.stringify({
|
|
302
|
+
version: 1,
|
|
303
|
+
tabs: { [activeTabId]: storedEntries },
|
|
304
|
+
}));
|
|
305
|
+
}, { activeTabId: tabId, storedEntries: entries });
|
|
306
|
+
const page = await context.newPage();
|
|
307
|
+
await page.goto(baseURL);
|
|
308
|
+
await suppressUnrelatedUpdateNotification(page);
|
|
309
|
+
|
|
310
|
+
const overflow = page.locator("#sessionSkillTags > button.composer-skill-tag.overflow");
|
|
311
|
+
const menu = page.locator("#sessionSkillOverflowMenu");
|
|
312
|
+
await expect(overflow).toBeVisible();
|
|
313
|
+
const hiddenCount = Number((await overflow.textContent())?.replace("+", ""));
|
|
314
|
+
assert.ok(hiddenCount > 0, "the narrow fixture should collapse at least one tracked skill");
|
|
315
|
+
|
|
316
|
+
await overflow.click();
|
|
317
|
+
await expect(overflow).toHaveAttribute("aria-expanded", "true");
|
|
318
|
+
await expect(menu).toBeVisible();
|
|
319
|
+
await expect(menu.locator("button:not([hidden])")).toHaveCount(hiddenCount);
|
|
320
|
+
const [overflowBox, menuBox] = await Promise.all([overflow.boundingBox(), menu.boundingBox()]);
|
|
321
|
+
assert.ok(overflowBox && menuBox && menuBox.y + menuBox.height <= overflowBox.y + 1, "the popup should render above the +X disclosure");
|
|
322
|
+
|
|
323
|
+
await page.keyboard.press("Escape");
|
|
324
|
+
await expect(menu).toBeHidden();
|
|
325
|
+
await expect(overflow).toBeFocused();
|
|
326
|
+
|
|
327
|
+
await overflow.click();
|
|
328
|
+
await page.locator("#promptInput").click();
|
|
329
|
+
await expect(menu).toBeHidden();
|
|
330
|
+
|
|
331
|
+
await overflow.click();
|
|
332
|
+
await menu.locator("button:not([hidden])").first().click();
|
|
333
|
+
await expect(menu).toBeHidden();
|
|
334
|
+
await expect(overflow).toHaveAttribute("aria-expanded", "false");
|
|
335
|
+
await context.close();
|
|
336
|
+
});
|
|
337
|
+
|
|
259
338
|
test("server-owned layout survives stale reads, failed writes, localStorage clear, and process restart", async ({ browser }) => {
|
|
260
339
|
test.setTimeout(90_000);
|
|
261
340
|
|
|
@@ -300,6 +379,7 @@ test("server-owned layout survives stale reads, failed writes, localStorage clea
|
|
|
300
379
|
});
|
|
301
380
|
|
|
302
381
|
await page.goto(baseURL);
|
|
382
|
+
await suppressUnrelatedUpdateNotification(page);
|
|
303
383
|
await staleGetReady;
|
|
304
384
|
await expect(page.locator("#sidePanel")).toBeVisible();
|
|
305
385
|
await expect(page.locator('[data-composer-action-id="options"]')).toBeVisible();
|
|
@@ -341,6 +421,12 @@ test("server-owned layout survives stale reads, failed writes, localStorage clea
|
|
|
341
421
|
await expect(page.locator("#terminalTabsLayoutSelect")).toBeVisible();
|
|
342
422
|
await page.locator("#terminalTabsLayoutSelect").selectOption("left");
|
|
343
423
|
await expect(page.locator("body")).toHaveClass(/terminal-tabs-left/);
|
|
424
|
+
const terminalTabsResize = page.locator("#terminalTabsResizeHandle");
|
|
425
|
+
await expect(terminalTabsResize).toBeVisible();
|
|
426
|
+
await terminalTabsResize.focus();
|
|
427
|
+
await terminalTabsResize.press("Shift+ArrowLeft");
|
|
428
|
+
const expectedTerminalSidebarWidth = Number(await terminalTabsResize.getAttribute("aria-valuenow"));
|
|
429
|
+
expect(expectedTerminalSidebarWidth).toBeGreaterThan(208);
|
|
344
430
|
const options = page.locator('[data-composer-action-id="options"]');
|
|
345
431
|
const optionsBox = await options.boundingBox();
|
|
346
432
|
expect(optionsBox).toBeTruthy();
|
|
@@ -374,6 +460,7 @@ test("server-owned layout survives stale reads, failed writes, localStorage clea
|
|
|
374
460
|
footerOrder: expectedFooterOrder,
|
|
375
461
|
fileViewerWidth: expectedFileViewerWidth,
|
|
376
462
|
sidePanelWidth: expectedSidePanelWidth,
|
|
463
|
+
terminalSidebarWidth: expectedTerminalSidebarWidth,
|
|
377
464
|
optionsColumn,
|
|
378
465
|
};
|
|
379
466
|
|
|
@@ -385,10 +472,10 @@ test("server-owned layout survives stale reads, failed writes, localStorage clea
|
|
|
385
472
|
await page.evaluate(() => window.dispatchEvent(new Event("online")));
|
|
386
473
|
|
|
387
474
|
await expect.poll(async () => (await serverApi("/api/interface-preferences")).data.layout).toMatchObject({
|
|
388
|
-
sidePanel: {
|
|
475
|
+
sidePanel: { sectionLayout: { order: expected.sideOrder } },
|
|
389
476
|
composerActions: { order: expected.composerOrder, grid: expected.composerGrid },
|
|
390
477
|
footerScopedModelOrder: expected.footerOrder,
|
|
391
|
-
terminalTabs: { layout: "left", customGroups: expected.terminalGroups },
|
|
478
|
+
terminalTabs: { layout: "left", customGroups: expected.terminalGroups, sidebarWidth: expected.terminalSidebarWidth },
|
|
392
479
|
fileViewerWidth: expected.fileViewerWidth,
|
|
393
480
|
});
|
|
394
481
|
await expect.poll(async () => (await serverApi("/api/interface-preferences")).data.preferences.sidePanelWidth).toBe(expected.sidePanelWidth);
|
|
@@ -396,20 +483,30 @@ test("server-owned layout survives stale reads, failed writes, localStorage clea
|
|
|
396
483
|
await page.evaluate(() => localStorage.clear());
|
|
397
484
|
expect(await page.evaluate(() => localStorage.length)).toBe(0);
|
|
398
485
|
await page.reload();
|
|
399
|
-
const
|
|
486
|
+
const deterministicComposer = await assertRestoredLayout(page, expected, { expectCustomGroup: true });
|
|
400
487
|
|
|
401
488
|
await page.setViewportSize({ width: 700, height: 900 });
|
|
402
489
|
await expect(page.locator("body")).not.toHaveClass(/composer-action-grid-enabled/);
|
|
403
490
|
await expect.poll(() => page.evaluate((key) => JSON.parse(localStorage.getItem(key) || "null"), layoutKeys.composerGrid)).toEqual(expected.composerGrid);
|
|
404
|
-
await page.setViewportSize({ width:
|
|
405
|
-
await
|
|
491
|
+
await page.setViewportSize({ width: deterministicComposer.width, height: 1000 });
|
|
492
|
+
await setTerminalLayout(page, "top");
|
|
493
|
+
await expect.poll(async () => {
|
|
494
|
+
const columns = await composerColumnCount(page);
|
|
495
|
+
const column = Number(await options.evaluate((node) => node.style.getPropertyValue("--composer-action-grid-column")));
|
|
496
|
+
return column >= 1 && column <= columns;
|
|
497
|
+
}).toBe(true);
|
|
498
|
+
await expect.poll(() => page.evaluate((key) => JSON.parse(localStorage.getItem(key) || "null"), layoutKeys.composerGrid)).toEqual(expected.composerGrid);
|
|
499
|
+
await setTerminalLayout(page, "left");
|
|
500
|
+
await expect(page.locator("body")).toHaveClass(/terminal-tabs-left/);
|
|
501
|
+
await expect.poll(async () => (await serverApi("/api/interface-preferences")).data.layout.terminalTabs.layout).toBe("left");
|
|
406
502
|
|
|
407
503
|
await context.close();
|
|
408
504
|
await stopServer();
|
|
409
505
|
const settingsOnDisk = JSON.parse(await readFile(settingsFile, "utf8"));
|
|
410
|
-
assert.deepEqual(settingsOnDisk.uiLayout.sidePanel.
|
|
506
|
+
assert.deepEqual(settingsOnDisk.uiLayout.sidePanel.sectionLayout.order, expected.sideOrder, "the private settings file should contain the browser-committed Control Deck order");
|
|
411
507
|
assert.equal("sectionHeights" in settingsOnDisk.uiLayout.sidePanel, false, "removed Control Deck section heights must not be persisted");
|
|
412
508
|
assert.deepEqual(settingsOnDisk.uiLayout.composerActions.grid, expected.composerGrid, "the private settings file should contain the exact sparse composer grid");
|
|
509
|
+
assert.equal(settingsOnDisk.uiLayout.terminalTabs.sidebarWidth, expected.terminalSidebarWidth, "the private settings file should contain the browser-committed terminal rail width");
|
|
413
510
|
assert.equal(settingsOnDisk.uiLayout.fileViewerWidth, expected.fileViewerWidth, "the private settings file should contain the browser-committed file-viewer width");
|
|
414
511
|
|
|
415
512
|
await startServer();
|
|
@@ -431,12 +528,14 @@ test("returning browsers adopt authoritative Control Deck state without echo wri
|
|
|
431
528
|
body: {
|
|
432
529
|
expectedLayoutRevision: current.data.layoutRevision,
|
|
433
530
|
layout: {
|
|
434
|
-
version:
|
|
531
|
+
version: 2,
|
|
435
532
|
sidePanel: {
|
|
436
|
-
|
|
533
|
+
placement: "right",
|
|
534
|
+
sectionLayout: { order: serverSideOrder, leftSectionIds: [] },
|
|
437
535
|
collapsedSectionIds: [],
|
|
438
536
|
hiddenSectionIds: [],
|
|
439
|
-
|
|
537
|
+
collapsedPanels: { left: false, right: false },
|
|
538
|
+
panelWidths: { left: 384, right: 352 },
|
|
440
539
|
},
|
|
441
540
|
},
|
|
442
541
|
},
|
|
@@ -462,9 +561,9 @@ test("returning browsers adopt authoritative Control Deck state without echo wri
|
|
|
462
561
|
await page.waitForTimeout(700);
|
|
463
562
|
expect(layoutPuts).toBe(0);
|
|
464
563
|
const persisted = await serverApi("/api/interface-preferences");
|
|
465
|
-
assert.deepEqual(persisted.data.layout.sidePanel.
|
|
564
|
+
assert.deepEqual(persisted.data.layout.sidePanel.sectionLayout.order, serverSideOrder);
|
|
466
565
|
assert.equal("sectionHeights" in persisted.data.layout.sidePanel, false);
|
|
467
|
-
assert.equal(persisted.data.layout.sidePanel.
|
|
566
|
+
assert.equal(persisted.data.layout.sidePanel.collapsedPanels.right, false);
|
|
468
567
|
|
|
469
568
|
const controlsToggle = page.locator('[data-side-panel-section-toggle="controls"]');
|
|
470
569
|
if (await controlsToggle.getAttribute("aria-expanded") !== "true") await controlsToggle.click();
|
|
@@ -486,7 +585,7 @@ test("failed layout writes remain pending across reload and later synchronize",
|
|
|
486
585
|
method: "PUT",
|
|
487
586
|
body: {
|
|
488
587
|
expectedLayoutRevision: current.data.layoutRevision,
|
|
489
|
-
layout: { version:
|
|
588
|
+
layout: { version: 2, composerActions: { order: ["send", "new"], grid: null } },
|
|
490
589
|
},
|
|
491
590
|
});
|
|
492
591
|
|
|
@@ -510,14 +609,14 @@ test("failed layout writes remain pending across reload and later synchronize",
|
|
|
510
609
|
await newSession.press("Alt+ArrowLeft");
|
|
511
610
|
await expect.poll(() => page.evaluate((key) => JSON.parse(localStorage.getItem(key) || "[]").slice(0, 2), layoutKeys.composerOrder)).toEqual(["new", "send"]);
|
|
512
611
|
await expect.poll(() => failedWrites).toBeGreaterThan(0);
|
|
513
|
-
await expect.poll(() => page.evaluate(() => Object.keys(localStorage).find((key) => key.startsWith("pi-webui-ui-layout-pending-
|
|
612
|
+
await expect.poll(() => page.evaluate(() => Object.keys(localStorage).find((key) => key.startsWith("pi-webui-ui-layout-pending-v4:")) || null)).not.toBeNull();
|
|
514
613
|
|
|
515
614
|
await page.reload();
|
|
516
615
|
await expect.poll(() => page.evaluate((key) => JSON.parse(localStorage.getItem(key) || "[]").slice(0, 2), layoutKeys.composerOrder)).toEqual(["new", "send"]);
|
|
517
616
|
allowWrites = true;
|
|
518
617
|
await page.evaluate(() => window.dispatchEvent(new Event("online")));
|
|
519
618
|
await expect.poll(async () => (await serverApi("/api/interface-preferences")).data.layout.composerActions.order.slice(0, 2)).toEqual(["new", "send"]);
|
|
520
|
-
await expect.poll(() => page.evaluate(() => Object.keys(localStorage).find((key) => key.startsWith("pi-webui-ui-layout-pending-
|
|
619
|
+
await expect.poll(() => page.evaluate(() => Object.keys(localStorage).find((key) => key.startsWith("pi-webui-ui-layout-pending-v4:")) || null)).toBeNull();
|
|
521
620
|
await context.close();
|
|
522
621
|
});
|
|
523
622
|
|
|
@@ -529,12 +628,14 @@ test("conflict retry updates only the changed Control Deck subfield", async ({ b
|
|
|
529
628
|
body: {
|
|
530
629
|
expectedLayoutRevision: current.data.layoutRevision,
|
|
531
630
|
layout: {
|
|
532
|
-
version:
|
|
631
|
+
version: 2,
|
|
533
632
|
sidePanel: {
|
|
534
|
-
|
|
633
|
+
placement: "right",
|
|
634
|
+
sectionLayout: { order: initialOrder, leftSectionIds: [] },
|
|
535
635
|
collapsedSectionIds: [],
|
|
536
636
|
hiddenSectionIds: [],
|
|
537
|
-
|
|
637
|
+
collapsedPanels: { left: false, right: false },
|
|
638
|
+
panelWidths: { left: 384, right: 352 },
|
|
538
639
|
},
|
|
539
640
|
},
|
|
540
641
|
},
|
|
@@ -553,13 +654,13 @@ test("conflict retry updates only the changed Control Deck subfield", async ({ b
|
|
|
553
654
|
await controlsA.focus();
|
|
554
655
|
await controlsA.press("Alt+ArrowDown");
|
|
555
656
|
const newerOrder = ["files", "git", "controls"];
|
|
556
|
-
await expect.poll(async () => (await serverApi("/api/interface-preferences")).data.layout.sidePanel.
|
|
657
|
+
await expect.poll(async () => (await serverApi("/api/interface-preferences")).data.layout.sidePanel.sectionLayout.order.slice(0, newerOrder.length)).toEqual(newerOrder);
|
|
557
658
|
|
|
558
|
-
await pageB.locator("#toggleSidePanelButton").click();
|
|
559
|
-
await expect(pageB.locator("body")).toHaveClass(/side-panel-collapsed/);
|
|
560
|
-
await expect.poll(async () => (await serverApi("/api/interface-preferences")).data.layout.sidePanel.
|
|
659
|
+
await pageB.locator("#toggleSidePanelButton").evaluate((button) => button.click());
|
|
660
|
+
await expect(pageB.locator("body")).toHaveClass(/side-panel-right-collapsed/);
|
|
661
|
+
await expect.poll(async () => (await serverApi("/api/interface-preferences")).data.layout.sidePanel.collapsedPanels.right).toBe(true);
|
|
561
662
|
const final = await serverApi("/api/interface-preferences");
|
|
562
|
-
assert.deepEqual(final.data.layout.sidePanel.
|
|
663
|
+
assert.deepEqual(final.data.layout.sidePanel.sectionLayout.order.slice(0, newerOrder.length), newerOrder, "a stale collapse retry must not revert another browser's newer section order");
|
|
563
664
|
|
|
564
665
|
await Promise.all([contextA.close(), contextB.close()]);
|
|
565
666
|
});
|
|
@@ -571,12 +672,14 @@ test("one tab cannot erase another tab's failed pending journal", async ({ brows
|
|
|
571
672
|
body: {
|
|
572
673
|
expectedLayoutRevision: current.data.layoutRevision,
|
|
573
674
|
layout: {
|
|
574
|
-
version:
|
|
675
|
+
version: 2,
|
|
575
676
|
sidePanel: {
|
|
576
|
-
|
|
677
|
+
placement: "right",
|
|
678
|
+
sectionLayout: { order: ["files", "controls", "git"], leftSectionIds: [] },
|
|
577
679
|
collapsedSectionIds: [],
|
|
578
680
|
hiddenSectionIds: [],
|
|
579
|
-
|
|
681
|
+
collapsedPanels: { left: false, right: false },
|
|
682
|
+
panelWidths: { left: 384, right: 352 },
|
|
580
683
|
},
|
|
581
684
|
composerActions: { order: ["send", "new"], grid: null },
|
|
582
685
|
},
|
|
@@ -604,12 +707,12 @@ test("one tab cannot erase another tab's failed pending journal", async ({ brows
|
|
|
604
707
|
await newSession.evaluate((button) => button.dispatchEvent(new KeyboardEvent("keydown", { key: "ArrowLeft", altKey: true, bubbles: true })));
|
|
605
708
|
await expect.poll(() => pageA.evaluate((key) => JSON.parse(localStorage.getItem(key) || "[]").slice(0, 2), layoutKeys.composerOrder)).toEqual(["new", "send"]);
|
|
606
709
|
await expect.poll(() => failedComposerWrites).toBeGreaterThan(0);
|
|
607
|
-
await expect.poll(() => pageA.evaluate(() => Object.keys(localStorage).filter((key) => key.startsWith("pi-webui-ui-layout-pending-
|
|
710
|
+
await expect.poll(() => pageA.evaluate(() => Object.keys(localStorage).filter((key) => key.startsWith("pi-webui-ui-layout-pending-v4:")).length)).toBeGreaterThan(0);
|
|
608
711
|
|
|
609
|
-
await pageB.locator("#toggleSidePanelButton").click();
|
|
610
|
-
await expect.poll(async () => (await serverApi("/api/interface-preferences")).data.layout.sidePanel.
|
|
712
|
+
await pageB.locator("#toggleSidePanelButton").evaluate((button) => button.click());
|
|
713
|
+
await expect.poll(async () => (await serverApi("/api/interface-preferences")).data.layout.sidePanel.collapsedPanels.right).toBe(true);
|
|
611
714
|
await expect.poll(() => pageB.evaluate(() => Object.keys(localStorage)
|
|
612
|
-
.filter((key) => key.startsWith("pi-webui-ui-layout-pending-
|
|
715
|
+
.filter((key) => key.startsWith("pi-webui-ui-layout-pending-v4:"))
|
|
613
716
|
.map((key) => JSON.parse(localStorage.getItem(key) || "null"))
|
|
614
717
|
.some((record) => record?.field === "composerActions"))).toBe(true);
|
|
615
718
|
|
|
@@ -629,12 +732,14 @@ test("in-flight sibling acknowledgement clears only the acknowledged subfield",
|
|
|
629
732
|
body: {
|
|
630
733
|
expectedLayoutRevision: current.data.layoutRevision,
|
|
631
734
|
layout: {
|
|
632
|
-
version:
|
|
735
|
+
version: 2,
|
|
633
736
|
sidePanel: {
|
|
634
|
-
|
|
737
|
+
placement: "right",
|
|
738
|
+
sectionLayout: { order: initialOrder, leftSectionIds: [] },
|
|
635
739
|
collapsedSectionIds: [],
|
|
636
740
|
hiddenSectionIds: [],
|
|
637
|
-
|
|
741
|
+
collapsedPanels: { left: false, right: false },
|
|
742
|
+
panelWidths: { left: 384, right: 352 },
|
|
638
743
|
},
|
|
639
744
|
},
|
|
640
745
|
},
|
|
@@ -659,7 +764,7 @@ test("in-flight sibling acknowledgement clears only the acknowledged subfield",
|
|
|
659
764
|
await pageA.route("**/api/interface-preferences", async (route) => {
|
|
660
765
|
const request = route.request();
|
|
661
766
|
const payload = request.method() === "PUT" ? request.postDataJSON() : null;
|
|
662
|
-
if (interceptWrites && payload?.layout && !firstOrderIntercepted && payload.layout.sidePanel?.
|
|
767
|
+
if (interceptWrites && payload?.layout && !firstOrderIntercepted && payload.layout.sidePanel?.sectionLayout) {
|
|
663
768
|
firstOrderIntercepted = true;
|
|
664
769
|
const response = await route.fetch();
|
|
665
770
|
firstOrderFetched();
|
|
@@ -685,23 +790,135 @@ test("in-flight sibling acknowledgement clears only the acknowledged subfield",
|
|
|
685
790
|
const controlsA = pageA.locator('[data-side-panel-section-toggle="controls"]');
|
|
686
791
|
await controlsA.evaluate((button) => button.dispatchEvent(new KeyboardEvent("keydown", { key: "ArrowDown", altKey: true, bubbles: true })));
|
|
687
792
|
await firstOrderFetchedPromise;
|
|
688
|
-
await pageA.locator("#toggleSidePanelButton").click();
|
|
793
|
+
await pageA.locator("#toggleSidePanelButton").evaluate((button) => button.click());
|
|
689
794
|
releaseFirstOrder();
|
|
690
795
|
await secondWriteSeenPromise;
|
|
691
|
-
assert.equal(Object.hasOwn(secondPayload.layout.sidePanel || {}, "
|
|
692
|
-
assert.equal(secondPayload.layout.sidePanel?.
|
|
796
|
+
assert.equal(Object.hasOwn(secondPayload.layout.sidePanel || {}, "sectionLayout"), false, "the acknowledged order must not remain in the pending collapse patch");
|
|
797
|
+
assert.equal(secondPayload.layout.sidePanel?.collapsedPanels?.right, true);
|
|
693
798
|
|
|
694
799
|
const controlsB = pageB.locator('[data-side-panel-section-toggle="controls"]');
|
|
695
800
|
await controlsB.evaluate((button) => button.dispatchEvent(new KeyboardEvent("keydown", { key: "ArrowUp", altKey: true, bubbles: true })));
|
|
696
801
|
const browserBOrder = ["controls", "files", "git"];
|
|
697
|
-
await expect.poll(async () => (await serverApi("/api/interface-preferences")).data.layout.sidePanel.
|
|
802
|
+
await expect.poll(async () => (await serverApi("/api/interface-preferences")).data.layout.sidePanel.sectionLayout.order.slice(0, browserBOrder.length)).toEqual(browserBOrder);
|
|
698
803
|
releaseSecondWrite();
|
|
699
|
-
await expect.poll(async () => (await serverApi("/api/interface-preferences")).data.layout.sidePanel.
|
|
804
|
+
await expect.poll(async () => (await serverApi("/api/interface-preferences")).data.layout.sidePanel.collapsedPanels.right).toBe(true);
|
|
700
805
|
const final = await serverApi("/api/interface-preferences");
|
|
701
|
-
assert.deepEqual(final.data.layout.sidePanel.
|
|
806
|
+
assert.deepEqual(final.data.layout.sidePanel.sectionLayout.order.slice(0, browserBOrder.length), browserBOrder);
|
|
702
807
|
await Promise.all([contextA.close(), contextB.close()]);
|
|
703
808
|
});
|
|
704
809
|
|
|
810
|
+
test("same-origin sibling placement adoption cannot overwrite a dirty section layout", async ({ browser }) => {
|
|
811
|
+
test.setTimeout(60_000);
|
|
812
|
+
const current = await serverApi("/api/interface-preferences");
|
|
813
|
+
const initialOrder = ["controls", "files", "git"];
|
|
814
|
+
await serverApi("/api/interface-preferences", {
|
|
815
|
+
method: "PUT",
|
|
816
|
+
body: {
|
|
817
|
+
expectedLayoutRevision: current.data.layoutRevision,
|
|
818
|
+
layout: {
|
|
819
|
+
version: 2,
|
|
820
|
+
sidePanel: {
|
|
821
|
+
placement: "right",
|
|
822
|
+
sectionLayout: { order: initialOrder, leftSectionIds: [] },
|
|
823
|
+
collapsedSectionIds: [],
|
|
824
|
+
hiddenSectionIds: [],
|
|
825
|
+
collapsedPanels: { left: false, right: false },
|
|
826
|
+
panelWidths: { left: 384, right: 352 },
|
|
827
|
+
},
|
|
828
|
+
},
|
|
829
|
+
},
|
|
830
|
+
});
|
|
831
|
+
|
|
832
|
+
const context = await browser.newContext({ viewport: { width: 1900, height: 1000 } });
|
|
833
|
+
const pageA = await context.newPage();
|
|
834
|
+
const pageB = await context.newPage();
|
|
835
|
+
let failedSectionWrites = 0;
|
|
836
|
+
await pageA.route("**/api/interface-preferences", async (route) => {
|
|
837
|
+
const payload = route.request().method() === "PUT" ? route.request().postDataJSON() : null;
|
|
838
|
+
if (payload?.layout?.sidePanel?.sectionLayout) {
|
|
839
|
+
failedSectionWrites += 1;
|
|
840
|
+
await route.abort("failed");
|
|
841
|
+
return;
|
|
842
|
+
}
|
|
843
|
+
await route.continue();
|
|
844
|
+
});
|
|
845
|
+
await Promise.all([pageA.goto(baseURL), pageB.goto(baseURL)]);
|
|
846
|
+
await Promise.all([suppressUnrelatedUpdateNotification(pageA), suppressUnrelatedUpdateNotification(pageB)]);
|
|
847
|
+
await expect.poll(async () => (await sectionOrder(pageA)).slice(0, initialOrder.length)).toEqual(initialOrder);
|
|
848
|
+
await pageA.waitForTimeout(700);
|
|
849
|
+
await expect.poll(async () => (await sectionOrder(pageA)).slice(0, initialOrder.length)).toEqual(initialOrder);
|
|
850
|
+
|
|
851
|
+
const controlsA = pageA.locator('[data-side-panel-section-toggle="controls"]');
|
|
852
|
+
await controlsA.focus();
|
|
853
|
+
await expect(controlsA).toBeFocused();
|
|
854
|
+
await controlsA.press("Alt+ArrowDown");
|
|
855
|
+
const dirtyOrder = ["files", "controls", "git"];
|
|
856
|
+
await expect.poll(async () => (await sectionOrder(pageA)).slice(0, dirtyOrder.length)).toEqual(dirtyOrder);
|
|
857
|
+
await expect.poll(() => failedSectionWrites).toBeGreaterThan(0);
|
|
858
|
+
|
|
859
|
+
await setTerminalLayout(pageB, "top");
|
|
860
|
+
const controlsB = pageB.locator('[data-side-panel-section-toggle="controls"]');
|
|
861
|
+
if (await controlsB.getAttribute("aria-expanded") !== "true") await controlsB.click();
|
|
862
|
+
await pageB.locator("#controlDeckPlacementSelect").selectOption("both");
|
|
863
|
+
await expect(pageB.locator("body")).toHaveClass(/control-deck-both/);
|
|
864
|
+
await expect(pageA.locator("body")).toHaveClass(/control-deck-both/);
|
|
865
|
+
await expect.poll(async () => (await sectionOrder(pageA)).slice(0, dirtyOrder.length)).toEqual(dirtyOrder);
|
|
866
|
+
await expect.poll(() => pageA.evaluate(() => JSON.parse(localStorage.getItem("pi-webui-control-deck-layout-v2") || "null")?.placement)).toBe("both");
|
|
867
|
+
await context.close();
|
|
868
|
+
});
|
|
869
|
+
|
|
870
|
+
test("seeded v3 Control Deck journal recovers legacy fields without widening partial collapse", async ({ browser }) => {
|
|
871
|
+
const current = await serverApi("/api/interface-preferences");
|
|
872
|
+
await serverApi("/api/interface-preferences", {
|
|
873
|
+
method: "PUT",
|
|
874
|
+
body: {
|
|
875
|
+
expectedLayoutRevision: current.data.layoutRevision,
|
|
876
|
+
layout: {
|
|
877
|
+
version: 2,
|
|
878
|
+
sidePanel: {
|
|
879
|
+
placement: "right",
|
|
880
|
+
sectionLayout: { order: ["controls", "files", "git"], leftSectionIds: [] },
|
|
881
|
+
collapsedSectionIds: [],
|
|
882
|
+
hiddenSectionIds: [],
|
|
883
|
+
collapsedPanels: { left: true, right: true },
|
|
884
|
+
panelWidths: { left: 384, right: 352 },
|
|
885
|
+
},
|
|
886
|
+
},
|
|
887
|
+
},
|
|
888
|
+
});
|
|
889
|
+
|
|
890
|
+
const context = await browser.newContext({ viewport: { width: 1680, height: 1000 } });
|
|
891
|
+
await context.addInitScript(() => {
|
|
892
|
+
const prefix = "pi-webui-ui-layout-pending-v3:fixture:";
|
|
893
|
+
const records = [
|
|
894
|
+
["order", { version: 3, field: "sidePanel", subfield: "sectionOrder", value: ["git", "files", "controls"], updatedAt: 1 }],
|
|
895
|
+
["collapsed-sections", { version: 3, field: "sidePanel", subfield: "collapsedSectionIds", value: ["git"], updatedAt: 2 }],
|
|
896
|
+
["hidden-sections", { version: 3, field: "sidePanel", subfield: "hiddenSectionIds", value: ["queue"], updatedAt: 3 }],
|
|
897
|
+
["panel-collapse", { version: 3, field: "sidePanel", subfield: "collapsed", value: false, updatedAt: 4 }],
|
|
898
|
+
];
|
|
899
|
+
for (const [key, value] of records) localStorage.setItem(`${prefix}${key}`, JSON.stringify(value));
|
|
900
|
+
});
|
|
901
|
+
const page = await context.newPage();
|
|
902
|
+
const collapsePayloads = [];
|
|
903
|
+
await page.route("**/api/interface-preferences", async (route) => {
|
|
904
|
+
const payload = route.request().method() === "PUT" ? route.request().postDataJSON() : null;
|
|
905
|
+
if (payload?.layout?.sidePanel?.collapsedPanels) collapsePayloads.push(payload.layout.sidePanel.collapsedPanels);
|
|
906
|
+
await route.continue();
|
|
907
|
+
});
|
|
908
|
+
await page.goto(baseURL);
|
|
909
|
+
|
|
910
|
+
await expect.poll(async () => (await serverApi("/api/interface-preferences")).data.layout.sidePanel).toMatchObject({
|
|
911
|
+
sectionLayout: { order: ["git", "files", "controls"] },
|
|
912
|
+
collapsedSectionIds: ["git"],
|
|
913
|
+
hiddenSectionIds: ["queue"],
|
|
914
|
+
collapsedPanels: { left: true, right: false },
|
|
915
|
+
});
|
|
916
|
+
await expect.poll(() => collapsePayloads.length).toBeGreaterThan(0);
|
|
917
|
+
assert.deepEqual(collapsePayloads[0], { right: false }, "translated v3 collapse must remain a right-only partial mutation");
|
|
918
|
+
await expect.poll(() => page.evaluate(() => Object.keys(localStorage).some((key) => key.startsWith("pi-webui-ui-layout-pending-v3:fixture:")))).toBe(false);
|
|
919
|
+
await context.close();
|
|
920
|
+
});
|
|
921
|
+
|
|
705
922
|
test("a delayed GET cannot regress the revision acknowledged by a newer PUT", async ({ browser }) => {
|
|
706
923
|
const current = await serverApi("/api/interface-preferences");
|
|
707
924
|
await serverApi("/api/interface-preferences", {
|
|
@@ -709,12 +926,14 @@ test("a delayed GET cannot regress the revision acknowledged by a newer PUT", as
|
|
|
709
926
|
body: {
|
|
710
927
|
expectedLayoutRevision: current.data.layoutRevision,
|
|
711
928
|
layout: {
|
|
712
|
-
version:
|
|
929
|
+
version: 2,
|
|
713
930
|
sidePanel: {
|
|
714
|
-
|
|
931
|
+
placement: "right",
|
|
932
|
+
sectionLayout: { order: ["files", "controls", "git"], leftSectionIds: [] },
|
|
715
933
|
collapsedSectionIds: [],
|
|
716
934
|
hiddenSectionIds: [],
|
|
717
|
-
|
|
935
|
+
collapsedPanels: { left: false, right: false },
|
|
936
|
+
panelWidths: { left: 384, right: 352 },
|
|
718
937
|
},
|
|
719
938
|
},
|
|
720
939
|
},
|
|
@@ -741,7 +960,7 @@ test("a delayed GET cannot regress the revision acknowledged by a newer PUT", as
|
|
|
741
960
|
}
|
|
742
961
|
if (captureNextPut && request.method() === "PUT") {
|
|
743
962
|
const payload = request.postDataJSON();
|
|
744
|
-
if (Object.hasOwn(payload?.layout?.sidePanel || {}, "
|
|
963
|
+
if (Object.hasOwn(payload?.layout?.sidePanel || {}, "collapsedPanels")) {
|
|
745
964
|
captureNextPut = false;
|
|
746
965
|
capturedExpectedRevision = payload.expectedLayoutRevision;
|
|
747
966
|
}
|
|
@@ -761,24 +980,24 @@ test("a delayed GET cannot regress the revision acknowledged by a newer PUT", as
|
|
|
761
980
|
[newerOrder[controlsIndex], newerOrder[controlsIndex + moveOffset]] = [newerOrder[controlsIndex + moveOffset], newerOrder[controlsIndex]];
|
|
762
981
|
const newerPutResponse = page.waitForResponse((response) => {
|
|
763
982
|
if (!response.url().includes("/api/interface-preferences") || response.request().method() !== "PUT") return false;
|
|
764
|
-
return Array.isArray(response.request().postDataJSON()?.layout?.sidePanel?.
|
|
983
|
+
return Array.isArray(response.request().postDataJSON()?.layout?.sidePanel?.sectionLayout?.order);
|
|
765
984
|
});
|
|
766
985
|
await controls.evaluate((button, key) => button.dispatchEvent(new KeyboardEvent("keydown", { key, altKey: true, bubbles: true })), moveOffset > 0 ? "ArrowDown" : "ArrowUp");
|
|
767
986
|
await newerPutResponse;
|
|
768
|
-
await expect.poll(async () => (await serverApi("/api/interface-preferences")).data.layout.sidePanel.
|
|
987
|
+
await expect.poll(async () => (await serverApi("/api/interface-preferences")).data.layout.sidePanel.sectionLayout.order.slice(0, newerOrder.length)).toEqual(newerOrder);
|
|
769
988
|
await expect.poll(() => page.evaluate((prefix) => {
|
|
770
989
|
for (let index = 0; index < localStorage.length; index += 1) {
|
|
771
990
|
const key = localStorage.key(index);
|
|
772
991
|
if (!key?.startsWith(prefix)) continue;
|
|
773
992
|
try {
|
|
774
993
|
const record = JSON.parse(localStorage.getItem(key) || "null");
|
|
775
|
-
if (record?.field === "sidePanel" && record?.subfield === "
|
|
994
|
+
if (record?.field === "sidePanel" && record?.subfield === "sectionLayout") return true;
|
|
776
995
|
} catch {
|
|
777
996
|
// Ignore malformed unrelated records; production also fails soft here.
|
|
778
997
|
}
|
|
779
998
|
}
|
|
780
999
|
return false;
|
|
781
|
-
}, "pi-webui-ui-layout-pending-
|
|
1000
|
+
}, "pi-webui-ui-layout-pending-v4:")).toBe(false);
|
|
782
1001
|
releaseDelayedGet();
|
|
783
1002
|
await page.waitForTimeout(300);
|
|
784
1003
|
const revisionBeforeCollapse = (await serverApi("/api/interface-preferences")).data.layoutRevision;
|
|
@@ -786,6 +1005,6 @@ test("a delayed GET cannot regress the revision acknowledged by a newer PUT", as
|
|
|
786
1005
|
captureNextPut = true;
|
|
787
1006
|
await page.locator("#toggleSidePanelButton").evaluate((button) => button.click());
|
|
788
1007
|
await expect.poll(() => capturedExpectedRevision).toBe(revisionBeforeCollapse);
|
|
789
|
-
await expect.poll(async () => (await serverApi("/api/interface-preferences")).data.layout.sidePanel.
|
|
1008
|
+
await expect.poll(async () => (await serverApi("/api/interface-preferences")).data.layout.sidePanel.collapsedPanels.right).toBe(true);
|
|
790
1009
|
await context.close();
|
|
791
1010
|
});
|