@firstpick/pi-package-webui 0.9.0 → 0.9.2
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/README.md +236 -24
- package/bin/pi-webui-launcher.mjs +23 -12
- package/bin/pi-webui.mjs +493 -65
- package/lib/agent-run-adapters.mjs +500 -0
- package/lib/agent-run-protocol.mjs +262 -0
- package/lib/agent-run-registry.mjs +339 -0
- package/lib/app-runner-terminal.mjs +40 -0
- package/lib/git-workflow-preferences.mjs +11 -4
- package/lib/trust-boundaries.mjs +2 -0
- package/lib/ui-layout-settings.mjs +172 -28
- package/lib/update/package-layout.mjs +50 -0
- package/lib/update/plan.mjs +11 -0
- package/package.json +2 -2
- package/public/app.js +1376 -337
- package/public/index.html +113 -68
- package/public/service-worker.js +1 -1
- package/public/styles.css +371 -93
- package/tests/agent-run-adapters.test.mjs +217 -0
- package/tests/agent-run-launcher.test.mjs +41 -0
- package/tests/agent-run-protocol.test.mjs +82 -0
- package/tests/agent-run-registry.test.mjs +102 -0
- package/tests/app-runner-terminal-static.test.mjs +28 -0
- package/tests/app-runner-terminal.test.mjs +65 -0
- package/tests/boot-failure-diagnostics.test.mjs +3 -3
- package/tests/browser/control-deck-side-panels.spec.mjs +354 -0
- package/tests/browser/controls-layout.spec.mjs +122 -0
- package/tests/browser/file-tree-git-ignored.spec.mjs +113 -0
- package/tests/browser/interaction-continuity.spec.mjs +159 -0
- package/tests/browser/mobile-foundation.spec.mjs +26 -0
- package/tests/browser/model-search-focus.spec.mjs +96 -0
- package/tests/browser/optimistic-prompt.spec.mjs +22 -0
- package/tests/browser/persistent-ui-layout.spec.mjs +224 -66
- package/tests/browser/subagent-observability.spec.mjs +87 -0
- package/tests/chat-scroll-intent-static.test.mjs +1 -1
- package/tests/codex-fast-mode-static.test.mjs +2 -2
- package/tests/component-update-api-static.test.mjs +2 -1
- package/tests/composer-action-grid-reorder-static.test.mjs +3 -3
- package/tests/control-deck-component-updates-static.test.mjs +2 -0
- package/tests/control-deck-side-panels-static.test.mjs +68 -0
- package/tests/controls-layout-static.test.mjs +22 -0
- package/tests/fast-mode-client-static.test.mjs +1 -1
- package/tests/feature-decision-output-popup-static.test.mjs +2 -2
- package/tests/file-tree-git-ignored-static.test.mjs +152 -0
- package/tests/file-tree-search-layout-static.test.mjs +2 -1
- package/tests/fixtures/fake-pi.mjs +43 -7
- package/tests/footer-provider-usage-visual-static.test.mjs +10 -8
- package/tests/git-workflow-preferences.test.mjs +55 -6
- package/tests/http-endpoints-harness.test.mjs +173 -14
- package/tests/middle-button-drag-scroll-static.test.mjs +3 -3
- package/tests/mobile-continuity-tablet-static.test.mjs +3 -3
- package/tests/mobile-foundation-static.test.mjs +3 -3
- package/tests/mobile-phone-experience-static.test.mjs +1 -1
- package/tests/mobile-static.test.mjs +18 -5
- package/tests/open-issue-wizard-static.test.mjs +2 -2
- package/tests/persistent-ui-layout-static.test.mjs +13 -13
- package/tests/questionnaire-dialog.test.mjs +3 -3
- package/tests/remote-auth-settings-harness.test.mjs +1 -1
- package/tests/session-sampling-ui-static.test.mjs +3 -3
- package/tests/side-panel-context-menu-static.test.mjs +1 -1
- package/tests/side-panel-resize-static.test.mjs +26 -16
- package/tests/side-panel-section-height-removal-static.test.mjs +4 -4
- package/tests/side-panel-section-reorder-static.test.mjs +16 -70
- package/tests/subagent-gate-visibility.test.mjs +2 -1
- package/tests/subagent-launch-slots.test.mjs +1 -1
- package/tests/subagent-observability-static.test.mjs +32 -0
- package/tests/subagent-reliability-integration.test.mjs +161 -0
- package/tests/subagents-helper.test.mjs +344 -4
- package/tests/terminal-tabs-resize-static.test.mjs +35 -0
- package/tests/theme-customizer-static.test.mjs +1 -1
- package/tests/ui-layout-settings.test.mjs +104 -32
- package/tests/update-api-harness.test.mjs +24 -10
- package/tests/update-package-layout.test.mjs +38 -0
- package/tests/update-plan.test.mjs +11 -1
- package/tests/webui-settings-locking.test.mjs +33 -3
- package/webui-rpc-helper.mjs +417 -28
|
@@ -19,6 +19,7 @@ const layoutKeys = {
|
|
|
19
19
|
footerOrder: "pi-webui-footer-scoped-model-order-v1",
|
|
20
20
|
terminalLayout: "pi-webui-terminal-tabs-layout",
|
|
21
21
|
terminalGroups: "pi-webui-terminal-custom-groups-v1",
|
|
22
|
+
terminalSidebarWidth: "pi-webui-terminal-tabs-sidebar-width",
|
|
22
23
|
fileViewerWidth: "pi-webui-file-viewer-width",
|
|
23
24
|
sidePanelWidth: "pi-webui-side-panel-width",
|
|
24
25
|
};
|
|
@@ -113,12 +114,14 @@ async function seedStaleServerLayout() {
|
|
|
113
114
|
sidePanelWidth: 352,
|
|
114
115
|
expectedLayoutRevision: current.data.layoutRevision,
|
|
115
116
|
layout: {
|
|
116
|
-
version:
|
|
117
|
+
version: 2,
|
|
117
118
|
sidePanel: {
|
|
118
|
-
|
|
119
|
+
placement: "right",
|
|
120
|
+
sectionLayout: { order: ["git", "files", "controls"], leftSectionIds: [] },
|
|
119
121
|
collapsedSectionIds: [],
|
|
120
122
|
hiddenSectionIds: [],
|
|
121
|
-
|
|
123
|
+
collapsedPanels: { left: false, right: false },
|
|
124
|
+
panelWidths: { left: 384, right: 352 },
|
|
122
125
|
},
|
|
123
126
|
composerActions: { order: ["send", "new"], grid: null },
|
|
124
127
|
footerScopedModelOrder: ["fake/fake-gamma", "fake/fake-beta", "fake/fake-model"],
|
|
@@ -130,9 +133,7 @@ async function seedStaleServerLayout() {
|
|
|
130
133
|
}
|
|
131
134
|
|
|
132
135
|
async function sectionOrder(page) {
|
|
133
|
-
return page.locator("
|
|
134
|
-
sections.map((section) => section.dataset.sidePanelSection)
|
|
135
|
-
));
|
|
136
|
+
return page.locator("[data-control-deck-body]:not([hidden]) > [data-side-panel-section]").evaluateAll((sections) => sections.map((section) => section.dataset.sidePanelSection));
|
|
136
137
|
}
|
|
137
138
|
|
|
138
139
|
async function localLayout(page) {
|
|
@@ -145,6 +146,7 @@ async function localLayout(page) {
|
|
|
145
146
|
footerOrder: json(keys.footerOrder),
|
|
146
147
|
terminalLayout: localStorage.getItem(keys.terminalLayout),
|
|
147
148
|
terminalGroups: json(keys.terminalGroups),
|
|
149
|
+
terminalSidebarWidth: Number(localStorage.getItem(keys.terminalSidebarWidth)),
|
|
148
150
|
fileViewerWidth: Number(localStorage.getItem(keys.fileViewerWidth)),
|
|
149
151
|
sidePanelWidth: Number(localStorage.getItem(keys.sidePanelWidth)),
|
|
150
152
|
};
|
|
@@ -161,6 +163,15 @@ async function installScopedModelFixture(page) {
|
|
|
161
163
|
});
|
|
162
164
|
}
|
|
163
165
|
|
|
166
|
+
async function setTerminalLayout(page, layout) {
|
|
167
|
+
const controls = page.locator('[data-side-panel-section-toggle="controls"]');
|
|
168
|
+
if (await controls.getAttribute("aria-expanded") !== "true") await controls.click();
|
|
169
|
+
const select = page.locator("#terminalTabsLayoutSelect");
|
|
170
|
+
await expect(select).toBeVisible();
|
|
171
|
+
await select.selectOption(layout);
|
|
172
|
+
await expect(select).toHaveValue(layout);
|
|
173
|
+
}
|
|
174
|
+
|
|
164
175
|
async function openFooterModelPicker(page) {
|
|
165
176
|
const trigger = page.locator(".footer-tui-model, .footer-model.footer-meta-action").first();
|
|
166
177
|
await expect(trigger).toBeVisible();
|
|
@@ -193,18 +204,13 @@ async function composerColumnCount(page) {
|
|
|
193
204
|
});
|
|
194
205
|
}
|
|
195
206
|
|
|
196
|
-
|
|
197
|
-
|
|
198
|
-
|
|
199
|
-
for (const width of [...new Set(candidates)]) {
|
|
200
|
-
await page.setViewportSize({ width, height: current.height });
|
|
201
|
-
await page.evaluate(() => new Promise((resolve) => requestAnimationFrame(() => requestAnimationFrame(resolve))));
|
|
202
|
-
if (await composerColumnCount(page) === columns) return width;
|
|
203
|
-
}
|
|
204
|
-
throw new Error(`Could not reproduce the stored ${columns}-column composer geometry`);
|
|
207
|
+
|
|
208
|
+
async function suppressUnrelatedUpdateNotification(page) {
|
|
209
|
+
await page.addStyleTag({ content: "#updateNotification { display: none !important; }" });
|
|
205
210
|
}
|
|
206
211
|
|
|
207
212
|
async function assertRestoredLayout(page, expected, { expectCustomGroup = null } = {}) {
|
|
213
|
+
await suppressUnrelatedUpdateNotification(page);
|
|
208
214
|
await expect.poll(() => sectionOrder(page)).toEqual(expected.sideOrder);
|
|
209
215
|
await expect.poll(() => localLayout(page)).toMatchObject({
|
|
210
216
|
sideOrder: expected.sideOrder,
|
|
@@ -212,16 +218,28 @@ async function assertRestoredLayout(page, expected, { expectCustomGroup = null }
|
|
|
212
218
|
composerGrid: expected.composerGrid,
|
|
213
219
|
footerOrder: expected.footerOrder,
|
|
214
220
|
terminalLayout: "left",
|
|
221
|
+
terminalSidebarWidth: expected.terminalSidebarWidth,
|
|
215
222
|
fileViewerWidth: expected.fileViewerWidth,
|
|
216
223
|
sidePanelWidth: expected.sidePanelWidth,
|
|
217
224
|
});
|
|
218
225
|
await expect(page.locator("body")).toHaveClass(/terminal-tabs-left/);
|
|
219
226
|
await expect(page.locator("#terminalTabsLayoutSelect")).toHaveValue("left");
|
|
227
|
+
await expect.poll(async () => Number(await page.locator("#terminalTabsResizeHandle").getAttribute("aria-valuenow"))).toBe(expected.terminalSidebarWidth);
|
|
220
228
|
await expect.poll(async () => Number(await page.locator("#sidePanelResizeHandle").getAttribute("aria-valuenow"))).toBeGreaterThanOrEqual(320);
|
|
221
229
|
await expect.poll(async () => Number(await page.locator("#sidePanelResizeHandle").getAttribute("aria-valuenow"))).toBeLessThanOrEqual(expected.sidePanelWidth);
|
|
222
230
|
await expect(page.locator("[data-side-panel-section-resize]")).toHaveCount(0);
|
|
223
|
-
const
|
|
224
|
-
await
|
|
231
|
+
const deterministicComposerWidth = 2200;
|
|
232
|
+
await page.setViewportSize({ width: deterministicComposerWidth, height: 1000 });
|
|
233
|
+
await setTerminalLayout(page, "top");
|
|
234
|
+
const options = page.locator('[data-composer-action-id="options"]');
|
|
235
|
+
await expect.poll(async () => {
|
|
236
|
+
const columns = await composerColumnCount(page);
|
|
237
|
+
const column = Number(await options.evaluate((node) => node.style.getPropertyValue("--composer-action-grid-column")));
|
|
238
|
+
return column >= 1 && column <= columns;
|
|
239
|
+
}).toBe(true);
|
|
240
|
+
const projectedOptionsColumn = Number(await options.evaluate((node) => node.style.getPropertyValue("--composer-action-grid-column")));
|
|
241
|
+
await setTerminalLayout(page, "left");
|
|
242
|
+
await expect(page.locator("body")).toHaveClass(/terminal-tabs-left/);
|
|
225
243
|
if (expectCustomGroup === true) await expect(page.locator(".terminal-tab-custom-group")).toHaveCount(1);
|
|
226
244
|
if (expectCustomGroup === false) await expect(page.locator(".terminal-tab-custom-group")).toHaveCount(0);
|
|
227
245
|
|
|
@@ -234,7 +252,7 @@ async function assertRestoredLayout(page, expected, { expectCustomGroup = null }
|
|
|
234
252
|
await expect(page.locator("#fileViewerPane")).toBeVisible();
|
|
235
253
|
await expect.poll(() => page.locator("#fileViewerResizeHandle").getAttribute("aria-valuenow")).toBe(String(expected.fileViewerWidth));
|
|
236
254
|
await page.locator("#fileViewerCloseButton").click();
|
|
237
|
-
return
|
|
255
|
+
return { width: deterministicComposerWidth, projectedOptionsColumn };
|
|
238
256
|
}
|
|
239
257
|
|
|
240
258
|
test.beforeAll(async () => {
|
|
@@ -300,6 +318,7 @@ test("server-owned layout survives stale reads, failed writes, localStorage clea
|
|
|
300
318
|
});
|
|
301
319
|
|
|
302
320
|
await page.goto(baseURL);
|
|
321
|
+
await suppressUnrelatedUpdateNotification(page);
|
|
303
322
|
await staleGetReady;
|
|
304
323
|
await expect(page.locator("#sidePanel")).toBeVisible();
|
|
305
324
|
await expect(page.locator('[data-composer-action-id="options"]')).toBeVisible();
|
|
@@ -341,6 +360,12 @@ test("server-owned layout survives stale reads, failed writes, localStorage clea
|
|
|
341
360
|
await expect(page.locator("#terminalTabsLayoutSelect")).toBeVisible();
|
|
342
361
|
await page.locator("#terminalTabsLayoutSelect").selectOption("left");
|
|
343
362
|
await expect(page.locator("body")).toHaveClass(/terminal-tabs-left/);
|
|
363
|
+
const terminalTabsResize = page.locator("#terminalTabsResizeHandle");
|
|
364
|
+
await expect(terminalTabsResize).toBeVisible();
|
|
365
|
+
await terminalTabsResize.focus();
|
|
366
|
+
await terminalTabsResize.press("Shift+ArrowLeft");
|
|
367
|
+
const expectedTerminalSidebarWidth = Number(await terminalTabsResize.getAttribute("aria-valuenow"));
|
|
368
|
+
expect(expectedTerminalSidebarWidth).toBeGreaterThan(208);
|
|
344
369
|
const options = page.locator('[data-composer-action-id="options"]');
|
|
345
370
|
const optionsBox = await options.boundingBox();
|
|
346
371
|
expect(optionsBox).toBeTruthy();
|
|
@@ -374,6 +399,7 @@ test("server-owned layout survives stale reads, failed writes, localStorage clea
|
|
|
374
399
|
footerOrder: expectedFooterOrder,
|
|
375
400
|
fileViewerWidth: expectedFileViewerWidth,
|
|
376
401
|
sidePanelWidth: expectedSidePanelWidth,
|
|
402
|
+
terminalSidebarWidth: expectedTerminalSidebarWidth,
|
|
377
403
|
optionsColumn,
|
|
378
404
|
};
|
|
379
405
|
|
|
@@ -385,10 +411,10 @@ test("server-owned layout survives stale reads, failed writes, localStorage clea
|
|
|
385
411
|
await page.evaluate(() => window.dispatchEvent(new Event("online")));
|
|
386
412
|
|
|
387
413
|
await expect.poll(async () => (await serverApi("/api/interface-preferences")).data.layout).toMatchObject({
|
|
388
|
-
sidePanel: {
|
|
414
|
+
sidePanel: { sectionLayout: { order: expected.sideOrder } },
|
|
389
415
|
composerActions: { order: expected.composerOrder, grid: expected.composerGrid },
|
|
390
416
|
footerScopedModelOrder: expected.footerOrder,
|
|
391
|
-
terminalTabs: { layout: "left", customGroups: expected.terminalGroups },
|
|
417
|
+
terminalTabs: { layout: "left", customGroups: expected.terminalGroups, sidebarWidth: expected.terminalSidebarWidth },
|
|
392
418
|
fileViewerWidth: expected.fileViewerWidth,
|
|
393
419
|
});
|
|
394
420
|
await expect.poll(async () => (await serverApi("/api/interface-preferences")).data.preferences.sidePanelWidth).toBe(expected.sidePanelWidth);
|
|
@@ -396,20 +422,30 @@ test("server-owned layout survives stale reads, failed writes, localStorage clea
|
|
|
396
422
|
await page.evaluate(() => localStorage.clear());
|
|
397
423
|
expect(await page.evaluate(() => localStorage.length)).toBe(0);
|
|
398
424
|
await page.reload();
|
|
399
|
-
const
|
|
425
|
+
const deterministicComposer = await assertRestoredLayout(page, expected, { expectCustomGroup: true });
|
|
400
426
|
|
|
401
427
|
await page.setViewportSize({ width: 700, height: 900 });
|
|
402
428
|
await expect(page.locator("body")).not.toHaveClass(/composer-action-grid-enabled/);
|
|
403
429
|
await expect.poll(() => page.evaluate((key) => JSON.parse(localStorage.getItem(key) || "null"), layoutKeys.composerGrid)).toEqual(expected.composerGrid);
|
|
404
|
-
await page.setViewportSize({ width:
|
|
405
|
-
await
|
|
430
|
+
await page.setViewportSize({ width: deterministicComposer.width, height: 1000 });
|
|
431
|
+
await setTerminalLayout(page, "top");
|
|
432
|
+
await expect.poll(async () => {
|
|
433
|
+
const columns = await composerColumnCount(page);
|
|
434
|
+
const column = Number(await options.evaluate((node) => node.style.getPropertyValue("--composer-action-grid-column")));
|
|
435
|
+
return column >= 1 && column <= columns;
|
|
436
|
+
}).toBe(true);
|
|
437
|
+
await expect.poll(() => page.evaluate((key) => JSON.parse(localStorage.getItem(key) || "null"), layoutKeys.composerGrid)).toEqual(expected.composerGrid);
|
|
438
|
+
await setTerminalLayout(page, "left");
|
|
439
|
+
await expect(page.locator("body")).toHaveClass(/terminal-tabs-left/);
|
|
440
|
+
await expect.poll(async () => (await serverApi("/api/interface-preferences")).data.layout.terminalTabs.layout).toBe("left");
|
|
406
441
|
|
|
407
442
|
await context.close();
|
|
408
443
|
await stopServer();
|
|
409
444
|
const settingsOnDisk = JSON.parse(await readFile(settingsFile, "utf8"));
|
|
410
|
-
assert.deepEqual(settingsOnDisk.uiLayout.sidePanel.
|
|
445
|
+
assert.deepEqual(settingsOnDisk.uiLayout.sidePanel.sectionLayout.order, expected.sideOrder, "the private settings file should contain the browser-committed Control Deck order");
|
|
411
446
|
assert.equal("sectionHeights" in settingsOnDisk.uiLayout.sidePanel, false, "removed Control Deck section heights must not be persisted");
|
|
412
447
|
assert.deepEqual(settingsOnDisk.uiLayout.composerActions.grid, expected.composerGrid, "the private settings file should contain the exact sparse composer grid");
|
|
448
|
+
assert.equal(settingsOnDisk.uiLayout.terminalTabs.sidebarWidth, expected.terminalSidebarWidth, "the private settings file should contain the browser-committed terminal rail width");
|
|
413
449
|
assert.equal(settingsOnDisk.uiLayout.fileViewerWidth, expected.fileViewerWidth, "the private settings file should contain the browser-committed file-viewer width");
|
|
414
450
|
|
|
415
451
|
await startServer();
|
|
@@ -431,12 +467,14 @@ test("returning browsers adopt authoritative Control Deck state without echo wri
|
|
|
431
467
|
body: {
|
|
432
468
|
expectedLayoutRevision: current.data.layoutRevision,
|
|
433
469
|
layout: {
|
|
434
|
-
version:
|
|
470
|
+
version: 2,
|
|
435
471
|
sidePanel: {
|
|
436
|
-
|
|
472
|
+
placement: "right",
|
|
473
|
+
sectionLayout: { order: serverSideOrder, leftSectionIds: [] },
|
|
437
474
|
collapsedSectionIds: [],
|
|
438
475
|
hiddenSectionIds: [],
|
|
439
|
-
|
|
476
|
+
collapsedPanels: { left: false, right: false },
|
|
477
|
+
panelWidths: { left: 384, right: 352 },
|
|
440
478
|
},
|
|
441
479
|
},
|
|
442
480
|
},
|
|
@@ -462,9 +500,9 @@ test("returning browsers adopt authoritative Control Deck state without echo wri
|
|
|
462
500
|
await page.waitForTimeout(700);
|
|
463
501
|
expect(layoutPuts).toBe(0);
|
|
464
502
|
const persisted = await serverApi("/api/interface-preferences");
|
|
465
|
-
assert.deepEqual(persisted.data.layout.sidePanel.
|
|
503
|
+
assert.deepEqual(persisted.data.layout.sidePanel.sectionLayout.order, serverSideOrder);
|
|
466
504
|
assert.equal("sectionHeights" in persisted.data.layout.sidePanel, false);
|
|
467
|
-
assert.equal(persisted.data.layout.sidePanel.
|
|
505
|
+
assert.equal(persisted.data.layout.sidePanel.collapsedPanels.right, false);
|
|
468
506
|
|
|
469
507
|
const controlsToggle = page.locator('[data-side-panel-section-toggle="controls"]');
|
|
470
508
|
if (await controlsToggle.getAttribute("aria-expanded") !== "true") await controlsToggle.click();
|
|
@@ -486,7 +524,7 @@ test("failed layout writes remain pending across reload and later synchronize",
|
|
|
486
524
|
method: "PUT",
|
|
487
525
|
body: {
|
|
488
526
|
expectedLayoutRevision: current.data.layoutRevision,
|
|
489
|
-
layout: { version:
|
|
527
|
+
layout: { version: 2, composerActions: { order: ["send", "new"], grid: null } },
|
|
490
528
|
},
|
|
491
529
|
});
|
|
492
530
|
|
|
@@ -510,14 +548,14 @@ test("failed layout writes remain pending across reload and later synchronize",
|
|
|
510
548
|
await newSession.press("Alt+ArrowLeft");
|
|
511
549
|
await expect.poll(() => page.evaluate((key) => JSON.parse(localStorage.getItem(key) || "[]").slice(0, 2), layoutKeys.composerOrder)).toEqual(["new", "send"]);
|
|
512
550
|
await expect.poll(() => failedWrites).toBeGreaterThan(0);
|
|
513
|
-
await expect.poll(() => page.evaluate(() => Object.keys(localStorage).find((key) => key.startsWith("pi-webui-ui-layout-pending-
|
|
551
|
+
await expect.poll(() => page.evaluate(() => Object.keys(localStorage).find((key) => key.startsWith("pi-webui-ui-layout-pending-v4:")) || null)).not.toBeNull();
|
|
514
552
|
|
|
515
553
|
await page.reload();
|
|
516
554
|
await expect.poll(() => page.evaluate((key) => JSON.parse(localStorage.getItem(key) || "[]").slice(0, 2), layoutKeys.composerOrder)).toEqual(["new", "send"]);
|
|
517
555
|
allowWrites = true;
|
|
518
556
|
await page.evaluate(() => window.dispatchEvent(new Event("online")));
|
|
519
557
|
await expect.poll(async () => (await serverApi("/api/interface-preferences")).data.layout.composerActions.order.slice(0, 2)).toEqual(["new", "send"]);
|
|
520
|
-
await expect.poll(() => page.evaluate(() => Object.keys(localStorage).find((key) => key.startsWith("pi-webui-ui-layout-pending-
|
|
558
|
+
await expect.poll(() => page.evaluate(() => Object.keys(localStorage).find((key) => key.startsWith("pi-webui-ui-layout-pending-v4:")) || null)).toBeNull();
|
|
521
559
|
await context.close();
|
|
522
560
|
});
|
|
523
561
|
|
|
@@ -529,12 +567,14 @@ test("conflict retry updates only the changed Control Deck subfield", async ({ b
|
|
|
529
567
|
body: {
|
|
530
568
|
expectedLayoutRevision: current.data.layoutRevision,
|
|
531
569
|
layout: {
|
|
532
|
-
version:
|
|
570
|
+
version: 2,
|
|
533
571
|
sidePanel: {
|
|
534
|
-
|
|
572
|
+
placement: "right",
|
|
573
|
+
sectionLayout: { order: initialOrder, leftSectionIds: [] },
|
|
535
574
|
collapsedSectionIds: [],
|
|
536
575
|
hiddenSectionIds: [],
|
|
537
|
-
|
|
576
|
+
collapsedPanels: { left: false, right: false },
|
|
577
|
+
panelWidths: { left: 384, right: 352 },
|
|
538
578
|
},
|
|
539
579
|
},
|
|
540
580
|
},
|
|
@@ -553,13 +593,13 @@ test("conflict retry updates only the changed Control Deck subfield", async ({ b
|
|
|
553
593
|
await controlsA.focus();
|
|
554
594
|
await controlsA.press("Alt+ArrowDown");
|
|
555
595
|
const newerOrder = ["files", "git", "controls"];
|
|
556
|
-
await expect.poll(async () => (await serverApi("/api/interface-preferences")).data.layout.sidePanel.
|
|
596
|
+
await expect.poll(async () => (await serverApi("/api/interface-preferences")).data.layout.sidePanel.sectionLayout.order.slice(0, newerOrder.length)).toEqual(newerOrder);
|
|
557
597
|
|
|
558
|
-
await pageB.locator("#toggleSidePanelButton").click();
|
|
559
|
-
await expect(pageB.locator("body")).toHaveClass(/side-panel-collapsed/);
|
|
560
|
-
await expect.poll(async () => (await serverApi("/api/interface-preferences")).data.layout.sidePanel.
|
|
598
|
+
await pageB.locator("#toggleSidePanelButton").evaluate((button) => button.click());
|
|
599
|
+
await expect(pageB.locator("body")).toHaveClass(/side-panel-right-collapsed/);
|
|
600
|
+
await expect.poll(async () => (await serverApi("/api/interface-preferences")).data.layout.sidePanel.collapsedPanels.right).toBe(true);
|
|
561
601
|
const final = await serverApi("/api/interface-preferences");
|
|
562
|
-
assert.deepEqual(final.data.layout.sidePanel.
|
|
602
|
+
assert.deepEqual(final.data.layout.sidePanel.sectionLayout.order.slice(0, newerOrder.length), newerOrder, "a stale collapse retry must not revert another browser's newer section order");
|
|
563
603
|
|
|
564
604
|
await Promise.all([contextA.close(), contextB.close()]);
|
|
565
605
|
});
|
|
@@ -571,12 +611,14 @@ test("one tab cannot erase another tab's failed pending journal", async ({ brows
|
|
|
571
611
|
body: {
|
|
572
612
|
expectedLayoutRevision: current.data.layoutRevision,
|
|
573
613
|
layout: {
|
|
574
|
-
version:
|
|
614
|
+
version: 2,
|
|
575
615
|
sidePanel: {
|
|
576
|
-
|
|
616
|
+
placement: "right",
|
|
617
|
+
sectionLayout: { order: ["files", "controls", "git"], leftSectionIds: [] },
|
|
577
618
|
collapsedSectionIds: [],
|
|
578
619
|
hiddenSectionIds: [],
|
|
579
|
-
|
|
620
|
+
collapsedPanels: { left: false, right: false },
|
|
621
|
+
panelWidths: { left: 384, right: 352 },
|
|
580
622
|
},
|
|
581
623
|
composerActions: { order: ["send", "new"], grid: null },
|
|
582
624
|
},
|
|
@@ -604,12 +646,12 @@ test("one tab cannot erase another tab's failed pending journal", async ({ brows
|
|
|
604
646
|
await newSession.evaluate((button) => button.dispatchEvent(new KeyboardEvent("keydown", { key: "ArrowLeft", altKey: true, bubbles: true })));
|
|
605
647
|
await expect.poll(() => pageA.evaluate((key) => JSON.parse(localStorage.getItem(key) || "[]").slice(0, 2), layoutKeys.composerOrder)).toEqual(["new", "send"]);
|
|
606
648
|
await expect.poll(() => failedComposerWrites).toBeGreaterThan(0);
|
|
607
|
-
await expect.poll(() => pageA.evaluate(() => Object.keys(localStorage).filter((key) => key.startsWith("pi-webui-ui-layout-pending-
|
|
649
|
+
await expect.poll(() => pageA.evaluate(() => Object.keys(localStorage).filter((key) => key.startsWith("pi-webui-ui-layout-pending-v4:")).length)).toBeGreaterThan(0);
|
|
608
650
|
|
|
609
|
-
await pageB.locator("#toggleSidePanelButton").click();
|
|
610
|
-
await expect.poll(async () => (await serverApi("/api/interface-preferences")).data.layout.sidePanel.
|
|
651
|
+
await pageB.locator("#toggleSidePanelButton").evaluate((button) => button.click());
|
|
652
|
+
await expect.poll(async () => (await serverApi("/api/interface-preferences")).data.layout.sidePanel.collapsedPanels.right).toBe(true);
|
|
611
653
|
await expect.poll(() => pageB.evaluate(() => Object.keys(localStorage)
|
|
612
|
-
.filter((key) => key.startsWith("pi-webui-ui-layout-pending-
|
|
654
|
+
.filter((key) => key.startsWith("pi-webui-ui-layout-pending-v4:"))
|
|
613
655
|
.map((key) => JSON.parse(localStorage.getItem(key) || "null"))
|
|
614
656
|
.some((record) => record?.field === "composerActions"))).toBe(true);
|
|
615
657
|
|
|
@@ -629,12 +671,14 @@ test("in-flight sibling acknowledgement clears only the acknowledged subfield",
|
|
|
629
671
|
body: {
|
|
630
672
|
expectedLayoutRevision: current.data.layoutRevision,
|
|
631
673
|
layout: {
|
|
632
|
-
version:
|
|
674
|
+
version: 2,
|
|
633
675
|
sidePanel: {
|
|
634
|
-
|
|
676
|
+
placement: "right",
|
|
677
|
+
sectionLayout: { order: initialOrder, leftSectionIds: [] },
|
|
635
678
|
collapsedSectionIds: [],
|
|
636
679
|
hiddenSectionIds: [],
|
|
637
|
-
|
|
680
|
+
collapsedPanels: { left: false, right: false },
|
|
681
|
+
panelWidths: { left: 384, right: 352 },
|
|
638
682
|
},
|
|
639
683
|
},
|
|
640
684
|
},
|
|
@@ -659,7 +703,7 @@ test("in-flight sibling acknowledgement clears only the acknowledged subfield",
|
|
|
659
703
|
await pageA.route("**/api/interface-preferences", async (route) => {
|
|
660
704
|
const request = route.request();
|
|
661
705
|
const payload = request.method() === "PUT" ? request.postDataJSON() : null;
|
|
662
|
-
if (interceptWrites && payload?.layout && !firstOrderIntercepted && payload.layout.sidePanel?.
|
|
706
|
+
if (interceptWrites && payload?.layout && !firstOrderIntercepted && payload.layout.sidePanel?.sectionLayout) {
|
|
663
707
|
firstOrderIntercepted = true;
|
|
664
708
|
const response = await route.fetch();
|
|
665
709
|
firstOrderFetched();
|
|
@@ -685,23 +729,135 @@ test("in-flight sibling acknowledgement clears only the acknowledged subfield",
|
|
|
685
729
|
const controlsA = pageA.locator('[data-side-panel-section-toggle="controls"]');
|
|
686
730
|
await controlsA.evaluate((button) => button.dispatchEvent(new KeyboardEvent("keydown", { key: "ArrowDown", altKey: true, bubbles: true })));
|
|
687
731
|
await firstOrderFetchedPromise;
|
|
688
|
-
await pageA.locator("#toggleSidePanelButton").click();
|
|
732
|
+
await pageA.locator("#toggleSidePanelButton").evaluate((button) => button.click());
|
|
689
733
|
releaseFirstOrder();
|
|
690
734
|
await secondWriteSeenPromise;
|
|
691
|
-
assert.equal(Object.hasOwn(secondPayload.layout.sidePanel || {}, "
|
|
692
|
-
assert.equal(secondPayload.layout.sidePanel?.
|
|
735
|
+
assert.equal(Object.hasOwn(secondPayload.layout.sidePanel || {}, "sectionLayout"), false, "the acknowledged order must not remain in the pending collapse patch");
|
|
736
|
+
assert.equal(secondPayload.layout.sidePanel?.collapsedPanels?.right, true);
|
|
693
737
|
|
|
694
738
|
const controlsB = pageB.locator('[data-side-panel-section-toggle="controls"]');
|
|
695
739
|
await controlsB.evaluate((button) => button.dispatchEvent(new KeyboardEvent("keydown", { key: "ArrowUp", altKey: true, bubbles: true })));
|
|
696
740
|
const browserBOrder = ["controls", "files", "git"];
|
|
697
|
-
await expect.poll(async () => (await serverApi("/api/interface-preferences")).data.layout.sidePanel.
|
|
741
|
+
await expect.poll(async () => (await serverApi("/api/interface-preferences")).data.layout.sidePanel.sectionLayout.order.slice(0, browserBOrder.length)).toEqual(browserBOrder);
|
|
698
742
|
releaseSecondWrite();
|
|
699
|
-
await expect.poll(async () => (await serverApi("/api/interface-preferences")).data.layout.sidePanel.
|
|
743
|
+
await expect.poll(async () => (await serverApi("/api/interface-preferences")).data.layout.sidePanel.collapsedPanels.right).toBe(true);
|
|
700
744
|
const final = await serverApi("/api/interface-preferences");
|
|
701
|
-
assert.deepEqual(final.data.layout.sidePanel.
|
|
745
|
+
assert.deepEqual(final.data.layout.sidePanel.sectionLayout.order.slice(0, browserBOrder.length), browserBOrder);
|
|
702
746
|
await Promise.all([contextA.close(), contextB.close()]);
|
|
703
747
|
});
|
|
704
748
|
|
|
749
|
+
test("same-origin sibling placement adoption cannot overwrite a dirty section layout", async ({ browser }) => {
|
|
750
|
+
test.setTimeout(60_000);
|
|
751
|
+
const current = await serverApi("/api/interface-preferences");
|
|
752
|
+
const initialOrder = ["controls", "files", "git"];
|
|
753
|
+
await serverApi("/api/interface-preferences", {
|
|
754
|
+
method: "PUT",
|
|
755
|
+
body: {
|
|
756
|
+
expectedLayoutRevision: current.data.layoutRevision,
|
|
757
|
+
layout: {
|
|
758
|
+
version: 2,
|
|
759
|
+
sidePanel: {
|
|
760
|
+
placement: "right",
|
|
761
|
+
sectionLayout: { order: initialOrder, leftSectionIds: [] },
|
|
762
|
+
collapsedSectionIds: [],
|
|
763
|
+
hiddenSectionIds: [],
|
|
764
|
+
collapsedPanels: { left: false, right: false },
|
|
765
|
+
panelWidths: { left: 384, right: 352 },
|
|
766
|
+
},
|
|
767
|
+
},
|
|
768
|
+
},
|
|
769
|
+
});
|
|
770
|
+
|
|
771
|
+
const context = await browser.newContext({ viewport: { width: 1900, height: 1000 } });
|
|
772
|
+
const pageA = await context.newPage();
|
|
773
|
+
const pageB = await context.newPage();
|
|
774
|
+
let failedSectionWrites = 0;
|
|
775
|
+
await pageA.route("**/api/interface-preferences", async (route) => {
|
|
776
|
+
const payload = route.request().method() === "PUT" ? route.request().postDataJSON() : null;
|
|
777
|
+
if (payload?.layout?.sidePanel?.sectionLayout) {
|
|
778
|
+
failedSectionWrites += 1;
|
|
779
|
+
await route.abort("failed");
|
|
780
|
+
return;
|
|
781
|
+
}
|
|
782
|
+
await route.continue();
|
|
783
|
+
});
|
|
784
|
+
await Promise.all([pageA.goto(baseURL), pageB.goto(baseURL)]);
|
|
785
|
+
await Promise.all([suppressUnrelatedUpdateNotification(pageA), suppressUnrelatedUpdateNotification(pageB)]);
|
|
786
|
+
await expect.poll(async () => (await sectionOrder(pageA)).slice(0, initialOrder.length)).toEqual(initialOrder);
|
|
787
|
+
await pageA.waitForTimeout(700);
|
|
788
|
+
await expect.poll(async () => (await sectionOrder(pageA)).slice(0, initialOrder.length)).toEqual(initialOrder);
|
|
789
|
+
|
|
790
|
+
const controlsA = pageA.locator('[data-side-panel-section-toggle="controls"]');
|
|
791
|
+
await controlsA.focus();
|
|
792
|
+
await expect(controlsA).toBeFocused();
|
|
793
|
+
await controlsA.press("Alt+ArrowDown");
|
|
794
|
+
const dirtyOrder = ["files", "controls", "git"];
|
|
795
|
+
await expect.poll(async () => (await sectionOrder(pageA)).slice(0, dirtyOrder.length)).toEqual(dirtyOrder);
|
|
796
|
+
await expect.poll(() => failedSectionWrites).toBeGreaterThan(0);
|
|
797
|
+
|
|
798
|
+
await setTerminalLayout(pageB, "top");
|
|
799
|
+
const controlsB = pageB.locator('[data-side-panel-section-toggle="controls"]');
|
|
800
|
+
if (await controlsB.getAttribute("aria-expanded") !== "true") await controlsB.click();
|
|
801
|
+
await pageB.locator("#controlDeckPlacementSelect").selectOption("both");
|
|
802
|
+
await expect(pageB.locator("body")).toHaveClass(/control-deck-both/);
|
|
803
|
+
await expect(pageA.locator("body")).toHaveClass(/control-deck-both/);
|
|
804
|
+
await expect.poll(async () => (await sectionOrder(pageA)).slice(0, dirtyOrder.length)).toEqual(dirtyOrder);
|
|
805
|
+
await expect.poll(() => pageA.evaluate(() => JSON.parse(localStorage.getItem("pi-webui-control-deck-layout-v2") || "null")?.placement)).toBe("both");
|
|
806
|
+
await context.close();
|
|
807
|
+
});
|
|
808
|
+
|
|
809
|
+
test("seeded v3 Control Deck journal recovers legacy fields without widening partial collapse", async ({ browser }) => {
|
|
810
|
+
const current = await serverApi("/api/interface-preferences");
|
|
811
|
+
await serverApi("/api/interface-preferences", {
|
|
812
|
+
method: "PUT",
|
|
813
|
+
body: {
|
|
814
|
+
expectedLayoutRevision: current.data.layoutRevision,
|
|
815
|
+
layout: {
|
|
816
|
+
version: 2,
|
|
817
|
+
sidePanel: {
|
|
818
|
+
placement: "right",
|
|
819
|
+
sectionLayout: { order: ["controls", "files", "git"], leftSectionIds: [] },
|
|
820
|
+
collapsedSectionIds: [],
|
|
821
|
+
hiddenSectionIds: [],
|
|
822
|
+
collapsedPanels: { left: true, right: true },
|
|
823
|
+
panelWidths: { left: 384, right: 352 },
|
|
824
|
+
},
|
|
825
|
+
},
|
|
826
|
+
},
|
|
827
|
+
});
|
|
828
|
+
|
|
829
|
+
const context = await browser.newContext({ viewport: { width: 1680, height: 1000 } });
|
|
830
|
+
await context.addInitScript(() => {
|
|
831
|
+
const prefix = "pi-webui-ui-layout-pending-v3:fixture:";
|
|
832
|
+
const records = [
|
|
833
|
+
["order", { version: 3, field: "sidePanel", subfield: "sectionOrder", value: ["git", "files", "controls"], updatedAt: 1 }],
|
|
834
|
+
["collapsed-sections", { version: 3, field: "sidePanel", subfield: "collapsedSectionIds", value: ["git"], updatedAt: 2 }],
|
|
835
|
+
["hidden-sections", { version: 3, field: "sidePanel", subfield: "hiddenSectionIds", value: ["queue"], updatedAt: 3 }],
|
|
836
|
+
["panel-collapse", { version: 3, field: "sidePanel", subfield: "collapsed", value: false, updatedAt: 4 }],
|
|
837
|
+
];
|
|
838
|
+
for (const [key, value] of records) localStorage.setItem(`${prefix}${key}`, JSON.stringify(value));
|
|
839
|
+
});
|
|
840
|
+
const page = await context.newPage();
|
|
841
|
+
const collapsePayloads = [];
|
|
842
|
+
await page.route("**/api/interface-preferences", async (route) => {
|
|
843
|
+
const payload = route.request().method() === "PUT" ? route.request().postDataJSON() : null;
|
|
844
|
+
if (payload?.layout?.sidePanel?.collapsedPanels) collapsePayloads.push(payload.layout.sidePanel.collapsedPanels);
|
|
845
|
+
await route.continue();
|
|
846
|
+
});
|
|
847
|
+
await page.goto(baseURL);
|
|
848
|
+
|
|
849
|
+
await expect.poll(async () => (await serverApi("/api/interface-preferences")).data.layout.sidePanel).toMatchObject({
|
|
850
|
+
sectionLayout: { order: ["git", "files", "controls"] },
|
|
851
|
+
collapsedSectionIds: ["git"],
|
|
852
|
+
hiddenSectionIds: ["queue"],
|
|
853
|
+
collapsedPanels: { left: true, right: false },
|
|
854
|
+
});
|
|
855
|
+
await expect.poll(() => collapsePayloads.length).toBeGreaterThan(0);
|
|
856
|
+
assert.deepEqual(collapsePayloads[0], { right: false }, "translated v3 collapse must remain a right-only partial mutation");
|
|
857
|
+
await expect.poll(() => page.evaluate(() => Object.keys(localStorage).some((key) => key.startsWith("pi-webui-ui-layout-pending-v3:fixture:")))).toBe(false);
|
|
858
|
+
await context.close();
|
|
859
|
+
});
|
|
860
|
+
|
|
705
861
|
test("a delayed GET cannot regress the revision acknowledged by a newer PUT", async ({ browser }) => {
|
|
706
862
|
const current = await serverApi("/api/interface-preferences");
|
|
707
863
|
await serverApi("/api/interface-preferences", {
|
|
@@ -709,12 +865,14 @@ test("a delayed GET cannot regress the revision acknowledged by a newer PUT", as
|
|
|
709
865
|
body: {
|
|
710
866
|
expectedLayoutRevision: current.data.layoutRevision,
|
|
711
867
|
layout: {
|
|
712
|
-
version:
|
|
868
|
+
version: 2,
|
|
713
869
|
sidePanel: {
|
|
714
|
-
|
|
870
|
+
placement: "right",
|
|
871
|
+
sectionLayout: { order: ["files", "controls", "git"], leftSectionIds: [] },
|
|
715
872
|
collapsedSectionIds: [],
|
|
716
873
|
hiddenSectionIds: [],
|
|
717
|
-
|
|
874
|
+
collapsedPanels: { left: false, right: false },
|
|
875
|
+
panelWidths: { left: 384, right: 352 },
|
|
718
876
|
},
|
|
719
877
|
},
|
|
720
878
|
},
|
|
@@ -741,7 +899,7 @@ test("a delayed GET cannot regress the revision acknowledged by a newer PUT", as
|
|
|
741
899
|
}
|
|
742
900
|
if (captureNextPut && request.method() === "PUT") {
|
|
743
901
|
const payload = request.postDataJSON();
|
|
744
|
-
if (Object.hasOwn(payload?.layout?.sidePanel || {}, "
|
|
902
|
+
if (Object.hasOwn(payload?.layout?.sidePanel || {}, "collapsedPanels")) {
|
|
745
903
|
captureNextPut = false;
|
|
746
904
|
capturedExpectedRevision = payload.expectedLayoutRevision;
|
|
747
905
|
}
|
|
@@ -761,24 +919,24 @@ test("a delayed GET cannot regress the revision acknowledged by a newer PUT", as
|
|
|
761
919
|
[newerOrder[controlsIndex], newerOrder[controlsIndex + moveOffset]] = [newerOrder[controlsIndex + moveOffset], newerOrder[controlsIndex]];
|
|
762
920
|
const newerPutResponse = page.waitForResponse((response) => {
|
|
763
921
|
if (!response.url().includes("/api/interface-preferences") || response.request().method() !== "PUT") return false;
|
|
764
|
-
return Array.isArray(response.request().postDataJSON()?.layout?.sidePanel?.
|
|
922
|
+
return Array.isArray(response.request().postDataJSON()?.layout?.sidePanel?.sectionLayout?.order);
|
|
765
923
|
});
|
|
766
924
|
await controls.evaluate((button, key) => button.dispatchEvent(new KeyboardEvent("keydown", { key, altKey: true, bubbles: true })), moveOffset > 0 ? "ArrowDown" : "ArrowUp");
|
|
767
925
|
await newerPutResponse;
|
|
768
|
-
await expect.poll(async () => (await serverApi("/api/interface-preferences")).data.layout.sidePanel.
|
|
926
|
+
await expect.poll(async () => (await serverApi("/api/interface-preferences")).data.layout.sidePanel.sectionLayout.order.slice(0, newerOrder.length)).toEqual(newerOrder);
|
|
769
927
|
await expect.poll(() => page.evaluate((prefix) => {
|
|
770
928
|
for (let index = 0; index < localStorage.length; index += 1) {
|
|
771
929
|
const key = localStorage.key(index);
|
|
772
930
|
if (!key?.startsWith(prefix)) continue;
|
|
773
931
|
try {
|
|
774
932
|
const record = JSON.parse(localStorage.getItem(key) || "null");
|
|
775
|
-
if (record?.field === "sidePanel" && record?.subfield === "
|
|
933
|
+
if (record?.field === "sidePanel" && record?.subfield === "sectionLayout") return true;
|
|
776
934
|
} catch {
|
|
777
935
|
// Ignore malformed unrelated records; production also fails soft here.
|
|
778
936
|
}
|
|
779
937
|
}
|
|
780
938
|
return false;
|
|
781
|
-
}, "pi-webui-ui-layout-pending-
|
|
939
|
+
}, "pi-webui-ui-layout-pending-v4:")).toBe(false);
|
|
782
940
|
releaseDelayedGet();
|
|
783
941
|
await page.waitForTimeout(300);
|
|
784
942
|
const revisionBeforeCollapse = (await serverApi("/api/interface-preferences")).data.layoutRevision;
|
|
@@ -786,6 +944,6 @@ test("a delayed GET cannot regress the revision acknowledged by a newer PUT", as
|
|
|
786
944
|
captureNextPut = true;
|
|
787
945
|
await page.locator("#toggleSidePanelButton").evaluate((button) => button.click());
|
|
788
946
|
await expect.poll(() => capturedExpectedRevision).toBe(revisionBeforeCollapse);
|
|
789
|
-
await expect.poll(async () => (await serverApi("/api/interface-preferences")).data.layout.sidePanel.
|
|
947
|
+
await expect.poll(async () => (await serverApi("/api/interface-preferences")).data.layout.sidePanel.collapsedPanels.right).toBe(true);
|
|
790
948
|
await context.close();
|
|
791
949
|
});
|
|
@@ -0,0 +1,87 @@
|
|
|
1
|
+
import { spawn } from "node:child_process";
|
|
2
|
+
import { createServer } from "node:net";
|
|
3
|
+
import { mkdtemp, rm } from "node:fs/promises";
|
|
4
|
+
import { tmpdir } from "node:os";
|
|
5
|
+
import { dirname, join } from "node:path";
|
|
6
|
+
import { setTimeout as delay } from "node:timers/promises";
|
|
7
|
+
import { fileURLToPath } from "node:url";
|
|
8
|
+
import { expect, test } from "@playwright/test";
|
|
9
|
+
|
|
10
|
+
const root = join(dirname(fileURLToPath(import.meta.url)), "..", "..");
|
|
11
|
+
const serverScript = join(root, "bin", "pi-webui.mjs");
|
|
12
|
+
const fakePi = join(root, "tests", "fixtures", "fake-pi.mjs");
|
|
13
|
+
let child;
|
|
14
|
+
let baseURL;
|
|
15
|
+
let tempRoot;
|
|
16
|
+
|
|
17
|
+
async function freePort() {
|
|
18
|
+
const server = createServer();
|
|
19
|
+
await new Promise((resolve) => server.listen(0, "127.0.0.1", resolve));
|
|
20
|
+
const { port } = server.address();
|
|
21
|
+
await new Promise((resolve) => server.close(resolve));
|
|
22
|
+
return port;
|
|
23
|
+
}
|
|
24
|
+
|
|
25
|
+
async function api(page, pathname, { method = "GET", data } = {}) {
|
|
26
|
+
const response = await page.request.fetch(`${baseURL}${pathname}`, { method, data });
|
|
27
|
+
expect(response.ok()).toBe(true);
|
|
28
|
+
return response.json();
|
|
29
|
+
}
|
|
30
|
+
|
|
31
|
+
async function startServer() {
|
|
32
|
+
const port = await freePort();
|
|
33
|
+
baseURL = `http://127.0.0.1:${port}`;
|
|
34
|
+
child = spawn(process.execPath, [serverScript, "--cwd", tempRoot, "--host", "127.0.0.1", "--port", String(port), "--pi", fakePi], {
|
|
35
|
+
stdio: ["ignore", "pipe", "pipe"],
|
|
36
|
+
env: { ...process.env, PI_WEBUI_RPC_SUPERVISOR: "0", PI_CODING_AGENT_DIR: join(tempRoot, "agent"), PI_WEBUI_SETTINGS_FILE: join(tempRoot, "settings.json") },
|
|
37
|
+
});
|
|
38
|
+
let output = "";
|
|
39
|
+
child.stdout.on("data", (chunk) => { output += String(chunk); });
|
|
40
|
+
child.stderr.on("data", (chunk) => { output += String(chunk); });
|
|
41
|
+
for (let attempt = 0; attempt < 100; attempt += 1) {
|
|
42
|
+
try { if ((await fetch(`${baseURL}/api/health`, { signal: AbortSignal.timeout(500) })).ok) return; } catch {}
|
|
43
|
+
await delay(100);
|
|
44
|
+
}
|
|
45
|
+
throw new Error(`server did not start: ${output}`);
|
|
46
|
+
}
|
|
47
|
+
|
|
48
|
+
async function stopServer() {
|
|
49
|
+
if (!child || child.exitCode !== null) return;
|
|
50
|
+
const exited = new Promise((resolve) => child.once("exit", resolve));
|
|
51
|
+
child.kill("SIGTERM");
|
|
52
|
+
await Promise.race([exited, delay(5_000).then(() => child.kill("SIGKILL"))]);
|
|
53
|
+
}
|
|
54
|
+
|
|
55
|
+
test.beforeAll(async () => {
|
|
56
|
+
tempRoot = await mkdtemp(join(tmpdir(), "pi-webui-subagent-browser-"));
|
|
57
|
+
await startServer();
|
|
58
|
+
});
|
|
59
|
+
|
|
60
|
+
test.afterAll(async () => {
|
|
61
|
+
await stopServer();
|
|
62
|
+
await rm(tempRoot, { recursive: true, force: true });
|
|
63
|
+
});
|
|
64
|
+
|
|
65
|
+
test("renders canonical v2 agents and opens output through the unified selection", async ({ page }) => {
|
|
66
|
+
await page.goto(baseURL);
|
|
67
|
+
await expect(page.locator("#tabBar [data-tab-id]").first()).toBeVisible();
|
|
68
|
+
const tabs = await api(page, "/api/tabs");
|
|
69
|
+
const tabId = tabs.data.tabs[0].id;
|
|
70
|
+
await api(page, `/api/prompt?tab=${encodeURIComponent(tabId)}`, { method: "POST", data: { message: "fixture subagents running", requestId: `subagents-${Date.now()}` } });
|
|
71
|
+
|
|
72
|
+
const sectionToggle = page.locator('[data-side-panel-section-toggle="subagents"]');
|
|
73
|
+
if (await sectionToggle.getAttribute("aria-expanded") !== "true") await sectionToggle.click();
|
|
74
|
+
await expect(page.locator(".subagent-agent-row")).toHaveCount(2);
|
|
75
|
+
await expect(page.locator("#subagentCountBadge")).toHaveText("2");
|
|
76
|
+
await expect(page.locator("#subagentsStatus")).toContainText("2 total");
|
|
77
|
+
await expect(page.locator("#subagentsStatus")).toContainText("2 running");
|
|
78
|
+
await expect(page.locator(".subagent-source-badge").first()).toHaveText("pi-subagents");
|
|
79
|
+
await expect(page.locator(".subagent-state-dot.running")).toHaveCount(2);
|
|
80
|
+
await expect(page.locator(".subagent-gate-card")).toHaveCount(1);
|
|
81
|
+
|
|
82
|
+
await page.locator(".subagent-agent-row").first().click();
|
|
83
|
+
await expect(page.locator(".subagent-overlay-widget")).toBeVisible();
|
|
84
|
+
await expect(page.locator(".subagent-overlay-widget")).toContainText("reviewer");
|
|
85
|
+
await expect(page.locator(".subagent-overlay-refresh-action")).toBeVisible();
|
|
86
|
+
await expect(page.locator(".subagent-overlay-cancel-action")).toBeVisible();
|
|
87
|
+
});
|