@firstpick/pi-package-webui 0.11.1 → 0.11.3

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (310) hide show
  1. package/DEVELOPMENT.md +151 -12
  2. package/README.md +34 -6
  3. package/TECHNICAL.md +75 -8
  4. package/bin/pi-webui.mjs +5390 -11423
  5. package/index.ts +10 -3
  6. package/lib/component-update-state.mjs +2 -2
  7. package/lib/git-workflow-preference-values.mjs +122 -0
  8. package/lib/git-workflow-preferences.mjs +35 -563
  9. package/lib/package-updates.mjs +260 -0
  10. package/lib/rpc-supervisor-client.mjs +8 -4
  11. package/lib/server/app-runners.mjs +1667 -0
  12. package/lib/server/codex-fast-mode.mjs +161 -0
  13. package/lib/server/conversation-mode.mjs +218 -0
  14. package/lib/server/conversation-voice.mjs +318 -0
  15. package/lib/server/extension-ui-requests.mjs +114 -0
  16. package/lib/server/git-generation.mjs +459 -0
  17. package/lib/server/git-mutations.mjs +1827 -0
  18. package/lib/server/git-reads.mjs +608 -0
  19. package/lib/server/git-worktree-sessions.mjs +408 -0
  20. package/lib/server/helper-requests.mjs +82 -0
  21. package/lib/server/no-project-workspaces.mjs +103 -0
  22. package/lib/server/rpc-transports.mjs +394 -0
  23. package/lib/server/settings-store.mjs +544 -0
  24. package/lib/server/sse-delivery.mjs +138 -0
  25. package/lib/server/workspace-files.mjs +563 -0
  26. package/lib/update/supervisor.mjs +4 -0
  27. package/lib/webui-workspaces.mjs +2 -0
  28. package/package.json +4 -4
  29. package/public/activity-agents-controller.mjs +269 -0
  30. package/public/activity-events-controller.mjs +236 -0
  31. package/public/activity-intercom-controller.mjs +627 -0
  32. package/public/activity-queue-controller.mjs +534 -0
  33. package/public/activity-todo-view.mjs +89 -0
  34. package/public/activity-usage-controller.mjs +589 -0
  35. package/public/app.js +3761 -3886
  36. package/public/conversation-overview.css +84 -0
  37. package/public/conversation-overview.mjs +193 -0
  38. package/public/draft-conversations.mjs +135 -0
  39. package/public/focused-composer-controls.css +111 -0
  40. package/public/focused-composer-controls.mjs +143 -0
  41. package/public/focused-composer-disclosure.mjs +223 -0
  42. package/public/focused-shell-adapter.css +264 -0
  43. package/public/focused-shell-adapter.mjs +257 -0
  44. package/public/index.html +137 -80
  45. package/public/model-catalog-order.mjs +63 -0
  46. package/public/platform-event-stream.mjs +64 -0
  47. package/public/project-artifact-controller.mjs +218 -0
  48. package/public/project-file-viewer-controller.mjs +383 -0
  49. package/public/project-git-tools-controller.mjs +181 -0
  50. package/public/project-runners-controller.mjs +220 -0
  51. package/public/service-worker.js +52 -1
  52. package/public/session-attention-scheduler.mjs +182 -0
  53. package/public/session-composer-store.mjs +56 -0
  54. package/public/session-context.mjs +51 -0
  55. package/public/session-extension-requests.mjs +63 -0
  56. package/public/session-shelf-state.mjs +151 -0
  57. package/public/session-shelves.css +171 -0
  58. package/public/session-shelves.mjs +95 -0
  59. package/public/settings-navigation-controller.mjs +249 -0
  60. package/public/settings-navigation.css +61 -0
  61. package/public/settings-resource-controller.mjs +232 -0
  62. package/public/settings-workspace.css +19 -0
  63. package/public/settings-workspace.mjs +175 -0
  64. package/public/shell-actions.mjs +87 -0
  65. package/public/shell-attention-inbox.css +72 -0
  66. package/public/shell-attention-inbox.mjs +198 -0
  67. package/public/shell-context-actions.css +61 -0
  68. package/public/shell-context-actions.mjs +168 -0
  69. package/public/shell-inspector-resize.mjs +124 -0
  70. package/public/shell-navigation-resize.mjs +107 -0
  71. package/public/shell-navigation.mjs +127 -0
  72. package/public/shell-preferences.mjs +108 -0
  73. package/public/shell-surfaces.mjs +99 -0
  74. package/public/shell-tools-launcher.css +97 -0
  75. package/public/shell-tools-launcher.mjs +222 -0
  76. package/public/shell-view-host.mjs +115 -0
  77. package/public/shell-workspace.css +266 -0
  78. package/public/shell-workspace.mjs +402 -0
  79. package/public/sidebar-update-menu.css +190 -0
  80. package/public/sidebar-update-menu.mjs +512 -0
  81. package/public/styles.css +322 -169
  82. package/public/subagent-launch-slot-state.mjs +2 -2
  83. package/public/themed-selects.css +156 -0
  84. package/public/workspace-choices.mjs +104 -0
  85. package/tests/activity-agents-controller.test.mjs +652 -0
  86. package/tests/activity-events-controller.test.mjs +511 -0
  87. package/tests/app-runner-terminal-static.test.mjs +3 -3
  88. package/tests/append-system-http.test.mjs +7 -6
  89. package/tests/append-system-selector-static.test.mjs +6 -6
  90. package/tests/aur-review-widget-static.test.mjs +11 -3
  91. package/tests/boot-failure-diagnostics.test.mjs +8 -3
  92. package/tests/browser/action-feedback-gutter.spec.mjs +251 -0
  93. package/tests/browser/activity-intercom-controller.spec.mjs +457 -0
  94. package/tests/browser/activity-navigation-integration.spec.mjs +45 -0
  95. package/tests/browser/activity-owner-integration.spec.mjs +201 -0
  96. package/tests/browser/activity-queue-controller.spec.mjs +405 -0
  97. package/tests/browser/activity-section-picker.spec.mjs +294 -0
  98. package/tests/browser/activity-todo-view.spec.mjs +60 -0
  99. package/tests/browser/activity-usage-controller.spec.mjs +416 -0
  100. package/tests/browser/compact-layout-integration.spec.mjs +58 -0
  101. package/tests/browser/composer-action-grid-reorder.spec.mjs +16 -0
  102. package/tests/browser/composer-disclosure.spec.mjs +389 -0
  103. package/tests/browser/composer-toolbar-polish.spec.mjs +343 -0
  104. package/tests/browser/control-deck-component-updates.spec.mjs +5 -14
  105. package/tests/browser/control-deck-side-panels.spec.mjs +27 -12
  106. package/tests/browser/control-visibility.spec.mjs +5 -0
  107. package/tests/browser/controls-layout.spec.mjs +21 -2
  108. package/tests/browser/conversation-overview.spec.mjs +251 -0
  109. package/tests/browser/draft-conversations.spec.mjs +276 -0
  110. package/tests/browser/empty-startup-fixture.mjs +135 -0
  111. package/tests/browser/empty-startup.spec.mjs +282 -0
  112. package/tests/browser/events-tree-context-menu.spec.mjs +1 -0
  113. package/tests/browser/focused-composer-more.spec.mjs +127 -0
  114. package/tests/browser/focused-model-shortcuts.spec.mjs +120 -0
  115. package/tests/browser/focused-navigation-fixture.mjs +32 -0
  116. package/tests/browser/focused-project-activity.spec.mjs +111 -0
  117. package/tests/browser/focused-shell-integration.spec.mjs +208 -0
  118. package/tests/browser/folder-picker-layout-fixture.mjs +13 -0
  119. package/tests/browser/folder-picker-layout.spec.mjs +302 -0
  120. package/tests/browser/footer-model-advanced-layout.spec.mjs +27 -14
  121. package/tests/browser/git-setup-cancel.spec.mjs +251 -0
  122. package/tests/browser/guided-git-fallback.spec.mjs +40 -21
  123. package/tests/browser/inspector-header.spec.mjs +221 -0
  124. package/tests/browser/inspector-overview-integration.spec.mjs +104 -0
  125. package/tests/browser/inspector-resize.spec.mjs +227 -0
  126. package/tests/browser/inspector-topic-overflow.spec.mjs +56 -0
  127. package/tests/browser/interaction-action-discovery.spec.mjs +332 -0
  128. package/tests/browser/interaction-attention-inbox.spec.mjs +364 -0
  129. package/tests/browser/interaction-attention-integration.spec.mjs +53 -0
  130. package/tests/browser/interaction-composer-controls.spec.mjs +267 -0
  131. package/tests/browser/interaction-composer-integration.spec.mjs +175 -0
  132. package/tests/browser/interaction-continuity.spec.mjs +50 -26
  133. package/tests/browser/interaction-model-picker.spec.mjs +86 -0
  134. package/tests/browser/last-terminal-close.spec.mjs +280 -0
  135. package/tests/browser/mobile-foundation.spec.mjs +172 -20
  136. package/tests/browser/model-catalog-groups.spec.mjs +104 -0
  137. package/tests/browser/more-row-menus.spec.mjs +258 -0
  138. package/tests/browser/new-tab-hit-target.spec.mjs +228 -0
  139. package/tests/browser/no-project-conversation.spec.mjs +113 -0
  140. package/tests/browser/optimistic-prompt.spec.mjs +3 -0
  141. package/tests/browser/overhaul-w7-accessibility.spec.mjs +227 -0
  142. package/tests/browser/overhaul-w7-capabilities.spec.mjs +298 -0
  143. package/tests/browser/overhaul-w7-companions.spec.mjs +290 -0
  144. package/tests/browser/overhaul-w7-focus-repairs.spec.mjs +210 -0
  145. package/tests/browser/overhaul-w7-layout-repairs.spec.mjs +183 -0
  146. package/tests/browser/overhaul-w7-parent-repairs.spec.mjs +97 -0
  147. package/tests/browser/overhaul-w7-pwa.spec.mjs +247 -0
  148. package/tests/browser/overhaul-w7-responsive.spec.mjs +450 -0
  149. package/tests/browser/overhaul-w7-update.spec.mjs +215 -0
  150. package/tests/browser/overhaul-w7-zoom.spec.mjs +243 -0
  151. package/tests/browser/overview-agent-ownership.spec.mjs +45 -0
  152. package/tests/browser/persistent-ui-layout.spec.mjs +3 -0
  153. package/tests/browser/project-artifact-controller.spec.mjs +324 -0
  154. package/tests/browser/project-artifact-integration.spec.mjs +103 -0
  155. package/tests/browser/project-file-buffer-integration.spec.mjs +230 -0
  156. package/tests/browser/project-git-tools-integration.spec.mjs +369 -0
  157. package/tests/browser/session-fixture.mjs +118 -0
  158. package/tests/browser/session-ownership.spec.mjs +175 -0
  159. package/tests/browser/session-shelves-integration.spec.mjs +219 -0
  160. package/tests/browser/session-shelves.spec.mjs +340 -0
  161. package/tests/browser/session-sidebar-resize.spec.mjs +138 -0
  162. package/tests/browser/session-summary.spec.mjs +17 -12
  163. package/tests/browser/settings-complete-home.spec.mjs +463 -0
  164. package/tests/browser/settings-entrypoint.spec.mjs +104 -0
  165. package/tests/browser/settings-navigation-controller.spec.mjs +383 -0
  166. package/tests/browser/settings-navigation-integration.spec.mjs +348 -0
  167. package/tests/browser/settings-resource-lifetime.spec.mjs +349 -0
  168. package/tests/browser/settings-workspace-integration.spec.mjs +132 -0
  169. package/tests/browser/shell-ownership.spec.mjs +398 -0
  170. package/tests/browser/shell-rollout-fixture.mjs +259 -0
  171. package/tests/browser/shell-rollout.spec.mjs +357 -0
  172. package/tests/browser/shell-tools-launcher.spec.mjs +260 -0
  173. package/tests/browser/shell-workspace.spec.mjs +433 -0
  174. package/tests/browser/side-panel-section-reorder.spec.mjs +3 -1
  175. package/tests/browser/sidebar-floating-tooltips.spec.mjs +37 -0
  176. package/tests/browser/sidebar-update-integration.spec.mjs +277 -0
  177. package/tests/browser/sidebar-update-menu.spec.mjs +402 -0
  178. package/tests/browser/sidebar-update-progress.spec.mjs +472 -0
  179. package/tests/browser/stream-output-isolation.spec.mjs +6 -3
  180. package/tests/browser/themed-selects.spec.mjs +297 -0
  181. package/tests/browser/thread-start-flow.spec.mjs +481 -0
  182. package/tests/browser/ui-polish-activity-controls.spec.mjs +177 -0
  183. package/tests/browser/ui-polish-features.spec.mjs +85 -0
  184. package/tests/browser/ui-polish-file-header.spec.mjs +43 -0
  185. package/tests/browser/ui-polish-local-git.spec.mjs +183 -0
  186. package/tests/browser/ui-polish-mobile-recovery.spec.mjs +36 -0
  187. package/tests/browser/ui-polish-navigation.spec.mjs +127 -0
  188. package/tests/browser/ui-polish-session-actions.spec.mjs +282 -0
  189. package/tests/browser/user-noticeable-fixes.spec.mjs +10 -3
  190. package/tests/browser/windows-drive-parent.spec.mjs +4 -2
  191. package/tests/browser/workspace-draft-selection.spec.mjs +266 -0
  192. package/tests/codex-fast-mode-static.test.mjs +16 -11
  193. package/tests/codex-speed-mode-browser-state.test.mjs +6 -3
  194. package/tests/codex-usage-source.test.mjs +4 -3
  195. package/tests/component-update-api-static.test.mjs +2 -2
  196. package/tests/composer-action-grid-reorder-static.test.mjs +3 -3
  197. package/tests/control-deck-component-updates-static.test.mjs +9 -4
  198. package/tests/control-visibility-static.test.mjs +3 -3
  199. package/tests/controls-layout-static.test.mjs +5 -5
  200. package/tests/conversation-overview-adapter.test.mjs +100 -0
  201. package/tests/document-artifact-static.test.mjs +2 -1
  202. package/tests/draft-conversations.test.mjs +205 -0
  203. package/tests/empty-startup-launcher.test.mjs +197 -0
  204. package/tests/events-tree-context-menu-static.test.mjs +22 -18
  205. package/tests/fake-pi-session-ownership.test.mjs +302 -0
  206. package/tests/fast-mode-client-static.test.mjs +1 -1
  207. package/tests/feature-decision-output-popup-static.test.mjs +2 -2
  208. package/tests/feature-system-prompt-optional-feature-static.test.mjs +1 -1
  209. package/tests/file-viewer-image-static.test.mjs +15 -11
  210. package/tests/file-viewer-search-static.test.mjs +5 -5
  211. package/tests/fixtures/fake-pi.mjs +41 -9
  212. package/tests/footer-provider-usage-visual-static.test.mjs +7 -6
  213. package/tests/foreground-transcript-catch-up-static.test.mjs +7 -4
  214. package/tests/git-footer-context-menu-static.test.mjs +1 -1
  215. package/tests/git-panel-file-preview-static.test.mjs +41 -48
  216. package/tests/git-panel-live-updates-static.test.mjs +2 -1
  217. package/tests/git-workflow-dispatch.test.mjs +66 -0
  218. package/tests/git-workflow-preferences.test.mjs +9 -1
  219. package/tests/guided-git-activation-static.test.mjs +14 -11
  220. package/tests/guided-git-fallback-ui-static.test.mjs +8 -5
  221. package/tests/guided-git-message-reliability-static.test.mjs +10 -6
  222. package/tests/guided-git-publication-backend-static.test.mjs +16 -11
  223. package/tests/http-endpoints-harness.test.mjs +21 -9
  224. package/tests/interaction-state-stability-static.test.mjs +4 -3
  225. package/tests/intercom-conversation-viewer-static.test.mjs +29 -17
  226. package/tests/intercom-tag-layout-static.test.mjs +13 -12
  227. package/tests/intercom-tag-overflow-layout.test.mjs +11 -10
  228. package/tests/main-output-loading-static.test.mjs +4 -4
  229. package/tests/middle-button-drag-scroll-static.test.mjs +3 -3
  230. package/tests/mobile-compact-layout.test.mjs +2 -2
  231. package/tests/mobile-continuity-tablet-static.test.mjs +3 -3
  232. package/tests/mobile-foundation-static.test.mjs +10 -7
  233. package/tests/mobile-phone-experience-static.test.mjs +3 -2
  234. package/tests/mobile-static.test.mjs +173 -135
  235. package/tests/model-catalog-order.test.mjs +103 -0
  236. package/tests/native-parity.test.mjs +6 -4
  237. package/tests/native-session-choice-owner.test.mjs +102 -0
  238. package/tests/native-update-lifecycle.test.mjs +10 -5
  239. package/tests/no-project-http-harness.test.mjs +328 -0
  240. package/tests/no-project-navigation.test.mjs +54 -0
  241. package/tests/no-project-workspaces.test.mjs +77 -0
  242. package/tests/open-issue-wizard-static.test.mjs +1 -1
  243. package/tests/optional-feature-migration-frontend.test.mjs +4 -4
  244. package/tests/optional-feature-prompt-impact-static.test.mjs +3 -3
  245. package/tests/package-updates.test.mjs +630 -0
  246. package/tests/persistent-ui-layout-static.test.mjs +3 -3
  247. package/tests/platform-event-stream.test.mjs +253 -0
  248. package/tests/project-file-viewer-controller.test.mjs +652 -0
  249. package/tests/project-git-tools-adapter.test.mjs +103 -0
  250. package/tests/project-git-tools-controller.test.mjs +577 -0
  251. package/tests/project-runners-controller.test.mjs +453 -0
  252. package/tests/prompt-input-vertical-scroll-static.test.mjs +3 -3
  253. package/tests/prompt-routing-input-clear-static.test.mjs +2 -2
  254. package/tests/questionnaire-dialog.test.mjs +6 -6
  255. package/tests/queue-edit-reorder-static.test.mjs +48 -51
  256. package/tests/rpc-supervisor-host.test.mjs +4 -1
  257. package/tests/safety-guard-auto-review-static.test.mjs +1 -1
  258. package/tests/sampling-native-controls-user-flow.test.mjs +7 -1
  259. package/tests/server-app-runners.test.mjs +536 -0
  260. package/tests/server-codex-fast-mode.test.mjs +346 -0
  261. package/tests/server-conversation-mode.test.mjs +386 -0
  262. package/tests/server-conversation-voice.test.mjs +426 -0
  263. package/tests/server-extension-ui-requests.test.mjs +357 -0
  264. package/tests/server-git-generation.test.mjs +558 -0
  265. package/tests/server-git-mutations.test.mjs +729 -0
  266. package/tests/server-git-reads.test.mjs +381 -0
  267. package/tests/server-git-worktree-sessions.test.mjs +502 -0
  268. package/tests/server-helper-requests.test.mjs +364 -0
  269. package/tests/server-rpc-transports.test.mjs +553 -0
  270. package/tests/server-settings-store.test.mjs +132 -0
  271. package/tests/server-shell-rollout.test.mjs +478 -0
  272. package/tests/server-sse-delivery.test.mjs +410 -0
  273. package/tests/server-workspace-files.test.mjs +546 -0
  274. package/tests/session-attention-scheduler.test.mjs +514 -0
  275. package/tests/session-composer-store.test.mjs +153 -0
  276. package/tests/session-context.test.mjs +134 -0
  277. package/tests/session-extension-requests.test.mjs +193 -0
  278. package/tests/session-ownership-adapter.test.mjs +130 -0
  279. package/tests/session-sampling-ui-static.test.mjs +10 -4
  280. package/tests/session-send-lifetime.test.mjs +140 -0
  281. package/tests/session-shelf-state.test.mjs +348 -0
  282. package/tests/session-shelves-adapter.test.mjs +79 -0
  283. package/tests/session-summary-lifetime.test.mjs +54 -0
  284. package/tests/settings-resource-controller.test.mjs +548 -0
  285. package/tests/shell-action-adapter.test.mjs +169 -0
  286. package/tests/shell-actions.test.mjs +182 -0
  287. package/tests/shell-navigation.test.mjs +348 -0
  288. package/tests/shell-preferences.test.mjs +367 -0
  289. package/tests/side-panel-section-height-removal-static.test.mjs +3 -3
  290. package/tests/stream-output-isolation-static.test.mjs +1 -1
  291. package/tests/subagent-gate-visibility.test.mjs +1 -1
  292. package/tests/subagent-launch-slot-state.test.mjs +2 -2
  293. package/tests/subagent-launch-slots-static.test.mjs +1 -1
  294. package/tests/subagent-observability-static.test.mjs +2 -2
  295. package/tests/subagent-reliability-integration.test.mjs +13 -30
  296. package/tests/syntax-highlighting-static.test.mjs +3 -3
  297. package/tests/tab-close-continuity-static.test.mjs +1 -1
  298. package/tests/tab-metadata-ordering.test.mjs +99 -0
  299. package/tests/terminal-cwd-grouping-static.test.mjs +2 -2
  300. package/tests/terminal-tab-prompt-tooltip-static.test.mjs +2 -0
  301. package/tests/terminal-tab-workspace-static.test.mjs +5 -4
  302. package/tests/terminal-tabs-resize-static.test.mjs +1 -1
  303. package/tests/theme-customizer-static.test.mjs +1 -1
  304. package/tests/thread-display-title.test.mjs +44 -0
  305. package/tests/update-api-harness.test.mjs +15 -14
  306. package/tests/update-tab-restore-harness.test.mjs +3 -0
  307. package/tests/webui-settings-locking.test.mjs +2 -2
  308. package/tests/windows-drive-cwd-picker-static.test.mjs +7 -9
  309. package/tests/workspace-choices.test.mjs +114 -0
  310. package/tests/workspace-save-load-static.test.mjs +7 -4
@@ -0,0 +1,343 @@
1
+ import { expect } from '@playwright/test';
2
+ import { test } from './session-fixture.mjs';
3
+
4
+ test.use({ video: 'off', serviceWorkers: 'block', reducedMotion: 'reduce', actionTimeout: 8_000 });
5
+ test.setTimeout(60_000);
6
+
7
+ const draft = 'Keep this draft while checking composer controls.';
8
+ const model = page => page.locator('#statusBar .footer-model.footer-meta-action, #statusBar .footer-tui-model');
9
+ const effort = page => page.locator('#statusBar .footer-thinking.footer-meta-action');
10
+ const componentModel = page => page.locator('.focused-composer-controls').getByRole('button', { name: /^Model:/ });
11
+ const componentEffort = page => page.locator('.focused-composer-controls').getByRole('button', { name: /^Effort:/ });
12
+
13
+ async function ready(page, ownership, { width = 1440, height = 900, theme = 'dark', inspector = false } = {}) {
14
+ await page.setViewportSize({ width, height });
15
+ await page.addInitScript(({ theme }) => {
16
+ localStorage.setItem('pi-webui-shell-preferences-v1', JSON.stringify({ v: 1, desktopLayout: 'focused' }));
17
+ localStorage.setItem('pi-webui-theme', theme === 'light' ? 'catppuccin-latte' : 'catppuccin-mocha');
18
+ // Put Send first in the saved order to exercise its independent primary placement.
19
+ localStorage.setItem('pi-webui-composer-action-order-v1', JSON.stringify(['send', 'compact', 'options', 'new']));
20
+ }, { theme });
21
+ await page.goto(ownership.baseURL);
22
+ await expect(page.locator('#focusedWorkspace')).toBeVisible();
23
+ await expect(page.locator('#chat')).toContainText('fake answer');
24
+ await expect(model(page)).toBeEnabled();
25
+ await expect(model(page)).toContainText('fake-model');
26
+ await expect(effort(page)).toBeEnabled();
27
+ await expect(page.locator('.focused-composer-controls')).toBeHidden();
28
+ if (inspector) {
29
+ await page.getByRole('button', { name: 'Inspector', exact: true }).click();
30
+ await page.getByRole('tab', { name: 'Project', exact: true }).click();
31
+ await expect(page.locator('#fileTreeSearchInput')).toBeVisible();
32
+ }
33
+ await page.locator('#promptInput').fill(draft);
34
+ }
35
+
36
+ async function screenshot(page, info, name) {
37
+ const path = info.outputPath(`${name}.png`);
38
+ await page.screenshot({ path, animations: 'disabled' });
39
+ await info.attach(name, { path, contentType: 'image/png' });
40
+ }
41
+
42
+ async function expectToolbar(page, { coarse = false, component = false } = {}) {
43
+ const geometry = await page.evaluate(() => {
44
+ const rect = selector => {
45
+ const { x, y, width, height, right, bottom } = document.querySelector(selector).getBoundingClientRect();
46
+ return { x, y, width, height, right, bottom };
47
+ };
48
+ return {
49
+ row: rect('.composer-row'), more: rect('#composerActionsButton'), send: rect('#sendButton'),
50
+ group: document.querySelector('.focused-composer-controls').getClientRects().length ? rect('.focused-composer-controls') : null,
51
+ footer: [...document.querySelectorAll('#statusBar .footer-model.footer-meta-action, #statusBar .footer-tui-model, #statusBar .footer-thinking.footer-meta-action')]
52
+ .map(node => {
53
+ const { x, right, y, bottom } = node.getBoundingClientRect();
54
+ return { x, right, y, bottom };
55
+ }),
56
+ controls: [...document.querySelectorAll('.focused-composer-controls button, .focused-composer-controls select')]
57
+ .filter(node => node.getClientRects().length).map(node => {
58
+ const { x, right, y, bottom, height } = node.getBoundingClientRect();
59
+ return { x, right, y, bottom, height, overflow: node.scrollWidth > node.clientWidth };
60
+ }),
61
+ overflow: document.documentElement.scrollWidth > innerWidth,
62
+ chatScrollLeft: document.querySelector('#focusedWorkspace .chat-panel').scrollLeft,
63
+ viewport: { width: innerWidth, height: innerHeight },
64
+ gradient: getComputedStyle(document.querySelector('#sendButton')).backgroundImage,
65
+ };
66
+ });
67
+ expect(geometry.overflow).toBe(false);
68
+ expect(geometry.chatScrollLeft).toBe(0);
69
+ expect(geometry.more.x).toBeCloseTo(geometry.row.x, 0);
70
+ expect(geometry.send.right).toBeCloseTo(geometry.row.right, 0);
71
+ expect(geometry.more.y).toBeCloseTo(geometry.send.y, 0);
72
+ expect(geometry.more.right + 8).toBeLessThanOrEqual(geometry.send.x);
73
+ expect(geometry.send.width).toBeLessThan(180);
74
+ expect(geometry.gradient).toContain('linear-gradient');
75
+ if (geometry.group) expect(geometry.group.y).toBeGreaterThanOrEqual(geometry.row.bottom);
76
+ expect(geometry.footer).toHaveLength(2);
77
+ for (const control of geometry.footer) {
78
+ expect(control.x).toBeGreaterThanOrEqual(0);
79
+ expect(control.right).toBeLessThanOrEqual(geometry.viewport.width);
80
+ expect(control.y).toBeGreaterThanOrEqual(0);
81
+ expect(control.bottom).toBeLessThanOrEqual(geometry.viewport.height);
82
+ }
83
+ for (const control of [geometry.more, geometry.send, ...geometry.controls]) {
84
+ expect(control.height).toBeGreaterThanOrEqual(coarse ? 44 : 30);
85
+ if (!coarse) expect(control.height).toBeLessThanOrEqual(36);
86
+ expect(control.x).toBeGreaterThanOrEqual(0);
87
+ expect(control.right).toBeLessThanOrEqual(geometry.viewport.width);
88
+ expect(control.y).toBeGreaterThanOrEqual(0);
89
+ expect(control.bottom).toBeLessThanOrEqual(geometry.viewport.height);
90
+ }
91
+ expect(geometry.controls.every(control => !control.overflow)).toBe(true);
92
+ const group = page.locator('.focused-composer-controls');
93
+ if (component || await page.getByRole('combobox', { name: 'During this run' }).isVisible()) {
94
+ await expect(group).toBeVisible();
95
+ } else {
96
+ await expect(group).toBeHidden();
97
+ }
98
+ if (!component) {
99
+ for (const setting of await group.locator('.focused-composer-setting').all()) await expect(setting).toBeHidden();
100
+ await expect(group.locator('.focused-composer-scoped-models')).toBeHidden();
101
+ }
102
+ }
103
+
104
+ async function checkPickers(page) {
105
+ const allTools = page.getByRole('navigation', { name: 'Workspace destinations' }).getByRole('button', { name: 'All tools', exact: true });
106
+ await allTools.click();
107
+ await page.getByRole('searchbox', { name: 'Search all tools' }).fill('/model');
108
+ await page.locator('#shellToolsLauncher').getByRole('button', { name: '/model', exact: true }).click();
109
+ await expect(page.getByRole('dialog', { name: 'Choose model', exact: true })).toBeVisible();
110
+ await expect(page.locator('#nativeCommandBody')).toContainText('fake/fake-model-alt');
111
+ await page.locator('#nativeCommandSearch').fill('fake-model-alt');
112
+ await expect(page.locator('#nativeSelectorList').getByRole('option')).toHaveCount(1);
113
+ await page.locator('#nativeCommandSearch').fill('');
114
+ await page.keyboard.press('Escape');
115
+ await expect(page.locator('#nativeCommandDialog')).toBeHidden();
116
+ await expect(allTools).toBeFocused();
117
+ await model(page).click();
118
+ const scoped = page.getByRole('listbox', { name: /Scoped models/ });
119
+ await expect(scoped).toBeVisible();
120
+ await page.keyboard.press('Escape');
121
+ await expect(scoped).toHaveCount(0);
122
+ await expect(model(page)).toBeFocused();
123
+ await effort(page).click();
124
+ const thinking = page.getByRole('listbox', { name: 'Thinking effort', exact: true });
125
+ await expect(thinking).toBeVisible();
126
+ await expect(thinking.getByRole('option', { name: 'off', exact: true })).toBeVisible();
127
+ await page.keyboard.press('Escape');
128
+ await expect(thinking).toHaveCount(0);
129
+ await expect(effort(page)).toBeFocused();
130
+ await expect(page.locator('#promptInput')).toHaveValue(draft);
131
+ }
132
+
133
+ async function checkMore(page, info, name) {
134
+ const more = page.locator('#composerActionsButton');
135
+ const panel = page.locator('#composerActionsPanel');
136
+ const closedSend = await page.locator('#sendButton').boundingBox();
137
+ await more.click();
138
+ await expect(more).toHaveAttribute('aria-expanded', 'true');
139
+ await expect(panel).toHaveCSS('position', 'fixed');
140
+ const actions = await panel.boundingBox();
141
+ const row = await page.locator('.composer-row').boundingBox();
142
+ const send = await page.locator('#sendButton').boundingBox();
143
+ const moreBounds = await more.boundingBox();
144
+ expect(actions.x).toBeGreaterThanOrEqual(moreBounds.x + moreBounds.width);
145
+ expect(actions.x + actions.width).toBeLessThanOrEqual(send.x);
146
+ expect(actions.y + actions.height).toBeCloseTo(moreBounds.y + moreBounds.height, 0);
147
+ expect(send).toEqual(closedSend);
148
+ expect(send.width).toBeCloseTo(closedSend.width, 0);
149
+ expect(send.height).toBeCloseTo(closedSend.height, 0);
150
+ const compact = await page.locator('#compactButton').boundingBox();
151
+ const options = await page.locator('#optionsMenuButton').boundingBox();
152
+ const newSession = await page.locator('#newSessionButton').boundingBox();
153
+ expect(compact.x + compact.width).toBeLessThanOrEqual(options.x);
154
+ expect(options.x + options.width).toBeLessThanOrEqual(newSession.x);
155
+ for (const button of [compact, options, newSession]) {
156
+ expect(button.y + button.height / 2).toBeCloseTo(compact.y + compact.height / 2, 0);
157
+ }
158
+ await expectToolbar(page);
159
+ const relocatedControls = page.locator('#composerActionsPanel .composer-workflow-mode-dock button, #composerActionsPanel .composer-context-tags button');
160
+ for (const button of await relocatedControls.all()) {
161
+ if (!await button.isVisible()) continue;
162
+ const bounds = await button.boundingBox();
163
+ expect(bounds.y).toBeGreaterThanOrEqual(actions.y - 1);
164
+ expect(bounds.x).toBeGreaterThanOrEqual(actions.x - 1);
165
+ expect(bounds.x + bounds.width).toBeLessThanOrEqual(actions.x + actions.width + 1);
166
+ expect(bounds.y + bounds.height).toBeLessThanOrEqual(actions.y + actions.height + 1);
167
+ }
168
+ await screenshot(page, info, `${name}-more`);
169
+ for (const selector of ['#newSessionButton', '#compactButton', '#optionsMenuButton', '#sendButton']) {
170
+ await page.locator(selector).click({ trial: true });
171
+ }
172
+ await page.locator('#optionsMenuButton').click();
173
+ const menu = page.locator('.composer-options-menu-panel');
174
+ const menuBounds = await menu.boundingBox();
175
+ const viewport = page.viewportSize();
176
+ expect(menuBounds.x).toBeGreaterThanOrEqual(0);
177
+ expect(menuBounds.x + menuBounds.width).toBeLessThanOrEqual(viewport.width);
178
+ expect(menuBounds.y).toBeGreaterThanOrEqual(0);
179
+ expect(menuBounds.y + menuBounds.height).toBeLessThanOrEqual(viewport.height);
180
+ const openedOptions = await page.locator('#optionsMenuButton').boundingBox();
181
+ expect(menuBounds.x).toBeCloseTo(openedOptions.x, 0);
182
+ await page.locator('#optionsSessionSubmenuButton').focus();
183
+ await page.keyboard.press('ArrowRight');
184
+ await page.locator('#optionsNameButton').click({ trial: true });
185
+ expect(await page.locator('.focused-conversation').evaluate(node => node.scrollLeft)).toBe(0);
186
+ await expectToolbar(page);
187
+ await screenshot(page, info, `${name}-nested`);
188
+ await page.locator('#optionsNameButton').click();
189
+ await expect(page.getByPlaceholder('New session name')).toBeVisible();
190
+ await page.keyboard.press('Escape');
191
+ if (await more.getAttribute('aria-expanded') === 'true') await more.click();
192
+ await expect(panel).toBeHidden();
193
+ await expect(page.locator('#promptInput')).toHaveValue(draft);
194
+ }
195
+
196
+ for (const [width, height, inspector] of [[1440, 900, false], [1100, 900, true], [1440, 500, false], [1100, 500, true]]) {
197
+ for (const theme of ['dark', 'light']) {
198
+ test(`compact toolbar at ${width}x${height}, ${theme}${inspector ? ', Project inspector' : ''}`, async ({ page, ownership }, info) => {
199
+ await ready(page, ownership, { width, height, theme, inspector });
200
+ await expect(page.locator('#sendButton')).toHaveText('Send');
201
+ await expectToolbar(page);
202
+ await screenshot(page, info, 'idle');
203
+ await checkPickers(page);
204
+ await checkMore(page, info, 'idle');
205
+
206
+ await ownership.api(`/api/prompt?tab=${ownership.tabs[0].id}`, {
207
+ message: 'fixture continuity held stream', requestId: 'composer-polish-held-stream',
208
+ });
209
+ const behavior = page.getByRole('combobox', { name: 'During this run' });
210
+ await expect(behavior).toBeVisible();
211
+ await behavior.selectOption('followUp');
212
+ await expect(page.locator('#sendButton')).toHaveText('Queue message');
213
+ await expectToolbar(page);
214
+ await screenshot(page, info, 'running-queue');
215
+ await behavior.selectOption('steer');
216
+ await expect(page.locator('#sendButton')).toHaveText('Steer run');
217
+ await expect(page.locator('.focused-composer-description')).toHaveText('Send guidance to Pi during this run.');
218
+ await expect(page.locator('.focused-run-controls #abortButton')).toBeVisible();
219
+ await expectToolbar(page);
220
+ await screenshot(page, info, 'running-steer');
221
+ await checkPickers(page);
222
+ await checkMore(page, info, 'running');
223
+ await expect(page.locator('#promptInput')).toHaveValue(draft);
224
+ });
225
+ }
226
+ }
227
+
228
+ test('focused desktop keeps coarse-pointer targets at least 44px', async ({ browser, ownership }, info) => {
229
+ const context = await browser.newContext({ hasTouch: true, serviceWorkers: 'block', reducedMotion: 'reduce' });
230
+ try {
231
+ const page = await context.newPage();
232
+ await ready(page, ownership, { width: 1440, height: 900 });
233
+ expect(await page.evaluate(() => matchMedia('(pointer: coarse)').matches)).toBe(true);
234
+ await expectToolbar(page, { coarse: true });
235
+ await checkPickers(page);
236
+ await ownership.api(`/api/prompt?tab=${ownership.tabs[0].id}`, {
237
+ message: 'fixture continuity held stream', requestId: 'composer-polish-touch-stream',
238
+ });
239
+ await expect(page.getByRole('combobox', { name: 'During this run' })).toBeVisible();
240
+ await expectToolbar(page, { coarse: true });
241
+ await screenshot(page, info, 'coarse-pointer');
242
+ } finally {
243
+ await context.close();
244
+ }
245
+ });
246
+
247
+ for (const theme of ['dark', 'light']) {
248
+ test(`focused styles retain long values and disabled reasons, ${theme}`, async ({ page, ownership }, info) => {
249
+ await ready(page, ownership, { width: 1100, height: 500, inspector: true, theme });
250
+ // Fake Pi has short model names. Mount the same component in its real shell
251
+ // to stress the focused CSS with long values and both disabled descriptions.
252
+ const labels = {
253
+ modelLabel: 'VeryLongProviderAndModelIdentifier'.repeat(4),
254
+ effortLabel: 'Extended reasoning effort for the next prompt',
255
+ modelReason: 'Model selection is unavailable while this session reconnects. Your draft will be kept.',
256
+ effortReason: 'Effort selection is unavailable until the session model has loaded. Please wait for reconnection.',
257
+ };
258
+ await page.evaluate(async labels => {
259
+ const { createFocusedComposerControls } = await import('/focused-composer-controls.mjs');
260
+ const probe = createFocusedComposerControls({ document, onScopedModels() {} });
261
+ document.querySelector('.focused-composer-controls').replaceWith(probe.element);
262
+ probe.update({ ...labels, runActive: true, modelDisabled: true, effortDisabled: true });
263
+ }, labels);
264
+ await expect(componentModel(page)).toBeDisabled();
265
+ await expect(componentEffort(page)).toBeDisabled();
266
+ await expect(page.getByRole('button', { name: 'Scoped models', exact: true })).toBeDisabled();
267
+ await expect(componentModel(page)).toHaveAttribute('title', labels.modelReason);
268
+ await expect(componentModel(page)).toHaveAccessibleDescription(labels.modelReason);
269
+ await expect(componentEffort(page)).toHaveAccessibleDescription(labels.effortReason);
270
+ await expect(page.getByText(labels.modelReason, { exact: true })).toBeVisible();
271
+ await expect(page.getByText(labels.effortReason, { exact: true })).toBeVisible();
272
+ const reasons = await page.locator('.focused-composer-reason').evaluateAll(nodes => nodes.map(node => {
273
+ const rect = node.getBoundingClientRect();
274
+ return { overflow: node.scrollWidth > node.clientWidth, top: rect.top, bottom: rect.bottom, right: rect.right };
275
+ }));
276
+ for (const reason of reasons) {
277
+ expect(reason.overflow).toBe(false);
278
+ expect(reason.top).toBeGreaterThanOrEqual(0);
279
+ expect(reason.bottom).toBeLessThanOrEqual(500);
280
+ expect(reason.right).toBeLessThanOrEqual(1100);
281
+ }
282
+ await expectToolbar(page, { component: true });
283
+ await screenshot(page, info, 'disabled-reasons');
284
+ await page.evaluate(async labels => {
285
+ const { createFocusedComposerControls } = await import('/focused-composer-controls.mjs');
286
+ const probe = createFocusedComposerControls({ document, onScopedModels() {} });
287
+ document.querySelector('.focused-composer-controls').replaceWith(probe.element);
288
+ probe.update(labels);
289
+ }, labels);
290
+ await expect(componentModel(page)).toHaveAttribute('title', labels.modelLabel);
291
+ await expect(componentEffort(page)).toHaveAttribute('title', labels.effortLabel);
292
+ expect(await page.locator('.focused-composer-model-value').evaluate(node => node.scrollWidth > node.clientWidth)).toBe(true);
293
+ await page.keyboard.press('Tab');
294
+ await componentModel(page).focus();
295
+ await expect(componentModel(page)).toBeFocused();
296
+ await expect(componentModel(page)).toHaveCSS('outline-style', 'solid');
297
+ await page.keyboard.press('Tab');
298
+ await expect(page.getByRole('button', { name: 'Scoped models', exact: true })).toBeFocused();
299
+ await page.keyboard.press('Tab');
300
+ await expect(componentEffort(page)).toBeFocused();
301
+ await expectToolbar(page, { component: true });
302
+ await screenshot(page, info, 'long-values');
303
+ await expect(page.locator('#promptInput')).toHaveValue(draft);
304
+ });
305
+ }
306
+
307
+
308
+ for (const height of [500, 900]) {
309
+ test(`minimized workflow controls and slash suggestions stay reachable at 1100x${height}`, async ({ page, ownership }, info) => {
310
+ await ready(page, ownership, { width: 1100, height, theme: 'dark', inspector: true });
311
+ await ownership.api(`/api/prompt?tab=${ownership.tabs[0].id}`, {
312
+ message: 'fixture workflow inspector running', requestId: 'composer-minimized-workflow',
313
+ });
314
+ await page.getByRole('tab', { name: 'Activity', exact: true }).click();
315
+ await page.getByRole('combobox', { name: 'Activity section', exact: true }).selectOption({ label: 'Progress' });
316
+ await page.locator('.workflow-overlay-close-button').first().click();
317
+ await page.getByRole('tab', { name: 'Project', exact: true }).click();
318
+ await page.locator('#composerActionsButton').click();
319
+ const restore = page.locator('#workflowOverlayOpenButton');
320
+ await expect(restore).toBeVisible();
321
+ await expect(page.locator('#workflowModeButton')).toBeVisible();
322
+ const controls = page.locator('#composerActionsPanel button');
323
+ const bounds = await controls.evaluateAll(nodes => nodes.filter(node => node.getClientRects().length && !node.closest('.composer-options-menu-panel')).map(node => {
324
+ const { x, y, right, bottom } = node.getBoundingClientRect();
325
+ return { id: node.id, x, y, right, bottom };
326
+ }));
327
+ for (const id of ['workflowOverlayOpenButton', 'workflowModeButton']) {
328
+ const own = bounds.find(button => button.id === id);
329
+ for (const other of bounds.filter(button => button.id !== id)) {
330
+ expect(Math.min(own.right, other.right) <= Math.max(own.x, other.x) + 1
331
+ || Math.min(own.bottom, other.bottom) <= Math.max(own.y, other.y) + 1, `${id} overlaps ${other.id}`).toBe(true);
332
+ }
333
+ }
334
+ await restore.click({ trial: true });
335
+ await page.locator('#workflowModeButton').click({ trial: true });
336
+ await page.locator('#promptInput').fill('/');
337
+ await expect(page.locator('#commandSuggest')).toBeVisible();
338
+ await page.locator('#sendButton').click({ trial: true });
339
+ await page.locator('#composerActionsButton').click({ trial: true });
340
+ await expect(page.locator('#promptInput')).toHaveValue('/');
341
+ await screenshot(page, info, 'short-window-suggestions-recovery');
342
+ });
343
+ }
@@ -43,7 +43,7 @@ test.afterAll(async () => {
43
43
  await rm(tempRoot, { recursive: true, force: true });
44
44
  });
45
45
 
46
- test("Pi and Web UI actions confirm independent native targets and show durable receipts", async ({ page }) => {
46
+ test("Pi and Web UI actions start independent native targets and show durable receipts", async ({ page }) => {
47
47
  const requests = [];
48
48
  const jobs = { pi: null, webui: null };
49
49
  const status = () => ({ updateAvailable: true, updateInProgress: Object.values(jobs).some((job) => job?.phase === "running"), canRunUpdate: !Object.values(jobs).some((job) => job?.phase === "running"), nativeJobs: jobs, nativeJobDiscoveryError: "", pi: { checked: true, currentVersion: "0.87.1", activeRuntimeVersion: "0.80.10", pathInstallationVersion: "0.87.1", latestVersion: "0.88.0", updateAvailable: true }, webui: { checked: true, currentVersion: "0.8.1", latestVersion: "0.8.2", updateAvailable: true } });
@@ -69,25 +69,17 @@ test("Pi and Web UI actions confirm independent native targets and show durable
69
69
  await page.goto(baseURL);
70
70
  await page.locator("#piVersionButton").click();
71
71
  await page.locator("#piComponentUpdateButton").click();
72
- await expect(page.locator("#confirmationSummary")).toContainText("/safe/path-pi/cli.js");
73
- await expect(page.locator("#confirmationSummary")).toContainText("0.80.10");
74
- await expect(page.locator("#confirmationSummary")).toContainText("Confirmed PATH Pi: 0.87.1 at /safe/path-pi");
75
- await expect(page.locator("#confirmationSummary")).toContainText("/safe/agent");
76
- await expect(page.locator("#confirmationSummary")).toContainText("Native lifecycle scripts");
77
- await page.locator("#confirmationConfirmButton").click();
78
72
  await expect(page.locator("#piComponentUpdateStatus")).toContainText("fixture-pi");
79
73
  await expect(page.locator("#piComponentUpdateStatus")).toHaveAttribute("data-update-running");
80
74
  jobs.pi = { ...jobs.pi, phase: "unchanged", receipts: [{ id: "pi", status: "unchanged", stdout: "Already current", stderr: "" }] };
81
- await expect(page.locator("#piComponentUpdateStatus")).toContainText("No automatic restart", { timeout: 8_000 });
75
+ await expect(page.locator("#piComponentUpdateStatus")).toContainText("Already up to date. No restart is needed.", { timeout: 8_000 });
82
76
  await expect(page.locator("#piComponentUpdateOutput")).toContainText("Already current");
83
77
  await page.locator("#piReleaseNotesCloseButton").click();
78
+ await page.locator("#updateNotificationDismissButton").click();
79
+ await expect(page.locator("#updateNotification")).toBeHidden();
84
80
  await page.locator("#webuiVersionButton").click();
85
81
  await page.locator("#webuiComponentUpdateButton").click();
86
- await expect(page.locator("#confirmationSummary")).toContainText("/safe/npm/webui");
87
- await expect(page.locator("#confirmationSummary")).toContainText("/safe/agent/npm/webui");
88
- await expect(page.locator("#confirmationSummary")).toContainText("Confirmed PATH Pi: 0.87.1 at /safe/path-pi");
89
- await expect(page.locator("#confirmationSummary")).toContainText("Project installation needs manual update");
90
- await page.locator("#confirmationConfirmButton").click();
82
+ await expect.poll(() => jobs.webui?.transactionId).toBe("fixture-webui");
91
83
  jobs.webui = { ...jobs.webui, phase: "partial", outcome: "partial", receipts: [{ id: "webui:npm-global", status: "changed", stdout: "updated" }, { id: "webui:pi-user", status: "failed", stderr: "fixture failure" }], verifiedTargets: [{ id: "webui:npm-global", status: "healthy" }] };
92
84
  await expect(page.locator("#webuiComponentUpdateStatus")).toContainText("partial result", { timeout: 8_000 });
93
85
  await expect(page.locator("#webuiComponentUpdateOutput")).toContainText("fixture failure");
@@ -117,7 +109,6 @@ test("ambiguous apply observes confirmed ID before authoritative discovery clear
117
109
  await page.goto(baseURL);
118
110
  await page.locator("#piVersionButton").click();
119
111
  await page.locator("#piComponentUpdateButton").click();
120
- await page.locator("#confirmationConfirmButton").click();
121
112
  await expect(page.locator("#piComponentUpdateButton")).toBeDisabled();
122
113
  await expect(page.locator("#piComponentUpdateStatus")).toContainText("uncertain-pi-job");
123
114
  assert.equal(applyCount, 1, "no second apply before job inspection");
@@ -259,16 +259,30 @@ test("Right, Left, Both, Sidebar rail, independent state, overlay, singleton ARI
259
259
  await page.waitForTimeout(300);
260
260
  if (await files.getAttribute("aria-expanded") !== "true") await files.click();
261
261
  if (await controls.getAttribute("aria-expanded") !== "true") await controls.click();
262
+ await expect(files).toHaveAttribute("aria-expanded", "true");
263
+ await expect(controls).toHaveAttribute("aria-expanded", "true");
264
+ await files.click();
262
265
  await expect(files).toHaveAttribute("aria-expanded", "false");
263
266
  await controls.press("Alt+ArrowRight");
267
+ await expect(controls).toBeFocused();
264
268
  await expect(controls).toHaveAttribute("aria-expanded", "true");
265
- if (await files.getAttribute("aria-expanded") !== "true") await files.click();
269
+ await expect(files).toHaveAttribute("aria-expanded", "false");
270
+ await files.click();
266
271
  await expect(files).toHaveAttribute("aria-expanded", "true");
267
272
  await files.press("Alt+ArrowRight");
273
+ await expect(files).toBeFocused();
268
274
  await expect(files).toHaveAttribute("aria-expanded", "true");
275
+ await expect(controls).toHaveAttribute("aria-expanded", "true");
276
+ await controls.click();
269
277
  await expect(controls).toHaveAttribute("aria-expanded", "false");
278
+ await expect(files).toHaveAttribute("aria-expanded", "true");
270
279
 
271
280
  await files.press("Alt+ArrowLeft");
281
+ await expect(files).toBeFocused();
282
+ await expect(files).toHaveAttribute("aria-expanded", "true");
283
+ await expect(controls).toHaveAttribute("aria-expanded", "false");
284
+ await files.click();
285
+ await expect(files).toHaveAttribute("aria-expanded", "false");
272
286
  const latentLeftBefore = await page.evaluate(() => JSON.parse(localStorage.getItem("pi-webui-control-deck-layout-v2") || "null")?.sectionLayout?.leftSectionIds || []);
273
287
  await selectPlacement(page, "right");
274
288
  await controls.focus();
@@ -279,6 +293,8 @@ test("Right, Left, Both, Sidebar rail, independent state, overlay, singleton ARI
279
293
  await expect.poll(() => page.locator("#sidePanelBodyRight > [data-side-panel-section]").evaluateAll((nodes) => nodes.map((node) => node.dataset.sidePanelSection))).toEqual(rightOrder);
280
294
  await selectPlacement(page, "both");
281
295
  await expect(page.locator('#sidePanelBodyLeft > [data-side-panel-section="files"]')).toHaveCount(1);
296
+ await expect(files).toHaveAttribute("aria-expanded", "false");
297
+ await expect(controls).toHaveAttribute("aria-expanded", "true");
282
298
 
283
299
  await page.locator("#toggleSidePanelLeftButton").click();
284
300
  await expect(page.locator("body")).toHaveClass(/side-panel-left-collapsed/);
@@ -315,7 +331,7 @@ test("Right, Left, Both, Sidebar rail, independent state, overlay, singleton ARI
315
331
  await expect(page.locator("#sidePanelLeft")).toBeHidden();
316
332
  const rightPlacementChatBox = await page.locator(".chat").boundingBox();
317
333
  const leftRailBox = await page.locator(".terminal-tabs-shell").boundingBox();
318
- assert.ok(rightPlacementChatBox && leftRailBox && leftRailBox.x < rightPlacementChatBox.x, "Right Control Deck placement should switch the terminal/tabs rail to the left of chat");
334
+ assert.ok(rightPlacementChatBox && leftRailBox && leftRailBox.x < rightPlacementChatBox.x, "Right Control Deck placement should switch the thread rail to the left of chat");
319
335
 
320
336
  await page.locator("#controlDeckPlacementSelect").selectOption("left");
321
337
  await expect(page.locator("body")).not.toHaveClass(/terminal-tabs-sidebar-start/);
@@ -323,19 +339,18 @@ test("Right, Left, Both, Sidebar rail, independent state, overlay, singleton ARI
323
339
  await expect(page.locator("#sidePanel")).toBeHidden();
324
340
  const chatBox = await page.locator(".chat").boundingBox();
325
341
  const railBox = await page.locator(".terminal-tabs-shell").boundingBox();
326
- assert.ok(chatBox && railBox && railBox.x > chatBox.x, "Left Control Deck placement should switch the terminal/tabs rail to the right of chat");
327
- await expect(page.locator("#controlDeckPlacementStatus")).toContainText("Control Deck left, terminal/tabs right");
342
+ assert.ok(chatBox && railBox && railBox.x > chatBox.x, "Left Control Deck placement should switch the thread rail to the right of chat");
343
+ await expect(page.locator("#controlDeckPlacementStatus")).toContainText("Control Deck left, threads right");
328
344
  const newTabButton = page.locator("#newTabButton");
345
+ const newTabButtonBox = await newTabButton.boundingBox();
346
+ assert.ok(newTabButtonBox && newTabButtonBox.x >= railBox.x - 1 && newTabButtonBox.x + newTabButtonBox.width <= railBox.x + railBox.width + 1, `the right-rail compose button should stay inside its rail: ${JSON.stringify({ newTabButtonBox, railBox })}`);
329
347
  await newTabButton.hover();
330
- await expect(page.locator("#newTabMenuPanel")).toBeVisible();
331
- const pointerMenuBox = await page.locator("#newTabMenuPanel").boundingBox();
332
- assert.ok(pointerMenuBox && pointerMenuBox.x < railBox.x && pointerMenuBox.x >= 0 && pointerMenuBox.x + pointerMenuBox.width <= 2200, `pointer-opened right-rail menu should open inward without viewport clipping: ${JSON.stringify({ pointerMenuBox, railBox })}`);
333
- await page.mouse.move(chatBox.x + 20, chatBox.y + 20);
334
- await expect(page.locator("#newTabMenuPanel")).toBeHidden();
348
+ await expect(page.locator("#newThreadDialog")).toBeHidden();
335
349
  await newTabButton.focus();
336
- await expect(page.locator("#newTabMenuPanel")).toBeVisible();
337
- const keyboardMenuBox = await page.locator("#newTabMenuPanel").boundingBox();
338
- assert.ok(keyboardMenuBox && keyboardMenuBox.x < railBox.x && keyboardMenuBox.x >= 0 && keyboardMenuBox.x + keyboardMenuBox.width <= 2200, `keyboard-opened right-rail menu should open inward without viewport clipping: ${JSON.stringify({ keyboardMenuBox, railBox })}`);
350
+ await page.keyboard.press("Enter");
351
+ await expect(page.locator("#newThreadDialog")).toBeVisible();
352
+ const paletteBox = await page.locator("#newThreadDialog").boundingBox();
353
+ assert.ok(paletteBox && paletteBox.x >= 0 && paletteBox.x + paletteBox.width <= 2200 && paletteBox.y >= 0 && paletteBox.y + paletteBox.height <= 1000, `the new-thread palette should open without viewport clipping: ${JSON.stringify({ paletteBox })}`);
339
354
  await page.keyboard.press("Escape");
340
355
  const workspaceButton = page.locator("#workspaceDashboardToggleButton");
341
356
  await workspaceButton.hover();
@@ -463,6 +463,11 @@ test("keyboard-only recovery from Send after every catalog item is hidden", asyn
463
463
  await openAreaMenu(page);
464
464
  await expect.poll(async () => checkboxes.evaluateAll((items) => items.map((item) => item.getAttribute("aria-checked")))).toEqual(Array(24).fill("true"));
465
465
  await page.keyboard.press("Escape");
466
+ // The next serial case reads the same server settings. Do not close this
467
+ // page while its final Show all write is still queued behind earlier toggles.
468
+ await expect.poll(hiddenIdsOnDisk).toEqual([]);
469
+ await expect.poll(() => page.evaluate(() => Object.keys(localStorage)
470
+ .filter((key) => key.startsWith("pi-webui-ui-layout-pending")).length)).toBe(0);
466
471
  });
467
472
 
468
473
  test("pending visibility mutation survives same-origin cache adoption and rewrites the cache after acknowledgment", async ({ browser }) => {
@@ -74,9 +74,28 @@ test("Controls use aligned name and parameter columns with viewport-safe tooltip
74
74
  await openControls(page);
75
75
 
76
76
  const rows = page.locator("#sidePanelSectionControls .control-row");
77
- await expect(rows).toHaveCount(13);
77
+ const rowLabels = [
78
+ "Model",
79
+ "Thinking effort",
80
+ "Thinking output",
81
+ "Desktop layout",
82
+ "Compact session navigation",
83
+ "Thread placement",
84
+ "Control Deck placement",
85
+ "Theme mode",
86
+ "Theme",
87
+ "Background",
88
+ "Notifications",
89
+ "Compact mode (Experimental)",
90
+ "Connection",
91
+ "PIN protection",
92
+ "Network access",
93
+ "Action",
94
+ ];
95
+ await expect(rows.locator(".control-row-label")).toHaveText(rowLabels);
78
96
  const visibleRows = rows.filter({ visible: true });
79
- await expect(visibleRows).toHaveCount(10);
97
+ const hiddenNetworkRows = new Set(["Connection", "PIN protection", "Network access"]);
98
+ await expect(visibleRows.locator(".control-row-label")).toHaveText(rowLabels.filter((label) => !hiddenNetworkRows.has(label)));
80
99
  for (let index = 0; index < await visibleRows.count(); index += 1) {
81
100
  const columns = await visibleRows.nth(index).evaluate((row) => getComputedStyle(row).gridTemplateColumns.split(" ").filter(Boolean));
82
101
  assert.equal(columns.length, 2, `visible setting row ${index + 1} should have two grid columns`);