@firstpick/pi-package-webui 0.11.0 → 0.11.2

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (318) hide show
  1. package/DEVELOPMENT.md +181 -12
  2. package/README.md +41 -9
  3. package/TECHNICAL.md +91 -8
  4. package/bin/pi-webui.mjs +5432 -11428
  5. package/index.ts +10 -3
  6. package/lib/codex-cli-usage.mjs +232 -0
  7. package/lib/codex-usage-auth.mjs +39 -3
  8. package/lib/codex-usage-source.mjs +36 -0
  9. package/lib/component-update-state.mjs +2 -2
  10. package/lib/git-workflow-preference-values.mjs +122 -0
  11. package/lib/git-workflow-preferences.mjs +35 -563
  12. package/lib/package-updates.mjs +260 -0
  13. package/lib/rpc-supervisor-client.mjs +8 -4
  14. package/lib/server/app-runners.mjs +1667 -0
  15. package/lib/server/codex-fast-mode.mjs +161 -0
  16. package/lib/server/conversation-mode.mjs +218 -0
  17. package/lib/server/conversation-voice.mjs +318 -0
  18. package/lib/server/extension-ui-requests.mjs +114 -0
  19. package/lib/server/git-generation.mjs +459 -0
  20. package/lib/server/git-mutations.mjs +1827 -0
  21. package/lib/server/git-reads.mjs +608 -0
  22. package/lib/server/git-worktree-sessions.mjs +408 -0
  23. package/lib/server/helper-requests.mjs +82 -0
  24. package/lib/server/no-project-workspaces.mjs +103 -0
  25. package/lib/server/rpc-transports.mjs +394 -0
  26. package/lib/server/settings-store.mjs +544 -0
  27. package/lib/server/sse-delivery.mjs +138 -0
  28. package/lib/server/workspace-files.mjs +563 -0
  29. package/lib/update/supervisor.mjs +4 -0
  30. package/lib/webui-workspaces.mjs +2 -0
  31. package/package.json +5 -5
  32. package/public/activity-agents-controller.mjs +269 -0
  33. package/public/activity-events-controller.mjs +236 -0
  34. package/public/activity-intercom-controller.mjs +627 -0
  35. package/public/activity-queue-controller.mjs +534 -0
  36. package/public/activity-todo-view.mjs +89 -0
  37. package/public/activity-usage-controller.mjs +589 -0
  38. package/public/app.js +3761 -3878
  39. package/public/conversation-overview.css +84 -0
  40. package/public/conversation-overview.mjs +193 -0
  41. package/public/draft-conversations.mjs +135 -0
  42. package/public/focused-composer-controls.css +111 -0
  43. package/public/focused-composer-controls.mjs +143 -0
  44. package/public/focused-composer-disclosure.mjs +223 -0
  45. package/public/focused-shell-adapter.css +264 -0
  46. package/public/focused-shell-adapter.mjs +257 -0
  47. package/public/index.html +137 -80
  48. package/public/model-catalog-order.mjs +63 -0
  49. package/public/platform-event-stream.mjs +64 -0
  50. package/public/project-artifact-controller.mjs +218 -0
  51. package/public/project-file-viewer-controller.mjs +383 -0
  52. package/public/project-git-tools-controller.mjs +181 -0
  53. package/public/project-runners-controller.mjs +220 -0
  54. package/public/service-worker.js +52 -1
  55. package/public/session-attention-scheduler.mjs +182 -0
  56. package/public/session-composer-store.mjs +56 -0
  57. package/public/session-context.mjs +51 -0
  58. package/public/session-extension-requests.mjs +63 -0
  59. package/public/session-shelf-state.mjs +151 -0
  60. package/public/session-shelves.css +171 -0
  61. package/public/session-shelves.mjs +95 -0
  62. package/public/settings-navigation-controller.mjs +249 -0
  63. package/public/settings-navigation.css +61 -0
  64. package/public/settings-resource-controller.mjs +232 -0
  65. package/public/settings-workspace.css +19 -0
  66. package/public/settings-workspace.mjs +175 -0
  67. package/public/shell-actions.mjs +87 -0
  68. package/public/shell-attention-inbox.css +72 -0
  69. package/public/shell-attention-inbox.mjs +198 -0
  70. package/public/shell-context-actions.css +61 -0
  71. package/public/shell-context-actions.mjs +168 -0
  72. package/public/shell-inspector-resize.mjs +124 -0
  73. package/public/shell-navigation-resize.mjs +107 -0
  74. package/public/shell-navigation.mjs +127 -0
  75. package/public/shell-preferences.mjs +108 -0
  76. package/public/shell-surfaces.mjs +99 -0
  77. package/public/shell-tools-launcher.css +97 -0
  78. package/public/shell-tools-launcher.mjs +222 -0
  79. package/public/shell-view-host.mjs +115 -0
  80. package/public/shell-workspace.css +266 -0
  81. package/public/shell-workspace.mjs +402 -0
  82. package/public/sidebar-update-menu.css +190 -0
  83. package/public/sidebar-update-menu.mjs +512 -0
  84. package/public/styles.css +320 -169
  85. package/public/subagent-launch-slot-state.mjs +2 -2
  86. package/public/theme-contract.mjs +1 -1
  87. package/public/themed-selects.css +156 -0
  88. package/public/workspace-choices.mjs +104 -0
  89. package/tests/activity-agents-controller.test.mjs +652 -0
  90. package/tests/activity-events-controller.test.mjs +511 -0
  91. package/tests/app-runner-terminal-static.test.mjs +3 -3
  92. package/tests/append-system-http.test.mjs +7 -6
  93. package/tests/append-system-selector-static.test.mjs +6 -6
  94. package/tests/aur-review-widget-static.test.mjs +11 -3
  95. package/tests/boot-failure-diagnostics.test.mjs +8 -3
  96. package/tests/browser/activity-intercom-controller.spec.mjs +457 -0
  97. package/tests/browser/activity-navigation-integration.spec.mjs +45 -0
  98. package/tests/browser/activity-owner-integration.spec.mjs +201 -0
  99. package/tests/browser/activity-queue-controller.spec.mjs +405 -0
  100. package/tests/browser/activity-section-picker.spec.mjs +294 -0
  101. package/tests/browser/activity-todo-view.spec.mjs +60 -0
  102. package/tests/browser/activity-usage-controller.spec.mjs +416 -0
  103. package/tests/browser/compact-layout-integration.spec.mjs +58 -0
  104. package/tests/browser/composer-action-grid-reorder.spec.mjs +16 -0
  105. package/tests/browser/composer-disclosure.spec.mjs +389 -0
  106. package/tests/browser/composer-toolbar-polish.spec.mjs +343 -0
  107. package/tests/browser/control-deck-component-updates.spec.mjs +5 -14
  108. package/tests/browser/control-deck-side-panels.spec.mjs +27 -12
  109. package/tests/browser/control-visibility.spec.mjs +5 -0
  110. package/tests/browser/controls-layout.spec.mjs +21 -2
  111. package/tests/browser/conversation-overview.spec.mjs +251 -0
  112. package/tests/browser/draft-conversations.spec.mjs +276 -0
  113. package/tests/browser/empty-startup-fixture.mjs +135 -0
  114. package/tests/browser/empty-startup.spec.mjs +282 -0
  115. package/tests/browser/events-tree-context-menu.spec.mjs +1 -0
  116. package/tests/browser/focused-composer-more.spec.mjs +127 -0
  117. package/tests/browser/focused-model-shortcuts.spec.mjs +120 -0
  118. package/tests/browser/focused-navigation-fixture.mjs +32 -0
  119. package/tests/browser/focused-project-activity.spec.mjs +111 -0
  120. package/tests/browser/focused-shell-integration.spec.mjs +208 -0
  121. package/tests/browser/folder-picker-layout-fixture.mjs +13 -0
  122. package/tests/browser/folder-picker-layout.spec.mjs +302 -0
  123. package/tests/browser/footer-model-advanced-layout.spec.mjs +27 -14
  124. package/tests/browser/git-setup-cancel.spec.mjs +251 -0
  125. package/tests/browser/guided-git-fallback.spec.mjs +40 -21
  126. package/tests/browser/inspector-header.spec.mjs +221 -0
  127. package/tests/browser/inspector-overview-integration.spec.mjs +104 -0
  128. package/tests/browser/inspector-resize.spec.mjs +227 -0
  129. package/tests/browser/inspector-topic-overflow.spec.mjs +56 -0
  130. package/tests/browser/interaction-action-discovery.spec.mjs +332 -0
  131. package/tests/browser/interaction-attention-inbox.spec.mjs +364 -0
  132. package/tests/browser/interaction-attention-integration.spec.mjs +53 -0
  133. package/tests/browser/interaction-composer-controls.spec.mjs +267 -0
  134. package/tests/browser/interaction-composer-integration.spec.mjs +175 -0
  135. package/tests/browser/interaction-continuity.spec.mjs +50 -26
  136. package/tests/browser/interaction-model-picker.spec.mjs +86 -0
  137. package/tests/browser/last-terminal-close.spec.mjs +280 -0
  138. package/tests/browser/mobile-foundation.spec.mjs +172 -20
  139. package/tests/browser/model-catalog-groups.spec.mjs +104 -0
  140. package/tests/browser/more-row-menus.spec.mjs +258 -0
  141. package/tests/browser/new-tab-hit-target.spec.mjs +228 -0
  142. package/tests/browser/no-project-conversation.spec.mjs +113 -0
  143. package/tests/browser/optimistic-prompt.spec.mjs +3 -0
  144. package/tests/browser/overhaul-w7-accessibility.spec.mjs +227 -0
  145. package/tests/browser/overhaul-w7-capabilities.spec.mjs +298 -0
  146. package/tests/browser/overhaul-w7-companions.spec.mjs +290 -0
  147. package/tests/browser/overhaul-w7-focus-repairs.spec.mjs +210 -0
  148. package/tests/browser/overhaul-w7-layout-repairs.spec.mjs +183 -0
  149. package/tests/browser/overhaul-w7-parent-repairs.spec.mjs +97 -0
  150. package/tests/browser/overhaul-w7-pwa.spec.mjs +247 -0
  151. package/tests/browser/overhaul-w7-responsive.spec.mjs +450 -0
  152. package/tests/browser/overhaul-w7-update.spec.mjs +215 -0
  153. package/tests/browser/overhaul-w7-zoom.spec.mjs +243 -0
  154. package/tests/browser/overview-agent-ownership.spec.mjs +45 -0
  155. package/tests/browser/persistent-ui-layout.spec.mjs +3 -0
  156. package/tests/browser/project-artifact-controller.spec.mjs +324 -0
  157. package/tests/browser/project-artifact-integration.spec.mjs +103 -0
  158. package/tests/browser/project-file-buffer-integration.spec.mjs +230 -0
  159. package/tests/browser/project-git-tools-integration.spec.mjs +369 -0
  160. package/tests/browser/session-fixture.mjs +118 -0
  161. package/tests/browser/session-ownership.spec.mjs +175 -0
  162. package/tests/browser/session-shelves-integration.spec.mjs +219 -0
  163. package/tests/browser/session-shelves.spec.mjs +340 -0
  164. package/tests/browser/session-sidebar-resize.spec.mjs +138 -0
  165. package/tests/browser/session-summary.spec.mjs +17 -12
  166. package/tests/browser/settings-complete-home.spec.mjs +463 -0
  167. package/tests/browser/settings-entrypoint.spec.mjs +104 -0
  168. package/tests/browser/settings-navigation-controller.spec.mjs +383 -0
  169. package/tests/browser/settings-navigation-integration.spec.mjs +348 -0
  170. package/tests/browser/settings-resource-lifetime.spec.mjs +349 -0
  171. package/tests/browser/settings-workspace-integration.spec.mjs +132 -0
  172. package/tests/browser/shell-ownership.spec.mjs +398 -0
  173. package/tests/browser/shell-rollout-fixture.mjs +259 -0
  174. package/tests/browser/shell-rollout.spec.mjs +357 -0
  175. package/tests/browser/shell-tools-launcher.spec.mjs +260 -0
  176. package/tests/browser/shell-workspace.spec.mjs +433 -0
  177. package/tests/browser/side-panel-section-reorder.spec.mjs +3 -1
  178. package/tests/browser/sidebar-floating-tooltips.spec.mjs +37 -0
  179. package/tests/browser/sidebar-update-integration.spec.mjs +277 -0
  180. package/tests/browser/sidebar-update-menu.spec.mjs +402 -0
  181. package/tests/browser/sidebar-update-progress.spec.mjs +472 -0
  182. package/tests/browser/stream-output-isolation.spec.mjs +6 -3
  183. package/tests/browser/themed-selects.spec.mjs +297 -0
  184. package/tests/browser/thread-start-flow.spec.mjs +481 -0
  185. package/tests/browser/ui-polish-activity-controls.spec.mjs +177 -0
  186. package/tests/browser/ui-polish-features.spec.mjs +85 -0
  187. package/tests/browser/ui-polish-file-header.spec.mjs +43 -0
  188. package/tests/browser/ui-polish-local-git.spec.mjs +183 -0
  189. package/tests/browser/ui-polish-mobile-recovery.spec.mjs +36 -0
  190. package/tests/browser/ui-polish-navigation.spec.mjs +127 -0
  191. package/tests/browser/ui-polish-session-actions.spec.mjs +282 -0
  192. package/tests/browser/user-noticeable-fixes.spec.mjs +10 -3
  193. package/tests/browser/windows-drive-parent.spec.mjs +4 -2
  194. package/tests/browser/workspace-draft-selection.spec.mjs +266 -0
  195. package/tests/codex-cli-usage.test.mjs +189 -0
  196. package/tests/codex-fast-mode-static.test.mjs +16 -11
  197. package/tests/codex-speed-mode-browser-state.test.mjs +6 -3
  198. package/tests/codex-usage-auth.test.mjs +168 -9
  199. package/tests/codex-usage-http.test.mjs +124 -0
  200. package/tests/codex-usage-source.test.mjs +146 -0
  201. package/tests/component-update-api-static.test.mjs +2 -2
  202. package/tests/composer-action-grid-reorder-static.test.mjs +3 -3
  203. package/tests/control-deck-component-updates-static.test.mjs +9 -4
  204. package/tests/control-visibility-static.test.mjs +3 -3
  205. package/tests/controls-layout-static.test.mjs +5 -5
  206. package/tests/conversation-overview-adapter.test.mjs +100 -0
  207. package/tests/document-artifact-static.test.mjs +2 -1
  208. package/tests/draft-conversations.test.mjs +205 -0
  209. package/tests/empty-startup-launcher.test.mjs +197 -0
  210. package/tests/events-tree-context-menu-static.test.mjs +22 -18
  211. package/tests/fake-pi-session-ownership.test.mjs +302 -0
  212. package/tests/fast-mode-client-static.test.mjs +1 -1
  213. package/tests/feature-decision-output-popup-static.test.mjs +2 -2
  214. package/tests/feature-system-prompt-optional-feature-static.test.mjs +1 -1
  215. package/tests/file-viewer-image-static.test.mjs +15 -11
  216. package/tests/file-viewer-search-static.test.mjs +5 -5
  217. package/tests/fixtures/fake-codex-app-server.mjs +61 -0
  218. package/tests/fixtures/fake-pi.mjs +41 -9
  219. package/tests/footer-provider-usage-visual-static.test.mjs +7 -6
  220. package/tests/foreground-transcript-catch-up-static.test.mjs +7 -4
  221. package/tests/git-footer-context-menu-static.test.mjs +1 -1
  222. package/tests/git-panel-file-preview-static.test.mjs +41 -48
  223. package/tests/git-panel-live-updates-static.test.mjs +2 -1
  224. package/tests/git-workflow-dispatch.test.mjs +66 -0
  225. package/tests/git-workflow-preferences.test.mjs +9 -1
  226. package/tests/guided-git-activation-static.test.mjs +14 -11
  227. package/tests/guided-git-fallback-ui-static.test.mjs +8 -5
  228. package/tests/guided-git-message-reliability-static.test.mjs +10 -6
  229. package/tests/guided-git-publication-backend-static.test.mjs +16 -11
  230. package/tests/http-endpoints-harness.test.mjs +29 -9
  231. package/tests/interaction-state-stability-static.test.mjs +4 -3
  232. package/tests/intercom-conversation-viewer-static.test.mjs +29 -17
  233. package/tests/intercom-tag-layout-static.test.mjs +13 -12
  234. package/tests/intercom-tag-overflow-layout.test.mjs +11 -10
  235. package/tests/main-output-loading-static.test.mjs +4 -4
  236. package/tests/middle-button-drag-scroll-static.test.mjs +3 -3
  237. package/tests/mobile-compact-layout.test.mjs +2 -2
  238. package/tests/mobile-continuity-tablet-static.test.mjs +3 -3
  239. package/tests/mobile-foundation-static.test.mjs +10 -7
  240. package/tests/mobile-phone-experience-static.test.mjs +3 -2
  241. package/tests/mobile-static.test.mjs +173 -135
  242. package/tests/model-catalog-order.test.mjs +103 -0
  243. package/tests/native-parity.test.mjs +6 -4
  244. package/tests/native-session-choice-owner.test.mjs +102 -0
  245. package/tests/native-update-lifecycle.test.mjs +10 -5
  246. package/tests/no-project-http-harness.test.mjs +328 -0
  247. package/tests/no-project-navigation.test.mjs +54 -0
  248. package/tests/no-project-workspaces.test.mjs +77 -0
  249. package/tests/open-issue-wizard-static.test.mjs +1 -1
  250. package/tests/optional-feature-migration-frontend.test.mjs +4 -4
  251. package/tests/optional-feature-prompt-impact-static.test.mjs +3 -3
  252. package/tests/package-updates.test.mjs +630 -0
  253. package/tests/persistent-ui-layout-static.test.mjs +3 -3
  254. package/tests/platform-event-stream.test.mjs +253 -0
  255. package/tests/project-file-viewer-controller.test.mjs +652 -0
  256. package/tests/project-git-tools-adapter.test.mjs +103 -0
  257. package/tests/project-git-tools-controller.test.mjs +577 -0
  258. package/tests/project-runners-controller.test.mjs +453 -0
  259. package/tests/prompt-input-vertical-scroll-static.test.mjs +3 -3
  260. package/tests/prompt-routing-input-clear-static.test.mjs +2 -2
  261. package/tests/questionnaire-dialog.test.mjs +6 -6
  262. package/tests/queue-edit-reorder-static.test.mjs +48 -51
  263. package/tests/rpc-supervisor-host.test.mjs +4 -1
  264. package/tests/safety-guard-auto-review-static.test.mjs +1 -1
  265. package/tests/sampling-native-controls-user-flow.test.mjs +7 -1
  266. package/tests/server-app-runners.test.mjs +536 -0
  267. package/tests/server-codex-fast-mode.test.mjs +346 -0
  268. package/tests/server-conversation-mode.test.mjs +386 -0
  269. package/tests/server-conversation-voice.test.mjs +426 -0
  270. package/tests/server-extension-ui-requests.test.mjs +357 -0
  271. package/tests/server-git-generation.test.mjs +558 -0
  272. package/tests/server-git-mutations.test.mjs +729 -0
  273. package/tests/server-git-reads.test.mjs +381 -0
  274. package/tests/server-git-worktree-sessions.test.mjs +502 -0
  275. package/tests/server-helper-requests.test.mjs +364 -0
  276. package/tests/server-rpc-transports.test.mjs +553 -0
  277. package/tests/server-settings-store.test.mjs +132 -0
  278. package/tests/server-shell-rollout.test.mjs +478 -0
  279. package/tests/server-sse-delivery.test.mjs +410 -0
  280. package/tests/server-workspace-files.test.mjs +546 -0
  281. package/tests/session-attention-scheduler.test.mjs +514 -0
  282. package/tests/session-composer-store.test.mjs +153 -0
  283. package/tests/session-context.test.mjs +134 -0
  284. package/tests/session-extension-requests.test.mjs +193 -0
  285. package/tests/session-ownership-adapter.test.mjs +130 -0
  286. package/tests/session-sampling-ui-static.test.mjs +10 -4
  287. package/tests/session-send-lifetime.test.mjs +140 -0
  288. package/tests/session-shelf-state.test.mjs +348 -0
  289. package/tests/session-shelves-adapter.test.mjs +79 -0
  290. package/tests/session-summary-lifetime.test.mjs +54 -0
  291. package/tests/settings-resource-controller.test.mjs +548 -0
  292. package/tests/shell-action-adapter.test.mjs +169 -0
  293. package/tests/shell-actions.test.mjs +182 -0
  294. package/tests/shell-navigation.test.mjs +348 -0
  295. package/tests/shell-preferences.test.mjs +367 -0
  296. package/tests/side-panel-section-height-removal-static.test.mjs +3 -3
  297. package/tests/stream-output-isolation-static.test.mjs +1 -1
  298. package/tests/subagent-gate-visibility.test.mjs +1 -1
  299. package/tests/subagent-launch-slot-state.test.mjs +2 -2
  300. package/tests/subagent-launch-slots-static.test.mjs +1 -1
  301. package/tests/subagent-observability-static.test.mjs +2 -2
  302. package/tests/subagent-reliability-integration.test.mjs +13 -30
  303. package/tests/syntax-highlighting-static.test.mjs +3 -3
  304. package/tests/tab-close-continuity-static.test.mjs +1 -1
  305. package/tests/tab-metadata-ordering.test.mjs +99 -0
  306. package/tests/terminal-cwd-grouping-static.test.mjs +2 -2
  307. package/tests/terminal-tab-prompt-tooltip-static.test.mjs +2 -0
  308. package/tests/terminal-tab-workspace-static.test.mjs +5 -4
  309. package/tests/terminal-tabs-resize-static.test.mjs +1 -1
  310. package/tests/theme-contract.test.mjs +10 -3
  311. package/tests/theme-customizer-static.test.mjs +1 -1
  312. package/tests/thread-display-title.test.mjs +44 -0
  313. package/tests/update-api-harness.test.mjs +15 -14
  314. package/tests/update-tab-restore-harness.test.mjs +3 -0
  315. package/tests/webui-settings-locking.test.mjs +2 -2
  316. package/tests/windows-drive-cwd-picker-static.test.mjs +7 -9
  317. package/tests/workspace-choices.test.mjs +114 -0
  318. package/tests/workspace-save-load-static.test.mjs +7 -4
@@ -0,0 +1,546 @@
1
+ import assert from "node:assert/strict";
2
+ import { chmod, lstat, mkdir, mkdtemp, readFile, readdir, realpath, rm, stat, symlink, utimes, writeFile } from "node:fs/promises";
3
+ import { tmpdir } from "node:os";
4
+ import path from "node:path";
5
+ import { test } from "node:test";
6
+ import { setTimeout as delay } from "node:timers/promises";
7
+ import { createWorkspaceFilesService, FILE_VIEWER_BODY_LIMIT_BYTES } from "../lib/server/workspace-files.mjs";
8
+
9
+ const MAX_BYTES = 2 * 1024 * 1024;
10
+
11
+ async function fixture(t) {
12
+ const temporary = await mkdtemp(path.join(tmpdir(), "pi-webui-w6-files-"));
13
+ t.after(() => rm(temporary, { recursive: true, force: true }));
14
+ const base = await realpath(temporary);
15
+ const root = path.join(base, "workspace");
16
+ const outside = path.join(base, "outside");
17
+ await Promise.all([mkdir(root), mkdir(outside)]);
18
+ const service = (overrides = {}) => createWorkspaceFilesService({
19
+ defaultCwd: root,
20
+ makeHttpError: (statusCode, message) => Object.assign(new Error(message), { statusCode }),
21
+ displayPath: (value) => `display:${value}`,
22
+ formatBytes: (value) => `${value} bytes`,
23
+ sanitizeError: (error) => `sanitized:${error.code || error.message}`,
24
+ runCommand: async () => { throw new Error("Unexpected command execution"); },
25
+ isLikelyBinaryBuffer: (buffer) => Buffer.isBuffer(buffer) && buffer.includes(0),
26
+ getGitRoot: async () => root,
27
+ readWorkspaceGitStatusIndex: async () => null,
28
+ readWorkspaceGitIgnoredPaths: async () => null,
29
+ withFileTreeGitStatus: (entries) => entries,
30
+ withFileTreeGitIgnored: (entries) => entries,
31
+ fileTreeGitStatusPayload: () => null,
32
+ ...overrides,
33
+ });
34
+ return { base, root, outside, tab: { cwd: root }, service };
35
+ }
36
+
37
+ async function expectError(promise, statusCode, message) {
38
+ await assert.rejects(promise, (error) => {
39
+ assert.equal(error.statusCode, statusCode);
40
+ assert.equal(error.message, message);
41
+ return true;
42
+ });
43
+ }
44
+
45
+ async function link(t, target, destination, type = "file") {
46
+ try {
47
+ await symlink(target, destination, type === "dir" && process.platform === "win32" ? "junction" : type);
48
+ return true;
49
+ } catch (error) {
50
+ if (!["EPERM", "EACCES", "EINVAL", "ENOTSUP"].includes(error.code)) throw error;
51
+ t.diagnostic(`Symlink checks skipped: ${error.code}`);
52
+ return false;
53
+ }
54
+ }
55
+
56
+ test("factory exports only the existing service operations and HTTP body limit", async (t) => {
57
+ const { service } = await fixture(t);
58
+ assert.deepEqual(Object.keys(service()), [
59
+ "getFileTreeData", "getFileSearchData", "getFileContentData", "getAurReviewReportContentData",
60
+ "saveFileContentData", "deleteFileSystemEntryData", "createFileSystemEntryData",
61
+ "moveFileSystemEntryData", "openPathInDefaultEditor",
62
+ ]);
63
+ assert.equal(FILE_VIEWER_BODY_LIMIT_BYTES, MAX_BYTES + 64 * 1024);
64
+ });
65
+
66
+ test("tree sorts directories before files, reports metadata, and passes exact Git boundary values", async (t) => {
67
+ const { root, tab, service } = await fixture(t);
68
+ await Promise.all([mkdir(path.join(root, "z-dir")), writeFile(path.join(root, "b.txt"), "b"), writeFile(path.join(root, "a.md"), "# A")]);
69
+ const gitStatus = { root, entries: new Map() };
70
+ const gitIgnored = { root, paths: new Set(["b.txt"]) };
71
+ const payload = { root, entries: [{ path: "a.md", changed: true }] };
72
+ const calls = [];
73
+ let listedEntries;
74
+ let decoratedEntries;
75
+ const files = service({
76
+ readWorkspaceGitStatusIndex: async (cwd) => { assert.equal(cwd, root); calls.push("status"); return gitStatus; },
77
+ readWorkspaceGitIgnoredPaths: async (cwd, entries, gitRoot) => {
78
+ assert.equal(cwd, root); assert.equal(gitRoot, root); listedEntries = entries; calls.push("ignored"); return gitIgnored;
79
+ },
80
+ withFileTreeGitStatus: (entries, cwd, status) => {
81
+ assert.equal(entries, listedEntries); assert.equal(cwd, root); assert.equal(status, gitStatus);
82
+ calls.push("decorate-status"); decoratedEntries = entries.map((entry) => ({ ...entry, gitStatus: { changed: true } })); return decoratedEntries;
83
+ },
84
+ withFileTreeGitIgnored: (entries, cwd, ignored) => {
85
+ assert.equal(entries, decoratedEntries); assert.equal(cwd, root); assert.equal(ignored, gitIgnored);
86
+ calls.push("decorate-ignored"); return entries.map((entry) => entry.path === "b.txt" ? { ...entry, gitIgnored: true } : entry);
87
+ },
88
+ fileTreeGitStatusPayload: (cwd, status) => { assert.equal(cwd, root); assert.equal(status, gitStatus); calls.push("payload"); return payload; },
89
+ });
90
+ const result = await files.getFileTreeData(tab);
91
+ assert.deepEqual(Object.keys(result), ["root", "displayRoot", "path", "displayPath", "entries", "gitStatus", "truncated", "total"]);
92
+ assert.equal(result.root, root);
93
+ assert.equal(result.displayRoot, `display:${root}`);
94
+ assert.equal(result.displayPath, `display:${root}`);
95
+ assert.equal(result.path, "");
96
+ assert.deepEqual(result.entries.map(({ name, type }) => [name, type]), [["z-dir", "directory"], ["a.md", "file"], ["b.txt", "file"]]);
97
+ assert.deepEqual(result.entries[1], {
98
+ name: "a.md", path: "a.md", type: "file", directory: false, file: true, symlink: false, outsideRoot: false,
99
+ size: 3, mtimeMs: (await stat(path.join(root, "a.md"))).mtimeMs, extension: ".md", canOpenInWebui: true, gitStatus: { changed: true },
100
+ });
101
+ assert.equal(result.entries[2].gitIgnored, true);
102
+ assert.equal(result.gitStatus, payload);
103
+ assert.equal(result.truncated, false);
104
+ assert.equal(result.total, 3);
105
+ assert.deepEqual(calls, ["status", "ignored", "decorate-status", "decorate-ignored", "payload"]);
106
+ await expectError(files.getFileTreeData(tab, "a.md"), 400, "Path is not a directory");
107
+ assert.equal((await files.getFileTreeData(undefined, "z-dir")).path, "z-dir");
108
+ });
109
+
110
+ test("tree caps listings at 1200 while reporting the uncapped total", async (t) => {
111
+ const { root, tab, service } = await fixture(t);
112
+ for (let start = 0; start < 1201; start += 50) {
113
+ await Promise.all(Array.from({ length: Math.min(50, 1201 - start) }, (_, index) => writeFile(path.join(root, `file-${String(start + index).padStart(4, "0")}`), "")));
114
+ }
115
+ const result = await service().getFileTreeData(tab);
116
+ assert.equal(result.entries.length, 1200);
117
+ assert.equal(result.total, 1201);
118
+ assert.equal(result.truncated, true);
119
+ assert.equal(result.entries[0].path, "file-0000");
120
+ assert.equal(result.entries.at(-1).path, "file-1199");
121
+ });
122
+
123
+ test("workspace resolution enforces lexical and canonical containment while listing outside and broken links", async (t) => {
124
+ const { base, root, outside, tab, service } = await fixture(t);
125
+ const files = service();
126
+ await writeFile(path.join(root, "inside.txt"), "inside");
127
+ await writeFile(path.join(outside, "secret.txt"), "outside");
128
+ await expectError(files.getFileContentData(tab, "inside\0.txt"), 400, "Path cannot contain null bytes");
129
+ for (const requested of ["../outside/secret.txt", path.join(outside, "secret.txt")]) {
130
+ await expectError(files.getFileContentData(tab, requested), 403, "Path must stay inside the active tab working directory");
131
+ }
132
+ await expectError(files.getFileContentData(tab, "missing"), 404, `Path not found: display:${path.join(root, "missing")}`);
133
+ if (!await link(t, path.join(root, "inside.txt"), path.join(root, "inside-link"))) return;
134
+ await symlink(path.join(outside, "secret.txt"), path.join(root, "outside-link"));
135
+ await symlink(path.join(root, "missing"), path.join(root, "broken-link"));
136
+ await symlink(outside, path.join(root, "outside-dir"), process.platform === "win32" ? "junction" : "dir");
137
+ assert.equal((await files.getFileContentData(tab, " inside-link ")).content, "inside");
138
+ await expectError(files.getFileContentData(tab, "outside-link"), 403, "Resolved path escapes the active tab working directory");
139
+ await expectError(files.getFileTreeData(tab, "outside-dir"), 403, "Resolved path escapes the active tab working directory");
140
+ const entries = (await files.getFileTreeData(tab)).entries;
141
+ for (const name of ["outside-link", "outside-dir"]) {
142
+ const entry = entries.find((item) => item.name === name);
143
+ assert.equal(entry.type, "other"); assert.equal(entry.outsideRoot, true); assert.equal(entry.symlink, true); assert.equal(entry.canOpenInWebui, false);
144
+ }
145
+ const broken = entries.find((entry) => entry.name === "broken-link");
146
+ assert.equal(broken.type, "error"); assert.equal(broken.error, "sanitized:ENOENT"); assert.equal(broken.canOpenInWebui, false);
147
+ const alias = path.join(base, "workspace-alias");
148
+ await symlink(root, alias, process.platform === "win32" ? "junction" : "dir");
149
+ const aliased = await files.getFileContentData({ cwd: alias }, path.join(alias, "inside.txt"));
150
+ assert.equal(aliased.root, alias); assert.equal(aliased.path, "inside.txt"); assert.equal(aliased.content, "inside");
151
+ });
152
+
153
+ test("search normalizes queries, skips empty scans, and preserves Git decoration order", async (t) => {
154
+ const { root, tab, service } = await fixture(t);
155
+ await mkdir(path.join(root, "Some Folder"));
156
+ await writeFile(path.join(root, "Some Folder", "Needle.MD"), "# match");
157
+ const calls = [];
158
+ const files = service({
159
+ readWorkspaceGitStatusIndex: async (cwd) => { assert.equal(cwd, root); calls.push("status"); return null; },
160
+ readWorkspaceGitIgnoredPaths: async (cwd, entries, gitRoot) => {
161
+ assert.equal(cwd, root); assert.equal(gitRoot, undefined); assert.ok(entries.length); calls.push("ignored"); return null;
162
+ },
163
+ withFileTreeGitStatus: (entries, cwd, status) => { assert.equal(cwd, root); assert.equal(status, null); calls.push("decorate-status"); return entries; },
164
+ withFileTreeGitIgnored: (entries, cwd, ignored) => { assert.equal(cwd, root); assert.equal(ignored, null); calls.push("decorate-ignored"); return entries; },
165
+ fileTreeGitStatusPayload: (cwd, status) => { assert.equal(cwd, root); assert.equal(status, null); calls.push("payload"); return null; },
166
+ });
167
+ assert.deepEqual(await files.getFileSearchData(undefined), {
168
+ root, displayRoot: `display:${root}`, query: "", entries: [], truncated: false, total: 0, scanned: 0, maxDepth: 8,
169
+ });
170
+ assert.deepEqual(calls, []);
171
+ const result = await files.getFileSearchData(tab, " sOME\n FOLDER ");
172
+ assert.equal(result.query, "sOME FOLDER");
173
+ assert.deepEqual(result.entries.map(({ path: entryPath, depth }) => [entryPath, depth]), [["Some Folder", 1], ["Some Folder/Needle.MD", 2]]);
174
+ assert.equal(result.scanned, 2); assert.equal(result.total, 2); assert.equal(result.truncated, false);
175
+ assert.deepEqual(result.excludedDirs, [".git", "node_modules"]);
176
+ assert.deepEqual(calls, ["status", "ignored", "decorate-status", "decorate-ignored", "payload"]);
177
+ await expectError(files.getFileSearchData(tab, "x\0"), 400, "Search query cannot contain null bytes");
178
+ await expectError(files.getFileSearchData(tab, "x".repeat(161)), 400, "Search query is too long");
179
+ const missing = path.join(root, "absent");
180
+ assert.equal((await files.getFileSearchData({ cwd: missing }, " ")).root, missing);
181
+ await writeFile(path.join(root, "not-directory"), "file");
182
+ await expectError(files.getFileSearchData({ cwd: path.join(root, "not-directory") }, "file"), 400, "Workspace root is not a directory");
183
+ });
184
+
185
+ test("search respects depth, excluded folders, result and scan caps", async (t) => {
186
+ const { root, tab, service } = await fixture(t);
187
+ const files = service();
188
+ const depth7 = path.join(root, ...Array.from({ length: 7 }, (_, index) => `d${index}`));
189
+ await mkdir(path.join(depth7, "depth8-folder"), { recursive: true });
190
+ await writeFile(path.join(depth7, "depth8-file"), "visible");
191
+ await writeFile(path.join(depth7, "depth8-folder", "depth9-file"), "hidden");
192
+ for (const name of [".git", "node_modules"]) {
193
+ await mkdir(path.join(root, name));
194
+ await writeFile(path.join(root, name, "depth-hidden"), "hidden");
195
+ assert.equal((await files.getFileSearchData(tab, name)).entries[0].type, "directory");
196
+ }
197
+ const depth = await files.getFileSearchData(tab, "depth");
198
+ assert.deepEqual(depth.entries.map((entry) => entry.name), ["depth8-folder", "depth8-file"]);
199
+ assert.ok(depth.entries.every((entry) => entry.depth === 8));
200
+ assert.equal(depth.maxDepth, 8);
201
+ await mkdir(path.join(root, "cap"));
202
+ for (let start = 0; start < 201; start += 50) {
203
+ await Promise.all(Array.from({ length: Math.min(50, 201 - start) }, (_, index) => writeFile(path.join(root, "cap", `match-${String(start + index).padStart(3, "0")}`), "")));
204
+ }
205
+ const capped = await files.getFileSearchData(tab, "match-");
206
+ assert.equal(capped.total, 200); assert.equal(capped.entries.length, 200); assert.equal(capped.truncated, true);
207
+ const scanRoot = path.join(root, "scan");
208
+ await mkdir(scanRoot);
209
+ for (let start = 0; start < 12001; start += 100) {
210
+ await Promise.all(Array.from({ length: Math.min(100, 12001 - start) }, (_, index) => writeFile(path.join(scanRoot, `entry-${String(start + index).padStart(5, "0")}`), "")));
211
+ }
212
+ const scanned = await files.getFileSearchData({ cwd: scanRoot }, "never-matches");
213
+ assert.equal(scanned.scanned, 12000); assert.equal(scanned.total, 0); assert.equal(scanned.truncated, true);
214
+ });
215
+
216
+ test("search visits a canonical directory only once and does not traverse outside symlinks", async (t) => {
217
+ const { root, outside, tab, service } = await fixture(t);
218
+ await mkdir(path.join(root, "actual"));
219
+ await writeFile(path.join(root, "actual", "needle.txt"), "inside");
220
+ await writeFile(path.join(outside, "needle-secret"), "outside");
221
+ if (!await link(t, root, path.join(root, "loop"), "dir")) return;
222
+ await symlink(path.join(root, "actual"), path.join(root, "alias"), process.platform === "win32" ? "junction" : "dir");
223
+ await symlink(outside, path.join(root, "needle-outside"), process.platform === "win32" ? "junction" : "dir");
224
+ await symlink(path.join(root, "missing"), path.join(root, "needle-broken"));
225
+ const result = await service().getFileSearchData(tab, "needle");
226
+ assert.deepEqual(result.entries.map((entry) => entry.path), ["needle-broken", "needle-outside", "actual/needle.txt"]);
227
+ assert.equal(result.entries[0].type, "error"); assert.equal(result.entries[0].error, "sanitized:ENOENT");
228
+ assert.equal(result.entries[1].outsideRoot, true); assert.equal(result.entries[1].type, "other");
229
+ assert.equal(result.scanned, 6); assert.equal(result.truncated, false);
230
+ });
231
+
232
+ test("content preserves text/image payloads, language metadata and binary/size refusal", async (t) => {
233
+ const { root, tab, service } = await fixture(t);
234
+ const files = service();
235
+ const content = "# Héllo\n";
236
+ await writeFile(path.join(root, "notes.MARKDOWN"), content);
237
+ const info = await stat(path.join(root, "notes.MARKDOWN"));
238
+ assert.deepEqual(await files.getFileContentData(tab, "notes.MARKDOWN"), {
239
+ root, path: "notes.MARKDOWN", name: "notes.MARKDOWN", size: Buffer.byteLength(content), mtimeMs: info.mtimeMs,
240
+ extension: ".markdown", kind: "text", content, language: "markdown",
241
+ });
242
+ await writeFile(path.join(root, "empty.txt"), "");
243
+ assert.equal((await files.getFileContentData(undefined, "empty.txt")).content, "");
244
+ const image = Buffer.from([0, 255, 1, 2]);
245
+ for (const [extension, mimeType] of [["png", "image/png"], ["jpg", "image/jpeg"], ["jpeg", "image/jpeg"], ["gif", "image/gif"], ["webp", "image/webp"], ["avif", "image/avif"]]) {
246
+ const name = `image.${extension.toUpperCase()}`;
247
+ await writeFile(path.join(root, name), image);
248
+ const result = await files.getFileContentData(tab, name);
249
+ assert.deepEqual(Object.keys(result), ["root", "path", "name", "size", "mtimeMs", "extension", "kind", "mimeType", "data"]);
250
+ assert.equal(result.kind, "image"); assert.equal(result.mimeType, mimeType); assert.equal(result.data, image.toString("base64"));
251
+ }
252
+ await writeFile(path.join(root, "binary.svg"), image);
253
+ await expectError(files.getFileContentData(tab, "binary.svg"), 415, "File appears to be binary; only text files and supported raster images can be opened in WebUI");
254
+ await writeFile(path.join(root, "exact.txt"), Buffer.alloc(MAX_BYTES, 0x61));
255
+ assert.equal((await files.getFileContentData(tab, "exact.txt")).size, MAX_BYTES);
256
+ await writeFile(path.join(root, "large.png"), Buffer.alloc(MAX_BYTES + 1, 0x61));
257
+ await expectError(files.getFileContentData(tab, "large.png"), 413, `File is too large to open in WebUI (limit ${MAX_BYTES} bytes)`);
258
+ await expectError(files.getFileContentData(tab), 400, "Path is not a regular file");
259
+ });
260
+
261
+ test("save replaces existing text through a sibling rename, preserves mode and enforces 5ms conflicts", async (t) => {
262
+ const { root, tab, service } = await fixture(t);
263
+ const files = service();
264
+ const target = path.join(root, "note.md");
265
+ await writeFile(target, "old");
266
+ await chmod(target, 0o640);
267
+ await utimes(target, 1_700_000_000, 1_700_000_000);
268
+ const before = await stat(target);
269
+ await expectError(files.saveFileContentData(tab, { path: "note.md", content: "lost", mtimeMs: before.mtimeMs - 6 }), 409, "File changed on disk after it was opened. Reopen it before saving.");
270
+ assert.equal(await readFile(target, "utf8"), "old");
271
+ const result = await files.saveFileContentData(tab, { filePath: "note.md", content: "new λ\n", mtimeMs: before.mtimeMs - 5 });
272
+ const after = await stat(target);
273
+ assert.deepEqual(result, { path: "note.md", name: "note.md", size: Buffer.byteLength("new λ\n"), mtimeMs: after.mtimeMs, extension: ".md", language: "markdown" });
274
+ assert.equal(await readFile(target, "utf8"), "new λ\n");
275
+ if (process.platform !== "win32") {
276
+ assert.equal(after.mode & 0o777, 0o640);
277
+ assert.notEqual(after.ino, before.ino, "saving replaces the inode rather than truncating the original file");
278
+ }
279
+ assert.deepEqual(await readdir(root), ["note.md"]);
280
+ await files.saveFileContentData(tab, { path: "note.md", content: "no mtime required", mtimeMs: "not-numeric" });
281
+ assert.equal(await readFile(target, "utf8"), "no mtime required");
282
+ await expectError(files.saveFileContentData(tab), 400, "File content must be a string");
283
+ await expectError(files.saveFileContentData(tab, { path: "note.md", content: "bad\0" }), 400, "File content cannot contain null bytes");
284
+ await expectError(files.saveFileContentData(tab, { path: "note.md", content: "λ".repeat(MAX_BYTES / 2 + 1) }), 413, `File is too large to save in WebUI (limit ${MAX_BYTES} bytes)`);
285
+ await expectError(files.saveFileContentData(tab, { path: "missing", content: "new" }), 404, `Path not found: display:${path.join(root, "missing")}`);
286
+ await expectError(files.saveFileContentData(tab, { content: "new" }), 400, "Path is not a regular file");
287
+ await writeFile(path.join(root, "binary.png"), Buffer.from([1, 0, 2]));
288
+ await expectError(files.saveFileContentData(tab, { path: "binary.png", content: "replacement" }), 415, "File appears to be binary; only text files and supported raster images can be opened in WebUI");
289
+ await writeFile(path.join(root, "large"), Buffer.alloc(MAX_BYTES + 1, 0x61));
290
+ await expectError(files.saveFileContentData(tab, { path: "large", content: "replacement" }), 413, `File is too large to save in WebUI (limit ${MAX_BYTES} bytes)`);
291
+ });
292
+
293
+ test("create is exclusive, requires existing contained parents, and returns existing payloads", async (t) => {
294
+ const { root, tab, service } = await fixture(t);
295
+ const files = service();
296
+ const folder = await files.createFileSystemEntryData(tab, { path: "folder", type: "directory" });
297
+ assert.equal(folder.type, "directory"); assert.equal(folder.created, true); assert.equal(folder.parentPath, "");
298
+ assert.deepEqual(Object.keys(folder), ["path", "name", "type", "parentPath", "created", "size", "mtimeMs"]);
299
+ const created = await files.createFileSystemEntryData(tab, { filePath: "folder/new.txt", type: "unknown" });
300
+ const info = await stat(path.join(root, "folder", "new.txt"));
301
+ assert.deepEqual(created, { path: "folder/new.txt", name: "new.txt", type: "file", parentPath: "folder", created: true, size: 0, mtimeMs: info.mtimeMs });
302
+ await expectError(files.createFileSystemEntryData(tab, { path: "folder/new.txt" }), 409, "Already exists: folder/new.txt");
303
+ await expectError(files.createFileSystemEntryData(tab), 400, "A name is required");
304
+ await expectError(files.createFileSystemEntryData(tab, { path: "missing/new" }), 404, "Parent folder not found: missing");
305
+ await expectError(files.createFileSystemEntryData(tab, { path: "folder/new.txt/child" }), 404, "Parent folder not found: folder/new.txt");
306
+ await expectError(files.createFileSystemEntryData(tab, { path: "../escape" }), 403, "Path must stay inside the active tab working directory");
307
+ if (await link(t, path.join(root, "missing-target"), path.join(root, "dangling"))) {
308
+ await assert.rejects(files.createFileSystemEntryData(tab, { path: "dangling" }), { code: "EEXIST" });
309
+ assert.equal((await lstat(path.join(root, "dangling"))).isSymbolicLink(), true);
310
+ }
311
+ });
312
+
313
+ test("move preserves aliases and directory-target semantics, refusing overwrite, root, descendants and escapes", async (t) => {
314
+ const { root, outside, tab, service } = await fixture(t);
315
+ const files = service();
316
+ await writeFile(path.join(root, "source.txt"), "move me");
317
+ await mkdir(path.join(root, "dest"));
318
+ await expectError(files.moveFileSystemEntryData(tab), 409, "Moving files or directories requires confirmed: true");
319
+ await expectError(files.moveFileSystemEntryData(tab, { path: "source.txt", toPath: "dest", confirmed: "true" }), 409, "Moving files or directories requires confirmed: true");
320
+ const moved = await files.moveFileSystemEntryData(tab, { sourcePath: "source.txt", destination: "dest", confirmed: true });
321
+ const info = await stat(path.join(root, "dest", "source.txt"));
322
+ assert.deepEqual(moved, { path: "source.txt", destination: "dest/source.txt", name: "source.txt", type: "file", parentPath: "", destinationParentPath: "dest", moved: true, size: info.size, mtimeMs: info.mtimeMs });
323
+ assert.equal(await readFile(path.join(root, "dest", "source.txt"), "utf8"), "move me");
324
+ await assert.rejects(stat(path.join(root, "source.txt")), { code: "ENOENT" });
325
+ await mkdir(path.join(root, "folder", "child"), { recursive: true });
326
+ await writeFile(path.join(root, "folder", "nested.txt"), "nested");
327
+ const movedDir = await files.moveFileSystemEntryData(tab, { filePath: "folder", destinationPath: "renamed", confirmed: true });
328
+ assert.equal(movedDir.type, "directory"); assert.equal(movedDir.destination, "renamed");
329
+ assert.equal(await readFile(path.join(root, "renamed", "nested.txt"), "utf8"), "nested");
330
+ const move = (toPath, entryPath = "dest/source.txt") => files.moveFileSystemEntryData(tab, { path: entryPath, toPath, confirmed: true });
331
+ await expectError(move("renamed/nested.txt"), 409, "Destination already exists: renamed/nested.txt");
332
+ await expectError(move("dest/source.txt"), 400, "Source and destination are the same path");
333
+ await expectError(move("dest"), 400, "Source and destination are the same path");
334
+ await expectError(move(""), 400, "Destination path is required");
335
+ await expectError(move("bad\0"), 400, "Destination path cannot contain null bytes");
336
+ await expectError(move(path.join(outside, "file")), 403, "Destination path must stay inside the active tab working directory");
337
+ await expectError(move("missing/new"), 404, `Destination parent not found: display:${path.join(root, "missing")}`);
338
+ await expectError(move("renamed/child/new", "renamed"), 400, "A directory cannot be moved into itself or one of its descendants");
339
+ await expectError(move("dest", ""), 400, "Workspace root cannot be moved");
340
+ await files.moveFileSystemEntryData(tab, { path: "dest/source.txt", toPath: path.join(root, "absolute.txt"), confirmed: true });
341
+ assert.equal(await readFile(path.join(root, "absolute.txt"), "utf8"), "move me");
342
+ });
343
+
344
+ test("delete requires boolean confirmation, refuses roots, and removes files and nested directories", async (t) => {
345
+ const { root, tab, service } = await fixture(t);
346
+ const files = service();
347
+ await mkdir(path.join(root, "folder"));
348
+ await writeFile(path.join(root, "folder", "file.txt"), "delete me");
349
+ await expectError(files.deleteFileSystemEntryData(tab), 409, "Deleting files or directories requires confirmed: true");
350
+ await expectError(files.deleteFileSystemEntryData(tab, { path: "folder", confirmed: 1 }), 409, "Deleting files or directories requires confirmed: true");
351
+ await expectError(files.deleteFileSystemEntryData(tab, { path: ".", confirmed: true }), 400, "Workspace root cannot be deleted");
352
+ assert.deepEqual(await files.deleteFileSystemEntryData(tab, { filePath: "folder/file.txt", confirmed: true }), {
353
+ path: "folder/file.txt", name: "file.txt", type: "file", parentPath: "folder", deleted: true,
354
+ });
355
+ await writeFile(path.join(root, "folder", "nested"), "recursive");
356
+ assert.deepEqual(await files.deleteFileSystemEntryData(tab, { path: "folder", confirmed: true }), {
357
+ path: "folder", name: "folder", type: "directory", parentPath: "", deleted: true,
358
+ });
359
+ await assert.rejects(stat(path.join(root, "folder")), { code: "ENOENT" });
360
+ });
361
+
362
+ test("mutations reject external symlinks and preserve the ordinary in-root alias behavior", async (t) => {
363
+ const { root, outside, tab, service } = await fixture(t);
364
+ const files = service();
365
+ const outsideFile = path.join(outside, "secret.txt");
366
+ await writeFile(outsideFile, "outside");
367
+ await writeFile(path.join(root, "source.txt"), "source");
368
+ if (!await link(t, outside, path.join(root, "escape"), "dir")) return;
369
+ await symlink(outsideFile, path.join(root, "escape-file"));
370
+ await expectError(files.createFileSystemEntryData(tab, { path: "escape/new" }), 403, "Parent folder escapes the active tab working directory");
371
+ await expectError(files.moveFileSystemEntryData(tab, { path: "source.txt", toPath: "escape/new", confirmed: true }), 403, "Destination parent escapes the active tab working directory");
372
+ await expectError(files.moveFileSystemEntryData(tab, { path: "escape-file", toPath: "new", confirmed: true }), 403, "Resolved path escapes the active tab working directory");
373
+ await expectError(files.deleteFileSystemEntryData(tab, { path: "escape-file", confirmed: true }), 403, "Resolved path escapes the active tab working directory");
374
+ await expectError(files.saveFileContentData(tab, { path: "escape-file", content: "bad" }), 403, "Resolved path escapes the active tab working directory");
375
+ assert.equal(await readFile(outsideFile, "utf8"), "outside");
376
+ assert.deepEqual(await readdir(outside), ["secret.txt"]);
377
+ await symlink(path.join(root, "source.txt"), path.join(root, "alias.txt"));
378
+ await files.saveFileContentData(tab, { path: "alias.txt", content: "replacement" });
379
+ assert.equal((await lstat(path.join(root, "alias.txt"))).isSymbolicLink(), false);
380
+ assert.equal(await readFile(path.join(root, "source.txt"), "utf8"), "source");
381
+ await symlink(path.join(root, "source.txt"), path.join(root, "delete-alias"));
382
+ const deleted = await files.deleteFileSystemEntryData(tab, { path: "delete-alias", confirmed: true });
383
+ assert.equal(deleted.type, "file");
384
+ assert.equal(await readFile(path.join(root, "source.txt"), "utf8"), "source");
385
+ });
386
+
387
+ test("AUR reports use canonical Git roots instead of the tab subdirectory and retain their distinct payload", async (t) => {
388
+ const { base, root, tab, service } = await fixture(t);
389
+ const subdir = path.join(root, "subdir");
390
+ await mkdir(subdir); await mkdir(path.join(root, "reports"));
391
+ const content = "# Audit\n";
392
+ const target = path.join(root, "reports", "audit.md");
393
+ await writeFile(target, content);
394
+ const calls = [];
395
+ const files = service({ getGitRoot: async (cwd) => { calls.push(cwd); return root; } });
396
+ await expectError(files.getFileContentData({ cwd: subdir }, "reports/audit.md"), 404, `Path not found: display:${path.join(subdir, "reports", "audit.md")}`);
397
+ const info = await stat(target);
398
+ assert.deepEqual(await files.getAurReviewReportContentData({ cwd: subdir }, { path: " reports/audit.md ", repoRoot: root }), {
399
+ root, path: "reports/audit.md", name: "audit.md", content, size: Buffer.byteLength(content), mtimeMs: info.mtimeMs, extension: ".md", language: "markdown",
400
+ });
401
+ assert.deepEqual(calls, [subdir]);
402
+ await expectError(files.getAurReviewReportContentData(tab, { path: "reports/audit.md", repoRoot: subdir }), 403, "Report repoRoot does not match this tab's canonical Git root");
403
+ const inaccessible = service({ getGitRoot: async () => path.join(root, "missing") });
404
+ await expectError(inaccessible.getAurReviewReportContentData(tab, { path: "audit.md", repoRoot: root }), 404, "Git repository root is no longer accessible");
405
+ const failure = new Error("not a git repository");
406
+ await assert.rejects(service({ getGitRoot: async () => { throw failure; } }).getAurReviewReportContentData(tab, { path: "audit.md", repoRoot: root }), (error) => error === failure);
407
+ const alias = path.join(base, "repo-alias");
408
+ if (await link(t, root, alias, "dir")) {
409
+ const aliased = service({ getGitRoot: async () => alias });
410
+ assert.equal((await aliased.getAurReviewReportContentData(tab, { path: "reports/audit.md", repoRoot: root })).root, root);
411
+ await expectError(aliased.getAurReviewReportContentData(tab, { path: "reports/audit.md", repoRoot: alias }), 403, "Report repoRoot does not match this tab's canonical Git root");
412
+ }
413
+ });
414
+
415
+ test("AUR validates every path segment and refuses symlinks even within the canonical root", async (t) => {
416
+ const { root, tab, service } = await fixture(t);
417
+ const files = service();
418
+ for (const repoRoot of [undefined, "", 7, `${root}\0`]) {
419
+ await expectError(files.getAurReviewReportContentData(tab, { path: "audit.md", repoRoot }), 400, "repoRoot is required for an AUR review report");
420
+ }
421
+ await expectError(files.getAurReviewReportContentData(tab), 400, "repoRoot is required for an AUR review report");
422
+ for (const requested of ["", "a".repeat(1025), "bad\0path"]) {
423
+ await expectError(files.getAurReviewReportContentData(tab, { path: requested, repoRoot: root }), 400, "Report path must be a non-empty repo-root-relative path");
424
+ }
425
+ for (const requested of [path.join(root, "report.md"), "C:\\report.md", "reports\\report.md", "\\\\server\\report.md"]) {
426
+ await expectError(files.getAurReviewReportContentData(tab, { path: requested, repoRoot: root }), 400, "Report path must be a repo-root-relative path");
427
+ }
428
+ for (const requested of ["../report.md", "./report.md", "reports//report.md", "reports/../report.md", "reports/./report.md", "reports/"]) {
429
+ await expectError(files.getAurReviewReportContentData(tab, { path: requested, repoRoot: root }), 400, "Report path cannot contain traversal segments");
430
+ }
431
+ await mkdir(path.join(root, "reports"));
432
+ await writeFile(path.join(root, "reports", "audit.md"), "report");
433
+ await expectError(files.getAurReviewReportContentData(tab, { path: "missing.md", repoRoot: root }), 404, "Report path not found: missing.md");
434
+ await expectError(files.getAurReviewReportContentData(tab, { path: "reports", repoRoot: root }), 400, "Report path is not a regular file");
435
+ await expectError(files.getAurReviewReportContentData(tab, { path: "reports/audit.md/child", repoRoot: root }), 400, "Report path contains a non-directory component");
436
+ if (!await link(t, path.join(root, "reports", "audit.md"), path.join(root, "report-link"))) return;
437
+ await symlink(path.join(root, "reports"), path.join(root, "reports-link"), process.platform === "win32" ? "junction" : "dir");
438
+ for (const requested of ["report-link", "reports-link/audit.md"]) {
439
+ await expectError(files.getAurReviewReportContentData(tab, { path: requested, repoRoot: root }), 403, "Report path cannot contain symlinks");
440
+ }
441
+ assert.equal((await files.getFileContentData(tab, "report-link")).content, "report");
442
+ });
443
+
444
+ test("AUR bounded reads accept the exact limit, reject oversized/binary data, and close opened handles", async (t) => {
445
+ const { root, tab, service } = await fixture(t);
446
+ const files = service();
447
+ await writeFile(path.join(root, "exact.md"), Buffer.alloc(MAX_BYTES, 0x61));
448
+ await writeFile(path.join(root, "large.md"), Buffer.alloc(MAX_BYTES + 1, 0x61));
449
+ await writeFile(path.join(root, "binary.png"), Buffer.from([1, 0, 2]));
450
+ await writeFile(path.join(root, "empty.txt"), "");
451
+ for (let attempt = 0; attempt < 4; attempt++) {
452
+ const exact = await files.getAurReviewReportContentData(tab, { path: "exact.md", repoRoot: root });
453
+ assert.equal(exact.size, MAX_BYTES); assert.equal(exact.content.length, MAX_BYTES);
454
+ await expectError(files.getAurReviewReportContentData(tab, { path: "large.md", repoRoot: root }), 413, `Report is too large to open in WebUI (limit ${MAX_BYTES} bytes)`);
455
+ await expectError(files.getAurReviewReportContentData(tab, { path: "binary.png", repoRoot: root }), 415, "File appears to be binary; only text files and supported raster images can be opened in WebUI");
456
+ }
457
+ const empty = await files.getAurReviewReportContentData(tab, { path: "empty.txt", repoRoot: root });
458
+ assert.equal(empty.size, 0); assert.equal(empty.content, ""); assert.equal(empty.language, "text");
459
+ if (process.platform === "linux") {
460
+ const descriptors = await readdir("/proc/self/fd");
461
+ const targets = await Promise.all(descriptors.map((fd) => realpath(`/proc/self/fd/${fd}`).catch(() => "")));
462
+ assert.equal(targets.some((target) => target.startsWith(`${root}${path.sep}`)), false, "success and refusal paths must release report handles");
463
+ } else {
464
+ t.diagnostic("Open-handle observation requires Linux /proc/self/fd; read/refusal cases still ran");
465
+ }
466
+ });
467
+
468
+ async function withEnvironment(values, action) {
469
+ const previous = Object.fromEntries(Object.keys(values).map((key) => [key, process.env[key]]));
470
+ for (const [key, value] of Object.entries(values)) {
471
+ if (value === undefined) delete process.env[key];
472
+ else process.env[key] = value;
473
+ }
474
+ try { return await action(); }
475
+ finally {
476
+ for (const [key, value] of Object.entries(previous)) {
477
+ if (value === undefined) delete process.env[key];
478
+ else process.env[key] = value;
479
+ }
480
+ }
481
+ }
482
+
483
+ async function editorLog(target) {
484
+ const logPath = `${target}.editor-log`;
485
+ for (let attempt = 0; attempt < 100; attempt++) {
486
+ try { return JSON.parse(await readFile(logPath, "utf8")); }
487
+ catch (error) { if (error.code !== "ENOENT" && !(error instanceof SyntaxError)) throw error; }
488
+ await delay(20);
489
+ }
490
+ assert.fail(`Disposable editor did not record ${target}`);
491
+ }
492
+
493
+ test("default editor validates paths and spawns only a disposable explicit Node override", async (t) => {
494
+ const { base, root, tab, service } = await fixture(t);
495
+ const files = service();
496
+ const target = path.join(root, "file with spaces.txt");
497
+ await writeFile(target, "content");
498
+ const editor = path.join(base, "editor.mjs");
499
+ await writeFile(editor, 'import { writeFileSync } from "node:fs"; const target = process.argv.at(-1); writeFileSync(`${target}.editor-log`, JSON.stringify({ args: process.argv.slice(2), cwd: process.cwd() }));\n');
500
+ await withEnvironment({ PI_WEBUI_OPEN_COMMAND: editor }, async () => {
501
+ await expectError(files.openPathInDefaultEditor(tab), 400, "Path to open is required");
502
+ await expectError(files.openPathInDefaultEditor(tab, " "), 400, "Path to open is required");
503
+ await expectError(files.openPathInDefaultEditor(tab, "../outside"), 403, "Path must stay inside the active tab working directory");
504
+ const result = await files.openPathInDefaultEditor(tab, "file with spaces.txt");
505
+ assert.deepEqual(result, { path: "file with spaces.txt", command: `${process.execPath} ${editor} ${target}`, mime: undefined, desktopFile: undefined, fallbackToTextEditor: false });
506
+ assert.deepEqual(await editorLog(target), { args: [target], cwd: root });
507
+ });
508
+ });
509
+
510
+ test("Linux editor probes MIME associations and falls back to text/plain using disposable launchers", { skip: process.platform !== "linux" }, async (t) => {
511
+ const { base, root, tab, service } = await fixture(t);
512
+ const bin = path.join(base, "bin");
513
+ await mkdir(bin);
514
+ const launcher = `#!${process.execPath}\nconst { writeFileSync } = require("node:fs"); const path = require("node:path"); const target = process.argv.at(-1); writeFileSync(target + ".editor-log", JSON.stringify({ launcher: path.basename(process.argv[1]), args: process.argv.slice(2), cwd: process.cwd() }));\n`;
515
+ for (const name of ["xdg-open", "gio"]) await writeFile(path.join(bin, name), launcher, { mode: 0o755 });
516
+ await withEnvironment({ PATH: bin, PI_WEBUI_OPEN_COMMAND: undefined }, async () => {
517
+ for (const scenario of ["associated", "text-fallback", "unassociated", "query-error", "directory"]) {
518
+ const target = path.join(root, scenario);
519
+ if (scenario === "directory") await mkdir(target);
520
+ else await writeFile(target, "content");
521
+ const queries = [];
522
+ const files = service({ runCommand: async (command, args, options) => {
523
+ assert.equal(command, "xdg-mime");
524
+ assert.deepEqual(options, { cwd: root, timeoutMs: 1500, maxOutputLength: 4096 });
525
+ queries.push(args);
526
+ if (scenario === "query-error") return { exitCode: 1, stdout: "must-be-ignored" };
527
+ if (args[1] === "filetype") return { exitCode: 0, stdout: "\n application/x-fixture \nignored-line\n" };
528
+ if (args[2] === "application/x-fixture") return { exitCode: 0, stdout: scenario === "associated" ? " fixture.desktop\nignored.desktop" : "" };
529
+ assert.equal(args[2], "text/plain");
530
+ return { exitCode: 0, stdout: scenario === "text-fallback" ? " text.desktop \n" : "" };
531
+ } });
532
+ const result = await files.openPathInDefaultEditor(tab, scenario);
533
+ const fallback = scenario === "text-fallback";
534
+ const expectedLauncher = fallback ? "gio" : "xdg-open";
535
+ const args = fallback ? ["launch", "text.desktop", target] : [target];
536
+ assert.equal(result.command, [expectedLauncher, ...args].join(" "));
537
+ assert.equal(result.fallbackToTextEditor, fallback);
538
+ assert.equal(result.desktopFile, fallback ? "text.desktop" : scenario === "associated" ? "fixture.desktop" : undefined);
539
+ assert.equal(result.mime, scenario === "directory" ? undefined : scenario === "query-error" ? "" : "application/x-fixture");
540
+ assert.deepEqual(await editorLog(target), { launcher: expectedLauncher, args, cwd: root });
541
+ assert.deepEqual(queries, scenario === "directory" ? [] : scenario === "query-error" ? [["query", "filetype", target], ["query", "default", "text/plain"]] : [
542
+ ["query", "filetype", target], ["query", "default", "application/x-fixture"], ...(scenario === "associated" ? [] : [["query", "default", "text/plain"]]),
543
+ ]);
544
+ }
545
+ });
546
+ });