@firsthandjs/compiler 0.6.3 → 0.7.1

package/dist/api.d.ts

@@ -19,7 +19,7 @@ export interface TransformOptions extends FirsthandPluginOptions {
  * inside this repository and fails in the first application that puts the
  * plugin into `vite.config.ts` — which is the one place it matters.
  */
-export interface SourceMap {
+export type SourceMap = {
     version: number;
     mappings: string;
     names: string[];
@@ -27,9 +27,9 @@ export interface SourceMap {
     sourcesContent?: string[];
     sourceRoot?: string;
     file?: string;
-}
+};
 /** A compiled module, and the map back to what was written. */
-export interface Compiled {
+export type Compiled = {
     code: string;
     /**
      * A source map, when one was asked for.
@@ -40,7 +40,7 @@ export interface Compiled {
      * cannot, so the Vite plugin always asks.
      */
     map: SourceMap | null;
-}
+};
 /**
  * Compiles one module, and maps it back.
  *

package/dist/api.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"api.d.ts","sourceRoot":"","sources":["../src/api.ts"],"names":[],"mappings":"AAGA,OAAwB,EAAE,KAAK,sBAAsB,EAAE,MAAM,gBAAgB,CAAC;AAE9E,MAAM,WAAW,gBAAiB,SAAQ,sBAAsB;IAC9D,QAAQ,CAAC,EAAE,MAAM,CAAC;IAClB;;;;OAIG;IACH,UAAU,CAAC,EAAE,OAAO,CAAC;IACrB,gFAAgF;IAChF,UAAU,CAAC,EAAE,OAAO,CAAC;CACtB;AAED;;;;;;;;GAQG;AACH,MAAM,WAAW,SAAS;IACxB,OAAO,EAAE,MAAM,CAAC;IAChB,QAAQ,EAAE,MAAM,CAAC;IACjB,KAAK,EAAE,MAAM,EAAE,CAAC;IAChB,OAAO,EAAE,MAAM,EAAE,CAAC;IAKlB,cAAc,CAAC,EAAE,MAAM,EAAE,CAAC;IAC1B,UAAU,CAAC,EAAE,MAAM,CAAC;IACpB,IAAI,CAAC,EAAE,MAAM,CAAC;CACf;AAED,+DAA+D;AAC/D,MAAM,WAAW,QAAQ;IACvB,IAAI,EAAE,MAAM,CAAC;IACb;;;;;;;OAOG;IACH,GAAG,EAAE,SAAS,GAAG,IAAI,CAAC;CACvB;AAED;;;;;;;GAOG;AACH,wBAAgB,aAAa,CAAC,IAAI,EAAE,MAAM,EAAE,OAAO,GAAE,gBAAqB,GAAG,QAAQ,CAqBpF;AAED,6DAA6D;AAC7D,wBAAgB,SAAS,CAAC,IAAI,EAAE,MAAM,EAAE,OAAO,GAAE,gBAAqB,GAAG,MAAM,CAE9E"}
+{"version":3,"file":"api.d.ts","sourceRoot":"","sources":["../src/api.ts"],"names":[],"mappings":"AAGA,OAAwB,EAAE,KAAK,sBAAsB,EAAE,MAAM,gBAAgB,CAAC;AAE9E,MAAM,WAAW,gBAAiB,SAAQ,sBAAsB;IAC9D,QAAQ,CAAC,EAAE,MAAM,CAAC;IAClB;;;;OAIG;IACH,UAAU,CAAC,EAAE,OAAO,CAAC;IACrB,gFAAgF;IAChF,UAAU,CAAC,EAAE,OAAO,CAAC;CACtB;AAED;;;;;;;;GAQG;AACH,MAAM,MAAM,SAAS,GAAG;IACtB,OAAO,EAAE,MAAM,CAAC;IAChB,QAAQ,EAAE,MAAM,CAAC;IACjB,KAAK,EAAE,MAAM,EAAE,CAAC;IAChB,OAAO,EAAE,MAAM,EAAE,CAAC;IAKlB,cAAc,CAAC,EAAE,MAAM,EAAE,CAAC;IAC1B,UAAU,CAAC,EAAE,MAAM,CAAC;IACpB,IAAI,CAAC,EAAE,MAAM,CAAC;CACf,CAAC;AAEF,+DAA+D;AAC/D,MAAM,MAAM,QAAQ,GAAG;IACrB,IAAI,EAAE,MAAM,CAAC;IACb;;;;;;;OAOG;IACH,GAAG,EAAE,SAAS,GAAG,IAAI,CAAC;CACvB,CAAC;AAEF;;;;;;;GAOG;AACH,wBAAgB,aAAa,CAAC,IAAI,EAAE,MAAM,EAAE,OAAO,GAAE,gBAAqB,GAAG,QAAQ,CAqBpF;AAED,6DAA6D;AAC7D,wBAAgB,SAAS,CAAC,IAAI,EAAE,MAAM,EAAE,OAAO,GAAE,gBAAqB,GAAG,MAAM,CAE9E"}

package/dist/{chunk-UYA7HB5G.js → chunk-7DU5USN7.js}

@@ -178,7 +178,9 @@ function annotateComponent(path, state, options) {
   const name = declaredName(path);
   rewritePropsDestructuring(path, name, state);
   if (options.strictReactivity !== false) {
-    checkKeptReads(path.get("arguments.0"), name);
+    const setupPath = path.get("arguments.0");
+    checkKeptReads(setupPath, name);
+    checkDecidedOnce(setupPath, name);
   }
   path.node.arguments = [
     setup,
@@ -213,6 +215,113 @@ Move the read into the part, handler, effect or computed that should re-read it
     }
   });
 }
+function checkDecidedOnce(setup, name) {
+  const report = (at) => {
+    throw at.buildCodeFrameError(
+      `${name}: this view is chosen once, here, from a value that changes. A setup runs one time per instance, so the other branch will never appear.
+
+Put the choice inside the markup, where it is a part that can run again:
+
+  return <>{open.value ? <A /> : <B />}</>;`
+    );
+  };
+  const check = (returned, at) => {
+    if (t.isConditionalExpression(returned)) {
+      if (!hasView(returned.consequent) && !hasView(returned.alternate)) {
+        return;
+      }
+      if (readsSignal(returned.test)) {
+        report(at);
+      }
+      return;
+    }
+    if (t.isLogicalExpression(returned) && returned.operator !== "??") {
+      if (!hasView(returned.right) && !hasView(returned.left)) {
+        return;
+      }
+      if (readsSignal(returned.left)) {
+        report(at);
+      }
+    }
+  };
+  const body = setup.get("body");
+  if (!body.isBlockStatement()) {
+    check(setup.node.body, body);
+    return;
+  }
+  body.traverse({
+    Function(nested) {
+      nested.skip();
+    },
+    ReturnStatement(statement) {
+      const returned = statement.node.argument;
+      if (returned !== null && returned !== void 0) {
+        check(returned, statement);
+      }
+    },
+    /**
+     * The same mistake spelled with a keyword, and the one that actually
+     * shipped: a route guard that returned `<Navigate />` early left the page
+     * it was meant to hide on the screen after a sign-out.
+     */
+    IfStatement(statement) {
+      if (!readsSignal(statement.node.test)) {
+        return;
+      }
+      if (returnsView(statement.node.consequent) || returnsView(statement.node.alternate)) {
+        report(statement.get("test"));
+      }
+    }
+  });
+}
+function returnsView(node) {
+  if (node === null || node === void 0) {
+    return false;
+  }
+  if (t.isReturnStatement(node)) {
+    return node.argument !== null && node.argument !== void 0 && hasView(node.argument);
+  }
+  if (t.isBlockStatement(node)) {
+    return node.body.some((inner) => returnsView(inner));
+  }
+  return false;
+}
+function hasView(node) {
+  if (t.isConditionalExpression(node)) {
+    return hasView(node.consequent) || hasView(node.alternate);
+  }
+  return t.isJSXElement(node) || t.isJSXFragment(node);
+}
+function readsSignal(node) {
+  let found = false;
+  const walk = (current) => {
+    if (current === null || current === void 0 || found) {
+      return;
+    }
+    if (t.isMemberExpression(current)) {
+      if (!current.computed && t.isIdentifier(current.property, { name: "value" })) {
+        found = true;
+        return;
+      }
+      walk(current.object);
+      return;
+    }
+    if (t.isUnaryExpression(current)) {
+      walk(current.argument);
+      return;
+    }
+    if (t.isBinaryExpression(current) || t.isLogicalExpression(current)) {
+      walk(current.left);
+      walk(current.right);
+      return;
+    }
+    if (t.isConditionalExpression(current)) {
+      walk(current.test);
+    }
+  };
+  walk(node);
+  return found;
+}
 function readsOnly(node, propsName) {
   let read = false;
   const walk = (current) => {

package/dist/index.js

@@ -3,7 +3,7 @@ import {
   firsthandPlugin,
   stableId,
   transform
-} from "./chunk-UYA7HB5G.js";
+} from "./chunk-7DU5USN7.js";
 export {
   compileModule,
   firsthandPlugin,

package/dist/transform.d.ts

@@ -13,18 +13,18 @@
  */
 import type { PluginObject } from '@babel/core';
 import * as t from '@babel/types';
-interface FirsthandState {
+type FirsthandState = {
     imports: Map<string, t.Identifier>;
     templates: t.VariableDeclarator[];
     counter: number;
     moduleId: string;
-}
+};
 declare module '@babel/core' {
     interface PluginPass {
         firsthand: FirsthandState;
     }
 }
-export interface FirsthandPluginOptions {
+export type FirsthandPluginOptions = {
     /** Package name used when hashing stable component ids (ADR-0004). */
     packageName?: string;
     /**
@@ -49,7 +49,7 @@ export interface FirsthandPluginOptions {
      * production build emits nothing.
      */
     devtools?: boolean;
-}
+};
 export default function firsthandPlugin(_api: unknown, options?: FirsthandPluginOptions): PluginObject;
 export {};
 //# sourceMappingURL=transform.d.ts.map

package/dist/transform.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"transform.d.ts","sourceRoot":"","sources":["../src/transform.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;GAYG;AAEH,OAAO,KAAK,EAAE,YAAY,EAAc,MAAM,aAAa,CAAC;AAE5D,OAAO,KAAK,CAAC,MAAM,cAAc,CAAC;AAelC,UAAU,cAAc;IACtB,OAAO,EAAE,GAAG,CAAC,MAAM,EAAE,CAAC,CAAC,UAAU,CAAC,CAAC;IACnC,SAAS,EAAE,CAAC,CAAC,kBAAkB,EAAE,CAAC;IAClC,OAAO,EAAE,MAAM,CAAC;IAChB,QAAQ,EAAE,MAAM,CAAC;CAClB;AAED,OAAO,QAAQ,aAAa,CAAC;IAC3B,UAAU,UAAU;QAClB,SAAS,EAAE,cAAc,CAAC;KAC3B;CACF;AAUD,MAAM,WAAW,sBAAsB;IACrC,sEAAsE;IACtE,WAAW,CAAC,EAAE,MAAM,CAAC;IACrB;;;;;;;;OAQG;IACH,gBAAgB,CAAC,EAAE,OAAO,CAAC;IAC3B;;;;;;;;;;OAUG;IACH,QAAQ,CAAC,EAAE,OAAO,CAAC;CACpB;AAED,MAAM,CAAC,OAAO,UAAU,eAAe,CACrC,IAAI,EAAE,OAAO,EACb,OAAO,GAAE,sBAA2B,GACnC,YAAY,CAsDd"}
+{"version":3,"file":"transform.d.ts","sourceRoot":"","sources":["../src/transform.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;GAYG;AAEH,OAAO,KAAK,EAAE,YAAY,EAAc,MAAM,aAAa,CAAC;AAE5D,OAAO,KAAK,CAAC,MAAM,cAAc,CAAC;AAelC,KAAK,cAAc,GAAG;IACpB,OAAO,EAAE,GAAG,CAAC,MAAM,EAAE,CAAC,CAAC,UAAU,CAAC,CAAC;IACnC,SAAS,EAAE,CAAC,CAAC,kBAAkB,EAAE,CAAC;IAClC,OAAO,EAAE,MAAM,CAAC;IAChB,QAAQ,EAAE,MAAM,CAAC;CAClB,CAAC;AAEF,OAAO,QAAQ,aAAa,CAAC;IAC3B,UAAU,UAAU;QAClB,SAAS,EAAE,cAAc,CAAC;KAC3B;CACF;AAUD,MAAM,MAAM,sBAAsB,GAAG;IACnC,sEAAsE;IACtE,WAAW,CAAC,EAAE,MAAM,CAAC;IACrB;;;;;;;;OAQG;IACH,gBAAgB,CAAC,EAAE,OAAO,CAAC;IAC3B;;;;;;;;;;OAUG;IACH,QAAQ,CAAC,EAAE,OAAO,CAAC;CACpB,CAAC;AAEF,MAAM,CAAC,OAAO,UAAU,eAAe,CACrC,IAAI,EAAE,OAAO,EACb,OAAO,GAAE,sBAA2B,GACnC,YAAY,CAsDd"}

package/dist/vite.d.ts

@@ -1,7 +1,7 @@
 import { type SourceMap } from './api.js';
 import type { FirsthandPluginOptions } from './transform.js';
 /** Minimal shape of the Vite plugin contract, so the package needs no Vite dependency. */
-export interface VitePluginLike {
+export type VitePluginLike = {
     name: string;
     enforce: 'pre';
     configResolved(config: {
@@ -11,7 +11,7 @@ export interface VitePluginLike {
         code: string;
         map: SourceMap | null;
     } | null;
-}
+};
 /**
  * Vite/Rollup plugin.
  *

package/dist/vite.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"vite.d.ts","sourceRoot":"","sources":["../src/vite.ts"],"names":[],"mappings":"AAAA,OAAO,EAAiB,KAAK,SAAS,EAAE,MAAM,UAAU,CAAC;AACzD,OAAO,KAAK,EAAE,sBAAsB,EAAE,MAAM,gBAAgB,CAAC;AAE7D,0FAA0F;AAC1F,MAAM,WAAW,cAAc;IAC7B,IAAI,EAAE,MAAM,CAAC;IACb,OAAO,EAAE,KAAK,CAAC;IACf,cAAc,CAAC,MAAM,EAAE;QAAE,OAAO,EAAE,MAAM,CAAA;KAAE,GAAG,IAAI,CAAC;IAClD,SAAS,CAAC,IAAI,EAAE,MAAM,EAAE,EAAE,EAAE,MAAM,GAAG;QAAE,IAAI,EAAE,MAAM,CAAC;QAAC,GAAG,EAAE,SAAS,GAAG,IAAI,CAAA;KAAE,GAAG,IAAI,CAAC;CACrF;AAED;;;;;GAKG;AACH,wBAAgB,SAAS,CAAC,OAAO,GAAE,sBAA2B,GAAG,cAAc,CA0B9E"}
+{"version":3,"file":"vite.d.ts","sourceRoot":"","sources":["../src/vite.ts"],"names":[],"mappings":"AAAA,OAAO,EAAiB,KAAK,SAAS,EAAE,MAAM,UAAU,CAAC;AACzD,OAAO,KAAK,EAAE,sBAAsB,EAAE,MAAM,gBAAgB,CAAC;AAE7D,0FAA0F;AAC1F,MAAM,MAAM,cAAc,GAAG;IAC3B,IAAI,EAAE,MAAM,CAAC;IACb,OAAO,EAAE,KAAK,CAAC;IACf,cAAc,CAAC,MAAM,EAAE;QAAE,OAAO,EAAE,MAAM,CAAA;KAAE,GAAG,IAAI,CAAC;IAClD,SAAS,CAAC,IAAI,EAAE,MAAM,EAAE,EAAE,EAAE,MAAM,GAAG;QAAE,IAAI,EAAE,MAAM,CAAC;QAAC,GAAG,EAAE,SAAS,GAAG,IAAI,CAAA;KAAE,GAAG,IAAI,CAAC;CACrF,CAAC;AAEF;;;;;GAKG;AACH,wBAAgB,SAAS,CAAC,OAAO,GAAE,sBAA2B,GAAG,cAAc,CA0B9E"}

package/dist/vite.js

@@ -1,6 +1,6 @@
 import {
   compileModule
-} from "./chunk-UYA7HB5G.js";
+} from "./chunk-7DU5USN7.js";
 
 // packages/compiler/src/vite.ts
 function firsthand(options = {}) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@firsthandjs/compiler",
-  "version": "0.6.3",
+  "version": "0.7.1",
   "description": "Build-time TSX transform for Firsthand: static markup into templates, dynamic expressions into DOM parts.",
   "license": "MIT",
   "type": "module",