@firsthandjs/compiler 0.6.3 → 0.7.0

package/dist/{chunk-UYA7HB5G.js → chunk-7DU5USN7.js}

@@ -178,7 +178,9 @@ function annotateComponent(path, state, options) {
   const name = declaredName(path);
   rewritePropsDestructuring(path, name, state);
   if (options.strictReactivity !== false) {
-    checkKeptReads(path.get("arguments.0"), name);
+    const setupPath = path.get("arguments.0");
+    checkKeptReads(setupPath, name);
+    checkDecidedOnce(setupPath, name);
   }
   path.node.arguments = [
     setup,
@@ -213,6 +215,113 @@ Move the read into the part, handler, effect or computed that should re-read it
     }
   });
 }
+function checkDecidedOnce(setup, name) {
+  const report = (at) => {
+    throw at.buildCodeFrameError(
+      `${name}: this view is chosen once, here, from a value that changes. A setup runs one time per instance, so the other branch will never appear.
+
+Put the choice inside the markup, where it is a part that can run again:
+
+  return <>{open.value ? <A /> : <B />}</>;`
+    );
+  };
+  const check = (returned, at) => {
+    if (t.isConditionalExpression(returned)) {
+      if (!hasView(returned.consequent) && !hasView(returned.alternate)) {
+        return;
+      }
+      if (readsSignal(returned.test)) {
+        report(at);
+      }
+      return;
+    }
+    if (t.isLogicalExpression(returned) && returned.operator !== "??") {
+      if (!hasView(returned.right) && !hasView(returned.left)) {
+        return;
+      }
+      if (readsSignal(returned.left)) {
+        report(at);
+      }
+    }
+  };
+  const body = setup.get("body");
+  if (!body.isBlockStatement()) {
+    check(setup.node.body, body);
+    return;
+  }
+  body.traverse({
+    Function(nested) {
+      nested.skip();
+    },
+    ReturnStatement(statement) {
+      const returned = statement.node.argument;
+      if (returned !== null && returned !== void 0) {
+        check(returned, statement);
+      }
+    },
+    /**
+     * The same mistake spelled with a keyword, and the one that actually
+     * shipped: a route guard that returned `<Navigate />` early left the page
+     * it was meant to hide on the screen after a sign-out.
+     */
+    IfStatement(statement) {
+      if (!readsSignal(statement.node.test)) {
+        return;
+      }
+      if (returnsView(statement.node.consequent) || returnsView(statement.node.alternate)) {
+        report(statement.get("test"));
+      }
+    }
+  });
+}
+function returnsView(node) {
+  if (node === null || node === void 0) {
+    return false;
+  }
+  if (t.isReturnStatement(node)) {
+    return node.argument !== null && node.argument !== void 0 && hasView(node.argument);
+  }
+  if (t.isBlockStatement(node)) {
+    return node.body.some((inner) => returnsView(inner));
+  }
+  return false;
+}
+function hasView(node) {
+  if (t.isConditionalExpression(node)) {
+    return hasView(node.consequent) || hasView(node.alternate);
+  }
+  return t.isJSXElement(node) || t.isJSXFragment(node);
+}
+function readsSignal(node) {
+  let found = false;
+  const walk = (current) => {
+    if (current === null || current === void 0 || found) {
+      return;
+    }
+    if (t.isMemberExpression(current)) {
+      if (!current.computed && t.isIdentifier(current.property, { name: "value" })) {
+        found = true;
+        return;
+      }
+      walk(current.object);
+      return;
+    }
+    if (t.isUnaryExpression(current)) {
+      walk(current.argument);
+      return;
+    }
+    if (t.isBinaryExpression(current) || t.isLogicalExpression(current)) {
+      walk(current.left);
+      walk(current.right);
+      return;
+    }
+    if (t.isConditionalExpression(current)) {
+      walk(current.test);
+    }
+  };
+  walk(node);
+  return found;
+}
 function readsOnly(node, propsName) {
   let read = false;
   const walk = (current) => {

package/dist/index.js

@@ -3,7 +3,7 @@ import {
   firsthandPlugin,
   stableId,
   transform
-} from "./chunk-UYA7HB5G.js";
+} from "./chunk-7DU5USN7.js";
 export {
   compileModule,
   firsthandPlugin,

package/dist/vite.js

@@ -1,6 +1,6 @@
 import {
   compileModule
-} from "./chunk-UYA7HB5G.js";
+} from "./chunk-7DU5USN7.js";
 
 // packages/compiler/src/vite.ts
 function firsthand(options = {}) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@firsthandjs/compiler",
-  "version": "0.6.3",
+  "version": "0.7.0",
   "description": "Build-time TSX transform for Firsthand: static markup into templates, dynamic expressions into DOM parts.",
   "license": "MIT",
   "type": "module",