@firsthandjs/compiler 0.2.0 → 0.3.0

package/dist/{chunk-HHKCDDN2.js → chunk-WW26NJL4.js}

@@ -128,7 +128,7 @@ function firsthandPlugin(_api, options = {}) {
         path.replaceWith(compileNode(path, state));
       },
       CallExpression(path, state) {
-        annotateComponent(path, state);
+        annotateComponent(path, state, options);
       }
     }
   };
@@ -157,7 +157,7 @@ function runtime(state, name, source = RUNTIME) {
   }
   return t.cloneNode(local);
 }
-function annotateComponent(path, state) {
+function annotateComponent(path, state, options) {
   const callee = path.node.callee;
   if (!t.isIdentifier(callee, { name: "component" }) || path.node.arguments.length > 2) {
     return;
@@ -172,6 +172,9 @@ function annotateComponent(path, state) {
   }
   const name = declaredName(path);
   rewritePropsDestructuring(path, name, state);
+  if (options.strictReactivity === true) {
+    checkKeptReads(path.get("arguments.0"), name);
+  }
   path.node.arguments = [
     setup,
     path.node.arguments[1] ?? t.identifier("undefined"),
@@ -179,6 +182,64 @@ function annotateComponent(path, state) {
     t.stringLiteral(name)
   ];
 }
+function checkKeptReads(setup, name) {
+  const parameter = setup.node.params[0];
+  const propsName = t.isIdentifier(parameter) ? parameter.name : null;
+  const body = setup.get("body");
+  if (!body.isBlockStatement()) {
+    return;
+  }
+  body.traverse({
+    Function(nested) {
+      nested.skip();
+    },
+    VariableDeclarator(declarator) {
+      const init = declarator.node.init;
+      if (init === null || init === void 0 || !readsOnly(init, propsName)) {
+        return;
+      }
+      const target = declarator.node.id;
+      const label = t.isIdentifier(target) ? `\`${target.name}\`` : "This value";
+      throw declarator.buildCodeFrameError(
+        `${name}: ${label} is read once, here, and then kept. A setup runs one time per instance, so this value will not change again.
+
+Move the read into the part, handler, effect or computed that should re-read it \u2014 or wrap it in snapshot(() => \u2026) if reading once is what you meant.`
+      );
+    }
+  });
+}
+function readsOnly(node, propsName) {
+  let read = false;
+  const walk = (current) => {
+    if (t.isIdentifier(current) || t.isLiteral(current)) {
+      if (t.isTemplateLiteral(current)) {
+        return current.expressions.every((part) => walk(part));
+      }
+      return true;
+    }
+    if (t.isMemberExpression(current)) {
+      const property = current.property;
+      if (!current.computed && t.isIdentifier(property, { name: "value" })) {
+        read = true;
+      }
+      if (propsName !== null && t.isIdentifier(current.object, { name: propsName })) {
+        read = true;
+      }
+      return walk(current.object) && (!current.computed || walk(property));
+    }
+    if (t.isUnaryExpression(current)) {
+      return walk(current.argument);
+    }
+    if (t.isBinaryExpression(current) || t.isLogicalExpression(current)) {
+      return walk(current.left) && walk(current.right);
+    }
+    if (t.isConditionalExpression(current)) {
+      return walk(current.test) && walk(current.consequent) && walk(current.alternate);
+    }
+    return false;
+  };
+  return walk(node) && read;
+}
 function isFirsthandImport(binding) {
   const parent = binding.path.parentPath;
   if (!parent.isImportDeclaration()) {
@@ -830,7 +891,10 @@ function buildPlugins(options) {
     plugins.push([typescriptSyntax, { isTSX: true }]);
   }
   plugins.push(jsxSyntax);
-  plugins.push([firsthandPlugin, { packageName: options.packageName }]);
+  plugins.push([
+    firsthandPlugin,
+    { packageName: options.packageName, strictReactivity: options.strictReactivity }
+  ]);
   return plugins;
 }
 

package/dist/index.js

@@ -2,7 +2,7 @@ import {
   firsthandPlugin,
   stableId,
   transform
-} from "./chunk-HHKCDDN2.js";
+} from "./chunk-WW26NJL4.js";
 export {
   firsthandPlugin,
   stableId,

package/dist/transform.d.ts

@@ -27,6 +27,14 @@ declare module '@babel/core' {
 export interface FirsthandPluginOptions {
     /** Package name used when hashing stable component ids (ADR-0004). */
     packageName?: string;
+    /**
+     * Refuse to compile a value that is read once in a setup and then kept.
+     *
+     * Off by default: reading once is legal and often deliberate. On, it is a
+     * build error rather than a warning, because the cases it can see are the
+     * unambiguous ones — see `checkKeptReads` (ADR-0019).
+     */
+    strictReactivity?: boolean;
 }
 export default function firsthandPlugin(_api: unknown, options?: FirsthandPluginOptions): PluginObject;
 export {};

package/dist/transform.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"transform.d.ts","sourceRoot":"","sources":["../src/transform.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;GAYG;AAEH,OAAO,KAAK,EAAE,YAAY,EAAc,MAAM,aAAa,CAAC;AAE5D,OAAO,KAAK,CAAC,MAAM,cAAc,CAAC;AAelC,UAAU,cAAc;IACtB,OAAO,EAAE,GAAG,CAAC,MAAM,EAAE,CAAC,CAAC,UAAU,CAAC,CAAC;IACnC,SAAS,EAAE,CAAC,CAAC,kBAAkB,EAAE,CAAC;IAClC,OAAO,EAAE,MAAM,CAAC;IAChB,QAAQ,EAAE,MAAM,CAAC;CAClB;AAED,OAAO,QAAQ,aAAa,CAAC;IAC3B,UAAU,UAAU;QAClB,SAAS,EAAE,cAAc,CAAC;KAC3B;CACF;AAUD,MAAM,WAAW,sBAAsB;IACrC,sEAAsE;IACtE,WAAW,CAAC,EAAE,MAAM,CAAC;CACtB;AAED,MAAM,CAAC,OAAO,UAAU,eAAe,CACrC,IAAI,EAAE,OAAO,EACb,OAAO,GAAE,sBAA2B,GACnC,YAAY,CAgDd"}
+{"version":3,"file":"transform.d.ts","sourceRoot":"","sources":["../src/transform.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;GAYG;AAEH,OAAO,KAAK,EAAE,YAAY,EAAc,MAAM,aAAa,CAAC;AAE5D,OAAO,KAAK,CAAC,MAAM,cAAc,CAAC;AAelC,UAAU,cAAc;IACtB,OAAO,EAAE,GAAG,CAAC,MAAM,EAAE,CAAC,CAAC,UAAU,CAAC,CAAC;IACnC,SAAS,EAAE,CAAC,CAAC,kBAAkB,EAAE,CAAC;IAClC,OAAO,EAAE,MAAM,CAAC;IAChB,QAAQ,EAAE,MAAM,CAAC;CAClB;AAED,OAAO,QAAQ,aAAa,CAAC;IAC3B,UAAU,UAAU;QAClB,SAAS,EAAE,cAAc,CAAC;KAC3B;CACF;AAUD,MAAM,WAAW,sBAAsB;IACrC,sEAAsE;IACtE,WAAW,CAAC,EAAE,MAAM,CAAC;IACrB;;;;;;OAMG;IACH,gBAAgB,CAAC,EAAE,OAAO,CAAC;CAC5B;AAED,MAAM,CAAC,OAAO,UAAU,eAAe,CACrC,IAAI,EAAE,OAAO,EACb,OAAO,GAAE,sBAA2B,GACnC,YAAY,CAgDd"}

package/dist/vite.js

@@ -1,6 +1,6 @@
 import {
   transform
-} from "./chunk-HHKCDDN2.js";
+} from "./chunk-WW26NJL4.js";
 
 // packages/compiler/src/vite.ts
 function firsthand(options = {}) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@firsthandjs/compiler",
-  "version": "0.2.0",
+  "version": "0.3.0",
   "description": "Build-time TSX transform for Firsthand: static markup into templates, dynamic expressions into DOM parts.",
   "license": "MIT",
   "type": "module",