@firmachain/firma-js 0.3.2 → 0.3.3

package/dist/sdk/FirmaStakingService.js

@@ -566,7 +566,7 @@ var FirmaStakingService = /** @class */ (function () {
                                 maxEntries: result.max_entries,
                                 historicalEntries: result.historical_entries,
                                 bondDenom: result.bond_denom,
-                                minCommissionRate: FirmaUtil_1.FirmaUtil.processCommissionRate(result.min_commission_rate)
+                                minCommissionRate: result.min_commission_rate
                             }];
                     case 2:
                         error_22 = _a.sent();

package/dist/sdk/FirmaUtil.d.ts

@@ -69,22 +69,14 @@ export declare class FirmaUtil {
      * @returns Duration object ready to use with protobuf
      */
     static createDurationFromString(durationStr: string): Duration;
-    /**
-     * Normalizes decimal string for Cosmos SDK usage.
-     * Converts "0.000000000000000000" to empty string to avoid big.Int conversion errors.
-     *
-     * @param decimalStr - Decimal string that might cause big.Int conversion issues
-     * @returns Normalized string safe for Cosmos SDK usage
-     */
-    static normalizeDecimalString(decimalStr: string): string;
     /**
      * Safely processes commission rate strings to prevent big.Int conversion errors.
-     * This is specifically for handling commission rates that might be "0.000000000000000000".
+     * Converts decimal commission rates to Cosmos SDK atomics format (integer representation).
      *
      * @param commissionRate - Commission rate string from staking params
-     * @returns Processed commission rate string safe for protobuf usage
+     * @returns Processed commission rate string safe for protobuf usage (atomics format or empty string)
      */
-    static processCommissionRate(commissionRate: string): string;
+    static processCommissionRateAsDecimal(commissionRate: string): string;
 }
 export declare const DefaultTxMisc: {
     memo: string;

package/dist/sdk/FirmaUtil.js

@@ -84,6 +84,7 @@ var proto_signing_1 = require("@cosmjs/proto-signing");
 var signingstargateclient_1 = require("./firmachain/common/signingstargateclient");
 var any_1 = require("./firmachain/google/protobuf/any");
 var long_1 = __importDefault(require("long"));
+var bignumber_js_1 = __importDefault(require("bignumber.js"));
 var CommonTxClient_1 = require("./firmachain/common/CommonTxClient");
 var CryptoJS = require("crypto-js");
 var sha1 = require("crypto-js/sha1");
@@ -537,63 +538,33 @@ var FirmaUtil = /** @class */ (function () {
             nanos: nanos
         });
     };
-    /**
-     * Normalizes decimal string for Cosmos SDK usage.
-     * Converts "0.000000000000000000" to empty string to avoid big.Int conversion errors.
-     *
-     * @param decimalStr - Decimal string that might cause big.Int conversion issues
-     * @returns Normalized string safe for Cosmos SDK usage
-     */
-    FirmaUtil.normalizeDecimalString = function (decimalStr) {
-        if (!decimalStr || decimalStr.trim() === "") {
-            return "";
-        }
-        var trimmed = decimalStr.trim();
-        // Check if it's a valid decimal number
-        if (!/^-?\d*\.?\d*$/.test(trimmed)) {
-            return trimmed; // Return as-is if not a valid decimal
-        }
-        try {
-            var num = parseFloat(trimmed);
-            // If the number is 0 or very close to 0, return empty string
-            if (num === 0 || Math.abs(num) < 1e-18) {
-                return "";
-            }
-            // For non-zero values, return the original string
-            return trimmed;
-        }
-        catch (error) {
-            // If parsing fails, return the original string
-            return trimmed;
-        }
-    };
     /**
      * Safely processes commission rate strings to prevent big.Int conversion errors.
-     * This is specifically for handling commission rates that might be "0.000000000000000000".
+     * Converts decimal commission rates to Cosmos SDK atomics format (integer representation).
      *
      * @param commissionRate - Commission rate string from staking params
-     * @returns Processed commission rate string safe for protobuf usage
+     * @returns Processed commission rate string safe for protobuf usage (atomics format or empty string)
      */
-    FirmaUtil.processCommissionRate = function (commissionRate) {
-        if (!commissionRate || commissionRate.trim() === "") {
-            return "";
-        }
-        var normalized = FirmaUtil.normalizeDecimalString(commissionRate);
-        // For commission rates, if it's effectively zero, return empty string
-        if (normalized === "") {
-            return "";
-        }
-        // Ensure the value is within valid commission rate range (0-1)
-        try {
-            var rate = parseFloat(normalized);
-            if (rate < 0 || rate > 1) {
-                throw new Error("Invalid commission rate: " + commissionRate + ". Must be between 0 and 1");
-            }
-            return normalized;
+    FirmaUtil.processCommissionRateAsDecimal = function (commissionRate) {
+        var trimmed = commissionRate.trim();
+        if (!commissionRate || trimmed === "") {
+            throw new Error("Invalid commission rate format: " + commissionRate);
         }
-        catch (error) {
+        if (!/^(\d+\.?\d*|\.\d+)$/.test(trimmed)) {
             throw new Error("Invalid commission rate format: " + commissionRate);
         }
+        // Validates input and creates BigNumber instance
+        var commissionRateBN = new bignumber_js_1.default(trimmed);
+        // Checks if it's a valid finite number
+        if (!commissionRateBN.isFinite())
+            throw new Error("Invalid commission rate format: " + commissionRate);
+        // Validates range (0 to 1 inclusive)
+        if (commissionRateBN.isNegative() || commissionRateBN.isGreaterThan(1))
+            throw new Error("Invalid commission rate range. Must be between 0 and 1 inclusive.");
+        // Converts to atomics format (multiply by 10^18)
+        var atomics = commissionRateBN.multipliedBy(new bignumber_js_1.default(10).pow(18));
+        // Returns integer string
+        return atomics.integerValue(bignumber_js_1.default.ROUND_DOWN).toString();
     };
     FirmaUtil.FctDecimal = 6;
     return FirmaUtil;

package/dist/test/16.gov_tx.test.js

@@ -50,6 +50,7 @@ Object.defineProperty(exports, "__esModule", { value: true });
 var chai_1 = require("chai");
 var common_1 = require("../sdk/firmachain/common");
 var FirmaSDK_1 = require("../sdk/FirmaSDK");
+var FirmaUtil_1 = require("../sdk/FirmaUtil");
 var config_test_1 = require("./config_test");
 // If test it, the properties of the chain change, so skip it.
 describe('[16. Gov Tx Test]', function () {
@@ -165,6 +166,7 @@ describe('[16. Gov Tx Test]', function () {
                     params = _a.sent();
                     params.maxValidators = 100;
                     params.historicalEntries = 10000;
+                    params.minCommissionRate = FirmaUtil_1.FirmaUtil.processCommissionRateAsDecimal(params.minCommissionRate);
                     metadata = "";
                     return [4 /*yield*/, firma.Gov.submitStakingParamsUpdateProposal(aliceWallet, title, summary, initialDepositFCT, params, metadata)];
                 case 2:
@@ -201,7 +203,7 @@ describe('[16. Gov Tx Test]', function () {
             switch (_a.label) {
                 case 0:
                     initialDeposit = 5000;
-                    title = "CancelProposal test proposal";
+                    title = "Software upgrade proposal";
                     summary = "This is a Text & CancelProposal";
                     plan = {
                         name: 'v0.5.1',

package/dist/test/18.util.test.js

@@ -38,12 +38,8 @@ var __generator = (this && this.__generator) || function (thisArg, body) {
 Object.defineProperty(exports, "__esModule", { value: true });
 var chai_1 = require("chai");
 var FirmaUtil_1 = require("../sdk/FirmaUtil");
-var FirmaSDK_1 = require("../sdk/FirmaSDK");
-var config_test_1 = require("./config_test");
 describe('[18. util Test]', function () {
-    var firma;
     beforeEach(function () {
-        firma = new FirmaSDK_1.FirmaSDK(config_test_1.TestChainConfig);
     });
     // getHashFromString
     it('getSha1HashFromString test', function () { return __awaiter(void 0, void 0, void 0, function () {
@@ -269,56 +265,47 @@ describe('[18. util Test]', function () {
             return [2 /*return*/];
         });
     }); });
-    it('normalizeDecimalString test - success case', function () { return __awaiter(void 0, void 0, void 0, function () {
+    it('processCommissionRateAsDecimal test - success case', function () { return __awaiter(void 0, void 0, void 0, function () {
         var result;
         return __generator(this, function (_a) {
-            result = FirmaUtil_1.FirmaUtil.normalizeDecimalString("0.000000000000000000");
-            chai_1.expect(result).to.equal("");
+            result = FirmaUtil_1.FirmaUtil.processCommissionRateAsDecimal("0.000000000000000000");
+            chai_1.expect(result).to.equal("0");
+            result = FirmaUtil_1.FirmaUtil.processCommissionRateAsDecimal("1");
+            chai_1.expect(result).to.equal("1000000000000000000");
+            result = FirmaUtil_1.FirmaUtil.processCommissionRateAsDecimal("0.99999999999999999999999");
+            chai_1.expect(result).to.equal("999999999999999999");
+            result = FirmaUtil_1.FirmaUtil.processCommissionRateAsDecimal("0.3719281729181018373290120300000831");
+            chai_1.expect(result).to.equal("371928172918101837");
+            result = FirmaUtil_1.FirmaUtil.processCommissionRateAsDecimal("1.000000000000000000");
+            chai_1.expect(result).to.equal("1000000000000000000");
+            result = FirmaUtil_1.FirmaUtil.processCommissionRateAsDecimal(" 0.75 ");
+            chai_1.expect(result).to.equal("750000000000000000");
+            result = FirmaUtil_1.FirmaUtil.processCommissionRateAsDecimal(".23");
+            chai_1.expect(result).to.equal("230000000000000000");
+            result = FirmaUtil_1.FirmaUtil.processCommissionRateAsDecimal(".9999990000000");
+            chai_1.expect(result).to.equal("999999000000000000");
             return [2 /*return*/];
         });
     }); });
-    it('normalizeDecimalString test - failure case', function () { return __awaiter(void 0, void 0, void 0, function () {
-        var result;
-        return __generator(this, function (_a) {
-            result = FirmaUtil_1.FirmaUtil.normalizeDecimalString("0.000000000000000000");
-            chai_1.expect(result).to.not.equal("0.000000000000000000");
-            return [2 /*return*/];
-        });
-    }); });
-    it('processCommissionRate test - success case', function () { return __awaiter(void 0, void 0, void 0, function () {
-        var result;
-        return __generator(this, function (_a) {
-            result = FirmaUtil_1.FirmaUtil.processCommissionRate("0.000000000000000000");
-            chai_1.expect(result).to.equal("");
-            result = FirmaUtil_1.FirmaUtil.processCommissionRate("0.1");
-            chai_1.expect(result).to.equal("0.1");
-            result = FirmaUtil_1.FirmaUtil.processCommissionRate("1");
-            chai_1.expect(result).to.equal("1");
-            result = FirmaUtil_1.FirmaUtil.processCommissionRate(" 0.75 ");
-            chai_1.expect(result).to.equal("0.75");
-            result = FirmaUtil_1.FirmaUtil.processCommissionRate("");
-            chai_1.expect(result).to.equal("");
-            return [2 /*return*/];
-        });
-    }); });
-    it('processCommissionRate - failure cases', function () { return __awaiter(void 0, void 0, void 0, function () {
-        var testString;
+    it('processCommissionRateAsDecimal test - failure cases', function () { return __awaiter(void 0, void 0, void 0, function () {
         return __generator(this, function (_a) {
-            testString = "1.01";
-            try {
-                FirmaUtil_1.FirmaUtil.processCommissionRate(testString);
-            }
-            catch (error) {
-                chai_1.expect(error.message).to.equal("Invalid commission rate format: 1.01");
-            }
-            // Invalid commission rate: -0.1. Must be >= 0
-            testString = "-0.1";
-            try {
-                FirmaUtil_1.FirmaUtil.processCommissionRate(testString);
-            }
-            catch (error) {
-                chai_1.expect(error.message).to.equal("Invalid commission rate format: -0.1");
-            }
+            chai_1.expect(function () { return FirmaUtil_1.FirmaUtil.processCommissionRateAsDecimal("."); }).to.throw("Invalid commission rate format");
+            chai_1.expect(function () { return FirmaUtil_1.FirmaUtil.processCommissionRateAsDecimal(""); }).to.throw("Invalid commission rate format: ");
+            chai_1.expect(function () { return FirmaUtil_1.FirmaUtil.processCommissionRateAsDecimal("   "); }).to.throw("Invalid commission rate format: ");
+            chai_1.expect(function () { return FirmaUtil_1.FirmaUtil.processCommissionRateAsDecimal("null"); }).to.throw("Invalid commission rate format: null");
+            chai_1.expect(function () { return FirmaUtil_1.FirmaUtil.processCommissionRateAsDecimal("0.1abc"); }).to.throw("Invalid commission rate format: 0.1abc");
+            chai_1.expect(function () { return FirmaUtil_1.FirmaUtil.processCommissionRateAsDecimal("0.1.2"); }).to.throw("Invalid commission rate format");
+            chai_1.expect(function () { return FirmaUtil_1.FirmaUtil.processCommissionRateAsDecimal("--0.5"); }).to.throw("Invalid commission rate format");
+            chai_1.expect(function () { return FirmaUtil_1.FirmaUtil.processCommissionRateAsDecimal("1.01"); }).to.throw("Invalid commission rate range. Must be between 0 and 1 inclusive.");
+            chai_1.expect(function () { return FirmaUtil_1.FirmaUtil.processCommissionRateAsDecimal("2"); }).to.throw("Invalid commission rate range. Must be between 0 and 1 inclusive.");
+            chai_1.expect(function () { return FirmaUtil_1.FirmaUtil.processCommissionRateAsDecimal("1.1"); }).to.throw("Invalid commission rate range. Must be between 0 and 1 inclusive.");
+            chai_1.expect(function () { return FirmaUtil_1.FirmaUtil.processCommissionRateAsDecimal("-0.1"); }).to.throw("Invalid commission rate format");
+            chai_1.expect(function () { return FirmaUtil_1.FirmaUtil.processCommissionRateAsDecimal("-1"); }).to.throw("Invalid commission rate format");
+            chai_1.expect(function () { return FirmaUtil_1.FirmaUtil.processCommissionRateAsDecimal("-0.01"); }).to.throw("Invalid commission rate format: -0.01");
+            chai_1.expect(function () { return FirmaUtil_1.FirmaUtil.processCommissionRateAsDecimal("-0.000000000000000001"); }).to.throw("Invalid commission rate format");
+            chai_1.expect(function () { return FirmaUtil_1.FirmaUtil.processCommissionRateAsDecimal("1.00000000000000000001"); }).to.throw("Invalid commission rate range. Must be between 0 and 1 inclusive.");
+            chai_1.expect(function () { return FirmaUtil_1.FirmaUtil.processCommissionRateAsDecimal("0.5%"); }).to.throw("Invalid commission rate format");
+            chai_1.expect(function () { return FirmaUtil_1.FirmaUtil.processCommissionRateAsDecimal(" 0.5 extra"); }).to.throw("Invalid commission rate format");
             return [2 /*return*/];
         });
     }); });

package/dist/test/config_test.d.ts

@@ -1,7 +1,7 @@
 import { FirmaConfig } from '../sdk/FirmaConfig';
 export declare let TestChainConfig: FirmaConfig;
 export declare const validatorMnemonic = "angry water bunker where iron absurd cruise deliver clutch unique creek pyramid arch express flush pill lens concert absent enemy boring mom nuclear rose";
-export declare const aliceMnemonic = "immune flavor record sphere foam planet faint grid disorder flag minute eternal beef sea camp surge extra scorpion pistol plastic happy siren juice found";
+export declare const aliceMnemonic = "angry water bunker where iron absurd cruise deliver clutch unique creek pyramid arch express flush pill lens concert absent enemy boring mom nuclear rose";
 export declare const bobMnemonic = "innocent enforce visit tilt job kitten actual glory flash feed wonder license rubber outer drum sun fuel relax roof universe enrich pulse fine grid";
 export declare const feeMnemonic = "long shallow crumble clown truth book oval render seed canal buffalo assist sadness elbow afraid catalog brother trade food subject must luggage bread neither";
 export declare const firmaFeeMnemonic = "arrest dynamic typical lunch original glare truth narrow stairs clip canyon space alley chat drive sudden music bubble time mesh color office minor draft";

package/dist/test/config_test.js

@@ -17,10 +17,18 @@ exports.TestChainConfig = {
     isShowLog: false,
 };
 exports.validatorMnemonic = "angry water bunker where iron absurd cruise deliver clutch unique creek pyramid arch express flush pill lens concert absent enemy boring mom nuclear rose";
-exports.aliceMnemonic = "immune flavor record sphere foam planet faint grid disorder flag minute eternal beef sea camp surge extra scorpion pistol plastic happy siren juice found";
+// DEVNET
+// export const aliceMnemonic = "immune flavor record sphere foam planet faint grid disorder flag minute eternal beef sea camp surge extra scorpion pistol plastic happy siren juice found";
+// TESTNET
+// export const aliceMnemonic = "harvest galaxy sniff include record undo width oven tired sad month text museum curious firm mountain flash assault oval sand ribbon blouse consider lens";
+// VALIDATOR
+// export const aliceMnemonic = "clump erupt type lucky mask pig soup runway wrestle suspect element involve stamp civil auction resource blame same journey start unaware crush ten draw";
+// export const aliceMnemonic = "owner pottery smile evolve pig base lady dismiss badge purchase divide royal medal buffalo miss carbon kiwi gate draft mouse yard reunion thank wage";
+// export const aliceMnemonic = "main shallow liberty desk super palm remind throw track legal warrior client garbage type insect first token keen subway pony curtain pitch yellow arrive";
 // voting test
 // export const aliceMnemonic = "long shallow crumble clown truth book oval render seed canal buffalo assist sadness elbow afraid catalog brother trade food subject must luggage bread neither";
-// export const aliceMnemonic = "angry water bunker where iron absurd cruise deliver clutch unique creek pyramid arch express flush pill lens concert absent enemy boring mom nuclear rose";
+// export const aliceMnemonic = "clump erupt type lucky mask pig soup runway wrestle suspect element involve stamp civil auction resource blame same journey start unaware crush ten draw";
+exports.aliceMnemonic = "angry water bunker where iron absurd cruise deliver clutch unique creek pyramid arch express flush pill lens concert absent enemy boring mom nuclear rose";
 // export const aliceMnemonic = "stadium lonely midnight okay meat rib awesome wealth phone leisure turn prosper notable label fruit define little also father silver half drill bargain antique";
 // export const aliceMnemonic = "uncle banana theme relax oak prosper volcano glad industry bicycle tower thrive jelly curious luggage frame that defy reason jewel figure begin nice moon";
 // export const aliceMnemonic = "rebel engine situate catalog blood strong satisfy aerobic cupboard again vivid twice flag work taxi heart fruit island ribbon hungry cheap ordinary horse foam";

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@firmachain/firma-js",
-  "version": "0.3.2",
+  "version": "0.3.3",
   "description": "The Official FirmaChain Javascript SDK written in Typescript",
   "main": "dist/index.js",
   "typings": "dist/index.d.ts",
@@ -41,6 +41,7 @@
     "@types/pako": "2.0.0",
     "axios": "0.27.2",
     "big-number": "2.0.0",
+    "bignumber.js": "^9.3.0",
     "cosmjs-types": "0.9.0",
     "crypto-js": "4.1.1",
     "fast-deep-equal": "^3.1.3",
@@ -50,6 +51,7 @@
     "readline-sync": "1.4.10"
   },
   "devDependencies": {
+    "@types/bignumber.js": "^4.0.0",
     "@types/chai": "4.2.21",
     "@types/mocha": "9.0.0",
     "@types/node": "16.4.3",