@firefoxic/eslint-config 6.0.1 → 8.0.0

package/lib/enough-is-enough/index.js

@@ -1,5 +1,6 @@
 import noMultilineNamedImports from "./no-multiline-named-imports/index.js"
 import noSingleQuotesInImportsAndObjectKeys from "./no-single-quotes-in-imports-and-object-keys/index.js"
+import preferLet from "./prefer-let/index.js"
 
 const plugin = {
 	// preferred location of name and version
@@ -10,6 +11,7 @@ const plugin = {
 	rules: {
 		"no-multiline-named-imports": noMultilineNamedImports,
 		"no-single-quotes-in-imports-and-object-keys": noSingleQuotesInImportsAndObjectKeys,
+		"prefer-let": preferLet,
 	},
 }
 

package/lib/enough-is-enough/prefer-let/index.js

@@ -0,0 +1,74 @@
+/**
+ * @fileoverview Use `let` declarations to bind names to values
+ * @author Charles Lowell
+ */
+
+export default {
+	meta: {
+		docs: {
+			description: `Use "let" declarations to bind names to values`,
+			category: `Stylistic Issues`,
+			recommended: false,
+		},
+		fixable: `code`, // or "code" or "whitespace"
+		schema: [], // fill in your schema
+	},
+
+	create (context) {
+		let sourceCode = context.sourceCode ?? context.getSourceCode()
+
+		function getScope (node) {
+			return sourceCode.getScope ? sourceCode.getScope(node) : context.getScope()
+		}
+
+		function isGlobalScope (node) {
+			return getScope(node).type === `global`
+		}
+
+		function isModuleScope (node) {
+			return getScope(node).type === `module`
+		}
+
+		function isProgramScope (node) {
+			return getScope(node).block.type === `Program`
+		}
+
+		function isTopLevelScope (node) {
+			return isGlobalScope(node) || isModuleScope(node) || isProgramScope(node)
+		}
+
+		function isInAmbientContext (node) {
+			let current = node.parent
+			while (current) {
+				if (current.type === `TSModuleDeclaration` && current.declare === true) return true
+
+				current = current.parent
+			}
+			return false
+		}
+
+		return {
+			VariableDeclaration (node) {
+				if (node.kind === `var`) {
+					if (isInAmbientContext(node)) return
+
+					context.report({
+						message: `prefer "let" over "var" to declare value bindings`,
+						node,
+					})
+				}
+				else if (node.kind === `const` && !isTopLevelScope(node)) {
+					let constToken = sourceCode.getFirstToken(node)
+
+					context.report({
+						message: `"const" declaration outside top-level scope`,
+						node,
+						fix (fixer) {
+							return fixer.replaceText(constToken, `let`)
+						},
+					})
+				}
+			},
+		}
+	},
+}

package/lib/index.js

@@ -1,5 +1,4 @@
 import stylistic from "@stylistic/eslint-plugin"
-import eslintPluginPreferLet from "eslint-plugin-prefer-let"
 import eslintPluginSimpleImportSort from "eslint-plugin-simple-import-sort"
 
 import enoughIsEnough from "./enough-is-enough/index.js"
@@ -130,14 +129,6 @@ export default [
 			"valid-typeof": `error`,
 		},
 	},
-	{
-		plugins: {
-			"prefer-let": eslintPluginPreferLet,
-		},
-		rules: {
-			"prefer-let/prefer-let": `error`,
-		},
-	},
 	{
 		plugins: {
 			"simple-import-sort": eslintPluginSimpleImportSort,
@@ -148,25 +139,25 @@ export default [
 				`error`,
 				{
 					groups: [
-						// 1.Node.js modules
+						// 1. Node.js modules
 						[`^node:`],
 						// 2. Foreign modules
 						[`^@?\\w`],
-						// 3. Absolute imports (@/...)
+						// 3. Styles
+						[`^.+\\.s?css$`],
+						// 4. Absolute imports (@/...)
 						[`^@/`],
-						// 4. Relative imports (up)
+						// 5. Relative imports (up)
 						[
 							`^\\.\\.(?!/?$)`,
 							`^\\.\\./?$`,
 						],
-						// 5. Relative imports (down)
+						// 6. Relative imports (down)
 						[
 							`^\\./(?=.*/)(?!/?$)`,
 							`^\\.(?!/?$)`,
 							`^\\./?$`,
 						],
-						// 6. Styles
-						[`^.+\\.s?css$`],
 					],
 				},
 			],
@@ -426,6 +417,7 @@ export default [
 		rules: {
 			"enough-is-enough/no-multiline-named-imports": `error`,
 			"enough-is-enough/no-single-quotes-in-imports-and-object-keys": `error`,
+			"enough-is-enough/prefer-let": `error`,
 		},
 	},
 ]

package/package.json

@@ -1,7 +1,7 @@
 {
 	"name": "@firefoxic/eslint-config",
 	"description": "Shared config for eslint by firefoxic.",
-	"version": "6.0.1",
+	"version": "8.0.0",
 	"license": "MIT",
 	"author": {
 		"name": "Sergey Artemov",
@@ -17,7 +17,8 @@
 	},
 	"type": "module",
 	"engines": {
-		"node": ">=20.19"
+		"node": ">=20.19",
+		"pnpm": ">=10.30"
 	},
 	"exports": {
 		"default": "./lib/index.js",
@@ -25,23 +26,23 @@
 	},
 	"files": [
 		"./lib/**/*.d.ts",
-		"./lib/**/*.js"
+		"./lib/**/*.js",
+		"!**/*.test.js"
 	],
 	"peerDependencies": {
-		"eslint": "^9.39.2"
+		"eslint": "^10.0.0"
 	},
 	"dependencies": {
-		"@stylistic/eslint-plugin": "^5.7.0",
-		"eslint-plugin-prefer-let": "^4.0.1",
+		"@stylistic/eslint-plugin": "^5.9.0",
 		"eslint-plugin-simple-import-sort": "^12.1.1",
-		"globals": "^17.0.0"
+		"globals": "^17.3.0"
 	},
 	"scripts": {
-		"help": "make help",
-		"eslint": "eslint"
+		"help": "make help"
 	},
 	"devDependencies": {
-		"eslint": "^9.39.2"
+		"@typescript-eslint/parser": "^8.56.1",
+		"eslint": "^10.0.2"
 	},
 	"keywords": [
 		"config",