@firefoxic/eslint-config 6.0.0 → 7.0.0

package/lib/enough-is-enough/index.js

@@ -0,0 +1,18 @@
+import noMultilineNamedImports from "./no-multiline-named-imports/index.js"
+import noSingleQuotesInImportsAndObjectKeys from "./no-single-quotes-in-imports-and-object-keys/index.js"
+import preferLet from "./prefer-let/index.js"
+
+const plugin = {
+	// preferred location of name and version
+	meta: {
+		name: `eslint-plugin-enough-is-enough`,
+		namespace: `enough-is-enough`,
+	},
+	rules: {
+		"no-multiline-named-imports": noMultilineNamedImports,
+		"no-single-quotes-in-imports-and-object-keys": noSingleQuotesInImportsAndObjectKeys,
+		"prefer-let": preferLet,
+	},
+}
+
+export default plugin

package/lib/enough-is-enough/no-multiline-named-imports/index.js

@@ -0,0 +1,53 @@
+export default {
+	meta: {
+		type: `layout`,
+		fixable: `code`,
+		messages: {
+			multiline: `Multi-line named imports are disallowed.`,
+		},
+	},
+	create (context) {
+		let sourceCode = context.sourceCode
+
+		return {
+			ImportDeclaration (node) {
+				let namedSpecifiers = node.specifiers.filter((s) => s.type === `ImportSpecifier`)
+
+				if (namedSpecifiers.length === 0) return
+
+				let tokens = sourceCode.getTokens(node)
+				let openBrace = tokens.find((t) => t.value === `{`)
+				let closeBrace = tokens.reverse().find((t) => t.value === `}`)
+
+				if (!openBrace || !closeBrace) return
+
+				if (openBrace.loc.start.line !== closeBrace.loc.end.line) {
+					context.report({
+						node,
+						messageId: `multiline`,
+						fix (fixer) {
+							let imports = namedSpecifiers.map((s) => sourceCode.getText(s)).join(`, `)
+							let defaultImport = node.specifiers.find((s) => s.type === `ImportDefaultSpecifier`)
+							let namespaceImport = node.specifiers.find((s) => s.type === `ImportNamespaceSpecifier`)
+							let source = sourceCode.getText(node.source)
+
+							let newImport = `import `
+
+							if (defaultImport) newImport += `${sourceCode.getText(defaultImport)}, `
+							if (namespaceImport) newImport += `${sourceCode.getText(namespaceImport)}, `
+							newImport += `{ ${imports} } from ${source}`
+
+							let lastToken = sourceCode.getLastToken(node)
+							let hasSemicolon = lastToken && lastToken.value === `;`
+
+							if (hasSemicolon) newImport += `;`
+
+							return fixer.replaceText(node, newImport)
+						},
+					})
+				}
+			},
+
+		}
+	},
+}

package/lib/enough-is-enough/no-single-quotes-in-imports-and-object-keys/index.js

@@ -0,0 +1,79 @@
+export default {
+	meta: {
+		type: `suggestion`,
+		docs: { description: `Disallow single quotes in import/export sources and object keys when quoted` },
+		fixable: `code`,
+		schema: [],
+	},
+
+	create (context) {
+		let sourceCode = context.sourceCode
+
+		function isSingleQuoted (node) {
+			if (typeof node.value !== `string`) return false
+
+			let text = sourceCode.getText(node)
+
+			return text.startsWith(`'`) && text.endsWith(`'`)
+		}
+
+		function checkLiteralInImportOrExport (node) {
+			if (!node.source) return
+
+			let literal = node.source
+
+			if (isSingleQuoted(literal)) {
+				context.report({
+					node: literal,
+					message: `Use double quotes for import/export source.`,
+					fix (fixer) {
+						let newText = `"${literal.value.replace(/"/g, `\\"`)}"`
+
+						return fixer.replaceText(literal, newText)
+					},
+				})
+			}
+		}
+
+		function checkObjectExpression (node) {
+			let properties = node.properties
+
+			let hasQuotedKey = properties.some(
+				(prop) => prop.type === `Property`
+					&& prop.key.type === `Literal`
+					&& typeof prop.key.value === `string`,
+			)
+
+			if (!hasQuotedKey) return
+
+			for (let prop of properties) {
+				if (
+					prop.type !== `Property`
+					|| prop.key.type !== `Literal`
+					|| typeof prop.key.value !== `string`
+				) continue
+
+				let key = prop.key
+
+				if (isSingleQuoted(key)) {
+					context.report({
+						node: key,
+						message: `Use double quotes for quoted object keys.`,
+						fix (fixer) {
+							let newText = `"${key.value.replace(/"/g, `\\"`)}"`
+
+							return fixer.replaceText(key, newText)
+						},
+					})
+				}
+			}
+		}
+
+		return {
+			ImportDeclaration: checkLiteralInImportOrExport,
+			ExportNamedDeclaration: checkLiteralInImportOrExport,
+			ExportAllDeclaration: checkLiteralInImportOrExport,
+			ObjectExpression: checkObjectExpression,
+		}
+	},
+}

package/lib/enough-is-enough/prefer-let/index.js

@@ -0,0 +1,74 @@
+/**
+ * @fileoverview Use `let` declarations to bind names to values
+ * @author Charles Lowell
+ */
+
+export default {
+	meta: {
+		docs: {
+			description: `Use "let" declarations to bind names to values`,
+			category: `Stylistic Issues`,
+			recommended: false,
+		},
+		fixable: `code`, // or "code" or "whitespace"
+		schema: [], // fill in your schema
+	},
+
+	create (context) {
+		let sourceCode = context.sourceCode ?? context.getSourceCode()
+
+		function getScope (node) {
+			return sourceCode.getScope ? sourceCode.getScope(node) : context.getScope()
+		}
+
+		function isGlobalScope (node) {
+			return getScope(node).type === `global`
+		}
+
+		function isModuleScope (node) {
+			return getScope(node).type === `module`
+		}
+
+		function isProgramScope (node) {
+			return getScope(node).block.type === `Program`
+		}
+
+		function isTopLevelScope (node) {
+			return isGlobalScope(node) || isModuleScope(node) || isProgramScope(node)
+		}
+
+		function isInAmbientContext (node) {
+			let current = node.parent
+			while (current) {
+				if (current.type === `TSModuleDeclaration` && current.declare === true) return true
+
+				current = current.parent
+			}
+			return false
+		}
+
+		return {
+			VariableDeclaration (node) {
+				if (node.kind === `var`) {
+					if (isInAmbientContext(node)) return
+
+					context.report({
+						message: `prefer "let" over "var" to declare value bindings`,
+						node,
+					})
+				}
+				else if (node.kind === `const` && !isTopLevelScope(node)) {
+					let constToken = sourceCode.getFirstToken(node)
+
+					context.report({
+						message: `"const" declaration outside top-level scope`,
+						node,
+						fix (fixer) {
+							return fixer.replaceText(constToken, `let`)
+						},
+					})
+				}
+			},
+		}
+	},
+}

package/lib/index.js

@@ -1,5 +1,4 @@
 import stylistic from "@stylistic/eslint-plugin"
-import eslintPluginPreferLet from "eslint-plugin-prefer-let"
 import eslintPluginSimpleImportSort from "eslint-plugin-simple-import-sort"
 
 import enoughIsEnough from "./enough-is-enough/index.js"
@@ -130,14 +129,6 @@ export default [
 			"valid-typeof": `error`,
 		},
 	},
-	{
-		plugins: {
-			"prefer-let": eslintPluginPreferLet,
-		},
-		rules: {
-			"prefer-let/prefer-let": `error`,
-		},
-	},
 	{
 		plugins: {
 			"simple-import-sort": eslintPluginSimpleImportSort,
@@ -426,6 +417,7 @@ export default [
 		rules: {
 			"enough-is-enough/no-multiline-named-imports": `error`,
 			"enough-is-enough/no-single-quotes-in-imports-and-object-keys": `error`,
+			"enough-is-enough/prefer-let": `error`,
 		},
 	},
 ]

package/package.json

@@ -1,7 +1,7 @@
 {
 	"name": "@firefoxic/eslint-config",
 	"description": "Shared config for eslint by firefoxic.",
-	"version": "6.0.0",
+	"version": "7.0.0",
 	"license": "MIT",
 	"author": {
 		"name": "Sergey Artemov",
@@ -24,24 +24,25 @@
 		"types": "./lib/index.d.ts"
 	},
 	"files": [
-		"./lib/index.d.ts",
-		"./lib/index.js"
+		"./lib/**/*.d.ts",
+		"./lib/**/*.js",
+		"!**/*.test.js"
 	],
 	"peerDependencies": {
-		"eslint": "^9.39.2"
+		"eslint": "^10.0.0"
 	},
 	"dependencies": {
-		"@stylistic/eslint-plugin": "^5.7.0",
-		"eslint-plugin-prefer-let": "^4.0.1",
+		"@stylistic/eslint-plugin": "^5.7.1",
 		"eslint-plugin-simple-import-sort": "^12.1.1",
-		"globals": "^17.0.0"
+		"globals": "^17.3.0"
 	},
 	"scripts": {
 		"help": "make help",
 		"eslint": "eslint"
 	},
 	"devDependencies": {
-		"eslint": "^9.39.2"
+		"@typescript-eslint/parser": "^8.54.0",
+		"eslint": "^10.0.0"
 	},
 	"keywords": [
 		"config",