@firebaseextensions/firestore-bigquery-change-tracker 1.1.33 → 1.1.35

package/lib/bigquery/partitioning.js

@@ -172,12 +172,12 @@ class Partitioning {
         return {};
     }
     customFieldExists(fields = []) {
-        if (!fields.length)
-            return false;
+        /** Extract the time partioning field name */
         const { timePartitioningField } = this.config;
+        /** Return based the field already exist */
         return fields.map(($) => $.name).includes(timePartitioningField);
     }
-    async shouldAddPartitioningToSchema() {
+    async shouldAddPartitioningToSchema(fields) {
         if (!this.isPartitioningEnabled()) {
             return { proceed: false, message: "Partitioning not enabled" };
         }
@@ -199,7 +199,7 @@ class Partitioning {
                 message: "Invalid partitioning and field type combination",
             };
         }
-        if (this.customFieldExists()) {
+        if (this.customFieldExists(fields)) {
             return { proceed: false, message: "Field already exists on schema" };
         }
         if (await this.isTablePartitioned()) {
@@ -211,7 +211,7 @@ class Partitioning {
         return { proceed: true, message: "" };
     }
     async addPartitioningToSchema(fields = []) {
-        const { proceed, message } = await this.shouldAddPartitioningToSchema();
+        const { proceed, message } = await this.shouldAddPartitioningToSchema(fields);
         if (!proceed) {
             functions.logger.warn(`Did not add partitioning to schema: ${message}`);
             return;

package/package.json

@@ -5,7 +5,7 @@
     "url": "github.com/firebase/extensions.git",
     "directory": "firestore-bigquery-export/firestore-bigquery-change-tracker"
   },
-  "version": "1.1.33",
+  "version": "1.1.35",
   "description": "Core change-tracker library for Cloud Firestore Collection BigQuery Exports",
   "main": "./lib/index.js",
   "scripts": {

package/lib/bigquery/utils.test.js

@@ -1,65 +0,0 @@
-"use strict";
-Object.defineProperty(exports, "__esModule", { value: true });
-const utils_1 = require("./utils");
-const logs = require("../logs");
-jest.mock("@google-cloud/bigquery");
-jest.mock("../../logs");
-const dataset = {
-    exists: jest.fn(),
-    table: jest.fn(),
-};
-const table = {
-    exists: jest.fn(),
-};
-const changelogName = "testTable";
-describe("waitForInitialization", () => {
-    beforeEach(() => {
-        jest.clearAllMocks();
-        dataset.table.mockReturnValue(table);
-    });
-    test("should successfully find the dataset and table", async () => {
-        dataset.exists.mockResolvedValue([true]);
-        table.exists.mockResolvedValue([true]);
-        const result = await (0, utils_1.waitForInitialization)({
-            dataset: dataset,
-            changelogName,
-        });
-        expect(result).toBe(table);
-        expect(dataset.exists).toHaveBeenCalledTimes(1);
-        expect(table.exists).toHaveBeenCalledTimes(1);
-    });
-    test("should fail after max attempts if table does not exist", async () => {
-        dataset.exists.mockResolvedValue([true]);
-        table.exists.mockResolvedValue([false]);
-        await expect((0, utils_1.waitForInitialization)({ dataset: dataset, changelogName }, 3)).rejects.toThrow("Initialization timed out. Dataset or table could not be verified to exist after multiple attempts.");
-        expect(dataset.exists).toHaveBeenCalledTimes(3);
-        expect(table.exists).toHaveBeenCalledTimes(3);
-    });
-    test("should handle and throw an error if dataset.exists throws", async () => {
-        const error = new Error("Access denied");
-        dataset.exists.mockRejectedValue(error);
-        await expect((0, utils_1.waitForInitialization)({
-            dataset: dataset,
-            changelogName,
-        })).rejects.toThrow("Access denied");
-        expect(logs.failedToInitializeWait).toHaveBeenCalledWith(error.message);
-    });
-    test("should handle and throw an error if table.exists throws", async () => {
-        dataset.exists.mockResolvedValue([true]);
-        const error = new Error("Table error");
-        table.exists.mockRejectedValue(error);
-        await expect((0, utils_1.waitForInitialization)({
-            dataset: dataset,
-            changelogName,
-        })).rejects.toThrow("Table error");
-        expect(logs.failedToInitializeWait).toHaveBeenCalledWith(error.message);
-    });
-    test("should handle unexpected error types gracefully", async () => {
-        dataset.exists.mockRejectedValue("String error");
-        await expect((0, utils_1.waitForInitialization)({
-            dataset: dataset,
-            changelogName,
-        })).rejects.toThrow("An unexpected error occurred");
-        expect(logs.failedToInitializeWait).toHaveBeenCalledWith("An unexpected error occurred");
-    });
-});