@firebaseextensions/firestore-bigquery-change-tracker 1.1.30 → 1.1.31

package/lib/bigquery/partitioning.js

@@ -63,10 +63,14 @@ class Partitioning {
         /* No custom config has been set, use partition value option only */
         if (hasNoCustomOptions)
             return true;
-        /* check if all options have been provided to be  */
-        return (!!timePartitioningField &&
-            !!timePartitioningFieldType &&
-            !!timePartitioningFirestoreField);
+        /* check if all valid combinations have been provided*/
+        const hasOnlyTimestamp = timePartitioningField === "timestamp" &&
+            !timePartitioningFieldType &&
+            !timePartitioningFirestoreField;
+        return (hasOnlyTimestamp ||
+            (!!timePartitioningField &&
+                !!timePartitioningFieldType &&
+                !!timePartitioningFirestoreField));
     }
     hasValidTimePartitionOption() {
         const { timePartitioning } = this.config;
@@ -180,53 +184,53 @@ class Partitioning {
     async addPartitioningToSchema(fields = []) {
         /** check if class has valid table reference */
         if (!this.hasValidTableReference())
-            return Promise.resolve();
+            return;
         /** return if table is already partitioned **/
         if (await this.isTablePartitioned())
-            return Promise.resolve();
+            return;
         /** return if an invalid partition type has been requested**/
         if (!this.hasValidTimePartitionType())
-            return Promise.resolve();
+            return;
         /** Return if invalid partitioning and field type combination */
         if (this.hasHourAndDatePartitionConfig())
-            return Promise.resolve();
+            return;
         /** return if an invalid partition type has been requested**/
         if (!this.hasValidCustomPartitionConfig())
-            return Promise.resolve();
+            return;
         /** return if an invalid partition type has been requested**/
         if (!this.hasValidCustomPartitionConfig())
-            return Promise.resolve();
+            return;
         /** update fields with new schema option ** */
         if (!this.hasValidTimePartitionOption())
-            return Promise.resolve();
+            return;
         /* Check if partition field has been provided */
         if (!this.config.timePartitioningField)
-            return Promise.resolve();
+            return;
         // if (await !this.hasExistingSchema) return Promise.resolve();
         // Field already exists on schema, skip
         if (this.customFieldExists(fields))
-            return Promise.resolve();
+            return;
         fields.push((0, schema_1.getNewPartitionField)(this.config));
         /** log successful addition of partition column */
         logs.addPartitionFieldColumn(this.table.id, this.config.timePartitioningField);
-        return Promise.resolve();
+        return;
     }
     async updateTableMetadata(options) {
         /** return if table is already partitioned **/
         if (await this.isTablePartitioned())
-            return Promise.resolve();
+            return;
         /** return if an invalid partition type has been requested**/
         if (!this.hasValidTimePartitionType())
-            return Promise.resolve();
+            return;
         /** update fields with new schema option ** */
         if (!this.hasValidTimePartitionOption())
-            return Promise.resolve();
+            return;
         /** Return if invalid partitioning and field type combination */
         if (this.hasHourAndDatePartitionConfig())
-            return Promise.resolve();
+            return;
         /** return if an invalid partition type has been requested**/
         if (!this.hasValidCustomPartitionConfig())
-            return Promise.resolve();
+            return;
         // if (await !this.hasExistingSchema) return Promise.resolve();
         if (this.config.timePartitioning) {
             options.timePartitioning = { type: this.config.timePartitioning };

package/package.json

@@ -5,7 +5,7 @@
     "url": "github.com/firebase/extensions.git",
     "directory": "firestore-bigquery-export/firestore-bigquery-change-tracker"
   },
-  "version": "1.1.30",
+  "version": "1.1.31",
   "description": "Core change-tracker library for Cloud Firestore Collection BigQuery Exports",
   "main": "./lib/index.js",
   "scripts": {