@firebase-function-kits/bigquery-firestore-export 0.0.2-rc.4 → 0.0.2-rc.5

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@firebase-function-kits/bigquery-firestore-export",
-  "version": "0.0.2-rc.4",
+  "version": "0.0.2-rc.5",
   "repository": {
     "type": "git",
     "url": "https://github.com/firebase/extensions.git",
@@ -35,15 +35,19 @@
     "@firebase/app": "^0.16.0",
     "@google-cloud/bigquery": "^8.3.1",
     "@google-cloud/bigquery-data-transfer": "^5.0.1",
-    "@google-cloud/pubsub": "^4.11.0",
-    "firebase-admin": "^14.1.0",
-    "firebase-functions": "^7.3.3-rc.0"
+    "@google-cloud/pubsub": "^4.11.0"
   },
   "devDependencies": {
+    "firebase-admin": "^14.4.0",
+    "firebase-functions": "^7.3.3-rc.3",
     "typescript": "^5.9.3",
     "vitest": "^4.1.10"
   },
   "overrides": {
     "uuid@9.0.1": "11.1.1"
+  },
+  "peerDependencies": {
+    "firebase-admin": "^14.4.0",
+    "firebase-functions": "^7.3.3-rc.3"
   }
 }

package/src/dts.ts

@@ -194,6 +194,11 @@ export async function constructUpdateTransferConfigRequest(
     updatedFields.partitioning_field.stringValue = newPartitioningField;
   }
 
+  if (config.displayName !== transferConfig.displayName) {
+    updateMask.push("display_name");
+    updatedConfig.displayName = config.displayName;
+  }
+
   if (config.schedule !== transferConfig.schedule) {
     updateMask.push("schedule");
     updatedConfig.schedule = config.schedule;

package/tests/dts.test.ts

@@ -85,6 +85,7 @@ describe("constructUpdateTransferConfigRequest", () => {
     const client = clientWithTransferConfig({
       name: "projects/p/locations/us/transferConfigs/c",
       destinationDatasetId: "analytics",
+      displayName: "Users export",
       schedule: "every 24 hours",
       notificationPubsubTopic:
         "projects/test-project/topics/kit-users-export-processMessages",
@@ -108,6 +109,63 @@ describe("constructUpdateTransferConfigRequest", () => {
     expect(request.updateMask?.paths).toEqual(["params"]);
   });
 
+  test("updates the display name when it changed", async () => {
+    const client = clientWithTransferConfig({
+      name: "projects/p/locations/us/transferConfigs/c",
+      destinationDatasetId: "analytics",
+      displayName: "Old export name",
+      schedule: "every 24 hours",
+      notificationPubsubTopic:
+        "projects/test-project/topics/kit-users-export-processMessages",
+      params: {
+        fields: {
+          query: { stringValue: config.queryString },
+          destination_table_name_template: {
+            stringValue: 'users_{run_time|"%H%M%S"}',
+          },
+          partitioning_field: { stringValue: "created_at" },
+        },
+      },
+    });
+
+    const request = await constructUpdateTransferConfigRequest(
+      client,
+      "projects/p/locations/us/transferConfigs/c",
+      config
+    );
+
+    expect(request.updateMask?.paths).toEqual(["display_name"]);
+    expect(request.transferConfig?.displayName).toBe("Users export");
+  });
+
+  test("leaves the display name out of the mask when unchanged", async () => {
+    const client = clientWithTransferConfig({
+      name: "projects/p/locations/us/transferConfigs/c",
+      destinationDatasetId: "analytics",
+      displayName: "Users export",
+      schedule: "every 12 hours",
+      notificationPubsubTopic:
+        "projects/test-project/topics/kit-users-export-processMessages",
+      params: {
+        fields: {
+          query: { stringValue: config.queryString },
+          destination_table_name_template: {
+            stringValue: 'users_{run_time|"%H%M%S"}',
+          },
+          partitioning_field: { stringValue: "created_at" },
+        },
+      },
+    });
+
+    const request = await constructUpdateTransferConfigRequest(
+      client,
+      "projects/p/locations/us/transferConfigs/c",
+      config
+    );
+
+    expect(request.updateMask?.paths).toEqual(["schedule"]);
+  });
+
   test("rejects clearing an existing partitioning field", async () => {
     const client = clientWithTransferConfig({
       name: "projects/p/locations/us/transferConfigs/c",