@fintekkers/ledger-models 0.4.3 → 0.4.4

package/node/fintekkers/requests/position/query_position_request.packed_enum_v4.test.d.ts

@@ -0,0 +1 @@
+export {};

package/node/fintekkers/requests/position/query_position_request.packed_enum_v4.test.js

@@ -0,0 +1,61 @@
+"use strict";
+// Regression guard for the v4-runtime decode path on packed-enum fields.
+//
+// google-protobuf v4 removed `BinaryReader.prototype.readPackedEnum`. The
+// bundled protoc 3.19.1 generator emits decode code that calls it on every
+// `repeated <enum>` field. compile.sh substitutes the call with the v4
+// `readPackableEnumInto(arr)` equivalent. This test exercises that path
+// end-to-end so a regen-without-patch (or a sed-rule drift) trips CI before
+// shipping.
+//
+// Repro: positions UI hit "reader.readPackedEnum is not a function" on every
+// `/data/positions` request because the QueryPositionRequestProto encode/decode
+// round-trip needed the packed-enum decoder. (second-brain#292)
+Object.defineProperty(exports, "__esModule", { value: true });
+const google_protobuf_1 = require("google-protobuf");
+const query_position_request_pb_1 = require("../../../fintekkers/requests/position/query_position_request_pb");
+const field_pb_1 = require("../../../fintekkers/models/position/field_pb");
+const measure_pb_1 = require("../../../fintekkers/models/position/measure_pb");
+describe("packed-enum decode under google-protobuf v4 (second-brain#292)", () => {
+    test("v4 BinaryReader does NOT expose readPackedEnum (sentinel for the bug)", () => {
+        // If a future google-protobuf release re-adds readPackedEnum, this
+        // assertion flips and the regen can drop the post-process patch.
+        expect(typeof google_protobuf_1.BinaryReader.prototype.readPackedEnum).toBe("undefined");
+    });
+    test("v4 BinaryReader exposes readPackableEnumInto (the replacement target)", () => {
+        expect(typeof google_protobuf_1.BinaryReader.prototype.readPackableEnumInto).toBe("function");
+    });
+    test("QueryPositionRequestProto round-trips packed repeated FieldProto + MeasureProto", () => {
+        const req = new query_position_request_pb_1.QueryPositionRequestProto();
+        req.setFieldsList([
+            field_pb_1.FieldProto.SECURITY,
+            field_pb_1.FieldProto.PORTFOLIO,
+            field_pb_1.FieldProto.AS_OF,
+        ]);
+        req.setMeasuresList([
+            measure_pb_1.MeasureProto.MARKET_VALUE,
+            measure_pb_1.MeasureProto.DIRECTED_QUANTITY,
+        ]);
+        // Encode → bytes → decode. Without the v4-compat substitution this
+        // throws `reader.readPackedEnum is not a function`.
+        const bytes = req.serializeBinary();
+        const decoded = query_position_request_pb_1.QueryPositionRequestProto.deserializeBinary(bytes);
+        expect(decoded.getFieldsList()).toEqual([
+            field_pb_1.FieldProto.SECURITY,
+            field_pb_1.FieldProto.PORTFOLIO,
+            field_pb_1.FieldProto.AS_OF,
+        ]);
+        expect(decoded.getMeasuresList()).toEqual([
+            measure_pb_1.MeasureProto.MARKET_VALUE,
+            measure_pb_1.MeasureProto.DIRECTED_QUANTITY,
+        ]);
+    });
+    test("empty repeated enum lists round-trip cleanly", () => {
+        const req = new query_position_request_pb_1.QueryPositionRequestProto();
+        const bytes = req.serializeBinary();
+        const decoded = query_position_request_pb_1.QueryPositionRequestProto.deserializeBinary(bytes);
+        expect(decoded.getFieldsList()).toEqual([]);
+        expect(decoded.getMeasuresList()).toEqual([]);
+    });
+});
+//# sourceMappingURL=query_position_request.packed_enum_v4.test.js.map

package/node/fintekkers/requests/position/query_position_request.packed_enum_v4.test.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"query_position_request.packed_enum_v4.test.js","sourceRoot":"","sources":["query_position_request.packed_enum_v4.test.ts"],"names":[],"mappings":";AAAA,yEAAyE;AACzE,EAAE;AACF,0EAA0E;AAC1E,2EAA2E;AAC3E,uEAAuE;AACvE,wEAAwE;AACxE,4EAA4E;AAC5E,YAAY;AACZ,EAAE;AACF,6EAA6E;AAC7E,gFAAgF;AAChF,gEAAgE;;AAEhE,qDAA+C;AAC/C,+GAA4G;AAC5G,2EAA0E;AAC1E,+EAA8E;AAE9E,QAAQ,CAAC,gEAAgE,EAAE,GAAG,EAAE;IAC5E,IAAI,CAAC,uEAAuE,EAAE,GAAG,EAAE;QAC/E,mEAAmE;QACnE,iEAAiE;QACjE,MAAM,CAAC,OAAQ,8BAAY,CAAC,SAAiB,CAAC,cAAc,CAAC,CAAC,IAAI,CAAC,WAAW,CAAC,CAAC;IACpF,CAAC,CAAC,CAAC;IAEH,IAAI,CAAC,uEAAuE,EAAE,GAAG,EAAE;QAC/E,MAAM,CAAC,OAAQ,8BAAY,CAAC,SAAiB,CAAC,oBAAoB,CAAC,CAAC,IAAI,CAAC,UAAU,CAAC,CAAC;IACzF,CAAC,CAAC,CAAC;IAEH,IAAI,CAAC,iFAAiF,EAAE,GAAG,EAAE;QACzF,MAAM,GAAG,GAAG,IAAI,qDAAyB,EAAE,CAAC;QAC5C,GAAG,CAAC,aAAa,CAAC;YACd,qBAAU,CAAC,QAAQ;YACnB,qBAAU,CAAC,SAAS;YACpB,qBAAU,CAAC,KAAK;SACnB,CAAC,CAAC;QACH,GAAG,CAAC,eAAe,CAAC;YAChB,yBAAY,CAAC,YAAY;YACzB,yBAAY,CAAC,iBAAiB;SACjC,CAAC,CAAC;QAEH,mEAAmE;QACnE,oDAAoD;QACpD,MAAM,KAAK,GAAG,GAAG,CAAC,eAAe,EAAE,CAAC;QACpC,MAAM,OAAO,GAAG,qDAAyB,CAAC,iBAAiB,CAAC,KAAK,CAAC,CAAC;QAEnE,MAAM,CAAC,OAAO,CAAC,aAAa,EAAE,CAAC,CAAC,OAAO,CAAC;YACpC,qBAAU,CAAC,QAAQ;YACnB,qBAAU,CAAC,SAAS;YACpB,qBAAU,CAAC,KAAK;SACnB,CAAC,CAAC;QACH,MAAM,CAAC,OAAO,CAAC,eAAe,EAAE,CAAC,CAAC,OAAO,CAAC;YACtC,yBAAY,CAAC,YAAY;YACzB,yBAAY,CAAC,iBAAiB;SACjC,CAAC,CAAC;IACP,CAAC,CAAC,CAAC;IAEH,IAAI,CAAC,8CAA8C,EAAE,GAAG,EAAE;QACtD,MAAM,GAAG,GAAG,IAAI,qDAAyB,EAAE,CAAC;QAC5C,MAAM,KAAK,GAAG,GAAG,CAAC,eAAe,EAAE,CAAC;QACpC,MAAM,OAAO,GAAG,qDAAyB,CAAC,iBAAiB,CAAC,KAAK,CAAC,CAAC;QACnE,MAAM,CAAC,OAAO,CAAC,aAAa,EAAE,CAAC,CAAC,OAAO,CAAC,EAAE,CAAC,CAAC;QAC5C,MAAM,CAAC,OAAO,CAAC,eAAe,EAAE,CAAC,CAAC,OAAO,CAAC,EAAE,CAAC,CAAC;IAClD,CAAC,CAAC,CAAC;AACP,CAAC,CAAC,CAAC"}

package/node/fintekkers/requests/position/query_position_request.packed_enum_v4.test.ts

@@ -0,0 +1,65 @@
+// Regression guard for the v4-runtime decode path on packed-enum fields.
+//
+// google-protobuf v4 removed `BinaryReader.prototype.readPackedEnum`. The
+// bundled protoc 3.19.1 generator emits decode code that calls it on every
+// `repeated <enum>` field. compile.sh substitutes the call with the v4
+// `readPackableEnumInto(arr)` equivalent. This test exercises that path
+// end-to-end so a regen-without-patch (or a sed-rule drift) trips CI before
+// shipping.
+//
+// Repro: positions UI hit "reader.readPackedEnum is not a function" on every
+// `/data/positions` request because the QueryPositionRequestProto encode/decode
+// round-trip needed the packed-enum decoder. (second-brain#292)
+
+import { BinaryReader } from "google-protobuf";
+import { QueryPositionRequestProto } from "../../../fintekkers/requests/position/query_position_request_pb";
+import { FieldProto } from "../../../fintekkers/models/position/field_pb";
+import { MeasureProto } from "../../../fintekkers/models/position/measure_pb";
+
+describe("packed-enum decode under google-protobuf v4 (second-brain#292)", () => {
+    test("v4 BinaryReader does NOT expose readPackedEnum (sentinel for the bug)", () => {
+        // If a future google-protobuf release re-adds readPackedEnum, this
+        // assertion flips and the regen can drop the post-process patch.
+        expect(typeof (BinaryReader.prototype as any).readPackedEnum).toBe("undefined");
+    });
+
+    test("v4 BinaryReader exposes readPackableEnumInto (the replacement target)", () => {
+        expect(typeof (BinaryReader.prototype as any).readPackableEnumInto).toBe("function");
+    });
+
+    test("QueryPositionRequestProto round-trips packed repeated FieldProto + MeasureProto", () => {
+        const req = new QueryPositionRequestProto();
+        req.setFieldsList([
+            FieldProto.SECURITY,
+            FieldProto.PORTFOLIO,
+            FieldProto.AS_OF,
+        ]);
+        req.setMeasuresList([
+            MeasureProto.MARKET_VALUE,
+            MeasureProto.DIRECTED_QUANTITY,
+        ]);
+
+        // Encode → bytes → decode. Without the v4-compat substitution this
+        // throws `reader.readPackedEnum is not a function`.
+        const bytes = req.serializeBinary();
+        const decoded = QueryPositionRequestProto.deserializeBinary(bytes);
+
+        expect(decoded.getFieldsList()).toEqual([
+            FieldProto.SECURITY,
+            FieldProto.PORTFOLIO,
+            FieldProto.AS_OF,
+        ]);
+        expect(decoded.getMeasuresList()).toEqual([
+            MeasureProto.MARKET_VALUE,
+            MeasureProto.DIRECTED_QUANTITY,
+        ]);
+    });
+
+    test("empty repeated enum lists round-trip cleanly", () => {
+        const req = new QueryPositionRequestProto();
+        const bytes = req.serializeBinary();
+        const decoded = QueryPositionRequestProto.deserializeBinary(bytes);
+        expect(decoded.getFieldsList()).toEqual([]);
+        expect(decoded.getMeasuresList()).toEqual([]);
+    });
+});

package/node/fintekkers/requests/position/query_position_request_pb.js

@@ -160,13 +160,13 @@ proto.fintekkers.requests.position.QueryPositionRequestProto.deserializeBinaryFr
       msg.setPositionView(value);
       break;
     case 30:
-      var values = /** @type {!Array<!proto.fintekkers.models.position.FieldProto>} */ (reader.isDelimited() ? reader.readPackedEnum() : [reader.readEnum()]);
+      var values = /** @type {!Array<!proto.fintekkers.models.position.FieldProto>} */ (reader.isDelimited() ? (function(){var arr=[];reader.readPackableEnumInto(arr);return arr;})() : [reader.readEnum()]);
       for (var i = 0; i < values.length; i++) {
         msg.addFields(values[i]);
       }
       break;
     case 31:
-      var values = /** @type {!Array<!proto.fintekkers.models.position.MeasureProto>} */ (reader.isDelimited() ? reader.readPackedEnum() : [reader.readEnum()]);
+      var values = /** @type {!Array<!proto.fintekkers.models.position.MeasureProto>} */ (reader.isDelimited() ? (function(){var arr=[];reader.readPackableEnumInto(arr);return arr;})() : [reader.readEnum()]);
       for (var i = 0; i < values.length; i++) {
         msg.addMeasures(values[i]);
       }

package/node/fintekkers/requests/security/get_fields_response_pb.js

@@ -132,7 +132,7 @@ proto.fintekkers.requests.security.GetFieldsResponseProto.deserializeBinaryFromR
       msg.setVersion(value);
       break;
     case 10:
-      var values = /** @type {!Array<!proto.fintekkers.models.position.FieldProto>} */ (reader.isDelimited() ? reader.readPackedEnum() : [reader.readEnum()]);
+      var values = /** @type {!Array<!proto.fintekkers.models.position.FieldProto>} */ (reader.isDelimited() ? (function(){var arr=[];reader.readPackableEnumInto(arr);return arr;})() : [reader.readEnum()]);
       for (var i = 0; i < values.length; i++) {
         msg.addFields(values[i]);
       }

package/node/fintekkers/requests/valuation/curve_request_pb.js

@@ -477,7 +477,7 @@ proto.fintekkers.requests.valuation.CurveRequestProto.deserializeBinaryFromReade
       msg.setAsofDatetime(value);
       break;
     case 20:
-      var values = /** @type {!Array<!proto.fintekkers.models.position.MeasureProto>} */ (reader.isDelimited() ? reader.readPackedEnum() : [reader.readEnum()]);
+      var values = /** @type {!Array<!proto.fintekkers.models.position.MeasureProto>} */ (reader.isDelimited() ? (function(){var arr=[];reader.readPackableEnumInto(arr);return arr;})() : [reader.readEnum()]);
       for (var i = 0; i < values.length; i++) {
         msg.addCurveTypes(values[i]);
       }

package/node/fintekkers/requests/valuation/valuation_request_pb.js

@@ -156,7 +156,7 @@ proto.fintekkers.requests.valuation.ValuationRequestProto.deserializeBinaryFromR
       msg.setOperationType(value);
       break;
     case 30:
-      var values = /** @type {!Array<!proto.fintekkers.models.position.MeasureProto>} */ (reader.isDelimited() ? reader.readPackedEnum() : [reader.readEnum()]);
+      var values = /** @type {!Array<!proto.fintekkers.models.position.MeasureProto>} */ (reader.isDelimited() ? (function(){var arr=[];reader.readPackableEnumInto(arr);return arr;})() : [reader.readEnum()]);
       for (var i = 0; i < values.length; i++) {
         msg.addMeasures(values[i]);
       }

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@fintekkers/ledger-models",
   "todo": "Replace the version with build script version number",
-  "version": "0.4.3",
+  "version": "0.4.4",
   "description": "ledger model protos ",
   "authors": [
     "David Doherty",