@fintekkers/ledger-models 0.4.2 → 0.4.4

package/node/fintekkers/requests/position/query_position_request.packed_enum_v4.test.d.ts

@@ -0,0 +1 @@
+export {};

package/node/fintekkers/requests/position/query_position_request.packed_enum_v4.test.js

@@ -0,0 +1,61 @@
+"use strict";
+// Regression guard for the v4-runtime decode path on packed-enum fields.
+//
+// google-protobuf v4 removed `BinaryReader.prototype.readPackedEnum`. The
+// bundled protoc 3.19.1 generator emits decode code that calls it on every
+// `repeated <enum>` field. compile.sh substitutes the call with the v4
+// `readPackableEnumInto(arr)` equivalent. This test exercises that path
+// end-to-end so a regen-without-patch (or a sed-rule drift) trips CI before
+// shipping.
+//
+// Repro: positions UI hit "reader.readPackedEnum is not a function" on every
+// `/data/positions` request because the QueryPositionRequestProto encode/decode
+// round-trip needed the packed-enum decoder. (second-brain#292)
+Object.defineProperty(exports, "__esModule", { value: true });
+const google_protobuf_1 = require("google-protobuf");
+const query_position_request_pb_1 = require("../../../fintekkers/requests/position/query_position_request_pb");
+const field_pb_1 = require("../../../fintekkers/models/position/field_pb");
+const measure_pb_1 = require("../../../fintekkers/models/position/measure_pb");
+describe("packed-enum decode under google-protobuf v4 (second-brain#292)", () => {
+    test("v4 BinaryReader does NOT expose readPackedEnum (sentinel for the bug)", () => {
+        // If a future google-protobuf release re-adds readPackedEnum, this
+        // assertion flips and the regen can drop the post-process patch.
+        expect(typeof google_protobuf_1.BinaryReader.prototype.readPackedEnum).toBe("undefined");
+    });
+    test("v4 BinaryReader exposes readPackableEnumInto (the replacement target)", () => {
+        expect(typeof google_protobuf_1.BinaryReader.prototype.readPackableEnumInto).toBe("function");
+    });
+    test("QueryPositionRequestProto round-trips packed repeated FieldProto + MeasureProto", () => {
+        const req = new query_position_request_pb_1.QueryPositionRequestProto();
+        req.setFieldsList([
+            field_pb_1.FieldProto.SECURITY,
+            field_pb_1.FieldProto.PORTFOLIO,
+            field_pb_1.FieldProto.AS_OF,
+        ]);
+        req.setMeasuresList([
+            measure_pb_1.MeasureProto.MARKET_VALUE,
+            measure_pb_1.MeasureProto.DIRECTED_QUANTITY,
+        ]);
+        // Encode → bytes → decode. Without the v4-compat substitution this
+        // throws `reader.readPackedEnum is not a function`.
+        const bytes = req.serializeBinary();
+        const decoded = query_position_request_pb_1.QueryPositionRequestProto.deserializeBinary(bytes);
+        expect(decoded.getFieldsList()).toEqual([
+            field_pb_1.FieldProto.SECURITY,
+            field_pb_1.FieldProto.PORTFOLIO,
+            field_pb_1.FieldProto.AS_OF,
+        ]);
+        expect(decoded.getMeasuresList()).toEqual([
+            measure_pb_1.MeasureProto.MARKET_VALUE,
+            measure_pb_1.MeasureProto.DIRECTED_QUANTITY,
+        ]);
+    });
+    test("empty repeated enum lists round-trip cleanly", () => {
+        const req = new query_position_request_pb_1.QueryPositionRequestProto();
+        const bytes = req.serializeBinary();
+        const decoded = query_position_request_pb_1.QueryPositionRequestProto.deserializeBinary(bytes);
+        expect(decoded.getFieldsList()).toEqual([]);
+        expect(decoded.getMeasuresList()).toEqual([]);
+    });
+});
+//# sourceMappingURL=query_position_request.packed_enum_v4.test.js.map

package/node/fintekkers/requests/position/query_position_request.packed_enum_v4.test.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"query_position_request.packed_enum_v4.test.js","sourceRoot":"","sources":["query_position_request.packed_enum_v4.test.ts"],"names":[],"mappings":";AAAA,yEAAyE;AACzE,EAAE;AACF,0EAA0E;AAC1E,2EAA2E;AAC3E,uEAAuE;AACvE,wEAAwE;AACxE,4EAA4E;AAC5E,YAAY;AACZ,EAAE;AACF,6EAA6E;AAC7E,gFAAgF;AAChF,gEAAgE;;AAEhE,qDAA+C;AAC/C,+GAA4G;AAC5G,2EAA0E;AAC1E,+EAA8E;AAE9E,QAAQ,CAAC,gEAAgE,EAAE,GAAG,EAAE;IAC5E,IAAI,CAAC,uEAAuE,EAAE,GAAG,EAAE;QAC/E,mEAAmE;QACnE,iEAAiE;QACjE,MAAM,CAAC,OAAQ,8BAAY,CAAC,SAAiB,CAAC,cAAc,CAAC,CAAC,IAAI,CAAC,WAAW,CAAC,CAAC;IACpF,CAAC,CAAC,CAAC;IAEH,IAAI,CAAC,uEAAuE,EAAE,GAAG,EAAE;QAC/E,MAAM,CAAC,OAAQ,8BAAY,CAAC,SAAiB,CAAC,oBAAoB,CAAC,CAAC,IAAI,CAAC,UAAU,CAAC,CAAC;IACzF,CAAC,CAAC,CAAC;IAEH,IAAI,CAAC,iFAAiF,EAAE,GAAG,EAAE;QACzF,MAAM,GAAG,GAAG,IAAI,qDAAyB,EAAE,CAAC;QAC5C,GAAG,CAAC,aAAa,CAAC;YACd,qBAAU,CAAC,QAAQ;YACnB,qBAAU,CAAC,SAAS;YACpB,qBAAU,CAAC,KAAK;SACnB,CAAC,CAAC;QACH,GAAG,CAAC,eAAe,CAAC;YAChB,yBAAY,CAAC,YAAY;YACzB,yBAAY,CAAC,iBAAiB;SACjC,CAAC,CAAC;QAEH,mEAAmE;QACnE,oDAAoD;QACpD,MAAM,KAAK,GAAG,GAAG,CAAC,eAAe,EAAE,CAAC;QACpC,MAAM,OAAO,GAAG,qDAAyB,CAAC,iBAAiB,CAAC,KAAK,CAAC,CAAC;QAEnE,MAAM,CAAC,OAAO,CAAC,aAAa,EAAE,CAAC,CAAC,OAAO,CAAC;YACpC,qBAAU,CAAC,QAAQ;YACnB,qBAAU,CAAC,SAAS;YACpB,qBAAU,CAAC,KAAK;SACnB,CAAC,CAAC;QACH,MAAM,CAAC,OAAO,CAAC,eAAe,EAAE,CAAC,CAAC,OAAO,CAAC;YACtC,yBAAY,CAAC,YAAY;YACzB,yBAAY,CAAC,iBAAiB;SACjC,CAAC,CAAC;IACP,CAAC,CAAC,CAAC;IAEH,IAAI,CAAC,8CAA8C,EAAE,GAAG,EAAE;QACtD,MAAM,GAAG,GAAG,IAAI,qDAAyB,EAAE,CAAC;QAC5C,MAAM,KAAK,GAAG,GAAG,CAAC,eAAe,EAAE,CAAC;QACpC,MAAM,OAAO,GAAG,qDAAyB,CAAC,iBAAiB,CAAC,KAAK,CAAC,CAAC;QACnE,MAAM,CAAC,OAAO,CAAC,aAAa,EAAE,CAAC,CAAC,OAAO,CAAC,EAAE,CAAC,CAAC;QAC5C,MAAM,CAAC,OAAO,CAAC,eAAe,EAAE,CAAC,CAAC,OAAO,CAAC,EAAE,CAAC,CAAC;IAClD,CAAC,CAAC,CAAC;AACP,CAAC,CAAC,CAAC"}

package/node/fintekkers/requests/position/query_position_request.packed_enum_v4.test.ts

@@ -0,0 +1,65 @@
+// Regression guard for the v4-runtime decode path on packed-enum fields.
+//
+// google-protobuf v4 removed `BinaryReader.prototype.readPackedEnum`. The
+// bundled protoc 3.19.1 generator emits decode code that calls it on every
+// `repeated <enum>` field. compile.sh substitutes the call with the v4
+// `readPackableEnumInto(arr)` equivalent. This test exercises that path
+// end-to-end so a regen-without-patch (or a sed-rule drift) trips CI before
+// shipping.
+//
+// Repro: positions UI hit "reader.readPackedEnum is not a function" on every
+// `/data/positions` request because the QueryPositionRequestProto encode/decode
+// round-trip needed the packed-enum decoder. (second-brain#292)
+
+import { BinaryReader } from "google-protobuf";
+import { QueryPositionRequestProto } from "../../../fintekkers/requests/position/query_position_request_pb";
+import { FieldProto } from "../../../fintekkers/models/position/field_pb";
+import { MeasureProto } from "../../../fintekkers/models/position/measure_pb";
+
+describe("packed-enum decode under google-protobuf v4 (second-brain#292)", () => {
+    test("v4 BinaryReader does NOT expose readPackedEnum (sentinel for the bug)", () => {
+        // If a future google-protobuf release re-adds readPackedEnum, this
+        // assertion flips and the regen can drop the post-process patch.
+        expect(typeof (BinaryReader.prototype as any).readPackedEnum).toBe("undefined");
+    });
+
+    test("v4 BinaryReader exposes readPackableEnumInto (the replacement target)", () => {
+        expect(typeof (BinaryReader.prototype as any).readPackableEnumInto).toBe("function");
+    });
+
+    test("QueryPositionRequestProto round-trips packed repeated FieldProto + MeasureProto", () => {
+        const req = new QueryPositionRequestProto();
+        req.setFieldsList([
+            FieldProto.SECURITY,
+            FieldProto.PORTFOLIO,
+            FieldProto.AS_OF,
+        ]);
+        req.setMeasuresList([
+            MeasureProto.MARKET_VALUE,
+            MeasureProto.DIRECTED_QUANTITY,
+        ]);
+
+        // Encode → bytes → decode. Without the v4-compat substitution this
+        // throws `reader.readPackedEnum is not a function`.
+        const bytes = req.serializeBinary();
+        const decoded = QueryPositionRequestProto.deserializeBinary(bytes);
+
+        expect(decoded.getFieldsList()).toEqual([
+            FieldProto.SECURITY,
+            FieldProto.PORTFOLIO,
+            FieldProto.AS_OF,
+        ]);
+        expect(decoded.getMeasuresList()).toEqual([
+            MeasureProto.MARKET_VALUE,
+            MeasureProto.DIRECTED_QUANTITY,
+        ]);
+    });
+
+    test("empty repeated enum lists round-trip cleanly", () => {
+        const req = new QueryPositionRequestProto();
+        const bytes = req.serializeBinary();
+        const decoded = QueryPositionRequestProto.deserializeBinary(bytes);
+        expect(decoded.getFieldsList()).toEqual([]);
+        expect(decoded.getMeasuresList()).toEqual([]);
+    });
+});

package/node/fintekkers/requests/position/query_position_request_pb.js

@@ -160,13 +160,13 @@ proto.fintekkers.requests.position.QueryPositionRequestProto.deserializeBinaryFr
       msg.setPositionView(value);
       break;
     case 30:
-      var values = /** @type {!Array<!proto.fintekkers.models.position.FieldProto>} */ (reader.isDelimited() ? reader.readPackedEnum() : [reader.readEnum()]);
+      var values = /** @type {!Array<!proto.fintekkers.models.position.FieldProto>} */ (reader.isDelimited() ? (function(){var arr=[];reader.readPackableEnumInto(arr);return arr;})() : [reader.readEnum()]);
       for (var i = 0; i < values.length; i++) {
         msg.addFields(values[i]);
       }
       break;
     case 31:
-      var values = /** @type {!Array<!proto.fintekkers.models.position.MeasureProto>} */ (reader.isDelimited() ? reader.readPackedEnum() : [reader.readEnum()]);
+      var values = /** @type {!Array<!proto.fintekkers.models.position.MeasureProto>} */ (reader.isDelimited() ? (function(){var arr=[];reader.readPackableEnumInto(arr);return arr;})() : [reader.readEnum()]);
       for (var i = 0; i < values.length; i++) {
         msg.addMeasures(values[i]);
       }

package/node/fintekkers/requests/security/get_fields_response_pb.js

@@ -132,7 +132,7 @@ proto.fintekkers.requests.security.GetFieldsResponseProto.deserializeBinaryFromR
       msg.setVersion(value);
       break;
     case 10:
-      var values = /** @type {!Array<!proto.fintekkers.models.position.FieldProto>} */ (reader.isDelimited() ? reader.readPackedEnum() : [reader.readEnum()]);
+      var values = /** @type {!Array<!proto.fintekkers.models.position.FieldProto>} */ (reader.isDelimited() ? (function(){var arr=[];reader.readPackableEnumInto(arr);return arr;})() : [reader.readEnum()]);
       for (var i = 0; i < values.length; i++) {
         msg.addFields(values[i]);
       }

package/node/fintekkers/requests/valuation/curve_request_pb.js

@@ -477,7 +477,7 @@ proto.fintekkers.requests.valuation.CurveRequestProto.deserializeBinaryFromReade
       msg.setAsofDatetime(value);
       break;
     case 20:
-      var values = /** @type {!Array<!proto.fintekkers.models.position.MeasureProto>} */ (reader.isDelimited() ? reader.readPackedEnum() : [reader.readEnum()]);
+      var values = /** @type {!Array<!proto.fintekkers.models.position.MeasureProto>} */ (reader.isDelimited() ? (function(){var arr=[];reader.readPackableEnumInto(arr);return arr;})() : [reader.readEnum()]);
       for (var i = 0; i < values.length; i++) {
         msg.addCurveTypes(values[i]);
       }

package/node/fintekkers/requests/valuation/valuation_request_pb.js

@@ -156,7 +156,7 @@ proto.fintekkers.requests.valuation.ValuationRequestProto.deserializeBinaryFromR
       msg.setOperationType(value);
       break;
     case 30:
-      var values = /** @type {!Array<!proto.fintekkers.models.position.MeasureProto>} */ (reader.isDelimited() ? reader.readPackedEnum() : [reader.readEnum()]);
+      var values = /** @type {!Array<!proto.fintekkers.models.position.MeasureProto>} */ (reader.isDelimited() ? (function(){var arr=[];reader.readPackableEnumInto(arr);return arr;})() : [reader.readEnum()]);
       for (var i = 0; i < values.length; i++) {
         msg.addMeasures(values[i]);
       }

package/node/wrappers/models/security/BondSecurity.d.ts

@@ -1,8 +1,6 @@
 import Security from './security';
 import { SecurityProto, BondDetailsProto } from '../../../fintekkers/models/security/security_pb';
 import { DecimalValueProto } from '../../../fintekkers/models/util/decimal_value_pb';
-import { LocalDateProto } from '../../../fintekkers/models/util/local_date_pb';
-import { LocalDate } from '../utils/date';
 import { CouponFrequency } from './coupon_frequency';
 import { CouponType } from './coupon_type';
 import { Tenor } from './term';
@@ -19,15 +17,9 @@ export interface BondPricerInputs {
     couponRate: Decimal;
     couponType: CouponTypeProto;
     couponFrequency: CouponFrequencyProto;
-    issueDate: LocalDate;
-    maturityDate: LocalDate;
+    issueDate: Date;
+    maturityDate: Date;
 }
-/**
- * Build a LocalDateProto from a LocalDate wrapper. Exported so subclass
- * builders (TIPSBond, FloatingRateNote) can re-use it without poking at
- * LocalDate's proto privately.
- */
-export declare function localDateToProto(d: LocalDate): LocalDateProto;
 /** Build a DecimalValueProto from a Decimal. */
 export declare function decimalToProto(v: Decimal): DecimalValueProto;
 /**
@@ -50,11 +42,11 @@ declare class BondSecurity extends Security {
      * This method handles month and year boundaries correctly.
      */
     private calculatePeriod;
-    getCouponRate(): DecimalValueProto;
-    getFaceValue(): DecimalValueProto;
+    getCouponRate(): Decimal | null;
+    getFaceValue(): Decimal | null;
     getCouponType(): CouponType;
     getCouponFrequency(): CouponFrequency;
-    getDatedDate(): LocalDate | undefined;
+    getDatedDate(): Date | null;
     /**
      * Returns every auction/reopening record on this bond as typed Issuance
      * wrappers. Empty list if bond_details is unset or has no issuances.
@@ -73,14 +65,6 @@ declare class BondSecurity extends Security {
      * @returns The price scale factor as a Decimal (0.01)
      */
     getPriceScaleFactor(): Decimal;
-    /**
-     * Bond issue date is the auction date and is required for bonds.
-     * Overrides Security.getIssueDate (which returns LocalDate | null on the
-     * base) with a non-nullable return type — for a properly-formed bond,
-     * issue date is always present, and TS callers narrowed via isBond()
-     * shouldn't have to null-check.
-     */
-    getIssueDate(): LocalDate;
     getProductType(): string;
 }
 export default BondSecurity;

package/node/wrappers/models/security/BondSecurity.fromPricerInputs.test.js

@@ -11,11 +11,11 @@ const product_type_pb_1 = require("../../../fintekkers/models/security/product_t
 const coupon_type_pb_1 = require("../../../fintekkers/models/security/coupon_type_pb");
 const coupon_frequency_pb_1 = require("../../../fintekkers/models/security/coupon_frequency_pb");
 const index_type_pb_1 = require("../../../fintekkers/models/security/index/index_type_pb");
-const date_1 = require("../utils/date");
-const local_date_pb_1 = require("../../../fintekkers/models/util/local_date_pb");
 const decimal_js_1 = require("decimal.js");
 function makeDate(y, m, d) {
-    return new date_1.LocalDate(new local_date_pb_1.LocalDateProto().setYear(y).setMonth(m).setDay(d));
+    const date = new Date(y, m - 1, d);
+    date.setHours(0, 0, 0, 0);
+    return date;
 }
 const baseInputs = {
     faceValue: new decimal_js_1.Decimal('1000'),
@@ -31,15 +31,19 @@ test('BondSecurity.fromPricerInputs round-trips through Security.create as a Bon
     const sec = security_1.default.create(proto);
     expect(sec).toBeInstanceOf(BondSecurity_1.default);
     const bond = sec;
-    expect(bond.getCouponRate().getArbitraryPrecisionValue()).toBe('0.045');
-    expect(bond.getFaceValue().getArbitraryPrecisionValue()).toBe('1000');
+    expect(bond.getCouponRate().equals(new decimal_js_1.Decimal('0.045'))).toBe(true);
+    expect(bond.getFaceValue().equals(new decimal_js_1.Decimal('1000'))).toBe(true);
     expect(bond.getCouponType().name()).toBe('FIXED');
     expect(bond.getCouponFrequency().toString()).toBe('SEMIANNUALLY');
-    expect(bond.getIssueDate().toDate().getFullYear()).toBe(2024);
-    expect(bond.getMaturityDate().toDate().getFullYear()).toBe(2034);
+    const issueDate = bond.getIssueDate();
+    const maturityDate = bond.getMaturityDate();
+    expect(issueDate).toBeInstanceOf(Date);
+    expect(maturityDate).toBeInstanceOf(Date);
+    expect(issueDate.getFullYear()).toBe(2024);
+    expect(maturityDate.getFullYear()).toBe(2034);
 });
 test('TIPSBond.fromPricerInputs round-trips with tips_extension populated', () => {
-    var _a, _b;
+    var _a;
     const proto = TIPSBond_1.default.fromPricerInputs(Object.assign(Object.assign({}, baseInputs), { baseCpi: new decimal_js_1.Decimal('301.5'), indexDate: makeDate(2024, 1, 15), inflationIndexType: index_type_pb_1.IndexTypeProto.CPI_U }));
     expect(proto.getProductType()).toBe(product_type_pb_1.ProductTypeProto.TIPS);
     expect(proto.hasTipsExtension()).toBe(true);
@@ -47,10 +51,12 @@ test('TIPSBond.fromPricerInputs round-trips with tips_extension populated', () =
     expect(sec).toBeInstanceOf(TIPSBond_1.default);
     const tips = sec;
     // Bond-side checks (inherited from BondSecurity)
-    expect(tips.getCouponRate().getArbitraryPrecisionValue()).toBe('0.045');
+    expect(tips.getCouponRate().equals(new decimal_js_1.Decimal('0.045'))).toBe(true);
     // TIPS-specific checks
     expect((_a = tips.getBaseCpi()) === null || _a === void 0 ? void 0 : _a.toString()).toBe('301.5');
-    expect((_b = tips.getIndexDate()) === null || _b === void 0 ? void 0 : _b.toDate().getFullYear()).toBe(2024);
+    const indexDate = tips.getIndexDate();
+    expect(indexDate).toBeInstanceOf(Date);
+    expect(indexDate.getFullYear()).toBe(2024);
     expect(tips.getInflationIndexType()).toBe(index_type_pb_1.IndexTypeProto.CPI_U);
 });
 test('FloatingRateNote.fromPricerInputs round-trips with frn_extension populated', () => {
@@ -61,7 +67,7 @@ test('FloatingRateNote.fromPricerInputs round-trips with frn_extension populated
     const sec = security_1.default.create(proto);
     expect(sec).toBeInstanceOf(FloatingRateNote_1.default);
     const frn = sec;
-    expect(frn.getCouponRate().getArbitraryPrecisionValue()).toBe('0.045');
+    expect(frn.getCouponRate().equals(new decimal_js_1.Decimal('0.045'))).toBe(true);
     expect((_a = frn.getSpread()) === null || _a === void 0 ? void 0 : _a.toString()).toBe('0.0015');
     expect(frn.getReferenceRateIndex()).toBe(index_type_pb_1.IndexTypeProto.SOFR);
     expect(frn.getResetFrequency()).toBe(coupon_frequency_pb_1.CouponFrequencyProto.QUARTERLY);

package/node/wrappers/models/security/BondSecurity.fromPricerInputs.test.js.map

@@ -1 +1 @@
-{"version":3,"file":"BondSecurity.fromPricerInputs.test.js","sourceRoot":"","sources":["BondSecurity.fromPricerInputs.test.ts"],"names":[],"mappings":";;;;;AAAA,0DAAkC;AAClC,kEAA0C;AAC1C,0DAAkC;AAClC,0EAAkD;AAClD,yFAAuF;AACvF,uFAAqF;AACrF,iGAA+F;AAC/F,2FAAyF;AACzF,wCAA0C;AAC1C,iFAA+E;AAC/E,2CAAqC;AAErC,SAAS,QAAQ,CAAC,CAAS,EAAE,CAAS,EAAE,CAAS;IAC/C,OAAO,IAAI,gBAAS,CAAC,IAAI,8BAAc,EAAE,CAAC,OAAO,CAAC,CAAC,CAAC,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC,CAAC;AAC9E,CAAC;AAED,MAAM,UAAU,GAAG;IACjB,SAAS,EAAE,IAAI,oBAAO,CAAC,MAAM,CAAC;IAC9B,UAAU,EAAE,IAAI,oBAAO,CAAC,OAAO,CAAC;IAChC,UAAU,EAAE,gCAAe,CAAC,KAAK;IACjC,eAAe,EAAE,0CAAoB,CAAC,YAAY;IAClD,SAAS,EAAE,QAAQ,CAAC,IAAI,EAAE,CAAC,EAAE,EAAE,CAAC;IAChC,YAAY,EAAE,QAAQ,CAAC,IAAI,EAAE,CAAC,EAAE,EAAE,CAAC;CACpC,CAAC;AAEF,IAAI,CAAC,qFAAqF,EAAE,GAAG,EAAE;IAC/F,MAAM,KAAK,GAAG,sBAAY,CAAC,gBAAgB,CAAC,UAAU,CAAC,CAAC;IACxD,MAAM,CAAC,KAAK,CAAC,cAAc,EAAE,CAAC,CAAC,IAAI,CAAC,kCAAgB,CAAC,aAAa,CAAC,CAAC;IACpE,MAAM,GAAG,GAAG,kBAAQ,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC;IACnC,MAAM,CAAC,GAAG,CAAC,CAAC,cAAc,CAAC,sBAAY,CAAC,CAAC;IACzC,MAAM,IAAI,GAAG,GAAmB,CAAC;IACjC,MAAM,CAAC,IAAI,CAAC,aAAa,EAAE,CAAC,0BAA0B,EAAE,CAAC,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC;IACxE,MAAM,CAAC,IAAI,CAAC,YAAY,EAAE,CAAC,0BAA0B,EAAE,CAAC,CAAC,IAAI,CAAC,MAAM,CAAC,CAAC;IACtE,MAAM,CAAC,IAAI,CAAC,aAAa,EAAE,CAAC,IAAI,EAAE,CAAC,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC;IAClD,MAAM,CAAC,IAAI,CAAC,kBAAkB,EAAE,CAAC,QAAQ,EAAE,CAAC,CAAC,IAAI,CAAC,cAAc,CAAC,CAAC;IAClE,MAAM,CAAC,IAAI,CAAC,YAAY,EAAE,CAAC,MAAM,EAAE,CAAC,WAAW,EAAE,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;IAC9D,MAAM,CAAC,IAAI,CAAC,eAAe,EAAE,CAAC,MAAM,EAAE,CAAC,WAAW,EAAE,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;AACnE,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,qEAAqE,EAAE,GAAG,EAAE;;IAC/E,MAAM,KAAK,GAAG,kBAAQ,CAAC,gBAAgB,iCAClC,UAAU,KACb,OAAO,EAAE,IAAI,oBAAO,CAAC,OAAO,CAAC,EAC7B,SAAS,EAAE,QAAQ,CAAC,IAAI,EAAE,CAAC,EAAE,EAAE,CAAC,EAChC,kBAAkB,EAAE,8BAAc,CAAC,KAAK,IACxC,CAAC;IACH,MAAM,CAAC,KAAK,CAAC,cAAc,EAAE,CAAC,CAAC,IAAI,CAAC,kCAAgB,CAAC,IAAI,CAAC,CAAC;IAC3D,MAAM,CAAC,KAAK,CAAC,gBAAgB,EAAE,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;IAE5C,MAAM,GAAG,GAAG,kBAAQ,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC;IACnC,MAAM,CAAC,GAAG,CAAC,CAAC,cAAc,CAAC,kBAAQ,CAAC,CAAC;IACrC,MAAM,IAAI,GAAG,GAAe,CAAC;IAC7B,iDAAiD;IACjD,MAAM,CAAC,IAAI,CAAC,aAAa,EAAE,CAAC,0BAA0B,EAAE,CAAC,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC;IACxE,uBAAuB;IACvB,MAAM,CAAC,MAAA,IAAI,CAAC,UAAU,EAAE,0CAAE,QAAQ,EAAE,CAAC,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC;IACpD,MAAM,CAAC,MAAA,IAAI,CAAC,YAAY,EAAE,0CAAE,MAAM,GAAG,WAAW,EAAE,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;IAC/D,MAAM,CAAC,IAAI,CAAC,qBAAqB,EAAE,CAAC,CAAC,IAAI,CAAC,8BAAc,CAAC,KAAK,CAAC,CAAC;AAClE,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,4EAA4E,EAAE,GAAG,EAAE;;IACtF,MAAM,KAAK,GAAG,0BAAgB,CAAC,gBAAgB,iCAC1C,UAAU,KACb,MAAM,EAAE,IAAI,oBAAO,CAAC,QAAQ,CAAC,EAC7B,kBAAkB,EAAE,8BAAc,CAAC,IAAI,EACvC,cAAc,EAAE,0CAAoB,CAAC,SAAS,IAC9C,CAAC;IACH,MAAM,CAAC,KAAK,CAAC,cAAc,EAAE,CAAC,CAAC,IAAI,CAAC,kCAAgB,CAAC,YAAY,CAAC,CAAC;IACnE,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;IAE3C,MAAM,GAAG,GAAG,kBAAQ,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC;IACnC,MAAM,CAAC,GAAG,CAAC,CAAC,cAAc,CAAC,0BAAgB,CAAC,CAAC;IAC7C,MAAM,GAAG,GAAG,GAAuB,CAAC;IACpC,MAAM,CAAC,GAAG,CAAC,aAAa,EAAE,CAAC,0BAA0B,EAAE,CAAC,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC;IACvE,MAAM,CAAC,MAAA,GAAG,CAAC,SAAS,EAAE,0CAAE,QAAQ,EAAE,CAAC,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC;IACnD,MAAM,CAAC,GAAG,CAAC,qBAAqB,EAAE,CAAC,CAAC,IAAI,CAAC,8BAAc,CAAC,IAAI,CAAC,CAAC;IAC9D,MAAM,CAAC,GAAG,CAAC,iBAAiB,EAAE,CAAC,CAAC,IAAI,CAAC,0CAAoB,CAAC,SAAS,CAAC,CAAC;AACvE,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,gDAAgD,EAAE,GAAG,EAAE;IAC1D,MAAM,SAAS,GAAG,kBAAQ,CAAC,gBAAgB,iCACtC,UAAU,KACb,OAAO,EAAE,IAAI,oBAAO,CAAC,KAAK,CAAC,EAC3B,SAAS,EAAE,QAAQ,CAAC,IAAI,EAAE,CAAC,EAAE,EAAE,CAAC,EAChC,kBAAkB,EAAE,8BAAc,CAAC,KAAK,IACxC,CAAC;IACH,MAAM,QAAQ,GAAG,0BAAgB,CAAC,gBAAgB,iCAC7C,UAAU,KACb,MAAM,EAAE,IAAI,oBAAO,CAAC,OAAO,CAAC,EAC5B,kBAAkB,EAAE,8BAAc,CAAC,IAAI,EACvC,cAAc,EAAE,0CAAoB,CAAC,SAAS,IAC9C,CAAC;IACH,MAAM,CAAC,kBAAQ,CAAC,MAAM,CAAC,SAAS,CAAC,CAAC,MAAM,EAAE,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;IACvD,MAAM,CAAC,kBAAQ,CAAC,MAAM,CAAC,QAAQ,CAAC,CAAC,MAAM,EAAE,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;AACxD,CAAC,CAAC,CAAC"}
+{"version":3,"file":"BondSecurity.fromPricerInputs.test.js","sourceRoot":"","sources":["BondSecurity.fromPricerInputs.test.ts"],"names":[],"mappings":";;;;;AAAA,0DAAkC;AAClC,kEAA0C;AAC1C,0DAAkC;AAClC,0EAAkD;AAClD,yFAAuF;AACvF,uFAAqF;AACrF,iGAA+F;AAC/F,2FAAyF;AACzF,2CAAqC;AAErC,SAAS,QAAQ,CAAC,CAAS,EAAE,CAAS,EAAE,CAAS;IAC/C,MAAM,IAAI,GAAG,IAAI,IAAI,CAAC,CAAC,EAAE,CAAC,GAAG,CAAC,EAAE,CAAC,CAAC,CAAC;IACnC,IAAI,CAAC,QAAQ,CAAC,CAAC,EAAE,CAAC,EAAE,CAAC,EAAE,CAAC,CAAC,CAAC;IAC1B,OAAO,IAAI,CAAC;AACd,CAAC;AAED,MAAM,UAAU,GAAG;IACjB,SAAS,EAAE,IAAI,oBAAO,CAAC,MAAM,CAAC;IAC9B,UAAU,EAAE,IAAI,oBAAO,CAAC,OAAO,CAAC;IAChC,UAAU,EAAE,gCAAe,CAAC,KAAK;IACjC,eAAe,EAAE,0CAAoB,CAAC,YAAY;IAClD,SAAS,EAAE,QAAQ,CAAC,IAAI,EAAE,CAAC,EAAE,EAAE,CAAC;IAChC,YAAY,EAAE,QAAQ,CAAC,IAAI,EAAE,CAAC,EAAE,EAAE,CAAC;CACpC,CAAC;AAEF,IAAI,CAAC,qFAAqF,EAAE,GAAG,EAAE;IAC/F,MAAM,KAAK,GAAG,sBAAY,CAAC,gBAAgB,CAAC,UAAU,CAAC,CAAC;IACxD,MAAM,CAAC,KAAK,CAAC,cAAc,EAAE,CAAC,CAAC,IAAI,CAAC,kCAAgB,CAAC,aAAa,CAAC,CAAC;IACpE,MAAM,GAAG,GAAG,kBAAQ,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC;IACnC,MAAM,CAAC,GAAG,CAAC,CAAC,cAAc,CAAC,sBAAY,CAAC,CAAC;IACzC,MAAM,IAAI,GAAG,GAAmB,CAAC;IACjC,MAAM,CAAC,IAAI,CAAC,aAAa,EAAG,CAAC,MAAM,CAAC,IAAI,oBAAO,CAAC,OAAO,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;IACtE,MAAM,CAAC,IAAI,CAAC,YAAY,EAAG,CAAC,MAAM,CAAC,IAAI,oBAAO,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;IACpE,MAAM,CAAC,IAAI,CAAC,aAAa,EAAE,CAAC,IAAI,EAAE,CAAC,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC;IAClD,MAAM,CAAC,IAAI,CAAC,kBAAkB,EAAE,CAAC,QAAQ,EAAE,CAAC,CAAC,IAAI,CAAC,cAAc,CAAC,CAAC;IAClE,MAAM,SAAS,GAAG,IAAI,CAAC,YAAY,EAAE,CAAC;IACtC,MAAM,YAAY,GAAG,IAAI,CAAC,eAAe,EAAE,CAAC;IAC5C,MAAM,CAAC,SAAS,CAAC,CAAC,cAAc,CAAC,IAAI,CAAC,CAAC;IACvC,MAAM,CAAC,YAAY,CAAC,CAAC,cAAc,CAAC,IAAI,CAAC,CAAC;IAC1C,MAAM,CAAC,SAAU,CAAC,WAAW,EAAE,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;IAC5C,MAAM,CAAC,YAAa,CAAC,WAAW,EAAE,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;AACjD,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,qEAAqE,EAAE,GAAG,EAAE;;IAC/E,MAAM,KAAK,GAAG,kBAAQ,CAAC,gBAAgB,iCAClC,UAAU,KACb,OAAO,EAAE,IAAI,oBAAO,CAAC,OAAO,CAAC,EAC7B,SAAS,EAAE,QAAQ,CAAC,IAAI,EAAE,CAAC,EAAE,EAAE,CAAC,EAChC,kBAAkB,EAAE,8BAAc,CAAC,KAAK,IACxC,CAAC;IACH,MAAM,CAAC,KAAK,CAAC,cAAc,EAAE,CAAC,CAAC,IAAI,CAAC,kCAAgB,CAAC,IAAI,CAAC,CAAC;IAC3D,MAAM,CAAC,KAAK,CAAC,gBAAgB,EAAE,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;IAE5C,MAAM,GAAG,GAAG,kBAAQ,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC;IACnC,MAAM,CAAC,GAAG,CAAC,CAAC,cAAc,CAAC,kBAAQ,CAAC,CAAC;IACrC,MAAM,IAAI,GAAG,GAAe,CAAC;IAC7B,iDAAiD;IACjD,MAAM,CAAC,IAAI,CAAC,aAAa,EAAG,CAAC,MAAM,CAAC,IAAI,oBAAO,CAAC,OAAO,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;IACtE,uBAAuB;IACvB,MAAM,CAAC,MAAA,IAAI,CAAC,UAAU,EAAE,0CAAE,QAAQ,EAAE,CAAC,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC;IACpD,MAAM,SAAS,GAAG,IAAI,CAAC,YAAY,EAAE,CAAC;IACtC,MAAM,CAAC,SAAS,CAAC,CAAC,cAAc,CAAC,IAAI,CAAC,CAAC;IACvC,MAAM,CAAC,SAAU,CAAC,WAAW,EAAE,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;IAC5C,MAAM,CAAC,IAAI,CAAC,qBAAqB,EAAE,CAAC,CAAC,IAAI,CAAC,8BAAc,CAAC,KAAK,CAAC,CAAC;AAClE,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,4EAA4E,EAAE,GAAG,EAAE;;IACtF,MAAM,KAAK,GAAG,0BAAgB,CAAC,gBAAgB,iCAC1C,UAAU,KACb,MAAM,EAAE,IAAI,oBAAO,CAAC,QAAQ,CAAC,EAC7B,kBAAkB,EAAE,8BAAc,CAAC,IAAI,EACvC,cAAc,EAAE,0CAAoB,CAAC,SAAS,IAC9C,CAAC;IACH,MAAM,CAAC,KAAK,CAAC,cAAc,EAAE,CAAC,CAAC,IAAI,CAAC,kCAAgB,CAAC,YAAY,CAAC,CAAC;IACnE,MAAM,CAAC,KAAK,CAAC,eAAe,EAAE,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;IAE3C,MAAM,GAAG,GAAG,kBAAQ,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC;IACnC,MAAM,CAAC,GAAG,CAAC,CAAC,cAAc,CAAC,0BAAgB,CAAC,CAAC;IAC7C,MAAM,GAAG,GAAG,GAAuB,CAAC;IACpC,MAAM,CAAC,GAAG,CAAC,aAAa,EAAG,CAAC,MAAM,CAAC,IAAI,oBAAO,CAAC,OAAO,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;IACrE,MAAM,CAAC,MAAA,GAAG,CAAC,SAAS,EAAE,0CAAE,QAAQ,EAAE,CAAC,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC;IACnD,MAAM,CAAC,GAAG,CAAC,qBAAqB,EAAE,CAAC,CAAC,IAAI,CAAC,8BAAc,CAAC,IAAI,CAAC,CAAC;IAC9D,MAAM,CAAC,GAAG,CAAC,iBAAiB,EAAE,CAAC,CAAC,IAAI,CAAC,0CAAoB,CAAC,SAAS,CAAC,CAAC;AACvE,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,gDAAgD,EAAE,GAAG,EAAE;IAC1D,MAAM,SAAS,GAAG,kBAAQ,CAAC,gBAAgB,iCACtC,UAAU,KACb,OAAO,EAAE,IAAI,oBAAO,CAAC,KAAK,CAAC,EAC3B,SAAS,EAAE,QAAQ,CAAC,IAAI,EAAE,CAAC,EAAE,EAAE,CAAC,EAChC,kBAAkB,EAAE,8BAAc,CAAC,KAAK,IACxC,CAAC;IACH,MAAM,QAAQ,GAAG,0BAAgB,CAAC,gBAAgB,iCAC7C,UAAU,KACb,MAAM,EAAE,IAAI,oBAAO,CAAC,OAAO,CAAC,EAC5B,kBAAkB,EAAE,8BAAc,CAAC,IAAI,EACvC,cAAc,EAAE,0CAAoB,CAAC,SAAS,IAC9C,CAAC;IACH,MAAM,CAAC,kBAAQ,CAAC,MAAM,CAAC,SAAS,CAAC,CAAC,MAAM,EAAE,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;IACvD,MAAM,CAAC,kBAAQ,CAAC,MAAM,CAAC,QAAQ,CAAC,CAAC,MAAM,EAAE,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;AACxD,CAAC,CAAC,CAAC"}

package/node/wrappers/models/security/BondSecurity.fromPricerInputs.test.ts

@@ -6,12 +6,12 @@ import { ProductTypeProto } from '../../../fintekkers/models/security/product_ty
 import { CouponTypeProto } from '../../../fintekkers/models/security/coupon_type_pb';
 import { CouponFrequencyProto } from '../../../fintekkers/models/security/coupon_frequency_pb';
 import { IndexTypeProto } from '../../../fintekkers/models/security/index/index_type_pb';
-import { LocalDate } from '../utils/date';
-import { LocalDateProto } from '../../../fintekkers/models/util/local_date_pb';
 import { Decimal } from 'decimal.js';
 
-function makeDate(y: number, m: number, d: number): LocalDate {
-  return new LocalDate(new LocalDateProto().setYear(y).setMonth(m).setDay(d));
+function makeDate(y: number, m: number, d: number): Date {
+  const date = new Date(y, m - 1, d);
+  date.setHours(0, 0, 0, 0);
+  return date;
 }
 
 const baseInputs = {
@@ -29,12 +29,16 @@ test('BondSecurity.fromPricerInputs round-trips through Security.create as a Bon
   const sec = Security.create(proto);
   expect(sec).toBeInstanceOf(BondSecurity);
   const bond = sec as BondSecurity;
-  expect(bond.getCouponRate().getArbitraryPrecisionValue()).toBe('0.045');
-  expect(bond.getFaceValue().getArbitraryPrecisionValue()).toBe('1000');
+  expect(bond.getCouponRate()!.equals(new Decimal('0.045'))).toBe(true);
+  expect(bond.getFaceValue()!.equals(new Decimal('1000'))).toBe(true);
   expect(bond.getCouponType().name()).toBe('FIXED');
   expect(bond.getCouponFrequency().toString()).toBe('SEMIANNUALLY');
-  expect(bond.getIssueDate().toDate().getFullYear()).toBe(2024);
-  expect(bond.getMaturityDate().toDate().getFullYear()).toBe(2034);
+  const issueDate = bond.getIssueDate();
+  const maturityDate = bond.getMaturityDate();
+  expect(issueDate).toBeInstanceOf(Date);
+  expect(maturityDate).toBeInstanceOf(Date);
+  expect(issueDate!.getFullYear()).toBe(2024);
+  expect(maturityDate!.getFullYear()).toBe(2034);
 });
 
 test('TIPSBond.fromPricerInputs round-trips with tips_extension populated', () => {
@@ -51,10 +55,12 @@ test('TIPSBond.fromPricerInputs round-trips with tips_extension populated', () =
   expect(sec).toBeInstanceOf(TIPSBond);
   const tips = sec as TIPSBond;
   // Bond-side checks (inherited from BondSecurity)
-  expect(tips.getCouponRate().getArbitraryPrecisionValue()).toBe('0.045');
+  expect(tips.getCouponRate()!.equals(new Decimal('0.045'))).toBe(true);
   // TIPS-specific checks
   expect(tips.getBaseCpi()?.toString()).toBe('301.5');
-  expect(tips.getIndexDate()?.toDate().getFullYear()).toBe(2024);
+  const indexDate = tips.getIndexDate();
+  expect(indexDate).toBeInstanceOf(Date);
+  expect(indexDate!.getFullYear()).toBe(2024);
   expect(tips.getInflationIndexType()).toBe(IndexTypeProto.CPI_U);
 });
 
@@ -71,7 +77,7 @@ test('FloatingRateNote.fromPricerInputs round-trips with frn_extension populated
   const sec = Security.create(proto);
   expect(sec).toBeInstanceOf(FloatingRateNote);
   const frn = sec as FloatingRateNote;
-  expect(frn.getCouponRate().getArbitraryPrecisionValue()).toBe('0.045');
+  expect(frn.getCouponRate()!.equals(new Decimal('0.045'))).toBe(true);
   expect(frn.getSpread()?.toString()).toBe('0.0015');
   expect(frn.getReferenceRateIndex()).toBe(IndexTypeProto.SOFR);
   expect(frn.getResetFrequency()).toBe(CouponFrequencyProto.QUARTERLY);

package/node/wrappers/models/security/BondSecurity.js

@@ -3,7 +3,7 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
     return (mod && mod.__esModule) ? mod : { "default": mod };
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.buildBondDetails = exports.decimalToProto = exports.localDateToProto = void 0;
+exports.buildBondDetails = exports.decimalToProto = void 0;
 const security_1 = __importDefault(require("./security"));
 const security_pb_1 = require("../../../fintekkers/models/security/security_pb");
 const product_type_pb_1 = require("../../../fintekkers/models/security/product_type_pb");
@@ -16,15 +16,6 @@ const tenor_type_pb_1 = require("../../../fintekkers/models/security/tenor_type_
 const decimal_js_1 = require("decimal.js");
 const product_hierarchy_1 = require("./product_hierarchy");
 const Issuance_1 = __importDefault(require("./Issuance"));
-/**
- * Build a LocalDateProto from a LocalDate wrapper. Exported so subclass
- * builders (TIPSBond, FloatingRateNote) can re-use it without poking at
- * LocalDate's proto privately.
- */
-function localDateToProto(d) {
-    return d.toProto();
-}
-exports.localDateToProto = localDateToProto;
 /** Build a DecimalValueProto from a Decimal. */
 function decimalToProto(v) {
     return new decimal_value_pb_1.DecimalValueProto().setArbitraryPrecisionValue(v.toString());
@@ -40,8 +31,8 @@ function buildBondDetails(args) {
         .setCouponRate(decimalToProto(args.couponRate))
         .setCouponType(args.couponType)
         .setCouponFrequency(args.couponFrequency)
-        .setIssueDate(localDateToProto(args.issueDate))
-        .setMaturityDate(localDateToProto(args.maturityDate));
+        .setIssueDate((0, date_1.dateToLocalDateProto)(args.issueDate))
+        .setMaturityDate((0, date_1.dateToLocalDateProto)(args.maturityDate));
 }
 exports.buildBondDetails = buildBondDetails;
 class BondSecurity extends security_1.default {
@@ -66,8 +57,13 @@ class BondSecurity extends security_1.default {
      * @returns The tenor (term) of the bond as a Tenor object.
      */
     getTenor(asOfDate) {
-        const startDate = asOfDate ? asOfDate : this.getIssueDate().toDate();
-        const maturityDate = this.getMaturityDate().toDate();
+        const issueDate = this.getIssueDate();
+        const maturityDate = this.getMaturityDate();
+        if (!issueDate)
+            throw new Error("Issue date is required for getTenor");
+        if (!maturityDate)
+            throw new Error("Maturity date is required for getTenor");
+        const startDate = asOfDate ? asOfDate : issueDate;
         // Calculate the period between issue date and maturity date
         const period = this.calculatePeriod(startDate, maturityDate);
         return new term_1.Tenor(tenor_type_pb_1.TenorTypeProto.TERM, period);
@@ -102,15 +98,15 @@ class BondSecurity extends security_1.default {
         const bond = this.getBondLikeDetails();
         const rate = bond ? bond.getCouponRate() : undefined;
         if (!rate)
-            throw new Error("Coupon rate is required for bonds");
-        return rate;
+            return null;
+        return new decimal_js_1.Decimal(rate.getArbitraryPrecisionValue());
     }
     getFaceValue() {
         const bond = this.getBondLikeDetails();
         const faceValue = bond ? bond.getFaceValue() : undefined;
         if (!faceValue)
-            throw new Error("Face value is required for bonds");
-        return faceValue;
+            return null;
+        return new decimal_js_1.Decimal(faceValue.getArbitraryPrecisionValue());
     }
     getCouponType() {
         const bond = this.getBondLikeDetails();
@@ -129,7 +125,7 @@ class BondSecurity extends security_1.default {
     getDatedDate() {
         const bond = this.getBondLikeDetails();
         const datedDate = bond ? bond.getDatedDate() : undefined;
-        return datedDate ? new date_1.LocalDate(datedDate) : undefined;
+        return (0, date_1.localDateProtoToDate)(datedDate);
     }
     /**
      * Returns every auction/reopening record on this bond as typed Issuance
@@ -160,19 +156,6 @@ class BondSecurity extends security_1.default {
     getPriceScaleFactor() {
         return new decimal_js_1.Decimal('0.01');
     }
-    /**
-     * Bond issue date is the auction date and is required for bonds.
-     * Overrides Security.getIssueDate (which returns LocalDate | null on the
-     * base) with a non-nullable return type — for a properly-formed bond,
-     * issue date is always present, and TS callers narrowed via isBond()
-     * shouldn't have to null-check.
-     */
-    getIssueDate() {
-        const date = super.getIssueDate();
-        if (!date)
-            throw new Error("Issue date is required for bonds");
-        return date;
-    }
     getProductType() {
         // Only BondSecurity has getTenor implemented
         // Check if getTenor method exists (it's only in BondSecurity)

package/node/wrappers/models/security/BondSecurity.js.map

@@ -1 +1 @@
-{"version":3,"file":"BondSecurity.js","sourceRoot":"","sources":["BondSecurity.ts"],"names":[],"mappings":";;;;;;AAAA,0DAAkC;AAClC,iFAAkG;AAClG,yFAAuF;AACvF,uFAAqF;AAErF,wCAA0C;AAE1C,yDAAqD;AACrD,+CAA2C;AAC3C,iCAAuC;AACvC,qFAAmF;AAGnF,2CAAqC;AACrC,2DAAqD;AACrD,0DAAkC;AAelC;;;;GAIG;AACH,SAAgB,gBAAgB,CAAC,CAAY;IAC3C,OAAO,CAAC,CAAC,OAAO,EAAE,CAAC;AACrB,CAAC;AAFD,4CAEC;AAED,gDAAgD;AAChD,SAAgB,cAAc,CAAC,CAAU;IACvC,OAAO,IAAI,oCAAiB,EAAE,CAAC,0BAA0B,CAAC,CAAC,CAAC,QAAQ,EAAE,CAAC,CAAC;AAC1E,CAAC;AAFD,wCAEC;AAED;;;GAGG;AACH,SAAgB,gBAAgB,CAAC,IAAsB;IACrD,OAAO,IAAI,8BAAgB,EAAE;SAC1B,YAAY,CAAC,cAAc,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC;SAC5C,aAAa,CAAC,cAAc,CAAC,IAAI,CAAC,UAAU,CAAC,CAAC;SAC9C,aAAa,CAAC,IAAI,CAAC,UAAU,CAAC;SAC9B,kBAAkB,CAAC,IAAI,CAAC,eAAe,CAAC;SACxC,YAAY,CAAC,gBAAgB,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC;SAC9C,eAAe,CAAC,gBAAgB,CAAC,IAAI,CAAC,YAAY,CAAC,CAAC,CAAC;AAC1D,CAAC;AARD,4CAQC;AAED,MAAM,YAAa,SAAQ,kBAAQ;IACjC,YAAY,KAAoB;QAC9B,KAAK,CAAC,KAAK,CAAC,CAAC;QACb,oEAAoE;QACpE,kEAAkE;QAClE,6DAA6D;QAC7D,yDAAyD;QACzD,8CAA8C;QAC9C,MAAM,MAAM,GAAI,MAAM,CAAC,IAAI,CAAC,kCAAgB,CAA0C;aACnF,IAAI,CAAC,CAAC,CAAC,EAAE,CAAC,kCAAgB,CAAC,CAAC,CAAC,KAAK,KAAK,CAAC,cAAc,EAAE,CAAC,CAAC;QAC7D,IAAI,CAAC,MAAM,IAAI,CAAC,IAAA,kCAAc,EAAC,MAAgB,EAAE,MAAM,CAAC,EAAE;YACxD,MAAM,IAAI,KAAK,CACb,+FAA+F,MAAM,aAAN,MAAM,cAAN,MAAM,GAAI,SAAS,EAAE,CACrH,CAAC;SACH;IACH,CAAC;IAED;;;;;;OAMG;IACH,QAAQ,CAAC,QAAe;QACtB,MAAM,SAAS,GAAG,QAAQ,CAAC,CAAC,CAAC,QAAQ,CAAC,CAAC,CAAC,IAAI,CAAC,YAAY,EAAE,CAAC,MAAM,EAAE,CAAC;QACrE,MAAM,YAAY,GAAG,IAAI,CAAC,eAAe,EAAE,CAAC,MAAM,EAAE,CAAC;QAErD,4DAA4D;QAC5D,MAAM,MAAM,GAAG,IAAI,CAAC,eAAe,CAAC,SAAS,EAAE,YAAY,CAAC,CAAC;QAE7D,OAAO,IAAI,YAAK,CAAC,8BAAc,CAAC,IAAI,EAAE,MAAM,CAAC,CAAC;IAChD,CAAC;IAED;;;OAGG;IACK,eAAe,CAAC,SAAe,EAAE,OAAa;QACpD,IAAI,KAAK,GAAG,OAAO,CAAC,WAAW,EAAE,GAAG,SAAS,CAAC,WAAW,EAAE,CAAC;QAC5D,IAAI,MAAM,GAAG,OAAO,CAAC,QAAQ,EAAE,GAAG,SAAS,CAAC,QAAQ,EAAE,CAAC;QACvD,IAAI,IAAI,GAAG,OAAO,CAAC,OAAO,EAAE,GAAG,SAAS,CAAC,OAAO,EAAE,CAAC;QAEnD,kEAAkE;QAClE,IAAI,IAAI,GAAG,CAAC,EAAE;YACZ,MAAM,EAAE,CAAC;YACT,+CAA+C;YAC/C,MAAM,kBAAkB,GAAG,IAAI,IAAI,CAAC,OAAO,CAAC,WAAW,EAAE,EAAE,OAAO,CAAC,QAAQ,EAAE,EAAE,CAAC,CAAC,CAAC,OAAO,EAAE,CAAC;YAC5F,IAAI,IAAI,kBAAkB,CAAC;SAC5B;QAED,6BAA6B;QAC7B,IAAI,MAAM,GAAG,CAAC,EAAE;YACd,KAAK,EAAE,CAAC;YACR,MAAM,IAAI,EAAE,CAAC;SACd;QAED,OAAO;YACL,KAAK;YACL,MAAM;YACN,IAAI;SACL,CAAC;IACJ,CAAC;IAED,aAAa;QACX,MAAM,IAAI,GAAG,IAAI,CAAC,kBAAkB,EAAE,CAAC;QACvC,MAAM,IAAI,GAAG,IAAI,CAAC,CAAC,CAAC,IAAI,CAAC,aAAa,EAAE,CAAC,CAAC,CAAC,SAAS,CAAC;QACrD,IAAI,CAAC,IAAI;YAAE,MAAM,IAAI,KAAK,CAAC,mCAAmC,CAAC,CAAC;QAChE,OAAO,IAAI,CAAC;IACd,CAAC;IAED,YAAY;QACV,MAAM,IAAI,GAAG,IAAI,CAAC,kBAAkB,EAAE,CAAC;QACvC,MAAM,SAAS,GAAG,IAAI,CAAC,CAAC,CAAC,IAAI,CAAC,YAAY,EAAE,CAAC,CAAC,CAAC,SAAS,CAAC;QACzD,IAAI,CAAC,SAAS;YAAE,MAAM,IAAI,KAAK,CAAC,kCAAkC,CAAC,CAAC;QACpE,OAAO,SAAS,CAAC;IACnB,CAAC;IAED,aAAa;QACX,MAAM,IAAI,GAAG,IAAI,CAAC,kBAAkB,EAAE,CAAC;QACvC,MAAM,UAAU,GAAG,IAAI,CAAC,CAAC,CAAC,IAAI,CAAC,aAAa,EAAE,CAAC,CAAC,CAAC,SAAS,CAAC;QAC3D,IAAI,UAAU,KAAK,SAAS;YAAE,MAAM,IAAI,KAAK,CAAC,mCAAmC,CAAC,CAAC;QACnF,OAAO,IAAI,wBAAU,CAAC,UAAU,CAAC,CAAC;IACpC,CAAC;IAED,kBAAkB;QAChB,MAAM,IAAI,GAAG,IAAI,CAAC,kBAAkB,EAAE,CAAC;QACvC,MAAM,eAAe,GAAG,IAAI,CAAC,CAAC,CAAC,IAAI,CAAC,kBAAkB,EAAE,CAAC,CAAC,CAAC,SAAS,CAAC;QACrE,IAAI,eAAe,KAAK,SAAS;YAAE,MAAM,IAAI,KAAK,CAAC,wCAAwC,CAAC,CAAC;QAC7F,OAAO,IAAI,kCAAe,CAAC,eAAe,CAAC,CAAC;IAC9C,CAAC;IAED,YAAY;QACV,MAAM,IAAI,GAAG,IAAI,CAAC,kBAAkB,EAAE,CAAC;QACvC,MAAM,SAAS,GAAG,IAAI,CAAC,CAAC,CAAC,IAAI,CAAC,YAAY,EAAE,CAAC,CAAC,CAAC,SAAS,CAAC;QACzD,OAAO,SAAS,CAAC,CAAC,CAAC,IAAI,gBAAS,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC;IAC1D,CAAC;IAED;;;OAGG;IACH,YAAY;QACV,MAAM,IAAI,GAAG,IAAI,CAAC,kBAAkB,EAAE,CAAC;QACvC,MAAM,IAAI,GAAoB,IAAI,CAAC,CAAC,CAAC,IAAI,CAAC,mBAAmB,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC;QACrE,OAAO,IAAI,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,CAAC,IAAI,kBAAQ,CAAC,CAAC,CAAC,CAAC,CAAC;IACxC,CAAC;IAED;;;;OAIG;IACH,MAAM,CAAC,gBAAgB,CAAC,IAAsB;QAC5C,MAAM,IAAI,GAAG,gBAAgB,CAAC,IAAI,CAAC,CAAC;QACpC,OAAO,IAAI,2BAAa,EAAE;aACvB,cAAc,CAAC,kCAAgB,CAAC,aAAa,CAAC;aAC9C,cAAc,CAAC,IAAI,CAAC,CAAC;IAC1B,CAAC;IAED;;;;;OAKG;IACH,mBAAmB;QACjB,OAAO,IAAI,oBAAO,CAAC,MAAM,CAAC,CAAC;IAC7B,CAAC;IAED;;;;;;OAMG;IACH,YAAY;QACV,MAAM,IAAI,GAAG,KAAK,CAAC,YAAY,EAAE,CAAC;QAClC,IAAI,CAAC,IAAI;YAAE,MAAM,IAAI,KAAK,CAAC,kCAAkC,CAAC,CAAC;QAC/D,OAAO,IAAI,CAAC;IACd,CAAC;IAED,cAAc;QACZ,6CAA6C;QAC7C,8DAA8D;QAC9D,IAAI,OAAQ,IAAY,CAAC,QAAQ,KAAK,UAAU,EAAE;YAChD,MAAM,IAAI,KAAK,CAAC,qDAAqD,CAAC,CAAC;SACxE;QAED,MAAM,KAAK,GAAI,IAAY,CAAC,QAAQ,EAAE,CAAC;QACvC,IAAI,CAAC,KAAK,EAAE;YACV,MAAM,IAAI,KAAK,CAAC,6CAA6C,CAAC,CAAC;SAChE;QAED,MAAM,MAAM,GAAG,KAAK,CAAC,QAAQ,EAAE,CAAC;QAChC,IAAI,CAAC,MAAM,EAAE;YACX,MAAM,IAAI,KAAK,CAAC,8CAA8C,CAAC,CAAC;SACjE;QAED,MAAM,KAAK,GAAG,MAAM,CAAC,KAAK,CAAC;QAC3B,MAAM,MAAM,GAAG,MAAM,CAAC,MAAM,CAAC;QAE7B,IAAI,KAAK,GAAG,CAAC,IAAI,CAAC,KAAK,KAAK,CAAC,IAAI,MAAM,KAAK,CAAC,CAAC,EAAE;YAC9C,OAAO,MAAM,CAAC;SACf;aAAM,IAAI,KAAK,GAAG,EAAE,EAAE;YACrB,OAAO,MAAM,CAAC;SACf;aAAM;YACL,OAAO,MAAM,CAAC;SACf;IACH,CAAC;CACF;AAED,kBAAe,YAAY,CAAC"}
+{"version":3,"file":"BondSecurity.js","sourceRoot":"","sources":["BondSecurity.ts"],"names":[],"mappings":";;;;;;AAAA,0DAAkC;AAClC,iFAAkG;AAClG,yFAAuF;AACvF,uFAAqF;AAErF,wCAA2E;AAE3E,yDAAqD;AACrD,+CAA2C;AAC3C,iCAAuC;AACvC,qFAAmF;AAGnF,2CAAqC;AACrC,2DAAqD;AACrD,0DAAkC;AAelC,gDAAgD;AAChD,SAAgB,cAAc,CAAC,CAAU;IACvC,OAAO,IAAI,oCAAiB,EAAE,CAAC,0BAA0B,CAAC,CAAC,CAAC,QAAQ,EAAE,CAAC,CAAC;AAC1E,CAAC;AAFD,wCAEC;AAED;;;GAGG;AACH,SAAgB,gBAAgB,CAAC,IAAsB;IACrD,OAAO,IAAI,8BAAgB,EAAE;SAC1B,YAAY,CAAC,cAAc,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC;SAC5C,aAAa,CAAC,cAAc,CAAC,IAAI,CAAC,UAAU,CAAC,CAAC;SAC9C,aAAa,CAAC,IAAI,CAAC,UAAU,CAAC;SAC9B,kBAAkB,CAAC,IAAI,CAAC,eAAe,CAAC;SACxC,YAAY,CAAC,IAAA,2BAAoB,EAAC,IAAI,CAAC,SAAS,CAAC,CAAC;SAClD,eAAe,CAAC,IAAA,2BAAoB,EAAC,IAAI,CAAC,YAAY,CAAC,CAAC,CAAC;AAC9D,CAAC;AARD,4CAQC;AAED,MAAM,YAAa,SAAQ,kBAAQ;IACjC,YAAY,KAAoB;QAC9B,KAAK,CAAC,KAAK,CAAC,CAAC;QACb,oEAAoE;QACpE,kEAAkE;QAClE,6DAA6D;QAC7D,yDAAyD;QACzD,8CAA8C;QAC9C,MAAM,MAAM,GAAI,MAAM,CAAC,IAAI,CAAC,kCAAgB,CAA0C;aACnF,IAAI,CAAC,CAAC,CAAC,EAAE,CAAC,kCAAgB,CAAC,CAAC,CAAC,KAAK,KAAK,CAAC,cAAc,EAAE,CAAC,CAAC;QAC7D,IAAI,CAAC,MAAM,IAAI,CAAC,IAAA,kCAAc,EAAC,MAAgB,EAAE,MAAM,CAAC,EAAE;YACxD,MAAM,IAAI,KAAK,CACb,+FAA+F,MAAM,aAAN,MAAM,cAAN,MAAM,GAAI,SAAS,EAAE,CACrH,CAAC;SACH;IACH,CAAC;IAED;;;;;;OAMG;IACH,QAAQ,CAAC,QAAe;QACtB,MAAM,SAAS,GAAG,IAAI,CAAC,YAAY,EAAE,CAAC;QACtC,MAAM,YAAY,GAAG,IAAI,CAAC,eAAe,EAAE,CAAC;QAC5C,IAAI,CAAC,SAAS;YAAE,MAAM,IAAI,KAAK,CAAC,qCAAqC,CAAC,CAAC;QACvE,IAAI,CAAC,YAAY;YAAE,MAAM,IAAI,KAAK,CAAC,wCAAwC,CAAC,CAAC;QAC7E,MAAM,SAAS,GAAG,QAAQ,CAAC,CAAC,CAAC,QAAQ,CAAC,CAAC,CAAC,SAAS,CAAC;QAElD,4DAA4D;QAC5D,MAAM,MAAM,GAAG,IAAI,CAAC,eAAe,CAAC,SAAS,EAAE,YAAY,CAAC,CAAC;QAE7D,OAAO,IAAI,YAAK,CAAC,8BAAc,CAAC,IAAI,EAAE,MAAM,CAAC,CAAC;IAChD,CAAC;IAED;;;OAGG;IACK,eAAe,CAAC,SAAe,EAAE,OAAa;QACpD,IAAI,KAAK,GAAG,OAAO,CAAC,WAAW,EAAE,GAAG,SAAS,CAAC,WAAW,EAAE,CAAC;QAC5D,IAAI,MAAM,GAAG,OAAO,CAAC,QAAQ,EAAE,GAAG,SAAS,CAAC,QAAQ,EAAE,CAAC;QACvD,IAAI,IAAI,GAAG,OAAO,CAAC,OAAO,EAAE,GAAG,SAAS,CAAC,OAAO,EAAE,CAAC;QAEnD,kEAAkE;QAClE,IAAI,IAAI,GAAG,CAAC,EAAE;YACZ,MAAM,EAAE,CAAC;YACT,+CAA+C;YAC/C,MAAM,kBAAkB,GAAG,IAAI,IAAI,CAAC,OAAO,CAAC,WAAW,EAAE,EAAE,OAAO,CAAC,QAAQ,EAAE,EAAE,CAAC,CAAC,CAAC,OAAO,EAAE,CAAC;YAC5F,IAAI,IAAI,kBAAkB,CAAC;SAC5B;QAED,6BAA6B;QAC7B,IAAI,MAAM,GAAG,CAAC,EAAE;YACd,KAAK,EAAE,CAAC;YACR,MAAM,IAAI,EAAE,CAAC;SACd;QAED,OAAO;YACL,KAAK;YACL,MAAM;YACN,IAAI;SACL,CAAC;IACJ,CAAC;IAED,aAAa;QACX,MAAM,IAAI,GAAG,IAAI,CAAC,kBAAkB,EAAE,CAAC;QACvC,MAAM,IAAI,GAAG,IAAI,CAAC,CAAC,CAAC,IAAI,CAAC,aAAa,EAAE,CAAC,CAAC,CAAC,SAAS,CAAC;QACrD,IAAI,CAAC,IAAI;YAAE,OAAO,IAAI,CAAC;QACvB,OAAO,IAAI,oBAAO,CAAC,IAAI,CAAC,0BAA0B,EAAE,CAAC,CAAC;IACxD,CAAC;IAED,YAAY;QACV,MAAM,IAAI,GAAG,IAAI,CAAC,kBAAkB,EAAE,CAAC;QACvC,MAAM,SAAS,GAAG,IAAI,CAAC,CAAC,CAAC,IAAI,CAAC,YAAY,EAAE,CAAC,CAAC,CAAC,SAAS,CAAC;QACzD,IAAI,CAAC,SAAS;YAAE,OAAO,IAAI,CAAC;QAC5B,OAAO,IAAI,oBAAO,CAAC,SAAS,CAAC,0BAA0B,EAAE,CAAC,CAAC;IAC7D,CAAC;IAED,aAAa;QACX,MAAM,IAAI,GAAG,IAAI,CAAC,kBAAkB,EAAE,CAAC;QACvC,MAAM,UAAU,GAAG,IAAI,CAAC,CAAC,CAAC,IAAI,CAAC,aAAa,EAAE,CAAC,CAAC,CAAC,SAAS,CAAC;QAC3D,IAAI,UAAU,KAAK,SAAS;YAAE,MAAM,IAAI,KAAK,CAAC,mCAAmC,CAAC,CAAC;QACnF,OAAO,IAAI,wBAAU,CAAC,UAAU,CAAC,CAAC;IACpC,CAAC;IAED,kBAAkB;QAChB,MAAM,IAAI,GAAG,IAAI,CAAC,kBAAkB,EAAE,CAAC;QACvC,MAAM,eAAe,GAAG,IAAI,CAAC,CAAC,CAAC,IAAI,CAAC,kBAAkB,EAAE,CAAC,CAAC,CAAC,SAAS,CAAC;QACrE,IAAI,eAAe,KAAK,SAAS;YAAE,MAAM,IAAI,KAAK,CAAC,wCAAwC,CAAC,CAAC;QAC7F,OAAO,IAAI,kCAAe,CAAC,eAAe,CAAC,CAAC;IAC9C,CAAC;IAED,YAAY;QACV,MAAM,IAAI,GAAG,IAAI,CAAC,kBAAkB,EAAE,CAAC;QACvC,MAAM,SAAS,GAAG,IAAI,CAAC,CAAC,CAAC,IAAI,CAAC,YAAY,EAAE,CAAC,CAAC,CAAC,SAAS,CAAC;QACzD,OAAO,IAAA,2BAAoB,EAAC,SAAS,CAAC,CAAC;IACzC,CAAC;IAED;;;OAGG;IACH,YAAY;QACV,MAAM,IAAI,GAAG,IAAI,CAAC,kBAAkB,EAAE,CAAC;QACvC,MAAM,IAAI,GAAoB,IAAI,CAAC,CAAC,CAAC,IAAI,CAAC,mBAAmB,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC;QACrE,OAAO,IAAI,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,CAAC,IAAI,kBAAQ,CAAC,CAAC,CAAC,CAAC,CAAC;IACxC,CAAC;IAED;;;;OAIG;IACH,MAAM,CAAC,gBAAgB,CAAC,IAAsB;QAC5C,MAAM,IAAI,GAAG,gBAAgB,CAAC,IAAI,CAAC,CAAC;QACpC,OAAO,IAAI,2BAAa,EAAE;aACvB,cAAc,CAAC,kCAAgB,CAAC,aAAa,CAAC;aAC9C,cAAc,CAAC,IAAI,CAAC,CAAC;IAC1B,CAAC;IAED;;;;;OAKG;IACH,mBAAmB;QACjB,OAAO,IAAI,oBAAO,CAAC,MAAM,CAAC,CAAC;IAC7B,CAAC;IAED,cAAc;QACZ,6CAA6C;QAC7C,8DAA8D;QAC9D,IAAI,OAAQ,IAAY,CAAC,QAAQ,KAAK,UAAU,EAAE;YAChD,MAAM,IAAI,KAAK,CAAC,qDAAqD,CAAC,CAAC;SACxE;QAED,MAAM,KAAK,GAAI,IAAY,CAAC,QAAQ,EAAE,CAAC;QACvC,IAAI,CAAC,KAAK,EAAE;YACV,MAAM,IAAI,KAAK,CAAC,6CAA6C,CAAC,CAAC;SAChE;QAED,MAAM,MAAM,GAAG,KAAK,CAAC,QAAQ,EAAE,CAAC;QAChC,IAAI,CAAC,MAAM,EAAE;YACX,MAAM,IAAI,KAAK,CAAC,8CAA8C,CAAC,CAAC;SACjE;QAED,MAAM,KAAK,GAAG,MAAM,CAAC,KAAK,CAAC;QAC3B,MAAM,MAAM,GAAG,MAAM,CAAC,MAAM,CAAC;QAE7B,IAAI,KAAK,GAAG,CAAC,IAAI,CAAC,KAAK,KAAK,CAAC,IAAI,MAAM,KAAK,CAAC,CAAC,EAAE;YAC9C,OAAO,MAAM,CAAC;SACf;aAAM,IAAI,KAAK,GAAG,EAAE,EAAE;YACrB,OAAO,MAAM,CAAC;SACf;aAAM;YACL,OAAO,MAAM,CAAC;SACf;IACH,CAAC;CACF;AAED,kBAAe,YAAY,CAAC"}

package/node/wrappers/models/security/BondSecurity.ts

@@ -3,7 +3,7 @@ import { SecurityProto, BondDetailsProto } from '../../../fintekkers/models/secu
 import { ProductTypeProto } from "../../../fintekkers/models/security/product_type_pb";
 import { DecimalValueProto } from '../../../fintekkers/models/util/decimal_value_pb';
 import { LocalDateProto } from '../../../fintekkers/models/util/local_date_pb';
-import { LocalDate } from '../utils/date';
+import { dateToLocalDateProto, localDateProtoToDate } from '../utils/date';
 import { IssuanceProto } from '../../../fintekkers/models/security/bond/issuance_pb';
 import { CouponFrequency } from './coupon_frequency';
 import { CouponType } from './coupon_type';
@@ -24,17 +24,8 @@ export interface BondPricerInputs {
   couponRate: Decimal;
   couponType: CouponTypeProto;
   couponFrequency: CouponFrequencyProto;
-  issueDate: LocalDate;
-  maturityDate: LocalDate;
-}
-
-/**
- * Build a LocalDateProto from a LocalDate wrapper. Exported so subclass
- * builders (TIPSBond, FloatingRateNote) can re-use it without poking at
- * LocalDate's proto privately.
- */
-export function localDateToProto(d: LocalDate): LocalDateProto {
-  return d.toProto();
+  issueDate: Date;
+  maturityDate: Date;
 }
 
 /** Build a DecimalValueProto from a Decimal. */
@@ -52,8 +43,8 @@ export function buildBondDetails(args: BondPricerInputs): BondDetailsProto {
     .setCouponRate(decimalToProto(args.couponRate))
     .setCouponType(args.couponType)
     .setCouponFrequency(args.couponFrequency)
-    .setIssueDate(localDateToProto(args.issueDate))
-    .setMaturityDate(localDateToProto(args.maturityDate));
+    .setIssueDate(dateToLocalDateProto(args.issueDate))
+    .setMaturityDate(dateToLocalDateProto(args.maturityDate));
 }
 
 class BondSecurity extends Security {
@@ -81,8 +72,11 @@ class BondSecurity extends Security {
    * @returns The tenor (term) of the bond as a Tenor object.
    */
   getTenor(asOfDate?: Date): Tenor {
-    const startDate = asOfDate ? asOfDate : this.getIssueDate().toDate();
-    const maturityDate = this.getMaturityDate().toDate();
+    const issueDate = this.getIssueDate();
+    const maturityDate = this.getMaturityDate();
+    if (!issueDate) throw new Error("Issue date is required for getTenor");
+    if (!maturityDate) throw new Error("Maturity date is required for getTenor");
+    const startDate = asOfDate ? asOfDate : issueDate;
 
     // Calculate the period between issue date and maturity date
     const period = this.calculatePeriod(startDate, maturityDate);
@@ -120,18 +114,18 @@ class BondSecurity extends Security {
     };
   }
 
-  getCouponRate(): DecimalValueProto {
+  getCouponRate(): Decimal | null {
     const bond = this.getBondLikeDetails();
     const rate = bond ? bond.getCouponRate() : undefined;
-    if (!rate) throw new Error("Coupon rate is required for bonds");
-    return rate;
+    if (!rate) return null;
+    return new Decimal(rate.getArbitraryPrecisionValue());
   }
 
-  getFaceValue(): DecimalValueProto {
+  getFaceValue(): Decimal | null {
     const bond = this.getBondLikeDetails();
     const faceValue = bond ? bond.getFaceValue() : undefined;
-    if (!faceValue) throw new Error("Face value is required for bonds");
-    return faceValue;
+    if (!faceValue) return null;
+    return new Decimal(faceValue.getArbitraryPrecisionValue());
   }
 
   getCouponType(): CouponType {
@@ -148,10 +142,10 @@ class BondSecurity extends Security {
     return new CouponFrequency(couponFrequency);
   }
 
-  getDatedDate(): LocalDate | undefined {
+  getDatedDate(): Date | null {
     const bond = this.getBondLikeDetails();
     const datedDate = bond ? bond.getDatedDate() : undefined;
-    return datedDate ? new LocalDate(datedDate) : undefined;
+    return localDateProtoToDate(datedDate);
   }
 
   /**
@@ -186,19 +180,6 @@ class BondSecurity extends Security {
     return new Decimal('0.01');
   }
 
-  /**
-   * Bond issue date is the auction date and is required for bonds.
-   * Overrides Security.getIssueDate (which returns LocalDate | null on the
-   * base) with a non-nullable return type — for a properly-formed bond,
-   * issue date is always present, and TS callers narrowed via isBond()
-   * shouldn't have to null-check.
-   */
-  getIssueDate(): LocalDate {
-    const date = super.getIssueDate();
-    if (!date) throw new Error("Issue date is required for bonds");
-    return date;
-  }
-
   getProductType(): string {
     // Only BondSecurity has getTenor implemented
     // Check if getTenor method exists (it's only in BondSecurity)