@finos/legend-query-builder 1.0.2 → 1.0.4

package/src/components/shared/BasicValueSpecificationEditor.tsx

@@ -32,6 +32,7 @@ import {
   FilledWindowMaximizeIcon,
   BasePopover,
   PanelFormSection,
+  CalculateIcon,
 } from '@finos/legend-art';
 import {
   type Enum,
@@ -53,6 +54,8 @@ import {
   getEnumValue,
   getMultiplicityDescription,
   type ObserverContext,
+  matchFunctionName,
+  isSubType,
 } from '@finos/legend-graph';
 import {
   type DebouncedFunc,
@@ -62,6 +65,7 @@ import {
   returnUndefOnError,
   uniq,
   parseCSVString,
+  guaranteeIsNumber,
 } from '@finos/legend-shared';
 import { flowResult } from 'mobx';
 import { observer } from 'mobx-react-lite';
@@ -72,6 +76,9 @@ import {
   instanceValue_setValues,
 } from '../../stores/shared/ValueSpecificationModifierHelper.js';
 import { CustomDatePicker } from './CustomDatePicker.js';
+import { QUERY_BUILDER_SUPPORTED_FUNCTIONS } from '../../graphManager/QueryBuilderSupportedFunctions.js';
+import { simplifyValueExpression } from '../../stores/QueryBuilderValueSpecificationHelper.js';
+import { evaluate } from 'mathjs';
 
 type TypeCheckOption = {
   expectedType: Type;
@@ -210,6 +217,7 @@ const StringPrimitiveInstanceValueEditor = observer(
           cleanUpReloadValues?: () => void;
         }
       | undefined;
+    obseverContext: ObserverContext;
   }) => {
     const {
       valueSpecification,
@@ -217,12 +225,13 @@ const StringPrimitiveInstanceValueEditor = observer(
       resetValue,
       setValueSpecification,
       selectorConfig,
+      obseverContext,
     } = props;
     const useSelector = Boolean(selectorConfig);
     const applicationStore = useApplicationStore();
     const value = valueSpecification.values[0] as string;
     const updateValueSpec = (val: string): void => {
-      instanceValue_setValue(valueSpecification, val, 0);
+      instanceValue_setValue(valueSpecification, val, 0, obseverContext);
       setValueSpecification(valueSpecification);
     };
     const changeInputValue: React.ChangeEventHandler<HTMLInputElement> = (
@@ -316,12 +325,18 @@ const BooleanPrimitiveInstanceValueEditor = observer(
     className?: string | undefined;
     resetValue: () => void;
     setValueSpecification: (val: ValueSpecification) => void;
+    obseverContext: ObserverContext;
   }) => {
-    const { valueSpecification, className, resetValue, setValueSpecification } =
-      props;
+    const {
+      valueSpecification,
+      className,
+      resetValue,
+      setValueSpecification,
+      obseverContext,
+    } = props;
     const value = valueSpecification.values[0] as boolean;
     const toggleValue = (): void => {
-      instanceValue_setValue(valueSpecification, !value, 0);
+      instanceValue_setValue(valueSpecification, !value, 0, obseverContext);
       setValueSpecification(valueSpecification);
     };
 
@@ -354,6 +369,7 @@ const NumberPrimitiveInstanceValueEditor = observer(
     className?: string | undefined;
     resetValue: () => void;
     setValueSpecification: (val: ValueSpecification) => void;
+    obseverContext: ObserverContext;
   }) => {
     const {
       valueSpecification,
@@ -361,26 +377,95 @@ const NumberPrimitiveInstanceValueEditor = observer(
       className,
       resetValue,
       setValueSpecification,
+      obseverContext,
     } = props;
-    const value = valueSpecification.values[0] as number;
+    const [value, setValue] = useState(
+      (valueSpecification.values[0] as number).toString(),
+    );
+    const inputRef = useRef<HTMLInputElement>(null);
+    const numericValue = isInteger
+      ? Number.parseInt(Number(value).toString(), 10)
+      : Number(value);
+
     const changeValue: React.ChangeEventHandler<HTMLInputElement> = (event) => {
-      let inputVal = isInteger
-        ? parseInt(event.target.value, 10)
-        : parseFloat(event.target.value);
-      inputVal = isNaN(inputVal) ? 0 : inputVal;
-      instanceValue_setValue(valueSpecification, inputVal, 0);
-      setValueSpecification(valueSpecification);
+      setValue(event.target.value);
     };
 
+    // Support expression evaluation
+    const calculateExpression = (): void => {
+      if (isNaN(numericValue)) {
+        try {
+          const calculatedValue = guaranteeIsNumber(evaluate(value));
+          setValue(
+            isInteger
+              ? Number.parseInt(calculatedValue.toString(), 10).toString()
+              : Number(calculatedValue).toString(),
+          );
+        } catch {
+          setValue((valueSpecification.values[0] as number).toString());
+        }
+      } else {
+        setValue(numericValue.toString());
+      }
+    };
+
+    const onKeyDown: React.KeyboardEventHandler<HTMLInputElement> = (event) => {
+      if (event.code === 'Enter') {
+        calculateExpression();
+        inputRef.current?.focus();
+      } else if (event.code === 'Escape') {
+        inputRef.current?.select();
+      }
+    };
+
+    useEffect(() => {
+      setValue((valueSpecification.values[0] as number).toString());
+    }, [valueSpecification]);
+
+    useEffect(() => {
+      if (
+        !isNaN(numericValue) &&
+        numericValue !== valueSpecification.values[0]
+      ) {
+        instanceValue_setValue(
+          valueSpecification,
+          numericValue,
+          0,
+          obseverContext,
+        );
+        setValueSpecification(valueSpecification);
+      }
+    }, [
+      numericValue,
+      valueSpecification,
+      setValueSpecification,
+      obseverContext,
+    ]);
+
     return (
       <div className={clsx('value-spec-editor', className)}>
-        <input
-          className="panel__content__form__section__input value-spec-editor__input"
-          spellCheck={false}
-          type="number"
-          value={value}
-          onChange={changeValue}
-        />
+        <div className="value-spec-editor__number__input-container">
+          <input
+            ref={inputRef}
+            className="panel__content__form__section__input value-spec-editor__input value-spec-editor__number__input"
+            spellCheck={false}
+            type="text" // NOTE: we leave this as text so that we can support expression evaluation
+            inputMode="numeric"
+            value={value}
+            onChange={changeValue}
+            onBlur={calculateExpression}
+            onKeyDown={onKeyDown}
+          />
+          <div className="value-spec-editor__number__actions">
+            <button
+              className="value-spec-editor__number__action"
+              title="Evaluate Expression (Enter)"
+              onClick={calculateExpression}
+            >
+              <CalculateIcon />
+            </button>
+          </div>
+        </div>
         <button
           className="value-spec-editor__reset-btn"
           title="Reset"
@@ -399,9 +484,15 @@ const EnumValueInstanceValueEditor = observer(
     className?: string | undefined;
     setValueSpecification: (val: ValueSpecification) => void;
     resetValue: () => void;
+    obseverContext: ObserverContext;
   }) => {
-    const { valueSpecification, className, resetValue, setValueSpecification } =
-      props;
+    const {
+      valueSpecification,
+      className,
+      resetValue,
+      setValueSpecification,
+      obseverContext,
+    } = props;
     const enumValueRef = guaranteeNonNullable(valueSpecification.values[0]);
     const enumValue = enumValueRef.value;
     const options = enumValue._OWNER.values.map((value) => ({
@@ -413,6 +504,7 @@ const EnumValueInstanceValueEditor = observer(
         valueSpecification,
         EnumValueExplicitReference.create(val.value),
         0,
+        obseverContext,
       );
       setValueSpecification(valueSpecification);
     };
@@ -466,9 +558,10 @@ const setCollectionValue = (
   valueSpecification: CollectionInstanceValue,
   expectedType: Type,
   value: string,
+  obseverContext: ObserverContext,
 ): void => {
   if (value.trim().length === 0) {
-    instanceValue_setValues(valueSpecification, []);
+    instanceValue_setValues(valueSpecification, [], obseverContext);
     return;
   }
   let result: unknown[] = [];
@@ -489,7 +582,11 @@ const setCollectionValue = (
                 new GenericType(expectedType),
               ),
             );
-            instanceValue_setValues(primitiveInstanceValue, [item.toString()]);
+            instanceValue_setValues(
+              primitiveInstanceValue,
+              [item.toString()],
+              obseverContext,
+            );
             return primitiveInstanceValue;
           })
           .filter(isNonNullable);
@@ -510,7 +607,11 @@ const setCollectionValue = (
                 new GenericType(expectedType),
               ),
             );
-            instanceValue_setValues(primitiveInstanceValue, [item]);
+            instanceValue_setValues(
+              primitiveInstanceValue,
+              [item],
+              obseverContext,
+            );
             return primitiveInstanceValue;
           })
           .filter(isNonNullable);
@@ -532,14 +633,16 @@ const setCollectionValue = (
         const enumValueInstanceValue = new EnumValueInstanceValue(
           GenericTypeExplicitReference.create(new GenericType(expectedType)),
         );
-        instanceValue_setValues(enumValueInstanceValue, [
-          EnumValueExplicitReference.create(_enum),
-        ]);
+        instanceValue_setValues(
+          enumValueInstanceValue,
+          [EnumValueExplicitReference.create(_enum)],
+          obseverContext,
+        );
         return enumValueInstanceValue;
       })
       .filter(isNonNullable);
   }
-  instanceValue_setValues(valueSpecification, result);
+  instanceValue_setValues(valueSpecification, result, obseverContext);
 };
 
 const COLLECTION_PREVIEW_CHAR_LIMIT = 50;
@@ -552,6 +655,7 @@ const CollectionValueInstanceValueEditor = observer(
     className?: string | undefined;
     resetValue: () => void;
     setValueSpecification: (val: ValueSpecification) => void;
+    obseverContext: ObserverContext;
   }) => {
     const {
       valueSpecification,
@@ -559,6 +663,7 @@ const CollectionValueInstanceValueEditor = observer(
       className,
       resetValue,
       setValueSpecification,
+      obseverContext,
     } = props;
     const inputRef = useRef<HTMLInputElement>(null);
     const [text, setText] = useState(stringifyValue(valueSpecification.values));
@@ -583,7 +688,12 @@ const CollectionValueInstanceValueEditor = observer(
     const saveEdit = (): void => {
       setEditable(false);
       setShowAdvancedEditorPopover(false);
-      setCollectionValue(valueSpecification, expectedType, text);
+      setCollectionValue(
+        valueSpecification,
+        expectedType,
+        text,
+        obseverContext,
+      );
       setText(stringifyValue(valueSpecification.values));
       setValueSpecification(valueSpecification);
     };
@@ -779,6 +889,7 @@ export const BasicValueSpecificationEditor: React.FC<{
             className={className}
             resetValue={resetValue}
             selectorConfig={selectorConfig}
+            obseverContext={obseverContext}
           />
         );
       case PRIMITIVE_TYPE.BOOLEAN:
@@ -788,6 +899,7 @@ export const BasicValueSpecificationEditor: React.FC<{
             setValueSpecification={setValueSpecification}
             className={className}
             resetValue={resetValue}
+            obseverContext={obseverContext}
           />
         );
       case PRIMITIVE_TYPE.NUMBER:
@@ -802,6 +914,7 @@ export const BasicValueSpecificationEditor: React.FC<{
             setValueSpecification={setValueSpecification}
             className={className}
             resetValue={resetValue}
+            obseverContext={obseverContext}
           />
         );
       case PRIMITIVE_TYPE.DATE:
@@ -829,6 +942,7 @@ export const BasicValueSpecificationEditor: React.FC<{
         className={className}
         resetValue={resetValue}
         setValueSpecification={setValueSpecification}
+        obseverContext={obseverContext}
       />
     );
   } else if (
@@ -846,6 +960,7 @@ export const BasicValueSpecificationEditor: React.FC<{
         className={className}
         resetValue={resetValue}
         setValueSpecification={setValueSpecification}
+        obseverContext={obseverContext}
       />
     );
   }
@@ -870,26 +985,55 @@ export const BasicValueSpecificationEditor: React.FC<{
         resetValue={resetValue}
       />
     );
-  } else if (
-    valueSpecification instanceof SimpleFunctionExpression &&
-    [
-      PRIMITIVE_TYPE.DATE.toString(),
-      PRIMITIVE_TYPE.STRICTDATE.toString(),
-      PRIMITIVE_TYPE.DATETIME.toString(),
-      PRIMITIVE_TYPE.LATESTDATE.toString(),
-    ].includes(typeCheckOption.expectedType.path)
-  ) {
-    return (
-      <DateInstanceValueEditor
-        valueSpecification={valueSpecification}
-        graph={graph}
-        obseverContext={obseverContext}
-        typeCheckOption={typeCheckOption}
-        className={className}
-        setValueSpecification={setValueSpecification}
-        resetValue={resetValue}
-      />
-    );
+  } else if (valueSpecification instanceof SimpleFunctionExpression) {
+    if (isSubType(typeCheckOption.expectedType, PrimitiveType.DATE)) {
+      return (
+        <DateInstanceValueEditor
+          valueSpecification={valueSpecification}
+          graph={graph}
+          obseverContext={obseverContext}
+          typeCheckOption={typeCheckOption}
+          className={className}
+          setValueSpecification={setValueSpecification}
+          resetValue={resetValue}
+        />
+      );
+    } else if (
+      // TODO: think of other ways we could make use of this code path where we can simplify
+      // an expression value to simple value, not just handling minus() function only
+      isSubType(typeCheckOption.expectedType, PrimitiveType.NUMBER) &&
+      matchFunctionName(
+        valueSpecification.functionName,
+        QUERY_BUILDER_SUPPORTED_FUNCTIONS.MINUS,
+      )
+    ) {
+      const simplifiedValue = simplifyValueExpression(
+        valueSpecification,
+        obseverContext,
+      );
+      if (
+        simplifiedValue instanceof PrimitiveInstanceValue &&
+        isSubType(
+          simplifiedValue.genericType.value.rawType,
+          PrimitiveType.NUMBER,
+        )
+      ) {
+        return (
+          <NumberPrimitiveInstanceValueEditor
+            valueSpecification={simplifiedValue}
+            isInteger={
+              simplifiedValue.genericType.value.rawType ===
+              PrimitiveType.INTEGER
+            }
+            setValueSpecification={setValueSpecification}
+            className={className}
+            resetValue={resetValue}
+            obseverContext={obseverContext}
+          />
+        );
+      }
+    }
   }
+
   return <UnsupportedValueSpecificationEditor />;
 };

package/src/components/shared/CustomDatePicker.tsx

@@ -258,16 +258,20 @@ const buildPureDateFunctionExpression = (
         new GenericType(graph.getType(DAY_OF_WEEK)),
       ),
     );
-    instanceValue_setValues(dayOfWeekEnumIntanceValue, [
-      ...dayOfWeekEnumIntanceValue.values,
-      EnumValueExplicitReference.create(
-        guaranteeNonNullable(
-          graph
-            .getEnumeration(DAY_OF_WEEK)
-            .values.filter((e) => e.name === datePickerOption.day)[0],
+    instanceValue_setValues(
+      dayOfWeekEnumIntanceValue,
+      [
+        ...dayOfWeekEnumIntanceValue.values,
+        EnumValueExplicitReference.create(
+          guaranteeNonNullable(
+            graph
+              .getEnumeration(DAY_OF_WEEK)
+              .values.filter((e) => e.name === datePickerOption.day)[0],
+          ),
         ),
-      ),
-    ]);
+      ],
+      observerContext,
+    );
     functionExpression_addParameterValue(
       previousFridaySFE,
       dayOfWeekEnumIntanceValue,
@@ -454,6 +458,7 @@ const buildPureAdjustDateFunction = (
         graph,
         PRIMITIVE_TYPE.INTEGER,
         customDateOption.duration,
+        observerContext,
       ),
       observerContext,
     );
@@ -463,14 +468,14 @@ const buildPureAdjustDateFunction = (
       observerContext,
     );
   } else {
-    const adjustmentInstanceValue = buildPrimitiveInstanceValue(
-      graph,
-      PRIMITIVE_TYPE.INTEGER,
-      customDateOption.duration,
-    );
     functionExpression_addParameterValue(
       dateAdjustSimpleFunctionExpression,
-      adjustmentInstanceValue,
+      buildPrimitiveInstanceValue(
+        graph,
+        PRIMITIVE_TYPE.INTEGER,
+        customDateOption.duration,
+        observerContext,
+      ),
       observerContext,
     );
   }
@@ -479,17 +484,21 @@ const buildPureAdjustDateFunction = (
       new GenericType(graph.getType(DURATION_UNIT)),
     ),
   );
-  instanceValue_setValues(durationUnitEnumIntanceValue, [
-    ...durationUnitEnumIntanceValue.values,
-    EnumValueExplicitReference.create(
-      guaranteeNonNullable(
-        buildPureDurationEnumValue(
-          guaranteeNonNullable(customDateOption.unit),
-          graph,
+  instanceValue_setValues(
+    durationUnitEnumIntanceValue,
+    [
+      ...durationUnitEnumIntanceValue.values,
+      EnumValueExplicitReference.create(
+        guaranteeNonNullable(
+          buildPureDurationEnumValue(
+            guaranteeNonNullable(customDateOption.unit),
+            graph,
+          ),
         ),
       ),
-    ),
-  ]);
+    ],
+    observerContext,
+  );
   functionExpression_addParameterValue(
     dateAdjustSimpleFunctionExpression,
     durationUnitEnumIntanceValue,
@@ -699,12 +708,14 @@ const AbsoluteDateValueSpecificationEditor: React.FC<{
   graph: PureModel;
   setValueSpecification: (val: ValueSpecification) => void;
   setDatePickerOption: (datePickerOption: DatePickerOption) => void;
+  observerContext: ObserverContext;
 }> = (props) => {
   const {
     valueSpecification,
     graph,
     setValueSpecification,
     setDatePickerOption,
+    observerContext,
   } = props;
   const inputRef = useRef<HTMLInputElement>(null);
   const absoluteDateValue =
@@ -720,10 +731,16 @@ const AbsoluteDateValueSpecificationEditor: React.FC<{
           graph,
           PRIMITIVE_TYPE.STRICTDATE,
           event.target.value,
+          observerContext,
         ),
       );
     } else if (valueSpecification instanceof InstanceValue) {
-      instanceValue_setValue(valueSpecification, event.target.value, 0);
+      instanceValue_setValue(
+        valueSpecification,
+        event.target.value,
+        0,
+        observerContext,
+      );
       if (
         valueSpecification.genericType.value.rawType.path !==
         PRIMITIVE_TYPE.STRICTDATE
@@ -768,12 +785,14 @@ const AbsoluteTimeValueSpecificationEditor: React.FC<{
   graph: PureModel;
   setValueSpecification: (val: ValueSpecification) => void;
   setDatePickerOption: (datePickerOption: DatePickerOption) => void;
+  observerContext: ObserverContext;
 }> = (props) => {
   const {
     valueSpecification,
     graph,
     setValueSpecification,
     setDatePickerOption,
+    observerContext,
   } = props;
   const inputRef = useRef<HTMLInputElement>(null);
   const absoluteTimeValue =
@@ -789,10 +808,16 @@ const AbsoluteTimeValueSpecificationEditor: React.FC<{
           graph,
           PRIMITIVE_TYPE.DATETIME,
           event.target.value,
+          observerContext,
         ),
       );
     } else {
-      instanceValue_setValue(valueSpecification, event.target.value, 0);
+      instanceValue_setValue(
+        valueSpecification,
+        event.target.value,
+        0,
+        observerContext,
+      );
       if (
         valueSpecification.genericType.value.rawType.path !==
         PRIMITIVE_TYPE.DATETIME
@@ -1213,6 +1238,7 @@ export const CustomDatePicker: React.FC<{
           graph,
           PRIMITIVE_TYPE.LATESTDATE,
           event.target.value,
+          observerContext,
         ),
       );
     } else if (
@@ -1255,6 +1281,7 @@ export const CustomDatePicker: React.FC<{
             valueSpecification={valueSpecification}
             setValueSpecification={setValueSpecification}
             setDatePickerOption={setDatePickerOption}
+            observerContext={observerContext}
           />
         );
       case CUSTOM_DATE_PICKER_OPTION.ABSOLUTE_TIME:
@@ -1264,6 +1291,7 @@ export const CustomDatePicker: React.FC<{
             valueSpecification={valueSpecification}
             setValueSpecification={setValueSpecification}
             setDatePickerOption={setDatePickerOption}
+            observerContext={observerContext}
           />
         );
       case CUSTOM_DATE_PICKER_OPTION.CUSTOM_DATE:

package/src/components/shared/LambdaEditor.tsx

@@ -584,7 +584,6 @@ const LambdaEditorPopUp = observer(
       >
         <Modal
           darkMode={true}
-          data-testid={QUERY_BUILDER_TEST_ID.LAMBDA_EDITOR__EDITOR_INPUT}
           className={clsx(
             'editor-modal lambda-editor__popup__modal',
             {

package/src/components/watermark/QueryBuilderWatermark.tsx

@@ -106,9 +106,7 @@ const WatermarkValueEditor = observer(
                 watermarkState.setValue(val);
               }}
               graph={graph}
-              obseverContext={
-                watermarkState.queryBuilderState.observableContext
-              }
+              obseverContext={watermarkState.queryBuilderState.observerContext}
               typeCheckOption={{
                 expectedType: PrimitiveType.STRING,
               }}

package/src/graphManager/QueryBuilderSupportedFunctions.ts

@@ -24,6 +24,7 @@ export enum QUERY_BUILDER_SUPPORTED_FUNCTIONS {
   OR = 'meta::pure::functions::boolean::or',
   TAKE = 'meta::pure::functions::collection::take',
   SUBTYPE = 'meta::pure::functions::lang::subType',
+  MINUS = 'meta::pure::functions::math::minus',
 
   // graph-fetch
   GRAPH_FETCH = 'meta::pure::graphFetch::execution::graphFetch',
@@ -53,6 +54,7 @@ export enum QUERY_BUILDER_SUPPORTED_FUNCTIONS {
   LESS_THAN = 'meta::pure::functions::lang::tests::lessThan',
   LESS_THAN_EQUAL = 'meta::pure::functions::lang::tests::lessThanEqual',
   STARTS_WITH = 'meta::pure::functions::string::startsWith',
+
   // aggregation
   AVERAGE = 'meta::pure::functions::math::average',
   COUNT = 'meta::pure::functions::collection::count',
@@ -66,8 +68,10 @@ export enum QUERY_BUILDER_SUPPORTED_FUNCTIONS {
   STD_DEV_SAMPLE = 'meta::pure::functions::math::stdDevSample',
   SUM = 'meta::pure::functions::math::sum',
   UNIQUE_VALUE_ONLY = 'meta::pure::functions::collection::uniqueValueOnly',
+
   // watermark
   WATERMARK = 'meta::datalake::functions::forWatermark',
+
   // OLAP
   OLAP_GROUPBY = 'meta::pure::tds::olapGroupBy',
   OLAP_RANK = 'meta::pure::functions::math::olap::rank',

package/src/graphManager/protocol/pure/QueryBuilder_PureProtocolProcessorPlugin.ts

@@ -57,7 +57,7 @@ export class QueryBuilder_PureProtocolProcessorPlugin extends PureProtocolProces
         openVariables: string[],
         compileContext: V1_GraphBuilderContext,
         processingContext: V1_ProcessingContext,
-      ): [SimpleFunctionExpression, ValueSpecification[]] | undefined => {
+      ): SimpleFunctionExpression | undefined => {
         if (
           matchFunctionName(
             functionName,