@finos/legend-graph 4.0.3 → 5.0.0

package/src/graph/PureModel.ts

@@ -25,38 +25,38 @@ import {
   guaranteeNonNullable,
   guaranteeType,
   returnUndefOnError,
-  getClass,
   IllegalStateError,
 } from '@finos/legend-shared';
 import { PrimitiveType } from '../models/metamodels/pure/packageableElements/domain/PrimitiveType';
 import { Enumeration } from '../models/metamodels/pure/packageableElements/domain/Enumeration';
 import { Multiplicity } from '../models/metamodels/pure/packageableElements/domain/Multiplicity';
-import { Association } from '../models/metamodels/pure/packageableElements/domain/Association';
+import type { Association } from '../models/metamodels/pure/packageableElements/domain/Association';
 import { Package } from '../models/metamodels/pure/packageableElements/domain/Package';
-import { Type } from '../models/metamodels/pure/packageableElements/domain/Type';
+import type { Type } from '../models/metamodels/pure/packageableElements/domain/Type';
 import { Class } from '../models/metamodels/pure/packageableElements/domain/Class';
-import { Mapping } from '../models/metamodels/pure/packageableElements/mapping/Mapping';
-import { Profile } from '../models/metamodels/pure/packageableElements/domain/Profile';
+import type { Mapping } from '../models/metamodels/pure/packageableElements/mapping/Mapping';
+import type { Profile } from '../models/metamodels/pure/packageableElements/domain/Profile';
 import type { Stereotype } from '../models/metamodels/pure/packageableElements/domain/Stereotype';
 import type { Tag } from '../models/metamodels/pure/packageableElements/domain/Tag';
 import type { PackageableElement } from '../models/metamodels/pure/packageableElements/PackageableElement';
-import { Store } from '../models/metamodels/pure/packageableElements/store/Store';
+import type { Store } from '../models/metamodels/pure/packageableElements/store/Store';
 import { DependencyManager } from '../graph/DependencyManager';
 import { ConcreteFunctionDefinition } from '../models/metamodels/pure/packageableElements/domain/ConcreteFunctionDefinition';
-import { Service } from '../models/metamodels/pure/packageableElements/service/Service';
+import type { Service } from '../models/metamodels/pure/packageableElements/service/Service';
 import { BasicModel } from './BasicModel';
 import { FlatData } from '../models/metamodels/pure/packageableElements/store/flatData/model/FlatData';
 import { Database } from '../models/metamodels/pure/packageableElements/store/relational/model/Database';
-import { PackageableConnection } from '../models/metamodels/pure/packageableElements/connection/PackageableConnection';
-import { PackageableRuntime } from '../models/metamodels/pure/packageableElements/runtime/PackageableRuntime';
-import { FileGenerationSpecification } from '../models/metamodels/pure/packageableElements/fileGeneration/FileGenerationSpecification';
+import type { PackageableConnection } from '../models/metamodels/pure/packageableElements/connection/PackageableConnection';
+import type { PackageableRuntime } from '../models/metamodels/pure/packageableElements/runtime/PackageableRuntime';
+import type { FileGenerationSpecification } from '../models/metamodels/pure/packageableElements/fileGeneration/FileGenerationSpecification';
 import { ModelStore } from '../models/metamodels/pure/packageableElements/store/modelToModel/model/ModelStore';
-import { GenerationSpecification } from '../models/metamodels/pure/packageableElements/generationSpecification/GenerationSpecification';
+import type { GenerationSpecification } from '../models/metamodels/pure/packageableElements/generationSpecification/GenerationSpecification';
 import {
   Measure,
   Unit,
 } from '../models/metamodels/pure/packageableElements/domain/Measure';
 import type { PureGraphPlugin } from './PureGraphPlugin';
+import { createPath } from '../MetaModelUtils';
 
 /**
  * CoreModel holds meta models which are constant and basic building block of the graph. Since throughout the lifetime
@@ -89,6 +89,10 @@ export class CoreModel extends BasicModel {
     this.setOwnStore(this.modelStore.path, this.modelStore);
   }
 
+  override get allOwnElements(): PackageableElement[] {
+    return [...super.allOwnElements, ...this.primitiveTypes];
+  }
+
   /**
    * NOTE: primitive types are special, they are not put in any package (i.e. they are not linked to `Root` package at all)
    */
@@ -171,8 +175,8 @@ export class GenerationModel extends BasicModel {
  * The model of Pure, a.k.a the Pure graph
  */
 export class PureModel extends BasicModel {
-  private coreModel: CoreModel;
-  systemModel: SystemModel;
+  private readonly coreModel: CoreModel;
+  readonly systemModel: SystemModel;
   generationModel: GenerationModel;
   dependencyManager: DependencyManager; // used to manage the elements from dependency projects
   graphPlugins: PureGraphPlugin[] = [];
@@ -197,7 +201,7 @@ export class PureModel extends BasicModel {
     return this.coreModel.modelStore;
   }
 
-  get sectionAutoImports(): Package[] {
+  get autoImports(): Package[] {
     return this.systemModel.autoImports;
   }
 
@@ -205,16 +209,16 @@ export class PureModel extends BasicModel {
     return this.coreModel.primitiveTypes;
   }
 
-  getPrimitiveType = (type: PRIMITIVE_TYPE): PrimitiveType =>
-    guaranteeNonNullable(
-      this.coreModel.primitiveTypesIndex.get(type),
-      `Can't find primitive type '${type}'`,
-    );
-  getElement = (path: string, includePackage?: boolean): PackageableElement =>
-    guaranteeNonNullable(
-      this.getNullableElement(path, includePackage),
-      `Can't find element '${path}'`,
-    );
+  get allElements(): PackageableElement[] {
+    return [
+      ...this.coreModel.allOwnElements,
+      ...this.systemModel.allOwnElements,
+      ...this.dependencyManager.allOwnElements,
+      ...this.allOwnElements,
+      ...this.generationModel.allOwnElements,
+    ];
+  }
+
   getProfileStereotype = (
     path: string,
     value: string,
@@ -229,21 +233,27 @@ export class PureModel extends BasicModel {
     path: string,
   ): FileGenerationSpecification | undefined =>
     returnUndefOnError(() => this.getFileGeneration(path));
+
+  getPrimitiveType = (type: PRIMITIVE_TYPE): PrimitiveType =>
+    guaranteeNonNullable(
+      this.coreModel.primitiveTypesIndex.get(type),
+      `Can't find primitive type '${type}'`,
+    );
   getType = (path: string): Type =>
     guaranteeNonNullable(
-      this.getOwnType(path) ??
-        this.generationModel.getOwnType(path) ??
-        this.dependencyManager.getOwnType(path) ??
-        this.systemModel.getOwnType(path) ??
-        this.coreModel.getOwnType(path),
+      this.getOwnNullableType(path) ??
+        this.generationModel.getOwnNullableType(path) ??
+        this.dependencyManager.getOwnNullableType(path) ??
+        this.systemModel.getOwnNullableType(path) ??
+        this.coreModel.getOwnNullableType(path),
       `Can't find type '${path}'`,
     );
   getProfile = (path: string): Profile =>
     guaranteeNonNullable(
-      this.getOwnProfile(path) ??
-        this.generationModel.getOwnProfile(path) ??
-        this.dependencyManager.getOwnProfile(path) ??
-        this.systemModel.getOwnProfile(path),
+      this.getOwnNullableProfile(path) ??
+        this.generationModel.getOwnNullableProfile(path) ??
+        this.dependencyManager.getOwnNullableProfile(path) ??
+        this.systemModel.getOwnNullableProfile(path),
       `Can't find profile '${path}'`,
     );
   getEnumeration = (path: string): Enumeration =>
@@ -260,28 +270,28 @@ export class PureModel extends BasicModel {
     guaranteeType(this.getType(path), Class, `Can't find class '${path}'`);
   getAssociation = (path: string): Association =>
     guaranteeNonNullable(
-      this.getOwnAssociation(path) ??
-        this.generationModel.getOwnAssociation(path) ??
-        this.dependencyManager.getOwnAssociation(path) ??
-        this.systemModel.getOwnAssociation(path),
+      this.getOwnNullableAssociation(path) ??
+        this.generationModel.getOwnNullableAssociation(path) ??
+        this.dependencyManager.getOwnNullableAssociation(path) ??
+        this.systemModel.getOwnNullableAssociation(path),
       `Can't find association '${path}'`,
     );
   getFunction = (path: string): ConcreteFunctionDefinition =>
     guaranteeType(
-      this.getOwnFunction(path) ??
-        this.generationModel.getOwnFunction(path) ??
-        this.dependencyManager.getOwnFunction(path) ??
-        this.systemModel.getOwnFunction(path),
+      this.getOwnNullableFunction(path) ??
+        this.generationModel.getOwnNullableFunction(path) ??
+        this.dependencyManager.getOwnNullableFunction(path) ??
+        this.systemModel.getOwnNullableFunction(path),
       ConcreteFunctionDefinition,
       `Can't find function '${path}'`,
     );
   getStore = (path: string): Store =>
     guaranteeNonNullable(
-      this.getOwnStore(path) ??
-        this.generationModel.getOwnStore(path) ??
-        this.dependencyManager.getOwnStore(path) ??
-        this.systemModel.getOwnStore(path) ??
-        this.coreModel.getOwnStore(path),
+      this.getOwnNullableStore(path) ??
+        this.generationModel.getOwnNullableStore(path) ??
+        this.dependencyManager.getOwnNullableStore(path) ??
+        this.systemModel.getOwnNullableStore(path) ??
+        this.coreModel.getOwnNullableStore(path),
       `Can't find store '${path}'`,
     );
   getFlatDataStore = (path: string): FlatData =>
@@ -298,50 +308,50 @@ export class PureModel extends BasicModel {
     );
   getMapping = (path: string): Mapping =>
     guaranteeNonNullable(
-      this.getOwnMapping(path) ??
-        this.generationModel.getOwnMapping(path) ??
-        this.dependencyManager.getOwnMapping(path) ??
-        this.systemModel.getOwnMapping(path),
+      this.getOwnNullableMapping(path) ??
+        this.generationModel.getOwnNullableMapping(path) ??
+        this.dependencyManager.getOwnNullableMapping(path) ??
+        this.systemModel.getOwnNullableMapping(path),
       `Can't find mapping '${path}'`,
     );
   getService = (path: string): Service =>
     guaranteeNonNullable(
-      this.getOwnService(path) ??
-        this.generationModel.getOwnService(path) ??
-        this.dependencyManager.getOwnService(path) ??
-        this.systemModel.getOwnService(path),
+      this.getOwnNullableService(path) ??
+        this.generationModel.getOwnNullableService(path) ??
+        this.dependencyManager.getOwnNullableService(path) ??
+        this.systemModel.getOwnNullableService(path),
       `Can't find service '${path}'`,
     );
   getConnection = (path: string): PackageableConnection =>
     guaranteeNonNullable(
-      this.getOwnConnection(path) ??
-        this.generationModel.getOwnConnection(path) ??
-        this.dependencyManager.getOwnConnection(path) ??
-        this.systemModel.getOwnConnection(path),
+      this.getOwnNullableConnection(path) ??
+        this.generationModel.getOwnNullableConnection(path) ??
+        this.dependencyManager.getOwnNullableConnection(path) ??
+        this.systemModel.getOwnNullableConnection(path),
       `Can't find connection '${path}'`,
     );
   getRuntime = (path: string): PackageableRuntime =>
     guaranteeNonNullable(
-      this.getOwnRuntime(path) ??
-        this.generationModel.getOwnRuntime(path) ??
-        this.dependencyManager.getOwnRuntime(path) ??
-        this.systemModel.getOwnRuntime(path),
+      this.getOwnNullableRuntime(path) ??
+        this.generationModel.getOwnNullableRuntime(path) ??
+        this.dependencyManager.getOwnNullableRuntime(path) ??
+        this.systemModel.getOwnNullableRuntime(path),
       `Can't find runtime '${path}'`,
     );
   getGenerationSpecification = (path: string): GenerationSpecification =>
     guaranteeNonNullable(
-      this.getOwnGenerationSpecification(path) ??
-        this.generationModel.getOwnGenerationSpecification(path) ??
-        this.dependencyManager.getOwnGenerationSpecification(path) ??
-        this.systemModel.getOwnGenerationSpecification(path),
+      this.getOwnNullableGenerationSpecification(path) ??
+        this.generationModel.getOwnNullableGenerationSpecification(path) ??
+        this.dependencyManager.getOwnNullableGenerationSpecification(path) ??
+        this.systemModel.getOwnNullableGenerationSpecification(path),
       `Can't find generation specification '${path}'`,
     );
   getFileGeneration = (path: string): FileGenerationSpecification =>
     guaranteeNonNullable(
-      this.getOwnFileGeneration(path) ??
-        this.generationModel.getOwnFileGeneration(path) ??
-        this.dependencyManager.getOwnFileGeneration(path) ??
-        this.systemModel.getOwnFileGeneration(path),
+      this.getOwnNullableFileGeneration(path) ??
+        this.generationModel.getOwnNullableFileGeneration(path) ??
+        this.dependencyManager.getOwnNullableFileGeneration(path) ??
+        this.systemModel.getOwnNullableFileGeneration(path),
       `Can't find file generation '${path}'`,
     );
 
@@ -352,19 +362,27 @@ export class PureModel extends BasicModel {
   ): T {
     // NOTE: beware that this method will favor main graph elements over those of subgraphs when resolving
     return guaranteeNonNullable(
-      this.getOwnExtensionElement(path, extensionElementClass) ??
-        this.generationModel.getOwnExtensionElement(
+      this.getOwnNullableExtensionElement(path, extensionElementClass) ??
+        this.generationModel.getOwnNullableExtensionElement(
           path,
           extensionElementClass,
         ) ??
-        this.dependencyManager.getOwnExtensionElement(
+        this.dependencyManager.getOwnNullableExtensionElement(
           path,
           extensionElementClass,
         ) ??
-        this.systemModel.getOwnExtensionElement(path, extensionElementClass),
+        this.systemModel.getOwnNullableExtensionElement(
+          path,
+          extensionElementClass,
+        ),
       notFoundErrorMessage ?? `Can't find element '${path}'`,
     );
   }
+  getElement = (path: string, includePackage?: boolean): PackageableElement =>
+    guaranteeNonNullable(
+      this.getNullableElement(path, includePackage),
+      `Can't find element '${path}'`,
+    );
 
   getNullableElement(
     path: string,
@@ -424,43 +442,21 @@ export class PureModel extends BasicModel {
     return multiplicity ?? new Multiplicity(lowerBound, upperBound);
   }
 
-  addElement(element: PackageableElement): void {
-    const existingElement = this.getNullableElement(element.path);
+  addElement(
+    element: PackageableElement,
+    packagePath: string | undefined,
+  ): void {
+    const fullPath = createPath(packagePath ?? '', element.name);
+
+    // check for duplication first, but skip package
+    const existingElement = this.getNullableElement(fullPath, false);
     if (existingElement) {
       throw new IllegalStateError(
-        `Can't create element '${element.path}': another element with the same path already existed`,
+        `Can't create element '${fullPath}': another element with the same path already existed`,
       );
     }
-    if (element instanceof Mapping) {
-      this.setOwnMapping(element.path, element);
-    } else if (element instanceof Store) {
-      this.setOwnStore(element.path, element);
-    } else if (element instanceof Type) {
-      this.setOwnType(element.path, element);
-    } else if (element instanceof Association) {
-      this.setOwnAssociation(element.path, element);
-    } else if (element instanceof Profile) {
-      this.setOwnProfile(element.path, element);
-    } else if (element instanceof ConcreteFunctionDefinition) {
-      this.setOwnFunction(element.path, element);
-    } else if (element instanceof Service) {
-      this.setOwnService(element.path, element);
-    } else if (element instanceof PackageableConnection) {
-      this.setOwnConnection(element.path, element);
-    } else if (element instanceof PackageableRuntime) {
-      this.setOwnRuntime(element.path, element);
-    } else if (element instanceof FileGenerationSpecification) {
-      this.setOwnFileGeneration(element.path, element);
-    } else if (element instanceof GenerationSpecification) {
-      this.setOwnGenerationSpecification(element.path, element);
-    } else if (element instanceof Package) {
-      // do nothing
-    } else {
-      const extension = this.getExtensionForElementClass(
-        getClass<PackageableElement>(element),
-      );
-      extension.setElement(element.path, element);
-    }
+
+    super.addOwnElement(element, packagePath);
   }
 
   deleteElement(element: PackageableElement): void {
@@ -476,7 +472,8 @@ export class PureModel extends BasicModel {
   }
 
   renameElement(element: PackageableElement, newPath: string): void {
-    const existingElement = this.getNullableElement(newPath);
+    // check for duplication first, but skip package
+    const existingElement = this.getNullableElement(newPath, false);
     if (existingElement) {
       throw new IllegalStateError(
         `Can't rename element '${element.path}' to '${newPath}': another element with the same path already existed`,

package/src/graphManager/AbstractPureGraphManager.ts

@@ -72,10 +72,11 @@ export interface TEMPORARY__EngineSetupConfig {
 }
 
 export interface GraphBuilderOptions {
-  // the `keepSectionIndex` flag is kept until we have stable support and enable usage of section index.
-  TEMPORARY__keepSectionIndex?: boolean;
-  // when we change our handling of section index, we should be able to get rid of this flag.
-  TEMPORARY__disableRawLambdaResolver?: boolean;
+  /**
+   * This flag will be kept until we have full support for section index
+   * See https://github.com/finos/legend-studio/issues/1067
+   */
+  TEMPORARY__preserveSectionIndex?: boolean;
 }
 
 export interface ExecutionOptions {
@@ -393,9 +394,10 @@ export abstract class AbstractPureGraphManager {
   // As the name suggested, these methods are temporary hacks since we don't handle value-specification
   // structurally in Studio
 
-  abstract HACKY_createGetAllLambda(_class: Class): RawLambda;
-  abstract HACKY_createServiceTestAssertLambda(assertData: string): RawLambda;
-  abstract HACKY_extractServiceTestAssertionData(
+  abstract HACKY__createGetAllLambda(_class: Class): RawLambda;
+  abstract HACKY__createServiceTestAssertLambda(assertData: string): RawLambda;
+  abstract HACKY__extractServiceTestAssertionData(
     query: RawLambda,
   ): string | undefined;
+  abstract HACKY__createDefaultBlankLambda(): RawLambda;
 }

package/src/graphManager/DSLExternalFormat_GraphManagerHelper.ts

@@ -14,17 +14,27 @@
  * limitations under the License.
  */
 
-import { guaranteeType } from '@finos/legend-shared';
+import { guaranteeNonNullable, guaranteeType } from '@finos/legend-shared';
+import type { BasicModel } from '../graph/BasicModel';
 import type { PureModel } from '../graph/PureModel';
 import { SchemaSet } from '../models/metamodels/pure/packageableElements/externalFormat/schemaSet/DSLExternalFormat_SchemaSet';
 import { Binding } from '../models/metamodels/pure/packageableElements/externalFormat/store/DSLExternalFormat_Binding';
 
 export const getSchemaSet = (path: string, graph: PureModel): SchemaSet =>
-  graph.getExtensionElement(
-    path,
-    SchemaSet,
-    `Can't find schema set element '${path}'`,
+  graph.getExtensionElement(path, SchemaSet, `Can't find schema set '${path}'`);
+
+export const getOwnSchemaSet = (path: string, graph: BasicModel): SchemaSet =>
+  guaranteeNonNullable(
+    graph.getOwnNullableExtensionElement(path, SchemaSet),
+    `Can't find schema set '${path}'`,
   );
 
 export const getBinding = (path: string, graph: PureModel): Binding =>
   guaranteeType(graph.getStore(path), Binding, `Can't find binding '${path}'`);
+
+export const getOwnBinding = (path: string, graph: BasicModel): Binding =>
+  guaranteeType(
+    graph.getOwnNullableStore(path),
+    Binding,
+    `Can't find binding '${path}'`,
+  );

package/src/graphManager/PureGraphManagerPlugin.ts

@@ -34,6 +34,10 @@ export type ElementObserver = (
 ) => PackageableElement | undefined;
 
 export abstract class PureGraphManagerPlugin extends AbstractPlugin {
+  /**
+   * This helps to better type-checking for this empty abtract type
+   * See https://github.com/finos/legend-studio/blob/master/docs/technical/typescript-usage.md#understand-typescript-structual-type-system
+   */
   private readonly _$nominalTypeBrand!: 'PureGraphManagerPlugin';
 
   install(pluginManager: GraphPluginManager): void {

package/src/graphManager/action/TEMPORARY__AbstractEngineConfig.ts

@@ -18,6 +18,10 @@ import { action, makeObservable, observable } from 'mobx';
 
 const DEFAULT_TAB_SIZE = 2;
 
+/**
+ * When we make application config generic, we can probably remove this
+ * See https://github.com/finos/legend-studio/issues/407
+ */
 export class TEMPORARY__AbstractEngineConfig {
   env?: string | undefined;
   tabSize = DEFAULT_TAB_SIZE;

package/src/graphManager/action/changeDetection/DSLMapping_ObserverHelper.ts

@@ -49,11 +49,11 @@ import type {
 import type {
   SetImplementation,
   SetImplementationVisitor,
-  TEMPORARY__UnresolvedSetImplementation,
 } from '../../../models/metamodels/pure/packageableElements/mapping/SetImplementation';
 import type { SetImplementationContainer } from '../../../models/metamodels/pure/packageableElements/mapping/SetImplementationContainer';
 import type { SetImplementationReference } from '../../../models/metamodels/pure/packageableElements/mapping/SetImplementationReference';
 import type { SubstituteStore } from '../../../models/metamodels/pure/packageableElements/mapping/SubstituteStore';
+import type { TEMPORARY__UnresolvedSetImplementation } from '../../../models/metamodels/pure/packageableElements/mapping/TEMPORARY__UnresolvedSetImplementation';
 import type { XStorePropertyMapping } from '../../../models/metamodels/pure/packageableElements/mapping/xStore/XStorePropertyMapping';
 import type { PackageableRuntime } from '../../../models/metamodels/pure/packageableElements/runtime/PackageableRuntime';
 import {
@@ -280,8 +280,6 @@ const observe_Abstract_SetImplementation = (
 ): void => {
   makeObservable(metamodel, {
     root: observable,
-    parent: observable,
-    label: computed,
   });
 
   observe_PackageableElementReference(metamodel.class);
@@ -565,7 +563,6 @@ export const observe_EnumerationMapping = skipObserved(
     makeObservable(metamodel, {
       sourceType: observable,
       enumValueMappings: observable,
-      label: computed,
       isStub: computed,
       hashCode: computed,
     });
@@ -586,10 +583,8 @@ export const observe_AssociationImplementation = skipObservedWithContext(
   ): AssociationImplementation => {
     makeObservable(metamodel, {
       id: observable,
-      parent: observable,
       stores: observable,
       propertyMappings: observable,
-      label: computed,
       hashCode: computed,
     });
 

package/src/graphManager/action/changeDetection/DomainObserverHelper.ts

@@ -14,6 +14,7 @@
  * limitations under the License.
  */
 
+import { promisify } from '@finos/legend-shared';
 import {
   computed,
   isObservable,
@@ -60,7 +61,7 @@ import {
   skipObservedWithContext,
   type ObserverContext,
 } from './CoreObserverHelper';
-import { observe_PackageabElement } from './PackageableElementObserver';
+import { observe_PackageableElement } from './PackageableElementObserver';
 import {
   observe_RawLambda,
   observe_RawVariableExpression,
@@ -87,7 +88,7 @@ export const observe_Package = skipObservedWithContext(
       if (child instanceof Package) {
         observe_Package(child, context);
       } else {
-        observe_PackageabElement(child, context);
+        observe_PackageableElement(child, context);
       }
     });
 
@@ -110,7 +111,7 @@ export const observe_PackageTree = async (
       if (child instanceof Package) {
         await observe_PackageTree(child, context);
       } else {
-        observe_PackageabElement(child, context);
+        await promisify(() => observe_PackageableElement(child, context));
       }
     }),
   );
@@ -184,7 +185,6 @@ export const observe_GenericTypeReference = skipObserved(
 
 export const observe_Section = skipObserved((metamodel: Section): Section => {
   makeObservable(metamodel, {
-    parent: observable,
     parserName: observable,
     elements: observable,
   });

package/src/graphManager/action/changeDetection/GraphObserverHelper.ts

@@ -73,7 +73,6 @@ const observe_Abstract_BasicModel = async (
     ownProfiles: computed,
     ownEnumerations: computed,
     ownMeasures: computed,
-    ownUnits: computed,
     ownClasses: computed,
     ownTypes: computed,
     ownAssociations: computed,
@@ -107,12 +106,11 @@ export const observe_DependencyManager = skipObserved(
     makeObservable(metamodel, {
       root: observable,
       projectDependencyModelsIndex: observable,
-      allElements: computed,
-      models: computed,
+      allOwnElements: computed,
+      dependencyGraphs: computed,
       profiles: computed,
       enumerations: computed,
       measures: computed,
-      units: computed,
       classes: computed,
       types: computed,
       associations: computed,
@@ -129,7 +127,7 @@ export const observe_DependencyManager = skipObserved(
     }),
 );
 
-export const observe_PureModel = async (
+export const observe_Graph = async (
   metamodel: PureModel,
   context: ObserverContext,
 ): Promise<PureModel> => {

package/src/graphManager/action/changeDetection/PackageableElementObserver.ts

@@ -152,7 +152,7 @@ class PackageableElementObserver implements PackageableElementVisitor<void> {
   }
 }
 
-export const observe_PackageabElement = skipObservedWithContext(
+export const observe_PackageableElement = skipObservedWithContext(
   (
     packageableElement: PackageableElement,
     context: ObserverContext,

package/src/graphManager/action/changeDetection/RawValueSpecificationObserver.ts

@@ -15,7 +15,7 @@
  */
 
 import { computed, makeObservable, observable } from 'mobx';
-import type { RawInstanceValue } from '../../../models/metamodels/pure/rawValueSpecification/RawInstanceValue';
+import type { RawPrimitiveInstanceValue } from '../../../models/metamodels/pure/rawValueSpecification/RawPrimitiveInstanceValue';
 import type { RawLambda } from '../../../models/metamodels/pure/rawValueSpecification/RawLambda';
 import type {
   RawValueSpecification,
@@ -30,12 +30,13 @@ import {
   type ObserverContext,
 } from './CoreObserverHelper';
 
-export const observe_RawInstanceValue = skipObserved(
-  (metamodel: RawInstanceValue): RawInstanceValue => {
+export const observe_RawPrimitiveInstanceValue = skipObserved(
+  (metamodel: RawPrimitiveInstanceValue): RawPrimitiveInstanceValue => {
     makeObservable(metamodel, {
       multiplicity: observable,
-      // TODO: check if we need this
-      // values: observable.ref,
+      // NOTE: we're being defensive here, technically, since the values
+      // are all of primitive types, it's safe to just use `observable`
+      values: observable.shallow,
       hashCode: computed,
     });
 
@@ -89,8 +90,10 @@ class RawValueSpecificationObserver
     observe_RawVariableExpression(valueSpecification);
   }
 
-  visit_RawInstanceValue(valueSpecification: RawInstanceValue): void {
-    observe_RawInstanceValue(valueSpecification);
+  visit_RawPrimitiveInstanceValue(
+    valueSpecification: RawPrimitiveInstanceValue,
+  ): void {
+    observe_RawPrimitiveInstanceValue(valueSpecification);
   }
 }