@finos/legend-graph 32.6.3 → 32.6.5

package/src/graph-manager/protocol/pure/v1/V1_PureGraphManager.ts

@@ -2150,14 +2150,14 @@ export class V1_PureGraphManager extends AbstractPureGraphManager {
 
   //
 
-  override createAccessorFromPackageableElement(
+  override async createAccessorFromPackageableElement(
     element: PackageableElement,
     graph: PureModel,
     options?: {
       schemaName?: string | undefined;
       tableName?: string | undefined;
     },
-  ): Accessor | undefined {
+  ): Promise<Accessor | undefined> {
     if (
       !(element instanceof IngestDefinition) &&
       !(element instanceof Database)
@@ -2170,7 +2170,12 @@ export class V1_PureGraphManager extends AbstractPureGraphManager {
       this.graphBuilderExtensions,
       this.logService,
     ).build();
-    return V1_createAccessorFromPackageableElement(element, context, options);
+    return V1_createAccessorFromPackageableElement(
+      element,
+      context,
+      this,
+      options,
+    );
   }
 
   override async buildDataProductAccessor(

package/src/graph-manager/protocol/pure/v1/helpers/V1_AccessorHelper.ts

@@ -51,6 +51,7 @@ import { V1_deserializeIngestDefinitionContent } from '../transformation/purePro
 import {
   RelationElement,
   RelationElementsData,
+  RelationRowTestData,
 } from '../../../../../graph/metamodel/pure/data/EmbeddedData.js';
 import type { RawLambda } from '../../../../../graph/metamodel/pure/rawValueSpecification/RawLambda.js';
 import type { AbstractPureGraphManager } from '../../../../AbstractPureGraphManager.js';
@@ -229,7 +230,7 @@ export const V1_buildRelationTypeFromAccessPointImplementation = (
  * For IngestDefinition: requires `datasetName` to identify the dataset.
  * For Database: requires `schemaName` and `tableName` to identify the table.
  */
-export const V1_createAccessorFromPackageableElement = (
+export const V1_createAccessorFromPackageableElementWithNonFunctionSources = (
   element: AccessorOwner,
   context: V1_GraphBuilderContext,
   options?: {
@@ -238,6 +239,7 @@ export const V1_createAccessorFromPackageableElement = (
   },
 ): Accessor | undefined => {
   if (element instanceof IngestDefinition) {
+    const datasetName = options?.tableName;
     const content = returnUndefOnError(() =>
       V1_deserializeIngestDefinitionContent(element.content),
     );
@@ -245,7 +247,6 @@ export const V1_createAccessorFromPackageableElement = (
     if (!content) {
       return undefined;
     }
-    const datasetName = options?.tableName;
     const dataset = datasetName
       ? content.datasets?.find((ds) => ds.name === datasetName)
       : content.datasets?.[0];
@@ -312,6 +313,67 @@ const buildRelationTypeFromMetadata = (
   return relationType;
 };
 
+export const V1_createAccessorFromPackageableElement = async (
+  element: AccessorOwner,
+  context: V1_GraphBuilderContext,
+  graphManager: AbstractPureGraphManager,
+  options?: {
+    schemaName?: string | undefined;
+    tableName?: string | undefined;
+  },
+): Promise<Accessor | undefined> => {
+  if (element instanceof IngestDefinition) {
+    const datasetName = options?.tableName;
+    const content = returnUndefOnError(() =>
+      V1_deserializeIngestDefinitionContent(element.content),
+    );
+    let matviewDataSet;
+    if (datasetName) {
+      matviewDataSet = element.TEMPORARY_MATVIEW_FUNCTION_DATA_SETS?.find(
+        (ds) => ds.name === datasetName,
+      );
+    } else if (element.TEMPORARY_MATVIEW_FUNCTION_DATA_SETS?.length) {
+      // Prefer non-matview datasets - only use matview if no non-matview dataset exists
+      const matviewNames = new Set(
+        element.TEMPORARY_MATVIEW_FUNCTION_DATA_SETS.map((ds) => ds.name),
+      );
+      const hasNonMatviewDataset = content?.datasets?.some(
+        (ds) => !matviewNames.has(ds.name),
+      );
+      matviewDataSet = hasNonMatviewDataset
+        ? undefined
+        : element.TEMPORARY_MATVIEW_FUNCTION_DATA_SETS[0];
+    }
+    if (matviewDataSet) {
+      const relationTypeMetadata = await graphManager.getLambdaRelationType(
+        matviewDataSet.source.function,
+        context.graph,
+      );
+      const relationType = buildRelationTypeFromMetadata(
+        relationTypeMetadata,
+        context,
+      );
+      addMilestonedColumnsForWriteMode(
+        relationType,
+        content?.writeMode,
+        context,
+      );
+      return new IngestionAccessor(
+        element.path,
+        undefined,
+        matviewDataSet.name,
+        relationType,
+        element,
+      );
+    }
+  }
+  return V1_createAccessorFromPackageableElementWithNonFunctionSources(
+    element,
+    context,
+    options,
+  );
+};
+
 export const V1_buildDataProductAccessor = async (
   element: DataProduct,
   context: V1_GraphBuilderContext,
@@ -457,7 +519,9 @@ export const V1_buildRelationElementsDataFromAccessors = (
     relationElement.columns = accessor.relationType.columns.map(
       (column) => column.name,
     );
-    relationElement.rows = [];
+    const row = new RelationRowTestData();
+    row.values = relationElement.columns.map(() => '');
+    relationElement.rows = [row];
     return relationElement;
   });
   return relationElementsData;

package/src/graph-manager/protocol/pure/v1/transformation/pureGraph/to/helpers/V1_ValueSpecificationBuilderHelper.ts

@@ -135,9 +135,9 @@ import {
   DataProduct,
   LakehouseAccessPoint,
 } from '../../../../../../../../graph/metamodel/pure/dataProduct/DataProduct.js';
-import { V1_createAccessorFromPackageableElement } from '../../../../helpers/V1_AccessorHelper.js';
 import { Database } from '../../../../../../../../graph/metamodel/pure/packageableElements/store/relational/model/Database.js';
 import { IngestDefinition } from '../../../../../../../../graph/metamodel/pure/packageableElements/ingest/IngestDefinition.js';
+import { V1_createAccessorFromPackageableElementWithNonFunctionSources } from '../../../../helpers/V1_AccessorHelper.js';
 
 const buildPrimtiveInstanceValue = (
   type: PRIMITIVE_TYPE,
@@ -562,10 +562,14 @@ export class V1_ValueSpecificationBuilder
           Database,
         );
         const accessor = guaranteeNonNullable(
-          V1_createAccessorFromPackageableElement(db, this.context, {
-            schemaName,
-            tableName,
-          }),
+          V1_createAccessorFromPackageableElementWithNonFunctionSources(
+            db,
+            this.context,
+            {
+              schemaName,
+              tableName,
+            },
+          ),
           `Can't build accessor for database '${dbPath}'`,
         );
         const accessorInstanceValue = new AccessorInstanceValue();
@@ -587,9 +591,13 @@ export class V1_ValueSpecificationBuilder
           IngestDefinition,
         );
         const accessor = guaranteeNonNullable(
-          V1_createAccessorFromPackageableElement(ingestDef, this.context, {
-            tableName: datasetName,
-          }),
+          V1_createAccessorFromPackageableElementWithNonFunctionSources(
+            ingestDef,
+            this.context,
+            {
+              tableName: datasetName,
+            },
+          ),
           `Can't build accessor for ingest definition '${ingestPath}'`,
         );
         const accessorInstanceValue = new AccessorInstanceValue();

package/src/index.ts

@@ -888,6 +888,7 @@ export {
 } from './graph/metamodel/pure/packageableElements/relation/Accessor.js';
 export {
   V1_createAccessorFromPackageableElement,
+  V1_createAccessorFromPackageableElementWithNonFunctionSources,
   V1_resolveAccessorsFromRawLambda,
   V1_buildRelationElementsDataFromAccessors,
   V1_buildRelationTypeFromAccessPointImplementation,